Review Request 47711: Added more verbose message when mesos command encouter error.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47711/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-5438
https://issues.apache.org/jira/browse/MESOS-5438


Repository: mesos


Description
---

Added more verbose message when mesos command encouter error.
This is mainly for adding exception info to error log
when using to mesos-xx get state info.


Diffs
-

  src/cli/mesos-cat ddc5a26d0a4618e9e032b4fcc75a230e49b7a2c5 
  src/cli/mesos-scp f305abdc3bc0e4f357a5df90764a39ab55f46e86 
  src/cli/mesos-tail 031ee251fde3b230c14d9ee0f0de68caa04d6595 

Diff: https://reviews.apache.org/r/47711/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

[Qian Zhang]

> On May 17, 2016, 9:27 p.m., haosdent huang wrote:
> > src/Makefile.am, line 2048
> > 
> >
> > I think you forgot to update the CMake build files.

I see all the tests are not included in `src/CMakeLists.txt`, so it seem CMake 
build has not enabled tests yet?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46097/#review133530
---


On May 12, 2016, 4:11 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46097/
> ---
> 
> (Updated May 12, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5167
> https://issues.apache.org/jira/browse/MESOS-5167
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd 
>   src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46097/diff/
> 
> 
> Testing
> ---
> 
> [ RUN  ] CniIsolatorTest.ROOT_LaunchCommandTask
> + /home/stack/workspace/mesos/build/src/mesos-containerizer mount 
> --help=false --operation=make-rslave --path=/
> + grep+  -E /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_HRK4Dz/.+ 
> /proc/self/mountinfo
> + grepcut -v -d  -f5
>  d06b117d-518b-41e2-b8e0-62a12083773c
> + xargs --no-run-if-empty umount -l
> + mount -n --rbind 
> /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_HRK4Dz/provisioner/containers/d06b117d-518b-41e2-b8e0-62a12083773c/backends/copy/rootfses/7ea27011-cd3a-43b0-8301-b0b94d9f9b47
>  
> /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_HRK4Dz/slaves/18dea042-5bb5-4336-8bc8-358ed1fbf6dd-S0/frameworks/18dea042-5bb5-4336-8bc8-358ed1fbf6dd-/executors/60e6d35d-6d33-47ae-9c23-d2e5c913c892/runs/d06b117d-518b-41e2-b8e0-62a12083773c/.rootfs
> I0420 22:26:00.924844  9305 exec.cpp:150] Version: 0.29.0
> I0420 22:26:00.942319  9375 exec.cpp:225] Executor registered on agent 
> 18dea042-5bb5-4336-8bc8-358ed1fbf6dd-S0
> Registered executor on mesos
> Starting task 60e6d35d-6d33-47ae-9c23-d2e5c913c892
> Forked command at 9382
> sh -c 'ls /'
> bin  dev  etc  home lib  linuxrc  mediamnt  proc  
>root run  sbin sys  tmp  usr  var
> Command exited with status 0 (pid: 9382)
> I0420 22:26:01.098331  9380 exec.cpp:399] Executor asked to shutdown
> [   OK ] CniIsolatorTest.ROOT_LaunchCommandTask (42603 ms)
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 45967: Added documentation for shareable resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45967/
---

(Updated May 23, 2016, 5:03 a.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4325
https://issues.apache.org/jira/browse/MESOS-4325


Repository: mesos


Description
---

Added documentation for shareable resources.


Diffs (updated)
-

  docs/home.md 16a77da437584995496d199d58340efa5882f19d 
  docs/shared-resources.md PRE-CREATION 

Diff: https://reviews.apache.org/r/45967/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/
---

(Updated May 23, 2016, 5:03 a.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

Added a persistent volume test framework for shared volumes.


Diffs (updated)
-

  src/Makefile.am c618a41d083ab7f19233a4cea05e22b436192d04 
  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/tests/examples_tests.cpp ac513ce9aa3c8f366fe81ba937e3dc0d51a26940 
  src/tests/persistent_shared_volume_framework_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/45962/diff/


Testing
---

New test framework for shared resources added.
Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 47515: Enforced a constraint on `DiskInfo.Persistence.principal`.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47515/
---

(Updated May 23, 2016, 4:37 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.


Changes
---

Addressed comments.


Bugs: MESOS-5005
https://issues.apache.org/jira/browse/MESOS-5005


Repository: mesos


Description
---

This patch enforces the constraint that the principal
found in `DiskInfo.Persistence` should equal that of
the framework or operator responsible for creating
the volume.


Diffs (updated)
-

  src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
  src/master/master.cpp 0c05938de3e4eaeea2187559e81559f85318fa73 
  src/master/validation.hpp f29f9753c75e5abc3402ed23381edcea26517ab3 
  src/master/validation.cpp f490b899758bdac9676a6f6939918efa6ac52781 

Diff: https://reviews.apache.org/r/47515/diff/


Testing
---

`make check` was used to test on OSX at the end of this review chain.


Thanks,

Greg Mann

Re: Review Request 44154: Added appc_simple_discovery_uri_prefix to configuration.md.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44154/
---

(Updated May 23, 2016, 3:45 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, Jojy Varghese, and Vinod Kone.


Bugs: MESOS-5437
https://issues.apache.org/jira/browse/MESOS-5437


Repository: mesos


Description
---

Added appc_simple_discovery_uri_prefix to configuration.md.


Diffs
-

  docs/configuration.md 458b7bd300e29bbb0fc97cbcacfad42a0bdef574 
  src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 

Diff: https://reviews.apache.org/r/44154/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 47558: Added allower interface to authorizer.

[Joerg Schad]

> On May 22, 2016, 10:58 p.m., Michael Park wrote:
> > include/mesos/authorizer/authorizer.hpp, line 54
> > 
> >
> > If we go with `ObjectAuthorizer`, we should call this `authorized`, but 
> > at the least we should call it `allow` if we were to keep `ObjectAllower`.

ok, see above.


> On May 22, 2016, 10:58 p.m., Michael Park wrote:
> > include/mesos/authorizer/authorizer.hpp, line 137
> > 
> >
> > I think we should call this `authorized`.

Why do you want to call authorized as well? This for getting an Allower which 
in turn can authorize/allow stuff...


> On May 22, 2016, 10:58 p.m., Michael Park wrote:
> > src/authorizer/local/authorizer.cpp, line 59
> > 
> >
> > Is this WIP? Are we actually planning to only handle `VIEW_FRAMEWORKS`?

No, i just split it up in several reviews. See 
https://reviews.apache.org/r/47703/


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47558/#review134295
---


On May 22, 2016, 9:25 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47558/
> ---
> 
> (Updated May 22, 2016, 9:25 p.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Bugs: MESOS-5403
> https://issues.apache.org/jira/browse/MESOS-5403
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allower interface to authorizer.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> ed5f9e73661e25a83722cf1e408ae61023cd4a21 
>   src/authorizer/local/authorizer.hpp 
> 61388454025211fd7d53e71a86983fd8479950b6 
>   src/authorizer/local/authorizer.cpp 
> dc53bc4374aea98b5ed41ade5617374d2447229b 
>   src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
>   src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e 
> 
> Diff: https://reviews.apache.org/r/47558/diff/
> 
> 
> Testing
> ---
> 
> tested entire chain.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 47558: Added allower interface to authorizer.

[Joerg Schad]

> On May 22, 2016, 10:58 p.m., Michael Park wrote:
> > include/mesos/authorizer/authorizer.hpp, line 51
> > 
> >
> > I'm leaning towards calling this `ObjectAuthorizer`. We would 
> > effectively have `authorized(subject, action, object)` and 
> > `object_authorizer = authorized(subject, action); 
> > object_authorizer.authorized(object);`. What do you think?

As mentioned earlier: The goal here was to differentiate between the 
asynchronous `authorized()` call and the synchronous `allow` call.
If you feel that is not needed, I will happily change this.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47558/#review134295
---


On May 22, 2016, 9:25 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47558/
> ---
> 
> (Updated May 22, 2016, 9:25 p.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Bugs: MESOS-5403
> https://issues.apache.org/jira/browse/MESOS-5403
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allower interface to authorizer.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> ed5f9e73661e25a83722cf1e408ae61023cd4a21 
>   src/authorizer/local/authorizer.hpp 
> 61388454025211fd7d53e71a86983fd8479950b6 
>   src/authorizer/local/authorizer.cpp 
> dc53bc4374aea98b5ed41ade5617374d2447229b 
>   src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
>   src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e 
> 
> Diff: https://reviews.apache.org/r/47558/diff/
> 
> 
> Testing
> ---
> 
> tested entire chain.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 47708: Rearranged `expectedOffers` in the SlavesEndpointFullResources Test.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47708/#review134299
---



Patch looks great!

Reviews applied: [47706, 47707, 47708]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 23, 2016, 12:46 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47708/
> ---
> 
> (Updated May 23, 2016, 12:46 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Neil Conway.
> 
> 
> Bugs: MESOS-5256
> https://issues.apache.org/jira/browse/MESOS-5256
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change was required in response to the new refactoring for
> resource enumeration. Since resources are now enumerated in a slightly
> different order, the resulting JSON representing resources has a
> slightly different ordering as well.
> 
> NOTE: We don't actually care about the ordering for this test. We only
> care that the resulting resources match. For now we just fix the
> ordering of resources in the JSON string, but we should consider
> updating the test to compare the resulting `Resources` object
> represented by the JSON, not the exact JSON strings themselves.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> a57461d881b2bf0175f83b50b0a46167acd5bd3e 
> 
> Diff: https://reviews.apache.org/r/47708/diff/
> 
> 
> Testing
> ---
> 
> make -j check
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 47702: Added framework role & principal to the Web UI.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47702/#review134297
---



Patch looks great!

Reviews applied: [47702]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 23, 2016, 12:33 a.m., Deshna Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47702/
> ---
> 
> (Updated May 23, 2016, 12:33 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-4788
> https://issues.apache.org/jira/browse/MESOS-4788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/frameworks.html 
> f172e022e18df5b6aa3d232e610c3c732e20aa09 
> 
> Diff: https://reviews.apache.org/r/47702/diff/
> 
> 
> Testing
> ---
> 
> make check (see attached screenshot for ui after the change)
> 
> 
> File Attachments
> 
> 
> UI after changes
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/23/e9d106cf-9109-47d4-b63f-d6ee50dbf14e__Screen_Shot_2016-05-22_at_3.05.18_PM.png
> 
> 
> Thanks,
> 
> Deshna Jain
> 
>

Re: Review Request 47702: Added framework role & principal to the Web UI.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47702/#review134296
---



Do you forget to update
* `framework.html` 
https://github.com/apache/mesos/blob/master/src/webui/master/static/framework.html#L24
* `agent.html` 
https://github.com/apache/mesos/blob/master/src/webui/master/static/agent.html 
* `agent_framework.html` 
https://github.com/apache/mesos/blob/master/src/webui/master/static/agent_framework.html

- haosdent huang


On May 23, 2016, 12:33 a.m., Deshna Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47702/
> ---
> 
> (Updated May 23, 2016, 12:33 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-4788
> https://issues.apache.org/jira/browse/MESOS-4788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/frameworks.html 
> f172e022e18df5b6aa3d232e610c3c732e20aa09 
> 
> Diff: https://reviews.apache.org/r/47702/diff/
> 
> 
> Testing
> ---
> 
> make check (see attached screenshot for ui after the change)
> 
> 
> File Attachments
> 
> 
> UI after changes
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/23/e9d106cf-9109-47d4-b63f-d6ee50dbf14e__Screen_Shot_2016-05-22_at_3.05.18_PM.png
> 
> 
> Thanks,
> 
> Deshna Jain
> 
>

Review Request 47708: Rearranged `expectedOffers` in the SlavesEndpointFullResources Test.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47708/
---

Review request for mesos, Benjamin Mahler and Neil Conway.


Bugs: MESOS-5256
https://issues.apache.org/jira/browse/MESOS-5256


Repository: mesos


Description
---

This change was required in response to the new refactoring for
resource enumeration. Since resources are now enumerated in a slightly
different order, the resulting JSON representing resources has a
slightly different ordering as well.

NOTE: We don't actually care about the ordering for this test. We only
care that the resulting resources match. For now we just fix the
ordering of resources in the JSON string, but we should consider
updating the test to compare the resulting `Resources` object
represented by the JSON, not the exact JSON strings themselves.


Diffs
-

  src/tests/persistent_volume_endpoints_tests.cpp 
a57461d881b2bf0175f83b50b0a46167acd5bd3e 

Diff: https://reviews.apache.org/r/47708/diff/


Testing
---

make -j check


Thanks,

Kevin Klues

Review Request 47707: Refactored resource enumeration for containerizers and isolators.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47707/
---

Review request for mesos, Benjamin Mahler and Jie Yu.


Bugs: MESOS-5256
https://issues.apache.org/jira/browse/MESOS-5256


Repository: mesos


Description
---

Previously, the `Containerizer` class contained a static `resources()`
function for enumerating all of the resources available on an agent.
This made it hard to add new resources to this enumeration that were,
for example, containerizer-specific or tied to a new isolator module
loaded at runtime.

This commit refactors the resource enumeration logic to allow each
containerizer to enumerate resources itself. It does this by adding a
new virtual `resources()` function, whose default implementation
includes the same logic as the old static version of `resources()`.
Individual containerizers simply overwrite this function to do their
own enumeration if they want to.

Similar logic exists to push resource enumeration down into isolators
as well. As such, the logic for the Nvidia GPU resource enumeration has
been moved down into the Nvidia GPU isolator instead of being
hard-coded into the mesos containerizer itself.


Diffs
-

  include/mesos/slave/isolator.hpp 4be8c2bb409052e2e07138483408209384f41e23 
  src/slave/containerizer/composing.hpp 
f3eebd19bc9e6b3b8a969a2ad967b3e2909e0ee4 
  src/slave/containerizer/composing.cpp 
15d059f0bbda4e8cb93c65c09327dde1e34d3e7b 
  src/slave/containerizer/containerizer.hpp 
ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
  src/slave/containerizer/containerizer.cpp 
faa0c789dda8a6f36fdb6217b0bae270b6b8f2e2 
  src/slave/containerizer/mesos/containerizer.hpp 
a1a00020668f6da8d611f26e5637afffc87d09ba 
  src/slave/containerizer/mesos/containerizer.cpp 
75e5a32a3e70ec60a6800e21a621673184ea0956 
  src/slave/containerizer/mesos/isolator.hpp 
bacd86af42d16cb7c9b6622dfb298dcaa7007b75 
  src/slave/containerizer/mesos/isolator.cpp 
253ff3cea8aff3e7a3051fb5a763cc081f455f18 
  src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp 
502204650192d5ea44aa631eac8eb37e051843f0 
  src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp 
8f81cb79c10261670efc9eaa8614751854f53806 
  src/slave/slave.cpp ce0e7b1f1d17c3b82d835b0a6296ed7b1e9eeac1 

Diff: https://reviews.apache.org/r/47707/diff/


Testing
---

make -j check ( which fails on one test -- see 
https://reviews.apache.org/r/47708/ )


Thanks,

Kevin Klues

Review Request 47706: Provided defaults for all virtual functions in `mesos::slave::Isolator'.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47706/
---

Review request for mesos, Benjamin Mahler and Jie Yu.


Bugs: MESOS-5435
https://issues.apache.org/jira/browse/MESOS-5435


Repository: mesos


Description
---

Previously all of the virtual functions in `mesos::slave::Isolator` were
pure virtual (expect status()). For many isolators, however, it
doesn't make sense to implement all of these virtual functions.
Currently, each isolator has to provide its own default implementation
of these functions even if they aren't really relying on them. This
adds unnecessary extra code to many isolators that don't need them.

In addition to the changes to `mesos::slave::Isolator`, this commit
also provides default implementations for all of the corresponding
virtual functions in `MesosIsolatorProcess`. This way, classes that
inherit from `MesosIsolatorProcess` get the same benefit of code reuse
as those that inherit form `mesos::slave::Isolator`.


Diffs
-

  include/mesos/slave/isolator.hpp 4be8c2bb409052e2e07138483408209384f41e23 
  src/slave/containerizer/mesos/isolator.hpp 
bacd86af42d16cb7c9b6622dfb298dcaa7007b75 
  src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp 
502204650192d5ea44aa631eac8eb37e051843f0 
  src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp 
8f81cb79c10261670efc9eaa8614751854f53806 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
d7592cf49f4e4c5f3fc6a3244d9b922d4eb70a9f 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
54ded996c879c41163cbf7e9c1bb7ae6807c8801 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 
65e731886b9e5cac07ae3ad6398faf8f50de5650 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 
336ae0a4c6e2ad519f7913cd819f2ddea82c5cec 
  src/slave/containerizer/mesos/isolators/docker/runtime.hpp 
90179119ef297855091dad3fe969aa79810bf209 
  src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
a12220a2693271fc192ab9165b176b1f3d18b9ce 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
01777d4a656657e591593631fda49787f7d9fe55 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
92fce1cbdcd0d2cbd68b02ab02c5c224c42d67a4 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
c99f33a77e4db5407cc26361a2f253b00e91f5b5 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
5edbce95cc9eb4d6d22f9ab1528902cc745780af 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
c6cea98e16f2bdea2da0220c235468080bbcd17b 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
01c0ad6dbb6d509e62e769365586b3d23dcb240d 
  src/slave/containerizer/mesos/isolators/filesystem/shared.hpp 
dd0481cd7b5aaa8e198160d9d604090041033605 
  src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 
9ae4d937c27286f18026c47b61b2f8fcff6e74a6 
  src/slave/containerizer/mesos/isolators/namespaces/pid.hpp 
c8f389d36138681795641088d3ef686def0a4e64 
  src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 
5970d22e7198236d22c55de6153f465ed5f5fd7a 
  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
a06bb89a7a79a62949a48274df806f9f95da09e7 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
dae369aadb940150aa806b28d9269e3d88cf57ed 
  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
2f65f0a072911d3384684609828ec6cb6a27d19a 

Diff: https://reviews.apache.org/r/47706/diff/


Testing
---

make -j check


Thanks,

Kevin Klues

Re: Review Request 47702: Added framework role & principal to the Web UI.

[Deshna Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47702/
---

(Updated May 23, 2016, 12:33 a.m.)


Review request for mesos, haosdent huang and Vinod Kone.


Changes
---

Address review comments.


Bugs: MESOS-4788
https://issues.apache.org/jira/browse/MESOS-4788


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/webui/master/static/frameworks.html 
f172e022e18df5b6aa3d232e610c3c732e20aa09 

Diff: https://reviews.apache.org/r/47702/diff/


Testing
---

make check (see attached screenshot for ui after the change)


File Attachments (updated)


UI after changes
  
https://reviews.apache.org/media/uploaded/files/2016/05/23/e9d106cf-9109-47d4-b63f-d6ee50dbf14e__Screen_Shot_2016-05-22_at_3.05.18_PM.png


Thanks,

Deshna Jain

Re: Review Request 47558: Added allower interface to authorizer.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47558/#review134295
---




include/mesos/authorizer/authorizer.hpp (line 35)


How about we move this inside `ObjectAllower` and just call it `Object`?



include/mesos/authorizer/authorizer.hpp (line 51)


I'm leaning towards calling this `ObjectAuthorizer`. We would effectively 
have `authorized(subject, action, object)` and `object_authorizer = 
authorized(subject, action); object_authorizer.authorized(object);`. What do 
you think?



include/mesos/authorizer/authorizer.hpp (line 54)


If we go with `ObjectAuthorizer`, we should call this `authorized`, but at 
the least we should call it `allow` if we were to keep `ObjectAllower`.



include/mesos/authorizer/authorizer.hpp (line 137)


I think we should call this `authorized`.



include/mesos/authorizer/authorizer.hpp (line 138)


Since `Request` is `Subject`, `Action`, `Object`, I think it would be 
better for this function to take `Subject` and `Action`. This way we can 
constrain the effected part to be: `Object` -> `ObjectAllower::Object`.



src/authorizer/local/authorizer.cpp (line 59)


Is this WIP? Are we actually planning to only handle `VIEW_FRAMEWORKS`?



src/authorizer/local/authorizer.cpp (lines 62 - 63)


```
  LocalAuthorizerFrameworkObjectAllower(
  const ACLs _acls, const Option& _subject)
: acls(_acls), subject(_subject) {}
```



src/authorizer/local/authorizer.cpp (line 65)


`s/override{/override {/`



src/authorizer/local/authorizer.cpp (line 73)


This is unused.



src/authorizer/local/authorizer.cpp (lines 75 - 76)


Please let's do this now. `matches` and `allows` doesn't even use internal 
state and could have been declared `static`. Shouldn't be hard to pull them out.


- Michael Park


On May 22, 2016, 9:25 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47558/
> ---
> 
> (Updated May 22, 2016, 9:25 p.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Bugs: MESOS-5403
> https://issues.apache.org/jira/browse/MESOS-5403
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allower interface to authorizer.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> ed5f9e73661e25a83722cf1e408ae61023cd4a21 
>   src/authorizer/local/authorizer.hpp 
> 61388454025211fd7d53e71a86983fd8479950b6 
>   src/authorizer/local/authorizer.cpp 
> dc53bc4374aea98b5ed41ade5617374d2447229b 
>   src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
>   src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e 
> 
> Diff: https://reviews.apache.org/r/47558/diff/
> 
> 
> Testing
> ---
> 
> tested entire chain.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 47558: Added allower interface to authorizer.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47558/
---

(Updated May 22, 2016, 9:25 p.m.)


Review request for mesos, Michael Park and Vinod Kone.


Summary (updated)
-

Added allower interface to authorizer.


Bugs: MESOS-5403
https://issues.apache.org/jira/browse/MESOS-5403


Repository: mesos


Description (updated)
---

Added allower interface to authorizer.


Diffs
-

  include/mesos/authorizer/authorizer.hpp 
ed5f9e73661e25a83722cf1e408ae61023cd4a21 
  src/authorizer/local/authorizer.hpp 61388454025211fd7d53e71a86983fd8479950b6 
  src/authorizer/local/authorizer.cpp dc53bc4374aea98b5ed41ade5617374d2447229b 
  src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
  src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e 

Diff: https://reviews.apache.org/r/47558/diff/


Testing
---

tested entire chain.


Thanks,

Joerg Schad

Re: Review Request 46613: Introduced filtering relevant actions and acls.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46613/#review134291
---




include/mesos/authorizer/authorizer.proto (lines 69 - 70)


The `WITH_INFO` doesn't really seem to tell me anything. What's the 
intended meaning?



include/mesos/authorizer/authorizer.proto (line 70)


Should this be `VIEW_TASKS`?


- Michael Park


On May 21, 2016, 9:29 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46613/
> ---
> 
> (Updated May 21, 2016, 9:29 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Michael Park.
> 
> 
> Bugs: MESOS-5169
> https://issues.apache.org/jira/browse/MESOS-5169
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In order to allow for framework and task level filtering we introduce
> the following authorizer actions:
> * VIEW_FRAMEWORK_WITH_INFO
> * VIEW_TASK_WITH_TASK
> 
> Note that we need different actions for authorizing a tasks
> based on the object being authorized.
> 
> We also introduce the following acls for the local authorizer:
> * ViewFrameworks  (giving access to frameworks running under
>   a specific OS user)
> * ViewTasks view_tasks (giving access to Tasks run under a
> specific OS user)
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> b178f53a299a2941afc073af963f6aff26af1ca8 
>   include/mesos/authorizer/authorizer.proto 
> 911a2271211249a41c4467f6754e9996f640bf38 
>   src/authorizer/local/authorizer.cpp 
> dc53bc4374aea98b5ed41ade5617374d2447229b 
> 
> Diff: https://reviews.apache.org/r/46613/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 45668: Enable CMake build.

[Juan Larriba]

> On Mayo 22, 2016, 5:26 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 134
> > 
> >
> > Shouldn't this be "--" instead of "__" ?
> > 
> > # Replace "--" with "-D".
> > CONFIGURATION=${CONFIGURATION//--/-D}
> 
> Juan Larriba wrote:
> We have just replaced all "-" with "_" in the previous step.
> 
> Vinod Kone wrote:
> I see. Lets do "--" transformation first so that it doesn't affect "-" 
> transformation?

If we do that, we will end with _DVARIABLE_NAME


- Juan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review134277
---


On Mayo 22, 2016, 8:15 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated Mayo 22, 2016, 8:15 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
> https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build with autotools configuration.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh 28ef4dce3f473adab9919d4c2170075a0900af41 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build.

[Juan Larriba]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/
---

(Updated Mayo 22, 2016, 8:15 p.m.)


Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.


Summary (updated)
-

Enable CMake build.


Bugs: MESOS-5101
https://issues.apache.org/jira/browse/MESOS-5101


Repository: mesos


Description
---

Enable CMake build with autotools configuration.


Diffs
-

  support/docker_build.sh 28ef4dce3f473adab9919d4c2170075a0900af41 

Diff: https://reviews.apache.org/r/45668/diff/


Testing
---

Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake 
and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only 
gcc.


Thanks,

Juan Larriba

Re: Review Request 45668: Enable CMake build

[Vinod Kone]

> On May 22, 2016, 5:26 p.m., Vinod Kone wrote:
> >

Also you need a "." in the summary of the review to make reviewbot happy.


> On May 22, 2016, 5:26 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 134
> > 
> >
> > Shouldn't this be "--" instead of "__" ?
> > 
> > # Replace "--" with "-D".
> > CONFIGURATION=${CONFIGURATION//--/-D}
> 
> Juan Larriba wrote:
> We have just replaced all "-" with "_" in the previous step.

I see. Lets do "--" transformation first so that it doesn't affect "-" 
transformation?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review134277
---


On May 22, 2016, 6:38 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated May 22, 2016, 6:38 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
> https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build with autotools configuration.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh 28ef4dce3f473adab9919d4c2170075a0900af41 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 47699: Fixed incomplete bootstrap 3.3.6 upgrade.

[Michael Lunøe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47699/#review134288
---


Ship it!




looks good to me!

- Michael Lunøe


On May 22, 2016, 2:22 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47699/
> ---
> 
> (Updated May 22, 2016, 2:22 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Michael Lunøe, and Thomas 
> Rampelberg.
> 
> 
> Bugs: MESOS-5434
> https://issues.apache.org/jira/browse/MESOS-5434
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed incomplete bootstrap 3.3.6 upgrade.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/fonts/glyphicons-halflings-regular.eot 
> 423bd5d3a20b804f596e04e5cd02fb4f16cfcbc1 
>   src/webui/master/static/fonts/glyphicons-halflings-regular.svg 
> 4469488747892e5d72de3752a17705b0f02bec91 
>   src/webui/master/static/fonts/glyphicons-halflings-regular.ttf 
> a498ef4e7c8b556fc36f580c5ff524025bb11c84 
>   src/webui/master/static/fonts/glyphicons-halflings-regular.woff 
> d83c539b8266366dc331c5f746714caefb84c47d 
>   src/webui/master/static/fonts/glyphicons-halflings-regular.woff2 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47699/diff/
> 
> 
> Testing
> ---
> 
> Without 
> ```
> GET http://localhost:5050/static/fonts/glyphicons-halflings-regular.woff2
> ```
> error after applied this patch.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45668: Enable CMake build

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review134287
---



Bad patch!

Reviews applied: [45668]

Failed command: ./support/apply-review.sh -n -r 45668

Error:
2016-05-22 19:42:51 URL:https://reviews.apache.org/r/45668/diff/raw/ 
[3268/3268] -> "45668.patch" [1]
No files to lint

Error: Commit message summary (the first line) must end in a period.

Full log: https://builds.apache.org/job/mesos-reviewbot/13239/console

- Mesos ReviewBot


On May 22, 2016, 6:38 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated May 22, 2016, 6:38 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
> https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build with autotools configuration.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh 28ef4dce3f473adab9919d4c2170075a0900af41 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 47702: Added framework role & principal to the Web UI.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47702/#review134286
---



Patch looks great!

Reviews applied: [47702]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 22, 2016, 6:15 p.m., Deshna Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47702/
> ---
> 
> (Updated May 22, 2016, 6:15 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-4788
> https://issues.apache.org/jira/browse/MESOS-4788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/frameworks.html 
> f172e022e18df5b6aa3d232e610c3c732e20aa09 
> 
> Diff: https://reviews.apache.org/r/47702/diff/
> 
> 
> Testing
> ---
> 
> make check (see attached screenshot for ui after the change)
> 
> 
> File Attachments
> 
> 
> image after making the change
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/22/4954a2d1-315f-454d-abe9-d140d0122f57__Screen_Shot_2016-05-22_at_11.03.06_AM.png
> 
> 
> Thanks,
> 
> Deshna Jain
> 
>

Re: Review Request 45668: Enable CMake build

[Juan Larriba]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/
---

(Updated Mayo 22, 2016, 6:38 p.m.)


Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.


Bugs: MESOS-5101
https://issues.apache.org/jira/browse/MESOS-5101


Repository: mesos


Description (updated)
---

Enable CMake build with autotools configuration.


Diffs (updated)
-

  support/docker_build.sh 28ef4dce3f473adab9919d4c2170075a0900af41 

Diff: https://reviews.apache.org/r/45668/diff/


Testing
---

Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake 
and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only 
gcc.


Thanks,

Juan Larriba

Re: Review Request 45668: Enable CMake build

[Juan Larriba]

> On Mayo 22, 2016, 5:26 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 134
> > 
> >
> > Shouldn't this be "--" instead of "__" ?
> > 
> > # Replace "--" with "-D".
> > CONFIGURATION=${CONFIGURATION//--/-D}

We have just replaced all "-" with "_" in the previous step.


> On Mayo 22, 2016, 5:26 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 129
> > 
> >
> > # Remove "\".
> > CONFIGURATION=${CONFIGURATION//\/}
> > 
> > Do we have back slashes in configuration?

You are right. The backslashes appear in "echo" commands (like in "echo ENV 
DISTCHECK_CONFIGURE_FLAGS ''\''--verbose'\''' ''\''--enable_libevent'\'''"), 
but there is no need of replacing them.


> On Mayo 22, 2016, 5:26 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 126
> > 
> >
> > Don't think we need to have the `replace` variable. Just use the 
> > replacement strings inline.
> > 
> > Also need periods at the end of comments and quotes around literals.
> > 
> > # Remove "'".
> > CONFIGURATION=${CONFIGURATION//\'/}

I have always used a variable. Nice to note that it can be done directly inline.


- Juan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review134277
---


On Mayo 22, 2016, 2:10 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated Mayo 22, 2016, 2:10 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
> https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh 28ef4dce3f473adab9919d4c2170075a0900af41 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 47702: Added framework role & principal to the Web UI.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47702/#review134285
---




src/webui/master/static/frameworks.html (line 16)


lets add role and principal to active frameworks as well?



src/webui/master/static/frameworks.html (line 70)


s/name/role/



src/webui/master/static/frameworks.html (line 71)


s/name/principal/


- Vinod Kone


On May 22, 2016, 6:15 p.m., Deshna Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47702/
> ---
> 
> (Updated May 22, 2016, 6:15 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-4788
> https://issues.apache.org/jira/browse/MESOS-4788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/frameworks.html 
> f172e022e18df5b6aa3d232e610c3c732e20aa09 
> 
> Diff: https://reviews.apache.org/r/47702/diff/
> 
> 
> Testing
> ---
> 
> make check (see attached screenshot for ui after the change)
> 
> 
> File Attachments
> 
> 
> image after making the change
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/22/4954a2d1-315f-454d-abe9-d140d0122f57__Screen_Shot_2016-05-22_at_11.03.06_AM.png
> 
> 
> Thanks,
> 
> Deshna Jain
> 
>

Review Request 47702: Added framework role & principal to the Web UI.

[Deshna Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47702/
---

Review request for mesos, haosdent huang and Vinod Kone.


Bugs: MESOS-4788
https://issues.apache.org/jira/browse/MESOS-4788


Repository: mesos


Description
---

See summary.


Diffs
-

  src/webui/master/static/frameworks.html 
f172e022e18df5b6aa3d232e610c3c732e20aa09 

Diff: https://reviews.apache.org/r/47702/diff/


Testing
---

make check (see attached screenshot for ui after the change)


File Attachments


image after making the change
  
https://reviews.apache.org/media/uploaded/files/2016/05/22/4954a2d1-315f-454d-abe9-d140d0122f57__Screen_Shot_2016-05-22_at_11.03.06_AM.png


Thanks,

Deshna Jain

Re: Review Request 47700: Added a benchmark for reconciling tasks using the library/driver.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47700/#review134283
---



Patch looks great!

Reviews applied: [47700]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 22, 2016, 4:06 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47700/
> ---
> 
> (Updated May 22, 2016, 4:06 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5222
> https://issues.apache.org/jira/browse/MESOS-5222
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds a benchmark for measuring the time taken to
> reconcile a large number of unknown tasks using the scheduler
> library/driver.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 
> 
> Diff: https://reviews.apache.org/r/47700/diff/
> 
> 
> Testing
> ---
> 
> make check (There is a 10x disrepancy between the library/driver. Would file 
> a followup JIRA for it)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 47693: Added more error info for mesos ps.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47693/#review134282
---


Ship it!




Ship It!

- Vinod Kone


On May 22, 2016, 1:40 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47693/
> ---
> 
> (Updated May 22, 2016, 1:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-5429
> https://issues.apache.org/jira/browse/MESOS-5429
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added more error info for mesos ps.
> 
> 
> Diffs
> -
> 
>   src/cli/mesos-ps a6e6b7a0dd7091db35cee549ca1ce589b36406f6 
> 
> Diff: https://reviews.apache.org/r/47693/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> No LD_LIBRARY_PATH:
> root@mesos002:~# mesos ps --master=192.168.56.12:5050 --verbose=true
> Failed to get the master due to: Failed to execute 'mesos-resolve 
> 192.168.56.12:5050':
> mesos-resolve: error while loading shared libraries: libmesos-0.29.0.so: 
> cannot open shared object file: No such file or directory
> 
> Master is not running:
> root@mesos002:~# mesos ps --master=192.168.56.12:5050 --verbose=true
> Failed to get the master state due to:  refused>
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47699: Fixed incomplete bootstrap 3.3.6 upgrade.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47699/#review134281
---


Ship it!




Ship It!

- Vinod Kone


On May 22, 2016, 2:22 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47699/
> ---
> 
> (Updated May 22, 2016, 2:22 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Michael Lunøe, and Thomas 
> Rampelberg.
> 
> 
> Bugs: MESOS-5434
> https://issues.apache.org/jira/browse/MESOS-5434
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed incomplete bootstrap 3.3.6 upgrade.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/fonts/glyphicons-halflings-regular.eot 
> 423bd5d3a20b804f596e04e5cd02fb4f16cfcbc1 
>   src/webui/master/static/fonts/glyphicons-halflings-regular.svg 
> 4469488747892e5d72de3752a17705b0f02bec91 
>   src/webui/master/static/fonts/glyphicons-halflings-regular.ttf 
> a498ef4e7c8b556fc36f580c5ff524025bb11c84 
>   src/webui/master/static/fonts/glyphicons-halflings-regular.woff 
> d83c539b8266366dc331c5f746714caefb84c47d 
>   src/webui/master/static/fonts/glyphicons-halflings-regular.woff2 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47699/diff/
> 
> 
> Testing
> ---
> 
> Without 
> ```
> GET http://localhost:5050/static/fonts/glyphicons-halflings-regular.woff2
> ```
> error after applied this patch.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47698: Included .proto javadoc during website generation.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47698/#review134280
---


Ship it!




Ship It!

- Vinod Kone


On May 22, 2016, 1:11 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47698/
> ---
> 
> (Updated May 22, 2016, 1:11 p.m.)
> 
> 
> Review request for mesos, Adam B, Ben Whitehead, and Connor Doyle.
> 
> 
> Bugs: MESOS-5432
> https://issues.apache.org/jira/browse/MESOS-5432
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Included .proto javadoc during website generation.
> 
> 
> Diffs
> -
> 
>   site/Rakefile fbf690fb672edf08793a014a4bca5915476d9754 
> 
> Diff: https://reviews.apache.org/r/47698/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134279
---




site/README.md (line 15)


I think `make` is enough here?



site/README.md (line 36)


s/Git/git/



site/README.md (lines 63 - 68)


The old version of the text here is fine. No need to update it.



site/Rakefile (line 5)


shouldn't the "build" task happen after "doxygen" and "javadoc"?



site/Rakefile (lines 75 - 82)


why the change from "pubish" to "source" here?



site/build.sh (lines 28 - 30)


bundle install && rake && rake dev


- Vinod Kone


On May 22, 2016, 10:45 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 22, 2016, 10:45 a.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> 
> 
> Diffs
> -
> 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Dockerfile PRE-CREATION 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile fbf690fb672edf08793a014a4bca5915476d9754 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/#review134278
---


Ship it!




Ship It!

- Vinod Kone


On May 22, 2016, 12:52 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47646/
> ---
> 
> (Updated May 22, 2016, 12:52 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5423
> https://issues.apache.org/jira/browse/MESOS-5423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website section in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 
> 
> Diff: https://reviews.apache.org/r/47646/diff/
> 
> 
> Testing
> ---
> 
> Could check it via github 
> https://github.com/haosdent/mesos/blob/MESOS-5423/docs/release-guide.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 45668: Enable CMake build

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review134277
---




support/docker_build.sh (line 126)


Don't think we need to have the `replace` variable. Just use the 
replacement strings inline.

Also need periods at the end of comments and quotes around literals.

# Remove "'".
CONFIGURATION=${CONFIGURATION//\'/}



support/docker_build.sh (line 129)


# Remove "\".
CONFIGURATION=${CONFIGURATION//\/}

Do we have back slashes in configuration?



support/docker_build.sh (line 131)


# Replace "-" with "_".
CONFIGURATION=${CONFIGURATION//-/_}



support/docker_build.sh (line 134)


Shouldn't this be "--" instead of "__" ?

# Replace "--" with "-D".
CONFIGURATION=${CONFIGURATION//--/-D}



support/docker_build.sh (line 137)


# To upper case.



support/docker_build.sh (line 140)


# Add "=1" suffix to each variable.



support/docker_build.sh (line 146)


kill this?



support/docker_build.sh (line 150)


"distcheck"


- Vinod Kone


On May 22, 2016, 2:10 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated May 22, 2016, 2:10 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
> https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh 28ef4dce3f473adab9919d4c2170075a0900af41 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 47700: Added a benchmark for reconciling tasks using the library/driver.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47700/#review134276
---




src/tests/scheduler_tests.cpp (line 1595)


split this into its own test to avoid side effects.


- Vinod Kone


On May 22, 2016, 4:06 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47700/
> ---
> 
> (Updated May 22, 2016, 4:06 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5222
> https://issues.apache.org/jira/browse/MESOS-5222
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds a benchmark for measuring the time taken to
> reconcile a large number of unknown tasks using the scheduler
> library/driver.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 
> 
> Diff: https://reviews.apache.org/r/47700/diff/
> 
> 
> Testing
> ---
> 
> make check (There is a 10x disrepancy between the library/driver. Would file 
> a followup JIRA for it)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 47699: Fixed incomplete bootstrap 3.3.6 upgrade.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47699/#review134275
---



Patch looks great!

Reviews applied: [47699]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 22, 2016, 2:22 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47699/
> ---
> 
> (Updated May 22, 2016, 2:22 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Michael Lunøe, and Thomas 
> Rampelberg.
> 
> 
> Bugs: MESOS-5434
> https://issues.apache.org/jira/browse/MESOS-5434
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed incomplete bootstrap 3.3.6 upgrade.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/fonts/glyphicons-halflings-regular.eot 
> 423bd5d3a20b804f596e04e5cd02fb4f16cfcbc1 
>   src/webui/master/static/fonts/glyphicons-halflings-regular.svg 
> 4469488747892e5d72de3752a17705b0f02bec91 
>   src/webui/master/static/fonts/glyphicons-halflings-regular.ttf 
> a498ef4e7c8b556fc36f580c5ff524025bb11c84 
>   src/webui/master/static/fonts/glyphicons-halflings-regular.woff 
> d83c539b8266366dc331c5f746714caefb84c47d 
>   src/webui/master/static/fonts/glyphicons-halflings-regular.woff2 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47699/diff/
> 
> 
> Testing
> ---
> 
> Without 
> ```
> GET http://localhost:5050/static/fonts/glyphicons-halflings-regular.woff2
> ```
> error after applied this patch.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 47700: Added a benchmark for reconciling tasks using the library/driver.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47700/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-5222
https://issues.apache.org/jira/browse/MESOS-5222


Repository: mesos


Description
---

This change adds a benchmark for measuring the time taken to
reconcile a large number of unknown tasks using the scheduler
library/driver.


Diffs
-

  src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 

Diff: https://reviews.apache.org/r/47700/diff/


Testing
---

make check (There is a 10x disrepancy between the library/driver. Would file a 
followup JIRA for it)


Thanks,

Anand Mazumdar

Re: Review Request 45668: Enable CMake build

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review134273
---



Bad patch!

Reviews applied: [45668]

Failed command: ./support/apply-review.sh -n -r 45668

Error:
2016-05-22 15:43:00 URL:https://reviews.apache.org/r/45668/diff/raw/ 
[3404/3404] -> "45668.patch" [1]
No files to lint

Error: Commit message summary (the first line) must end in a period.

Full log: https://builds.apache.org/job/mesos-reviewbot/13235/console

- Mesos ReviewBot


On May 22, 2016, 2:10 p.m., Juan Larriba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> ---
> 
> (Updated May 22, 2016, 2:10 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
> https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enable CMake build
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh 28ef4dce3f473adab9919d4c2170075a0900af41 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> ---
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both 
> cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in 
> centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 47698: Included .proto javadoc during website generation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47698/#review134272
---



Patch looks great!

Reviews applied: [47698]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 22, 2016, 1:11 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47698/
> ---
> 
> (Updated May 22, 2016, 1:11 p.m.)
> 
> 
> Review request for mesos, Adam B, Ben Whitehead, and Connor Doyle.
> 
> 
> Bugs: MESOS-5432
> https://issues.apache.org/jira/browse/MESOS-5432
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Included .proto javadoc during website generation.
> 
> 
> Diffs
> -
> 
>   site/Rakefile fbf690fb672edf08793a014a4bca5915476d9754 
> 
> Diff: https://reviews.apache.org/r/47698/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 47699: Fixed incomplete bootstrap 3.3.6 upgrade.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47699/
---

Review request for mesos, Bernd Mathiske, Michael Lunøe, and Thomas Rampelberg.


Bugs: MESOS-5434
https://issues.apache.org/jira/browse/MESOS-5434


Repository: mesos


Description
---

Fixed incomplete bootstrap 3.3.6 upgrade.


Diffs
-

  src/webui/master/static/fonts/glyphicons-halflings-regular.eot 
423bd5d3a20b804f596e04e5cd02fb4f16cfcbc1 
  src/webui/master/static/fonts/glyphicons-halflings-regular.svg 
4469488747892e5d72de3752a17705b0f02bec91 
  src/webui/master/static/fonts/glyphicons-halflings-regular.ttf 
a498ef4e7c8b556fc36f580c5ff524025bb11c84 
  src/webui/master/static/fonts/glyphicons-halflings-regular.woff 
d83c539b8266366dc331c5f746714caefb84c47d 
  src/webui/master/static/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION 

Diff: https://reviews.apache.org/r/47699/diff/


Testing
---

Without 
```
GET http://localhost:5050/static/fonts/glyphicons-halflings-regular.woff2
```
error after applied this patch.


Thanks,

haosdent huang

Re: Review Request 45668: Enable CMake build

[Juan Larriba]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/
---

(Updated Mayo 22, 2016, 2:10 p.m.)


Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.


Changes
---

Enable CMake build with the same parameters as autotools.


Summary (updated)
-

Enable CMake build


Bugs: MESOS-5101
https://issues.apache.org/jira/browse/MESOS-5101


Repository: mesos


Description (updated)
---

Enable CMake build


Diffs (updated)
-

  support/docker_build.sh 28ef4dce3f473adab9919d4c2170075a0900af41 

Diff: https://reviews.apache.org/r/45668/diff/


Testing
---

Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake 
and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only 
gcc.


Thanks,

Juan Larriba

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/#review134270
---



Patch looks great!

Reviews applied: [47646]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 22, 2016, 12:52 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47646/
> ---
> 
> (Updated May 22, 2016, 12:52 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5423
> https://issues.apache.org/jira/browse/MESOS-5423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website section in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 
> 
> Diff: https://reviews.apache.org/r/47646/diff/
> 
> 
> Testing
> ---
> 
> Could check it via github 
> https://github.com/haosdent/mesos/blob/MESOS-5423/docs/release-guide.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 47698: Included .proto javadoc during website generation.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47698/
---

Review request for mesos, Adam B, Ben Whitehead, and Connor Doyle.


Bugs: MESOS-5432
https://issues.apache.org/jira/browse/MESOS-5432


Repository: mesos


Description
---

Included .proto javadoc during website generation.


Diffs
-

  site/Rakefile fbf690fb672edf08793a014a4bca5915476d9754 

Diff: https://reviews.apache.org/r/47698/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/
---

(Updated May 22, 2016, 12:52 p.m.)


Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
Vinod Kone.


Changes
---

Address @klueska's comments.


Bugs: MESOS-5423
https://issues.apache.org/jira/browse/MESOS-5423


Repository: mesos


Description
---

Updated the outdated website section in release-guide.md.


Diffs (updated)
-

  docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 

Diff: https://reviews.apache.org/r/47646/diff/


Testing
---

Could check it via github 
https://github.com/haosdent/mesos/blob/MESOS-5423/docs/release-guide.md


Thanks,

haosdent huang

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

[haosdent huang]

> On May 20, 2016, 6:45 p.m., Kevin Klues wrote:
> > docs/release-guide.md, line 180
> > 
> >
> > This isn't really a step in "updating the website".  As such, I'd 
> > probably move this to the last step and reword it slightly.
> > 
> > ```
> > 5. Write a blog post announcing the new release and its features and 
> > major bug fixes. Include a link to the updated website.
> > ```

Thanks a lot for your helpful review comments! Just updated, may you review it 
again? Thank you in advance.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47646/#review134184
---


On May 20, 2016, 5:30 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47646/
> ---
> 
> (Updated May 20, 2016, 5:30 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5423
> https://issues.apache.org/jira/browse/MESOS-5423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the outdated website section in release-guide.md.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 68782199f4ae9eb2471f7ca23e6455f43d23f4d9 
> 
> Diff: https://reviews.apache.org/r/47646/diff/
> 
> 
> Testing
> ---
> 
> Could check it via github 
> https://github.com/haosdent/mesos/blob/MESOS-5423/docs/release-guide.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134265
---



Patch looks great!

Reviews applied: [47695]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 22, 2016, 10:45 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 22, 2016, 10:45 a.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> 
> 
> Diffs
> -
> 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Dockerfile PRE-CREATION 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile fbf690fb672edf08793a014a4bca5915476d9754 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/
---

(Updated May 22, 2016, 10:45 a.m.)


Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
Vinod Kone.


Changes
---

Add testing done.


Bugs: MESOS-5431
https://issues.apache.org/jira/browse/MESOS-5431


Repository: mesos


Description
---

In this changes, we include below items to make it more convenience to
develop and generate the website.

* added `doxygen` and `javadoc` to `rake` default target.
* added `build.sh` as the wrapper for the website generation to make
  sure we clean up generated documents when exit.
* switched the `Dockerfile` to based on `centos:7` because the default
  `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
  correctly when generate `doxygen` documents.
* adjusted the `Dockerfile` and `README.md` locations to avoid we
  distract at finding the website generation document.


Diffs
-

  site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
  site/Dockerfile PRE-CREATION 
  site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
  site/Rakefile fbf690fb672edf08793a014a4bca5915476d9754 
  site/build.sh PRE-CREATION 
  support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
  support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 

Diff: https://reviews.apache.org/r/47695/diff/


Testing (updated)
---

Tested in OS X and Ubuntu 14.04

For document changes, could verified from 
https://github.com/haosdent/mesos/tree/MESOS-5431/site


Thanks,

haosdent huang

Review Request 47695: Updated the website generation and development workflows with docker.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/
---

Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
Vinod Kone.


Bugs: MESOS-5431
https://issues.apache.org/jira/browse/MESOS-5431


Repository: mesos


Description
---

In this changes, we include below items to make it more convenience to
develop and generate the website.

* added `doxygen` and `javadoc` to `rake` default target.
* added `build.sh` as the wrapper for the website generation to make
  sure we clean up generated documents when exit.
* switched the `Dockerfile` to based on `centos:7` because the default
  `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
  correctly when generate `doxygen` documents.
* adjusted the `Dockerfile` and `README.md` locations to avoid we
  distract at finding the website generation document.


Diffs
-

  site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
  site/Dockerfile PRE-CREATION 
  site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
  site/Rakefile fbf690fb672edf08793a014a4bca5915476d9754 
  site/build.sh PRE-CREATION 
  support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
  support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 

Diff: https://reviews.apache.org/r/47695/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 45967: Added documentation for shareable resources.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45967/#review134261
---



Bad patch!

Reviews applied: [45967, 45966, 45964, 45963, 45962, 45961, 45960, 45959, 45958]

Failed command: ./support/apply-review.sh -n -r 45962

Error:
2016-05-22 08:33:08 URL:https://reviews.apache.org/r/45962/diff/raw/ 
[20908/20908] -> "45962.patch" [1]
error: missing binary patch data for 
'src/tests/.persistent_shared_volume_framework_test.sh.swp'
error: binary patch does not apply to 
'src/tests/.persistent_shared_volume_framework_test.sh.swp'
error: src/tests/.persistent_shared_volume_framework_test.sh.swp: patch does 
not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13229/console

- Mesos ReviewBot


On May 22, 2016, 7:24 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45967/
> ---
> 
> (Updated May 22, 2016, 7:24 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4325
> https://issues.apache.org/jira/browse/MESOS-4325
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for shareable resources.
> 
> 
> Diffs
> -
> 
>   docs/home.md 16a77da437584995496d199d58340efa5882f19d 
>   docs/shared-resources.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45967/diff/
> 
> 
> Testing
> ---
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 47671: Windows: Allowed `dynamic_cast` on an object being constructed.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47671/#review134260
---



Patch looks great!

Reviews applied: [47473, 47492, 47486, 47474, 47489, 47442, 47671]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 22, 2016, 6:59 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47671/
> ---
> 
> (Updated May 22, 2016, 6:59 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
> Van Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-5428
> https://issues.apache.org/jira/browse/MESOS-5428
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Allowed `dynamic_cast` on an object being constructed.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 5c7833ceaed556cc4ffb650996e918c1a542c5f0 
> 
> Diff: https://reviews.apache.org/r/47671/diff/
> 
> 
> Testing
> ---
> 
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 45967: Added documentation for shareable resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45967/
---

(Updated May 22, 2016, 7:24 a.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Changes due to renaming of `share` to `shared` in protobuf for Resource.


Bugs: MESOS-4325
https://issues.apache.org/jira/browse/MESOS-4325


Repository: mesos


Description
---

Added documentation for shareable resources.


Diffs (updated)
-

  docs/home.md 16a77da437584995496d199d58340efa5882f19d 
  docs/shared-resources.md PRE-CREATION 

Diff: https://reviews.apache.org/r/45967/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45966: Offer shareable resources to frameworks only if opted in.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45966/
---

(Updated May 22, 2016, 7:24 a.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Cosmetic changes.


Bugs: MESOS-4325
https://issues.apache.org/jira/browse/MESOS-4325


Repository: mesos


Description
---

Added a new capability SHAREABLE_RESOURCES that frameworks need to opt
in if they are interested in receiving shared resources in their
offers.


Diffs (updated)
-

  include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 
  include/mesos/v1/mesos.proto 9e59aed20965d50ee10989ff6b75db742cf2b83b 
  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/master/allocator/mesos/hierarchical.hpp 
3f5dff72945bf81fda4e5bc9b11edfba40cced9d 
  src/master/allocator/mesos/hierarchical.cpp 
8b7b3afb5770c617918ec4864faaf8d8a7a81ef2 
  src/tests/hierarchical_allocator_tests.cpp 
e4579cb7978c966f639c0d2c196884e522b372c2 

Diff: https://reviews.apache.org/r/45966/diff/


Testing
---

Tests updated with new capability.
Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45964: Add unit tests for sharing of resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45964/
---

(Updated May 22, 2016, 7:21 a.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Renaming in protobuf field from `share` to `shared`.


Bugs: MESOS-4324
https://issues.apache.org/jira/browse/MESOS-4324


Repository: mesos


Description
---

Add unit tests for sharing of resources.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
e4579cb7978c966f639c0d2c196884e522b372c2 
  src/tests/master_validation_tests.cpp 
ca4442aa1ef0087a7d058d1b3aa430a1dbc16960 
  src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
  src/tests/persistent_volume_tests.cpp 
d246f35046fff469b847c908de2b305ae629212f 
  src/tests/resources_tests.cpp dc12bd8f1e2da6972bc8aed598811c55d664036e 

Diff: https://reviews.apache.org/r/45964/diff/


Testing
---

Tests for shared resources added for allocator, resources and sorter.
Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45963/
---

(Updated May 22, 2016, 7:21 a.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Cosmetic changes.


Bugs: MESOS-4324
https://issues.apache.org/jira/browse/MESOS-4324


Repository: mesos


Description
---

Allow the task to specify the persistent volume access to be read-only
or read-write. Note that the persistent volume is always created as
read-write.
If the task is the first consumer of the shared persistent volume, then
set the ownership of the persistent volume to match that of the task.
Otherwise, allow the task to be executed only if the ownership of the
persistent volume matches that of the task.
Added an option to run the test in mixed (default) mode or shared-only
mode. In mixed mode, multiple shards alternate between shared and
unshared persistent volumes for the tasks. In shared-only mode, all
shards use shared persistent volumes for the tasks.


Diffs (updated)
-

  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/master/validation.hpp f29f9753c75e5abc3402ed23381edcea26517ab3 
  src/master/validation.cpp f490b899758bdac9676a6f6939918efa6ac52781 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
c99f33a77e4db5407cc26361a2f253b00e91f5b5 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
5edbce95cc9eb4d6d22f9ab1528902cc745780af 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
c6cea98e16f2bdea2da0220c235468080bbcd17b 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
01c0ad6dbb6d509e62e769365586b3d23dcb240d 

Diff: https://reviews.apache.org/r/45963/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/
---

(Updated May 22, 2016, 7:12 a.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Changes in renaming of share to shared.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

Added a persistent volume test framework for shared volumes.


Diffs (updated)
-

  src/Makefile.am c618a41d083ab7f19233a4cea05e22b436192d04 
  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/tests/.persistent_shared_volume_framework_test.sh.swp PRE-CREATION 
  src/tests/examples_tests.cpp ac513ce9aa3c8f366fe81ba937e3dc0d51a26940 
  src/tests/persistent_shared_volume_framework_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/45962/diff/


Testing
---

New test framework for shared resources added.
Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

[Anindya Sinha]

> On May 11, 2016, 3:49 p.m., Jiang Yan Xu wrote:
> > Looks like the SHARE and UNSHARE operations are not in this patch?

Yes that is correct.


> On May 11, 2016, 3:49 p.m., Jiang Yan Xu wrote:
> > src/common/resources.cpp, line 1328
> > 
> >
> > Should we require persistent volumes to be unshared before we destroy 
> > them?
> > 
> > Here the concern is that we are clearing things in DESTROY that are not 
> > added by its pairing operation CREATE.

Since SHARE and UNSHARE apis are not supported yet, the only way to mark a 
resource as shared is in CREATE so clearing it in DESTROY seems correct.


> On May 11, 2016, 3:49 p.m., Jiang Yan Xu wrote:
> > src/common/resources_utils.cpp, lines 71-74
> > 
> >
> > Do we need `Resources::isShared(resource)`?
> > 
> > If we don't need that method, here we can actually just 
> > `stripped.clear_shared()`.

I will remove the check for `if (Resources::isShareable(resource))` [now 
`Resources::isShared(resource)`] and always do a `stripped.clear_shared()`. I 
would keep the `Resources::isShared()` method since that is the pattern being 
used for `Resources::shared()` and `Resources::nonShared()`, which is how it is 
done for revocable resources as well.


> On May 11, 2016, 3:49 p.m., Jiang Yan Xu wrote:
> > include/mesos/resources.hpp, lines 424-430
> > 
> >
> > See my comment at the definition.

Refactored this within sorter.


> On May 11, 2016, 3:49 p.m., Jiang Yan Xu wrote:
> > src/common/resources.cpp, lines 1464-1496
> > 
> >
> > This concept of weightedGet tightly couples with the sorter logic which 
> > is not used elsewhere so it shouldn't be pulled out.
> > 
> > Here to have something that's more easily explainable in a generic way, 
> > perhaps we can introduce something like
> > 
> > 
> > ```
> > // Returns the count of the target Resource in the Resources.
> > size_t Resources::count(const Resource& target) const
> > {
> >   // Search the list of resources in the collection.
> >   // For shared resources, return the Resource_::sharedCount but 
> > because this
> >   // is strictly an internal optimzation, the caller just needs to 
> > refer to this
> >   // as "the count".
> >   // For nonshared resources, given how we collapse addable resources, 
> > the result
> >   // is at most 1.
> > }
> > ```
> > 
> > I feel API is easiler to explain in a general sense for the callers and 
> > the implementation is easy to explain for readers of the cpp file without 
> > going to through the DRF logic.
> > 
> > Chatted with Anindya offline and we are still debating whether we can 
> > avoid even having `count` altogether but I am writing down my thoughts here.
> > 
> > As to whether we are leaking internal information, I don't feel like 
> > this is the case: we are not asking the caller to carefully manipulating 
> > the internal state in order to use share resource arithmetics correctly but 
> > rather this provides additional information for logic that doesn't deal 
> > with resource arithmetic. Therefore I don't think we are breaking 
> > abstractions but merely exposing a const `count` method.

Based on our f2f discussion, we decided to add `Resources::count()` which 
returns the shared count for shared resources, and 1 for non-shared resources. 
This API is being used within the sorter in calculation of resource share (in 
DRF).


> On May 11, 2016, 3:49 p.m., Jiang Yan Xu wrote:
> > src/common/resources_utils.cpp, lines 88-119
> > 
> >
> > In the most recent iteration we can just -= from the call sites right?

And hence this function is removed.


> On May 11, 2016, 3:49 p.m., Jiang Yan Xu wrote:
> > src/master/allocator/sorter/drf/sorter.cpp, lines 252-254
> > 
> >
> > What does "included in non shareable resources already." mean?

Removed the erraneous comment.


> On May 11, 2016, 3:49 p.m., Jiang Yan Xu wrote:
> > src/master/allocator/sorter/drf/sorter.cpp, lines 394-402
> > 
> >
> > `allocations[(*it).name].scalarQuantities` has only nonshared resources.

Refactored this to bring the calculation of total scalars within sorter. So, we 
no longer need to add a vector of scalars for each client.


> On May 11, 2016, 3:49 p.m., Jiang Yan Xu wrote:
> > src/master/allocator/sorter/drf/sorter.cpp, lines 427-432
> > 
> >
> > 

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45961/
---

(Updated May 22, 2016, 7:11 a.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Updates to reflect share->shared, and renaming of other APIs in Resources class.
Share count now reflects actual reference count in usedResources, but presence 
(or absence) of shared resources in offer, allocator and sorter.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description (updated)
---

Each shared resource is accouted via its share count. This count is
updated based on the resource operations (such as add and subtract)
in various scenarios such as task launch and terminate at multiple
modules such as master, allocator, sorter, etc.
Allow DESTROY for shared volumes only if share count is 0.
Since shared resources are available to multiple frameworks of the
same role simultaneously, we normalize it with a weight equivalent
to the number of frameworks to which this shared resource has been
allocated to in the sorter.


Diffs (updated)
-

  src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 
  src/common/resources_utils.cpp 8e881a09500b0966b577e514077460f724868a8d 
  src/master/allocator/mesos/hierarchical.cpp 
8b7b3afb5770c617918ec4864faaf8d8a7a81ef2 
  src/master/allocator/sorter/drf/sorter.hpp 
05d5205d29ad74e01e07c508d88b6f8371541513 
  src/master/allocator/sorter/drf/sorter.cpp 
4306973277b9d32356eed31ceabac09fb2a03e6c 
  src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
  src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
  src/master/master.cpp 0c05938de3e4eaeea2187559e81559f85318fa73 
  src/master/validation.hpp f29f9753c75e5abc3402ed23381edcea26517ab3 
  src/master/validation.cpp f490b899758bdac9676a6f6939918efa6ac52781 
  src/tests/master_validation_tests.cpp 
ca4442aa1ef0087a7d058d1b3aa430a1dbc16960 
  src/tests/sorter_tests.cpp eb207a36c18198588cd8a98b3860a66c2ff7a641 
  src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a 

Diff: https://reviews.apache.org/r/45961/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45960/
---

(Updated May 22, 2016, 7:09 a.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Changes based on shareable/ShareInfo to shared/SharedInfo.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

Added interfaces to handle and track shareable resources.


Diffs (updated)
-

  include/mesos/resources.hpp a557e97c65194d4aad879fb88d8edefd1c95b8d8 
  include/mesos/v1/resources.hpp a5ba8fec4c9c3643646308f75a4b28cefe0b3df3 
  src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 
  src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a 

Diff: https://reviews.apache.org/r/45960/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

[Anindya Sinha]

> On May 16, 2016, 6:24 p.m., Jiang Yan Xu wrote:
> > include/mesos/resources.hpp, line 346
> > 
> >
> > s/nonShareable/nonshared/.

Renamed nonShareable() to nonShared().


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45960/#review131462
---


On May 22, 2016, 7:09 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45960/
> ---
> 
> (Updated May 22, 2016, 7:09 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4431
> https://issues.apache.org/jira/browse/MESOS-4431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added interfaces to handle and track shareable resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp a557e97c65194d4aad879fb88d8edefd1c95b8d8 
>   include/mesos/v1/resources.hpp a5ba8fec4c9c3643646308f75a4b28cefe0b3df3 
>   src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 
>   src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a 
> 
> Diff: https://reviews.apache.org/r/45960/diff/
> 
> 
> Testing
> ---
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

[Anindya Sinha]

> On May 16, 2016, 6:01 p.m., Jiang Yan Xu wrote:
> > include/mesos/resources.hpp, line 190
> > 
> >
> > This is supposed to be hidden in private right?

Done as a part of the refactor. Few of the comments below have been addressed 
by this change.


> On May 16, 2016, 6:01 p.m., Jiang Yan Xu wrote:
> > include/mesos/resources.hpp, lines 303-304
> > 
> >
> > We talked about its use in tests: I think exposing `size_t 
> > Resources::count(const Resource&)` is more direct in returning the 
> > information about how many copies of the shared resources are in the 
> > container.
> > 
> > As for the concerns about leaking the value of the internal counter: I 
> > think this is fine because the correctness of the Resources arithmetic 
> > doesn't rely on the callers carefully manipulating the counters correctly 
> > or calling particular methods based on the result of `count()`. The 
> > `count()` method simply exposes information for uses other than Resources 
> > arithmetic operations themselves. Similar to 
> > [set::count()](http://en.cppreference.com/w/cpp/container/unordered_multiset/count).

Added `Resources::count()` as discussed.
I think the analogy is to a `multiset` or `unordered_multiset` (not a `set`). 
There is a small difference in that the multiple entries (with same keys) in 
`multiset` or `unordered_multiset` are stored as separate objects, and 
`count()` accumulates them and returns the count based on the specified key.
`Resources::count()` is different since the internal storage (which I agree is 
not exposed to callers) ensures that a Resource is stored once only and the 
`count()` returns the sharedCount (if present); or 1 (if not a shared 
resource); or 0 (otherwise).


> On May 16, 2016, 6:01 p.m., Jiang Yan Xu wrote:
> > include/mesos/resources.hpp, lines 406-409
> > 
> >
> > As discussed, we'll no longer need this.

Updated as discussed.


> On May 16, 2016, 6:01 p.m., Jiang Yan Xu wrote:
> > include/mesos/v1/resources.hpp, lines 489-496
> > 
> >
> > Should they both exist or we can just replace 
> > 
> > ```
> > bool Resources::_contains(const Resource& that) const
> > ```
> > 
> > with 
> > 
> > ```
> > bool Resources::_contains(const Resource_& that) const
> > ```
> > 
> > ?

Merged the 2 functions, and the following is the only available member function 
now available:
`bool _contains(const Resource_& that) const`.

If we have a Resource object, we do a `_contains(Resource_(resource))`.


> On May 16, 2016, 6:01 p.m., Jiang Yan Xu wrote:
> > src/common/resources.cpp, lines 841-847
> > 
> >
> > ```
> > if (isShared() && sharedCount.get() == 0) {
> >   return true;
> > }
> > 
> > return Resources::isEmpty(resource);
> > ```
> > 
> > because a 0MB shared disk volume is still empty.

Good point.


> On May 16, 2016, 6:01 p.m., Jiang Yan Xu wrote:
> > src/common/resources.cpp, lines 869-879
> > 
> >
> > This could be
> > 
> > ```
> > return sharedCount == that.sharedCount() && resource == that.resource;
> > ```
> > 
> > right?

I would leave the existing code instead of shortening it. I think it makes it 
clearer.


> On May 16, 2016, 6:01 p.m., Jiang Yan Xu wrote:
> > src/common/resources.cpp, line 1757
> > 
> >
> > `*resources.back()` as `resources.back()` returns an iterator.

std::vector::back() returns a reference or const_reference (not iterator or 
const_iterator).
http://en.cppreference.com/w/cpp/container/vector/back


> On May 16, 2016, 6:01 p.m., Jiang Yan Xu wrote:
> > src/common/resources.cpp, lines 1890-1891
> > 
> >
> > You just need 
> > 
> > ```
> > stream << resource_.resource;
> > ```
> > 
> > right?

Either way is fine. Anyways, I changed it...


> On May 16, 2016, 6:01 p.m., Jiang Yan Xu wrote:
> > src/common/resources.cpp, lines 1907-1909
> > 
> >
> > Wouldn't the version on the left do the right thing?

Either way is fine. Anyways, I changed it...


> On May 16, 2016, 6:01 p.m., Jiang Yan Xu wrote:
> > include/mesos/v1/resources.hpp, lines 458-459
> > 
> >
> > When do people need to using the vector explicitly?

Removed this.


> On May 16, 

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45959/
---

(Updated May 22, 2016, 7:08 a.m.)


Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and Jiang Yan 
Xu.


Changes
---

Changes based on `ShareInfo` renamed to `SharedInfo`.
Cleaned up the `Resources` and `Resource_` classes.
Share count keeps track of shared resource utilization in usedResources, but it 
keeps track of whether shared resource is used or not in offer, allocator and 
sorter.


Bugs: MESOS-4892
https://issues.apache.org/jira/browse/MESOS-4892


Repository: mesos


Description (updated)
---

A new class Resource_ is added that allows 'Resources' to group
identical shared resource objects together into a single 'Resource_'
object and tracked by its shared count. Non-shared resource objects
are not grouped.

For resource addition and subtraction, the shared count is adjusted for
shared resources as follows:
a) Addition: If shared resource is absent from original, then the
   resource is added initialized with a consumer count of 1. Otherwise,
   the share count for the shared resource is incremented.
b) Subtraction: If shared resource's share count is already 1, then
   the shared resource is removed from the original. Otherwise, its
   consumer count is decremented.


Diffs (updated)
-

  include/mesos/resources.hpp a557e97c65194d4aad879fb88d8edefd1c95b8d8 
  include/mesos/v1/resources.hpp a5ba8fec4c9c3643646308f75a4b28cefe0b3df3 
  src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 
  src/master/validation.cpp f490b899758bdac9676a6f6939918efa6ac52781 
  src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
  src/tests/resources_tests.cpp dc12bd8f1e2da6972bc8aed598811c55d664036e 
  src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a 

Diff: https://reviews.apache.org/r/45959/diff/


Testing
---

New tests added to demonstrate arithmetic operations for shared resources with 
consumer counts.
Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

[Anindya Sinha]

> On April 9, 2016, 7:08 a.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 757
> > 
> >
> > What about `ShareableInfo`? This is also consistent with 
> > `RevocableInfo`.
> 
> Anindya Sinha wrote:
> I am not sure if that is a huge deal though. I would prefer to keep it as 
> ShareInfo, but if there is a strong opinion regarding this I am open to 
> change this to ShareableInfo.

Updated to SharedInfo


> On April 9, 2016, 7:08 a.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 762
> > 
> >
> > s/optional ShareInfo share/optional ShareableInfo shareable
> 
> Anindya Sinha wrote:
> Will change as appropriate.

Updated to `optional SharedInfo shared`.


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45958/#review127960
---


On April 29, 2016, 12:15 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45958/
> ---
> 
> (Updated April 29, 2016, 12:15 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4892
> https://issues.apache.org/jira/browse/MESOS-4892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added ShareInfo in Resource protobuf to allow for sharing of resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 9a180304996895e2e003085690a7dff9ec561e9c 
>   include/mesos/v1/mesos.proto 44b4f8a059f9dfdcbf02f0c30c1b859898c2e617 
> 
> Diff: https://reviews.apache.org/r/45958/diff/
> 
> 
> Testing
> ---
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shared.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45958/
---

(Updated May 22, 2016, 7:05 a.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Renamed ShareInfo to SharedInfo.


Summary (updated)
-

Updated protobuf Resource to mark the resource as shared.


Bugs: MESOS-4892
https://issues.apache.org/jira/browse/MESOS-4892


Repository: mesos


Description (updated)
---

Added SharedInfo in Resource protobuf to allow for sharing of resources.


Diffs (updated)
-

  include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 
  include/mesos/v1/mesos.proto 9e59aed20965d50ee10989ff6b75db742cf2b83b 

Diff: https://reviews.apache.org/r/45958/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 47671: Windows: Allowed `dynamic_cast` on an object being constructed.

[Daniel Pravat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47671/
---

(Updated May 22, 2016, 6:59 a.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
Van Remoortere, and Michael Park.


Summary (updated)
-

Windows: Allowed `dynamic_cast` on an object being constructed.


Bugs: MESOS-5428
https://issues.apache.org/jira/browse/MESOS-5428


Repository: mesos


Description (updated)
---

Windows: Allowed `dynamic_cast` on an object being constructed.


Diffs (updated)
-

  cmake/CompilationConfigure.cmake 5c7833ceaed556cc4ffb650996e918c1a542c5f0 

Diff: https://reviews.apache.org/r/47671/diff/


Testing (updated)
---

Windows: build/run


Thanks,

Daniel Pravat