Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49137/#review139350 --- src/master/http.cpp (line 1290)

Review Request 49185: Added test for file volume from host.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49185/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Timothy Chen, and Jiang Yan

Review Request 49184: Implemented file volume support in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49184/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Timothy Chen, and Jiang Yan

Review Request 49186: Added test for file volume from host sandbox mountpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49186/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Timothy Chen, and Jiang Yan

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49137/#review139339 --- Patch looks great! Reviews applied: [49136, 49137] Passed comman

Re: Review Request 49170: Added a bullet point on JIRA and a snippet on AFFILIATIONS.yml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49170/ --- (Updated June 23, 2016, 9:49 p.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 49170: Added a bullet point on JIRA and a snippet on AFFILIATIONS.yml.

> On June 23, 2016, 5:12 p.m., Vinod Kone wrote: > > docs/submitting-a-patch.md, line 29 > > > > > > Lets ask them to include the PR# created above in the email. We should get a notification from merginng the PR, so

Re: Review Request 49067: Added AFFILIATIONS.yml file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49067/ --- (Updated June 23, 2016, 9:47 p.m.) Review request for mesos, Joris Van Remoorte

Review Request 49178: Configured single output binary folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49178/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos Descript

Re: Review Request 49118: Move allocator header and proto to own package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49118/#review139333 --- Bad patch! Reviews applied: [49118, 48902] Failed command: ./sup

Re: Review Request 49171: Added a `Networking` section.

> On June 24, 2016, 2:36 a.m., Qian Zhang wrote: > > docs/networking.md, line 154 > > > > > > Do we have this doc (networking_docker.md) in Mesos git repo? My bad. Was still debating if we should have a separate sec

Re: Review Request 49171: Added a `Networking` section.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49171/ --- (Updated June 24, 2016, 3:27 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 49157: Added missing comments for operator API protos.

> On June 24, 2016, 12:27 a.m., Vinod Kone wrote: > > include/mesos/master/master.proto, line 319 > > > > > > can you include informaation about which roles weights are listed here? > > for every role listed above?

Review Request 49176: Showed that Network::remove is un-used in the codebase.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49176/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, Artem

Review Request 49174: Added test-only function for retrieving link sockets from libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49174/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, Artem

Review Request 49177: Added 'relink' semantics to ProcessBase::link.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49177/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, Artem

Review Request 49175: Added tests for libprocess linking and unlinking behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49175/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, Artem

Re: Review Request 48968: Fixed bug in '/reserve' endpoint validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48968/#review139328 --- Patch looks great! Reviews applied: [48968] Passed command: expo

Re: Review Request 49171: Added a `Networking` section.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49171/#review139326 --- docs/networking.md (line 13)

Re: Review Request 49167: Updated MasterAPITest.SetQuota for GET_QUOTA and REMOVE_QUOTA APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49167/ --- (Updated June 24, 2016, 2:22 a.m.) Review request for mesos, Abhishek Dasgupta,

Re: Review Request 49166: Fixed incorrect headers in nodist_v1quota_HEADERS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49166/ --- (Updated June 24, 2016, 2:22 a.m.) Review request for mesos, Abhishek Dasgupta,

Re: Review Request 49165: Implemented GET_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49165/ --- (Updated June 24, 2016, 2:21 a.m.) Review request for mesos, Abhishek Dasgupta,

Re: Review Request 49164: Implemented REMOVE_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49164/ --- (Updated June 24, 2016, 2:21 a.m.) Review request for mesos, Abhishek Dasgupta,

Re: Review Request 48705: Implemented LIST_FILES Call in v1 agent API.

> On June 24, 2016, 12:51 a.m., Anand Mazumdar wrote: > > src/slave/http.cpp, lines 666-714 > > > > > > We can use the `FilesError` type's to construct the response here and > > just have one public `browse` that do

Re: Review Request 49166: Fixed incorrect headers in nodist_v1quota_HEADERS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49166/ --- (Updated June 24, 2016, 2:03 a.m.) Review request for mesos, Abhishek Dasgupta,

Re: Review Request 49166: Fixed incorrect headers in nodist_v1quota_HEADERS.

> On June 24, 2016, 12:38 a.m., Zhitao Li wrote: > > src/master/http.cpp, line 680 > > > > > > This shouldn't be here LoL. Thank you very much, let me fixed. - haosdent --

Re: Review Request 49165: Implemented GET_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49165/ --- (Updated June 24, 2016, 2:01 a.m.) Review request for mesos, Abhishek Dasgupta,

Re: Review Request 48705: Implemented LIST_FILES Call in v1 agent API.

> On 六月 24, 2016, 12:51 a.m., Anand Mazumdar wrote: > > src/slave/http.cpp, lines 666-714 > > > > > > We can use the `FilesError` type's to construct the response here and > > just have one public `browse` that does

Re: Review Request 49157: Added missing comments for operator API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/ --- (Updated June 24, 2016, 1:58 a.m.) Review request for mesos, Abhishek Dasgupta,

Re: Review Request 49157: Added missing comments for operator API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/ --- (Updated June 24, 2016, 1:55 a.m.) Review request for mesos, Abhishek Dasgupta,

Re: Review Request 49157: Added missing comments for operator API protos.

> On 六月 24, 2016, 12:27 a.m., Vinod Kone wrote: > > include/mesos/master/master.proto, line 319 > > > > > > can you include informaation about which roles weights are listed here? > > for every role listed above? >

Review Request 49136: Add Framework protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49136/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. Bugs:

Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49137/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. Bugs:

Re: Review Request 49157: Added missing comments for operator API protos.

> On June 24, 2016, 12:27 a.m., Vinod Kone wrote: > > include/mesos/master/master.proto, line 319 > > > > > > can you include informaation about which roles weights are listed here? > > for every role listed above?

Re: Review Request 49167: Updated MasterAPITest.SetQuota for GET_QUOTA and REMOVE_QUOTA APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49167/#review139318 --- Bad patch! Reviews applied: [49167, 49166, 49165, 49164] Failed

Re: Review Request 48705: Implemented LIST_FILES Call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48705/#review139317 --- include/mesos/v1/agent/agent.proto (line 81)

Re: Review Request 49118: Move allocator header and proto to own package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49118/ --- (Updated June 24, 2016, 12:51 a.m.) Review request for mesos, Joris Van Remoort

Re: Review Request 48704: Updated FilesProcess to support List_Files Call in Operator API v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48704/#review139314 --- hmm, we can do some refactoring here. Have a look at my later comm

Re: Review Request 49166: Fixed incorrect headers in nodist_v1quota_HEADERS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49166/#review139315 --- src/master/http.cpp (line 680)

Re: Review Request 49157: Added missing comments for operator API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139312 --- LGTM overall. include/mesos/master/master.proto (line 64)

Re: Review Request 49157: Added missing comments for operator API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139309 --- include/mesos/master/master.proto (lines 306 - 307)

Re: Review Request 49131: Fixed failed authorization of '/files/*' endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49131/#review139308 --- Patch looks great! Reviews applied: [49131] Passed command: expo

Review Request 49171: Added a `Networking` section.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49171/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5699 https://issues.apache

Re: Review Request 47973: Updated gc to prevent early exit in case of error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47973/#review139303 --- Patch looks great! Reviews applied: [47972, 47973] Passed comman

Re: Review Request 49118: Move allocator header and proto to own package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49118/#review139172 --- Fix it, then Ship it! docs/upgrades.md (line 263)

Re: Review Request 48968: Fixed bug in '/reserve' endpoint validation.

> On June 23, 2016, 7:34 p.m., Neil Conway wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, line 527 > > > > > > Why are we doing `create-volumes` twice but not testing > > `destroy-volumes`? > > > >

Re: Review Request 48968: Fixed bug in '/reserve' endpoint validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48968/ --- (Updated June 23, 2016, 9:29 p.m.) Review request for mesos, Anand Mazumdar, Ne

Re: Review Request 49067: Added AFFILIATIONS.yml file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49067/ --- (Updated June 23, 2016, 2:27 p.m.) Review request for Joris Van Remoortere and

Re: Review Request 49067: Added AFFILIATIONS.yml file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49067/ --- (Updated June 23, 2016, 2:23 p.m.) Review request for Joris Van Remoortere and

Re: Review Request 49155: Implement GET_STATE_SUMMARY Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49155/#review139297 --- Patch looks great! Reviews applied: [49155] Passed command: expo

Re: Review Request 48751: Implement GetState response for master API.

> On June 23, 2016, 5:34 p.m., Zhitao Li wrote: > > include/mesos/master/master.proto, lines 223-224 > > > > > > Per previous conversation with Jay Guo, I'm inclined to make most > > fields as optional for now unles

Review Request 49165: Implemented GET_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49165/ --- Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay Guo,

Review Request 49166: Fixed incorrect headers in nodist_v1quota_HEADERS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49166/ --- Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay Guo,

Review Request 49167: Updated MasterAPITest.SetQuota for GET_QUOTA and REMOVE_QUOTA APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49167/ --- Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay Guo,

Review Request 49164: Implemented REMOVE_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49164/ --- Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay Guo,

Re: Review Request 48968: Fixed bug in '/reserve' endpoint validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48968/#review139289 --- src/tests/persistent_volume_endpoints_tests.cpp (line 527)

Re: Review Request 49157: Added missing comments for operator API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139287 --- Patch looks great! Reviews applied: [49157] Passed command: expo

Re: Review Request 49131: Fixed failed authorization of '/files/*' endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49131/ --- (Updated June 23, 2016, 6:55 p.m.) Review request for mesos, Adam B and Vinod K

Re: Review Request 49131: Fixed failed authorization of '/files/*' endpoints.

> On June 23, 2016, 6:09 p.m., Adam B wrote: > > src/files/files.cpp, lines 321-323 > > > > > > You don't even need the if clause anymore, since strings::remove() is a > > noop when "/" isn't the suffix. Ah, than

Re: Review Request 49131: Fixed failed authorization of '/files/*' endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49131/#review139282 --- src/files/files.cpp (lines 321 - 323)

Re: Review Request 49131: Fixed failed authorization of '/files/*' endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49131/ --- (Updated June 23, 2016, 6:06 p.m.) Review request for mesos, Adam B and Vinod K

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

> On June 20, 2016, 10:16 a.m., Jiang Yan Xu wrote: > > In terms of testing, if we don't crash the agent within > > `syncCheckpointedResources()` but rather return a failure when its fails > > during recovery, we can capture this in `Slave::__recover` and verify the > > failed future right? E

Re: Review Request 49140: Added startsWith/endsWith to support char.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49140/#review139279 --- Patch looks great! Reviews applied: [49140] Passed command: expo

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

> On June 8, 2016, 6:28 a.m., Neil Conway wrote: > > Overall seems like a reasonable approach. > > > > One thing that isn't clear to me: what is the advantage of updating the > > checkpoint to reflect any partial work that was done before exiting? It > > seems that adds a bunch of complexity a

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

> On June 20, 2016, 10:16 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp, line 2513 > > > > > > The first argument is already a member variable and doesn't need to be > > passed around right? > > > > It

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/#review139100 --- src/slave/paths.hpp (lines 86 - 89)

Re: Review Request 48751: Implement GetState response for master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48751/#review139277 --- include/mesos/master/master.proto (lines 223 - 224)

Re: Review Request 47973: Updated gc to prevent early exit in case of error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47973/ --- (Updated June 23, 2016, 5:32 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 47972: Updated rmdir to continue deletion on error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47972/ --- (Updated June 23, 2016, 5:32 p.m.) Review request for mesos, Alex Clemmer, Jori

Re: Review Request 48751: Implement GetState response for master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48751/#review139276 --- include/mesos/master/master.proto (lines 223 - 224)

Re: Review Request 49082: Enabled fine grained authorization in the Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49082/#review139273 --- Fix it, then Ship it! LGTM. I can update the comment before com

Re: Review Request 49155: Implement GET_STATE_SUMMARY Call in v1 master API.

> On June 23, 2016, 5:12 p.m., Zhitao Li wrote: > > include/mesos/master/master.proto, line 279 > > > > > > I think we should unified messages for different `Get*` calls in the V1 > > API. > > > > IMO, the

Re: Review Request 49155: Implement GET_STATE_SUMMARY Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49155/#review139274 --- include/mesos/master/master.proto (line 279)

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

> On June 8, 2016, 1:28 p.m., Neil Conway wrote: > > Overall seems like a reasonable approach. > > > > One thing that isn't clear to me: what is the advantage of updating the > > checkpoint to reflect any partial work that was done before exiting? It > > seems that adds a bunch of complexity a

Review Request 48968: Fixed bug in '/reserve' endpoint validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48968/ --- Review request for mesos, Anand Mazumdar, Neil Conway, and Vinod Kone. Bugs: ME

Re: Review Request 48453: Track UPIDs based on executor id in scheduler driver.

> On June 9, 2016, 9:16 a.m., Neil Conway wrote: > > src/sched/sched.cpp, line 1001 > > > > > > What happens in the following scenario: > > > > * framework launches task with executor (=> add UPID to `taskP

Re: Review Request 48375: Rearranged Nvidia GPU files to cleanup semantics for header inclusion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48375/ --- (Updated June 23, 2016, 4:34 p.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 48373: Integrated the `NvidiaGpuAllocator` into the `NvidiaGpuIsolator`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48373/ --- (Updated June 23, 2016, 4:34 p.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 48374: Added class to share Nvidia-specific components between containerizers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48374/ --- (Updated June 23, 2016, 4:34 p.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 48372: Updated `Containerizer::resources()` to use the `NvidiaGpuAllocator`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48372/ --- (Updated June 23, 2016, 4:33 p.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 48371: Added `NvidiaGpuAllocator` component.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48371/ --- (Updated June 23, 2016, 4:33 p.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 49082: Enabled fine grained authorization in the Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49082/#review139264 --- Patch looks great! Reviews applied: [49082] Passed command: expo

Re: Review Request 49157: Added missing comments for operator API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/ --- (Updated June 23, 2016, 3:47 p.m.) Review request for mesos, Abhishek Dasgupta,

Review Request 49157: Added missing comments for operator API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/ --- Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay Guo,

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

> On June 8, 2016, 6:28 a.m., Neil Conway wrote: > > Overall seems like a reasonable approach. > > > > One thing that isn't clear to me: what is the advantage of updating the > > checkpoint to reflect any partial work that was done before exiting? It > > seems that adds a bunch of complexity a

Review Request 49155: Implement GET_STATE_SUMMARY Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49155/ --- Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, Vinod Kone,

Review Request 49140: Added startsWith/endsWith to support char.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49140/ --- Review request for mesos and Michael Park. Bugs: MESOS-5692 https://issues.

Re: Review Request 49132: Fixed an unsafe callback in the Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49132/#review139259 --- Ship it! Ship It! - Anand Mazumdar On June 23, 2016, 6:08 a.

Re: Review Request 49132: Fixed an unsafe callback in the Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49132/#review139256 --- Patch looks great! Reviews applied: [49132] Passed command: expo

Re: Review Request 49082: Enabled fine grained authorization in the Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49082/ --- (Updated June 23, 2016, 3:30 p.m.) Review request for mesos, Adam B, Joerg Scha

Re: Review Request 49082: Enabled fine grained authorization in the Agent.

> On June 23, 2016, 2:14 p.m., Adam B wrote: > > src/slave/http.cpp, line 861 > > > > > > How many things from the current context do we really need to pull into > > this lambda? Is it safe to pull them all in? Jus

Re: Review Request 49064: Implement v1 operator update weights API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49064/#review139245 --- Patch looks great! Reviews applied: [48924, 48925, 48940, 49064]

Re: Review Request 49132: Fixed an unsafe callback in the Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49132/#review139244 --- Ship it! Ship It! - Adam B On June 22, 2016, 11:08 p.m., Gre

Re: Review Request 49082: Enabled fine grained authorization in the Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49082/ --- (Updated June 23, 2016, 5:30 a.m.) Review request for mesos, Adam B, Joerg Scha

Re: Review Request 49082: Enabled fine grained authorization in the Agent.

> On June 23, 2016, 5:14 a.m., Adam B wrote: > > src/slave/http.cpp, line 150 > > > > > > Is it safe to pass `this` through here? Could you instead just pass > > immutable copies of `executor_->launchedTasks` and `f

Re: Review Request 49082: Enabled fine grained authorization in the Agent.

> On June 23, 2016, 2:14 p.m., Adam B wrote: > > src/slave/http.cpp, line 150 > > > > > > Is it safe to pass `this` through here? Could you instead just pass > > immutable copies of `executor_->launchedTasks` and `f

Re: Review Request 49131: Fixed failed authorization of '/files/*' endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49131/#review139239 --- Fix it, then Ship it! Nice catch. Update to use `strings::remov

Re: Review Request 49082: Enabled fine grained authorization in the Agent.

> On June 23, 2016, 2:14 p.m., Adam B wrote: > > src/slave/http.cpp, line 162 > > > > > > Ditto on `this` here and elsewhere sambe as above. - Alexander --

Re: Review Request 49082: Enabled fine grained authorization in the Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49082/#review139234 --- Looks pretty good to me. Just some questions about the lambda para

Re: Review Request 49071: Updated CNI test to verify the checkpointed CNI network config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49071/#review139233 --- Patch looks great! Reviews applied: [49069, 49070, 49071] Passed

  1   2   >