st if I know the background or the
issue. Because this test is not trivial, I would argue the user story helps.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39450/#review105885
--
740cfa801ee90417c038308192d1f4f2416f8315
Diff: https://reviews.apache.org/r/39450/diff/
Testing
---
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
c65fe35198b846da2dc959dd467a21ff6edd30a9
src/master/allocator/mesos/hierarchical.cpp
2765526047767cbd19d13c11ecfa6e90c505b3a7
Diff: https://reviews.apache.org/r/40332/diff/
Testing
---
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
it:
https://reviews.apache.org/r/39400/#review107563
---
On Nov. 11, 2015, 10:29 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply
/allocator/mesos/hierarchical.hpp
c65fe35198b846da2dc959dd467a21ff6edd30a9
Diff: https://reviews.apache.org/r/40586/diff/
Testing
---
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
ed extra blank line
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40586/#review107548
---
On Nov. 22, 2015, 11:5
in order to use one flag.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107780
---
On Nov. 24, 201
2a21364fdcaa4ec5e5567b9f367c14a1579b9a49
src/master/allocator/mesos/hierarchical.cpp
aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a
Diff: https://reviews.apache.org/r/40332/diff/
Testing
---
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
l. To reply, visit:
https://reviews.apache.org/r/39320/#review107625
---
On Nov. 23, 2015, 5:52 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generate
] FaultToleranceTest.FrameworkReregister (49 ms)
```
Thanks,
Alexander Rukletsov
> On Nov. 23, 2015, 6:45 p.m., Neil Conway wrote:
> > An alternative would be to pause and advance the clock by the
> > allocation_interval. Do you think that would be worth doing instead?
>
> Alexander Rukletsov wrote:
> That's correct. I was not sure what approach
t:
https://reviews.apache.org/r/40351/#review107545
---
On Nov. 23, 2015, 12:57 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e
tps://reviews.apache.org/r/39492/#comment166184>
let's `static_cast` to `int` explicitly
- Alexander Rukletsov
On Nov. 19, 2015, 3:19 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
tests.cpp (line 524)
<https://reviews.apache.org/r/39614/#comment166169>
`RepeatedField::size()` returns `int`
- Alexander Rukletsov
On Nov. 19, 2015, 2:48 p.m., Joerg Schad wrote:
>
>
> On Nov. 19, 2015, 2:53 p.m., Alexander Rukletsov wrote:
> > src/master/quota_handler.cpp, line 338
> > <https://reviews.apache.org/r/39492/diff/4/?file=1131960#file1131960line338>
> >
> > s/Status/status
> > Do you think it makes sense to add
On Nov. 19, 2015, 2:48 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39614/
> ---
>
> (Updated
5e5a575dc7dd49324f3c837028df8a7f75cd1f80
src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f
Diff: https://reviews.apache.org/r/40351/diff/
Testing
---
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f
Diff: https://reviews.apache.org/r/40351/diff/
Testing
---
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
t; > ```flatten()``` to remove role too? For dynamic reservation, in
> > ```Http::_operation()```, I see we do not call ```flatten()``` for offered
> > resources too, is it a bug?
>
> Alexander Rukletsov wrote:
> In this case everything should be fine. IIUC, there
8fc984003762a339a796b7a516362e21dab0a6e5
src/master/quota.cpp 835b191460d86e912ffdac8160459b4a0643bd88
Diff: https://reviews.apache.org/r/40399/diff/
Testing
---
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40351/#review106977
---
On Nov. 19, 2015, 5:10 p.m., Alexander Rukletsov wrote:
>
> -
tps://reviews.apache.org/r/39614/#comment166150>
I can't understand, why `quota` and not `guarantees`. What am I missing?
src/tests/master_quota_tests.cpp (line 794)
<https://reviews.apache.org/r/39614/#comment166151>
Let's expand this test beyond a simple size check.
- Alexander Rukletsov
status here as well?
src/tests/master_quota_tests.cpp (lines 785 - 787)
<https://reviews.apache.org/r/39614/#comment166138>
If we create an implicit contract that the status JSON is based on
`QuotaStatus` proto—which I think is a good idea—we should maybe check we can
convert the `JSON` to
> On Nov. 19, 2015, 10:39 a.m., Alexander Rukletsov wrote:
> > src/master/quota_handler.cpp, line 195
> > <https://reviews.apache.org/r/39492/diff/3/?file=1126166#file1126166line195>
> >
> > Am I right that there i
> On Jan. 7, 2016, 10:25 a.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, lines 97-99
> > <https://reviews.apache.org/r/41593/diff/14/?file=1181766#file1181766line97>
> >
> > Why this behaviour? I woul
u want plural here?
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42221/#review114126
---
On Jan. 12, 2016, 11:0
ed and the second for all frameworks.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42221/#review114126
---
On J
reply, visit:
> https://reviews.apache.org/r/42040/
> -------
>
> (Updated Jan. 11, 2016, 6:51 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van
> Remoortere, and Neil Conway.
>
> On Jan. 13, 2016, 11:41 a.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1164-1166
> > <https://reviews.apache.org/r/41769/diff/2/?file=1180221#file1180221line1164>
> >
> > This looks like a bug to me. I can't
)
<https://reviews.apache.org/r/41769/#comment175008>
This looks like a bug to me. I can't remember why we have `break` here in
the first place. Could you please elaborate why do you think `break` is fine
here?
- Alexander Rukletsov
On Dec. 31, 2015, 11:34 p.m., Guangya Liu
://reviews.apache.org/r/41949/diff/
Testing
---
`make check` on Mac OS 10.10.5
Thanks,
Alexander Rukletsov
)
-
src/tests/hierarchical_allocator_tests.cpp
e044f832c2c16e53e663c6ced5452649bb0dcb59
Diff: https://reviews.apache.org/r/41950/diff/
Testing
---
`make check` on Mac OS 10.10.5
Thanks,
Alexander Rukletsov
/quota.cpp df2cc5877160df101222756739f042895ceacc95
src/master/quota_handler.cpp 134a93b1d1b6e050aa8a5037ffbec2cc305b0694
Diff: https://reviews.apache.org/r/41947/diff/
Testing
---
`make check` on Mac OS 10.10.5
Thanks,
Alexander Rukletsov
10.10.5
Thanks,
Alexander Rukletsov
validation.
Diffs (updated)
-
src/tests/registrar_tests.cpp 6064621a001d66423f9b2dc7b749b67d9fc4bc13
Diff: https://reviews.apache.org/r/41948/diff/
Testing
---
`make check` on Mac OS 10.10.5
Thanks,
Alexander Rukletsov
/41648/diff/
Testing
---
`make check` on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
: https://reviews.apache.org/r/41937/diff/
Testing
---
`make check` on Mac OS 10.10.5
Thanks,
Alexander Rukletsov
/41936/diff/
Testing
---
`make check` on Mac OS 10.10.5
Thanks,
Alexander Rukletsov
---
`make check` on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
: mesos
Description
---
See summary.
Diffs
-
src/master/allocator/mesos/hierarchical.cpp
df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f
Diff: https://reviews.apache.org/r/4/diff/
Testing
---
None: not a functional change.
Thanks,
Alexander Rukletsov
pose? Do you want to do it in a
separate patch explaining the reasoning?
- Alexander Rukletsov
On May 30, 2016, 1:17 p.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
--
>
> (Updated May 30, 2016, 1:17 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod
> Kone, and Zhitao Li.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> See summary.
>
>
>
right?
- Alexander Rukletsov
On May 30, 2016, 1:17 p.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
us', 'ms', 'secs', 'mins', 'hrs', 'days', and
'weeks'");
```
- Alexander Rukletsov
On May 23, 2016, 3:41 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply
--
On May 30, 2016, 1:17 p.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48039/
> ---
>
> (
`value`).
- Alexander Rukletsov
On May 26, 2016, 8:25 a.m., Adam B wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
b41f46b6c7bdbf58549635a6f345b4b5f98d5c52
Diff: https://reviews.apache.org/r/49089/diff/
Testing
---
make check
Thanks,
Alexander Rukletsov
;https://reviews.apache.org/r/48947/#comment204005>
Ditto.
- Alexander Rukletsov
On June 20, 2016, 9:37 a.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To rep
/49062/diff/
Testing
---
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
Description
---
See summary.
Diffs
-
src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e
Diff: https://reviews.apache.org/r/49060/diff/
Testing
---
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
Description
---
See summary.
Diffs
-
src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e
Diff: https://reviews.apache.org/r/49061/diff/
Testing
---
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
Description
---
See summary.
Diffs
-
src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e
Diff: https://reviews.apache.org/r/49063/diff/
Testing
---
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
/
Testing
---
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
and Michael Park.
Repository: mesos
Description
---
See summary.
Diffs (updated)
-
src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e
Diff: https://reviews.apache.org/r/49063/diff/
Testing
---
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
/49088/diff/
Testing
---
make check
Thanks,
Alexander Rukletsov
(line 352)
<https://reviews.apache.org/r/48733/#comment202979>
According to the changelog, we call it 1.0.0 officially. Could you please
update?
- Alexander Rukletsov
On June 15, 2016, 3:21 p.m., Joerg Schad
> On June 15, 2016, 6:32 p.m., Alexander Rukletsov wrote:
> > src/authorizer/local/authorizer.cpp, line 352
> > <https://reviews.apache.org/r/48733/diff/1/?file=1420032#file1420032line352>
> >
> > According to the changelog, we call it 1.0.0 officially. Cou
> On June 15, 2016, 6:55 p.m., Alexander Rukletsov wrote:
> > src/module/manager.cpp, line 100
> > <https://reviews.apache.org/r/48733/diff/1/?file=1420039#file1420039line100>
> >
> > Did you leave out that 0.29.0 on purp
and commit this shortly.
src/module/manager.cpp (line 100)
<https://reviews.apache.org/r/48733/#comment202988>
Did you leave out that 0.29.0 on purpose?
- Alexander Rukletsov
On June 15, 2016, 3:21 p.m., Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48787/#review137967
---
Ship it!
Ship It!
- Alexander Rukletsov
On June 16, 2016
-
>
> (Updated May 2, 2016, 10:35 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, and haosdent huang.
>
>
> Bugs: MESOS-5313
> https://issues.apache.org/jira/browse/MESOS-5313
>
>
> Repository: mesos
>
>
>
/reviews.apache.org/r/46872/
> ---
>
> (Updated May 2, 2016, 10:35 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, and haosdent huang.
>
>
> Bugs: MESOS-5313
> https://issues.apache.org/jira/browse/MESOS-5313
>
>
> Repository: mesos
>
>
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/#review138135
---
Ship it!
Ship It!
- Alexander Rukletsov
On June 16, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48040/#review138137
---
Ship it!
Ship It!
- Alexander Rukletsov
On June 16, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/#review138131
---
Ship it!
Ship It!
- Alexander Rukletsov
On June 16, 2016
> On June 21, 2016, 1:19 p.m., Alexander Rukletsov wrote:
> > Why do you think it is a typo?
>
> Guangya Liu wrote:
> I think that here we should "preventing non-GPU workloads from using
> precious GPU resources", comments?
But this is what the original
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48986/#review138826
---
Why do you think it is a typo?
- Alexander Rukletsov
On June
3a53ef74f3e80e832804a21cebe0fc9e405420cb
Diff: https://reviews.apache.org/r/49049/diff/
Testing
---
make check
Thanks,
Alexander Rukletsov
tps://reviews.apache.org/r/48920/#comment203681>
As in r/48919/, let's not create an empty body.
3rdparty/libprocess/src/process.cpp (line 3387)
<https://reviews.apache.org/r/48920/#comment203682>
Ditto.
- Alexander Rukletsov
On June 19, 2016, 9:01 p.m., Till Toe
tend to insert a blank line in this case : ).
- Alexander Rukletsov
On June 19, 2016, 9:02 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To
` when the authenticator
or the authorizer fails to process the request.
- Alexander Rukletsov
On June 19, 2016, 9 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
(line 1225)
<https://reviews.apache.org/r/48919/#comment203734>
Why not `future.failure?`?
- Alexander Rukletsov
On June 20, 2016, 5:50 a.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48923/#review138539
---
Ship it!
Ship It!
- Alexander Rukletsov
On June 20, 2016, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48920/#review138538
---
Ship it!
Ship It!
- Alexander Rukletsov
On June 20, 2016, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48918/#review138537
---
Ship it!
Ship It!
- Alexander Rukletsov
On June 20, 2016, 5
tps://reviews.apache.org/r/48932/#comment203736>
Backticks : ). I would also put http status code name under backticks.
- Alexander Rukletsov
On June 20, 2016, 1:03 a.m., Till Toenshoff wrote:
>
> ---
> This is an automatica
allocator code
lives is as well. I've once started that effort
(https://reviews.apache.org/r/29930/) but decided to discard because allocator
is the master-only component.
- Alexander Rukletsov
On June 18, 2016, 6:36 a.m., Zhitao Li wrote
messages as `required`. Absent
// `Entity` is ambiguous: it can be interpreted as `NONE` or `ANY`.
```
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48936/#review138507
------
: https://reviews.apache.org/r/48936/diff/
Testing
---
None: Not a functional change.
Thanks,
Alexander Rukletsov
://reviews.apache.org/r/48937/diff/
Testing
---
None: Not a functional change.
Thanks,
Alexander Rukletsov
> On June 20, 2016, 8:06 a.m., Alexander Rukletsov wrote:
> > To avoid confusion, we should actually change the namespace allocator code
> > lives is as well. I've once started that effort
> > (https://reviews.apache.org/r/29930/) but decided to discard because
> &
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48037/#review138050
---
Ship it!
Ship It!
- Alexander Rukletsov
On June 16, 2016, 6
, and not the file,
right?
- Alexander Rukletsov
On May 1, 2016, 6:52 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
40/
> ---
>
> (Updated Jan. 8, 2016, 10:26 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van
> Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.o
Diff: https://reviews.apache.org/r/42255/diff/
Testing
---
None: not a functional change.
Thanks,
Alexander Rukletsov
> On Jan. 13, 2016, 3:05 p.m., Alexander Rukletsov wrote:
> > I'm reading section 1.2 of RFC2617 and see the following paragraph:
> >
> > > If the origin server does not wish to accept the credentials sent
> > > with a request, it SHOULD ret
> On Jan. 13, 2016, 1:52 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1185
> > <https://reviews.apache.org/r/42221/diff/1/?file=1194999#file1194999line1185>
> >
> > s/framwork/frameworks
>
> Alexander Rukletsov w
: not a functional change.
Thanks,
Alexander Rukletsov
tps://reviews.apache.org/r/42241/#comment175852>
Why do you need a loop here? Isn't it enought to advance once and then
settle?
- Alexander Rukletsov
On Jan. 18, 2016, 2:28 a.m., Jian Qiu wrote:
>
> ---
> This is an automatically g
f969975f242f7fc7a8b7a89e3e211d2201c9114a
docs/reservation.md 57cd92ce5d8d25b3393763614e40155e17e8c06e
Diff: https://reviews.apache.org/r/42255/diff/
Testing
---
None: not a functional change.
Thanks,
Alexander Rukletsov
uch shorter with the same meaning.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42221/#review114886
---
On Jan. 12, 2016, 11:0
`?
Correct, sorry!
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42305/#review114890
---
On Jan. 14, 2016, 3:3
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42222/#review114628
---
On Jan. 12, 2016, 11:06 p.m., Alexander Rukletsov wrote:
>
> ---
://reviews.apache.org/r/42476/diff/
Testing
---
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
: mesos
Description
---
See summary.
Diffs
-
docs/quota.md 1a6d2f07fb74d168a7eb30764ab9ff80cea5e3b6
Diff: https://reviews.apache.org/r/42477/diff/
Testing
---
None: Not a functional change.
Thanks,
Alexander Rukletsov
call so that frameworks in roles without quota are not
unnecessarily deprived of resources.
- Alexander Rukletsov
On Jan. 19, 2016, 8:50 a.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail
> On Jan. 19, 2016, 9:23 a.m., Alexander Rukletsov wrote:
> > Let's tweak some wording and testing and we are good to go!
> >
> > I liked the initial summary more. IMO a patch should describe the solution,
> > and not the problem. It's quite opposite for JIRA ticket
QUOTA_ROLE share = 0.25 (cpus=0.25, mem=128) [quota: cpus=0.25,
mem=128]
// framework1 share = 1
// NO_QUOTA_ROLE share = 0.75 (cpus=0.75, mem=384)
// framework2 share = 0
```
src/tests/hierarchical_allocator_tests.cpp (lines 1957 - 1958)
<https://reviews.apache.org/r/417
--------
On Jan. 18, 2016, 11:37 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42476/
> -
g/r/42289/#comment176028>
Let's add a `NOTE:` here that each `addSlave()` triggers an event-based
allocation.
src/tests/hierarchical_allocator_tests.cpp (lines 1826 - 1828)
<https://reviews.apache.org/r/42289/#comment176027>
Any reason why you change the original comment?
- A
601 - 700 of 2820 matches
Mail list logo
