chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
,
Alexander Rukletsov
.
Repository: mesos
Description
---
See summary.
Diffs (updated)
-
src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e
Diff: https://reviews.apache.org/r/44635/diff/
Testing
---
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander
---
See summary.
Diffs
-
src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866
src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e
Diff: https://reviews.apache.org/r/44709/diff/
Testing
---
`make check` on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
Diff: https://reviews.apache.org/r/44661/diff/
Testing
---
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
Diff: https://reviews.apache.org/r/44657/diff/
Testing
---
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
/
Testing
---
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
,
Alexander Rukletsov
/
Testing
---
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
/.
Thanks,
Alexander Rukletsov
.
Repository: mesos
Description
---
See summary.
Diffs (updated)
-
CHANGELOG 1fbf3029d35207041b5204ed5754a412d5870b3c
Diff: https://reviews.apache.org/r/44662/diff/
Testing (updated)
---
`make check` on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
://reviews.apache.org/r/44658/diff/
Testing
---
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
/
Testing
---
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
.
Repository: mesos
Description
---
See summary.
Diffs (updated)
-
src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e
Diff: https://reviews.apache.org/r/44651/diff/
Testing
---
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander
: https://reviews.apache.org/r/44656/diff/
Testing
---
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
.
Repository: mesos
Description
---
See summary.
Diffs (updated)
-
src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e
Diff: https://reviews.apache.org/r/43763/diff/
Testing
---
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander
/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2
src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe
Diff: https://reviews.apache.org/r/44630/diff/
Testing
---
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
/
Testing
---
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
eliminates the
> > // unfortunate poll delay.
> > ```
I think refactoring the reaper is a great idea but maybe not now. I will add an
extra time buffer and leave a todo to remove it once the reaper is updated.
- Alexander
-------
---
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
10.10.4:
`make check`
`GTEST_FILTER="*TaskKillPolicy*" ./bin/mesos-tests.sh --gtest_repeat=100
--gtest_break_on_failure`
Thanks,
Alexander Rukletsov
/.
Thanks,
Alexander Rukletsov
change.
Thanks,
Alexander Rukletsov
that "the next" guy will save some
time.
Also, I dream of cross-platform helper functions that will allow us to define
things like helper directory once, i.e. being able to call
`getTestScriptPath()` from this python helper...
- Alexander Rukletsov
On April 6, 2016, 5:25 a.m., Greg
tps://reviews.apache.org/r/46135/#comment192122>
If you're not doing any checks with resources, you can use
`Future` instead.
src/tests/master_allocator_tests.cpp (line 1637)
<https://reviews.apache.org/r/46135/#comment192121>
You don't need this `settle()`.
- Alexander Rukletsov
h allocation" now. Consistency in naming is
important to avoid confusion!
src/tests/hierarchical_allocator_tests.cpp (line 3077)
<https://reviews.apache.org/r/42342/#comment192107>
Let's stay consistent and call it "a batch allocation"
- Alexander Rukletsov
On April
="HierarchicalAllocatorTest*" ./bin/mesos-tests.sh
--gtest_break_on_failure --gtest_repeat=100`
Thanks,
Alexander Rukletsov
: https://reviews.apache.org/r/44334/diff/
Testing (updated)
---
On Mac OS X:
`make check`
`GTEST_FILTER="HierarchicalAllocatorTest*" ./bin/mesos-tests.sh
--gtest_break_on_failure --gtest_repeat=100`
Thanks,
Alexander Rukletsov
/
Thanks,
Alexander Rukletsov
Diff: https://reviews.apache.org/r/44335/diff/
Testing
---
Tested as a chain in https://reviews.apache.org/r/44336/
Thanks,
Alexander Rukletsov
03064da4a5feda0d64db6175c7d5a8e3122bb67a
Diff: https://reviews.apache.org/r/44336/diff/
Testing
---
On Mac OS 10.10.4:
`make check`
`GTEST_FILTER="HierarchicalAllocatorTest.*" ./bin/mesos-tests.sh
--gtest_repeat=100 --gtest_break_on_failure --gtest_shuffle`
Thanks,
Alexander Rukletsov
/
Testing
---
Tested as a chain in https://reviews.apache.org/r/44336/
Thanks,
Alexander Rukletsov
> On April 13, 2016, 9:27 a.m., Alexander Rukletsov wrote:
> > src/tests/master_allocator_tests.cpp, line 1604
> > <https://reviews.apache.org/r/46135/diff/1/?file=1342280#file1342280line1604>
> >
> > If you're not doing any checks with resources,
arse command properly and that `tokenize` is error-prone in this case.
- Alexander Rukletsov
On April 13, 2016, 2:47 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/quota_handler.cpp 88247d6525b2aaeb58eea77376fd4ed8e0c653c3
Diff: https://reviews.apache.org/r/46033/diff/
Testing
---
make check
Thanks,
Alexander Rukletsov
with the globbing in the
description?
Btw, I was unaware of that patch and filed https://reviews.apache.org/r/46034/
. I'll discard it in favour of your patch.
- Alexander Rukletsov
On April 10, 2016, 6:41 a.m., Michael Park wrote
---
Manually tested on commits with description containing '*'. Committing with '*'
is failing without this patch with the reported line length being 400+
charachters.
Thanks,
Alexander Rukletsov
88247d6525b2aaeb58eea77376fd4ed8e0c653c3
Diff: https://reviews.apache.org/r/46033/diff/
Testing
---
make check
Thanks,
Alexander Rukletsov
`return BadRequest(
> "Failed to validate set quota request JSON '" + request.body +
> "': Unknown role '" + quotaInfo.role() + "'");
> }```
>
> Alexander Rukletsov wrote:
> Why should we?
Filed https://reviews.apache.or
,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46102/#review128647
---
Ship it!
Ship It!
- Alexander Rukletsov
On April 12, 2016
/rukletsov/unresponsive-process) tasks:
`./src/mesos-execute --master=127.0.0.1:5050 --name=test --command="sleep 10"
--env='{"GLOG_v": 2}'`
`./src/mesos-execute --master=127.0.0.1:5050 --name=test
--command="/Users/alex/bin/unresponsive_process" --env='{"GLOG_v": 2}'`
Thanks,
Alexander Rukletsov
Description
---
See summary.
Diffs
-
src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8
Diff: https://reviews.apache.org/r/45925/diff/
Testing
---
See the last patch in the chain: https://reviews.apache.org/r/45927/
Thanks,
Alexander Rukletsov
Description
---
See summary.
Diffs
-
src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8
Diff: https://reviews.apache.org/r/45926/diff/
Testing
---
See the last patch in the chain: https://reviews.apache.org/r/45927/
Thanks,
Alexander Rukletsov
after advancing the clock?
- Alexander Rukletsov
On Feb. 12, 2016, 2:47 p.m., Shuai Lin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45863/#review127755
---
@ReviewBot retry
- Alexander Rukletsov
On April 7, 2016, 10:50
? Thanks!
src/tests/master_allocator_tests.cpp (line 652)
<https://reviews.apache.org/r/43329/#comment191171>
I think it's fine to do this, but let's explain why we adjust the flag.
- Alexander Rukletsov
On March 30, 2016, 1:22 p.m., Shuai Lin
nge interval through flags in this test.
src/tests/master_tests.cpp (line 1042)
<https://reviews.apache.org/r/43515/#comment191175>
Move it up after `advance()`?
- Alexander Rukletsov
On Feb. 12, 2016, 6:36 a.m., ha
`settle` here because AWAIT_READY does it for us. However, we
should resume the clock since in the future we may have a check that the clock
is unpaused when test finishes.
- Alexander Rukletsov
On Feb. 19, 2016, 4:3
in repetition?
src/tests/master_tests.cpp (line 745)
<https://reviews.apache.org/r/43514/#comment191172>
I believe you do settle in order to make sure the container is destroyed.
Mind writing a comment?
Also, I think you can resume the clock right after advancing.
- Ale
limiting for
metrcis in tests altogether with https://reviews.apache.org/r/44073/. Correct?
- Alexander Rukletsov
On Feb. 12, 2016, 8:09 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To rep
> On Feb. 19, 2016, 2:50 a.m., Anand Mazumdar wrote:
> > src/tests/hook_tests.cpp, line 396
> > <https://reviews.apache.org/r/42241/diff/3/?file=1200496#file1200496line396>
> >
> > Is there a need to explicitly invoke `Clock::resume()` here? If not,
>
org/r/43514/#comment191173>
After the second thought, a better approach would be to create an instance
of master flags and extract the allocator interval from there.
- Alexander Rukletsov
On Feb. 12, 2016, 6:36 a.m., haosdent huang
://reviews.apache.org/r/41665/
- Alexander Rukletsov
On Feb. 11, 2016, 4:02 p.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
>
> (Updated Feb. 19, 2016, 4:36 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
>
>
> Bugs: MESOS-4174
> https://issues.apache.org/jira/browse/MESOS-4174
>
>
> Repository: mesos
>
>
> Description
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43321/#review127796
---
Could you please rebase it?
- Alexander Rukletsov
On March 30
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45863/#review127580
---
On April 7, 2016, 10:50 a.m., Alexander Rukletsov wrote:
>
> --
eviews.apache.org/r/45863/#review127580
---
On April 7, 2016, 10:50 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45863/
> ---
ted e-mail. To reply, visit:
https://reviews.apache.org/r/45927/#review127946
-------
On April 8, 2016, 12:39 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically
eviews.apache.org/r/45926/#review127945
---
On April 8, 2016, 12:39 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To re
visit:
https://reviews.apache.org/r/45926/#review127827
---
On April 8, 2016, 12:39 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To re
='{"GLOG_v": "2"}' --kill_after=2secs
./src/mesos-execute --master=127.0.0.1:5050 --name=test
--command="/Users/alex/bin/unresponsive_process" --env='{"GLOG_v": "2"}'
--kill_after=2secs
Thanks,
Alexander Rukletsov
/
Thanks,
Alexander Rukletsov
still validate flags in `main()` before we create an instance of
`CommandScheduler`. Moving validations into lambdas makes sense.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46
t was runtime configuration and was get from docker iamge.
>
> Alexander Rukletsov wrote:
> Why not? That's exactly what you do in https://reviews.apache.org/r/1/
>
> Guangya Liu wrote:
> In my understanding, what I did in r1 is for
> https://github.com/apac
st
--command="/Users/alex/bin/unresponsive_process" --env='{"GLOG_v": "2"}'
--kill_after=2secs`
Thanks,
Alexander Rukletsov
/
Thanks,
Alexander Rukletsov
description and then commit it for you.
src/tests/log_tests.cpp (line 1870)
<https://reviews.apache.org/r/43524/#comment191803>
s/is is/are in
Also we backtick variables and types
- Alexander Rukletsov
On April 9, 2016, 4:11 a.m., Shuai Lin
and commit it shortly.
Note that we use past tense in the summary and present in description.
- Alexander Rukletsov
On April 8, 2016, 6:32 p.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
(line 1000)
<https://reviews.apache.org/r/43521/#comment191820>
I understand why you need to make this change now, but I think we can kill
this comment, because it's not surprising that we wait for registration first
and then for offers.
- Alexander Rukletsov
On April 8, 2016, 6:
.
- Alexander Rukletsov
On April 9, 2016, 6:19 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
.
- Alexander Rukletsov
On April 9, 2016, 6:19 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
o long.
```
- Alexander Rukletsov
On April 9, 2016, 3:39 a.m., Shuai Lin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
.
- Alexander Rukletsov
On April 8, 2016, 3:43 p.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
shortly.
src/tests/oversubscription_tests.cpp (line 1037)
<https://reviews.apache.org/r/43522/#comment191822>
We should either kill this comment or pull it up one line.
- Alexander Rukletsov
On April 9, 2016, 6:16 a.m., haosdent huang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review128422
---
Ship it!
Ship It!
- Alexander Rukletsov
On April 9, 2016, 2
tests in
repetition.
- Alexander Rukletsov
On April 9, 2016, 6:16 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
.
src/tests/scheduler_tests.cpp (line 1075)
<https://reviews.apache.org/r/43321/#comment191848>
Any reason why not resuming right after advancing?
- Alexander Rukletsov
On April 9, 2016, 9:17 a.m., Shuai Lin
g/r/1/#comment191422>
You lost a period : )
- Alexander Rukletsov
On April 3, 2016, 1:42 p.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
in contrast to the end of the
previous line.
Diffs
-
src/master/weights_handler.cpp e88bf2ab67ccadf35879b92f3280298a43d7cd0e
Diff: https://reviews.apache.org/r/45863/diff/
Testing
---
On Mac OS 10.10.4:
`make check`
Thanks,
Alexander Rukletsov
/
Thanks,
Alexander Rukletsov
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45927/#review127829
-------
On April 11, 2016, 4:55 p.m., Alexander Rukletsov wrote:
>
> -
fter=2secs
./src/mesos-execute --master=127.0.0.1:5050 --name=test
--command="/Users/alex/bin/unresponsive_process" --env='{"GLOG_v": "2"}'
--kill_after=2secs
Thanks,
Alexander Rukletsov
g/r/1/#comment191605>
Let's write a comment here why `command` can be `None`.
- Alexander Rukletsov
On April 10, 2016, 1:12 p.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
,
Alexander Rukletsov
st
--command="/Users/alex/bin/unresponsive_process" --env='{"GLOG_v": "2"}'
--kill_after=2secs`
Thanks,
Alexander Rukletsov
and="/Users/alex/bin/unresponsive_process" --env='{"GLOG_v": 2}'
--kill_after=2secs`
Thanks,
Alexander Rukletsov
private when we refactor. Does it make sense?
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44654/#review123713
------
://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
---
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
="*TaskKillPolicy*" ./bin/mesos-tests.sh --gtest_repeat=100
--gtest_break_on_failure`
Thanks,
Alexander Rukletsov
/.
Thanks,
Alexander Rukletsov
.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44707/#review123743
---
On March 15, 2016, 3:47 p.m., Alexander
---
See summary,
Diffs
-
include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54
Diff: https://reviews.apache.org/r/45039/diff/
Testing
---
None: not a functional change.
Thanks,
Alexander Rukletsov
840534ff0687e82ed063c386e36bbabada230697
Diff: https://reviews.apache.org/r/44655/diff/
Testing
---
The complete chain was tested. See https://reviews.apache.org/r/44662/.
Thanks,
Alexander Rukletsov
:
`make check`
`GLOG_v=2 GTEST_FILTER="*SlaveTest*" ./bin/mesos-tests.sh --gtest_repeat=100
--gtest_break_on_failure`
Thanks,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44661/#review123787
---
On March 15, 2016, 2:28 p.m., Alexander Rukletsov wr
/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e
src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e
Diff: https://reviews.apache.org/r/44709/diff/
Testing
---
`make check` on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
bf866f5ebece2505eaa27bf39a1382cd1a2a069a
src/python/interface/src/mesos/interface/__init__.py
232890daa6d222ae1c86906bbc484c8e635c4eb7
Diff: https://reviews.apache.org/r/45039/diff/
Testing
---
None: not a functional change.
Thanks,
Alexander Rukletsov
901 - 1000 of 2820 matches
Mail list logo
