Re: Review Request 44071: Added documentation for new libprocess environment variable.

/ Testing --- Site rendered with packaged docker container. Thanks, Benjamin Bannier

Re: Review Request 43884: Added allocator metrics for used quotas.

metrics in the allocator while the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43882: Added allocation metrics for allocation time.

`HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

`HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43879: Added allocator metrics for number of allocations made.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review121255 ------- On March 2, 2016, 11:35 a.m., Benjamin Bannier wrote: > > --

Re: Review Request 43879: Added allocator metrics for number of allocations made.

the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Review Request 44261: Introduced a RAII helper for process::metrics::Timer.

/44261/diff/ Testing --- Thanks, Benjamin Bannier

Re: Review Request 43879: Added allocator metrics for number of allocations made.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120985 ------- On March 2, 2016, 11:35 a.m., Benjamin Bannier wrote: > >

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

allocator while the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43879: Added allocator metrics for number of allocations made.

- Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review121255 --- On March 2, 2016, 11:35 a.m., Benjamin Bannier wrote

Re: Review Request 43879: Added allocator metrics for number of allocations made.

- Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120985 --- On March 2, 2016, 11:35 a.m., Benjamin Bannier wrote

Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

. In the follow-up patch #43879 we use the introduced class successfully. Thanks, Benjamin Bannier

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

e comments. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review121405 --- On March 2, 2016, 11:35 a.m., Benjamin Ba

Re: Review Request 43882: Added allocation metrics for allocation time.

ould you please describe your intention, so that folks understand why > > it is fine? Thanks. I added a comment. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

g/r/43881/#review121360 --- On March 2, 2016, 11:34 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

", "allocator/allocated", name), > > totalGenerator)); > > > > ``` To make this more readable and obvious I introduced getters analoguous to `HierarchicalAllocatorProcess::_event_queue_dispatches`. - Benjamin -----

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

previously. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/#review121363 --- On March 2, 2016, 11:34 a.m., Benjamin Bann

Re: Review Request 43884: Added allocator metrics for used quotas.

en makes more sense. Fixed with specific and named getters like elsewhere. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review121366 ------

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

erts metrics in the allocator while the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43884: Added allocator metrics for used quotas.

work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

, Benjamin Bannier

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

enerated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121624 ------- On March 2, 2016, 4:43 p.m., Benjamin Bannier wrote: > > --- > This

Re: Review Request 44261: Introduced a RAII helper for process::metrics::Timer.

0a9c0227c457c6c81a59f65f901a5464ee00983d Diff: https://reviews.apache.org/r/44261/diff/ Testing (updated) --- `make check` succeeds under OS X (but this patch just adds a header). The follow-up patch using this header does not need further changes here though. Thanks, Benjamin Bannier

Re: Review Request 43882: Added allocation metrics for allocation time.

perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43879: Added allocator metrics for number of allocations made.

tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43879: Added allocator metrics for number of allocations made.

> On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > docs/monitoring.md, lines 872-874 > > <https://reviews.apache.org/r/43879/diff/9/?file=1273629#file1273629line872> > > > > Why not putting these onto the same line? > > Benjamin Ban

Re: Review Request 43884: Added allocator metrics for used quotas.

inserts metrics in the allocator while the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

/metrics.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44260/diff/ Testing --- `make distcheck` on OS X, but this patch only adds an unused header. In the follow-up patch #43879 we use the introduced class successfully. Thanks, Benjamin Bannier

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

s://reviews.apache.org/r/44260/#review121638 ------- On March 2, 2016, 4:43 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 44261: Introduced a RAII helper for process::metrics::Timer.

e lines now nevertheless. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44261/#review121635 --- On March 2, 2

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review121421 --- On March 2, 2016, 4:43 p.m., Benjamin Bannier wrote: > >

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

inserts metrics in the allocator while the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 44070: Allowed disabling metrics endpoint rate limiting via the environment.

/libprocess/include/process/metrics/metrics.hpp 09b716be56eac38f75d79d917799c001aa0b205c 3rdparty/libprocess/src/metrics/metrics.cpp a9840083722dd6b7b6aab692ed449407ab125ac7 Diff: https://reviews.apache.org/r/44070/diff/ Testing --- make check (OS X, not optimized) Thanks, Benjamin

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

distcheck` on OS X. Thanks, Benjamin Bannier

Re: Review Request 43884: Added allocator metrics for used quotas.

metrics in the allocator while the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

metrics in the allocator while the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43879: Added allocator metrics for number of allocations made.

performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 44261: Introduced a RAII helper for process::metrics::Timer.

0a9c0227c457c6c81a59f65f901a5464ee00983d Diff: https://reviews.apache.org/r/44261/diff/ Testing --- `make check` succeeds under OS X (but this patch just adds a header). The follow-up patch using this header does not need further changes here though. Thanks, Benjamin Bannier

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

added code only inserts metrics in the allocator while the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

, Benjamin Bannier

Re: Review Request 43882: Added allocation metrics for allocation time.

asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

exists an `defer` > > override taking process instance. > > Benjamin Bannier wrote: > At least my clang does not trigger that overload. > > Alexander Rukletsov wrote: > > https://github.com/apache/mesos/blob/9bbba94021dde42c9d9d1fa0662462c364797018/3rdparty/libproc

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

llocator/mesos/metrics.hpp, line 43 > > <https://reviews.apache.org/r/44260/diff/1/?file=1276467#file1276467line43> > > > > Is it what clnag-format suggest? I doubt it : ) > > Benjamin Bannier wrote: > Yes, that's indeed what it suggests, at least with wh

Re: Review Request 43884: Added allocator metrics for used quotas.

since the added code only inserts metrics in the allocator while the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

. Thanks, Benjamin Bannier

Re: Review Request 44261: Introduced a RAII helper for process::metrics::Timer.

, Benjamin Bannier

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

Diff: https://reviews.apache.org/r/44260/diff/ Testing --- `make distcheck` on OS X. Thanks, Benjamin Bannier

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

while the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43879: Added allocator metrics for number of allocations made.

actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43882: Added allocation metrics for allocation time.

asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

, Benjamin Bannier

Re: Review Request 43879: Added allocator metrics for number of allocations made.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review121856 ------- On March 3, 2016, 5:17 p.m., Benjamin Bannier wrote: > > ---

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

useful; also, it is defined as a class. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121861 --- On March 3, 2016,

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

----- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review121860 --- On March 3, 2016, 5:17 p.m., Benjamin Bannier wrote: > > --

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

t;src/CMakeLists.txt" as well, here and below. Good point I did not think about. I updated `src/CMakeLists.txt`, but am unsure what other files you have in mind. - Benjamin --- This is an automatically generated e-mail

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

exists an `defer` > > override taking process instance. > > Benjamin Bannier wrote: > At least my clang does not trigger that overload. > > Alexander Rukletsov wrote: > > https://github.com/apache/mesos/blob/9bbba94021dde42c9d9d1fa0662462c364797018/3rdparty/libp

Review Request 44343: Used single space in license check error message.

--- Used single space in license check error message. Diffs - support/mesos-style.py 815d88c1935ae8248cd76a73d3dd613312b1d730 Diff: https://reviews.apache.org/r/44343/diff/ Testing --- Thanks, Benjamin Bannier

Re: Review Request 44326: Added missing includes in metrics.

ss/src/metrics/metrics.cpp (line 33) <https://reviews.apache.org/r/44326/#comment183774> Not yours, but already included in the header. - Benjamin Bannier On March 3, 2016, 3:42 p.m., Alexander Rukletsov wrote: > > --- >

Re: Review Request 44325: Removed superfluous periods in failure messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44325/#review121920 --- Ship it! - Benjamin Bannier On March 3, 2016, 10:20 a.m

Re: Review Request 44343: Used single space in license check error message.

it: https://reviews.apache.org/r/44343/#review121927 --- On March 3, 2016, 6:06 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

creating files (that would be `BufferedRead` and `Redirect`), and other ones? - Benjamin Bannier On March 4, 2016, 8:27 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 43884: Added allocator metrics for used quotas.

diff/ > > > Testing > --- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

inserts metrics in the allocator while the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43882: Added allocation metrics for allocation time.

tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

inserts metrics in the allocator while the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43882: Added allocation metrics for allocation time.

t least I a word. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/#review122055 --- On March 4, 2016, 5:01 p.m., Benjamin Ba

Re: Review Request 43884: Added allocator metrics for used quotas.

added code only inserts metrics in the allocator while the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

f/14/?file=1279201#file1279201line2491> > > > > /cluster/cluster state/ Stated as such. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review122047 -

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

ache.org/r/43883/diff/13/?file=1279218#file1279218line2462> > > > > Here you can also check that 2 counters for offers filters were > > installed. We do now. - Benjamin --- This is an automatically

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

ock::settle(); > > ++allocations; > > ``` > > to keep clock manipulation together? So be it. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#re

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

exists an `defer` > > override taking process instance. > > Benjamin Bannier wrote: > At least my clang does not trigger that overload. > > Alexander Rukletsov wrote: > > https://github.com/apache/mesos/blob/9bbba94021dde42c9d9d1fa0662462c364797018/3rdparty/libp

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

uality), https://gist.github.com/bbannier/6e47d32eec9e0093711a - Benjamin Bannier On March 13, 2016, 5:15 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

reviews.apache.org/r/44380/#comment185636> Please keep this in its original location. - Benjamin Bannier On March 4, 2016, 7:56 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 44785: Don't use --as-needed on OSX.

tps://reviews.apache.org/r/44785/#comment185678> Could we instead make that decision based on the tool used instead of just the platform? LLVM's lld supports `--as-needed` now, or a user could link with gcc (e.g., via homebrew). - Benjamin Bannier On March 14, 2016, 3:21 p.m., St

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

> On March 4, 2016, 8:42 a.m., Benjamin Bannier wrote: > > I think using a `TemporaryDirectoryTest` fixture is the right approach, but > > what I find unfortunate about your approach is that with this patch we'd > > create a temporary directory and incur the over

Re: Review Request 43884: Added allocator metrics for used quotas.

clang(trunk) as compiler. Thanks, Benjamin Bannier

Review Request 44850: Added missing include in allocator/mesos/hierarchical.hpp.

-trunk) Thanks, Benjamin Bannier

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

partially expected since the added code only inserts metrics in the allocator while the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin

Re: Review Request 43879: Added allocator metrics for number of allocations made.

added code only inserts metrics in the allocator while the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Review Request 44853: Added benchmark test for the allocator metrics endpoint.

after already a few frameworks. Thanks, Benjamin Bannier

Review Request 44851: Renamed an allocator metric.

/ Testing (updated) --- check make check (OS X, clang-trunk) here and with later patches using other allocator metrics. Thanks, Benjamin Bannier

Review Request 44852: Documented existing allocator metrics.

: mesos Description --- Documented existing allocator metrics. Diffs (updated) - docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 Diff: https://reviews.apache.org/r/44852/diff/ Testing (updated) --- Checked rendering with packaged docker image. Thanks, Benjamin

Re: Review Request 43880: Added allocated metrics for total and allocated scalar resources.

asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43883: Added allocator metrics for the number of offer filters per framework.

` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 43882: Added allocation metrics for allocation time.

added code only inserts metrics in the allocator while the actual work is perform asynchronously. These tests where performed with `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build under OS X using clang(trunk) as compiler. Thanks, Benjamin Bannier

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

vel entities. - Benjamin Bannier On March 15, 2016, 2:38 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 44989: Fixed a race in the resource offers tests.

> On March 18, 2016, 12:16 a.m., Neil Conway wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Style-wise, do we want all tests to resume if they initially pause it? > > I think we do a mix of both.

Re: Review Request 43884: Added allocator metrics for used quotas.

compiler. Thanks, Benjamin Bannier

Re: Review Request 44852: Documented existing allocator metrics.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44852/#review124056 --- On March 18, 2016, 5:08 p.m., Benjamin Bannier wrote: > > --

Re: Review Request 44851: Renamed an allocator metric.

/44851/diff/ Testing --- check make check (OS X, clang-trunk) here and with later patches using other allocator metrics. Thanks, Benjamin Bannier

Re: Review Request 44853: Added benchmark test for the allocator metrics endpoint.

few frameworks. Thanks, Benjamin Bannier

Re: Review Request 43884: Added allocator metrics for used quotas.

ue` while `Metrics` returns a `JSON::Object`, so to use `contains` we need to create a `JSON::Value` somewhere. Since we cannot use `contains` to check for value absence we still need access to the `JSON::Object`'s `values`. If we'd choose to create the temporary just bef

Re: Review Request 44851: Renamed an allocator metric.

erly communicate that in their names. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44851/#review124143 ------- O

Re: Review Request 44852: Documented existing allocator metrics.

--- Checked rendering with packaged docker image. Thanks, Benjamin Bannier

Review Request 44912: Used the same fixture for all related tests.

/src/tests/io_tests.cpp 87fd3fafc29c01362bae0b77a2a332ec89a8b442 Diff: https://reviews.apache.org/r/44912/diff/ Testing --- make check (OS X, clang-trunk, not optimized) Thanks, Benjamin Bannier

<    1   2   3   4   5   6   7   8   9   10   >