led it =).
- Gastón
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57386/#review168227
---
On March 8, 2017, 11:08 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57422/#review168306
---
Ship it!
Ship It!
- Gastón Kleiman
On March 8, 2017, 3:56
56e90747f2c943daee675738428d8ddeeafde36d
Diff: https://reviews.apache.org/r/55901/diff/13/
Changes: https://reviews.apache.org/r/55901/diff/12-13/
Testing
---
Introduced a new test: `HealthCheckTest.DefaultExecutorCmdHealthCheck`. It
passes on Linux, but not on macOS, because of MESOS-7050.
Thanks,
Gastón
ea01fe55a28d17105157004d8cf0976202a49b7c
Diff: https://reviews.apache.org/r/57384/diff/1/
Testing
---
Added a test and verified that it works on Linux.
Thanks,
Gastón Kleiman
fdc4817ce74c45d792fc47f064f7909a83b1657d
Diff: https://reviews.apache.org/r/57386/diff/1/
Testing
---
Thanks,
Gastón Kleiman
.
Thanks,
Gastón Kleiman
://reviews.apache.org/r/57388/diff/1/
Testing
---
Thanks,
Gastón Kleiman
/57341/diff/1/
Testing
---
Thanks,
Gastón Kleiman
42edecc794b71a00ca32d26ae9b74e9f3ef97510
src/tests/slave_validation_tests.cpp 784528443469f68a8f2d93ebdb69dc872eef255d
Diff: https://reviews.apache.org/r/57387/diff/1/
Testing
---
Thanks,
Gastón Kleiman
9149724159485ea2265e1494c1ce7ef989dad20a
include/mesos/v1/agent/agent.proto 34210c30ca58f50b14ff3e5a01c54003c9705121
Diff: https://reviews.apache.org/r/57385/diff/1/
Testing
---
Thanks,
Gastón Kleiman
/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528
include/mesos/authorizer/authorizer.proto
fdc4817ce74c45d792fc47f064f7909a83b1657d
Diff: https://reviews.apache.org/r/57386/diff/1/
Testing
---
Thanks,
Gastón Kleiman
src/tests/containerizer/nested_mesos_containerizer_tests.cpp
ea01fe55a28d17105157004d8cf0976202a49b7c
Diff: https://reviews.apache.org/r/57384/diff/2/
Changes: https://reviews.apache.org/r/57384/diff/1-2/
Testing
---
Added a test and verified that it works on Linux.
Thanks,
Gastón
fdc4817ce74c45d792fc47f064f7909a83b1657d
Diff: https://reviews.apache.org/r/57386/diff/2/
Changes: https://reviews.apache.org/r/57386/diff/1-2/
Testing
---
Thanks,
Gastón Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58108/#review170735
---
Ship it!
Ship It!
- Gastón Kleiman
On March 31, 2017, 3:48
tps://reviews.apache.org/r/58196/#comment244250>
I'd add comments saying that this is the stderr/stdout of the TCP checker
process.
We should also change the logging level to `VLOG(1)` and also do something
similar for `HTTP` checks that use `curl`.
- Gastón Kleiman
On April 4, 2017,
://reviews.apache.org/r/61394/diff/1/
Testing
---
`sudo GLOG_v=1 bin/mesos-tests.sh
--gtest_filter="*LinuxCapabilitiesIsolatorTest*"`
Thanks,
Gastón Kleiman
://reviews.apache.org/r/61393/diff/1/
Testing
---
Used by a test in this same chain.
Thanks,
Gastón Kleiman
/1/
Testing
---
`bin/mesos-tests.sh --gtest_filter="PosixRLimitsIsolatorTest.NestedContainers"
--gtest_repeat=1000 --gtest_break_on_failure` passed on a machine running
GNU/Linux.
Thanks,
Gastón Kleiman
tps://reviews.apache.org/r/60439/#comment257792>
s/websiste/website/
- Gastón Kleiman
On July 27, 2017, 12:28 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
="DefaultExecutorTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyGPUDeviceAccess"
--gtest_repeat=3000 --gtest_break_on_failure --verbose` passed on a machine
with an Nvidia GPU.
Note: the tasks did get killed on another test run after 276 iterations,
leading to a test failure.
Thanks,
Gastón Kleiman
epeat=1000 --gtest_break_on_failure` passed on a machine running
GNU/Linux.
Thanks,
Gastón Kleiman
rTest*"`
Thanks,
Gastón Kleiman
995 (original), 1001 (patched)
<https://reviews.apache.org/r/61668/#comment258945>
We should send a TASK_KILLING update here, and address the TODOs added by
AlexR.
- Gastón Kleiman
On Aug. 15, 2017, 5:40 p.m., Anand Mazumdar
(patched)
<https://reviews.apache.org/r/61573/#comment258932>
The task ID is user-generated, so we usually put it in single quotes.
src/launcher/default_executor.cpp
Line 1059 (original), 1064 (patched)
<https://reviews.apache.org/r/61573/#comment258933>
Ditto.
- Gastón Klei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61573/#review182975
---
Ship it!
Ship It!
- Gastón Kleiman
On Aug. 14, 2017, 5:19
(patched)
<https://reviews.apache.org/r/61573/#comment258937>
We should send a `TASK_KILLING` update here, and address the TODOs added by
AlexR.
- Gastón Kleiman
On Aug. 14, 2017, 5:19 p.m., Anand Mazumdar
it take less than 3 seconds to run.
src/launcher/default_executor.cpp
Lines 1005-1006 (original), 1024-1025 (patched)
<https://reviews.apache.org/r/61668/#comment258941>
I think it'd be useful to include the container and task ids.
- Gastón Kleiman
On Aug. 15, 2017, 5:40 p.m.,
e that.
I couldn't find a test that checks this with the other executors, but I
think that we should at least add a TODO.
- Gastón Kleiman
On Aug. 15, 2017, 10:11 p.m., Anand Mazumdar wrote:
>
> ---
> This is
> On Aug. 14, 2017, 6:45 p.m., Gastón Kleiman wrote:
> > src/launcher/default_executor.cpp
> > Line 233 (original), 233 (patched)
> > <https://reviews.apache.org/r/61573/diff/2/?file=1796672#file1796672line233>
> >
> > shouldn't we also pass the
ID).
src/launcher/default_executor.cpp
Lines 1053-1054 (patched)
<https://reviews.apache.org/r/61573/#comment258833>
Ditto.
src/launcher/default_executor.cpp
Lines 1058-1059 (patched)
<https://reviews.apache.org/r/61573/#comment258834>
Ditto.
- Gastón Kleiman
On Aug. 14
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61571/#review182885
---
Ship it!
Ship It!
- Gastón Kleiman
On Aug. 10, 2017, 7:33
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61569/#review182878
---
Ship it!
Ship It!
- Gastón Kleiman
On Aug. 10, 2017, 7:32
ecutor/executor.proto#L96-L106
- Gastón Kleiman
On Aug. 14, 2017, 5:19 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
DoAll(
FutureArg<1>(),
v1::scheduler::SendAcknowledge(
frameworkId,
offer.agent_id(;
mesos.send(v1::createCallAccept(
frameworkId,
offer,
{reserve, create, launchGroup}));
```
- Gastón Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61572/#review182909
---
Ship it!
Ship It!
- Gastón Kleiman
On Aug. 14, 2017, 5:20
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61570/#review182879
---
Ship it!
Ship It!
- Gastón Kleiman
On Aug. 14, 2017, 5:20
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61493/#review182880
---
Ship it!
Ship It!
- Gastón Kleiman
On Aug. 14, 2017, 2:06
/tests/strings_tests.cpp
a51144df652c5d456d8dab49ca8b2cbec69ea4b6
Diff: https://reviews.apache.org/r/61565/diff/1/
Testing
---
The stout tests still pass.
Thanks,
Gastón Kleiman
d71fa4b9619a5fb5b8b8cae3310c36aaefc878ae
Diff: https://reviews.apache.org/r/61564/diff/1/
Testing
---
The libprocess tests still pass.
Thanks,
Gastón Kleiman
/
Testing
---
`sudo bin/mesos-tests.sh`
Thanks,
Gastón Kleiman
git grep -E '(EXPECT|ASSERT)_(EQ|NE).*(0u,\s.*size())'
> >
> > I still get ~50 hits. Since you are at it, would you mind adjusting
> > also?
>
> Gastón Kleiman wrote:
> I had done a similar search, and as far as I can see, the other matches
> are
: mesos
Description
---
Fixed a typo in a test.
Diffs
-
src/tests/fetcher_cache_tests.cpp 6d212cd460322ad6e97f4cf6ef537323275b7da0
Diff: https://reviews.apache.org/r/61584/diff/1/
Testing
---
None - not a functional change.
Thanks,
Gastón Kleiman
f021c34ef11aac42026ba39c5a1b775794982035
Diff: https://reviews.apache.org/r/60525/diff/7/
Changes: https://reviews.apache.org/r/60525/diff/6-7/
Testing
---
`make check`
Thanks,
Gastón Kleiman
Gastón
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60525/#review182730
---
On Aug. 12, 2017, 1:07 a.m., Gastón Kleiman wrote:
/60721/diff/4-5/
Testing
---
Added a new expectation to an existing test and confirmed that tests still pass.
Thanks,
Gastón Kleiman
ine?
woops, I did it again.
- Gastón
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60721/#review182728
---
On Aug. 12
://reviews.apache.org/r/61601/diff/1/
Testing
---
Stout tests still pass.
Thanks,
Gastón Kleiman
tched)
<https://reviews.apache.org/r/61493/#comment258775>
Ditto.
src/tests/default_executor_tests.cpp
Lines 1547 (patched)
<https://reviews.apache.org/r/61493/#comment258776>
Remove this extra line.
- Gastón Kleima
/
Changes: https://reviews.apache.org/r/60721/diff/5-6/
Testing
---
Added a new expectation to an existing test and confirmed that tests still pass.
Thanks,
Gastón Kleiman
9d47a8a3a2f10fa493b4db35a73f33e6ee1ac727
src/master/allocator/mesos/hierarchical.cpp
f021c34ef11aac42026ba39c5a1b775794982035
Diff: https://reviews.apache.org/r/60525/diff/9/
Changes: https://reviews.apache.org/r/60525/diff/8-9/
Testing
---
`make check`
Thanks,
Gastón Kleiman
---
Not a functional change.
Thanks,
Gastón Kleiman
://reviews.apache.org/r/60524/diff/2/
Changes: https://reviews.apache.org/r/60524/diff/1-2/
Testing
---
Added new Stout tests and confirmed that the Mesos test suite still passes.
Thanks,
Gastón Kleiman
er if the number is negative) than any double.
I removed these TODOs and added extra expectations to the tests.
- Gastón
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60524/#r
in this case.
Diffs (updated)
-
src/master/allocator/mesos/hierarchical.cpp
eb01d8e6b1108866ebc049f9f4a46157823a3541
Diff: https://reviews.apache.org/r/60525/diff/2/
Changes: https://reviews.apache.org/r/60525/diff/1-2/
Testing
---
`make check`
Thanks,
Gastón Kleiman
b0cd77b833f6fbf752b4db820fd43b87e1d1e476
3rdparty/stout/tests/duration_tests.cpp
59b08f14849a8db31f11fbd0b2e1248c99afd9dd
Diff: https://reviews.apache.org/r/60721/diff/1/
Testing
---
Added a new expectation to an existing test and confirmed that tests still pass.
Thanks,
Gastón Kleiman
in this case.
Diffs (updated)
-
src/master/allocator/mesos/hierarchical.cpp
eb01d8e6b1108866ebc049f9f4a46157823a3541
Diff: https://reviews.apache.org/r/60525/diff/3/
Changes: https://reviews.apache.org/r/60525/diff/2-3/
Testing
---
`make check`
Thanks,
Gastón Kleiman
was only one empty line before, do we need two?
- Gastón Kleiman
On July 21, 2017, 9:30 a.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
: https://reviews.apache.org/r/60721/diff/2-3/
Testing
---
Added a new expectation to an existing test and confirmed that tests still pass.
Thanks,
Gastón Kleiman
/stout/tests/duration_tests.cpp
59b08f14849a8db31f11fbd0b2e1248c99afd9dd
Diff: https://reviews.apache.org/r/60524/diff/4/
Changes: https://reviews.apache.org/r/60524/diff/3-4/
Testing
---
Added new Stout tests and confirmed that the Mesos test suite still passes.
Thanks,
Gastón
/allocator/mesos/hierarchical.cpp
f021c34ef11aac42026ba39c5a1b775794982035
Diff: https://reviews.apache.org/r/60525/diff/5/
Changes: https://reviews.apache.org/r/60525/diff/4-5/
Testing
---
`make check`
Thanks,
Gastón Kleiman
/OS + Marathon on AWS clusters on which
it is not possible to resolve localhost. The tasks failed without this patch,
but they succeeded after having applied it.
Thanks,
Gastón Kleiman
eviews.apache.org/r/60984/#review180976
---
On July 19, 2017, 9:03 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To re
---
Not a functional change.
Thanks,
Gastón Kleiman
/r/60524/diff/3/
Changes: https://reviews.apache.org/r/60524/diff/2-3/
Testing
---
Added new Stout tests and confirmed that the Mesos test suite still passes.
Thanks,
Gastón Kleiman
duration
in this case.
Diffs (updated)
-
src/master/allocator/mesos/hierarchical.cpp
f021c34ef11aac42026ba39c5a1b775794982035
Diff: https://reviews.apache.org/r/60525/diff/4/
Changes: https://reviews.apache.org/r/60525/diff/3-4/
Testing
---
`make check`
Thanks,
Gastón
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60525/#review180013
-------
On July 12, 2017, 9:41 p.m., Gastón Kleiman wrote:
>
> ---
> This is
eb01d8e6b1108866ebc049f9f4a46157823a3541
Diff: https://reviews.apache.org/r/60525/diff/1/
Testing
---
`make check`
Thanks,
Gastón Kleiman
that the Mesos test suite still passes.
Thanks,
Gastón Kleiman
eave this up to the shepherd, but the method is trivial enough that
we might want to just expand it in `cloneWithSetns`.
- Gastón Kleiman
On June 28, 2017, 10:49 p.m., James Peach wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60647/#review179649
---
Ship it!
Ship It!
- Gastón Kleiman
On July 5, 2017, 9:15
/linux_capabilities_isolator_tests.cpp
80508760f8d635b414651e521848315399918fbc
Diff: https://reviews.apache.org/r/61394/diff/3/
Changes: https://reviews.apache.org/r/61394/diff/2-3/
Testing
---
`sudo GLOG_v=1 bin/mesos-tests.sh
--gtest_filter="*LinuxCapabilitiesIsolatorTest*"`
Thank
re` passed on a machine running
GNU/Linux.
Thanks,
Gastón Kleiman
., Benjamin Bannier wrote:
> > src/tests/containerizer/posix_rlimits_isolator_tests.cpp
> > Lines 490 (patched)
> > <https://reviews.apache.org/r/61387/diff/2/?file=1789190#file1789190line490>
> >
> > `s/updates[1]/taskStatus/`.
Good catch =
tainer, it will shar the PID namespace
with its parent container. This field will be ignored if the `namespaces/pid`
isolator is not enabled.
```
- Gastón Kleiman
On Aug. 3, 2017, 9:40 p.m., Gilbert Song wrote:
>
> ---
> This is a
rTest*"`
Thanks,
Gastón Kleiman
ines 453-458 (patched)
<https://reviews.apache.org/r/61406/#comment258146>
Ditto.
- Gastón Kleiman
On Aug. 4, 2017, 4 p.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
est_repeat=3000 --gtest_break_on_failure --verbose` passed on a machine
with an Nvidia GPU.
Thanks,
Gastón Kleiman
Diff: https://reviews.apache.org/r/61282/diff/3/
Changes: https://reviews.apache.org/r/61282/diff/2-3/
Testing
---
`GLOG_v=1 sudo bin/mesos-tests.sh --gtest_filter="*NvidiaGpuTest.*Default*"
--verbose` passed on a machine with an Nvidia GPU.
Thanks,
Gastón Kleiman
/nvidia_gpu_isolator_tests.cpp
9a78ae65c1cd414b5093b54ff51724e31e31c9d3
Diff: https://reviews.apache.org/r/61438/diff/1/
Testing
---
`GLOG_v=1 sudo bin/mesos-tests.sh --gtest_filter="*NvidiaGpuTest.*Verify*"
--verbose` passed on a machine with 4 Nvidia GPUs.
Thanks,
Gastón Kleiman
7c900b17e5c895ea3a842f0f5b05b3a2876e61dd
Diff: https://reviews.apache.org/r/61511/diff/1/
Testing
---
`sudo bin/mesos-tests.sh`
Thanks,
Gastón Kleiman
t the executors send an empty check status in this case? See
`CommandExecutorCheckTest.CommandCheckTimeout`.
docs/health-checks.md
Line 273 (original), 501 (patched)
<https://reviews.apache.org/r/61434/#comment258367>
s/docker/Docker/
- Gast
710723c2a6ff7b72fce5d1d9ac69bf351e37a2ff
src/tests/upgrade_tests.cpp 7c900b17e5c895ea3a842f0f5b05b3a2876e61dd
Diff: https://reviews.apache.org/r/61511/diff/2/
Changes: https://reviews.apache.org/r/61511/diff/1-2/
Testing
---
`sudo bin/mesos-tests.sh`
Thanks,
Gastón Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61258/#review181853
---
Ship it!
Ship It!
- Gastón Kleiman
On July 31, 2017, 2:36
ue and add two more patches for stout and libprocess to the
chain.
- Gastón
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61511/#review182488
--------
/isolator_tests.cpp
Line 176 (original), 176 (patched)
<https://reviews.apache.org/r/61463/#comment258215>
`/proc/self/ns/ipc` is also a symlink, should we change this line too?
- Gastón Kleiman
On Aug. 7, 2017, 3:12 p.m., Qian Zhang
="HealthCheckTest.DefaultExecutorWithDockerImageCommandHealthCheck"`
Thanks,
Gastón Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61455/#review182282
---
Ship it!
Ship It!
- Gastón Kleiman
On Aug. 7, 2017, 10:47
: https://reviews.apache.org/r/61697/diff/1/
Testing
---
Manual tests.
Thanks,
Gastón Kleiman
/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e
Diff: https://reviews.apache.org/r/61697/diff/2/
Changes: https://reviews.apache.org/r/61697/diff/1-2/
Testing
---
Manual tests.
Thanks,
Gastón Kleiman
eviews.apache.org/r/61697/#review183121
---
On Aug. 18, 2017, 11:20 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To re
(updated)
-
src/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e
Diff: https://reviews.apache.org/r/61697/diff/3/
Changes: https://reviews.apache.org/r/61697/diff/2-3/
Testing
---
Manual tests.
Thanks,
Gastón Kleiman
eviews.apache.org/r/61697/#review183071
---
On Aug. 18, 2017, 11:20 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To re
. Let's make the output consistent.
Ditto https://reviews.apache.org/r/61766/.
- Gastón
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61697/#review183121
-----------
On Aug. 18, 2017, 11:20 p.m., Gastón Kleiman wrote:
&
erated e-mail. To reply, visit:
https://reviews.apache.org/r/61697/#review183121
-------
On Aug. 18, 2017, 11:20 p.m., Gastón Kleiman wrote:
>
> ---
> This is
/61766/diff/1/
Testing
---
`make tests` on GNU/Linux
Thanks,
Gastón Kleiman
/nested_mesos_containerizer_tests.cpp
Line 579 (original), 595-598 (patched)
<https://reviews.apache.org/r/58263/#comment247473>
Why do you prefer not to use the helper method?
- Gastón Kleiman
On May 9, 2017, 2:32 p.m., Alexander Rukletsov
: https://reviews.apache.org/r/59107/diff/1/
Testing
---
Publishing this RR only to make the patch go through the Apache CI.
Thanks,
Gastón Kleiman
Rukletsov and Gastón Kleiman.
Changes
---
Rebased, trying to trigger a CI build.
Repository: mesos
Description
---
Added extra debugging statements.
Diffs (updated)
-
src/slave/containerizer/mesos/containerizer.cpp
97837c83cc223950750e4cd088f4da067023c96c
src/slave
------
On June 9, 2017, 3:36 a.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59873/
> --
/diff/2-3/
Testing
---
Tests still pass on GNU/Linux.
Thanks,
Gastón Kleiman
401 - 500 of 781 matches
Mail list logo
