c84aa6724170bba46bbe8410b71d42a1626e
src/tests/containerizer/port_mapping_tests.cpp
16e015a8ac53a4aa5336b60c40228720b5f6910a
Diff: https://reviews.apache.org/r/59294/diff/6/
Changes: https://reviews.apache.org/r/59294/diff/5-6/
Testing
---
# added a new test
$ make check
Thanks,
Ian Downes
b.cpp 464120214b75e2e422c8ea6a57c5654ba77d669f
src/linux/routing/queueing/internal.hpp
9fe522ee017c86af8c7b2e518cd0957af08750e4
Diff: https://reviews.apache.org/r/60203/diff/3/
Changes: https://reviews.apache.org/r/60203/diff/2-3/
Testing
---
make check
Thanks,
Ian Downes
750e4
Diff: https://reviews.apache.org/r/60203/diff/2/
Changes: https://reviews.apache.org/r/60203/diff/1-2/
Testing
---
make check
Thanks,
Ian Downes
16e015a8ac53a4aa5336b60c40228720b5f6910a
Diff: https://reviews.apache.org/r/59294/diff/5/
Changes: https://reviews.apache.org/r/59294/diff/4-5/
Testing
---
# added a new test
$ make check
Thanks,
Ian Downes
- Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60203/#review178789
---
On June 19, 2017, 12:36 p.m., Ian Downes wrote
ic error handling and removed the erroneous comment.
- Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60203/#review178789
-------
On June 19, 2017, 12:36 p.m., Ian Downes wrote:
>
>
's simpler to
scale rate by cpu and burst naturally becomes progressively less useful for
higher cpu.
- Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59294/#revi
c84aa6724170bba46bbe8410b71d42a1626e
src/tests/containerizer/port_mapping_tests.cpp
16e015a8ac53a4aa5336b60c40228720b5f6910a
Diff: https://reviews.apache.org/r/59294/diff/4/
Changes: https://reviews.apache.org/r/59294/diff/3-4/
Testing
---
# added a new test
$ make check
Thanks,
Ian Downes
---
# added a new test
$ make check
Thanks,
Ian Downes
gt; > Then, the custom logic can be injected into a label decrorator, rather
> > than first class it here?
>
> Ian Downes wrote:
> It's not really a heuristic, it's a simple linear model with min/max. The
> major benefit is that it enables more effective alloca
b.hpp 857646190d21387f98832f5094128505a52a0776
src/linux/routing/queueing/htb.cpp 464120214b75e2e422c8ea6a57c5654ba77d669f
src/linux/routing/queueing/internal.hpp
9fe522ee017c86af8c7b2e518cd0957af08750e4
Diff: https://reviews.apache.org/r/60203/diff/1/
Testing
---
make check
Thanks,
Ian Downes
0c8276e425a6a7d22ee68edc6cc25b331635ec44
src/tests/containerizer/port_mapping_tests.cpp
d062f2f6bcf7b44dbcde951cdca23b0a2cd42115
Diff: https://reviews.apache.org/r/59294/diff/2/
Testing
---
# added a new test
$ make check
Thanks,
Ian Downes
/tests/containerizer/port_mapping_tests.cpp
d062f2f6bcf7b44dbcde951cdca23b0a2cd42115
Diff: https://reviews.apache.org/r/59294/diff/2/
Changes: https://reviews.apache.org/r/59294/diff/1-2/
Testing
---
# added a new test
$ make check
Thanks,
Ian Downes
/tests/containerizer/port_mapping_tests.cpp
d062f2f6bcf7b44dbcde951cdca23b0a2cd42115
Diff: https://reviews.apache.org/r/59294/diff/2/
Changes: https://reviews.apache.org/r/59294/diff/1-2/
Testing
---
# added a new test
$ make check
Thanks,
Ian Downes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59294/#review175114
---
On May 15, 2017, 1:56 p.m., Ian Downes wrote:
>
> ---
bc63a6a4cb6115b4b4d592e67e34045f52b50d4c
src/tests/containerizer/port_mapping_tests.cpp
a528382e8b4831b9c7e8dcc877a5e242909f0cd5
Diff: https://reviews.apache.org/r/59294/diff/1/
Testing
---
# added a new test
$ make check
Thanks,
Ian Downes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53931/#review157872
---
Ship it!
Ship It!
- Ian Downes
On Nov. 19, 2016, 11:13 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53927/#review157871
---
Ship it!
Ship It!
- Ian Downes
On Nov. 18, 2016, 10:45 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53926/#review157869
---
Ship it!
Ship It!
- Ian Downes
On Nov. 19, 2016, 4:42 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53925/#review157868
---
Ship it!
Ship It!
- Ian Downes
On Nov. 18, 2016, 10:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53913/#review157866
---
Ship it!
Ship It!
- Ian Downes
On Nov. 18, 2016, 4:11 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53912/#review157865
---
Ship it!
Ship It!
- Ian Downes
On Nov. 18, 2016, 4:10 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53882/#review157864
---
Ship it!
Ship It!
- Ian Downes
On Nov. 18, 2016, 4:11 p.m
Description
---
Add support for task labels to example no_executor_framework.
Diffs
-
src/examples/no_executor_framework.cpp
e82ae9a9ea23c7d181b071f0e3f5071b3856d8a4
Diff: https://reviews.apache.org/r/53009/diff/
Testing
---
Thanks,
Ian Downes
as actually been stopped or just that
systemd accepted the stop command?
src/tests/linux/systemd_tests.cpp (line 126)
<https://reviews.apache.org/r/50540/#comment211392>
What happens if there's an assertion during the test!? Because this is
outside the test sandbox it'
ary
to be in the same mount ns is only for the command executor?
- Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49273/#review139601
--
> On July 4, 2016, 10:06 a.m., Jie Yu wrote:
> > Please see the test section of https://reviews.apache.org/r/49569/
> >
> > Let me know if that's ok or not. Thanks!
>
> Ian Downes wrote:
> Hey, thanks for looking at this. I looked at the review for
&g
ews.apache.org/r/49273/#review140687
---
On June 27, 2016, 10:09 a.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e-mail. To reply
---
Manual.
Thanks,
Ian Downes
/ which describes
why I think this is an unexpected fundamental change in how the metrics are
counted.
- Ian Downes
On March 7, 2016, 2:51 p.m., Cong Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
es, i.e., staging before starting.
src/master/metrics.cpp (line 193)
<https://reviews.apache.org/r/44474/#comment184416>
foreach?
- Ian Downes
On March 7, 2016, 2:51 p.m., Cong Wang wrote:
>
> ---
> This is an automati
> On Feb. 8, 2016, 2:52 p.m., Ian Downes wrote:
> > src/linux/perf.cpp, lines 423-426
> > <https://reviews.apache.org/r/43283/diff/1/?file=1237011#file1237011line423>
> >
> > Hmmm, I'm not satisfied with this. I thought the new output format was
>
*temporary* tmpfs mount?
- Ian Downes
On Feb. 23, 2016, 12:12 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
> On Dec. 15, 2015, 11:36 a.m., Ian Downes wrote:
> > src/slave/containerizer/docker.cpp, line 838
> > <https://reviews.apache.org/r/33174/diff/2/?file=927472#file927472line838>
> >
> > Docker supports specifying the CFS period and quota to run a contai
tps://reviews.apache.org/r/33174/#comment181038>
Why not call update() here, rather than _update()? It will determine the
correct pid, just launched in launchExecutorContainer().
- Ian Downes
On Dec. 15, 2015, 12:14 p.m., Steve Niemitz
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43730/#review119687
---
Ship it!
Ship It!
- Ian Downes
On Feb. 18, 2016, 11:15 a.m
an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38117/
> ---
>
> (Updated Feb. 10, 2016, 4:48 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> B
org/r/43283/#comment179540>
Hmmm, I'm not satisfied with this. I thought the new output format was
introduced at a specific kernel version (3.13.0 might not be correct). Could
you please confirm that the 3.10 on CentOS7.1 has the new unit field but other
3.10 kernels don't.
-
> On Feb. 8, 2016, 2:47 p.m., Ian Downes wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp, lines
> > 132-134
> > <https://reviews.apache.org/r/43284/diff/1/?file=1237013#file1237013line132>
> >
> > I think you should disca
of seconds.
Note: I'm not sure if the correct behavior is implemented...
- Ian Downes
On Feb. 7, 2016, 12:19 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42757/#review118301
---
Ship it!
Ship It!
- Ian Downes
On Feb. 5, 2016, 9:35 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42735/#review118297
---
Ship it!
Ship It!
- Ian Downes
On Feb. 5, 2016, 8:51 a.m
>
> (Updated Jan. 25, 2016, 12:07 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan and Ian Downes.
>
>
> Bugs: MESOS-4502
> https://issues.apache.org/jira/browse/MESOS-4502
>
>
> Repository: mesos
>
>
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41726/#review115510
---
Ship it!
Ship It!
- Ian Downes
On Jan. 7, 2016, 4:52 p.m
usage.
src/tests/containerizer/port_mapping_tests.cpp (line 1149)
<https://reviews.apache.org/r/41911/#comment176189>
ditto, drop the "1".
src/tests/containerizer/port_mapping_tests.cpp (line 1172)
<https://reviews.apache.org/r/41911/#comm
mp and test parsing is
sucessful, further tests should ensure known values are parsed correctly.
- Ian Downes
On Dec. 14, 2015, 4:05 p.m., Cong Wang wrote:
>
> ---
> This is an automatically generated e-mail. To r
before.
2) The cfs quota changes depending on the CPU resource value so it
definitely does need to be re-written at every update. Again, this is a
straight copy-and-paste from the MC cpu isolator.
This part of the code looks fine to me. @Tim, do you concur?
- Ian Downes
On April 14
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41245/#review109990
---
Ship it!
Ship It!
- Ian Downes
On Dec. 10, 2015, 9:20 p.m
/port_mapping.cpp (line 3572)
<https://reviews.apache.org/r/41158/#comment169231>
s/kernel/the kernel/
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp (line 3574)
<https://reviews.apache.org/r/41158/#comment169230>
s/could/to
- Ian Downes
On Dec. 9, 2015, 3:1
ss/src/tests/http_tests.cpp (line 897)
<https://reviews.apache.org/r/39635/#comment167819>
Full stop.
- Ian Downes
On Nov. 27, 2015, 8:26 p.m., David Forsythe wrote:
>
> ---
> This is an automatically generated e-mai
ionality in
libc?
src/tests/attributes_tests.cpp (line 38)
<https://reviews.apache.org/r/39634/#comment167813>
These are unrelated to the FreeBSD support so can you split them out? Else,
I'll do it when I commit this patch.
- Ian Downes
On Nov. 27, 2015, 8:2
.org/r/38074/#comment165808>
Users have different kernels, code should determine the version at run time
and act accordingly.
src/slave/containerizer/isolators/cgroups/perf_event.cpp (line 633)
<https://reviews.apache.org/r/38074/#comment165811>
Include
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37101/#review106954
---
Ship it!
Ship It!
- Ian Downes
On Aug. 24, 2015, 2:30 p.m
> On Oct. 26, 2015, 5:20 p.m., Ian Downes wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 401-405
> > <https://reviews.apache.org/r/39417/diff/1/?file=1100528#file1100528line401>
> >
> > Why not add a 0x prefix if it&#x
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39415/#review104185
---
Ship it!
Ship It!
- Ian Downes
On Oct. 17, 2015, 5:22 p.m
2431)
<https://reviews.apache.org/r/39490/#comment162473>
Why is this no longer a failure?
src/slave/containerizer/isolators/network/port_mapping.cpp (line 2450)
<https://reviews.apache.org/r/39490/#comment162474>
ditto?
- Ian Downes
On Oct. 20, 2015, 11:57 a.m., Con
tps://reviews.apache.org/r/39416/#comment162355>
Does it actually create a flow per container or is it really based on the 5
tuple, which will be different for different containers?
- Ian Downes
On Oct. 17, 2015, 5:24 p.m., Cong Wang
t;
> (Updated Oct. 17, 2015, 5:29 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> When --egress_unique_flow_per_container is enabled, we need to install a flow
> classifier (
?
src/slave/flags.cpp (lines 506 - 513)
<https://reviews.apache.org/r/39417/#comment162362>
Why is this description different from the docs?
- Ian Downes
On Oct. 17, 2015, 5:29 p.m., Cong Wang wrote:
>
> ---
> Thi
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39345/#review103232
-------
On Oct. 20, 2015, 12:45 a.m., David Forsythe wrote:
>
> ---
> This is an aut
e since we're using this for setting quota.
src/tests/attributes_tests.cpp (line 40)
<https://reviews.apache.org/r/39345/#comment161517>
Did this cause a problem running the tests or are you cleaning things up?
- Ian Downes
On Oct. 20, 2015, 12:45 a.m., David Forsythe wrote:
>
> -
/containerizer/isolators/network/port_mapping.cpp (line 1169)
<https://reviews.apache.org/r/38117/#comment160782>
Toggle line type here.
src/slave/containerizer/isolators/network/port_mapping.cpp (lines 1171 - 1174)
<https://reviews.apache.org/r/38117/#comment16
ind mounted, just that *if* it is
then it's a shared mount...
src/tests/containerizer/filesystem_isolator_tests.cpp (lines 949 - 953)
<https://reviews.apache.org/r/38858/#comment158319>
Ditto.
- Ian Downes
On Sept. 29, 2015, 12:48 p.m., Jie Yu wrote:
>
> -
s.cpp (line 241)
<https://reviews.apache.org/r/38855/#comment158311>
Like above, can you verify the master id is correct?
src/tests/containerizer/fs_tests.cpp (line 243)
<https://reviews.apache.org/r/38855/#comment158310>
s/Cleanup/Clean up/
- Ian Downes
On Sept.
---
Thanks,
Ian Downes
---
Thanks,
Ian Downes
ators/filesystem/posix.cpp PRE-CREATION
src/slave/containerizer/mesos/containerizer.cpp
47d146125dfd4ea909e7ec9d94f41cfa11d035e5
Diff: https://reviews.apache.org/r/34135/diff/
Testing
---
existing persistent volumes tests.
Thanks,
Ian Downes
PRE-CREATION
src/slave/containerizer/mesos/containerizer.cpp
47d146125dfd4ea909e7ec9d94f41cfa11d035e5
Diff: https://reviews.apache.org/r/36429/diff/
Testing
---
Thanks,
Ian Downes
/diff/
Testing
---
Thanks,
Ian Downes
p PRE-CREATION
src/slave/containerizer/isolators/filesystem/posix.cpp PRE-CREATION
src/slave/containerizer/mesos/containerizer.cpp
47d146125dfd4ea909e7ec9d94f41cfa11d035e5
Diff: https://reviews.apache.org/r/34135/diff/
Testing
---
existing persistent volumes tests.
Thanks,
Ian Downes
://reviews.apache.org/r/34908/diff/
Testing
---
Thanks,
Ian Downes
-----------
On June 22, 2015, 9:42 a.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34136/
> ---
; ---
>
> Add ContainerImage protobuf.
>
>
> Diffs
> -
>
> include/mesos/mesos.proto 8df1211165169c9595e0e6e85b5ddc404345ff70
>
> Diff: https://reviews.apache.org/r/34136/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Ian Downes
>
>
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review90166
-------
On June 22, 2015, 9:42 a.m., Ian Downes wrote:
>
> ---
> Thi
eviews.apache.org/r/34137/#review89293
-------
On July 10, 2015, 5:05 p.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34137/
>
0741616b656e947cb460dd6ee6a9a4852be001c2
src/slave/state.hpp fed4b7ecf9572a8dbb1a99dbb1769d3e55ef7bc5
src/slave/state.cpp 8eda22a550e5add0f84c46cc2ed762b006c0dcec
src/tests/containerizer_tests.cpp 0cdb2d2a3f19a4835e85c6b040759019b03f051e
Diff: https://reviews.apache.org/r/34137/diff/
Testing
---
Thanks,
Ian
r.cpp
8c102fb7d1f79ee768cb06de3a976ea12f958712
Diff: https://reviews.apache.org/r/34135/diff/
Testing
---
existing persistent volumes tests.
Thanks,
Ian Downes
is is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34135/#review84775
-------
On June 22, 2015, 9:41 a.m., Ian Downes wrote:
>
> ---
rc/tests/perf_tests.cpp (line 226)
<https://reviews.apache.org/r/36380/#comment144712>
ditto
- Ian Downes
On July 10, 2015, 1:52 p.m., Paul Brett wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
c/linux/perf.cpp (line 532)
<https://reviews.apache.org/r/36378/#comment144651>
const T&
src/linux/perf.cpp (line 536)
<https://reviews.apache.org/r/36378/#comment144550>
newline
- Ian Downes
On July 9, 2015, 4:08 p.m., Paul Brett wrote:
>
> -
rkaround because ephemeral ports are not exposed to
the master.
s/packets/packet/
docs/network-isolation.md (line 77)
<https://reviews.apache.org/r/36281/#comment143938>
Can you state and explain why there's no shaping/limit on ingress?
St
/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2
Diff: https://reviews.apache.org/r/34142/diff/
Testing
---
Thanks,
Ian Downes
---
Thanks,
Ian Downes
src/slave/containerizer/provisioners/appc/discovery.cpp PRE-CREATION
src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b
src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2
Diff: https://reviews.apache.org/r/34139/diff/
Testing
---
Thanks,
Ian Downes
/diff/
Testing
---
Thanks,
Ian Downes
://reviews.apache.org/r/34138/diff/
Testing
---
Thanks,
Ian Downes
0741616b656e947cb460dd6ee6a9a4852be001c2
src/slave/state.hpp fed4b7ecf9572a8dbb1a99dbb1769d3e55ef7bc5
src/slave/state.cpp 8eda22a550e5add0f84c46cc2ed762b006c0dcec
src/tests/containerizer_tests.cpp 0cdb2d2a3f19a4835e85c6b040759019b03f051e
Diff: https://reviews.apache.org/r/34137/diff/
Testing
---
Thanks,
Ian
sting
---
Manual testing only so far. This is harder to automate because we need a
self-contained chroot to execute something in... Suggestions welcome.
Thanks,
Ian Downes
ce we chdir() after
chroot() which will change to "/". I clarified the comment.
- Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/#review89425
---
the correct fields and values.
src/tests/perf_tests.cpp (line 87)
<https://reviews.apache.org/r/36115/#comment143172>
```cpp
foreach (const tuple& input, input1) {}
```?
- Ian Downes
On July 1, 2015, 3:44
simplest to start from the
lowest in the ordering:
```cpp
if (a < x) {
//
} else if (a < y) {
//
} else if (a < z) {
//
} else {
//
}
```
src/linux/perf.cpp (line 549)
<https://reviews.apache.org/r/36114/#comment143163>
Where is
, i.e., the user
just calls extract(line) and gets the right output.
- Ian Downes
On July 1, 2015, 3:44 p.m., Chi Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
g/r/36112/#comment143162>
See subsequent review, I don't think this needs to be pulled out into a
separate function.
- Ian Downes
On July 1, 2015, 3:43 p.m., Chi Zhang wrote:
>
> ---
> This is an automatically genera
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36014/#review89775
---
Ship it!
Ship It!
- Ian Downes
On June 29, 2015, 11:58 a.m
nstexpr functions, i.e.,
inline is only for constexpr functions?
- Ian Downes
On June 24, 2015, 2:14 p.m., Paul Brett wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
> On June 23, 2015, 11:01 a.m., Ian Downes wrote:
> > Ship It!
For the test error, are we not cleaning out /var/run/mesos/netns (correctly)
between tests so we're trying to symlink container1 repeatedly? We should
probably be storing these symlinks in a directory the test con
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35585/#review89011
---
Ship it!
Ship It!
- Ian Downes
On June 22, 2015, 10:03 p.m
/provisioners/appc.cpp PRE-CREATION
src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b
src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2
Diff: https://reviews.apache.org/r/34142/diff/
Testing
---
Thanks,
Ian Downes
://reviews.apache.org/r/34908/diff/
Testing
---
Thanks,
Ian Downes
/34139/diff/
Testing
---
Thanks,
Ian Downes
1 - 100 of 200 matches
Mail list logo
