> On July 9, 2019, 5:44 a.m., Jie Yu wrote:
> > Can you add some unit test for this? For instance, toggle the new agent
> > flag, test with some docker registry (ideally, an unsecure registry, but I
> > think it's ok to test with a secure one too just to excersize the code
oolean
- Jie Yu
On July 9, 2019, 3:24 a.m., fei long wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71024/
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71005/#review216440
---
Ship it!
Ship It!
- Jie Yu
On July 3, 2019, 11:12 a.m., fei
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70712/
> -----------
>
> (Updated May 24, 2019, 6:46 a.m.)
>
>
> Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, Jacob Janco, and
> Jiang Yan Xu.
>
/slave/containerizer.proto
Lines 272 (patched)
<https://reviews.apache.org/r/70712/#comment302248>
typo `conttainer`
- Jie Yu
On May 24, 2019, 6:46 a.m., James Peach wrote:
>
> ---
> This is an automatically generated e
d80
src/slave/containerizer/mesos/paths.cpp
94ab921a79ff62bd43b5c72a368ec8b3e37ef110
Diff: https://reviews.apache.org/r/70356/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
Diff: https://reviews.apache.org/r/70355/diff/1/
Testing
---
sudo make check
This test will fail on some PidNamespace tests, which will be fixed in a
subsequent patch.
Thanks,
Jie Yu
description of the
issue?
- Jie Yu
On March 18, 2019, 10:20 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70017/#review213172
---
Ship it!
Ship It!
- Jie Yu
On Feb. 20, 2019, 6:27 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70018/#review213173
---
Ship it!
Ship It!
- Jie Yu
On Feb. 20, 2019, 6:27 a.m
/gpu/volume.cpp
Lines 493 (patched)
<https://reviews.apache.org/r/70016/#comment299042>
Can you also add a TODO here about relying on `NVIDIA_DRIVER_CAPABILITIES`
env var instead in the future?
- Jie Yu
On Feb. 21, 2019, 11:03 p.m., Chun-Hung Hsiao
: https://reviews.apache.org/r/70037/diff/1/
Testing
---
tested locally by running support/packaging/centos/build-docker-rpmbuild.sh
Thanks,
Jie Yu
> On Feb. 20, 2019, 6:34 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/gpu/isolator.cpp
> > Lines 418 (patched)
> > <https://reviews.apache.org/r/70016/diff/1/?file=2125909#file2125909line418>
> >
> > Ideally, for PATH and LD_LIBR
---
n/a
Thanks,
Jie Yu
/jenkins/mini.sh a012c6c35c4ae113eec541d93a8bc8005c566a75
Diff: https://reviews.apache.org/r/70024/diff/1/
Testing
---
run the script locally.
Thanks,
Jie Yu
oughts on this.
- Jie Yu
On Feb. 20, 2019, 6:26 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/subprocess.hpp
Lines 137-138 (patched)
<https://reviews.apache.org/r/69946/#comment298595>
I'd add a TODO here to cleanup the use of os::strerror here as it's not
async signal safe. We have the same issue above. So you can follow up with a
patch adding TODO.
- Jie Yu
On Feb. 11, 2019, 7:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69947/#review212707
---
Ship it!
Ship It!
- Jie Yu
On Feb. 11, 2019, 7:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69948/#review212708
---
Ship it!
Ship It!
- Jie Yu
On Feb. 11, 2019, 7:21 p.m
Diff: https://reviews.apache.org/r/69945/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
3f7daf2cca63c1b9c9e78264f241892327741aa0
src/linux/memfd.hpp PRE-CREATION
src/linux/memfd.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/69943/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
-CREATION
Diff: https://reviews.apache.org/r/69944/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69810/#review212246
---
THis looks fine, but what's the motivation?
- Jie Yu
On Jan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69809/#review212211
---
Ship it!
Ship It!
- Jie Yu
On Jan. 23, 2019, 1:15 a.m
> On Jan. 16, 2019, 10:10 p.m., Jie Yu wrote:
> > src/tests/mesos.cpp
> > Line 173 (original), 173 (patched)
> > <https://reviews.apache.org/r/69776/diff/1/?file=2120114#file2120114line173>
> >
> > s/agentDir/configDir/
>
> Gilbert Song wro
), 173 (patched)
<https://reviews.apache.org/r/69776/#comment297689>
s/agentDir/configDir/
- Jie Yu
On Jan. 16, 2019, 10:08 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
ber directly against the
namespace handle, instead of `/proc`.
Diffs
-
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
a1130a58553fb67bd8c212498b98978f116d7b0c
Diff: https://reviews.apache.org/r/69727/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69728/#review211917
---
Ship it!
Ship It!
- Jie Yu
On Jan. 11, 2019, 11:17 p.m
to true.
Diffs (updated)
-
src/tests/containerizer/cni_isolator_tests.cpp
eb20e637ecbe1b39e2dbb274c5198828f2fdf62f
Diff: https://reviews.apache.org/r/69712/diff/3/
Changes: https://reviews.apache.org/r/69712/diff/2-3/
Testing
---
sudo make check
Thanks,
Jie Yu
to true.
Diffs (updated)
-
src/tests/containerizer/cni_isolator_tests.cpp
eb20e637ecbe1b39e2dbb274c5198828f2fdf62f
Diff: https://reviews.apache.org/r/69712/diff/2/
Changes: https://reviews.apache.org/r/69712/diff/1-2/
Testing
---
sudo make check
Thanks,
Jie Yu
/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
4e784ffb4ac29861c888fdbed4fcf9902bf4182a
Diff: https://reviews.apache.org/r/69715/diff/2/
Changes: https://reviews.apache.org/r/69715/diff/1-2/
Testing
---
sudo make check
Thanks,
Jie Yu
eb20e637ecbe1b39e2dbb274c5198828f2fdf62f
Diff: https://reviews.apache.org/r/69710/diff/2/
Changes: https://reviews.apache.org/r/69710/diff/1-2/
Testing
---
sudo make check
Thanks,
Jie Yu
---
sudo make check
Thanks,
Jie Yu
ps://reviews.apache.org/r/69715/#review211875
-----------
On Jan. 11, 2019, 6:14 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail.
ated e-mail. To reply, visit:
https://reviews.apache.org/r/69712/#review211871
-------
On Jan. 11, 2019, 5:13 a.m., Jie Yu wrote:
>
> ---
> This is a
izerTest::SetUp()` instead?
Good catch!
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69710/#review211869
-------
On
/port_mapper.cpp
4e784ffb4ac29861c888fdbed4fcf9902bf4182a
Diff: https://reviews.apache.org/r/69715/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
---
sudo make check
Thanks,
Jie Yu
---
We forgot to call MesosTest::SetUp() and MesosTest::TearDown() in the
override methods.
Diffs
-
src/tests/health_check_tests.cpp 3e9b2da5aa1602a5dd24007d9b14cab74e7d02ae
Diff: https://reviews.apache.org/r/69713/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
eb20e637ecbe1b39e2dbb274c5198828f2fdf62f
Diff: https://reviews.apache.org/r/69710/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
affecting other files for the test. This patch makes the runtime
directory a separate directory.
Diffs
-
src/tests/mesos.cpp 3a1101cf41995733fe7b6492781def6ac09c6130
Diff: https://reviews.apache.org/r/69711/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
Thanks,
Jie Yu
-
src/tests/mesos.cpp 3a1101cf41995733fe7b6492781def6ac09c6130
Diff: https://reviews.apache.org/r/69711/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
/containerizer/cni_isolator_tests.cpp
eb20e637ecbe1b39e2dbb274c5198828f2fdf62f
Diff: https://reviews.apache.org/r/69712/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
ache.org/r/69706/diff/2/
Changes: https://reviews.apache.org/r/69706/diff/1-2/
Testing
---
sudo make check
Thanks,
Jie Yu
ni/cni.cpp
cc23428d27d40be8c4ff1476e6e984c7d12760c4
Diff: https://reviews.apache.org/r/69706/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69690/#review211738
---
Ship it!
Ship It!
- Jie Yu
On Jan. 7, 2019, 8:19 p.m., Chun
)
<https://reviews.apache.org/r/69671/#comment297209>
Can you add some comments about this one? Or just separate this change in a
different patch?
- Jie Yu
On Jan. 5, 2019, 1:24 a.m., Chun-Hung Hsiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69665/#review211663
---
Ship it!
Ship It!
- Jie Yu
On Jan. 4, 2019, 12:57 a.m
/reviews.apache.org/r/69590/#comment296514>
instead of use `paths::ROOT_DIR`, you should use `flags.runtime_dir`
- Jie Yu
On Dec. 19, 2018, 4:52 a.m., Deepak Goel wrote:
>
> ---
> This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69540/#review211151
---
Ship it!
Ship It!
- Jie Yu
On Dec. 10, 2018, 4:41 p.m
t;: 128,
"requirePorts": false,
"networks": [
{
"mode": "container/bridge"
}
],
"healthChecks": [],
"fetch": [],
"constraints": [],
"cmd": "sleep 10"
}
```
Thanks,
Jie Yu
```
```json
{
"id": "/test",
"cmd": "dd if=/dev/zero of=file bs=1024 count=1 oflag=dsync",
"cpus": 1,
"mem": 128,
"disk": 128,
"instances": 1,
"container": {
"type": "MESOS",
"docker": {
"image": "ubuntu:18.04"
}
}
}
```
Thanks,
Jie Yu
3rdparty/stout/include/stout/os/windows/shell.hpp
b9e06d667159d2fb5e266ce7f7e633deb1237a78
Diff: https://reviews.apache.org/r/69537/diff/1/
Testing
---
make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69532/#review211130
---
On Dec. 8, 2018, 4:45 a.m., Jie Yu wrote:
>
>
of=file bs=1024 count=1 oflag=dsync",
"cpus": 1,
"mem": 128,
"disk": 128,
"instances": 1,
"container": {
"type": "MESOS",
"docker": {
"image": "ubuntu:18.04"
}
}
}
```
Thanks,
Jie Yu
/69532/diff/1-2/
Testing
---
sudo make check
Thanks,
Jie Yu
/isolators/volume/host_path.cpp
2e4cd2b9b852b0c95a2957f4bed33fe54f093e3d
src/slave/containerizer/mesos/launch.cpp
6aa4397aa0fc9e1c93a0f3a13fbe0a55c5a02f0c
Diff: https://reviews.apache.org/r/69532/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69528/#review211120
---
Ship it!
Ship It!
- Jie Yu
On Dec. 7, 2018, 7:41 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69210/#review211022
---
Ship it!
Ship It!
- Jie Yu
On Nov. 17, 2018, 12:49 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69211/#review211015
---
Ship it!
Ship It!
- Jie Yu
On Dec. 4, 2018, 1:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69450/#review211014
---
Ship it!
Ship It!
- Jie Yu
On Nov. 27, 2018, 12:49 a.m
Line 189 (original), 189 (patched)
<https://reviews.apache.org/r/69210/#comment295866>
This is a bit weird to me. I'd prefer just add a new optional field in
ContainerMountInfo
- Jie Yu
On Nov. 17, 2018, 12:49 a.m., James Peach
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69086/#review211012
---
Ship it!
Ship It!
- Jie Yu
On Nov. 27, 2018, 12:49 a.m
://reviews.apache.org/r/69377/diff/4/
Changes: https://reviews.apache.org/r/69377/diff/3-4/
Testing
---
Markdown rendering can be viewed here:
https://github.com/jieyu/mesos/blob/mesos_mini_blog/site/source/blog/2018-11-19-mesos-mini.md
Thanks,
Jie Yu
https://reviews.apache.org/r/69377/#review210643
---
On Nov. 19, 2018, 5:47 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
/
Changes: https://reviews.apache.org/r/69377/diff/2-3/
Testing
---
Markdown rendering can be viewed here:
https://github.com/jieyu/mesos/blob/mesos_mini_blog/site/source/blog/2018-11-19-mesos-mini.md
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/#review210638
---
Ship it!
Ship It!
- Jie Yu
On Nov. 7, 2018, 10:10 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68832/#review210639
---
Ship it!
Ship It!
- Jie Yu
On Nov. 7, 2018, 10:29 p.m
://reviews.apache.org/r/69377/diff/1-2/
Testing
---
Markdown rendering can be viewed here:
https://github.com/jieyu/mesos/blob/mesos_mini_blog/site/source/blog/2018-11-19-mesos-mini.md
Thanks,
Jie Yu
/mesos/blob/mesos_mini_blog/site/source/blog/2018-11-19-mesos-mini.md
Thanks,
Jie Yu
CSI integration)
src/slave/containerizer/mesos/launch.cpp
Line 466 (original), 471 (patched)
<https://reviews.apache.org/r/69086/#comment294978>
Do we still need this function? Looks like this is just a verification now.
Can you simply move the logic to the main `execute()` method?
decision?
- Jie Yu
On Oct. 30, 2018, 4:46 p.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
re.
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
Lines 436 (patched)
<https://reviews.apache.org/r/69086/#comment294764>
Ditto.
src/slave/containerizer/mesos/launch.cpp
Lines 510 (patched)
<https://reviews.apache.org/r/69086/#comment294765>
Is this intent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69103/#review209946
---
Ship it!
Ship It!
- Jie Yu
On Oct. 20, 2018, 9:52 a.m
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/69009/#review209538
---
On Oct. 12, 2018, 11:53 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68987/#review209433
---
Ship it!
Ship It!
- Jie Yu
On Oct. 11, 2018, 5:18 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68923/#review209247
---
Ship it!
Ship It!
- Jie Yu
On Oct. 4, 2018, 10:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68924/#review209233
---
Ship it!
Ship It!
- Jie Yu
On Oct. 4, 2018, 5:26 a.m., Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68923/#review209231
---
Ship it!
Ship It!
- Jie Yu
On Oct. 4, 2018, 5:22 a.m., Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68810/#review209133
---
Ship it!
Ship It!
- Jie Yu
On Sept. 29, 2018, 12:05 p.m
mount table is big (e.g., MESOS-8418).
This patch uses the static local variable to cache the result.
Diffs
-
src/slave/containerizer/docker.cpp 277a1550e199097ebc3c47d0a6c0d258bac90da5
Diff: https://reviews.apache.org/r/68880/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
-
src/slave/containerizer/docker.cpp 277a1550e199097ebc3c47d0a6c0d258bac90da5
Diff: https://reviews.apache.org/r/68880/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
ed470465726227a61216b467ad1a7f030806008f
Diff: https://reviews.apache.org/r/68862/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
the network configs.
This patch fixed a potential CHECK failure.
Diffs
-
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
ed470465726227a61216b467ad1a7f030806008f
Diff: https://reviews.apache.org/r/68861/diff/1/
Testing
---
sudo make check
Thanks,
Jie Yu
and executor. I.e.,
```
if (containerConfig.has_task_info()) {
launchInfo.mutable_command()->add_arguments(
"--tty_slave_path=" + slavePath.get());
}
```
- Jie Yu
On Sept. 22, 2018, 12:3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68724/#review209030
---
Ship it!
Ship It!
- Jie Yu
On Sept. 22, 2018, 12:35 a.m
here.
src/resource_provider/daemon.cpp
Lines 686-688 (patched)
<https://reviews.apache.org/r/68763/#comment293184>
Can we LOG all errors in the `futures` list, not just the first one? You
need to combine the error messages.
- Jie Yu
On Sept. 21, 2018, 7:47 p.m., Chu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68769/#review208771
---
Ship it!
Ship It!
- Jie Yu
On Sept. 19, 2018, 6:27 p.m
/68728/diff/1/
Testing
---
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68614/#review208288
---
Ship it!
Ship It!
- Jie Yu
On Sept. 3, 2018, 10:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68615/#review208283
---
Ship it!
Ship It!
- Jie Yu
On Sept. 3, 2018, 10:25 p.m
> On Sept. 2, 2018, 3:37 a.m., Jie Yu wrote:
> > src/authorizer/local/authorizer.cpp
> > Lines 1138 (patched)
> > <https://reviews.apache.org/r/68601/diff/1/?file=2079385#file2079385line1138>
> >
> > you might also need VIEW_CONTAINERS because `GetCon
d allow
us to see the log history.
- Jie Yu
On Sept. 1, 2018, 5:31 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68600/#review208233
---
Ship it!
Ship It!
- Jie Yu
On Sept. 1, 2018, 5:31 p.m
/provisioner_docker_tests.cpp
Lines 1140-1142 (patched)
<https://reviews.apache.org/r/68599/#comment291961>
I'd swap the order of these two.
- Jie Yu
On Sept. 1, 2018, 6:15 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically g
Description
---
Added a missing failure message in overlay backend.
Diffs
-
src/slave/containerizer/mesos/provisioner/backends/overlay.cpp
e32b9918ac15122477e05ebe701c9425bbefa809
Diff: https://reviews.apache.org/r/68598/diff/1/
Testing
---
Thanks,
Jie Yu
/68597/diff/1-2/
Testing
---
sudo make check
Thanks,
Jie Yu
/slave/containerizer/mesos/provisioner/backends/overlay.cpp
e32b9918ac15122477e05ebe701c9425bbefa809
Diff: https://reviews.apache.org/r/68594/diff/2/
Changes: https://reviews.apache.org/r/68594/diff/1-2/
Testing
---
sudo make check
Thanks,
Jie Yu
Diff: https://reviews.apache.org/r/68596/diff/2/
Changes: https://reviews.apache.org/r/68596/diff/1-2/
Testing
---
sudo make check
Thanks,
Jie Yu
1 - 100 of 4105 matches
Mail list logo
