che.org/r/55856/diff/
Testing
---
Visual inspection.
Thanks,
Neil Conway
7b7b9a9c8f
Diff: https://reviews.apache.org/r/55862/diff/
Testing
---
Manual testing: launching tasks, partitioning an agent, examing the web UI, etc.
Thanks,
Neil Conway
/
- Neil Conway
On Jan. 21, 2017, 11:27 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/
Testing
---
`make check`
Thanks,
Neil Conway
iew162573
---
On Jan. 21, 2017, 11:27 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
leaving a lot of `.patch` files on the file system. With this
patch, no such error is observed and no orphan `.patch` files are left behind.
Thanks,
Neil Conway
59d98da
src/webui/master/static/js/controllers.js
b6364fa636a6dc4b8d314285bec7dc19eb1c9c3b
Diff: https://reviews.apache.org/r/55856/diff/
Testing
---
Visual inspection.
Thanks,
Neil Conway
to the registry
(MESOS-1719).
Diffs (updated)
-
src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba
src/tests/partition_tests.cpp e7f64182f39dfdf15d035b43c18bf58aecfc74d1
Diff: https://reviews.apache.org/r/54232/diff/
Testing
---
`make check`
Thanks,
Neil Conway
e "./support/apply-reviews.py", line 119, in
atexit.register(lambda: os.remove('%s.patch' % patch_id()))
OSError: [Errno 2] No such file or directory: '55856.patch'
...
```
And results in leaving a lot of `.patch` files on the file system. With this
patch, no such error is observed and no orph
ask.slave_id() != info.id()) {...}` ?
src/slave/slave.cpp (line 1679)
<https://reviews.apache.org/r/55876/#comment234201>
Also variable shadowing.
- Neil Conway
On Jan. 24, 2017, 2:54 p.m., Alexander Rukletsov wrote:
>
> ---
&g
also be changed: e.g., lines 1179, 1226, 1580, potentially 5292.
- Neil Conway
On Jan. 27, 2017, 11:52 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
0abb9ebe8e9a40c6b7201a1f0e8071b7b249a6ed
docs/scheduler-http-api.md 958cfc52496b1585564e019f9ce8b06a623f2d5c
Diff: https://reviews.apache.org/r/55964/diff/
Testing
---
Visual inspection on GH.
Thanks,
Neil Conway
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56005/#review163444
---
Ship it!
Ship It!
- Neil Conway
On Jan. 27, 2017, 12:31 a.m
0abb9ebe8e9a40c6b7201a1f0e8071b7b249a6ed
docs/scheduler-http-api.md 958cfc52496b1585564e019f9ce8b06a623f2d5c
Diff: https://reviews.apache.org/r/55964/diff/
Testing
---
Visual inspection on GH.
Thanks,
Neil Conway
d4ffd523a0c689bdb462e934c431a38a9d8c350b
docs/quota.md 0abb9ebe8e9a40c6b7201a1f0e8071b7b249a6ed
docs/scheduler-http-api.md 958cfc52496b1585564e019f9ce8b06a623f2d5c
Diff: https://reviews.apache.org/r/55964/diff/
Testing
---
Visual inspection on GH.
Thanks,
Neil Conway
,
Neil Conway
/
Testing
---
`make check`
Thanks,
Neil Conway
---
Fixed comments, usage text in mesos-execute.
Diffs
-
src/cli/execute.cpp 34c5d6e76c05edce987bf75fcd78797b7b9a9c8f
Diff: https://reviews.apache.org/r/55801/diff/
Testing
---
`make check`
Thanks,
Neil Conway
://reviews.apache.org/r/55800/diff/
Testing
---
`make check`
Thanks,
Neil Conway
---
`make check`
Thanks,
Neil Conway
/metrics.cpp 1f049f3794c1bca45d2684cbbec3b08c1a78c494
src/tests/partition_tests.cpp e7f64182f39dfdf15d035b43c18bf58aecfc74d1
Diff: https://reviews.apache.org/r/55804/diff/
Testing
---
`make check`
Thanks,
Neil Conway
---
Reordered function definitions to match declaration order.
Diffs
-
src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba
Diff: https://reviews.apache.org/r/55803/diff/
Testing
---
`make check`
Thanks,
Neil Conway
---
Fixed whitespace in mesos-execute.
Diffs
-
src/cli/execute.cpp 34c5d6e76c05edce987bf75fcd78797b7b9a9c8f
Diff: https://reviews.apache.org/r/55802/diff/
Testing
---
`make check`
Thanks,
Neil Conway
---
`make check`, visual inspection.
Thanks,
Neil Conway
://reviews.apache.org/r/55805/diff/
Testing (updated)
---
`make check`, visual inspection.
Thanks,
Neil Conway
---
Updated the list of terminal states in the webui.
Diffs
-
src/webui/master/static/js/controllers.js
388ca2447716cbc7141da6a20daf2340621a16e8
Diff: https://reviews.apache.org/r/55807/diff/
Testing
---
`make check`
Thanks,
Neil Conway
---
The listing completed tasks was not closed.
Diffs
-
src/webui/master/static/home.html cf251865e1670beee9532f7c6e1b4dc23e86dbfc
Diff: https://reviews.apache.org/r/55809/diff/
Testing
---
`make check`
Thanks,
Neil Conway
---
`make check`
Thanks,
Neil Conway
c2211be7458755aeb91ef078e4bfe92ac474044a
src/tests/master_quota_tests.cpp 54ae66f09a0b9d1e3be0c44bd4a8bbf5d27ba688
Diff: https://reviews.apache.org/r/55995/diff/
Testing
---
`make check`
Thanks,
Neil Conway
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55911/#review163007
---
On Jan. 25, 2017, 2:38 a.m., Neil Conway wrote:
>
> ---
>
914b3c5749f775cce806f37c26e67d1f0f5351c6
Diff: https://reviews.apache.org/r/55911/diff/
Testing
---
`make check`
Without this change, this test fails on most platforms in the internal CI. With
this change, no failures of this test are observed.
Thanks,
Neil Conway
leaving a lot of `.patch` files on the file system. With this
patch, no such error is observed and no orphan `.patch` files are left behind.
Thanks,
Neil Conway
---
`make check`
Without this change, this test fails on most platforms in the internal CI. With
this change, no failures of this test are observed.
Thanks,
Neil Conway
ce and then reuse it.
src/tests/slave_recovery_tests.cpp (line 2405)
<https://reviews.apache.org/r/56895/#comment238205>
Should probably be `EXPECT`, here and below.
src/tests/slave_recovery_tests.cpp (line 2420)
<https://reviews.apache.org/r/56895/#comment238204>
/
Testing
---
`make check`
Thanks,
Neil Conway
/
Testing
---
Without this change, the test consistently produces this warning on my system:
```
GMOCK WARNING:
Uninteresting mock function call - returning directly.
Function call: shutdown(0x7fe1f0e7d330)
```
With this change, the warning was not observed in 500 test runs.
Thanks,
Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56611/#review165983
---
Ship it!
Ship It!
- Neil Conway
On Feb. 14, 2017, 3:59 p.m
ec8df33a3f0d4ad790d5cc753e1691c5517c39c0
Diff: https://reviews.apache.org/r/56806/diff/
Testing
---
`make check`
Thanks,
Neil Conway
74dacf140e49e402a4ad02ce7751e7c7b2f78ee1
src/tests/slave_recovery_tests.cpp 0e295915fea0a7314e173857249bd8726eeccd76
Diff: https://reviews.apache.org/r/56805/diff/
Testing
---
`make check`
Thanks,
Neil Conway
ce577ce6c71bbfffba7db7c72523a9fd2d68141b
Diff: https://reviews.apache.org/r/56804/diff/
Testing
---
`make check`
Thanks,
Neil Conway
y be killed when the task fails -- i.e.,
transitions to the TASK_FAILED state. For the default executor, this happens
when the task exits with a non-zero exit code."
Note that OOM killer (i.e., SIGKILL) does _not_ result in the exit code
being "unknown" --
tps://reviews.apache.org/r/53993/#comment236839>
Seems unintentional?
- Neil Conway
On Feb. 9, 2017, 9:48 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
at most the first three components of the version, (b) return an
error if either of the first two components can't be parsed and default to zero
for third component.
src/linux/perf.cpp (line 235)
<https://reviews.apache.org/r/56611/#comment237231>
Whitespace before `+`, also after `:
system:
```
GMOCK WARNING:
Uninteresting mock function call - returning directly.
Function call: shutdown(0x7fe1f0e7d330)
```
With this change, the warning was not observed in 500 test runs.
Thanks,
Neil Conway
uot;
docs/quota.md (line 342)
<https://reviews.apache.org/r/53993/#comment236787>
"Rescind at least as many resources as are required to satisfy the quota
request"
- Neil Conway
On Feb. 9, 2017, 5:29 p.m., Zhitao Li wrote:
>
> ---
---
Updated version in comment about TASK_LOST behavior.
Diffs
-
include/mesos/mesos.proto 8f1d6957a97eff1e0a94817d38e7a7de6d69
include/mesos/v1/mesos.proto 74e7851b147ab821dceeab6e838d34b092f101c3
Diff: https://reviews.apache.org/r/55689/diff/
Testing
---
Thanks,
Neil
master.cpp b863ff6e93931c3d1ee056248084c7f44caf2fd9
src/tests/partition_tests.cpp 72013d1bfee275c6f3cb90173f0c408d55e0bc5d
Diff: https://reviews.apache.org/r/54183/diff/
Testing
---
`make check`
Thanks,
Neil Conway
src/master/quota_handler.cpp 6e6e7375219d34e6e8d011a025b5f5d70b87383b
Diff: https://reviews.apache.org/r/54408/diff/
Testing
---
`make check`
Thanks,
Neil Conway
master.cpp b863ff6e93931c3d1ee056248084c7f44caf2fd9
src/tests/partition_tests.cpp 72013d1bfee275c6f3cb90173f0c408d55e0bc5d
Diff: https://reviews.apache.org/r/54183/diff/
Testing
---
`make check`
Thanks,
Neil Conway
`
Thanks,
Neil Conway
/
Testing
---
`make check`
Thanks,
Neil Conway
master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba
src/tests/partition_tests.cpp 72013d1bfee275c6f3cb90173f0c408d55e0bc5d
Diff: https://reviews.apache.org/r/54183/diff/
Testing
---
`make check`
Thanks,
Neil Conway
5476/diff/
Testing
---
`make check`
Thanks,
Neil Conway
).
Diffs (updated)
-
src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba
src/tests/partition_tests.cpp 72013d1bfee275c6f3cb90173f0c408d55e0bc5d
Diff: https://reviews.apache.org/r/54232/diff/
Testing
---
`make check`
Thanks,
Neil Conway
> On Jan. 3, 2017, 10:25 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 5507
> > <https://reviews.apache.org/r/54183/diff/6/?file=1588710#file1588710line5507>
> >
> > can we inline this?
>
> Neil Conway wrote:
> We could, but
`
Thanks,
Neil Conway
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55472/#review162306
---
On Jan. 18, 2017, 5 p.m., Neil Conway wrote:
>
> ---
&g
73159328ce3fd838e02eba0e6a30cf69efc319ba
Diff: https://reviews.apache.org/r/55473/diff/
Testing
---
`make check`
Thanks,
Neil Conway
/diff/
Testing
---
`make check`
Thanks,
Neil Conway
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51109/#review145810
---
First line of the commit message should be <= 60 chars.
- N
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51099/#review146236
---
Ship it!
Ship It!
- Neil Conway
On Aug. 16, 2016, 4:34 p.m
693fdd119ed3b0bf734eaa55da9c58b0a
Diff: https://reviews.apache.org/r/57167/diff/
Testing
---
`make check`
Thanks,
Neil Conway
://reviews.apache.org/r/57166/diff/
Testing
---
`make check`
Thanks,
Neil Conway
b5b805868bed61bf482d71322fb1918a0d020d48
src/tests/sorter_tests.cpp c93d236b13256f4022a811d019990ef81521aa77
Diff: https://reviews.apache.org/r/57164/diff/
Testing
---
`make check`
Thanks,
Neil Conway
Description
---
Minor cleanup for quota validation code.
Diffs
-
src/master/quota.cpp 847ec068f4f3fe94ddabc11ff583d7e76117d375
Diff: https://reviews.apache.org/r/57165/diff/
Testing
---
`make check`
Thanks,
Neil Conway
sorter test cases.
Diffs
-
src/tests/sorter_tests.cpp c93d236b13256f4022a811d019990ef81521aa77
Diff: https://reviews.apache.org/r/57163/diff/
Testing
---
`make check`
Thanks,
Neil Conway
/56806/diff/
Testing
---
`make check`
Thanks,
Neil Conway
---
Cleaned up header includes.
Diffs
-
src/linux/capabilities.hpp 7c6342745a7db1ecf8664c64be77b10a54d5037a
src/linux/capabilities.cpp 9f46bd0a34d35d8295b1899a7ba67d85c3c24348
Diff: https://reviews.apache.org/r/57161/diff/
Testing
---
`make check`
Thanks,
Neil Conway
/tests/containerizer/rootfs.cpp 513c1b544f9e5239fa2a8e8ebedc3d84a6384ba3
Diff: https://reviews.apache.org/r/57157/diff/
Testing
---
`make check`
Thanks,
Neil Conway
---
Minor cleanup for slave tests.
Diffs
-
src/tests/slave_tests.cpp 3731c7607d5e49f3000c4863b1999851fac45705
Diff: https://reviews.apache.org/r/57162/diff/
Testing
---
`make check`
Thanks,
Neil Conway
5c0d01483efb4561b8c0016c3a2fa6ea5574196e
src/tests/resource_offers_tests.cpp 74dacf140e49e402a4ad02ce7751e7c7b2f78ee1
src/tests/slave_recovery_tests.cpp b5b805868bed61bf482d71322fb1918a0d020d48
Diff: https://reviews.apache.org/r/56805/diff/
Testing
---
`make check`
Thanks,
Neil Conway
.apache.org/r/57161/#review167183
---
On Feb. 28, 2017, 8:07 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
system, `PerfTest.Version` yields:
```
[ RUN ] PerfTest.Version
../../mesos/src/tests/containerizer/perf_tests.cpp:134: Failure
(perf::version()).failure(): Failed to execute perf: exited with status 2
[ FAILED ] PerfTest.Version (51 ms)
[--] 1 test from PerfTest (51 ms total)
```
- Neil Conway
r/50699/diff/
Testing
---
make check
Thanks,
Neil Conway
al changes are landed, though.
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50701/#review146394
---
On Aug.
(because it has been "removed" from the list of admitted
agents). Importantly, we need to check-for and remove tasks here: if an agent
was marked unreachable but then it reregisters, any non-partition-aware tasks
running on the agent will be shutdown and should be removed from
tps://reviews.apache.org/r/50705/#comment213176>
src/master/master.cpp (lines 5467 - 5468)
<https://reviews.apache.org/r/50705/#comment213178>
- Neil Conway
On Aug. 13, 2016, 11:56 p.m., Neil Conway wrote:
>
> ---
> Thi
about `removed` containing both "shutdown" and
"unreachable" agents.
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50705/#review146438
---
On Aug. 13, 2016, 11:56 p.m., Neil Conway wrote:
>
22ed8780023c4a3cd0f6
src/tests/partition_tests.cpp 0a72b345538ca3b9510fccf38ceb68ac71c2b473
Diff: https://reviews.apache.org/r/50705/diff/
Testing
---
make check
Thanks,
Neil Conway
0a72b345538ca3b9510fccf38ceb68ac71c2b473
Diff: https://reviews.apache.org/r/50702/diff/
Testing
---
make check
Thanks,
Neil Conway
://reviews.apache.org/r/50702/#review146419
---
On Aug. 25, 2016, 9:09 a.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. T
/diff/
Testing
---
make check
Thanks,
Neil Conway
/
Testing
---
make check
Thanks,
Neil Conway
/partition_tests.cpp 0a72b345538ca3b9510fccf38ceb68ac71c2b473
src/tests/slave_tests.cpp dcf84545354dd2ae0ab5acad3b15eca0467b9982
Diff: https://reviews.apache.org/r/51374/diff/
Testing
---
make check
Thanks,
Neil Conway
sts/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86
src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00
Diff: https://reviews.apache.org/r/50705/diff/
Testing
---
make check
Thanks,
Neil Conway
/registrar_tests.cpp b04fc92c66449f1094212a534899e16d5f6f01bd
Diff: https://reviews.apache.org/r/51021/diff/
Testing
---
make check
Thanks,
Neil Conway
tps://reviews.apache.org/r/51324/diff/
Testing (updated)
---
make check on Linux with glibc>=2.24 and Mac OS X.
Thanks,
Neil Conway
"re-register" whenever it is used in comments
> > or log messages. So lets be consistent.
> >
> > here and everywhere else.
>
> Neil Conway wrote:
> Not opposed to making this consistent, but we use `reregister` in plenty
> of
/50845/diff/
Testing
---
make check
Thanks,
Neil Conway
/
Testing
---
make check
Thanks,
Neil Conway
/50707/diff/
Testing
---
make check
Thanks,
Neil Conway
e
cleanup patch.
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50705/#review147825
---
On Sept. 5, 2016, 2:38 p.m., Neil
sts/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86
src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00
Diff: https://reviews.apache.org/r/50705/diff/
Testing
---
make check
Thanks,
Neil Conway
f3142ad8d50daafcdb70ad9dbb2772f8ba30db00
Diff: https://reviews.apache.org/r/51653/diff/
Testing
---
make check on OSX and Linux.
`./src/mesos-tests
--gtest_filter="Strict/PartitionTest.FailHealthChecksTwice/0"
--gtest_repeat=1000 --gtest_break_on_failure`
Thanks,
Neil Conway
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50706/#review147827
-------
On Aug. 29, 2016, 9:49 a.m., Neil Conway wrote:
>
> -
f3142ad8d50daafcdb70ad9dbb2772f8ba30db00
Diff: https://reviews.apache.org/r/50706/diff/
Testing
---
make check
Thanks,
Neil Conway
----
On Sept. 6, 2016, 3:27 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50707/
> ---
/50707/diff/
Testing
---
make check
Thanks,
Neil Conway
gt; assumption is actually wrong! tasks could be unknown to the master but
> > known to the agent. not sure why we made that assumption.
>
> Neil Conway wrote:
> I believe that the comment in `Master::reconcile` assumes that the master
> hasn't failed over (see the `NOTE` at t
/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647
Diff: https://reviews.apache.org/r/50707/diff/
Testing
---
make check
Thanks,
Neil Conway
1101 - 1200 of 2064 matches
Mail list logo
