Description
---
See summary.
Diffs
-
src/examples/inverse_offer_framework.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/65255/diff/1/
Testing
---
make check && tested with external tooling.
Thanks,
Till Toenshoff
On Nov. 23, 2016, 2:24 p.m., Joseph Wu wrote:
> > Doing a `make check` with this patch on top of `master` did not work,
> > modifying it following the two comments above fixed the problem.
Those issues are now fixed by https://reviews.apache.org/r/65255/
- Till
-
-
src/examples/inverse_offer_framework.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/65255/diff/1/
Testing
---
make check && tested with external tooling.
Thanks,
Till Toenshoff
/65255/diff/1/
Testing
---
make check && tested with external tooling.
Thanks,
Till Toenshoff
org/r/65203/#comment274942>
This one should be reworded; s/Investigate supporting /Added support for/
- Till Toenshoff
On Jan. 18, 2018, 12:21 a.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail.
2c33a57b2b876191249410a
> src/tests/persistent_volume_framework_test.sh
> 2ab22c03e573d4801c73957f9cad2939b3d3174b
>
>
> Diff: https://reviews.apache.org/r/64849/diff/4/
>
>
> Testing
> ---
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
-----
On Jan. 17, 2018, 11:37 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64857/
> --
5a7bac52c33a57b2b876191249410a
Diff: https://reviews.apache.org/r/64857/diff/4/
Changes: https://reviews.apache.org/r/64857/diff/3-4/
Testing
---
make check
Thanks,
Till Toenshoff
/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a
src/tests/persistent_volume_framework_test.sh
2ab22c03e573d4801c73957f9cad2939b3d3174b
Diff: https://reviews.apache.org/r/64849/diff/4/
Changes: https://reviews.apache.org/r/64849/diff/3-4/
Testing
---
make check
Thanks,
Till
Diff: https://reviews.apache.org/r/64848/diff/4/
Changes: https://reviews.apache.org/r/64848/diff/3-4/
Testing
---
make check
Thanks,
Till Toenshoff
-----
On Jan. 15, 2018, 12:29 a.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64848/
>
/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a
Diff: https://reviews.apache.org/r/64848/diff/3/
Changes: https://reviews.apache.org/r/64848/diff/2-3/
Testing
---
make check
Thanks,
Till Toenshoff
org/r/64857/diff/2-3/
Testing
---
make check
Thanks,
Till Toenshoff
enhancement aids in unifying the user experience when tinkering with
our examples.
Diffs (updated)
-
src/examples/flags.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/64847/diff/3/
Changes: https://reviews.apache.org/r/64847/diff/2-3/
Testing
---
make check
Thanks,
Till Toenshoff
482f65efc15a7bac52c33a57b2b876191249410a
src/tests/persistent_volume_framework_test.sh
2ab22c03e573d4801c73957f9cad2939b3d3174b
Diff: https://reviews.apache.org/r/64849/diff/3/
Changes: https://reviews.apache.org/r/64849/diff/2-3/
Testing
---
make check
Thanks,
Till Toenshoff
Used the wrong constructor here - this won't authenticate.
- Till Toenshoff
On Jan. 9, 2018, 11:10 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
flags like this? Also, not
> > clear why v0 and v1 have different flags. Can you provide more context?
>
> Till Toenshoff wrote:
> The breakdown happened on the basis of existing example framework
> implementations and the features they offered. Formerly V0 example framewor
tinkering with
our examples.
Diffs (updated)
-
src/examples/flags.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/64847/diff/2/
Changes: https://reviews.apache.org/r/64847/diff/1-2/
Testing
---
make check
Thanks,
Till Toenshoff
482f65efc15a7bac52c33a57b2b876191249410a
Diff: https://reviews.apache.org/r/64848/diff/2/
Changes: https://reviews.apache.org/r/64848/diff/1-2/
Testing
---
make check
Thanks,
Till Toenshoff
org/r/64857/diff/1-2/
Testing
---
make check
Thanks,
Till Toenshoff
482f65efc15a7bac52c33a57b2b876191249410a
Diff: https://reviews.apache.org/r/64849/diff/2/
Changes: https://reviews.apache.org/r/64849/diff/1-2/
Testing
---
make check
Thanks,
Till Toenshoff
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64847/#review195007
---
On Dec. 28, 2017, 2:06 a.m., Till Toenshoff wrote:
>
> ---
> This is
follow instead and return what it gets then.
But if CURL now decided it followed enough redirects, maybe it does actually
come back with a 3XX even though it should follow instead. SUCH case is treated
as a success and that is exactly what this says :)
- Till Toenshoff
On Jan. 5, 2018, 4 p.m., Ale
/r/64848/diff/1/
Testing
---
make check
Thanks,
Till Toenshoff
-
src/examples/example_framework_flags.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/64847/diff/1/
Testing
---
make check
Thanks,
Till Toenshoff
ecutor_framework.cpp
972ef777cec07d1030af208daef69ebe606d071e
src/examples/test_framework.cpp acf1faf1523c8c03483dfafbc8f8e245322527e4
src/examples/test_http_framework.cpp 482f65efc15a7bac52c33a57b2b876191249410a
Diff: https://reviews.apache.org/r/64857/diff/1/
Testing
---
make c
a03b6bcddcd4397808d415922b5317ac7d68b8a0
Diff: https://reviews.apache.org/r/64846/diff/1/
Testing
---
make check
Thanks,
Till Toenshoff
/r/64849/diff/1/
Testing
---
make check
Thanks,
Till Toenshoff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64683/#review194334
---
Ship it!
Ship It!
- Till Toenshoff
On Dec. 20, 2017, 4:31
/hook.md PRE-CREATION
docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3
Diff: https://reviews.apache.org/r/64297/diff/1/
Testing
---
Thanks,
Till Toenshoff
c5231e242cfe42834beeb98846c9308e0fd8dff3
Diff: https://reviews.apache.org/r/64297/diff/1/
Testing
---
Thanks,
Till Toenshoff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63662/#review190561
---
Ship it!
Ship It!
- Till Toenshoff
On Nov. 9, 2017, 10 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63494/#review190137
---
Ship it!
Ship It!
- Till Toenshoff
On Nov. 2, 2017, 1:57
: mesos
Description
---
Adds the ability to authenticate against the master to the test-http-framework.
Diffs
-
src/examples/test_http_framework.cpp 693dd47694678e7439f9d4ab0ff77b93950edf6e
Diff: https://reviews.apache.org/r/63463/diff/1/
Testing
---
make check
Thanks,
Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62886/#review188296
---
Ship it!
Ship It!
- Till Toenshoff
On Oct. 11, 2017, 1:29
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62887/#review187667
---
Ship it!
Ship It!
- Till Toenshoff
On Oct. 11, 2017, 1:29
next one in that
chain, please.
src/master/allocator/mesos/hierarchical.cpp
Line 1466 (original), 1466 (patched)
<https://reviews.apache.org/r/62886/#comment264713>
Why not this one to `VLOG(2)`?
- Till Toenshoff
On Oct. 11, 2017, 1:29 p.m., Armand Gr
src/common/http.hpp 0e6b1c59860e75c04e2e3be2520ed2b39c84ac90
Diff: https://reviews.apache.org/r/62592/diff/5/
Changes: https://reviews.apache.org/r/62592/diff/4-5/
Testing
---
Integration test in external project. Further tests upcoming.
Thanks,
Till Toenshoff
iews.apache.org/r/62594/#review187497
---
On Oct. 2, 2017, 10:29 a.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
nerated e-mail. To reply, visit:
https://reviews.apache.org/r/62594/#review187493
---
On Oct. 2, 2017, 10:29 a.m., Till Toenshoff wrote:
>
> ---
> This is an automatic
/authenticatee.hpp PRE-CREATION
src/Makefile.am da8af916652a80303f37b65056920676726f8dfe
Diff: https://reviews.apache.org/r/62587/diff/6/
Changes: https://reviews.apache.org/r/62587/diff/5-6/
Testing
---
Integration test in external project. Further tests upcoming.
Thanks,
Till Toenshoff
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62587/#review187246
---
On Oct. 2, 2017, 6:55 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
eviews.apache.org/r/62587/#review187244
-------
On Oct. 2, 2017, 6:55 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To re
/http/authenticatee.hpp PRE-CREATION
src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900
Diff: https://reviews.apache.org/r/62587/diff/3/
Changes: https://reviews.apache.org/r/62587/diff/2-3/
Testing
---
Integration test in external project. Further tests upcoming.
Thanks,
Till
: https://reviews.apache.org/r/62594/diff/1-2/
Testing
---
Integration test in external project. Further tests upcoming.
Thanks,
Till Toenshoff
Also, this seems bad :) (also for modules_dir) I wonder if we have a
> > ticket for eliminating this code duplication thru common inheritance?
>
> Till Toenshoff wrote:
> Yes, lets fix this particular stuff via a ticket and flags inher
0e6b1c59860e75c04e2e3be2520ed2b39c84ac90
Diff: https://reviews.apache.org/r/62592/diff/2/
Changes: https://reviews.apache.org/r/62592/diff/1-2/
Testing
---
Integration test in external project. Further tests upcoming.
Thanks,
Till Toenshoff
.
Thanks,
Till Toenshoff
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review186495
---
On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
>
> ---
> This is an au
eviews.apache.org/r/62594/#review186483
---
On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
-------
On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62592/
> --
llows that properly. Could you please enhance it that way?
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62587/#review186390
----
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62592/#review186476
---
On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
>
> --
project. Further tests upcoming.
Thanks,
Till Toenshoff
def233d13f627f58362fdc61ac3e9c104d65fe7e
src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505
Diff: https://reviews.apache.org/r/62595/diff/1/
Testing
---
Integration test in external project. Further tests upcoming.
Thanks,
Till Toenshoff
://reviews.apache.org/r/62587/diff/1/
Testing
---
Integration test in external project. Further tests upcoming.
Thanks,
Till Toenshoff
ec5614a6d2e9555fd8c8e35309ef05ad5c312638
Diff: https://reviews.apache.org/r/62591/diff/1/
Testing
---
Integration test in external project. Further tests upcoming.
Thanks,
Till Toenshoff
78f53707364ab988bcc53ec2c95490df04cd9a6c
Diff: https://reviews.apache.org/r/62594/diff/1/
Testing
---
Integration test in external project. Further tests upcoming.
Thanks,
Till Toenshoff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62358/#review185500
---
Ship it!
Ship It!
- Till Toenshoff
On Sept. 15, 2017, 6:10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61849/#review184345
---
Ship it!
Ship It!
- Till Toenshoff
On Aug. 31, 2017, 4:39
turely
instantiated objects up - can you elaborate this preference?
- Till Toenshoff
On Aug. 25, 2017, 5:34 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61745/#review183249
---
Ship it!
Ship It!
- Till Toenshoff
On Aug. 18, 2017, 5:25
> On Aug. 18, 2017, 4:55 p.m., Till Toenshoff wrote:
> > docs/endpoints/slave/api/v1/resource_provider.md
> > Lines 12 (patched)
> > <https://reviews.apache.org/r/61732/diff/2/?file=1800019#file1800019line12>
> >
> > Not yours but the capitalizing h
zing here is inconsitent - we should possibly fix
the source.
"Local resource Provider" vs. "local resource provider" later in this
document. Also why are "Call" and "Event" capitalized -- they are neither
product nor company names.
@anandmazumda
?
include/mesos/v1/master/master.proto
Line 410 (original), 409 (patched)
<https://reviews.apache.org/r/61733/#comment259253>
See above - kinda confusing. Guessing that you have simply made it
consistant with unversioned but we should double-check with the maintainers
here, I feel.
- T
.
Repository: mesos
Description
---
see summary.
Diffs
-
docs/health-checks.md 41fc4f8f224115d9a1d634aa0a775a9d01b4e938
Diff: https://reviews.apache.org/r/61735/diff/1/
Testing
---
site/mesos-website-dev.sh
Thanks,
Till Toenshoff
/reviews.apache.org/r/61725/#comment259227>
s/A default/The default/?
s/resolved/resolvs/?
- Till Toenshoff
On Aug. 18, 2017, 1:30 a.m., Kapil Arya wrote:
>
> ---
org/r/61495/#comment258464>
Avoiding duplication by moving this comment into the implementation seems a
good move to me.
- Till Toenshoff
On Aug. 9, 2017, 3:41 p.m., Benno Evers wrote:
>
> ---
> This is an automatically generated
(patched)
<https://reviews.apache.org/r/61517/#comment258444>
See my (non issue) comment in the previous one.
- Till Toenshoff
On Aug. 9, 2017, 10:47 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically gener
TX_new],
[found_ssl=yes],
[],
[-lcrypto])])
```
I am a fan of consistent formatting but leaving it up to you to decide :) -
hence not an "issue".
- Till Toenshoff
On Aug. 9, 2017, 10:46 p.m., Chun-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61458/#review182492
---
Ship it!
Ship It!
- Till Toenshoff
On Aug. 7, 2017, 11:52
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60646/#review182491
---
Ship it!
Ship It!
- Till Toenshoff
On Aug. 7, 2017, 10:30
2017, 9:30 a.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60996/
> ---
>
> (Updated July 21, 2017, 9:30 a.m.)
g/r/60996/#comment257124>
Indeed - thanks!
- Till Toenshoff
On July 21, 2017, 9:30 a.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60913/#review181514
---
Ship it!
Ship It!
- Till Toenshoff
On July 26, 2017, 9:25
This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60996/
> -------
>
> (Updated July 21, 2017, 9:30 a.m.)
>
>
> Review request for mesos, Jie Yu and Till Toenshoff.
>
>
> Bugs: MESOS-7792
> htt
--
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60913/
> ---
>
> (Updated July 26, 2017, 9:25 a.m.)
>
>
> Review r
ed e-mail. To reply, visit:
> https://reviews.apache.org/r/60996/
> ---
>
> (Updated July 21, 2017, 9:30 a.m.)
>
>
> Review request for mesos, Jie Yu and Till Toenshoff.
>
>
> Bugs: MESOS-7792
> https://issues.apache.org/jira/browse/MESOS-7792
>
>
> R
d e-mail. To reply, visit:
> https://reviews.apache.org/r/60996/
> ---
>
> (Updated July 21, 2017, 9:30 a.m.)
>
>
> Review request for mesos, Jie Yu and Till Toenshoff.
>
>
> Bugs: MESOS-7792
>
> On July 26, 2017, 8:55 a.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/src/openssl.cpp
> > Lines 672 (patched)
> > <https://reviews.apache.org/r/60913/diff/6/?file=1782092#file1782092line672>
> >
> > This would break with OpenSSL < 0.9.8 a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61063/#review181497
---
Ship it!
Ship It!
- Till Toenshoff
On July 23, 2017, 9:09
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61064/#review181496
---
Ship it!
Ship It!
- Till Toenshoff
On July 23, 2017, 9:09
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60996/#review181491
---
Ship it!
Ship It!
- Till Toenshoff
On July 21, 2017, 9:30
tps://reviews.apache.org/r/60913/#comment257022>
This would break with OpenSSL < 0.9.8 as the function
`initialize_ecdh_curve` would not exist.
- Till Toenshoff
On July 25, 2017, 10:11 a.m., Alexander Rojas wrote:
>
> -
command =
path::join(os::realpath(Path(argv[0]).dirname()).get(),
EXECUTOR_BINARY);
}
}
```
- Till Toenshoff
On July 25, 2017, 3:47 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically
lag is not set, we can now allow archive downloads
and achieve what we want without having to;
- trigger multiple downloads
- accept depending libraries to be `chmod` into `+X` which wont trigger
failures but still is nasty
- Till Toenshoff
On July 25, 2017, 3:48 p.m., Armand Grillet
> On July 20, 2017, 3:51 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/src/openssl.cpp
> > Lines 294 (patched)
> > <https://reviews.apache.org/r/60913/diff/4/?file=1780273#file1780273line294>
> >
> > Judging from the NGINX sources, it appears tha
g/r/60996/#comment256487>
s/The valid values depends of OpenSSL version/Valid values depend on the
OpenSSL version used/
- Till Toenshoff
On July 20, 2017, 12:38 p.m., Alexander Rojas wrote:
>
> ---
> This is an automatica
guard against that.
- Till Toenshoff
On July 20, 2017, 12:37 p.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On July 20, 2017, 3:21 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/src/openssl.cpp
> > Lines 124 (patched)
> > <https://reviews.apache.org/r/60913/diff/4/?file=1780273#file1780273line124>
> >
> > ```
> > &qu
> On July 20, 2017, 3:21 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/src/openssl.cpp
> > Lines 118 (patched)
> > <https://reviews.apache.org/r/60913/diff/4/?file=1780273#file1780273line118>
> >
> > We are still missing the documentation in `d
ly use `error_string` again?
3rdparty/libprocess/src/openssl.cpp
Lines 352 (patched)
<https://reviews.apache.org/r/60913/#comment256479>
s/defined()/
- Till Toenshoff
On July 20, 2017, 12:37 p.m., Alexander Rojas wrote:
>
> ---
ed)
<https://reviews.apache.org/r/60913/#comment256265>
Please add a leading comment on what we are testing here.
- Till Toenshoff
On July 18, 2017, 12:13 p.m., Alexander Rojas wrote:
>
> ---
>
tps://reviews.apache.org/r/60215/#comment255853>
I am not sure this wont grow into output sizes that become significant load
for the logging system. How about doing the offer detail logging on VLOG level
2?
- Till Toenshoff
On June 19, 2017, 11:08 p.m., Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60214/#review180659
---
Ship it!
Ship It!
- Till Toenshoff
On June 19, 2017, 10:42
ted e-mail. To reply, visit:
> https://reviews.apache.org/r/59525/
> ---
>
> (Updated July 7, 2017, 3:05 p.m.)
>
>
> Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.
>
>
> Bugs: MESOS-7416
> https://issues.apache.org/jira/browse/MESOS-7416
>
>
&
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59525/
> ---
>
> (Updated July 7, 2017, 3:05 p.m.)
>
>
> Review request for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59525/#review179834
---
Needs a rebase.
- Till Toenshoff
On June 13, 2017, 2:12 p.m
)
<https://reviews.apache.org/r/60425/#comment254297>
Will fix the ordering while committing.
- Till Toenshoff
On June 26, 2017, 10:42 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail.
tps://reviews.apache.org/r/60427/#comment254298>
Ordering gets fixed while committing.
- Till Toenshoff
On June 26, 2017, 10:42 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
301 - 400 of 1274 matches
Mail list logo
