Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-08 Thread zhou xing
/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 Diff: https://reviews.apache.org/r/48438/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-09 Thread zhou xing
ed e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review136864 --- On 六月 8, 2016, 6:37 p.m., zhou xing wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-09 Thread zhou xing
6e1bf9557a854a89fa9173223295816a9e114e7c src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 Diff: https://reviews.apache.org/r/48438/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-30 Thread zhou xing
will submit a patch then - zhou --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review135408 --- On 五月 18,

Re: Review Request 47805: Add authorization to GET /weights.

2016-05-27 Thread zhou xing
for your time on looking this. - zhou --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47805/#review135190 ------- On May 27, 2016, 5:45 a.m., zhou xing wrote: > > -

Re: Review Request 47805: Add authorization to GET /weights.

2016-05-27 Thread zhou xing
reply, visit: https://reviews.apache.org/r/47805/#review135190 ------- On May 27, 2016, 5:45 a.m., zhou xing wrote: > > --- > This is an automatically

Re: Review Request 47805: Add authorization to GET /weights.

2016-05-27 Thread zhou xing
isit: https://reviews.apache.org/r/47805/#review135190 ------- On 五月 27, 2016, 5:45 a.m., zhou xing wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47805/ > ---

Re: Review Request 47805: Add authorization to GET /weights.

2016-05-30 Thread zhou xing
/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 47805: Add authorization to GET /weights.

2016-05-26 Thread zhou xing
st test in this test case. Or we can merge the get weights test and update weights test together into one, please let me know your comments, thanks. - zhou --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 47805: Add authorization to GET /weights.

2016-05-26 Thread zhou xing
/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 47909: Slave/Agent Rename Phase I - Updated terms in the website.

2016-05-26 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47909/#review135125 --- Ship it! ok to me - zhou xing On 五月 26, 2016, 5:15 p.m

Review Request 47944: Set timestamp when updating task status from long lived framework.

2016-05-27 Thread zhou xing
"46 years ago", it should show "just now" or the current timestamp Thanks, zhou xing

Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-21 Thread zhou xing
weights. Diffs - src/master/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4 src/master/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 Diff: https://reviews.apache.org/r/48940/diff/ Testing --- make make check Thanks, zhou xing

Review Request 49064: Implement v1 operator update weights API.

2016-06-21 Thread zhou xing
bf1a294f1fc3c8659c31115beee3876d4d0a45e2 Diff: https://reviews.apache.org/r/49064/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48841: Add Agent protobuf message.

2016-06-21 Thread zhou xing
check Thanks, zhou xing

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-21 Thread zhou xing
, zhou xing

Re: Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

2016-06-21 Thread zhou xing
cally generated e-mail. To reply, visit: https://reviews.apache.org/r/48925/#review138732 --- On 六月 20, 2016, 3:35 a.m., zhou xing wrote: > > --- > This is an automati

Re: Review Request 48841: Add Agent protobuf message.

2016-06-17 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48841/#review138173 --- On 六月 17, 2016, 6:37 a.m., zhou xing wrote: > > -

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-19 Thread zhou xing
/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d src/tests/api_tests.cpp d9596f35c2adfbb223c831136546bd854b19c320 Diff: https://reviews.apache.org/r/48438/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48924: Extract public logic of collecting weights info into _getWeights.

2016-06-19 Thread zhou xing
Thanks, zhou xing

Re: Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

2016-06-19 Thread zhou xing
check Thanks, zhou xing

Review Request 48924: Extract public logic of collecting weights info into _getWeights.

2016-06-19 Thread zhou xing
weight info. Diffs - src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d src/master/weights_handler.cpp 25075357c5ac8450d2fa1790844802f121908e9e Diff: https://reviews.apache.org/r/48924/diff/ Testing --- make make check Thanks, zhou xing

Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

2016-06-19 Thread zhou xing
src/master/weights_handler.cpp 25075357c5ac8450d2fa1790844802f121908e9e src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf Diff: https://reviews.apache.org/r/48925/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48841: Add Agent protobuf message.

2016-06-18 Thread zhou xing
er.proto 59e978fef6e0faca7dc8c25b47a79f0b5007d0a6 include/mesos/v1/mesos.proto 9be22f02861f1eb89ab547d88530faf90ebee7ab Diff: https://reviews.apache.org/r/48841/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-18 Thread zhou xing
) - src/master/http.cpp a6beb1721958a77886f0aa535346e2ff33bd5d04 src/master/master.hpp 618d928ef1398e7397df968c7cd47acbc987d1e3 src/tests/api_tests.cpp afa5ffab8729dfc5b102968ec64c6a3bcd832dfd Diff: https://reviews.apache.org/r/48438/diff/ Testing --- make make check Thanks, zhou

Re: Review Request 49064: Implement v1 operator update weights API.

2016-06-23 Thread zhou xing
9120b71fc7725bdf7094aac6619d8aadcc352df5 src/master/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49064/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-23 Thread zhou xing
/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48841: Add Agent protobuf message.

2016-06-22 Thread zhou xing
/master.proto Diffs (updated) - include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 Diff: https://reviews.apache.org/r/48841/diff/ Testing --- make make check Thanks, zhou

Re: Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.

2016-06-15 Thread zhou xing
g/r/48596/#comment203125> for some of the set_xxx or update_xxx method, we do not need contentType, we keep this param only for consistency? - zhou xing On 六月 15, 2016, 5:14 p.m., haosdent huang wrote: > > --- > This is a

Re: Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.

2016-06-15 Thread zhou xing
> On 六月 16, 2016, 1:11 a.m., zhou xing wrote: > > src/master/http.cpp, line 1371 > > <https://reviews.apache.org/r/48596/diff/4/?file=1420195#file1420195line1371> > > > > for some of the set_xxx or update_xxx method, we do not need > > contentType,

Review Request 48835: Remove duplicate return in getHealth method.

2016-06-16 Thread zhou xing
Description --- removed the duplicate return clause. Diffs - src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d Diff: https://reviews.apache.org/r/48835/diff/ Testing --- make Thanks, zhou xing

Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

2016-06-23 Thread zhou xing
src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49137/diff/ Testing --- make make check Thanks, zhou xing

Review Request 49136: Add Framework protobuf message.

2016-06-23 Thread zhou xing
esos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 Diff: https://reviews.apache.org/r/49136/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 49157: Added missing comments for operator API protos.

2016-06-23 Thread zhou xing
pache.org/r/49157/ > --- > > (Updated 六月 23, 2016, 3:47 p.m.) > > > Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay > Guo, Shuai Lin, and Vinod Kone. > > > Bugs: MESOS-5695

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

2016-06-24 Thread zhou xing
g/r/49137/#comment204518> Need to update the method according to GetFrameworks message change - zhou xing On 六月 24, 2016, 1:42 a.m., zhou xing wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 49136: Add Framework protobuf message.

2016-06-24 Thread zhou xing
ated) - include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 Diff: https://reviews.apache.org/r/49136/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48705: Implemented LIST_FILES Call in v1 agent API.

2016-06-23 Thread zhou xing
> On 六月 24, 2016, 12:51 a.m., Anand Mazumdar wrote: > > src/slave/http.cpp, lines 666-714 > > > > > > We can use the `FilesError` type's to construct the response here and > > just have one public `browse` that

Re: Review Request 49136: Add Framework protobuf message.

2016-06-24 Thread zhou xing
lude/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 Diff: https://reviews.apache.org/r/49136/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

2016-06-24 Thread zhou xing
/http.cpp 70f084b84db90fde20c05d2354be190f28e72996 src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49137/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-27 Thread zhou xing
/http.cpp 9e6d291aff77bb39462375dfed5dc75f3719806f src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 src/tests/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe Diff: https://reviews.apache.org/r/48438/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48841: Add Agent protobuf message.

2016-06-27 Thread zhou xing
, zhou xing

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

2016-06-27 Thread zhou xing
------- On 六月 27, 2016, 7:48 a.m., zhou xing wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49137/ > ---

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

2016-06-27 Thread zhou xing
t, any suggestions here? - zhou --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49137/#review139571 --- On 六月 27,

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

2016-06-27 Thread zhou xing
9e6d291aff77bb39462375dfed5dc75f3719806f src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 src/tests/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe Diff: https://reviews.apache.org/r/49137/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-27 Thread zhou xing
/48940/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-27 Thread zhou xing
eviews.apache.org/r/48940/#review139409 --- On 六月 28, 2016, 5:21 a.m., zhou xing wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48940/ > --

Review Request 49293: Rename method 'getWeights' to 'get' in WeightsHandler.

2016-06-27 Thread zhou xing
/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 Diff: https://reviews.apache.org/r/49293/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 49064: Implement v1 operator update weights API.

2016-06-27 Thread zhou xing
9120b71fc7725bdf7094aac6619d8aadcc352df5 src/master/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 src/tests/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe Diff: https://reviews.apache.org/r/49064/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

2016-06-28 Thread zhou xing
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/49137/#review139729 --- On 六月 28, 2016, 3:11 a.m., zhou xing wrote: > > --- > This is an automatically generated e

Re: Review Request 49136: Add Framework protobuf message.

2016-06-27 Thread zhou xing
esos/master/master.proto 332261918a069f4e581bfc4d0fc14ce8c86c2617 include/mesos/v1/master/master.proto 681ea1e638777059a6bf792435cbe526bc252f7a Diff: https://reviews.apache.org/r/49136/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

2016-06-28 Thread zhou xing
> On 六月 28, 2016, 6:14 a.m., Vinod Kone wrote: > > src/master/http.cpp, line 1358 > > <https://reviews.apache.org/r/49137/diff/5/?file=1431412#file1431412line1358> > > > > don't use `auto` here because the type is not clear from this > > expression. &g

Re: Review Request 49136: Add Framework protobuf message.

2016-06-28 Thread zhou xing
ated) - include/mesos/master/master.proto f63cc5a9dc379e4e264fe1f08fdc06d8c16d7384 include/mesos/v1/master/master.proto d98281d58daa461ce622af49adff9f748b920b7f Diff: https://reviews.apache.org/r/49136/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 49064: Implement v1 operator update weights API.

2016-06-28 Thread zhou xing
9120b71fc7725bdf7094aac6619d8aadcc352df5 src/master/weights_handler.cpp 0332d86570724e841f97348087808081b2b890af src/tests/api_tests.cpp 7b5c761751e4b28e3966ac8180fb19ce00fc8f30 Diff: https://reviews.apache.org/r/49064/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

2016-06-28 Thread zhou xing
d583bbeb186974135999eaddbab96e69635dcc7c src/master/master.hpp ba271e7a175529c59abd8bb92536eb5bf0136a40 src/tests/api_tests.cpp 7b5c761751e4b28e3966ac8180fb19ce00fc8f30 Diff: https://reviews.apache.org/r/49137/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 49244: Implement READ_FILE for master operator API.

2016-06-28 Thread zhou xing
d583bbeb186974135999eaddbab96e69635dcc7c src/master/master.hpp ba271e7a175529c59abd8bb92536eb5bf0136a40 src/tests/api_tests.cpp 7b5c761751e4b28e3966ac8180fb19ce00fc8f30 Diff: https://reviews.apache.org/r/49244/diff/ Testing --- make make check Thanks, zhou xing

Review Request 49301: Added FilesError class.

2016-06-28 Thread zhou xing
the response. Diffs - src/files/files.hpp b767d5bc5bee16e3bd98199773a6bc7d30c1c32d Diff: https://reviews.apache.org/r/49301/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 49243: Create readFile method in FilesProcess.

2016-06-28 Thread zhou xing
operator v1 API. Diffs (updated) - src/files/files.hpp b767d5bc5bee16e3bd98199773a6bc7d30c1c32d src/files/files.cpp a5a1b86e14f63e5e3834a2900270252fbe16f586 Diff: https://reviews.apache.org/r/49243/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 49243: Create readFile method in FilesProcess.

2016-06-28 Thread zhou xing
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49243/#review139575 --- On 六月 28, 2016, 11:13 a.m., zhou xing wrote: > > ---

Re: Review Request 49243: Create readFile method in FilesProcess.

2016-06-28 Thread zhou xing
inside the namespace declaration. - zhou --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49243/#review139575 ------- On 六月 28, 2016, 11:13 a.m., zhou xing wrote: > > ---

Re: Review Request 49245: Implement READ_FILE for agent operator API.

2016-06-28 Thread zhou xing
f325bc6b7c92adfb47c1a636b7d385a00e461afb src/slave/slave.hpp 2afd7d152dcd2f5390014cd7bd4e926b62c292d1 src/tests/api_tests.cpp 7b5c761751e4b28e3966ac8180fb19ce00fc8f30 Diff: https://reviews.apache.org/r/49245/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 49242: Add ReadFile protobuf message.

2016-06-28 Thread zhou xing
Diff: https://reviews.apache.org/r/49242/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.

2016-06-25 Thread zhou xing
/http.cpp ad3f723ec21dd0e9f3a3f015d4de0702625cd603 src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49137/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 49136: Add Framework protobuf message.

2016-06-25 Thread zhou xing
ated) - include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 Diff: https://reviews.apache.org/r/49136/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 49214: Added `FileInfo` protobuf for describing a File.

2016-06-26 Thread zhou xing
into mesos.proto, will submit today - zhou xing On 六月 24, 2016, 9:13 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 48841: Add Agent protobuf message.

2016-06-17 Thread zhou xing
f: https://reviews.apache.org/r/48841/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

2016-06-17 Thread zhou xing
) - src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 src/tests/api_tests.cpp 03e46cc5e0af8250ba36281e1293a1dc89f8e266 Diff: https://reviews.apache.org/r/48438/diff/ Testing --- make make check Thanks, zhou xing

Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-09 Thread zhou xing
tp.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 src/tests/persistent_volume_endpoints_tests.cpp 81185a161498394020a27f1f5bf747bac5425f43 src/tests/reservation_endpoints_tests.cpp f95ae7a32c3809d150adf1e9e515a3b527e61699 Diff: https://reviews.apache.org/r/44606/diff/ Testing --- Thanks, zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-09 Thread zhou xing
esting --- Thanks, zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-09 Thread zhou xing
ically. Thanks for the review, has updated the patch - zhou --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44606/#review122879 ---

Review Request 45806: Replace Master/Slave Terminology Phase I - Add duplicate binaries.

2016-04-06 Thread zhou xing
-slaves.sh.in 3dd9b51edff2beb3ccc8d5dd44f0cdc265f623f9 Diff: https://reviews.apache.org/r/45806/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-07 Thread zhou xing
h.in 3dd9b51edff2beb3ccc8d5dd44f0cdc265f623f9 Diff: https://reviews.apache.org/r/45806/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-12 Thread zhou xing
> > symlink from `agent->slave`. Possibly renaming `copy-agent-env-template` to > > something more meaningful to cover both the existing stuff, plus setting up > > this symlink. > > > > Finally, the CHANGELOG should be updated as part of

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-12 Thread zhou xing
gure --prefix=${HOME}/install/mesos make make check Thanks, zhou xing

Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-12 Thread zhou xing
/46134/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-12 Thread zhou xing
gure --prefix=${HOME}/install/mesos make make check Thanks, zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-11 Thread zhou xing
Diff: https://reviews.apache.org/r/44606/diff/ Testing --- Thanks, zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-12 Thread zhou xing
e.py 2c4061d71338f66e432dfa4ac86a9693f3ad38bf Diff: https://reviews.apache.org/r/45806/diff/ Testing (updated) --- cd mesos ./bootstrap mkdir build cd build ../configure --prefix=${HOME}/install/mesos make make check Thanks, zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-11 Thread zhou xing
iew - zhou --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44606/#review127678 --- On 四月 7, 2016, 8:56 a.m., zhou xing wrote: > > --

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-04-07 Thread zhou xing
: https://reviews.apache.org/r/44606/diff/ Testing --- Thanks, zhou xing

Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

2016-03-23 Thread zhou xing
/ Testing --- make make check Thanks, zhou xing

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

2016-03-27 Thread zhou xing
might just do the change > > in 0.29.0. This should go into the 0.29.0 CHANGELOG though (API Changes > > section). > > zhou xing wrote: > Thanks for the review, we have sent a message to the community to see > wether anyone are using the return code. will update you the late

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

2016-03-31 Thread zhou xing
/45213/#review126429 --- On 四月 1, 2016, 5:57 a.m., zhou xing wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

2016-03-31 Thread zhou xing
://reviews.apache.org/r/45213/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

2016-04-01 Thread zhou xing
3d0d5828ef095884ca87156d69f963f04dba40a1 Diff: https://reviews.apache.org/r/45213/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 45213: Change 'slave' to 'agent' in all the logs and standard output.

2016-04-01 Thread zhou xing
> On 三月 31, 2016, 8:25 p.m., Vinod Kone wrote: > > Can you call this out specifically in the CHANGELOG (under "Binary API > > Changes) section. > > zhou xing wrote: > Vinod?thanks for the review. I just resubmit the patch to rebase to the > latest code, p

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread zhou xing
le.am and tried locally, it worked. have submitted the updated patch to see if this can make CI happy, thanks - zhou --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4613

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread zhou xing
/cmake/Process3rdpartyConfigure.cmake 7b53a49baddc8b65f9c5b4b8fe5a53b6883b3652 Diff: https://reviews.apache.org/r/46134/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

2016-04-13 Thread zhou xing
7b53a49baddc8b65f9c5b4b8fe5a53b6883b3652 Diff: https://reviews.apache.org/r/46134/diff/ Testing --- make make check Thanks, zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread zhou xing
cd mesos ./bootstrap mkdir build cd build ../configure --prefix=${HOME}/install/mesos make make check Thanks, zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread zhou xing
gure --prefix=${HOME}/install/mesos make make check Thanks, zhou xing

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

2016-04-13 Thread zhou xing
cd mesos ./bootstrap mkdir build cd build ../configure --prefix=${HOME}/install/mesos make make check Thanks, zhou xing

Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.

2016-04-29 Thread zhou xing
' is completely removed in the code, I'm ok to the change - zhou xing On 四月 29, 2016, 4:55 a.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-27 Thread zhou xing
request 'files/read.json' endpoint with negative offset or length argument Thanks, zhou xing

Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

2016-04-28 Thread zhou xing
page and url Thanks, zhou xing

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

2016-04-26 Thread zhou xing
nks, zhou xing

Review Request 46720: Fix the titles of 'Slave/Agent Rename' series tickets in CHANGELOG.

2016-04-26 Thread zhou xing
, zhou xing

Re: Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

2016-04-26 Thread zhou xing
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46676/#review130664 --- On 四月 26, 2016, 6:06 a.m., zhou xing wrote: > > -

Re: Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

2016-04-28 Thread zhou xing
arjs/redirect-to sure, will keep the old ones and update the patch then - zhou --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46761/#review130946 --- On 四月 28, 2016, 5:20 p.m., zhou xing wrote: > >

Review Request 46676: Slave/Agent Rename Phase I: Rename '/include/mesos/slave' folder.

2016-04-26 Thread zhou xing
: https://reviews.apache.org/r/46676/diff/ Testing --- cd mesos ./bootstrap mkdir build cd build ../configure --prefix=${HOME}/install/mesos make make check make install Thanks, zhou xing

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-04-26 Thread zhou xing
request 'files/read.json' endpoint with negative offset or length argument Thanks, zhou xing

  1   2   >