---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70678/#review215491
---
Ship it!
Ship It!
- Jason Lai
On May 22, 2019, 8:25 p.m
system/linux.cpp
Lines 816 (patched)
<https://reviews.apache.org/r/70678/#comment302130>
Nit: I feel we should consider making the masked paths an instance variable
of the isolator class and initializing it with `ROOTFS_MASKED_PATHS` instead,
in the purpose of avoid hard coding.
- Jason Lai
://reviews.apache.org/r/70048/diff/1/
Testing
---
N/A.
Thanks,
Jason Lai
/containerizer/volume_host_path_isolator_tests.cpp
81bf72e869d36edb162b121f9e84a53d2096dae3
Diff: https://reviews.apache.org/r/69287/diff/3/
Changes: https://reviews.apache.org/r/69287/diff/2-3/
Testing
---
`make check`
Thanks,
Jason Lai
ccaf65029ec2d0e78041fc3992a0bf5ca0798686
Diff: https://reviews.apache.org/r/69286/diff/4/
Changes: https://reviews.apache.org/r/69286/diff/3-4/
Testing
---
Thanks,
Jason Lai
s is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69286/#review213061
---
On Feb. 21, 2019, 11:34 p.m., Jason Lai wrote:
>
> ---
> >
> > instead of returning a boolean, do you think it is better to return a
> > `Try` (if we always regard `false` as a error case)?
Makes sense. Done.
- Jason
---
This is an automatically generated e-ma
,
Jason Lai
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69287/#review213047
-------
On Nov. 7, 2018, 10:06 p.m., Jason Lai wrote:
>
> ---
ccaf65029ec2d0e78041fc3992a0bf5ca0798686
Diff: https://reviews.apache.org/r/69286/diff/3/
Changes: https://reviews.apache.org/r/69286/diff/2-3/
Testing
---
Thanks,
Jason Lai
29d8b7985ffde57da02b5fe0d3a524e98acc27c8
src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686
Diff: https://reviews.apache.org/r/69286/diff/2/
Changes: https://reviews.apache.org/r/69286/diff/1-2/
Testing
---
Thanks,
Jason Lai
93#file2106293line658>
> >
> > Remove these lines?
Done.
- Jason
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69286/#review210388
> On Nov. 18, 2018, 5:19 a.m., Jason Lai wrote:
> > Ship It!
With a few nits.
- Jason
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69377/#rev
e followings/the following steps/
2. s/as if it was/as if it were/
- Jason Lai
On Nov. 18, 2018, 5:18 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
Add unit tests for Stout `path::normalize` function in POSIX.
Diffs
-
3rdparty/stout/tests/path_tests.cpp 452865b919c0d3644eb0ece0e17e402318aaff41
Diff: https://reviews.apache.org/r/68832/diff/2/
Testing
---
`make check`
Thanks,
Jason Lai
Repository: mesos
Description
---
Add unit tests for Stout `path::normalize` function in POSIX.
Diffs
-
3rdparty/stout/tests/path_tests.cpp 452865b919c0d3644eb0ece0e17e402318aaff41
Diff: https://reviews.apache.org/r/68832/diff/2/
Testing
---
`make check`
Thanks,
Jason
the actual filesystem.
Diffs
-
3rdparty/stout/include/stout/path.hpp
ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7
Diff: https://reviews.apache.org/r/65811/diff/9/
Testing
---
`make tests and make check` with https://reviews.apache.org/r/68832/
Thanks,
Jason Lai
src/slave/containerizer/mesos/isolators/volume/utils.cpp PRE-CREATION
src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8
src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686
Diff: https://reviews.apache.org/r/69286/diff/1/
Testing
---
Thanks,
Jason Lai
81bf72e869d36edb162b121f9e84a53d2096dae3
Diff: https://reviews.apache.org/r/69287/diff/1/
Testing
---
`make check`
Thanks,
Jason Lai
/stout/include/stout/os/posix/readlink.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/68804/diff/2/
Changes: https://reviews.apache.org/r/68804/diff/1-2/
Testing
---
Thanks,
Jason Lai
---
Thanks,
Jason Lai
)
-
3rdparty/stout/tests/path_tests.cpp 452865b919c0d3644eb0ece0e17e402318aaff41
Diff: https://reviews.apache.org/r/68832/diff/2/
Changes: https://reviews.apache.org/r/68832/diff/1-2/
Testing (updated)
---
`make check`
Thanks,
Jason Lai
/linux/fs.hpp 31969f6ba82bf5ee549bfdf9698a21adaa486a90
src/linux/fs.cpp 5cdffe1f4c7f00aee5b8f640e7cfa4a0018cfa0a
Diff: https://reviews.apache.org/r/67175/diff/3/
Changes: https://reviews.apache.org/r/67175/diff/2-3/
Testing
---
Thanks,
Jason Lai
Diff: https://reviews.apache.org/r/65811/diff/9/
Changes: https://reviews.apache.org/r/65811/diff/8-9/
Testing
---
`make tests and make check` with https://reviews.apache.org/r/68832/
Thanks,
Jason Lai
/8/
Testing (updated)
---
`make tests and make check` with https://reviews.apache.org/r/68832/
Thanks,
Jason Lai
e added in https://reviews.apache.org/r/68832/.
- Jason
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/#review199363
-------
/stout/path.hpp
ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7
Diff: https://reviews.apache.org/r/65811/diff/8/
Changes: https://reviews.apache.org/r/65811/diff/7-8/
Testing (updated)
---
`make tests` with https://reviews.apache.org/r/68832/
Thanks,
Jason Lai
Diff: https://reviews.apache.org/r/68832/diff/1/
Testing
---
`make tests`
Thanks,
Jason Lai
filesystem.
Diffs
-
3rdparty/stout/include/stout/path.hpp
ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7
Diff: https://reviews.apache.org/r/65811/diff/7/
Testing
---
Thanks,
Jason Lai
absolute paths` sounds a little weird. are these
> > two separate todo items or one?
Fixed.
- Jason
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/#review208903
-------
only now).
Diffs (updated)
-
3rdparty/stout/include/stout/path.hpp
ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7
Diff: https://reviews.apache.org/r/65811/diff/7/
Changes: https://reviews.apache.org/r/65811/diff/6-7/
Testing
---
Thanks,
Jason Lai
---
On Sept. 21, 2018, 10:34 p.m., Jason Lai wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68804/
> -
/
Testing
---
Thanks,
Jason Lai
generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review203455
-----------
On May 17, 2018, 1:07 a.m., Jason Lai wrote:
>
> ---
> This is an automatically
_separator`
Dropped.
- Jason
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review203430
---
On May 17, 2018, 1:07 a.m., Jason
://reviews.apache.org/r/68804/diff/1/
Testing
---
Thanks,
Jason Lai
t:
https://reviews.apache.org/r/65811/#review203453
-------
On Sept. 21, 2018, 9:53 p.m., Jason Lai wrote:
>
> ---
> This is an automatically generated e
> } else if (!isEmpty && components.back() == "..") {
> > components.push_back(component);
> > } else if (!isEmpty) {
> > components.pop_back();
> > }
> > }
> > ```
>
> Jason Lai wrote:
> I was
).
Diffs (updated)
-
3rdparty/stout/include/stout/path.hpp
ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7
Diff: https://reviews.apache.org/r/65811/diff/6/
Changes: https://reviews.apache.org/r/65811/diff/5-6/
Testing
---
Thanks,
Jason Lai
> > If we can emulate the `os::stat` API and use enum constants to make
> > this more obvious at the call site:
> > ```
> > os::touch(path, os::Touch::RECURSIVE, os::Touch::FILE);
> > ```
> >
> > cc @jieyu
>
> Jason Lai wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67022/#review208684
---
Ship it!
Ship It!
- Jason Lai
On Sept. 13, 2018, 5:17 p.m
, os::Touch::RECURSIVE, os::Touch::FILE);
> > ```
> >
> > cc @jieyu
Makes sense. I've dropped the function in this patch and will create another
patch in favor of your suggestion.
- Jason
--------
/67175/diff/1-2/
Testing
---
Thanks,
Jason Lai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68088/#review206604
---
Ship it!
Ship It!
- Jason Lai
On July 30, 2018, 5:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66875/#review204958
---
Ship it!
Ship It!
- Jason Lai
On May 21, 2018, 5:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53105/#review204957
---
Ship it!
Ship It!
- Jason Lai
On May 21, 2018, 5:16 p.m
mountTable->entries)) {
```
This is used in `src/linux/fs.cpp` and a couple of other places.
- Jason Lai
On June 11, 2018, 8:58 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To
It would be safer to check the following:
1) Check if `entry.target` == `info->path`;
2) Check if `strings::startsWith(entry.target, path::join(info->path, ""))`
(`info->path` suffied with a `"/"`)
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/#review203392
---
On May 17, 2018, 1:06 a.m., Jason Lai wrote:
>
inal
> > prefix (which could be a tad annoying), and then re-add it here.
Indeed. As said in a previous comment, will do that in a separate patch for
cross platform support.
- Jason
---
This is an automatically generate
/mesos/launch.cpp
f25d90651ef32495c9161c3eaed8a327d1b2b926
Diff: https://reviews.apache.org/r/67177/diff/1/
Testing
---
Manual
Thanks,
Jason Lai
: https://reviews.apache.org/r/67176/diff/1/
Testing
---
Thanks,
Jason Lai
76dc09c38996eefd8487ba6ef4977ef2f7c9df4c
src/linux/fs.cpp fbd03b19abb9b56dbf3fb8a84d09a39171bbc1b0
Diff: https://reviews.apache.org/r/67175/diff/1/
Testing
---
Thanks,
Jason Lai
/sandbox_path.cpp
e0cae1036e2e49b4f61705c77f31ae166d1b1380
src/slave/containerizer/mesos/isolators/volume/utils.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/65900/diff/3/
Changes: https://reviews.apache.org/r/65900/diff/2-3/
Testing
---
Thanks,
Jason Lai
/65812/diff/5-6/
Testing
---
Thanks,
Jason Lai
now).
Diffs (updated)
-
3rdparty/stout/include/stout/path.hpp
27438d31617b3b78bf3d4deffd25c93340610e8d
Diff: https://reviews.apache.org/r/65811/diff/5/
Changes: https://reviews.apache.org/r/65811/diff/4-5/
Testing
---
Thanks,
Jason Lai
tfs.isSome()) {
return path::join(rootfs.get(), containerSandboxPath, mountPoint);
}
return path::join(hostSandboxPath, mountPoint);
}
```
- Jason Lai
On May 8, 2018, 7:07 p.m., Jason Lai wrote:
>
> ---
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67095/#review202990
---
Ship it!
Ship It!
- Jason Lai
On May 11, 2018, 6:32 p.m
5-L702)
- Jason Lai
On May 11, 2018, 6:31 p.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
fs/tmp`, as well as
making it an extended `pivot_root(2)` with no unnecessary preparations and
cleanups.
- Jason Lai
On May 11, 2018, 6:31 p.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail.
Diff: https://reviews.apache.org/r/67013/diff/2/
Changes: https://reviews.apache.org/r/67013/diff/1-2/
Testing
---
Thanks,
Jason Lai
)
-
src/slave/containerizer/mesos/launch/linux_helper.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/67012/diff/2/
Changes: https://reviews.apache.org/r/67012/diff/1-2/
Testing
---
Thanks,
Jason Lai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67022/#review202723
---
Ship it!
Ship It!
- Jason Lai
On May 9, 2018, 12:40 a.m
8ca3d55d5792ed1cfc8e49df40587ac2abc83fec
src/slave/containerizer/mesos/isolators/volume/utils.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/65900/diff/2/
Changes: https://reviews.apache.org/r/65900/diff/1-2/
Testing
---
Thanks,
Jason Lai
/diff/1/
Testing
---
Thanks,
Jason Lai
/67012/diff/1/
Testing
---
Thanks,
Jason Lai
/65812/diff/4-5/
Testing
---
Thanks,
Jason Lai
/diff/4/
Changes: https://reviews.apache.org/r/65811/diff/3-4/
Testing
---
Thanks,
Jason Lai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66342/#review200167
---
Ship it!
Ship It!
- Jason Lai
On March 28, 2018, 6:23 p.m
Will do in a separate patch.
- Jason
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review199365
---
On Ma
y be moved away from this file, as I polish up
the mounts with other isolators.
- Jason
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66034/#review199281
---------
/volume/sandbox_path.hpp
20d5b32fb7ada1a17a40bf1a2438db4d85cf1063
src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp
5801977e93bcb8f463a2635f73e763098f2aa97d
Diff: https://reviews.apache.org/r/66104/diff/1/
Testing
---
Thanks,
Jason Lai
exec,relatime
|-/sys sysfs sysfs
ro,nosuid,nodev,noexec,relatime
`-/dev tmpfs tmpfs
rw,nosuid,noexec,mode=755
|-/dev/ptsdevpts devpts
rw,nosuid,noexec,relatime,mode=600,ptmxmode=666
`-/dev/shmtmpfs tmpfs rw,nosuid,nodev
```
Thanks,
Jason Lai
: https://reviews.apache.org/r/65899/diff/1-2/
Testing
---
Thanks,
Jason Lai
-CREATION
src/slave/containerizer/mesos/launch/windows_helper.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/65898/diff/3/
Changes: https://reviews.apache.org/r/65898/diff/2-3/
Testing
---
Thanks,
Jason Lai
ps://reviews.apache.org/r/65899/#review198759
-------
On March 5, 2018, 7:31 a.m., Jason Lai wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65899/
> -
ve more folks in favor of it.
- Jason
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/#review198548
---
On Ma
exec,relatime
|-/sys sysfs sysfs
ro,nosuid,nodev,noexec,relatime
`-/dev tmpfs tmpfs
rw,nosuid,noexec,mode=755
|-/dev/ptsdevpts devpts
rw,nosuid,noexec,relatime,mode=600,ptmxmode=666
`-/dev/shmtmpfs tmpfs rw,nosuid,nodev
```
Thanks,
Jason Lai
xec,relatime
`-/dev tmpfs tmpfs
rw,nosuid,noexec,mode=755
|-/dev/ptsdevpts devpts
rw,nosuid,noexec,relatime,mode=600,ptmxmode=666
`-/dev/shmtmpfs tmpfs rw,nosuid,nodev
```
Thanks,
Jason Lai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65930/#review198714
---
Ship it!
Ship It!
- Jason Lai
On March 6, 2018, 4:57 p.m
in function "protected: virtual int __cdecl
> > mesos::internal::slave::MesosContainerizerLaunch::execute(void)"
> > (?execute@MesosContainerizerLaunch@slave@internal@mesos@@MEAAHXZ)
> > [D:\DCOS\mesos\src\launcher\mesos-executor.vcxproj]
> >
/1/
Testing
---
Thanks,
Jason Lai
/windows_helper.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/65898/diff/2/
Changes: https://reviews.apache.org/r/65898/diff/1-2/
Testing
---
Thanks,
Jason Lai
-
src/slave/containerizer/mesos/launch.cpp
75b7eaf9cd62d6b5f02896175168b651f4517e12
Diff: https://reviews.apache.org/r/65899/diff/1/
Testing
---
Thanks,
Jason Lai
src/slave/containerizer/mesos/launch/windows_helper.hpp PRE-CREATION
src/slave/containerizer/mesos/launch/windows_helper.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/65898/diff/1/
Testing
---
Thanks,
Jason Lai
://reviews.apache.org/r/65812/diff/3-4/
Testing
---
Thanks,
Jason Lai
://reviews.apache.org/r/65812/diff/2-3/
Testing
---
Thanks,
Jason Lai
).
Diffs (updated)
-
3rdparty/stout/include/stout/path.hpp
27438d31617b3b78bf3d4deffd25c93340610e8d
Diff: https://reviews.apache.org/r/65811/diff/3/
Changes: https://reviews.apache.org/r/65811/diff/2-3/
Testing
---
Thanks,
Jason Lai
/
Testing
---
Thanks,
Jason Lai
.
Diffs (updated)
-
3rdparty/stout/include/stout/os/posix/realpath.hpp
31352cefc5b8d0ccd9af8f6dabdec4a959fded32
Diff: https://reviews.apache.org/r/65812/diff/2/
Changes: https://reviews.apache.org/r/65812/diff/1-2/
Testing
---
Thanks,
Jason Lai
ts.back()` as long as `components` is guaranteed
> > not empty.
Doh! This was dumb. Nice catch!
- Jason
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/#review198334
).
Diffs (updated)
-
3rdparty/stout/include/stout/path.hpp
27438d31617b3b78bf3d4deffd25c93340610e8d
Diff: https://reviews.apache.org/r/65811/diff/2/
Changes: https://reviews.apache.org/r/65811/diff/1-2/
Testing
---
Thanks,
Jason Lai
/posix/realpath.hpp
31352cefc5b8d0ccd9af8f6dabdec4a959fded32
Diff: https://reviews.apache.org/r/65812/diff/1/
Testing
---
Thanks,
Jason Lai
27438d31617b3b78bf3d4deffd25c93340610e8d
Diff: https://reviews.apache.org/r/65811/diff/1/
Testing
---
Thanks,
Jason Lai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65294/#review196550
---
Ship it!
Ship It!
- Jason Lai
On Jan. 30, 2018, 12:03 a.m
4 (patched)
<https://reviews.apache.org/r/56721/#comment268389>
Will there be a race here?
- Jason Lai
On Nov. 10, 2017, 7:34 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
0017d3d9d46433b391703025f611ce437bbc7ebe
Diff: https://reviews.apache.org/r/54693/diff/3/
Testing
---
Thanks,
Jason Lai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60170/#review178153
---
Ship it!
Ship It!
- Jason Lai
On June 17, 2017, 4:58 p.m
> On June 18, 2017, 4:08 a.m., Jason Lai wrote:
> > Ship It!
Ditto Qian's comment.
- Jason
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60170/#rev
the kernel blkio doc for helper functions
Diffs
-
src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433
src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5
Diff: https://reviews.apache.org/r/59960/diff/1/
Testing
---
Thanks,
Jason Lai
1 - 100 of 116 matches
Mail list logo
