[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-64164059 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-64164053 [Test build #23773 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23773/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-24 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-64266203 Okay thanks everyone who worked on this. I'm going to pull it in to make sure it gets into the next preview release. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3009 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-23 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20774720 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala --- @@ -41,11 +41,15 @@ private[ui] class JobProgressPage(parent:

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-23 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20774731 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala --- @@ -41,11 +41,15 @@ private[ui] class JobProgressPage(parent:

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20774742 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala --- @@ -41,11 +41,15 @@ private[ui] class JobProgressPage(parent:

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-64157435 [Test build #23773 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23773/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-22 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20759212 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -31,6 +31,21 @@ import org.apache.spark.scheduler._ import

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-22 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-64092595 Hey @JoshRosen JSON changes LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-22 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-64094091 Took a look at the new JSON stuff and it LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63944081 [Test build #23714 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23714/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63944088 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-64056282 [Test build #23735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23735/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-64062267 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-64062263 [Test build #23735 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23735/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-21 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-64062374 @pwendell @andrewor14 I fixed the JsonProtocol compatibility issues that we discussed and added a note on compatibility guarantees; it would be great if you could take

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-21 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-64063836 Just noticed that the Completed Stages table still shows a Kill button:

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-21 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20753937 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -31,6 +31,21 @@ import org.apache.spark.scheduler._ import

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-21 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20753939 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -31,6 +31,21 @@ import org.apache.spark.scheduler._ import

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63908292 [Test build #23698 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23698/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63914131 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63914127 [Test build #23698 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23698/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-20 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63927868 @JoshRosen I believe this is failing tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-20 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63928198 @pwendell Yep, it looks like a legitimate failure in ReplayListenerSuite: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23698/testReport/

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-20 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63928641 Ah, spotted the problem: I forgot to remove the line that wrote the `Stage Ids` JSON field, so this was mistakenly causing the read path to treat data written in the

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63929025 [Test build #23705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23705/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63933196 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63933193 [Test build #23705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23705/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-20 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63934171 This skipped thing looks great -- I withdraw my -0.5 (which I didn't realize meant this couldn't get merged into 1.2...didn't realize code voting was different

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-20 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63934214 Argh, not again! That's what I get for playing whackamole with individual test suites without running all of them... I've spotted the cause behind this latest

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63935148 [Test build #23714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23714/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-18 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63554720 although there are possibly some race conditions here with the StageInfo being modified by the DAGScheduler concurrently with a listener using it I think this

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-18 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63560812 Awesome -- sounds great! On Tue, Nov 18, 2014 at 2:09 PM, Josh Rosen notificati...@github.com wrote: although there are possibly some race

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-18 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63566220 The good news is that the JobProgressListener already tracks the stages that have already completed, so when we get the JobStartEvent, we can subtract the stage IDs

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-18 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63568209 Alright, I've pushed a new set of commits which add `StageInfos` to the job started event and use these to compute `numTasks` correctly. @andrewor14, it would be

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63568631 [Test build #23569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23569/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-18 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63569572 Now that we expose StageInfos in the job start event, do you think it's worth adding a Pending Stages section to the stages page which lists stages that will

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-18 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63569805 @JoshRosen definitely (re:Pending stages) but not as part of this change, which I'm hoping we can merge soon! Planning to look at it this evening. --- If your

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-18 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63576508 Similarly, it's currently possible for completed jobs to show (Unknown Stage Name) for stages that aren't actually run:

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63576770 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63576764 [Test build #23569 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23569/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-18 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63576847 That last screenshot suggests that there's a problem in how I use StageInfo to determine whether a stage needs to be computed. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63581733 [Test build #23578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23578/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63587633 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63587629 [Test build #23578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23578/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-18 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63588578 I just pushed a bunch of fixes to several UI issues, including several sorting problems. The biggest change is the addition of a pending state on the job details page

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-17 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63367682 I just have one comment about the code, which is that the code for AllStagesPage.scala and JobPage.scala is very similar and I think should be factored into a shared

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-17 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63367998 @JoshRosen ok that makes sense. @pwendell having just the 1/2 etc. text for stages seems fine with me if you think it's more useful / intuitive to novice

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-17 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63371456 The only other issue is something we discussed earlier, which is what happens if a map stage has to be recomputed due to a fetch failure? Do you end up with more

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-17 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63384081 I'm playing around with removing the stages progress bar. It looks like this doesn't result in significant horizontal space savings:

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-17 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63385102 Personally I do prefer the new one. The main argument I was making was not space savings, but instead simplicity and clarity for users. --- If your project is set up

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-17 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63385969 @JoshRosen I think something like this will do the trick to trigger a FetchFailedException: test(hash shuffle manager recovers when local shuffle files get

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63401712 [Test build #23509 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23509/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63401716 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-17 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63411844 Implementing an intuitive progress bar is turning out to be a lot more complicated than I originally anticipated. ## Correctness specification for progress

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-17 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63423908 Would there be an alternative approach where we keep a fixed goal post but we risk over estimating the size of the job if there are stages that are, in fact, not ever

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-17 Thread markhamstra
Github user markhamstra commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63426293 There are several alternative approaches, and they largely differentiate on who is the intended consumer of the progress bar information. For example, a system

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-17 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63426995 One super nit: the stage progress shows X / Y (with spaces) whereas the task one shows X/Y (no spaces). Can you make these consistent? In terms of the

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-14 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63103921 /bump; does anyone have additional feedback on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-14 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63107141 Sorry Josh looking at this now! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-14 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63129471 Sorry again for being slow to look at this! I tried this out and, visually, it looks great -- the kill issue is fixed and I like the new ? help text and

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-14 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63129947 The other thing is I find it a little confusing that the total number of tasks keeps increasing as more stages get submitted. One way to fix this is to change the

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-14 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-63158558 Hey Josh - two pieces of feedback 1. I found having two sliders very visually distracting. What if instead of a slider for the stages, we just have the text

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62520874 [Test build #23209 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23209/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62520879 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20171855 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala --- @@ -25,7 +25,7 @@ import org.apache.spark.scheduler.Schedulable

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62603471 @shivaram and I played around with this a bit and, after looking at it, having the total number of tasks as the only progress bar is somewhat unintuitive. I'd

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20173587 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20173702 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62605715 Also this seems broken? (the stage should be in Active Stages)

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20174342 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20174537 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala --- @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20174958 --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala --- @@ -45,20 +45,23 @@ private[spark] class SparkUI private ( /**

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20175656 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20185389 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20186097 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20189716 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala --- @@ -41,11 +41,13 @@ private[ui] class JobProgressPage(parent:

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20189977 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala --- @@ -41,11 +41,13 @@ private[ui] class JobProgressPage(parent:

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r20189991 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62641172 [Test build #23226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23226/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62642410 Thanks for this latest round of feedback. I'm planning to incorporate three other fixes: 1. Add a help icon that shows a tooltip or popover with descriptive

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62642818 I case it helps, I got there by doing: val a = sc.parallelize(1 to 1, 5) a.map { b = Thread.sleep(1000); b}.count() so hopefully will be

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62652195 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62652182 [Test build #23226 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23226/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62659354 Alright, pushed another set of changes. I've addressed the (Job Group) thing by hiding it when no jobs use job groups (the common case). This has Selenium tests

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62659453 [Test build #23239 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23239/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62666120 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62666116 [Test build #23239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23239/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62497811 One approach, which I'm exploring now, is to show a combined progress bar that just tracks total number of tasks summed across all stages involved in that job. To

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-10 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62508540 This sounds great. I do think it would be good to get this job page change in ASAP, since it's a major, user-visible change and it would be good to have it

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62508831 Agreed. This change actually involves some potentially costly listener operations, so it would be great to get this in soon so it can get lots of testing / review.

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62512817 Alright, added a rough first cut at progress bars. This code is functional, although it might be cleaner. I'll take another look tomorrow when I'm fresh. --- If

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-62513015 [Test build #23209 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23209/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-05 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r19917181 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-05 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r19917176 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala --- @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-05 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/3009#discussion_r19917247 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala --- @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-61906528 @kayousterhout I like the progress bar idea and I'm working on implementing it now. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-61906800 [Test build #22965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22965/consoleFull) for PR 3009 at commit

[GitHub] spark pull request: [SPARK-4145] Web UI job pages

2014-11-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3009#issuecomment-61906977 Actually, there's one subtlety: a single stage might be shared by multiple jobs, so when we get a StageCompletion event we don't know which job triggered that stage.

  1   2   >