[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22192 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r218861435 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -136,6 +136,26 @@ private[spark] class Executor( // for fetching

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r218865220 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216210046 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -136,6 +136,26 @@ private[spark] class Executor( // for fetching remote

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216209462 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -240,6 +240,19 @@ private[spark] object Utils extends Logging { //

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216118263 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -136,6 +136,26 @@ private[spark] class Executor( // for fetching remote

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216116857 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -136,6 +136,26 @@ private[spark] class Executor( // for fetching remote

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216116705 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -68,7 +68,9 @@ public void testPluginClassDoesNotExist() { } catch

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216116706 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -240,6 +240,19 @@ private[spark] object Utils extends Logging { //

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216116693 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -242,14 +242,17 @@ private[spark] class Executor( // Notify

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216112535 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216106676 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216106455 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -219,6 +239,18 @@ private[spark] class Executor(

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216106482 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -219,6 +239,18 @@ private[spark] class Executor(

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216106778 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216106909 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -240,6 +240,16 @@ private[spark] object Utils extends Logging { //

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216105914 --- Diff: core/src/main/java/org/apache/spark/ExecutorPlugin.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216106874 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -240,6 +240,16 @@ private[spark] object Utils extends Logging { //

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216106374 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -136,6 +136,26 @@ private[spark] class Executor( // for fetching remote

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216054443 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -219,6 +236,13 @@ private[spark] class Executor(

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216053464 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -219,6 +236,13 @@ private[spark] class Executor(

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216049652 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216048261 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -136,6 +136,23 @@ private[spark] class Executor( // for fetching remote

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216049113 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -219,6 +236,13 @@ private[spark] class Executor(

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216051495 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216049530 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -219,6 +236,13 @@ private[spark] class Executor(

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r215760787 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -218,6 +244,8 @@ private[spark] class Executor(

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r215750952 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -218,6 +244,8 @@ private[spark] class Executor(

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r215749556 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -136,6 +136,32 @@ private[spark] class Executor( // for fetching remote

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r215749405 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -136,6 +136,32 @@ private[spark] class Executor( // for fetching remote

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r215371723 --- Diff: core/src/main/java/org/apache/spark/ExecutorPlugin.java --- @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r215372559 --- Diff: core/src/main/java/org/apache/spark/ExecutorPlugin.java --- @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r215373277 --- Diff: core/src/main/java/org/apache/spark/ExecutorPlugin.java --- @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r214486314 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r214486250 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -604,4 +604,14 @@ package object config { .intConf

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r214486385 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r214486075 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -136,6 +136,15 @@ private[spark] class Executor( // for fetching remote

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r214486292 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r214485930 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -136,6 +136,15 @@ private[spark] class Executor( // for fetching remote

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r214418189 --- Diff: core/src/main/java/org/apache/spark/ExecutorPlugin.java --- @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r214354883 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,11 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r214354153 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,11 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r214353529 --- Diff: core/src/main/java/org/apache/spark/ExecutorPlugin.java --- @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r214353202 --- Diff: core/src/main/java/org/apache/spark/ExecutorPlugin.java --- @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213837582 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,14 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213832471 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,14 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213831980 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,14 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213828422 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,14 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213819091 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,14 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213818362 --- Diff: core/src/main/java/org/apache/spark/ExecutorPlugin.java --- @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213821565 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213821674 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,14 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213820297 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,14 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213792638 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213792183 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213791918 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,14 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213792035 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,14 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213790939 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,14 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213150133 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,16 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213142394 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,16 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213140764 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,16 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213106129 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,16 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213045752 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,16 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213003599 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,16 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r213003400 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212781171 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212780758 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212780252 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212779435 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212778867 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212777617 --- Diff: core/src/main/java/org/apache/spark/ExecutorPlugin.java --- @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user NiharS commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212777267 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,16 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212747168 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212747219 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212747806 --- Diff: core/src/test/java/test/org/apache/spark/TestExecutorPlugin.java --- @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212747628 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212746377 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,16 @@ private[spark] class Executor( private val

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212746626 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -604,4 +604,15 @@ package object config { .intConf

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212746238 --- Diff: core/src/main/java/org/apache/spark/ExecutorPlugin.java --- @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212745955 --- Diff: core/src/main/java/org/apache/spark/ExecutorPlugin.java --- @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212745901 --- Diff: core/src/main/java/org/apache/spark/ExecutorPlugin.java --- @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212747362 --- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java --- @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #22192: [SPARK-24918][Core] Executor Plugin API

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r212746543 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -130,6 +130,16 @@ private[spark] class Executor( private val