[GitHub] spark pull request #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-28 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17804#discussion_r113965033 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -26,13 +26,16 @@ import

[GitHub] spark issue #17804: [SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed...

2017-04-28 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17804 @hvanhovell We need this fix in master as well. It somehow works magically in master, but is broken for sure in 2.1 --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request #17787: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-27 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17787#discussion_r113788603 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -108,6 +108,31 @@ class KafkaSinkSuite extends

[GitHub] spark pull request #17787: [SPARK-20496][SS] Bug in KafkaWriter Looks at Una...

2017-04-27 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17787#discussion_r113788434 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -108,6 +108,31 @@ class KafkaSinkSuite extends

[GitHub] spark pull request #17765: [SPARK-20464][SS] Add a job group and description...

2017-04-26 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17765#discussion_r113583392 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -252,6 +252,7 @@ class StreamExecution

[GitHub] spark pull request #17735: [SPARK-20441][SPARK-20432][SS] Within the same st...

2017-04-26 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17735#discussion_r113518581 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala --- @@ -120,6 +141,26 @@ class StreamSuite extends StreamTest

[GitHub] spark pull request #17467: [SPARK-20140][DStream] Remove hardcoded kinesis r...

2017-04-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17467#discussion_r112849184 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisBackedBlockRDD.scala --- @@ -135,7 +139,8 @@ class

[GitHub] spark pull request #17467: [SPARK-20140][DStream] Remove hardcoded kinesis r...

2017-04-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17467#discussion_r112848595 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisBackedBlockRDD.scala --- @@ -135,7 +139,8 @@ class

[GitHub] spark pull request #17467: [SPARK-20140][DStream] Remove hardcoded kinesis r...

2017-04-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17467#discussion_r112841794 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisBackedBlockRDD.scala --- @@ -135,7 +139,8 @@ class

[GitHub] spark pull request #17467: [SPARK-20140][DStream] Remove hardcoded kinesis r...

2017-04-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17467#discussion_r112841862 --- Diff: external/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisBackedBlockRDDSuite.scala --- @@ -101,6 +103,36 @@ abstract class

[GitHub] spark pull request #17467: [SPARK-20140][DStream] Remove hardcoded kinesis r...

2017-04-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17467#discussion_r112841727 --- Diff: docs/streaming-kinesis-integration.md --- @@ -216,3 +216,7 @@ de-aggregate records during consumption. - If no Kinesis checkpoint info exists

[GitHub] spark pull request #17467: [SPARK-20140][DStream] Remove hardcoded kinesis r...

2017-04-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17467#discussion_r112841869 --- Diff: external/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisBackedBlockRDDSuite.scala --- @@ -101,6 +103,36 @@ abstract class

[GitHub] spark pull request #17467: [SPARK-20140][DStream] Remove hardcoded kinesis r...

2017-04-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17467#discussion_r112841668 --- Diff: docs/streaming-kinesis-integration.md --- @@ -216,3 +216,7 @@ de-aggregate records during consumption. - If no Kinesis checkpoint info exists

[GitHub] spark issue #17613: [SPARK-20301][FLAKY-TEST] Fix Hadoop Shell.runCommand fl...

2017-04-12 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17613 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #17613: [SPARK-20301][FLAKY-TEST][DO NOT MERGE] Fix Hadoo...

2017-04-11 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17613#discussion_r111067826 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -284,42 +284,38 @@ class StreamExecution

[GitHub] spark pull request #17613: [SPARK-20301][FLAKY-TEST][DO NOT MERGE] Fix Hadoo...

2017-04-11 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/17613 [SPARK-20301][FLAKY-TEST][DO NOT MERGE] Fix Hadoop Shell.runCommand flakiness in Structured Streaming tests ## What changes were proposed in this pull request? Some Structured Streaming

[GitHub] spark issue #17597: [SPARK-20285][Tests]Increase the pyspark streaming test ...

2017-04-10 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17597 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #17467: [SPARK-20140][DStream] Remove hardcoded kinesis r...

2017-04-07 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17467#discussion_r110437376 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisBackedBlockRDD.scala --- @@ -251,21 +255,22 @@ class

[GitHub] spark pull request #17467: [SPARK-20140][DStream] Remove hardcoded kinesis r...

2017-04-07 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17467#discussion_r110437471 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisBackedBlockRDD.scala --- @@ -292,9 +297,3 @@ class

[GitHub] spark pull request #17467: [SPARK-20140][DStream] Remove hardcoded kinesis r...

2017-04-07 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17467#discussion_r110437682 --- Diff: docs/streaming-kinesis-integration.md --- @@ -216,3 +216,7 @@ de-aggregate records during consumption. - If no Kinesis checkpoint info exists

[GitHub] spark pull request #17467: [SPARK-20140][DStream] Remove hardcoded kinesis r...

2017-04-07 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17467#discussion_r110437838 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisBackedBlockRDD.scala --- @@ -83,7 +83,8 @@ class

[GitHub] spark pull request #17467: [SPARK-20140][DStream] Remove hardcoded kinesis r...

2017-04-07 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17467#discussion_r110437249 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisBackedBlockRDD.scala --- @@ -251,21 +255,22 @@ class

[GitHub] spark issue #17543: [SPARK-20230] FetchFailedExceptions should invalidate fi...

2017-04-05 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17543 That JIRA is great. I'll close this PR for now and link my JIRA in there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #17543: [SPARK-20230] FetchFailedExceptions should invali...

2017-04-05 Thread brkyvz
Github user brkyvz closed the pull request at: https://github.com/apache/spark/pull/17543 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #17543: [SPARK-20230] FetchFailedExceptions should invalidate fi...

2017-04-05 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17543 Let me try to draw a graph to better explain this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #17543: [SPARK-20230] FetchFailedExceptions should invalidate fi...

2017-04-05 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17543 Yes, your explanation is on point. If I have 4+ executors that died, then all retries of Stage B will also eventually fail. If we didn't ignore these failures, we could have re-computed the outputs

[GitHub] spark pull request #17543: [SPARK-20230] FetchFailedExceptions should invali...

2017-04-05 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17543#discussion_r110011464 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1281,10 +1281,24 @@ class DAGScheduler( val failedStage

[GitHub] spark pull request #17543: [SPARK-20230] FetchFailedExceptions should invali...

2017-04-05 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17543#discussion_r110011422 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1281,10 +1281,24 @@ class DAGScheduler( val failedStage

[GitHub] spark issue #17543: [SPARK-20230] FetchFailedExceptions should invalidate fi...

2017-04-05 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17543 cc @kayousterhout @markhamstra for feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #17543: [SPARK-20230] FetchFailedExceptions should invali...

2017-04-05 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/17543 [SPARK-20230] FetchFailedExceptions should invalidate file caches in MapOutputTracker even if newer stages are launched ## What changes were proposed in this pull request? If you lose

[GitHub] spark issue #17539: [SPARK-20224][SS] Updated docs for streaming dropDuplica...

2017-04-05 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17539 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #17539: [SPARK-20224][SS] Updated docs for streaming drop...

2017-04-05 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17539#discussion_r109960948 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -871,6 +871,65 @@ streamingDf.join(staticDf, "type", "right_join")

[GitHub] spark pull request #17539: [SPARK-20224][SS] Updated docs for streaming drop...

2017-04-05 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17539#discussion_r109959911 --- Diff: examples/src/main/java/org/apache/spark/examples/sql/streaming/JavaStructuredSessionization.java --- @@ -0,0 +1,258 @@ +/* + * Licensed

[GitHub] spark pull request #17539: [SPARK-20224][SS] Updated docs for streaming drop...

2017-04-05 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17539#discussion_r109959005 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala --- @@ -347,7 +347,7 @@ class KeyValueGroupedDataset[K, V] private[sql

[GitHub] spark issue #17525: [SPARK-20209][SS] Execute next trigger immediately if pr...

2017-04-04 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17525 Thanks for the change. It is easier to understand when things are being triggered now. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #17525: [SPARK-20209][SS] Execute next trigger immediately if pr...

2017-04-04 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17525 left one minor comment, otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17525: [SPARK-20209][SS] Execute next trigger immediatel...

2017-04-04 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17525#discussion_r109821142 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ProcessingTimeExecutorSuite.scala --- @@ -35,6 +42,56 @@ class

[GitHub] spark pull request #17525: [SPARK-20209][SS] Execute next trigger immediatel...

2017-04-04 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17525#discussion_r109726076 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/util/StreamManualClock.scala --- @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17525: [SPARK-20209][SS] Execute next trigger immediatel...

2017-04-04 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17525#discussion_r109725805 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala --- @@ -83,6 +84,6 @@ case class ProcessingTimeExecutor

[GitHub] spark pull request #17416: [SPARK-20075][CORE][WIP] Support classifier, pack...

2017-03-28 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17416#discussion_r108508229 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -941,6 +965,12 @@ private[spark] object SparkSubmitUtils { val ri

[GitHub] spark pull request #17416: [SPARK-20075][CORE][WIP] Support classifier, pack...

2017-03-28 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17416#discussion_r108507118 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -829,33 +830,56 @@ private[spark] object SparkSubmitUtils { var

[GitHub] spark issue #16541: [SPARK-19088][SQL] Optimize sequence type deserializatio...

2017-03-27 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/16541 This PR unfortunately broke Scala 2.10 compilation https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-master-compile-sbt-scala-2.10/4110/console --- If your project

[GitHub] spark issue #17444: [SPARK-19876][SS] Follow up: Refactored BatchCommitLog t...

2017-03-27 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17444 LGTM pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #17444: [SPARK-19876][SS] Follow up: Refactored BatchComm...

2017-03-27 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17444#discussion_r108299910 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/BatchCommitLog.scala --- @@ -45,28 +45,37 @@ import

[GitHub] spark pull request #17444: [SPARK-19876][SS] Follow up: Refactored BatchComm...

2017-03-27 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17444#discussion_r108299709 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/BatchCommitLog.scala --- @@ -45,28 +45,37 @@ import

[GitHub] spark issue #17250: [SPARK-19911][STREAMING] Add builder interface for Kines...

2017-03-24 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17250 Merging to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #17250: [SPARK-19911][STREAMING] Add builder interface for Kines...

2017-03-24 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17250 LGTM pending tests. Thanks a lot for this PR @budde PS It's okay to make new commits, you don't have to squash commit every time :) --- If your project is set up for it, you can reply

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-24 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107976590 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/SparkAWSCredentials.scala --- @@ -0,0 +1,179 @@ +/* + * Licensed

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-24 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107973850 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/SparkAWSCredentials.scala --- @@ -0,0 +1,179 @@ +/* + * Licensed

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-24 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107968898 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/SparkAWSCredentials.scala --- @@ -0,0 +1,175 @@ +/* + * Licensed

[GitHub] spark issue #17403: Fix compilation of the Scala 2.10 master branch

2017-03-23 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17403 Merging to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #17403: Fix compilation of the Scala 2.10 master branch

2017-03-23 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/17403 Fix compilation of the Scala 2.10 master branch ## What changes were proposed in this pull request? Fixes break caused by: https://github.com/apache/spark/commit

[GitHub] spark issue #17250: [SPARK-19911][STREAMING] Add builder interface for Kines...

2017-03-23 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17250 Thanks! new PR would be easier! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17250: [SPARK-19911][STREAMING] Add builder interface for Kines...

2017-03-23 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17250 Thanks a lot for the quick turnaround @budde ! Could you also contribute to the docs as well with the new builder API? https://spark.apache.org/docs/latest/streaming-kinesis-integration.html

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107765330 --- Diff: external/kinesis-asl/src/test/java/org/apache/spark/streaming/kinesis/JavaKinesisInputDStreamBuilderSuite.java --- @@ -0,0 +1,63

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107761278 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -22,24 +22,28 @@ import

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107747493 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -22,24 +22,28 @@ import

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107749941 --- Diff: external/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisInputDStreamBuilderSuite.scala --- @@ -0,0 +1,112

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107750493 --- Diff: external/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/SparkAWSCredentialsBuilderSuite.scala --- @@ -0,0 +1,112

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107748068 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -71,7 +75,238 @@ private[kinesis] class

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107748101 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -71,7 +75,238 @@ private[kinesis] class

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107750889 --- Diff: external/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/SparkAWSCredentialsBuilderSuite.scala --- @@ -0,0 +1,112

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107750451 --- Diff: external/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/SparkAWSCredentialsBuilderSuite.scala --- @@ -0,0 +1,112

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107749649 --- Diff: external/kinesis-asl/src/test/java/org/apache/spark/streaming/kinesis/JavaKinesisInputDStreamBuilderSuite.java --- @@ -0,0 +1,63

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107749751 --- Diff: external/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisInputDStreamBuilderSuite.scala --- @@ -0,0 +1,112

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-23 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107748154 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -71,7 +75,238 @@ private[kinesis] class

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-21 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107330754 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/SerializableCredentialsProvider.scala --- @@ -83,3 +84,146 @@ private

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-21 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107297624 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/SerializableCredentialsProvider.scala --- @@ -83,3 +84,146 @@ private

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-21 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107295179 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/SerializableCredentialsProvider.scala --- @@ -83,3 +84,146 @@ private

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-21 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107294828 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/SerializableCredentialsProvider.scala --- @@ -83,3 +84,146 @@ private

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-21 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107296097 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -71,7 +75,256 @@ private[kinesis] class

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-21 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107296962 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -71,7 +75,256 @@ private[kinesis] class

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-21 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107296327 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -71,7 +75,256 @@ private[kinesis] class

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-21 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107294998 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/SerializableCredentialsProvider.scala --- @@ -83,3 +84,146 @@ private

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-21 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107296247 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/SerializableCredentialsProvider.scala --- @@ -83,3 +84,146 @@ private

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-21 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107224819 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -71,7 +75,256 @@ private[kinesis] class

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-20 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r107003143 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -71,7 +75,256 @@ private[kinesis] class

[GitHub] spark issue #17250: [SPARK-19911][STREAMING] Add builder interface for Kines...

2017-03-18 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17250 @budde Do you think you can update this PR? The 2.2 branch will be cut on Monday (2017-03-18). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #17320: [SPARK-19967][SQL] Add from_json in FunctionRegistry

2017-03-17 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17320 LGTM2! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #17192: [SPARK-19849][SQL] Support ArrayType in to_json t...

2017-03-16 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17192#discussion_r106567525 --- Diff: python/pyspark/sql/functions.py --- @@ -1802,10 +1802,10 @@ def from_json(col, schema, options={}): @since(2.1) def to_json(col, options

[GitHub] spark pull request #17192: [SPARK-19849][SQL] Support ArrayType in to_json t...

2017-03-16 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17192#discussion_r106567845 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -37,6 +37,11 @@ private[sql] class JacksonGenerator

[GitHub] spark pull request #17192: [SPARK-19849][SQL] Support ArrayType in to_json t...

2017-03-16 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17192#discussion_r106566917 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -589,52 +591,69 @@ case class StructToJson

[GitHub] spark pull request #17192: [SPARK-19849][SQL] Support ArrayType in to_json t...

2017-03-16 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17192#discussion_r106567643 --- Diff: python/pyspark/sql/functions.py --- @@ -1802,10 +1802,10 @@ def from_json(col, schema, options={}): @since(2.1) def to_json(col, options

[GitHub] spark pull request #17192: [SPARK-19849][SQL] Support ArrayType in to_json t...

2017-03-16 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17192#discussion_r106567410 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -422,7 +422,7 @@ object FunctionRegistry

[GitHub] spark pull request #17192: [SPARK-19849][SQL] Support ArrayType in to_json t...

2017-03-16 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17192#discussion_r106567583 --- Diff: R/pkg/R/functions.R --- @@ -1795,10 +1795,10 @@ setMethod("to_date", #' to_json #' -#' Converts a column containi

[GitHub] spark issue #17250: [SPARK-19911][STREAMING] Add builder interface for Kines...

2017-03-13 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/17250 Good point @budde. I can think of two options: 1. Leave it as a constructor param 2. Make the `Builder` class non-generic and have the `build` function take the message handler

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-13 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r105796830 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisDStream.scala --- @@ -0,0 +1,559 @@ +/* + * Licensed

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-13 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r105795423 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisDStream.scala --- @@ -0,0 +1,559 @@ +/* + * Licensed

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-13 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r105792395 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisDStream.scala --- @@ -0,0 +1,559 @@ +/* + * Licensed

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-13 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r105793335 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisDStream.scala --- @@ -0,0 +1,559 @@ +/* + * Licensed

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-13 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r105791929 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisDStream.scala --- @@ -0,0 +1,559 @@ +/* + * Licensed

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-13 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r105792446 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisDStream.scala --- @@ -0,0 +1,559 @@ +/* + * Licensed

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-13 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r105792289 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisDStream.scala --- @@ -0,0 +1,559 @@ +/* + * Licensed

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-13 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r105793427 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisDStream.scala --- @@ -0,0 +1,559 @@ +/* + * Licensed

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-13 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r105791711 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisDStream.scala --- @@ -0,0 +1,559 @@ +/* + * Licensed

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-13 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r105793124 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisDStream.scala --- @@ -0,0 +1,559 @@ +/* + * Licensed

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-13 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r105795516 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala --- @@ -31,15 +31,17 @@ import

[GitHub] spark pull request #17250: [SPARK-19911][STREAMING] Add builder interface fo...

2017-03-13 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17250#discussion_r105792656 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisDStream.scala --- @@ -0,0 +1,559 @@ +/* + * Licensed

[GitHub] spark pull request #17228: [SPARK-19886] Fix reportDataLoss if statement in ...

2017-03-09 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/17228#discussion_r105313916 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala --- @@ -398,4 +386,23 @@ private[kafka010] object

[GitHub] spark pull request #17228: [SPARK-19886] Fix reportDataLoss if statement in ...

2017-03-09 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/17228 [SPARK-19886] Fix reportDataLoss if statement in SS KafkaSource ## What changes were proposed in this pull request? You can merge this pull request into a Git repository by running

<    1   2   3   4   5   6   7   8   9   10   >