Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15105
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r79158292
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -227,7 +227,7 @@ class Word2VecModel private[ml] (
*/
Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r79157601
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -227,7 +227,7 @@ class Word2VecModel private[ml] (
*/
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r79139237
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -227,7 +227,7 @@ class Word2VecModel private[ml] (
*/
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r79145091
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -563,11 +580,16 @@ class Word2VecModel private[spark] (
ind +=
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r79139615
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -518,25 +518,42 @@ class Word2VecModel private[spark] (
}
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r79006879
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -566,8 +582,8 @@ class Word2VecModel private[spark] (
Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r79005872
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -566,8 +582,8 @@ class Word2VecModel private[spark] (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r78999711
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -566,8 +582,8 @@ class Word2VecModel private[spark] (
Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r78995496
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -566,8 +582,8 @@ class Word2VecModel private[spark] (
Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r78983451
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -566,8 +582,8 @@ class Word2VecModel private[spark] (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r78982095
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -566,8 +582,8 @@ class Word2VecModel private[spark] (
Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r78981374
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/feature/Word2VecSuite.scala ---
@@ -68,6 +69,21 @@ class Word2VecSuite extends SparkFunSuite with
Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r78981066
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -566,8 +582,8 @@ class Word2VecModel private[spark] (
Github user willb commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r78973934
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -566,8 +582,8 @@ class Word2VecModel private[spark] (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r78905623
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/feature/Word2VecSuite.scala ---
@@ -68,6 +69,21 @@ class Word2VecSuite extends SparkFunSuite with
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15105#discussion_r78905531
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -566,8 +582,8 @@ class Word2VecModel private[spark] (
GitHub user willb opened a pull request:
https://github.com/apache/spark/pull/15105
[SPARK-17548] [MLlib] Word2VecModel.findSynonyms no longer spuriously
rejects the best match when invoked with a vector
## What changes were proposed in this pull request?
This pull request
18 matches
Mail list logo
