Re: Review Request 48288: Microsoft-r install script should use Ambari libraries instead of direct shell calls

2016-06-06 Thread Balázs Bence Sári
--mpack microsoft-r_mpack-1.0.0.0-SNAPSHOT.tar.gz - Restarted the Ambari Server - On the UI, chose add service and selected Microsoft R. - Install completed without errors. It had a warning due to missing service check script (covered by another Jira ticket). Thanks, Balázs Bence Sári

Review Request 48288: Microsoft-r install script should use Ambari libraries instead of direct shell calls

2016-06-06 Thread Balázs Bence Sári
- On the UI, chose add service and selected Microsoft R. - Install completed without errors. It had a warning due to missing service check script (covered by another Jira ticket). Thanks, Balázs Bence Sári

Re: Review Request 47985: Fix for AMBARI-16939, upgrade from 2.2.0 to 2.4.0 on Ubuntu 14.04 / MySQL.

2016-05-30 Thread Balázs Bence Sári
-- On May 27, 2016, 8:54 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47985/ >

Re: Review Request 47985: Fix for AMBARI-16939, upgrade from 2.2.0 to 2.4.0 on Ubuntu 14.04 / MySQL.

2016-05-30 Thread Balázs Bence Sári
, Balázs Bence Sári

Review Request 47985: Fix for AMBARI-16939, upgrade from 2.2.0 to 2.4.0 on Ubuntu 14.04 / MySQL.

2016-05-27 Thread Balázs Bence Sári
tests in ambari-server, all passed - Manually tested upgrading a 2.2.0 cluster having the old constraint names to 2.4 - Manually tested upgrading a 2.2.0 cluster having the new constraint names to 2.4 Thanks, Balázs Bence Sári

Re: Review Request 47766: Host name resolution for dfs_ha_initial_namenode_active and dfs_ha_initial_namenode_standby properties.

2016-05-24 Thread Balázs Bence Sári
, Balázs Bence Sári

Re: Review Request 47766: Host name resolution for dfs_ha_initial_namenode_active and dfs_ha_initial_namenode_standby properties.

2016-05-24 Thread Balázs Bence Sári
to check that the two properties are not exported with blueprints. - All unit tests in ambari-server passed. - Run a manual test to verify that the host names are resolved for the two properties and the two properties are not exported with blueprints. Thanks, Balázs Bence Sári

Re: Review Request 46899: Disable alternate user search functionality by default

2016-05-03 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46899/#review131486 --- Ship it! Ship It! - Balázs Bence Sári On May 2, 2016, 8:01

Re: Review Request 47170: AMBARI-16360 RM fails to start after adding services in Kerb'd cluster

2016-05-10 Thread Balázs Bence Sári
--- - Checked manually that RM starts up in order with kerberized clusters - Run java and python tests in ambari-server and ambari-agent (no failures) Thanks, Balázs Bence Sári

Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

2016-04-15 Thread Balázs Bence Sári
. creating databases and users) I only run the table/index creation part. Thanks, Balázs Bence Sári

Re: Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

2016-04-15 Thread Balázs Bence Sári
t fwk, kerberos workflow) ? - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46269/#review129118 ------- On April

Re: Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

2016-04-18 Thread Balázs Bence Sári
//github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java#L569-L581 > > We could do something similar for FKs as well. > > Balázs Bence Sári wrote: > I've got a couple of questions: > - The method in DBAccessor only w

Re: Review Request 46403: Blueprint processor does not replace "localhost" in "xasecure.audit.destination.hdfs.dir" property.

2016-04-20 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46403/#review129715 --- Ship it! Ship It! - Balázs Bence Sári On April 19, 2016, 8

Re: Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

2016-04-18 Thread Balázs Bence Sári
//github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java#L569-L581 > > We could do something similar for FKs as well. > > Balázs Bence Sári wrote: > I've got a couple of questions: > - The method in DBAccessor only w

Re: Review Request 50786: Blueprint Validation: Ranger Admin missing in Ambari Server response while POSTing clients without masters

2016-08-04 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50786/#review144739 --- Ship it! Ship It! - Balázs Bence Sári On Aug. 4, 2016, 9:55

Review Request 55818: Unknown attributes should not be allowed in quick link filter definitions

2017-01-21 Thread Balázs Bence Sári
th good and bad quick link profiles set via Ambari settings API - run the unit test suite for ambari-server. The only failing test was org.apache.ambari.server.state.ServicePropertiesTest.validatePropertySchemaOfServiceXMLs which currently fails on the trunk CI too. Thanks, Balázs Bence Sári

Re: Review Request 55818: Unknown attributes should not be allowed in quick link filter definitions

2017-01-23 Thread Balázs Bence Sári
hemaOfServiceXMLs which currently fails on the trunk CI too. Thanks, Balázs Bence Sári

Re: Review Request 56054: Inconsistent auth-to-local rules processing during Kerberos authentication

2017-01-30 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56054/#review163487 --- Ship it! Ship It! - Balázs Bence Sári On Jan. 29, 2017, 12

Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

2017-02-24 Thread Balázs Bence Sári
-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 2b1c01b ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json e1e6461 Diff: https://reviews.apache.org/r/57039/diff/ Testing --- Manually tested the fix. Thanks, Balázs Bence Sári

Re: Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

2017-02-24 Thread Balázs Bence Sári
/ Testing --- Manually tested the fix. Thanks, Balázs Bence Sári

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

2017-02-23 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56980/#review166520 --- Ship it! Ship It! - Balázs Bence Sári On Feb. 23, 2017, 12

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

2017-02-14 Thread Balázs Bence Sári
://reviews.apache.org/r/56540/diff/ Testing --- - Wrote new unit tests - Run all tests for ambari-server (all passed) - Performed manual testing Thanks, Balázs Bence Sári

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

2017-02-14 Thread Balázs Bence Sári
c. Method is deleted. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56540/#review165118 --- On Feb. 14, 2

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

2017-02-14 Thread Balázs Bence Sári
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/56540/#review165527 ------- On Feb. 14, 2017, 3:27 p.m., Balázs Bence Sári wrote: > > --- > This is an au

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

2017-02-14 Thread Balázs Bence Sári
> This is strange - why not make the DatabaseConsistencyCheckHelper do > > this exception handling/logic and call it directly instead of having yet > > another method call in AmbariServer? Separation of concerns would be > > helpful. > > Balázs Bence Sári wrote: >

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

2017-02-15 Thread Balázs Bence Sári
se logging here, not System.out.println(...) > > Balázs Bence Sári wrote: > I copied existing behavior. I think the reason why it is here that the > python script checks the standard out, so the intention is to make sure this > line appears there, irrespectively of the logging

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

2017-02-15 Thread Balázs Bence Sári
passed) - Performed manual testing Thanks, Balázs Bence Sári

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

2017-02-15 Thread Balázs Bence Sári
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56540/#review165527 ------- On Feb. 14, 2017, 3:27 p.m., Balázs Bence Sári wrote: > > -

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

2017-02-10 Thread Balázs Bence Sári
ly, visit: https://reviews.apache.org/r/56540/#review165115 ------- On Feb. 10, 2017, 12:21 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail.

Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

2017-02-10 Thread Balázs Bence Sári
) - Performed manual testing Thanks, Balázs Bence Sári

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

2017-02-10 Thread Balázs Bence Sári
is to make sure this line appears there, irrespectively of the logging config. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56540/#review165122 ------- On Feb. 10, 2017, 12:21 p.m., Balázs Bence Sári wr

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

2017-02-15 Thread Balázs Bence Sári
passed) - Performed manual testing Thanks, Balázs Bence Sári

Review Request 55643: Blueprint installation should accept quick link profile

2017-01-17 Thread Balázs Bence Sári
, quick links profile in the cluster creation template, there was an existing quick links profile which was overwritten during cluster installation -- Installing a cluster via blueprint, no quick links profile in the cluster creation template Thanks, Balázs Bence Sári

Re: Review Request 55643: Blueprint installation should accept quick link profile

2017-01-17 Thread Balázs Bence Sári
, no quick links profile in the cluster creation template Thanks, Balázs Bence Sári

Re: Review Request 55643: Blueprint installation should accept quick link profile

2017-01-18 Thread Balázs Bence Sári
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55643/#review162065 ------- On Jan. 17, 2017, 9:30 p.m., Balázs Bence Sári wrote: > > -

Re: Review Request 55643: Blueprint installation should accept quick link profile

2017-01-19 Thread Balázs Bence Sári
in the cluster creation template, there was an existing quick links profile which was overwritten during cluster installation -- Installing a cluster via blueprint, no quick links profile in the cluster creation template Thanks, Balázs Bence Sári

Re: Review Request 55643: Blueprint installation should accept quick link profile

2017-01-19 Thread Balázs Bence Sári
in the cluster creation template, there was an existing quick links profile which was overwritten during cluster installation -- Installing a cluster via blueprint, no quick links profile in the cluster creation template Thanks, Balázs Bence Sári

Review Request 55777: Update quicklink.json files in stack definitions with authenticated/sso features

2017-01-20 Thread Balázs Bence Sári
API. - Verified that attributes are respected when a quick links profile to show authenticated/sso links only is in effect Thanks, Balázs Bence Sári

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

2017-02-27 Thread Balázs Bence Sári
/serveraction/kerberos/CreateKeytabFilesServerAction.java (line 232) <https://reviews.apache.org/r/56980/#comment238947> What does the comment mean? - Balázs Bence Sári On Feb. 27, 2017, 2:14 p.m., Attila Magyar

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

2017-02-27 Thread Balázs Bence Sári
> On Feb. 27, 2017, 2:39 p.m., Balázs Bence Sári wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java, > > line 232 > > <https://reviews.apache.org/r/56980/diff/2/?file=1650134#file1650134line23

Re: Review Request 51364: Set the default 1.8 JDK to 18.0_77 for Ambari

2016-08-24 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51364/#review146644 --- Ship it! Ship It! - Balázs Bence Sári On Aug. 24, 2016, 11

Re: Review Request 51370: DB consistency check should tolerate services with no configuration

2016-08-25 Thread Balázs Bence Sári
/DatabaseConsistencyCheckHelperTest.java a7c77e1 Diff: https://reviews.apache.org/r/51370/diff/ Testing --- 1. Tested manually 2. Wrote a new unit tests 3. All unit tests in ambari-servers passed. Thanks, Balázs Bence Sári

Re: Review Request 51370: DB consistency check should tolerate services with no configuration

2016-08-25 Thread Balázs Bence Sári
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java a7c77e1 Diff: https://reviews.apache.org/r/51370/diff/ Testing --- 1. Tested manually 2. Wrote a new unit tests 3. All unit tests in ambari-servers passed. Thanks, Balázs Bence Sári

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-02 Thread Balázs Bence Sári
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review147167 ------- On Aug. 26, 2016, 9:25 a.m., Balázs Bence Sári wrote: > > --- >

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-05 Thread Balázs Bence Sári
/51238/diff/ Testing --- - Manually tested - Wrote new unit tests - All unit tests passed except two which were failing in CI builds as well. Thanks, Balázs Bence Sári

Review Request 51725: Microsoft-R client should work in a secured cluster

2016-09-08 Thread Balázs Bence Sári
Diff: https://reviews.apache.org/r/51725/diff/ Testing --- Manually tested the installation and kerberization of MSFT-R via UI and blueprints on 1-8 node clusters. Thanks, Balázs Bence Sári

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Balázs Bence Sári
ng the > > repos that are built FROM it should be sufficient. Ok. (I just thought the XML and JSON representation should change together.) - Balázs Bence ------- This is an automatically generated e-mail. To reply, visit: https://reviews.ap

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Balázs Bence Sári
- Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review147162 --- On Aug. 26, 2016, 9:25 a.m., Balázs B

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Balázs Bence Sári
r/51238/#review147170 --- On Aug. 26, 2016, 9:25 a.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51238/ > -

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Balázs Bence Sári
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review147175 ------- On Aug. 26, 2016, 9:25 a.m., Balázs Bence Sári wrote: > > ---

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Balázs Bence Sári
---------- On Aug. 26, 2016, 9:25 a.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51238/ > ---

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-08-29 Thread Balázs Bence Sári
rence" or a different indicator of where > > this repo came from. > > Jayush Luniya wrote: > RE: I was under the impression that applying an m-pack would DIRECTLY > update repoinfo.xml on the filesystem. > Personally, it would be better if we can avoid updates

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-01 Thread Balázs Bence Sári
ly, visit: https://reviews.apache.org/r/51238/#review147557 ------- On Aug. 26, 2016, 9:25 a.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 51725: Microsoft-R client should work in a secured cluster

2016-09-13 Thread Balázs Bence Sári
via UI and blueprints on 1-8 node clusters. Thanks, Balázs Bence Sári

Re: Review Request 51725: Microsoft-R client should work in a secured cluster

2016-09-13 Thread Balázs Bence Sári
-mail. To reply, visit: https://reviews.apache.org/r/51725/#review148751 --- On Sept. 13, 2016, 3:55 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-12 Thread Balázs Bence Sári
eviews.apache.org/r/51238/#review147153 --- On Sept. 5, 2016, 1:26 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-13 Thread Balázs Bence Sári
://reviews.apache.org/r/51238/diff/ Testing --- - Manually tested - Wrote new unit tests - All unit tests passed except two which were failing in CI builds as well. Thanks, Balázs Bence Sári

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-12 Thread Balázs Bence Sári
ly, visit: https://reviews.apache.org/r/51238/#review148002 ------- On Sept. 12, 2016, 8:48 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-12 Thread Balázs Bence Sári
t; > > > A management pack can have one than one custom services. For example > > for HAWQ and PXF release artifacts for both the services are in the same > > repo. > > Balázs Bence Sári wrote: > Service name is removed Also, if two services declar

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-12 Thread Balázs Bence Sári
> > > > Is it mandatory to have servicename and serviceversion when defining a > > repoinfo at service-level? If, so can we add validations for it? > > Balázs Bence Sári wrote: > How about logginng a warning and not loading the repo in this case? Del

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-12 Thread Balázs Bence Sári
-CREATION Diff: https://reviews.apache.org/r/51238/diff/ Testing --- - Manually tested - Wrote new unit tests - All unit tests passed except two which were failing in CI builds as well. Thanks, Balázs Bence Sári

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-13 Thread Balázs Bence Sári
> > Use Objects.hash(...) for easier going Fixed. - Balázs Bence --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review148053 ---------

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-13 Thread Balázs Bence Sári
://reviews.apache.org/r/51238/diff/ Testing --- - Manually tested - Wrote new unit tests - All unit tests passed except two which were failing in CI builds as well. Thanks, Balázs Bence Sári

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

2016-09-13 Thread Balázs Bence Sári
management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/microsoft_r.py > 61ea96b > > contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/51238/diff/ > > > Testing > --- > > - Manually tested > - Wrote new unit tests > - All unit tests passed except two which were failing in CI builds as well. > > > Thanks, > > Balázs Bence Sári > >

Re: Review Request 51725: Microsoft-R client should work in a secured cluster

2016-09-13 Thread Balázs Bence Sári
and kerberization of MSFT-R via UI and blueprints on 1-8 node clusters. Thanks, Balázs Bence Sári

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-15 Thread Balázs Bence Sári
-START/scripts/shared_initialization.py (line 107) <https://reviews.apache.org/r/51906/#comment216589> Do we need the has_namenode condition? - Balázs Bence Sári On Sept. 15, 2016, 11:45 a.m., Attila Doroszlai

Re: Review Request 51725: Microsoft-R client should work in a secured cluster

2016-09-09 Thread Balázs Bence Sári
8a425ca Diff: https://reviews.apache.org/r/51725/diff/ Testing --- Manually tested the installation and kerberization of MSFT-R via UI and blueprints on 1-8 node clusters. Thanks, Balázs Bence Sári

Re: Review Request 51725: Microsoft-R client should work in a secured cluster

2016-09-09 Thread Balázs Bence Sári
/51725/diff/ Testing --- Manually tested the installation and kerberization of MSFT-R via UI and blueprints on 1-8 node clusters. Thanks, Balázs Bence Sári

Review Request 52266: Ambari server does not come up after restart if cluster install fails

2016-09-26 Thread Balázs Bence Sári
/ Testing --- - Added a new unit test - All unit tests in ambari-server passed - Did manual testing to verify (removed cluster version from the DB and restarted the server) Thanks, Balázs Bence Sári

Review Request 52551: Update Mirosoft R version in mpack

2016-10-05 Thread Balázs Bence Sári
-r_mpack/src/main/resources/mpack.json 52363d1 Diff: https://reviews.apache.org/r/52551/diff/ Testing --- Manually tested installing the mpack Thanks, Balázs Bence Sári

Review Request 52630: Improve package handling in Microsoft R Server Mpack

2016-10-07 Thread Balázs Bence Sári
these scenarios: - Installing the mpack and Microsoft R - Upgrading the cluster from HDP 2.4 -> 2.5 with Microsoft R installed. Thanks, Balázs Bence Sári

Review Request 52629: Microsoft R Server management pack should support for Redhat 7

2016-10-07 Thread Balázs Bence Sári
/repoinfo.xml deb58de Diff: https://reviews.apache.org/r/52629/diff/ Testing --- Manually tested installation and kerberization on CentOS 7. Thanks, Balázs Bence Sári

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-19 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51906/#review149463 --- Ship it! Ship It! - Balázs Bence Sári On Sept. 16, 2016, 2

Re: Review Request 52038: AMBARI-18418 StackServiceDirectory debug messages are logged with placeholders

2016-09-20 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52038/#review149632 --- Ship it! Ship It! - Balázs Bence Sári On Sept. 19, 2016, 2

Re: Review Request 52123: Microsoft-R service should be supported on SLES11

2016-09-23 Thread Balázs Bence Sári
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/52123/#review150044 ------- On Sept. 22, 2016, 8:59 a.m., Balázs Bence Sári wrote: > > --- > This is an au

Re: Review Request 52123: Microsoft-R service should be supported on SLES11

2016-09-22 Thread Balázs Bence Sári
Microsoft-R on a SLES11.3 cluster via UI. - Kerberize the cluster Service check run in order in both cases. Ambari-server restart didn't cause any issues (since dummy property is missing). Thanks, Balázs Bence Sári

Review Request 51370: DB consistency check should tolerate services with no configuration

2016-08-24 Thread Balázs Bence Sári
://reviews.apache.org/r/51370/diff/ Testing --- 1. Tested manually 2. Wrote a new unit tests 3. All unit tests in ambari-servers passed. Thanks, Balázs Bence Sári

Re: Review Request 52266: Ambari server does not come up after restart if cluster install fails

2016-09-28 Thread Balázs Bence Sári
://reviews.apache.org/r/52266/diff/ Testing --- - Added a new unit test - All unit tests in ambari-server passed - Did manual testing to verify (removed cluster version from the DB and restarted the server) Thanks, Balázs Bence Sári

Re: Review Request 52266: Ambari server does not come up after restart if cluster install fails

2016-09-28 Thread Balázs Bence Sári
gt; When I tried this on my cluster that was installed failed by making a > > jar, it did not come out of the bad state. Just want to make sure the > > manual testing on this was good. > > Balázs Bence Sári wrote: > I tested it by installing the cluster, then deleting th

Re: Review Request 52264: AMBARI-18466 Component should be renamed to "Microsoft R Server Client"

2016-09-27 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52264/#review150532 --- Ship it! Ship It! - Balázs Bence Sári On Sept. 26, 2016, 6

Re: Review Request 52266: Ambari server does not come up after restart if cluster install fails

2016-09-27 Thread Balázs Bence Sári
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52266/#review150459 ------- On Sept. 26, 2016, 6:23 p.m., Balázs Bence Sári wrote: > >

Review Request 52860: Rename service to "Microsoft R Server" and component to "Microsoft R Node Client"

2016-10-14 Thread Balázs Bence Sári
ROSOFT_R/8.0.5/repos/repoinfo.xml contrib/management-packs/microsoft-r_mpack/src/main/resources/mpack.json eb7076c Diff: https://reviews.apache.org/r/52860/diff/ Testing --- Manually tested installation and kerberization. Thanks, Balázs Bence Sári

Re: Review Request 52860: Rename service to "Microsoft R Server" and component to "Microsoft R Node Client"

2016-10-18 Thread Balázs Bence Sári
eply, visit: https://reviews.apache.org/r/52860/#review153111 --- On Oct. 14, 2016, 10:07 a.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 53953: Extend current quick link JSON with properties

2016-11-22 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53953/ --- (Updated Nov. 22, 2016, 1:20 p.m.) Review request for Ambari, Attila Magyar,

Re: Review Request 53778: Oozie config not shown as stale upon changing DefaultFS

2016-11-15 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53778/#review155899 --- Ship it! Ship It! - Balázs Bence Sári On Nov. 15, 2016, 10

Re: Review Request 53228: AMBARI-18702 Fix typos

2016-10-27 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53228/#review154032 --- Ship it! Ship It! - Balázs Bence Sári On Oct. 27, 2016, 2

Re: Review Request 54252: Data model and Json parser for quick link profiles.

2016-12-16 Thread Balázs Bence Sári
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54252/#review158656 --- On Dec. 2, 2016, 2:10 p.m., Balázs Bence Sári wrote: > > ---

Re: Review Request 54252: Data model and Json parser for quick link profiles.

2016-12-16 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54252/ --- (Updated Dec. 16, 2016, 6:40 p.m.) Review request for Ambari, Attila

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Balázs Bence Sári
ce --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/#review161216 --- On Jan. 9, 2017, 3:07 p.m., Balázs Bence Sá

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Balázs Bence Sári
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/#review161258 ------- On Jan. 11, 2017, 5:27 p.m., Balázs Bence Sári wrote: > > --- > This is an au

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Balázs Bence Sári
in a subsequent run. Thanks, Balázs Bence Sári

Re: Review Request 54252: Data model and Json parser for quick link profiles.

2016-12-02 Thread Balázs Bence Sári
enerated e-mail. To reply, visit: https://reviews.apache.org/r/54252/#review157638 ------- On Dec. 1, 2016, 2:25 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 54252: Data model and Json parser for quick link profiles.

2016-12-02 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54252/ --- (Updated Dec. 2, 2016, 2:06 p.m.) Review request for Ambari, Attila Doroszlai,

Re: Review Request 54252: Data model and Json parser for quick link profiles.

2016-12-02 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54252/ --- (Updated Dec. 2, 2016, 2:10 p.m.) Review request for Ambari, Attila Doroszlai,

Re: Review Request 54252: Data model and Json parser for quick link profiles.

2016-12-01 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54252/ --- (Updated Dec. 1, 2016, 2:25 p.m.) Review request for Ambari, Attila Doroszlai,

Re: Review Request 53953: Extend current quick link JSON with properties

2016-11-30 Thread Balázs Bence Sári
-------- On Nov. 22, 2016, 1:20 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53953/ > -

Re: Review Request 54252: Data model and Json parser for quick link profiles.

2016-12-01 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54252/ --- (Updated Dec. 1, 2016, 11:15 a.m.) Review request for Ambari, Attila

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-09 Thread Balázs Bence Sári
testing 2. Wrote new unit tests 3. Run the ambari-server unit test suite. Only KerberosServiceMetaInfoTest failed, but it succeeded in a subsequent run. Thanks, Balázs Bence Sári

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-09 Thread Balázs Bence Sári
testing 2. Wrote new unit tests 3. Run the ambari-server unit test suite. Only KerberosServiceMetaInfoTest failed, but it succeeded in a subsequent run. Thanks, Balázs Bence Sári

Review Request 54891: Create quick links profile evaluator

2016-12-20 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54891/ --- Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, Sandor

  1   2   >