Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-06-03 Thread Dmytro Sen
2fbb1e1 ambari-server/pom.xml 20d3fab Diff: https://reviews.apache.org/r/47730/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-06-03 Thread Dmytro Sen
sink/relocated/google/common/annotations/VisibleForTesting.class - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47730/#review136064 ----------- On Июнь 3, 2016, 1:54 п.п., Dmytro Sen wrote: > > -

Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-09 Thread Dmytro Sen
ad8d4f9 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 9ec0a09 Diff: https://reviews.apache.org/r/48494/diff/ Testing --- Unit tests and manual tests passed Thanks, Dmytro Sen

Re: Review Request 48321: Ambari server failed to start METRICS_COLLECTOR via BP

2016-06-07 Thread Dmytro Sen
/BlueprintConfigurationProcessorTest.java 8b1a9a6 Diff: https://reviews.apache.org/r/48321/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Review Request 48321: Ambari server failed to start METRICS_COLLECTOR via BP

2016-06-07 Thread Dmytro Sen
://reviews.apache.org/r/48321/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Review Request 48402: ATS needs a dynamic dependency on Tez and Spark

2016-06-08 Thread Dmytro Sen
c6ee13d Diff: https://reviews.apache.org/r/48402/diff/ Testing --- Unit tests passed. Thanks, Dmytro Sen

Re: Review Request 48262: AMBARI-16852: Update metrics collector pom.xml to use httpclient-4.2.5.jar

2016-06-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48262/#review136288 --- Ship it! Ship It! - Dmytro Sen On Июнь 6, 2016, 6:26 д.п

Re: Review Request 48262: AMBARI-16852: Update metrics collector pom.xml to use httpclient-4.2.5.jar

2016-06-06 Thread Dmytro Sen
> On Июнь 6, 2016, 4:32 п.п., Dmytro Sen wrote: > > Ship It! Committed to trunk and branch-2.4. Please close this review board - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 48283: Namenode failed to start while installing a cluster from UI

2016-06-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48283/#review136274 --- Ship it! Ship It! - Dmytro Sen On Июнь 6, 2016, 3:31 п.п

Re: Review Request 48282: YARN service check fails if there is no queue named "default"

2016-06-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48282/#review136282 --- Ship it! Ship It! - Dmytro Sen On Июнь 6, 2016, 3:18 п.п

Re: Review Request 48508: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents HBase RS process shutdown

2016-06-10 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48508/#review136973 --- Ship it! Ship It! - Dmytro Sen On Июнь 10, 2016, полночь

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-10 Thread Dmytro Sen
> > > > Please consider cyclomatic complexity in this method. > > Dmytro Sen wrote: > What is wrong with it ? The loop body is executed only once for every > property. > Moreover, this method is executed only once during ambari server > lifecycle, w

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-09 Thread Dmytro Sen
the server is least loaded. - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48494/#review136823 ------- On Ию

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-09 Thread Dmytro Sen
y generated e-mail. To reply, visit: https://reviews.apache.org/r/48494/#review136832 ----------- On Июнь 9, 2016, 3:23 п.п., Dmytro Sen wrote: > > --- > This is an automatically

Re: Review Request 48121: YARN default configs are invalid

2016-06-03 Thread Dmytro Sen
ation/yarn-site.xml 9777ee4 ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/YARN/configuration/yarn-site.xml c8a588c Diff: https://reviews.apache.org/r/48121/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 48121: YARN default configs are invalid

2016-06-03 Thread Dmytro Sen
962 ------- On Июнь 3, 2016, 10:43 д.п., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48121/ > ---

Re: Review Request 47856: AMBARI-16887 : [AMS / Grafana] Metrics are staying flat for 1 minutes, causing rate calculations to be 0

2016-05-26 Thread Dmytro Sen
um_ops ? - Dmytro Sen On Май 25, 2016, 10:04 п.п., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 47879: AMBARI-16807: After enabling HTTPS for HDFS, Data Node JVM Metrics on HDFS Heatmaps show NA

2016-05-26 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47879/#review134989 --- Ship it! Ship It! - Dmytro Sen On Май 26, 2016, 10:27 д.п

Review Request 48555: Kerberization of a cluster deletes ATS service

2016-06-10 Thread Dmytro Sen
/services/YARN/metainfo.xml 2c3afb0 Diff: https://reviews.apache.org/r/48555/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 48641: yarncli throws log4j error "FileNotFoundException : /grid/0/log/yarn/hrt_qa/rm-audit.log"

2016-06-13 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48641/#review137305 --- Ship it! Ship It! - Dmytro Sen On Июнь 13, 2016, 2:31 п.п

Re: Review Request 48654: Upgrading Ambari Causes Alert Fields Not To Save Thresholds

2016-06-14 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48654/#review137478 --- Ship it! Ship It! - Dmytro Sen On Июнь 14, 2016, 10:41 д.п

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-14 Thread Dmytro Sen
/BlueprintConfigurationProcessorTest.java cda8fb8 Diff: https://reviews.apache.org/r/48494/diff/ Testing --- Unit tests and manual tests passed Thanks, Dmytro Sen

Re: Review Request 48706: 'ambari-server --version' command does not show build number

2016-06-15 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48706/#review137693 --- Ship it! Ship It! - Dmytro Sen On Июнь 15, 2016, 8:43 д.п

Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-15 Thread Dmytro Sen
Thanks, Dmytro Sen

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-06-03 Thread Dmytro Sen
-server/pom.xml 20d3fab Diff: https://reviews.apache.org/r/47730/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-05-31 Thread Dmytro Sen
://reviews.apache.org/r/47730/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Review Request 48079: Capture user based metrics for Namenode fair call queue.

2016-05-31 Thread Dmytro Sen
--- Unit tests passed. + Manual testing Thanks, Dmytro Sen

Re: Review Request 48079: Capture user based metrics for Namenode fair call queue.

2016-05-31 Thread Dmytro Sen
] [INFO] BUILD SUCCESS Thanks, Dmytro Sen

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-05-27 Thread Dmytro Sen
/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 47953: Add ability to query all hosts using hostname=% through AMS API.

2016-05-27 Thread Dmytro Sen
SUCCESS [02:47 min] [INFO] [INFO] BUILD SUCCESS Thanks, Dmytro Sen

Review Request 47953: Add ability to query all hosts using hostname=% through AMS API.

2016-05-27 Thread Dmytro Sen
://reviews.apache.org/r/47953/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 47856: AMBARI-16887 : [AMS / Grafana] Metrics are staying flat for 1 minutes, causing rate calculations to be 0

2016-05-27 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47856/#review135195 --- Ship it! Ship It! - Dmytro Sen On Май 26, 2016, 7:16 п.п

Re: Review Request 47879: AMBARI-16807: After enabling HTTPS for HDFS, Data Node JVM Metrics on HDFS Heatmaps show NA

2016-06-02 Thread Dmytro Sen
> On Май 26, 2016, 3:11 п.п., Dmytro Sen wrote: > > Ship It! > > Qin Liu wrote: > Thank you so much Dmytro! > > Qin Liu wrote: > Hi Sid, > Could you please review the patch at your earliest convenience? Thank you > in advance! > > Qin

Re: Review Request 48139: Required empty config is present after Upgrade from 2.1.2.1 to 2.4.0.0 for HIVE and HBASE

2016-06-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48139/#review135828 --- Ship it! Ship It! - Dmytro Sen On Июнь 1, 2016, 6:06 п.п

Re: Review Request 48087: AMBARI-16969 : Provide ability in AMS to filter tracked metrics through a whitelist metic file.

2016-06-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48087/#review135772 --- Ship it! Ship It! - Dmytro Sen On Май 31, 2016, 7:25 п.п

Review Request 48121: YARN default configs are invalid

2016-06-01 Thread Dmytro Sen
fd2 Diff: https://reviews.apache.org/r/48121/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 48121: YARN default configs are invalid

2016-06-01 Thread Dmytro Sen
r/internal/BlueprintConfigurationProcessorTest.java ec04fd2 Diff: https://reviews.apache.org/r/48121/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-05-31 Thread Dmytro Sen
-server/pom.xml 20d3fab Diff: https://reviews.apache.org/r/47730/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-15 Thread Dmytro Sen
/BlueprintConfigurationProcessorTest.java cda8fb8 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackTest.java e70af3e Diff: https://reviews.apache.org/r/48494/diff/ Testing --- Unit tests and manual tests passed Thanks, Dmytro Sen

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-15 Thread Dmytro Sen
/BlueprintConfigurationProcessorTest.java cda8fb8 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackTest.java e70af3e Diff: https://reviews.apache.org/r/48494/diff/ Testing --- Unit tests and manual tests passed Thanks, Dmytro Sen

Re: Review Request 48985: AMBARI-17325 : Ambari Metrics service check failed exceed timeout due to invalid Phoenix JARS

2016-06-21 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48985/#review138803 --- Ship it! Ship It! - Dmytro Sen On Июнь 21, 2016, 1:41 д.п

Re: Review Request 49018: Downloading sqoop client files throws error

2016-06-21 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49018/#review138810 --- Ship it! Ship It! - Dmytro Sen On Июнь 21, 2016, 9:55 д.п

Re: Review Request 48985: AMBARI-17325 : Ambari Metrics service check failed exceed timeout due to invalid Phoenix JARS

2016-06-21 Thread Dmytro Sen
> On Июнь 21, 2016, 8:44 д.п., Dmytro Sen wrote: > > Ship It! committed to trunk and branch-2.4 - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48985/#rev

Re: Review Request 49080: Tez install failed

2016-06-22 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49080/#review139052 --- Ship it! Ship It! - Dmytro Sen On Июнь 22, 2016, 11:12 д.п

Review Request 49030: Ambari agent log contains failures for AMS status commands

2016-06-21 Thread Dmytro Sen
- [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 1:08.949s [INFO] Finished at: Tue Jun 21 18:52:10 EEST 2016 [INFO] Final Memory: 70M/948M Thanks, Dmytro Sen

Re: Review Request 49032: Hive metastore failed to start

2016-06-21 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49032/#review138866 --- Ship it! Ship It! - Dmytro Sen On Июнь 21, 2016, 4:28 п.п

Re: Review Request 47730: Improve TimelineMetricsCache eviction/flush logic using a cache library

2016-06-21 Thread Dmytro Sen
of 2.4.0. - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47730/#review136067 --- On Июнь 3, 2016, 3:15 п

Review Request 49142: Performance issues with ambari metrics (and Metrics Collector keeps going down)

2016-06-23 Thread Dmytro Sen
/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 49153: RU/EU Install packages fails on non-root

2016-06-23 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49153/#review139252 --- Ship it! Ship It! - Dmytro Sen On Июнь 23, 2016, 1:56 п.п

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48729/#review137985 ------- On Июнь 15, 2016, 1:35 п.п., Dmytro Sen wrote: > > ---

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Dmytro Sen
uld have some way to check if this property was set in the > > Blueprint, or is relying on the stack defaults. > > > > I realize that this change is not really a part of this current patch, > > but this looks like something that needs some investigation, and

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Dmytro Sen
8729/#review137985 --- On Июнь 15, 2016, 1:35 п.п., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apac

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Dmytro Sen
uld have some way to check if this property was set in the > > Blueprint, or is relying on the stack defaults. > > > > I realize that this change is not really a part of this current patch, > > but this looks like something that needs some investigation, and

Review Request 49199: Falcon client install failed

2016-06-24 Thread Dmytro Sen
/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py 2bdaa48 ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/configuration/falcon-client.properties.xml PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/metainfo.xml 2e444b1 ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/params.py 41ecafa Diff: https://reviews.apache.org/r/49199/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 49205: Fix serviceconfig NPE in db consistency checker

2016-06-24 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49205/#review139380 --- Ship it! Ship It! - Dmytro Sen On Июнь 24, 2016, 4:32 п.п

Review Request 48858: Ambari Metrics service check failed exceed timeout

2016-06-17 Thread Dmytro Sen
/ Diffs - ambari-metrics/ambari-metrics-timelineservice/pom.xml 2fefede Diff: https://reviews.apache.org/r/48858/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 44174: Ambari overwrites permissions on HDFS directories

2016-03-10 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44174/#review122910 --- Ship it! Ship It! - Dmytro Sen On Март 10, 2016, 10:46 д.п

Re: Review Request 44792: AMS fails to start with TTL for column family 0 must be positive after upgrade

2016-03-14 Thread Dmytro Sen
) --- Unit tests passed Tested end-to-end Thanks, Dmytro Sen

Re: Review Request 44792: AMS fails to start with TTL for column family 0 must be positive after upgrade

2016-03-14 Thread Dmytro Sen
----- On Март 14, 2016, 5:25 п.п., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44792/ > ---

Re: Review Request 44807: Ambari2400:Ambari server start fails with Required properties are not found: ['jdk.name', 'jce.name']

2016-03-14 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44807/#review123508 --- Ship it! Ship It! - Dmytro Sen On Март 14, 2016, 8:52 п.п

Review Request 44847: Ambari upgrade/start commands should detect any ambari-server hotfix and fail upgrade/start from proceeding

2016-03-15 Thread Dmytro Sen
Testing --- -- Ran 257 tests in 8.222s OK -- Total run:926 Total errors:0 Total failures:0 OK Thanks, Dmytro Sen

Review Request 44567: Ambari upgrade/start commands should detect any ambari-server hotfix and fail upgrade/start from proceeding

2016-03-09 Thread Dmytro Sen
9.077s OK -- Total run:939 Total errors:0 Total failures:0 OK Thanks, Dmytro Sen

Re: Review Request 44962: file_system get_mount_point_for_dir works incorrect

2016-03-19 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44962/#review124045 --- Ship it! Ship It! - Dmytro Sen On Март 17, 2016, 4:03 п.п

Re: Review Request 45739: Create script to export AMS metrics and re-import into AMS to visualize using Grafana

2016-04-05 Thread Dmytro Sen
(line 58) <https://reviews.apache.org/r/45739/#comment190239> Can be https:// - Dmytro Sen On Апрель 5, 2016, 11:09 д.п., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-07 Thread Dmytro Sen
/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py 038592f ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 10b92d4 Diff: https://reviews.apache.org/r/45873/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 45739: Create script to export AMS metrics and re-import into AMS to visualize using Grafana

2016-04-05 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45739/#review127114 --- Ship it! Ship It! - Dmytro Sen On Апрель 5, 2016, 11:09 д.п

Re: Review Request 45833: Webhcat Server failed to stop while stopping all the services

2016-04-07 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45833/#review127570 --- Ship it! Ship It! - Dmytro Sen On Апрель 6, 2016, 8:21 п.п

Re: Review Request 45845: AMBARI-15694 : AMS returns truncated results when it exceeds the metrics service default result limit config

2016-04-07 Thread Dmytro Sen
before commit - Dmytro Sen On Апрель 6, 2016, 11:39 п.п., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-11 Thread Dmytro Sen
f a first class citizen? I'll fix this. - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45873/#review127769 ---------

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-11 Thread Dmytro Sen
sit: https://reviews.apache.org/r/45873/#review127769 --- On Апрель 7, 2016, 3:24 п.п., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-11 Thread Dmytro Sen
--- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-11 Thread Dmytro Sen
S, is there a better place to get this > > information from, like the AMS configurations? > > Sid Wagle wrote: > +1 Ambari server already has the cached location and port for > collector(s), is there way to make that more of a first class citizen? > > Dmytro Sen wrote: >

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Dmytro Sen
Should we initialize if Storm/Kafka are not deployed? What happens when > > Add Service is called later. > > Dmytro Sen wrote: > I handle it inside initializeStromAnsKafkaWidgets() > > if ("STORM".equals(service.getName()) || > "KAFKA".equals(servi

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Dmytro Sen
StormAns -> StormAnd fixed - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45930/#review127802 ------- On А

Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Dmytro Sen
va/org/apache/ambari/server/upgrade/UpgradeCatalog222.java 77b8b45 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java 5f07e56 Diff: https://reviews.apache.org/r/45930/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Dmytro Sen
passed Thanks, Dmytro Sen

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Dmytro Sen
oller.initializeWidgetsAndLayouts(cluster, service); } - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45930/#review127802 -----------

Re: Review Request 45980: If initial NN start runs into problem while communicating with JN, restart does not work

2016-04-09 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45980/#review127973 --- Ship it! Ship It! - Dmytro Sen On Апрель 9, 2016, 12:34 п.п

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-11 Thread Dmytro Sen
tion for checking any component metrics. - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45873/#review127697 --- On Апрель 7, 2016,

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-11 Thread Dmytro Sen
.apache.org/r/45873/#review127697 --- On Апрель 7, 2016, 3:24 п.п., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45873/ >

Review Request 46018: HDFS script alerts moved to UNKNOWN status with "Unable to calculate the standard deviation for 1 datapoints"

2016-04-11 Thread Dmytro Sen
tests in 9.376s OK -- Total run:956 Total errors:0 Total failures:0 OK Thanks, Dmytro Sen

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

2016-04-11 Thread Dmytro Sen
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45873/#review127769 ----------- On Апрель 7, 2016, 3:24 п.п., Dmytro Sen wrote: > >

Review Request 46076: Enable HDFS alerts based on AMS metrics by default.

2016-04-12 Thread Dmytro Sen
-- Total run:944 Total errors:0 Total failures:0 OK Thanks, Dmytro Sen

Re: Review Request 46079: Build and Test SLES 12 Ambari with SLES 12 HDP builds.

2016-04-12 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46079/#review128364 --- Ship it! Ship It! - Dmytro Sen On Апрель 12, 2016, 9:39 д.п

Re: Review Request 46095: On debian7 UI shows 'os not supported' in processor info

2016-04-12 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46095/#review128406 --- Ship it! Ship It! - Dmytro Sen On Апрель 12, 2016, 2:21 п.п

Re: Review Request 46099: testUpdateRepoUrlController unit test fails

2016-04-12 Thread Dmytro Sen
Thanks, Dmytro Sen

Re: Review Request 46006: Ambari install failing in RHEL7 while trying to install ATS

2016-04-11 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46006/#review128087 --- Ship it! Ship It! - Dmytro Sen On Апрель 11, 2016, 9:04 д.п

Re: Review Request 45374: Use ">>" instead of ">" to write ambari-metrics-collector.out

2016-04-06 Thread Dmytro Sen
ws.apache.org/r/45374/ > --- > > (Updated Март 30, 2016, 2:02 д.п.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle. > > > Bugs: AMBARI-15588 > https://issues.apache.org/jira/browse/AMBARI-1

Re: Review Request 46037: AMBARI-15698 : Metrics is not showing data

2016-04-11 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46037/#review128172 --- Ship it! Ship It! - Dmytro Sen On Апрель 11, 2016, 4:57 п.п

Re: Review Request 44859: Cannot specify ZooKeeper heap size via UI

2016-03-19 Thread Dmytro Sen
/3.4.5.2.0/package/scripts/params_linux.py (line 68) <https://reviews.apache.org/r/44859/#comment186368> default 1024m instead of 1024 ? - Dmytro Sen On Март 17, 2016, 1:22 п.п., Vitalyi Brodetskyi wrote: > > --- > This is a

Review Request 45030: Replace 0.0.0.0 with hostname in ams-site/timeline.metrics.service.webapp.address

2016-03-19 Thread Dmytro Sen
-upgrade.json a7057db ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 390f9ce ambari-server/src/test/python/stacks/2.3/configs/ats_1_5.json 3fe1235 Diff: https://reviews.apache.org/r/45030/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 45030: Replace 0.0.0.0 with hostname in ams-site/timeline.metrics.service.webapp.address

2016-03-19 Thread Dmytro Sen
ps://reviews.apache.org/r/45030/#review124198 ----------- On Март 18, 2016, 3:33 п.п., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 44955: Yarn start is failed (YARN Client Install) after upgrade from 1.7.0 to 2.2.2.0

2016-03-19 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44955/#review124005 --- Ship it! Ship It! - Dmytro Sen On Март 17, 2016, 12:37 п.п

Re: Review Request 45680: Ambari should verify JAVA_HOME Consistency

2016-04-04 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45680/#review126827 --- Ship it! Ship It! - Dmytro Sen On Апрель 4, 2016, 2:25 п.п

Re: Review Request 45736: "Wrong metrics path " exceptions for JMX metrics

2016-04-05 Thread Dmytro Sen
tests passed Thanks, Dmytro Sen

Review Request 45736: "Wrong metrics path " exceptions for JMX metrics

2016-04-05 Thread Dmytro Sen
/ambari/server/api/services/AmbariMetaInfoTest.java 2730463 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java cc4bd54 Diff: https://reviews.apache.org/r/45736/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 45735: Dev Deploy: Unexpected error, database check failed

2016-04-05 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45735/#review127073 --- Ship it! Ship It! - Dmytro Sen On Апрель 5, 2016, 9:27 д.п

Re: Review Request 45374: Use ">>" instead of ">" to write ambari-metrics-collector.out

2016-03-30 Thread Dmytro Sen
- Dmytro Sen On Март 30, 2016, 2:02 д.п., Akira Ajisaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 45518: AMBARI-15638 : AMS Sum Calculation Incorrect

2016-03-31 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45518/#review126321 --- Ship it! Ship It! - Dmytro Sen On Март 31, 2016, 1:36 д.п

Review Request 45395: Ambari API does not return HDFS RPC metrics based on ports

2016-03-28 Thread Dmytro Sen
in/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java b883d2b ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java 41da279 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py b0e2e7a ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java 35ba605 ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/PropertyHelperTest.java 2beb462 Diff: https://reviews.apache.org/r/45395/diff/ Testing --- Unit tests passed Thanks, Dmytro Sen

  1   2   3   4   5   >