Re: Review Request 48178: AMBARI-17017. Fixing open issues for 'Hive Server Interactive' in Kerberized environment. / AMBARI-17020. Use 'llapstatus' comand after starting llap to check its status befo

2016-06-02 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48178/#review136007 --- Ship it! Ship It! - Sumit Mohanty On June 2, 2016, 10:32

Re: Review Request 48301: AMBARI-17075. Set 'hive.server2.tez.default.queues' config value to be the one used by config hive.llap.daemon.queue.name for 'llap' app.

2016-06-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48301/#review136394 --- Ship it! Ship It! - Sumit Mohanty On June 7, 2016, 12:24

Re: Review Request 48403: Fixed implementation of on-ambari-upgrade support. Patch 1 - change validation rules and available fields

2016-06-09 Thread Sumit Mohanty
- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48403/ > --- > > (Updated June 9, 2016, 1:12 p.m.) > > > Review request for Ambari, Alejandro Fernandez,

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Sumit Mohanty
> On June 3, 2016, 8:15 p.m., Alejandro Fernandez wrote: > > ambari-agent/src/main/python/ambari_agent/Controller.py, line 290 > > > > > > Restarting is dangerous to do, especially if it happens during > >

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Sumit Mohanty
tps://reviews.apache.org/r/48207/#comment201300> Whats the default behavior - looks like by default it should be disabled. What is the memory consumption for an agent instance that is not leaking - assuming 20+ master/slave components on the host. - Sumit Mohanty On June 6, 2016, 4:

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48207/#review136291 --- Ship it! Ship It! - Sumit Mohanty On June 6, 2016, 4:29 p.m

Re: Review Request 48590: AMBARI-17179. Allow 'LLAP related calculations' to be done for any selected queue instead of existing for only 'llap' named queue.

2016-06-12 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48590/#review137228 --- Ship it! Ship It! - Sumit Mohanty On June 12, 2016, 10:57

Re: Review Request 48553: Blueprint processor should handle manual stack definition changes without failing deployment

2016-06-10 Thread Sumit Mohanty
. As the config it self is an excluded config it shoudl be ok to ignore that it is not associated with any service type. - Sumit Mohanty On June 10, 2016, 7:09 p.m., Robert Nettleton wrote: > > --- > This is an automatically generat

Re: Review Request 48526: AMBARI-17156: Ambari Agent: TestActionQueue and TestRecoveryManager python unit tests failures

2016-06-09 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48526/#review136939 --- Ship it! Ship It! - Sumit Mohanty On June 10, 2016, 12:13

Re: Review Request 48508: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents HBase RS process shutdown

2016-06-09 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48508/#review136904 --- Ship it! Ship It! - Sumit Mohanty On June 9, 2016, 8:40 p.m

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-02 Thread Sumit Mohanty
June 2, 2016, 12:55 p.m., Laszlo Puskas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48044/ > --- > > (Updated June 2, 2016, 12:55 p.m.) > > > Review request for Ambari, Ol

Re: Review Request 47773: one very careless mistake for ambari agent cancel logic

2016-05-24 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47773/#review134694 --- Ship it! Ship It! - Sumit Mohanty On May 25, 2016, 2:18 a.m

Re: Review Request 47996: AMBARI-16942. Take into account reading 'hive.tez.container.size', 'yarn.scheduler.minimum-allocation-mb', 'yarn.nodemanager.resource.memory-mb' & 'tez.am.resource.memory.mb'

2016-05-27 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47996/#review135365 --- Ship it! Ship It! - Sumit Mohanty On May 27, 2016, 11:43

Re: Review Request 48555: Kerberization of a cluster deletes ATS service

2016-06-10 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48555/#review137003 --- Ship it! Ship It! - Sumit Mohanty On June 10, 2016, 2:51

Re: Review Request 48670: Return well formatted error response while deleting host with clients installed.

2016-06-14 Thread Sumit Mohanty
delete fail if any host component exist - allow a bulk delete of host components - Sumit Mohanty On June 14, 2016, 12:29 a.m., Ajit Kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 48706: 'ambari-server --version' command does not show build number

2016-06-14 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48706/#review137654 --- Ship it! Ship It! - Sumit Mohanty On June 14, 2016, 7:41

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Sumit Mohanty
> > (Updated June 15, 2016, 2:55 p.m.) > > > Review request for Ambari, Andrew Onischuk, Laszlo Puskas, Robert Levas, > Sandor Magyari, and Sumit Mohanty. > > > Bugs: AMBARI-17248 > https://issues.apache.org/jira/browse/AMBARI-17248 > >

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-13 Thread Sumit Mohanty
and process that rather than Heartbeat processing completed? - Sumit Mohanty On June 11, 2016, 6:43 a.m., Daniel Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 48308: [AMBARI-17078] Make Spark2-ThriftServer and Livy Server as optional by default

2016-06-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48308/#review137449 --- Ship it! Ship It! - Sumit Mohanty On June 14, 2016, 4:10

Re: Review Request 48308: [AMBARI-17078] Make Spark2-ThriftServer and Livy Server as optional by default

2016-06-13 Thread Sumit Mohanty
/stack_advisor.py (line 910) <https://reviews.apache.org/r/48308/#comment202581> The new components should be in HDP/2.5 stack advisor as they are added in that version. - Sumit Mohanty On June 7, 2016, 2:59 a.m., Jeff Zhang

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-05-30 Thread Sumit Mohanty
/functions/hdp_select.py (line 129) <https://reviews.apache.org/r/48044/#comment200593> We should also add the following commands: ls -la /usr/hdp/current hdp-select - Sumit Mohanty On May 30, 2016, 2:34 p.m., Laszlo Puskas

Re: Review Request 47815: Handle the scenario when 'capacity-scheduler' configs is passed in as dictionary to Stack Advisor (generally on 1st invocation) in order to create 'llap' queue for Hive Serve

2016-05-25 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47815/#review134883 --- Ship it! Ship It! - Sumit Mohanty On May 25, 2016, 11:01

Re: Review Request 47949: AMBARI-16923. Fix for getting the 'hive.llap.daemon.queue.name' config Property Attributes updated if there is a change in 'capacity-scheduler'.

2016-05-27 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47949/#review135263 --- Ship it! Ship It! - Sumit Mohanty On May 27, 2016, 4:39 p.m

Re: Review Request 47939: AMBARI-16919. Handle the scenario when 'capacity-scheduler' is passed-in as dictionary to Stack Advisor and services['configurations'][capacity-scheduler][properties][capacit

2016-05-26 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47939/#review135142 --- Ship it! Ship It! - Sumit Mohanty On May 27, 2016, 2:03 a.m

Re: Review Request 47914: AMBARI-16910. Hive Server Interactive. Change the timeout to 120 secs for LLAP alert command.

2016-05-26 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47914/#review135141 --- Ship it! Ship It! - Sumit Mohanty On May 27, 2016, 12:49

Re: Review Request 47882: HBase backups fail if there is no /user/hbase directory in HDFS

2016-05-26 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47882/#review134971 --- Ship it! Ship It! - Sumit Mohanty On May 26, 2016, 12:19

Review Request 48081: Prefix command execution log lines in agent log

2016-05-31 Thread Sumit Mohanty
-qa Thanks, Sumit Mohanty

Re: Review Request 48697: AMBARI-17229. Add config 'tez.lib.uris' in tez_hive2/tez-site's pointing to tez_hive2 path jar.

2016-06-14 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48697/#review137615 --- Ship it! Ship It! - Sumit Mohanty On June 14, 2016, 11:12

Re: Review Request 49014: AMBARI-17331. Determine Tez for Hive2 config 'tez.am.resource.memory.mb' based on cluster capacity.

2016-06-21 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49014/#review138833 --- Ship it! Ship It! - Sumit Mohanty On June 21, 2016, 9:25

Re: Review Request 49014: AMBARI-17331. Determine Tez for Hive2 config 'tez.am.resource.memory.mb' based on cluster capacity.

2016-06-21 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49014/#review138915 --- Ship it! Ship It! - Sumit Mohanty On June 21, 2016, 7:10

Re: Review Request 48894: AMBARI-17306. Filter out Message Of The Day (MOTD) logging from 'llapstatus' command in order to get the output which is JSON parsable.

2016-06-18 Thread Sumit Mohanty
/package/alerts/alert_llap_app_status.py (line 231) <https://reviews.apache.org/r/48894/#comment203610> Any way for alerts to share methods with rest of the python scripts? - Sumit Mohanty On June 18, 2016, 2:05 a.m., Swapan Shridhar

Re: Review Request 48894: AMBARI-17306. Filter out Message Of The Day (MOTD) logging from 'llapstatus' command in order to get the output which is JSON parsable.

2016-06-18 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48894/#review138438 --- Ship it! Ship It! - Sumit Mohanty On June 18, 2016, 2:05

Re: Review Request 49114: AMBARI-17384. Remove '/usr/hdp' hardcoding from HIVE's alert_llap_app_status.py and KNOX's upgrade.py

2016-06-22 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49114/#review139162 --- Ship it! Ship It! - Sumit Mohanty On June 22, 2016, 10:51

Re: Review Request 49128: AMBARI-17389. Read 'yarn.nodemanager.resource.memory-mb' and 'yarn.scheduler.minimum-allocation-mb' from 'configurations' if 'changed-configurations' is empty and config is t

2016-06-22 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49128/#review139206 --- Ship it! Ship It! - Sumit Mohanty On June 23, 2016, 2:28

Re: Review Request 49134: Add llap-*log4j config dependency for hive server interactive component

2016-06-23 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49134/#review139255 --- Ship it! Ship It! - Sumit Mohanty On June 23, 2016, 6:18

Re: Review Request 48894: AMBARI-17306. Filter out Message Of The Day (MOTD) logging from 'llapstatus' command in order to get the output which is JSON parsable.

2016-06-20 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48894/#review138717 --- Ship it! Ship It! - Sumit Mohanty On June 21, 2016, 12:24

Re: Review Request 48985: AMBARI-17325 : Ambari Metrics service check failed exceed timeout due to invalid Phoenix JARS

2016-06-20 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48985/#review138775 --- Ship it! Ship It! - Sumit Mohanty On June 21, 2016, 1:41

Re: Review Request 48729: AMS collector not coming up in 2.5 cluster blueprint deployment

2016-06-16 Thread Sumit Mohanty
29/#review137985 --- On June 15, 2016, 1:35 p.m., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48729/ > ---------

Re: Review Request 48712: AMBARI-17263. Fix for following for Hive Server Interactive : (1). Updates to 'llapstatus' command while querying LLAP app status. (2). Adding validation check for config 'hi

2016-06-15 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48712/#review137829 --- Ship it! Ship It! - Sumit Mohanty On June 15, 2016, 6:47

Re: Review Request 49179: AMBARI-17418. Fix for LLAP calculation to happen on invocation by Blueprints and HIVE SERVER INTERACTIVE is ON (1st invocation to Stack Advisor). Also, reverts AMBARI-17283.

2016-06-23 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49179/#review139336 --- Ship it! Ship It! - Sumit Mohanty On June 24, 2016, 5 a.m

Re: Review Request 49179: AMBARI-17418. Fix for LLAP calculation to happen on invocation by Blueprints and HIVE SERVER INTERACTIVE is ON (1st invocation to Stack Advisor). Also, reverts AMBARI-17283.

2016-06-24 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49179/#review139346 --- Ship it! Ship It! - Sumit Mohanty On June 24, 2016, 6:14

Re: Review Request 49119: AMBARI-17383: User names should be case insensitive

2016-06-23 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49119/#review139331 --- Ship it! Ship It! - Sumit Mohanty On June 24, 2016, 3:19

Re: Review Request 49260: Update desired states in case of service restarts

2016-06-27 Thread Sumit Mohanty
460) <https://reviews.apache.org/r/49260/#comment204828> This may be fine but is it needed? Service component state generally refers to all host components associated with the component. - Sumit Mohanty On June 27, 2016, 12:42 p.m., L

Re: Review Request 49220: AMBARI-17434. Keep empty value for Hive2/hive-interactive-site.xml config 'hive.llap.io.memory.mode'.

2016-06-24 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49220/#review139421 --- Ship it! Ship It! - Sumit Mohanty On June 24, 2016, 11:45

Review Request 49241: Allow commands to specify if they should be auto-retried upon failure

2016-06-26 Thread Sumit Mohanty
unit tests and test runs through hadoop-qa in the JIRA (https://issues.apache.org/jira/browse/AMBARI-17443). Thanks, Sumit Mohanty

Re: Review Request 44272: Install & Manage Zeppelin with Ambari

2016-03-09 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44272/#review122880 --- Ship it! Ship It! - Sumit Mohanty On March 9, 2016, 6:51

Re: Review Request 45041: Strange paths in ambari-server setup

2016-03-18 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45041/#review124231 --- Ship it! Ship It! - Sumit Mohanty On March 18, 2016, 5:39

Re: Review Request 44556: HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to

2016-03-14 Thread Sumit Mohanty
ER_INTERACTIVE has a different config dir. I do not think we need to set this value if the role is HSI - Sumit Mohanty On March 15, 2016, 12:35 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 44272: Install & Manage Zeppelin with Ambari

2016-03-08 Thread Sumit Mohanty
zeppelin-env? zeppelin-ambari-config is no longer a config type ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/alert_check_zeppelin.py (line 1) <https://reviews.apache.org/r/44272/#comment184750> Thanks. - Sumit Mohanty On March 8, 2016,

Re: Review Request 44272: Install & Manage Zeppelin with Ambari

2016-03-08 Thread Sumit Mohanty
> > (Updated March 8, 2016, 7:18 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-15265 > h

Re: Review Request 44959: Enable Ambari build process to automatically switch repo base urls in the repo files

2016-03-19 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44959/#review124020 --- Ship it! Ship It! - Sumit Mohanty On March 17, 2016, 2:49

Re: Review Request 44352: AMBARI-15230: Move default recovery properties from ambari.properties to cluster-env.xml

2016-03-14 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44352/#review123513 --- Ship it! Ship It! - Sumit Mohanty On March 14, 2016, 10 p.m

Re: Review Request 44746: HiveInteractiveServer. Add 'tez-interactive-site.xml' for custom Tez used by Hive2.

2016-03-14 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44746/#review123567 --- Ship it! Ship It! - Sumit Mohanty On March 14, 2016, 8:27

Re: Review Request 44352: AMBARI-15230: Move default recovery properties from ambari.properties to cluster-env.xml

2016-03-15 Thread Sumit Mohanty
apache.org/r/44352/ > --- > > (Updated March 14, 2016, 10 p.m.) > > > Review request for Ambari, Jonathan Hurley, Zhe (Joe) Wang, Nate Cole, Sumit > Mohanty, and Sid Wagle. > > > Bugs: AMBARI-15230 > https://issues.apache.org/jira/browse/AMBARI-15230 > > >

Re: Review Request 44464: AMBARI-15321. Adding support for Hive Server Interactive Alerts.

2016-03-09 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44464/#review122867 --- Ship it! Ship It! - Sumit Mohanty On March 7, 2016, 7:57

Re: Review Request 44816: Fix new HDFS AMS alerts to account for NN rpc ports

2016-03-14 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44816/#review123562 --- Ship it! Ship It! - Sumit Mohanty On March 15, 2016, 12:21

Re: Review Request 45459: AMBARI-15622. 'phoenix.query.spoolThresholdBytes' property doesn't have a description on UI

2016-03-30 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45459/#review126134 --- Ship it! Ship It! - Sumit Mohanty On March 29, 2016, 11:41

Re: Review Request 45824: Failed to install oozie client

2016-04-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45824/#review127407 --- Ship it! Ship It! - Sumit Mohanty On April 6, 2016, 5:58

Re: Review Request 45835: AMBARI-15635. Storm & Kafka should've default nproc , nofile values.

2016-04-07 Thread Sumit Mohanty
/package/scripts/params_linux.py (line 124) <https://reviews.apache.org/r/45835/#comment191013> Yes, this needs to be fixed. to use default('/configurations/storm-env/storm_user_nofile_limit', 128000) - Sumit Mohanty On April 6, 2016, 9:12 p.m., Sriharsha Chintalapani

Re: Review Request 45893: Password must not by displayed by UpgradeItem and Stage resources in the API

2016-04-07 Thread Sumit Mohanty
/ambari/server/utils/SecretReference.java (line 88) <https://reviews.apache.org/r/45893/#comment191044> I do not think any one needs ambari_db_rca_password. We should go ahead with the changes in the patch but let me open a JIRA to remove this property from host level params. - Sumit M

Re: Review Request 45837: Kafka jaas files are not generated on a Kafa upgrade if security.inter.broker.protocol is set to SASL_PLAINTEXT

2016-04-06 Thread Sumit Mohanty
--- > > (Updated April 6, 2016, 9:12 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Repository: ambari > > > Description > --- > > AMBARI-15747. Kafka jaas files are not generated on a Kafa upgrade if > s

Re: Review Request 45837: Kafka jaas files are not generated on a Kafa upgrade if security.inter.broker.protocol is set to SASL_PLAINTEXT

2016-04-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45837/#review127524 --- Ship it! Ship It! - Sumit Mohanty On April 7, 2016, 12:41

Re: Review Request 45930: After upgrading to Ambari 2.2.1, Storm widgets are gone

2016-04-08 Thread Sumit Mohanty
> On April 8, 2016, 3:04 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java, > > line 186 > > <https://reviews.apache.org/r/45930/diff/1/?file=1337196#file1337196line186> > > > >

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-09 Thread Sumit Mohanty
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml (line 477) <https://reviews.apache.org/r/45972/#comment191386> Change the default to /hadoop/llap/local - Sumit Mohanty On April 9, 2016, 7:30 a.m

Review Request 45989: Blueprint: Presence/absence of HiveServer2 Interactive component in the template should be validated against related configurations

2016-04-10 Thread Sumit Mohanty
-- Total run:946 Total errors:0 Total failures:0 OK [smohanty@HW12158 python (trunk)]$ Thanks, Sumit Mohanty

Re: Review Request 45980: If initial NN start runs into problem while communicating with JN, restart does not work

2016-04-09 Thread Sumit Mohanty
> On April 9, 2016, 4:15 p.m., Sid Wagle wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py, > > line 322 > > > > > > Shouldn't the same logic apply for HA

Review Request 46000: Parallel execution should only be allowed on commands that have auto retry enabled

2016-04-10 Thread Sumit Mohanty
/python/ambari_agent/TestActionQueue.py 466c3a8 Diff: https://reviews.apache.org/r/46000/diff/ Testing --- mvn test against ambari-agent passed. New unit tests added. Thanks, Sumit Mohanty

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-10 Thread Sumit Mohanty
ams_linux.py (line 504) <https://reviews.apache.org/r/45972/#comment191457> Remove the variable llap_local_dir - Sumit Mohanty On April 11, 2016, 5:03 a.m., Swapan Shridhar wrote: > > --- > This is an automatically genera

Re: Review Request 45785: Removing unknown host from cluster throws NPE

2016-04-05 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45785/#review127282 --- Ship it! Ship It! - Sumit Mohanty On April 6, 2016, 4 a.m

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-07 Thread Sumit Mohanty
. - Sumit Mohanty On April 7, 2016, 11:34 p.m., Sid Wagle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45904/ > --

Re: Review Request 45904: Ambari upgrade fails with MySQL DB and enforce gtid enabled

2016-04-07 Thread Sumit Mohanty
lar - why we are keeping count? ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java (line 70) <https://reviews.apache.org/r/45904/#comment191117> Oh! these existed - just not mapped to Entity obj - Sumit Mohanty On April 7, 2016, 11:34 p.m

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-11 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45972/#review128205 --- Ship it! Ship It! - Sumit Mohanty On April 11, 2016, 6:48

Re: Review Request 45872: Component install post processing can not be run in parallel

2016-04-11 Thread Sumit Mohanty
tomatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45872/ > --- > > (Updated April 11, 2016, 2:33 p.m.) > > > Review request for Ambari, Sumit Mohanty and Vitalyi Brodetskyi. > &g

Re: Review Request 45872: Component install post processing can not be run in parallel

2016-04-11 Thread Sumit Mohanty
cally generated e-mail. To reply, visit: > https://reviews.apache.org/r/45872/ > --- > > (Updated April 11, 2016, 2:33 p.m.) > > > Review request for Ambari, Sumit Mohanty and Vitalyi Brodetskyi. > > &g

Re: Review Request 45989: Blueprint: Presence/absence of HiveServer2 Interactive component in the template should be validated against related configurations

2016-04-11 Thread Sumit Mohanty
----- On April 10, 2016, 6:56 p.m., Sumit Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45989/ > -

Re: Review Request 46000: Parallel execution should only be allowed on commands that have auto retry enabled

2016-04-11 Thread Sumit Mohanty
: https://reviews.apache.org/r/46000/diff/ > > > Testing > --- > > mvn test against ambari-agent passed. New unit tests added. > > > Thanks, > > Sumit Mohanty > >

Re: Review Request 46002: Ambari installation failing in RHEL7 during setup

2016-04-10 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46002/#review128069 --- Ship it! Ship It! - Sumit Mohanty On April 11, 2016, 5:29

Re: Review Request 44941: Report AMS / Grafana Per Disk Metrics and other changes

2016-03-19 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44941/#review123980 --- Ship it! Ship It! - Sumit Mohanty On March 17, 2016, 1:09

Re: Review Request 44941: Report AMS / Grafana Per Disk Metrics and other changes

2016-03-19 Thread Sumit Mohanty
- > > (Updated March 17, 2016, 1:09 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty. > > > Bugs: AMBARI-15448 > https://issues.apache.org/jira/browse/AMBARI-15448 > > > Repository: ambari > > > D

Re: Review Request 44965: AMBARI-15452 : Change timeouts for Hbase and Phoenix

2016-03-20 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44965/#review124050 --- Ship it! Ship It! - Sumit Mohanty On March 17, 2016, 5:10

Re: Review Request 45253: AMBARI-15544: Creating multinode cluster using Blueprints fails.

2016-03-23 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45253/#review125147 --- Ship it! Ship It! - Sumit Mohanty On March 23, 2016, 10:45

Re: Review Request 45325: Add the Config, Start and Stop logic for: (1). Hive Server Interactive, and (2). Associate the LLAP lifecycle to it.

2016-03-24 Thread Sumit Mohanty
ain/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 160) <https://reviews.apache.org/r/45325/#comment188178> Use Execute() - Sumit Mohanty On March 24, 2016, 11:24 p.m., Swapan Shridhar wrote: > > -

Re: Review Request 45306: ambari-server check-database has errors after upgrade from 170 to ambari 2.2.2.0 [service SLIDER]

2016-03-24 Thread Sumit Mohanty
<https://reviews.apache.org/r/45306/#comment188096> Nit: Typo - SLIDE to SLIDER in the text. - Sumit Mohanty On March 24, 2016, 7:09 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 45306: ambari-server check-database has errors after upgrade from 170 to ambari 2.2.2.0 [service SLIDER]

2016-03-24 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45306/#review125321 --- Ship it! Fix the minor type and ship. - Sumit Mohanty

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-26 Thread Sumit Mohanty
(line 424) <https://reviews.apache.org/r/45347/#comment188397> Can you add changed to UpgradeCatalog240 as well? - Sumit Mohanty On March 26, 2016, 12:39 a.m., Nahappan Somasundaram wrote: > > --- > This is an automatica

Re: Review Request 45250: AMBARI-15540 : NAMENODE critical alert is present [Percentage standard deviation] after upgrade from 2.0.2/ 2.2.1.0 etc to 2.2.2.0 and disabling security

2016-03-23 Thread Sumit Mohanty
/package/alerts/alert_metrics_deviation.py (line 313) <https://reviews.apache.org/r/45250/#comment188001> Should we say - ... threshold of {0} seconds. Basically, add a unit - Sumit Mohanty On March 23, 2016, 8:46 p.m., Aravindan Vijayan

Re: Review Request 45325: Add the Config, Start and Stop logic for: (1). Hive Server Interactive, and (2). Associate the LLAP lifecycle to it.

2016-03-26 Thread Sumit Mohanty
an develop a check command to see if slider app is alive and use that to decide to call destroy or not. The status command can be used in the status() call as well. - Sumit Mohanty On March 26, 2016, 4:27 a.m., Swa

Re: Review Request 44272: Install & Manage Zeppelin with Ambari

2016-03-07 Thread Sumit Mohanty
version should be 0.6.0.2.5 ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml (line 25) <https://reviews.apache.org/r/44272/#comment184477> folder should be 0.6.0. common-services is a common definition of service that should not be associated with specific

Re: Review Request 44272: Install & Manage Zeppelin with Ambari

2016-03-08 Thread Sumit Mohanty
> On March 8, 2016, 6:39 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml, > > line 24 > > <https://reviews.apache.org/r/44272/diff/2/?file=1283236#file1283236line24> > > > > version should

Re: Review Request 45714: AMBARI-15703: HostResourceProvider should include maintenance_state when a request is made directly with the host name

2016-04-04 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45714/#review126996 --- Ship it! Ship It! - Sumit Mohanty On April 5, 2016, 12:46

Re: Review Request 45714: AMBARI-15703: HostResourceProvider should include maintenance_state when a request is made directly with the host name

2016-04-04 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45714/#review127033 --- Ship it! Ship It! - Sumit Mohanty On April 5, 2016, 4:41

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

2016-03-30 Thread Sumit Mohanty
/functions/constants.py (line 62) <https://reviews.apache.org/r/45458/#comment189013> OK, for now but should not this be in the stack definition as these are service related? - Sumit Mohanty On March 30, 2016, 4:06 a.m., Jayush Luniya

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

2016-03-30 Thread Sumit Mohanty
it. - Sumit Mohanty On March 30, 2016, 4:06 a.m., Jayush Luniya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 45554: ambari-server database check is failing due to EOF Error

2016-03-31 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45554/#review126377 --- Ship it! Ship It! - Sumit Mohanty On March 31, 2016, 6:04

Re: Review Request 45518: AMBARI-15638 : AMS Sum Calculation Incorrect

2016-03-31 Thread Sumit Mohanty
/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AggregatorUtils.java (line 46) <https://reviews.apache.org/r/45518/#comment189494> It may not always be correct to ignore 0 as a datapoint. - Sumit Mohanty On March 31, 2016, 9:35 p.m., Aravindan Vijayan

Re: Review Request 45518: AMBARI-15638 : AMS Sum Calculation Incorrect

2016-03-31 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45518/#review126495 --- Ship it! Ship It! - Sumit Mohanty On March 31, 2016, 9:35

Re: Review Request 45618: Log streaming disabled in Oozie

2016-04-02 Thread Sumit Mohanty
/configuration/oozie-log4j.xml (line 1) <https://reviews.apache.org/r/45618/#comment189722> Why is this file needed? Should HDP-2.2 not inherit from common services? - Sumit Mohanty On April 2, 2016, 2:51 p.m., Vitalyi Brodetskyi

Re: Review Request 45619: Ambari needs to set HDFS GC settings correctly

2016-04-02 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45619/#review126702 --- Ship it! Ship It! - Sumit Mohanty On April 2, 2016, 3:01

Re: Review Request 45665: AMBARI-15680 : METRICS_GRAFANA START failed with 401 Unauthorized Error

2016-04-03 Thread Sumit Mohanty
they are reasonable and then ship. - Sumit Mohanty On April 4, 2016, 4:41 a.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 45665: AMBARI-15680 : METRICS_GRAFANA START failed with 401 Unauthorized Error

2016-04-03 Thread Sumit Mohanty
e other code. - Sumit Mohanty On April 4, 2016, 4:41 a.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

  1   2   3   4   5   6   >