Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-10-29 Thread John Sirois
/python:: -- -v` Also generated a pycharm project via: `./build-support/python/make-pycharm-virtualenv` Confirmed library source linking worked as did running unit tests via the IDE. Also grepped for pants commands in the repo, found `binary` and `setup-py` and confirmed these worked. Thanks, John

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-10 Thread John Sirois
.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift > > . > > > > 22:57:15 00:16 [complete] > >FAILURE > > Exception message: Ambiguous resolvable: thrift > > > > > > > > I will refresh thi

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-10 Thread John Sirois
.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift > > . > > > > 22:57:15 00:16 [complete] > >FAILURE > > Exception message: Ambiguous resolvable: thrift > > > > > > > > I will refresh

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-10 Thread John Sirois
. Thanks, John Sirois

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-10 Thread John Sirois
a pycharm project via: `./build-support/python/make-pycharm-virtualenv` Confirmed library source linking worked as did running unit tests via the IDE. Also grepped for pants commands in the repo, found `binary` and `setup-py` and confirmed these worked. Thanks, John Sirois

Re: Review Request 39784: Upgrade Aurora to pants 0.0.57.

2015-11-10 Thread John Sirois
library source linking worked as did running unit tests via the IDE. Also grepped for pants commands in the repo, found `binary` and `setup-py` and confirmed these worked. Thanks, John Sirois

Re: Review Request 39784: Upgrade Aurora to pants 0.0.57.

2015-11-10 Thread John Sirois
via: `./build-support/python/make-pycharm-virtualenv` Confirmed library source linking worked as did running unit tests via the IDE. Also grepped for pants commands in the repo, found `binary` and `setup-py` and confirmed these worked. Thanks, John Sirois

Re: Review Request 39784: Upgrade Aurora to pants 0.0.57.

2015-11-10 Thread John Sirois
------ On Nov. 10, 2015, 2:50 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39784/ > ---

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-09 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105748 --- @ReviewBot retry - John Sirois On Nov. 9, 2015, 2:47 p.m., John

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-09 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105743 --- @ReviewBot retry - John Sirois On Oct. 29, 2015, 4:05 p.m

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-12 Thread John Sirois
stom > > plugin here we won't be able to upgrade pants in the future at all. > > John Sirois wrote: > As you see fit. I will say that the APIs used here are minimal and > historically stable. For example, Medium similarly enables checkstyle as > well as another,

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-12 Thread John Sirois
stom > > plugin here we won't be able to upgrade pants in the future at all. > > John Sirois wrote: > As you see fit. I will say that the APIs used here are minimal and > historically stable. For example, Medium similarly enables checkstyle as > well as another,

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-12 Thread John Sirois
stom > > plugin here we won't be able to upgrade pants in the future at all. > > John Sirois wrote: > As you see fit. I will say that the APIs used here are minimal and > historically stable. For example, Medium similarly enables checkstyle as > well as another,

Re: Review Request 40220: Modernize the pex venv script.

2015-11-12 Thread John Sirois
(1.1.0) and proper use of the cached venv in the second run: `git clean -fdx build-support && ./build-support/pex --version` Thanks, John Sirois

Re: Review Request 40220: Modernize the pex venv script.

2015-11-12 Thread John Sirois
://reviews.apache.org/r/40220/diff/2#index_header - John Sirois On Nov. 12, 2015, 1:35 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-12 Thread John Sirois
ce around operator | context_aware_object_factories={'pants_requirement': pants_requirement_factory} FAILURE: Python Style issues found 00:48:50 00:01 [complete] FAILURE ``` Thanks, John Sirois

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-12 Thread John Sirois
stom > > plugin here we won't be able to upgrade pants in the future at all. > > John Sirois wrote: > As you see fit. I will say that the APIs used here are minimal and > historically stable. For example, Medium similarly enables checkstyle as > well as another,

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-13 Thread John Sirois
> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote: > > pants.ini, line 33 > > <https://reviews.apache.org/r/40299/diff/1/?file=1125123#file1125123line33> > > > > Seems worth a note this is only used by the vagrant provisioning ... or > > add t

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-13 Thread John Sirois
> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote: > > pants.ini, line 33 > > <https://reviews.apache.org/r/40299/diff/1/?file=1125123#file1125123line33> > > > > Seems worth a note this is only used by the vagrant provisioning ... or > > add t

Re: Review Request 40197: Fix `./pants test src/test/python::` to work out of the box.

2015-11-13 Thread John Sirois
=commit;h=b4102def I'll rebase and post the new diff. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40197/#review106424 --- On Nov. 11, 2015, 1:30 p.m., John Sirois wrote: > > -

Re: Review Request 40197: Fix `./pants test src/test/python::` to work out of the box.

2015-11-13 Thread John Sirois
/test/python:: -- -v` green. Previously this would lead to test failures and CPU starvation. Thanks, John Sirois

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-13 Thread John Sirois
> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote: > > pants.ini, line 33 > > <https://reviews.apache.org/r/40299/diff/1/?file=1125123#file1125123line33> > > > > Seems worth a note this is only used by the vagrant provisioning ... or > > add t

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-13 Thread John Sirois
ed only contain the entry you added here. - John Sirois On Nov. 13, 2015, 9:34 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-13 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40299/#review106451 --- Ship it! Ship It! - John Sirois On Nov. 13, 2015, 10:24 a.m

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-13 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40299/#review106447 --- Ship it! LGTM mod a pending comment - John Sirois On Nov. 13

Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-13 Thread John Sirois
/40310/diff/ Testing --- See the discarded https://reviews.apache.org/r/40219/ for the commit-hook check. This version of that RB engages the same code and this RB commit was vetted by the same commit-hook. Thanks, John Sirois

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-13 Thread John Sirois
/ Testing --- See the discarded https://reviews.apache.org/r/40219/ for the commit-hook check. This version of that RB engages the same code and this RB commit was vetted by the same commit-hook. Thanks, John Sirois

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-13 Thread John Sirois
://reviews.apache.org/r/40310/ - John Sirois On Nov. 12, 2015, 1:54 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois
> > mkdir: /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install: > > Not a directory > > make[5]: *** [install-libLIBRARIES] Error 1 > > make[4]: *** [install-am] Error 2 > > make[3]: *** [install] Error 2 > > make[2]: *** [install-recursive] Error

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois
` green locally. I also got a hold of an OSX 10.10.5 box and was able to run `./build-support/jenkins/build.sh` green on it using this change. Thanks, John Sirois

Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.

2015-11-16 Thread John Sirois
and clean repo via: ``` vagrant destroy && \ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois
and was able to run `./build-support/jenkins/build.sh` green on it using this change. Thanks, John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois
rror 1 > > make[1]: *** [install] Error 2 > > ``` > > > > bison includes an INSTALL file, and your `--prefix` is `$dist/install` :-P Hrm - serves me right for installing OSX on case-sensitive HFS+. Fixed; although the AuroraBot will continue to be red due to https://reviews.a

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-16 Thread John Sirois
://reviews.apache.org/r/40219/ for the commit-hook check. This version of that RB engages the same code and this RB commit was vetted by the same commit-hook. Thanks, John Sirois

Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.

2015-11-16 Thread John Sirois
--- Successfully ran end-to-end with this change using a fresh vagrant image and clean repo via: ``` vagrant destroy && \ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-16 Thread John Sirois
> > ... > > self._scheduler_proxy).restart(instances) I couldn't follow the comment, but did change the style to the one you demonstrated. - John --- This is an automatically genera

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois
and was able to run `./build-support/jenkins/build.sh` green on it using this change. Thanks, John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois
ted e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106749 ------- On Nov. 16, 2015, 1:11 p.m., John Sirois wrote: > > --- > This is an automatically gener

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois
gt; > productive to upgrade to 0.9.2+ before complicating our thrift build? > > > > Not a blocker to landing this but I think it would be nice if we didn't > > have to download a patch for our vendored thrit. > > John Sirois wrote: > Sadly 0.9.2 and 0.9.3 are

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-16 Thread John Sirois
://reviews.apache.org/r/40219/ for the commit-hook check. This version of that RB engages the same code and this RB commit was vetted by the same commit-hook. Thanks, John Sirois

Re: Review Request 40220: Modernize the pex venv script.

2015-11-16 Thread John Sirois
-version` Thanks, John Sirois

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-16 Thread John Sirois
with isort rules internally). - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review106710 --- On Nov.

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-16 Thread John Sirois
the discarded https://reviews.apache.org/r/40219/ for the commit-hook check. This version of that RB engages the same code and this RB commit was vetted by the same commit-hook. Thanks, John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-16 Thread John Sirois
` green on it using this change. Thanks, John Sirois

Re: Review Request 40201: Cleanup thermos_executor test pexes.

2015-11-16 Thread John Sirois
: ``` $ rm -rf dist/ && \ ./pants test.pytest --no-fast src/test/python/apache/aurora/executor: ``` And no `dist/` created. Thanks, John Sirois

Re: Review Request 40334: Upgrade to pants `0.0.59` to avoid pytest errors.

2015-11-15 Thread John Sirois
://reviews.apache.org/r/40310/ Fixed diff coming... - John Sirois On Nov. 15, 2015, 4:32 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-15 Thread John Sirois
/ in anticipation of that fix landing Monday to prevent test errors. - John Sirois On Nov. 15, 2015, 4:34 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-15 Thread John Sirois
and this RB commit was vetted by the same commit-hook. Thanks, John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
; make clean && make -j4 && \ > > make install > > openssl:Error: 'sha256' is an invalid command. > > ``` > > > > Looks like the command syntax on OS X is `openssl dgst -sha256`, i > > don't suppose

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
/jenkins/build.sh` green on it using this change. Thanks, John Sirois

Re: Review Request 40334: Upgrade to pants `0.0.59` to avoid pytest errors.

2015-11-15 Thread John Sirois
about that! - John Sirois On Nov. 15, 2015, 4:36 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106577 --- On Nov. 14, 2015, 4:44 p.m., John Sirois wrote: > > -

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-15 Thread John Sirois
--- See the discarded https://reviews.apache.org/r/40219/ for the commit-hook check. This version of that RB engages the same code and this RB commit was vetted by the same commit-hook. Thanks, John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
clean && make -j4 && \ > > make install > > openssl:Error: 'sha256' is an invalid command. > > ``` > > > > Looks like the command syntax on OS X is `openssl dgst -sha256`, i > > don't suppose that's supported by your v

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
/40323/diff/ Testing --- I can now run `./build-support/jenkins/build.sh` green locally. I also got a hold of an OSX 10.10.5 box and was able to run `./build-support/jenkins/build.sh` green on it using this change. Thanks, John Sirois

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
- > > build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 > build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 > > Diff: https://reviews.apache.org/r/40323/diff/ > > > Testing > --- > > I can now run `./build-support/jenkins/build.sh` green locally. > > I also got a hold of an OSX 10.10.5 box and was able to run > `./build-support/jenkins/build.sh` green on it using this change. > > > Thanks, > > John Sirois > >

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
pytest>=2.6,<2.7, pytest>=2.8.0(from: pytest-timeout) > > > > > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" I'll wait until https://reviews.apache.org/r/40334/ is in

Re: Review Request 39170: Fix NPE on accessing crons set at impossible dates

2015-11-15 Thread John Sirois
towards the cleanups suggested by Kevin and style fixes failing the build currently? If so - great. If not, I can brush this up and send out a new RB. - John Sirois On Oct. 9, 2015, 6:41 a.m., Brice Arnould wrote

Re: Review Request 40204: Update pants bootstrap script to be agnostic to sed version

2015-11-11 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40204/#review106171 --- Ship it! Ship It! - John Sirois On Nov. 11, 2015, 4:39 p.m

Review Request 40208: Eliminate OOB pip install of python deps in CI.

2015-11-11 Thread John Sirois
locally which forces re-download of requirements by pants: ``` $ ./pants clean-all test.pytest --no-fast src/test/python:: ``` Thanks, John Sirois

Review Request 40197: Fix `./pants test src/test/python::` to work out of the box.

2015-11-11 Thread John Sirois
/40197/diff/ Testing --- Ran into this working https://issues.apache.org/jira/browse/AURORA-547. After the fix, locally ran `./pants test src/test/python:: -- -v` green. Previously this would lead to test failures and CPU starvation. Thanks, John Sirois

Review Request 40201: Cleanup thermos_executor test pexes.

2015-11-11 Thread John Sirois
no `dist/` created. Thanks, John Sirois

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-12 Thread John Sirois
/reviews.apache.org/r/40219/#review106301 --- On Nov. 12, 2015, 1:54 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-17 Thread John Sirois
gt; > productive to upgrade to 0.9.2+ before complicating our thrift build? > > > > Not a blocker to landing this but I think it would be nice if we didn't > > have to download a patch for our vendored thrit. > > John Sirois wrote: > Sadly 0.9.2 and 0.9.3 are

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-17 Thread John Sirois
51f37a959041536004f83a60d038f2116be8c8a9 Diff: https://reviews.apache.org/r/40323/diff/ Testing --- I can now run `./build-support/jenkins/build.sh` green locally. I also got a hold of an OSX 10.10.5 box and was able to run `./build-support/jenkins/build.sh` green on it using this change. Thanks, John Sirois

Re: Review Request 40391: Introduce a utility class to read executor configurations in JSON.

2015-11-17 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40391/#review106895 --- Ship it! Ship It! - John Sirois On Nov. 17, 2015, 10:51 a.m

Review Request 40161: Clarify the commit process for new contributors.

2015-11-10 Thread John Sirois
--- Eyeballed: `markdown_py CONTRIBUTING.md > CONTRIBUTING.html && open CONTRIBUTING.html` Thanks, John Sirois

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-02 Thread John Sirois
32 Thanks Joe. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review104483 --- On Oct. 29, 2015, 4:05

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-02 Thread John Sirois
s is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review104487 ------- On Oct. 29, 2015, 4:05 p.m., John Sirois wrote: > > --- > This is an

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-02 Thread John Sirois
ill refresh this build result if you post a review containing > > "@ReviewBot retry" I need to dig in here, this is unexpected. - John --- This is an automatically generated e-mail. To reply, visi

Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.

2015-11-02 Thread John Sirois
If not mind removing it? I'll kill it, its not a lie, but not particularaly useful. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review104484 -------

Review Request 40323: Improve the isolation in the thrift build.

2015-11-14 Thread John Sirois
`./build-support/jenkins/build.sh` green locally. I also got a hold of an OSX 10.10.5 box and was able to run `./build-support/jenkins/build.sh` green on it using this change. Thanks, John Sirois

Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.

2015-11-14 Thread John Sirois
://reviews.apache.org/r/40299/ with another approach and this is it. This is a take-it or leave it. It certainly could be see as obscuring if folks are used to looking in pants.ini for a custom repos setup. - John Sirois On Nov. 14, 2015, 5:18 p.m., John Sirois wrote

Re: Review Request 40299: Restore the third_party python repo, needed for mesos.native egg.

2015-11-14 Thread John Sirois
> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote: > > pants.ini, line 33 > > <https://reviews.apache.org/r/40299/diff/1/?file=1125123#file1125123line33> > > > > Seems worth a note this is only used by the vagrant provisioning ... or > > add t

Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.

2015-11-14 Thread John Sirois
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Review Request 40786: Replace manual Forwarding* with `@Forward`.

2015-11-29 Thread John Sirois
oleSummary(); } ... ``` Thanks, John Sirois

Review Request 41140: Revert "Replace manual Forwarding* with `@Forward`."

2015-12-09 Thread John Sirois
--- Green: `./gradlew -Pq build` Also confirmd `./gradlew idea` produced a project I could build from within IDEA and debug tests with. Thanks, John Sirois

Re: Review Request 40786: Replace manual Forwarding* with `@Forward`.

2015-12-07 Thread John Sirois
tForwarder(AnnotatedAuroraAdmin annotatedAuroraAdmin) { this.annotatedAuroraAdmin = Objects.requireNonNull(annotatedAuroraAdmin); } @Override public Response getRoleSummary() throws TException { return this.annotatedAuroraAdmin.getRoleSummary(); } ... ``` Thanks, John Sirois

Re: Review Request 40786: Replace manual Forwarding* with `@Forward`.

2015-12-07 Thread John Sirois
enerated e-mail. To reply, visit: https://reviews.apache.org/r/40786/#review109183 --- On Dec. 7, 2015, 2:55 p.m., John Sirois wrote: > > --- > This is an automatically ge

Re: Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread John Sirois
non-Optional and on the next line add the stopAsync as a tear down? - John Sirois On Dec. 16, 2015, 11:19 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41453/#review110739 --- Ship it! Ship It! - John Sirois On Dec. 16, 2015, 12:53 p.m

Re: Review Request 41226: Handling task event race in updater.

2015-12-16 Thread John Sirois
will refresh this build result if you post a review containing "@ReviewBot retry" - John Sirois On Dec. 11, 2015, 1:33 a.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 40889: Changed mesos native lib to use mesos.executor instead

2015-12-16 Thread John Sirois
to rebase? I will refresh this build result if you post a review containing "@ReviewBot retry" - John Sirois On Dec. 2, 2015, 11:57 p.m., Steve Niemitz wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-16 Thread John Sirois
, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - John Sirois On Dec. 16, 2015, 4:41 p.m., Kasisnu Singh wrote: > > --- > This is an automatical

Re: Review Request 41368: Remove the client-side updater.

2015-12-16 Thread John Sirois
will refresh this build result if you post a review containing "@ReviewBot retry" - John Sirois On Dec. 14, 2015, 10:36 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-12-16 Thread John Sirois
will refresh this build result if you post a review containing "@ReviewBot retry" - John Sirois On Nov. 25, 2015, 5 p.m., George Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread John Sirois
will refresh this build result if you post a review containing "@ReviewBot retry" - John Sirois On Dec. 16, 2015, 7:15 a.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 41331: Upgrade to pants 0.0.64 and pex 1.1.1.

2015-12-13 Thread John Sirois
/jenkins/build.sh` Thanks, John Sirois

Re: Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

2015-12-17 Thread John Sirois
6efe03fe4841cf1275e2ee0c7cc1b9576540f34e Diff: https://reviews.apache.org/r/41528/diff/ Testing --- Green locally: `./gradlew -Pq build` Thanks, John Sirois

Re: Review Request 41521: Force Windows to always use Unix line endings.

2015-12-17 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41521/#review111002 --- Ship it! Ship It! - John Sirois On Dec. 17, 2015, 11:18 a.m

Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

2015-12-17 Thread John Sirois
` Thanks, John Sirois

Re: Review Request 39170: Fix NPE on accessing crons set at impossible dates

2015-12-17 Thread John Sirois
> On Nov. 15, 2015, 11:34 a.m., John Sirois wrote: > > Brice - this would be nice to land. Are you able to put time towards the > > cleanups suggested by Kevin and style fixes failing the build currently? > > If so - great. If not, I can brush this up and send out a

Re: Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

2015-12-17 Thread John Sirois
sit: https://reviews.apache.org/r/41528/#review111058 --- On Dec. 17, 2015, 2:27 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request 41893: Fixup missing commons compile dep.

2016-01-04 Thread John Sirois
://reviews.apache.org/r/41893/diff/ Testing --- Not green locally due to ZK issues from https://git1-us-west.apache.org/repos/asf/aurora/repo?p=aurora.git;a=commit;h=8706a781968912c68688284d9d3813d34ce45bf7, but the CI script gets further on my machine with the junit dep added Thanks, John Sirois

Re: Review Request 41897: Upgrade to the latest zk point release.

2016-01-04 Thread John Sirois
/build.sh` and `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` ran green locally. Thanks, John Sirois

Review Request 41895: Fix Kerberos5ShiroRealmModule: use dedicated jaas config.

2016-01-04 Thread John Sirois
ure(NIOServerCnxnFactory.java:96) at org.apache.aurora.common.zookeeper.testing.ZooKeeperTestServer.startNetwork(ZooKeeperTestServer.java:81) at org.apache.aurora.common.zookeeper.testing.BaseZooKeeperTest.setUp(BaseZooKeeperTest.java:64) ... ``` Thanks, John Sirois

Re: Review Request 41897: Upgrade to the latest zk point release.

2016-01-04 Thread John Sirois
it: https://reviews.apache.org/r/41897/#review112679 --- On Jan. 4, 2016, 4:02 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Review Request 41899: Upgrade to pants 0.0.66.

2016-01-04 Thread John Sirois
579d86cd2e02ea3e1a7add9cdd8291a6dc9669ec Diff: https://reviews.apache.org/r/41899/diff/ Testing --- Locally green: ``` ./build-support/jenkins/build.sh && ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Re: Review Request 41893: Fixup missing commons compile dep.

2016-01-04 Thread John Sirois
/BaseZooKeeperTest.java:import org.junit.Before; commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java:import org.junit.Rule; commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java:import org.junit.rules.TemporaryFolder; ``` - John Sirois On Jan. 4, 2016

Re: Review Request 41897: Upgrade to the latest zk point release.

2016-01-04 Thread John Sirois
> On Jan. 4, 2016, 4:17 p.m., Stephan Erb wrote: > > News file needs updating too :-) > > John Sirois wrote: > Good call - change coming as well as an updated reviews list. Fixed. - John --- This is an automat

  1   2   3   4   5   6   7   >