Re: Review Request 49338: Update packaging for Aurora 0.14

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49338/#review139871 --- Ship it! Ship It! - John Sirois On June 28, 2016, 3:45 p.m

Review Request 49399: Fix Process log configuration handling.

Thanks, John Sirois

Re: Review Request 49399: Fix Process log configuration handling.

tps://reviews.apache.org/r/49399/#comment205381> NB: The trailing comma here on the LHS formed a 1-tuple leading to the initial bug report (wrong type). - John Sirois On June 29, 2016, 4:53 p.m., John Sirois wrote: > > ---

Re: Review Request 49399: Fix Process log configuration handling.

://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1724/docs/reference/configuration.md#logger https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1724/docs/operations/configuration.md#process-logs Thanks, John Sirois

Re: Review Request 49399: Fix Process log configuration handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49399/#review140067 --- @ReviewBot retry - John Sirois On June 29, 2016, 5 p.m., John

Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

0.14.0 releases. Rendered here: https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2 Thanks, John Sirois

Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

-us.apache.org/repos/asf?p=aurora-packaging.git;a=commit;h=a665227c0d1634fe69bb9c45559f7d1ff69a4c03 - John Sirois On June 29, 2016, 6:10 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49413/#review140080 --- @ReviewBot retry - John Sirois On June 29, 2016, 6:10 p.m

Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

> On June 29, 2016, 6:23 p.m., John Sirois wrote: > > @ReviewBot retry FWIW: The failures that lead to this sort of "coverage missing" are all intergation test connect errors to an in-process servlet engine: https://gist.github.com/jsirois/32f629a2e950d28e8910fe3d62e928d8

Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49413/#review140085 --- @ReviewBot retry - John Sirois On June 29, 2016, 6:10 p.m

Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49413/#review140087 --- @ReviewBot retry - John Sirois On June 29, 2016, 6:10 p.m

Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.

> On June 29, 2016, 6:23 p.m., John Sirois wrote: > > @ReviewBot retry > > John Sirois wrote: > FWIW: The failures that lead to this sort of "coverage missing" are all > intergation test connect errors to an in-process servlet engine: >

Re: Review Request 49399: Fix Process log configuration handling.

> > `_build_process_logger_args` if we assign default arugments here, rather > > than later in the code. I think this would be less defaulting than you envisioned due to the same odd UI issue as shown above in tak config json presents in CLI help output. I cou

Review Request 49528: Patch thrift to compile under modern gcc.

c28f4146b4874fe5faf6dbd872a692d39816d4bb Diff: https://reviews.apache.org/r/49528/diff/ Testing --- Locally green under gcc 6.1.1 20160602 using: ``` git clean -fdx build-support/thrift/ ./gradlew -Pq clean build ``` Thanks, John Sirois

Re: Review Request 49528: Patch thrift to compile under modern gcc.

d be found! ``` To keep the patch simple, I'm treating these WARNINGs as acceptable noise. - John Sirois On July 1, 2016, 1:28 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 49527: Reduce log level of finding a valid leader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49527/#review140415 --- Ship it! Ship It! - John Sirois On July 1, 2016, 1:29 p.m

Review Request 49577: Ensure e2e key has its own authorized_keys line.

``` Thanks, John Sirois

Review Request 49578: Close `PathChildrenCache` before its framework.

pache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java 16692056ffb97e6bfcc8c80c8f4faecc7ae16c62 Diff: https://reviews.apache.org/r/49578/diff/ Testing --- Locally green: ``` ./gradlew -Pq clean build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Re: Review Request 49578: Close `PathChildrenCache` before its framework.

were involved in its predecessor reviews despite the fact one or both may not be interested in reviewing at present. As such, I won't block on their feedback, but will happily take it if offered. - John Sirois On July 3, 2016, 5:02 p.m., John Sirois

Re: Review Request 49578: Close `PathChildrenCache` before its framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49578/#review140583 --- @ReviewBot retry - John Sirois On July 3, 2016, 5:02 p.m

Re: Review Request 49578: Close `PathChildrenCache` before its framework.

va.net.ConnectException at ShiroKerberosPermissiveAuthenticationFilterTest.java:90 java.lang.AssertionError ``` - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49578/#review140581 -

Re: Review Request 49578: Close `PathChildrenCache` before its framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49578/#review140590 --- @ReviewBot retry - John Sirois On July 3, 2016, 5:02 p.m

Review Request 49593: Upgrade to pants 1.1.0-pre6.

/client/cli/.auroraversion 0.16.0-SNAPSHOT ``` Also green locally: ``` $ ./build-support/jenkins/build.sh $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Re: Review Request 49593: Upgrade to pants 1.1.0-pre6.

593/#comment206029> NB: This may look like it possibly disables the jvm backend by not selecting it (`pants.backend.jvm`), but we're not quite there yet. - John Sirois On July 4, 2016, 8:52 a.m., John Sirois wrote: > > ---

Re: Review Request 49593: Upgrade to pants 1.1.0-pre6.

hen it does vet. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49593/#review140663 --- On July 4, 2016, 8:5

Re: Review Request 49593: Upgrade to pants 1.1.0-pre6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49593/#review140668 --- @ReviewBot retry - John Sirois On July 4, 2016, 8:52 a.m

Re: Review Request 49528: Patch thrift to compile under modern gcc.

.compiler.cpp.src.generate.t_java_generator.cc.patch (line 8) <https://reviews.apache.org/r/49528/#comment206032> This is a bug - should be `if (!first) {`. We don't hit this bug since we don't declare thrift service exceptions, but I'll circle back with a fix for sanity sake. - John Sirois On J

Review Request 49595: Fix thrift t_java_generator.ccc patch.

$ ./thriftw 0.9.1 -version Thrift version 0.9.1 ``` Thanks, John Sirois

Re: Review Request 49528: Patch thrift to compile under modern gcc.

> On July 4, 2016, 9:36 a.m., John Sirois wrote: > > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch, > > line 8 > > <https://reviews.apache.org/r/49528/diff/1/?file=1435189#file1435189line8> > > > > This is a bug

Review Request 49740: Update packaging for Aurora 0.15.

. Thanks, John Sirois

Re: Review Request 49740: Update packaging for Aurora 0.15.

in-fact on master: https://git-wip-us.apache.org/repos/asf?p=aurora-packaging.git;a=summary - John Sirois On July 6, 2016, 8:19 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 49732: Update package scripts to 0.15.0.

> On July 6, 2016, 6:41 p.m., Maxim Khutornenko wrote: > > Pushed this as tbr to origin/0.15.x in favor of speeding up the vote. > > Feedback is still welcome. Shouldn't this be on master? I discarded my similar fix here after having missed this was only on a branch: https://reviews.apache.or

Re: Review Request 49732: Update package scripts to 0.15.0.

after this change ... IIUC Aurora 0.15.0 should work with mesos 0.27.2 (Aurora should work with the mesos its developed against +/- 1). - John Sirois On July 6, 2016, 6:30 p.m., Maxim Khutornenko wrote: > > --- > This is an auto

Re: Review Request 49740: Update packaging for Aurora 0.15.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49740/#review141122 --- Discarded. - John Sirois On July 6, 2016, 8:19 p.m., John

Re: Review Request 49732: Update package scripts to 0.15.0.

> On July 6, 2016, 8:33 p.m., John Sirois wrote: > > I am slightly worried the tests only seem to work after this change ... > > IIUC Aurora 0.15.0 should work with mesos 0.27.2 (Aurora should work with > > the mesos its developed against +/- 1). Oh, now I understand I

Re: Review Request 49732: Update package scripts to 0.15.0.

> On July 6, 2016, 8:33 p.m., John Sirois wrote: > > I am slightly worried the tests only seem to work after this change ... > > IIUC Aurora 0.15.0 should work with mesos 0.27.2 (Aurora should work with > > the mesos its developed against +/- 1). > > John Si

Re: Review Request 49732: Update package scripts to 0.15.0.

more sense. This TBR to a branch (on origin) confused me at least. - John Sirois On July 6, 2016, 6:30 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 49868: Update virtualenv version to 15.0.2

gt; from within the test code. This was the original case motivating AURORA-1717. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49868/#review141619 --- On

Re: Review Request 49868: Update virtualenv version to 15.0.2

e and configured differently on various Apache build farm Jenkins slaves ... which is likely. I'm digging a bit to see if I can confirm more details. - John Sirois On July 10, 2016, 11:38 a.m., Stephan Erb wrote: > > --- > This

Re: Review Request 49868: Update virtualenv version to 15.0.2

canonical bootstrap script which the Aurora `./pants` script is mod the extra license header: https://github.com/pantsbuild/setup/commit/31976dcc75d1facc1fd5496c878684b8b955f1cc - John Sirois On July 10, 2016, 11:38 a.m., Stephan Erb wrote

Re: Review Request 49868: Update virtualenv version to 15.0.2

> On July 10, 2016, 3:35 p.m., John Sirois wrote: > > I'm not sure this is directly relevant to the problem at hand. Pants > > bootstraps fine, is the thermos integration tests that pants runs (must be > > bootstrapped via pip to do so), that have a `./pants` sub

Re: Review Request 49868: Update virtualenv version to 15.0.2

inate 1 causes of noise in the quest to track down what's really going on with AURORA-1717. Thanks again for this fix! - John Sirois On July 10, 2016, 11:38 a.m., Stephan Erb wrote: > > --- > This is an automatically generat

Review Request 49872: Upgrade pants to 1.1.0-rc7.

/test_end_to_end.sh ``` Thanks, John Sirois

Re: Review Request 49872: Upgrade pants to 1.1.0-rc7.

longer be active, but I thought he'd be happy to see the resolution of https://github.com/pantsbuild/pants/issues/940 at last applied to the Aurora repo. - John Sirois On July 10, 2016, 4:43 p.m., John Sirois wrote: > > --- >

Review Request 49899: Upgrade to gradle 2.14.

/ Testing --- Locally green and Gradle daemon observed used in e2e: ``` ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` I also built a fresh IDEA project with `./gradlew idea` and that project built green from within IDEA. Thanks, John Sirois

Review Request 49900: Upgrade to gradle 2.14.

/tmp/snapshot.tar.gz HEAD ``` And used that to successfully build all debs and the rpm: ``` (aurora-packaging) $ ./build-artifact.sh /tmp/snapshot.tar.gz 0.16.0-SNAPSHOT ``` Thanks, John Sirois

Re: Review Request 49872: Upgrade pants to 1.1.0-rc7.

not been as fraught as an rc7 might lead you to believe. Long story short, pants-devel did not do its homework when switching to the new version scheme, and in pip's eyes 1.1.0-pre0 == 1.1.0-rc0; so pants needed to move past the last pre (6), thus we're at 1.1.0-rc7. - John Sirois

Re: Review Request 49872: Upgrade pants to 1.1.0-rc7.

-python-sdists $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Re: Review Request 49900: Upgrade to gradle 2.14.

https://builds.apache.org/job/aurora-packaging-nightly/360 back green. - John Sirois On July 11, 2016, 10:53 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 49900: Upgrade to gradle 2.14.

-packaging/commit/502d07ef - John Sirois On July 11, 2016, 10:53 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 50716: Use Docker host network rather than bridging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50716/#review144532 --- Ship it! Ship It! - John Sirois On Aug. 2, 2016, 3:13 p.m

Re: Review Request 51484: Re-enable python style check in the integration build.

hould no longer be needed since `./pants test...` implies `./pants compile...` which is all the seperate script does. - John Sirois On Aug. 27, 2016, 10:40 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatical

Re: Review Request 51484: Re-enable python style check in the integration build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51484/#review147142 --- Ship it! Ship It! - John Sirois On Aug. 27, 2016, 10:40 p.m

Re: Review Request 51484: Re-enable python style check in the integration build.

> On Aug. 29, 2016, 10:39 a.m., John Sirois wrote: > > I'm taking a look presently. The seperate script call-out should no longer > > be needed since `./pants test...` implies `./pants compile...` which is all > > the seperate script does. Aha - yes, the compile d

Re: Review Request 51484: Re-enable python style check in the integration build.

> On Aug. 29, 2016, 10:39 a.m., John Sirois wrote: > > I'm taking a look presently. The seperate script call-out should no longer > > be needed since `./pants test...` implies `./pants compile...` which is all > > the seperate script does. > > John Sirois wro

Re: Review Request 51484: Re-enable python style check in the integration build.

> On Aug. 29, 2016, 10:44 a.m., John Sirois wrote: > > Ship It! Zameer - I'll patch this in directly without your review since its straightforward. - John --- This is an automatically generated e-mail. To reply

Re: Review Request 51484: Re-enable python style check in the integration build.

> On Aug. 29, 2016, 10:39 a.m., John Sirois wrote: > > I'm taking a look presently. The seperate script call-out should no longer > > be needed since `./pants test...` implies `./pants compile...` which is all > > the seperate script does. > > John Sirois wro

Re: Review Request 51484: Re-enable python style check in the integration build.

> On Aug. 29, 2016, 10:39 a.m., John Sirois wrote: > > I'm taking a look presently. The seperate script call-out should no longer > > be needed since `./pants test...` implies `./pants compile...` which is all > > the seperate script does. > > John Sirois wro

Re: Review Request 51499: Update 3dparty Python dependencies

> > I will refresh this build result if you post a review containing > > "@ReviewBot retry" @ReviewBot retry - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51499/#review147196 --

Re: Review Request 51499: Update 3dparty Python dependencies

it: https://reviews.apache.org/r/51499/#review147224 --- On Aug. 29, 2016, 1:11 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 51499: Update 3dparty Python dependencies

... 30424 KB 1.447s > > INFO] Fetched thrift binary from: > > https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift > > . > > > > 22:03:42 00:07 [complete] > > FAILUREException caught: ( > 'ex

Re: Review Request 51499: Update 3dparty Python dependencies

... 30424 KB 1.447s > > INFO] Fetched thrift binary from: > > https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift > > . > > > > 22:03:42 00:07 [complete] > > FAILUREException caught: ( > 'ex

Re: Review Request 51499: Update 3dparty Python dependencies

... 30424 KB 1.447s > > INFO] Fetched thrift binary from: > > https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift > > . > > > > 22:03:42 00:07 [complete] > > FAILUREException caught: ( > 'ex

Re: Review Request 51499: Update 3dparty Python dependencies

... 30424 KB 1.447s > > INFO] Fetched thrift binary from: > > https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift > > . > > > > 22:03:42 00:07 [complete] > > FAILUREException caught: ( > 'ex

Review Request 51506: Enable -zk_use_curator by default and deprecate.

/FlaggedZooKeeperConfig.java 36ad18c49c5693031136440ab163070f9ffa9405 Diff: https://reviews.apache.org/r/51506/diff/ Testing --- Locally green: ``` ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Re: Review Request 51499: Update 3dparty Python dependencies

... 30424 KB 1.447s > > INFO] Fetched thrift binary from: > > https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift > > . > > > > 22:03:42 00:07 [complete] > > FAILUREException caught: ( > 'ex

Re: Review Request 51499: Update 3dparty Python dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51499/#review147283 --- Ship it! Ship It! - John Sirois On Aug. 30, 2016, 1:40 a.m

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

ically generated e-mail. To reply, visit: https://reviews.apache.org/r/51506/#review147322 --- On Aug. 29, 2016, 5:37 p.m., John Sirois wrote: > > --- > This is an autom

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

is is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51506/#review147269 --- On Aug. 29, 2016, 5:37 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51506/#review147326 ------- On Aug. 29, 2016, 5:37 p.m., John Sirois wrote: > > --

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java 36ad18c49c5693031136440ab163070f9ffa9405 Diff: https://reviews.apache.org/r/51506/diff/ Testing --- Locally green: ``` ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java 36ad18c49c5693031136440ab163070f9ffa9405 Diff: https://reviews.apache.org/r/51506/diff/ Testing --- Locally green: ``` ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

> On Aug. 30, 2016, 11:56 a.m., Zameer Manji wrote: > > LGTM modulo updating the docs about restarting all instances at the same > > time. > > > > Could you also file a ticket to track the removal of the `zk_use_curator` > > flag in 0.17? I did not see on

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

https://reviews.apache.org/r/51564/#review147497 --- On Aug. 31, 2016, 2:56 p.m., Zhitao Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51564/ > ---

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

be switching to root, it will be switching to > the user matching the role name on the host system, the uid set in your > docker/appc image wouldn't have any impact on that. Am I missing something? > > John Sirois wrote: > Joshua mentioned this in Slack/IRC, but I do think

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

be switching to root, it will be switching to > the user matching the role name on the host system, the uid set in your > docker/appc image wouldn't have any impact on that. Am I missing something? > > John Sirois wrote: > Joshua mentioned this in Slack/IRC, but I do think

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

python # Return codes from `useradd` and `groupadd` calls. _USER_OR_GROUP_EXISTS = ( 4, # uid/gid already exists. 9 # user/group name exists. ) ``` - John Sirois On Sept. 2, 2016, 8:11 a.m., Zhitao Li

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

> On Sept. 2, 2016, 12:35 p.m., John Sirois wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 251 > > <https://reviews.apache.org/r/51564/diff/6/?file=1490570#file1490570line251> > > > > You might extract this as a helper function >

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

> On Sept. 2, 2016, 12:35 p.m., John Sirois wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 251 > > <https://reviews.apache.org/r/51564/diff/6/?file=1490570#file1490570line251> > > > > You might extract this as a helper function >

Review Request 51615: Upgrade to latest CherryPy.

/pantsbuild/pants/issues/3823 on the pants/pex side. Now green: `LANG=en_US.ISO-8859-1 ./pants test src/{main,test}/python::` Thanks, John Sirois

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

> On Sept. 15, 2016, 12:25 p.m., Zameer Manji wrote: > > config/findbugs/excludeFilter.xml, line 123 > > > > > > If I'm reading the code correctly we need this because we have a > > `CompletableFuture` and to give i

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

oid` with a random `Object` just to > avoid analyzer error. This opens up a potential for much more confusing cases. > > John Sirois wrote: > Generally a `SideEffect` type with 1 instance would be handy for these > things. Something to consider outside this review. &g

Review Request 51987: Enable the `project_info` plugin.

de0ab30264980e28cbb771b8beaa99fa02797b25 Diff: https://reviews.apache.org/r/51987/diff/ Testing --- Used `./build-support/python/make-pycharm-virtualenv` to generate a pycharm project that loaded properly with symbol navigation for aurora 3rdparty deps. Thanks, John Sirois

Review Request 52312: Remove `-zk_use_curator` and unused code.

/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a src/test/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfigTest.java a065505134c1ad30ba9f4d4cd829355b2acc9a13 Diff: https://reviews.apache.org/r/52312/diff/ Testing --- Locally green: `./gradlew -Pq build` Thanks, John

Re: Review Request 52312: Remove `-zk_use_curator` and unused code.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52312/#review150605 --- On Sept. 27, 2016, 1:43 p.m., John Sirois wrote: > > ---

Re: Review Request 52312: Remove `-zk_use_curator` and unused code.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52312/#review150604 --- On Sept. 27, 2016, 1:43 p.m., John Sirois wrote: > > ---

Re: Review Request 52312: Remove `-zk_use_curator` and unused code.

/ZooKeeperConfigTest.java a065505134c1ad30ba9f4d4cd829355b2acc9a13 Diff: https://reviews.apache.org/r/52312/diff/ Testing --- Locally green: `./gradlew -Pq build` Thanks, John Sirois

Review Request 52314: Upgrade to latest pants 1.2.0 pre-release.

``` Thanks, John Sirois

Re: Review Request 52314: Upgrade to latest pants 1.2.0 pre-release.

include libffi-dev (needed by a new pants dep). - John Sirois On Sept. 27, 2016, 2:37 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 52314: Upgrade to latest pants 1.2.0 pre-release.

e has been released. - John Sirois On Sept. 27, 2016, 2:37 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Review Request 52367: Upgrade to latest pants 1.2.0 pre-release.

/build.sh ./build-support/python/make-pycharm-virtualenv vagrant destroy && ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Review Request 52422: Improve docker perf in the Vagrant vm.

hon -c "print('Hello Storage Driver')" Hello Storage Driver real0m0.413s user0m0.006s sys 0m0.012s ``` NB: In this test, the active ingredient is `--rm` which removes the container, engaging the storage driver in a serious way. Thanks, John Sirois

Review Request 52428: Add missing libffi build dep to support pants.

-packaging-nightly/440/ Now locally green: ``` (aurora) $ git archive --prefix=apache-aurora-$(cat .auroraversion)/ -o snapshot.tar.gz HEAD (aurora-packaging) $ ./build-artifact.sh ../aurora/snapshot.tar.gz 0.17.0-SNAPSHOT ``` Thanks, John Sirois

Re: Review Request 52428: Add missing libffi build dep to support pants.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52428/#review151061 --- On Sept. 30, 2016, 12:17 p.m., John Sirois wrote: > > -

Re: Review Request 52577: Update to Gradle 3.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52577/#review151576 --- Ship it! Ship It! - John Sirois On Oct. 5, 2016, 4:14 p.m

Re: Review Request 52579: Update Gradle to 3.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52579/#review151586 --- Ship it! Ship It! - John Sirois On Oct. 5, 2016, 4:58 p.m

Re: Review Request 52581: Reduce offer_filter_duration to 0secs in Vagrant

: https://github.com/apache/aurora/blob/783baaefb9a814ca01fad78181fe3df3de5b34af/src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java#L40 - John Sirois On Oct. 5, 2016, 5:23 p.m., Stephan Erb wrote: > > --- > T

Re: Review Request 52581: Reduce offer_filter_duration to 0secs in Vagrant

> On Oct. 5, 2016, 5:32 p.m., John Sirois wrote: > > presumably a near-zero jitter would help as well: > > https://github.com/apache/aurora/blob/783baaefb9a814ca01fad78181fe3df3de5b34af/src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java#L40 Umm, nmm, pure s

Review Request 52591: Remove untested classes that no longer exist.

, John Sirois

Review Request 52594: Move common/zookeeper to the main aurora project.

ache.org/r/52594/diff/ Testing --- Locally green: ``` ./gradlew -Pq build ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

  1   2   3   4   5   6   7   8   >