/python:: -- -v`
Also generated a pycharm project via:
`./build-support/python/make-pycharm-virtualenv`
Confirmed library source linking worked as did running unit tests
via the IDE.
Also grepped for pants commands in the repo, found `binary` and `setup-py`
and confirmed these worked.
Thanks,
John
.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift
> > .
> >
> > 22:57:15 00:16 [complete][31m
> >FAILURE[0m
> > Exception message: Ambiguous resolvable: thrift
> >
> >
> >
> > I will refresh thi
.
Thanks,
John Sirois
a pycharm project via:
`./build-support/python/make-pycharm-virtualenv`
Confirmed library source linking worked as did running unit tests
via the IDE.
Also grepped for pants commands in the repo, found `binary` and `setup-py`
and confirmed these worked.
Thanks,
John Sirois
library source linking worked as did running unit tests
via the IDE.
Also grepped for pants commands in the repo, found `binary` and `setup-py`
and confirmed these worked.
Thanks,
John Sirois
via:
`./build-support/python/make-pycharm-virtualenv`
Confirmed library source linking worked as did running unit tests
via the IDE.
Also grepped for pants commands in the repo, found `binary` and `setup-py`
and confirmed these worked.
Thanks,
John Sirois
------
On Nov. 10, 2015, 2:50 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39784/
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39784/#review105748
---
@ReviewBot retry
- John Sirois
On Nov. 9, 2015, 2:47 p.m., John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39784/#review105743
---
@ReviewBot retry
- John Sirois
On Oct. 29, 2015, 4:05 p.m
stom
> > plugin here we won't be able to upgrade pants in the future at all.
>
> John Sirois wrote:
> As you see fit. I will say that the APIs used here are minimal and
> historically stable. For example, Medium similarly enables checkstyle as
> well as another,
stom
> > plugin here we won't be able to upgrade pants in the future at all.
>
> John Sirois wrote:
> As you see fit. I will say that the APIs used here are minimal and
> historically stable. For example, Medium similarly enables checkstyle as
> well as another,
stom
> > plugin here we won't be able to upgrade pants in the future at all.
>
> John Sirois wrote:
> As you see fit. I will say that the APIs used here are minimal and
> historically stable. For example, Medium similarly enables checkstyle as
> well as another,
(1.1.0) and
proper use of the cached venv in the second run:
`git clean -fdx build-support && ./build-support/pex --version`
Thanks,
John Sirois
://reviews.apache.org/r/40220/diff/2#index_header
- John Sirois
On Nov. 12, 2015, 1:35 a.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
stom
> > plugin here we won't be able to upgrade pants in the future at all.
>
> John Sirois wrote:
> As you see fit. I will say that the APIs used here are minimal and
> historically stable. For example, Medium similarly enables checkstyle as
> well as another,
> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote:
> > pants.ini, line 33
> > <https://reviews.apache.org/r/40299/diff/1/?file=1125123#file1125123line33>
> >
> > Seems worth a note this is only used by the vagrant provisioning ... or
> > add t
> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote:
> > pants.ini, line 33
> > <https://reviews.apache.org/r/40299/diff/1/?file=1125123#file1125123line33>
> >
> > Seems worth a note this is only used by the vagrant provisioning ... or
> > add t
=commit;h=b4102def
I'll rebase and post the new diff.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40197/#review106424
---
On Nov. 11, 2015, 1:30 p.m., John Sirois wrote:
>
> -
/test/python:: -- -v` green.
Previously this would lead to test failures and CPU starvation.
Thanks,
John Sirois
ed only
contain the entry you added here.
- John Sirois
On Nov. 13, 2015, 9:34 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40299/#review106451
---
Ship it!
Ship It!
- John Sirois
On Nov. 13, 2015, 10:24 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40299/#review106447
---
Ship it!
LGTM mod a pending comment
- John Sirois
On Nov. 13
/
Testing
---
See the discarded https://reviews.apache.org/r/40219/ for the
commit-hook check. This version of that RB engages the same code
and this RB commit was vetted by the same commit-hook.
Thanks,
John Sirois
://reviews.apache.org/r/40310/
- John Sirois
On Nov. 12, 2015, 1:54 a.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> > mkdir: /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install:
> > Not a directory
> > make[5]: *** [install-libLIBRARIES] Error 1
> > make[4]: *** [install-am] Error 2
> > make[3]: *** [install] Error 2
> > make[2]: *** [install-recursive] Error
and clean repo via:
```
vagrant destroy && \
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
and was able to run
`./build-support/jenkins/build.sh` green on it using this change.
Thanks,
John Sirois
rror 1
> > make[1]: *** [install] Error 2
> > ```
> >
> > bison includes an INSTALL file, and your `--prefix` is `$dist/install` :-P
Hrm - serves me right for installing OSX on case-sensitive HFS+.
Fixed; although the AuroraBot will continue to be red due to
https://reviews.a
://reviews.apache.org/r/40219/ for the
commit-hook check. This version of that RB engages the same code
and this RB commit was vetted by the same commit-hook.
Thanks,
John Sirois
---
Successfully ran end-to-end with this change using a fresh vagrant
image and clean repo via:
```
vagrant destroy && \
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
> > ...
> > self._scheduler_proxy).restart(instances)
I couldn't follow the comment, but did change the style to the one you
demonstrated.
- John
---
This is an automatically genera
and was able to run
`./build-support/jenkins/build.sh` green on it using this change.
Thanks,
John Sirois
ted e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106749
-------
On Nov. 16, 2015, 1:11 p.m., John Sirois wrote:
>
> ---
> This is an automatically gener
gt; > productive to upgrade to 0.9.2+ before complicating our thrift build?
> >
> > Not a blocker to landing this but I think it would be nice if we didn't
> > have to download a patch for our vendored thrit.
>
> John Sirois wrote:
> Sadly 0.9.2 and 0.9.3 are
://reviews.apache.org/r/40219/ for the
commit-hook check. This version of that RB engages the same code
and this RB commit was vetted by the same commit-hook.
Thanks,
John Sirois
-version`
Thanks,
John Sirois
with isort rules internally).
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40310/#review106710
---
On Nov.
the discarded https://reviews.apache.org/r/40219/ for the
commit-hook check. This version of that RB engages the same code
and this RB commit was vetted by the same commit-hook.
Thanks,
John Sirois
` green on it using this change.
Thanks,
John Sirois
:
```
$ rm -rf dist/ && \
./pants test.pytest --no-fast src/test/python/apache/aurora/executor:
```
And no `dist/` created.
Thanks,
John Sirois
://reviews.apache.org/r/40310/
Fixed diff coming...
- John Sirois
On Nov. 15, 2015, 4:32 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/ in anticipation
of that fix landing Monday to prevent test errors.
- John Sirois
On Nov. 15, 2015, 4:34 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
and this RB commit was vetted by the same commit-hook.
Thanks,
John Sirois
; make clean && make -j4 && \
> > make install
> > openssl:Error: 'sha256' is an invalid command.
> > ```
> >
> > Looks like the command syntax on OS X is `openssl dgst -sha256`, i
> > don't suppose
/jenkins/build.sh` green on it using this change.
Thanks,
John Sirois
about that!
- John Sirois
On Nov. 15, 2015, 4:36 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106577
---
On Nov. 14, 2015, 4:44 p.m., John Sirois wrote:
>
> -
---
See the discarded https://reviews.apache.org/r/40219/ for the
commit-hook check. This version of that RB engages the same code
and this RB commit was vetted by the same commit-hook.
Thanks,
John Sirois
clean && make -j4 && \
> > make install
> > openssl:Error: 'sha256' is an invalid command.
> > ```
> >
> > Looks like the command syntax on OS X is `openssl dgst -sha256`, i
> > don't suppose that's supported by your v
/40323/diff/
Testing
---
I can now run `./build-support/jenkins/build.sh` green locally.
I also got a hold of an OSX 10.10.5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.
Thanks,
John Sirois
-
>
> build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7
> build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9
>
> Diff: https://reviews.apache.org/r/40323/diff/
>
>
> Testing
> ---
>
> I can now run `./build-support/jenkins/build.sh` green locally.
>
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
>
>
> Thanks,
>
> John Sirois
>
>
pytest>=2.6,<2.7, pytest>=2.8.0(from: pytest-timeout)
> >
> >
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
I'll wait until https://reviews.apache.org/r/40334/ is in
towards the
cleanups suggested by Kevin and style fixes failing the build currently? If so
- great. If not, I can brush this up and send out a new RB.
- John Sirois
On Oct. 9, 2015, 6:41 a.m., Brice Arnould wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40204/#review106171
---
Ship it!
Ship It!
- John Sirois
On Nov. 11, 2015, 4:39 p.m
locally which forces re-download of requirements
by pants:
```
$ ./pants clean-all test.pytest --no-fast src/test/python::
```
Thanks,
John Sirois
/40197/diff/
Testing
---
Ran into this working https://issues.apache.org/jira/browse/AURORA-547.
After the fix, locally ran `./pants test src/test/python:: -- -v` green.
Previously this would lead to test failures and CPU starvation.
Thanks,
John Sirois
no `dist/` created.
Thanks,
John Sirois
/reviews.apache.org/r/40219/#review106301
---
On Nov. 12, 2015, 1:54 a.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
gt; > productive to upgrade to 0.9.2+ before complicating our thrift build?
> >
> > Not a blocker to landing this but I think it would be nice if we didn't
> > have to download a patch for our vendored thrit.
>
> John Sirois wrote:
> Sadly 0.9.2 and 0.9.3 are
51f37a959041536004f83a60d038f2116be8c8a9
Diff: https://reviews.apache.org/r/40323/diff/
Testing
---
I can now run `./build-support/jenkins/build.sh` green locally.
I also got a hold of an OSX 10.10.5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.
Thanks,
John Sirois
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40391/#review106895
---
Ship it!
Ship It!
- John Sirois
On Nov. 17, 2015, 10:51 a.m
---
Eyeballed:
`markdown_py CONTRIBUTING.md > CONTRIBUTING.html && open CONTRIBUTING.html`
Thanks,
John Sirois
32
Thanks Joe.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39784/#review104483
---
On Oct. 29, 2015, 4:05
ill refresh this build result if you post a review containing
> > "@ReviewBot retry"
I need to dig in here, this is unexpected.
- John
---
This is an automatically generated e-mail. To reply, visi
If not mind removing it?
I'll kill it, its not a lie, but not particularaly useful.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39784/#review104484
-------
://reviews.apache.org/r/40299/ with another approach and this is it.
This is a take-it or leave it. It certainly could be see as obscuring if folks
are used to looking in pants.ini for a custom repos setup.
- John Sirois
On Nov. 14, 2015, 5:18 p.m., John Sirois wrote
> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote:
> > pants.ini, line 33
> > <https://reviews.apache.org/r/40299/diff/1/?file=1125123#file1125123line33>
> >
> > Seems worth a note this is only used by the vagrant provisioning ... or
> > add t
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
oleSummary();
}
...
```
Thanks,
John Sirois
---
Green: `./gradlew -Pq build`
Also confirmd `./gradlew idea` produced a project I could build from
within IDEA and debug tests with.
Thanks,
John Sirois
tForwarder(AnnotatedAuroraAdmin annotatedAuroraAdmin) {
this.annotatedAuroraAdmin = Objects.requireNonNull(annotatedAuroraAdmin);
}
@Override
public Response getRoleSummary() throws TException {
return this.annotatedAuroraAdmin.getRoleSummary();
}
...
```
Thanks,
John Sirois
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/40786/#review109183
---
On Dec. 7, 2015, 2:55 p.m., John Sirois wrote:
>
> ---
> This is an automatically ge
non-Optional and on the next line add the stopAsync as a tear down?
- John Sirois
On Dec. 16, 2015, 11:19 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41453/#review110739
---
Ship it!
Ship It!
- John Sirois
On Dec. 16, 2015, 12:53 p.m
will refresh this build result if you post a review containing "@ReviewBot
retry"
- John Sirois
On Dec. 11, 2015, 1:33 a.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To re
will refresh this build result if you post a review containing "@ReviewBot
retry"
- John Sirois
On Dec. 14, 2015, 10:36 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To re
will refresh this build result if you post a review containing "@ReviewBot
retry"
- John Sirois
On Nov. 25, 2015, 5 p.m., George Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
will refresh this build result if you post a review containing "@ReviewBot
retry"
- John Sirois
On Dec. 16, 2015, 7:15 a.m., Dmitriy Shirchenko wrote:
>
> ---
> This is an automatically generated e-mail. To re
/jenkins/build.sh`
Thanks,
John Sirois
6efe03fe4841cf1275e2ee0c7cc1b9576540f34e
Diff: https://reviews.apache.org/r/41528/diff/
Testing
---
Green locally: `./gradlew -Pq build`
Thanks,
John Sirois
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41521/#review111002
---
Ship it!
Ship It!
- John Sirois
On Dec. 17, 2015, 11:18 a.m
`
Thanks,
John Sirois
> On Nov. 15, 2015, 11:34 a.m., John Sirois wrote:
> > Brice - this would be nice to land. Are you able to put time towards the
> > cleanups suggested by Kevin and style fixes failing the build currently?
> > If so - great. If not, I can brush this up and send out a
sit:
https://reviews.apache.org/r/41528/#review111058
---
On Dec. 17, 2015, 2:27 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
://reviews.apache.org/r/41893/diff/
Testing
---
Not green locally due to ZK issues from
https://git1-us-west.apache.org/repos/asf/aurora/repo?p=aurora.git;a=commit;h=8706a781968912c68688284d9d3813d34ce45bf7,
but the CI script gets further on my machine with the junit
dep added
Thanks,
John Sirois
/build.sh` and
`./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` ran
green locally.
Thanks,
John Sirois
ure(NIOServerCnxnFactory.java:96)
at
org.apache.aurora.common.zookeeper.testing.ZooKeeperTestServer.startNetwork(ZooKeeperTestServer.java:81)
at
org.apache.aurora.common.zookeeper.testing.BaseZooKeeperTest.setUp(BaseZooKeeperTest.java:64)
...
```
Thanks,
John Sirois
it:
https://reviews.apache.org/r/41897/#review112679
---
On Jan. 4, 2016, 4:02 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
579d86cd2e02ea3e1a7add9cdd8291a6dc9669ec
Diff: https://reviews.apache.org/r/41899/diff/
Testing
---
Locally green:
```
./build-support/jenkins/build.sh &&
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
/BaseZooKeeperTest.java:import
org.junit.Before;
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java:import
org.junit.Rule;
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java:import
org.junit.rules.TemporaryFolder;
```
- John Sirois
On Jan. 4, 2016
> On Jan. 4, 2016, 4:17 p.m., Stephan Erb wrote:
> > News file needs updating too :-)
>
> John Sirois wrote:
> Good call - change coming as well as an updated reviews list.
Fixed.
- John
---
This is an automat
---
Not green locally due to ZK/krb interaction issues from
https://git1-us-west.apache.org/repos/asf/aurora/repo?p=aurora.git;a=commit;h=8706a781968912c68688284d9d3813d34ce45bf7,
but the CI script gets further on my machine with this fix.
Thanks,
John Sirois
gt; AssertionError
> > generated xml file:
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.thermos.observer.observer.xml
> >
> > [1m[31m=== 1 failed, 3 passed in 0.25 seconds
> > ===[
t RB.
- John Sirois
On Jan. 4, 2016, 4:04 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41894/
> -
ectly into the arg list,
> > e.g:'stop_event=threading.Event()'.
>
> John Sirois wrote:
> I'm leery of that for mutable objects like an Event. Surprising things
> happen if/when the containing object gets constructed a 2nd time and the
> single default Event has be
/ -- -kTaskObserverTest
done
```
After the change I cannot trigger the failure.
Thanks,
John Sirois
ectly into the arg list,
> > e.g:'stop_event=threading.Event()'.
>
> John Sirois wrote:
> I'm leery of that for mutable objects like an Event. Surprising things
> happen if/when the containing object gets constructed a 2nd time and the
> single default Event has been mu
> On Jan. 4, 2016, 8:05 p.m., John Sirois wrote:
> > Another answer could be to delete this test altogether. It looks like it
> > only really tests the proper converson from Time Amounts to fractional
> > second waits.
>
> Bill Farner wrote:
> I'm temp
/test/python/apache/thermos/observer/ -- -kTaskObserverTest
done
```
After the change I cannot trigger the failure.
Thanks,
John Sirois
efault Event has been mutated!
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41915/#review112750
-------
On Jan. 4, 2016, 8:02 p.m., John Sirois wrote:
>
> -
1 - 100 of 620 matches
Mail list logo
