`
Ran `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` successfully.
I will verify this patch on a live cluster as well before submitting.
Thanks,
Jordan Ly
; >
> > Maybe add a metric to track the unban-s?
> >
> > Do we really need to `unban` the offer before `cancelling` it? Can we
> > fold `unbanOffer` into the `cancelOffer` method?
>
> Jordan Ly wrote:
> Added metrics to check ba
test`
Ran `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` successfully.
I will verify this patch on a live cluster as well before submitting.
Thanks,
Jordan Ly
rc/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` successfully.
I will verify this patch on a live cluster as well before submitting.
Thanks,
Jordan Ly
/python/apache/aurora/client/cli/test_diff_formatter.py ..
== 175 passed in 26.42 seconds ===
```
I've also compiled it within the local cluster with Vagrant and used the
command to transfer a text file between the scheduler machine and job I created.
Thanks,
Jordan Ly
]
SUCCESS
```
I've also compiled it within the local cluster with Vagrant and used the
command to transfer a text file between the scheduler machine and job I created.
Thanks,
Jordan Ly
nt and used the
command to transfer a text file between the scheduler machine and job I created.
Thanks,
Jordan Ly
ler machine and job I created.
Thanks,
Jordan Ly
more log output.
> > ==
> >
> > BUILD FAILED
> >
> > Total time: 25 mins 14.098 secs
> >
> >
> > I will refresh this build result if you post a review conta
c-task-machine
Added!
- Jordan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174789
---
On May 14,
src/test/python/apache/aurora/client/cli/test_diff_formatter.py ..
== 175 passed in 26.42 seconds ===
```
I've also compiled it within the local cluster with Vagrant and used the
command to transfer a text file between the scheduler machine and job I created.
Thanks,
Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59733/#review177639
---
@ReviewBot retry
- Jordan Ly
On June 12, 2017, 6:37 a.m
f59ee1a0514a6dc52573c0b932cba755e0a10e18
Diff: https://reviews.apache.org/r/60173/diff/1/
Testing
---
Injected a custom module on a Vagrant box.
Unit + integration tests pass.
Thanks,
Jordan Ly
pass.
Thanks,
Jordan Ly
it:
https://reviews.apache.org/r/60173/#review178273
---
On June 19, 2017, 6:03 p.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
tp_example
/vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example.aurora
INFO] Creating job http_example
INFO] Checking status of devcluster/www-data/test/http_example
Job create succeeded: job
url=http://aurora.local:8081/scheduler/www-data/test/http_example
```
Thanks,
Jordan Ly
M_COMPARATOR TO this (in case two
machines have the same cpu/RAM amounts)?
- Jordan Ly
On May 23, 2017, 7:41 a.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
tically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59640/#review176371
-------
On May 30, 2017, 9:21 p.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
date, update & kill.
Thanks,
Jordan Ly
Diff: https://reviews.apache.org/r/59733/diff/1/
Testing
---
Ran unit and integration tests.
Created and killed jobs with varying wait_escalation_secs values on the Vagrant
devcluster.
Thanks,
Jordan Ly
ly, visit:
https://reviews.apache.org/r/59733/#review176705
-------
On June 1, 2017, 11:48 p.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail.
even though
the test didn't really
care.
Tested different update configurations on the Vagrant cluster: only adding
instances, only updating
instances, only killing instances, create & update, update & kill.
Thanks,
Jordan Ly
Thanks,
Jordan Ly
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59733/#review176802
---
On June 1, 2017, 11:48 p.m., Jordan Ly wrote:
>
> ---
/main/java/org/apache/aurora/scheduler/offers/OffersModule.java
Lines 121-123 (patched)
<https://reviews.apache.org/r/59698/#comment250072>
Maybe move to configure
- Jordan Ly
On June 1, 2017, 12:14 a.m., David McLaughlin
/org/apache/aurora/scheduler/events/Webhook.java
Lines 111-113 (patched)
<https://reviews.apache.org/r/59703/#comment250082>
What are the implications of a task failing to change?
- Jordan Ly
On June 1, 2017, 6:33 a.m., David McLaughlin
devcluster.
Thanks,
Jordan Ly
- Jordan Ly
On June 7, 2017, 1:06 a.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59733/
> ---
>
my one?
- Jordan Ly
On June 7, 2017, 10:24 p.m., Reza Motamedi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59864/
>
/
Changes: https://reviews.apache.org/r/59733/diff/4-5/
Testing
---
Ran unit and integration tests.
Created and killed jobs with varying wait_escalation_secs values on the Vagrant
devcluster.
Thanks,
Jordan Ly
1b92667bceabc8ea1540122477a51cb58ea2ae36
Diff: https://reviews.apache.org/r/59733/diff/6/
Changes: https://reviews.apache.org/r/59733/diff/5-6/
Testing
---
Ran unit and integration tests.
Created and killed jobs with varying wait_escalation_secs values on the Vagrant
devcluster.
Thanks,
Jordan Ly
the configurations.
I will update this ticket in a few days with the changes. Please do not merge
yet :)
- Jordan Ly
On June 7, 2017, 1:06 a.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
jobs with varying wait_escalation_secs values on the Vagrant
devcluster.
Thanks,
Jordan Ly
://reviews.apache.org/r/59733/diff/3/
Changes: https://reviews.apache.org/r/59733/diff/2-3/
Testing
---
Ran unit and integration tests.
Created and killed jobs with varying wait_escalation_secs values on the Vagrant
devcluster.
Thanks,
Jordan Ly
nt waiting
5-10 minutes to response -- does not seem to block scheduling.
Thanks,
Jordan Ly
or being flaky?
- Jordan Ly
On Oct. 10, 2017, 8:35 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
se of this?
src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java
Lines 72-73 (patched)
<https://reviews.apache.org/r/62869/#comment265199>
Should this be configurable?
- Jordan Ly
On Oct. 10, 2017, 7:35
end to end test and testing on a live cluster.
Thanks,
Jordan Ly
s that already exist but
you are trying to add them".
- Jordan Ly
On Sept. 27, 2017, 12:10 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> htt
ing
---
No unit tests specified.
./gradlew test
Thanks,
Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62621/#review186446
---
@ReviewBot retry
- Jordan Ly
On Sept. 27, 2017, 5:25 p.m
sts specified.
./gradlew test
Thanks,
Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62620/#review186443
---
Ship it!
Ship It!
- Jordan Ly
On Sept. 27, 2017, 4:06 p.m
://reviews.apache.org/r/62626/diff/1/
Testing
---
Added an additional unit test for prepare() failing in
`SchedulerLifecycle.java`.
./gradlew test
./build-support/jenkin/build.sh
Thanks,
Jordan Ly
ontrol. Followers should
just be able to use `shutdown()`.
- Jordan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62626/#review186473
--------
est
Thanks,
Jordan Ly
functionality it gives out of the box for us right now vs. how many custom
parsers we will have to write.
- Jordan Ly
On Sept. 28, 2017, 4:22 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62601/#review186734
---
Ship it!
Ship It!
- Jordan Ly
On Sept. 27, 2017, 12:20 a.m
WebhookTest.java
07f39fa487e0ebd2252568750d5f36ac200a96aa
Diff: https://reviews.apache.org/r/62700/diff/1/
Testing
---
./gradlew test
Tested proper shutdown occurs in Vagrant.
Currently scale-testing over the weekend.
Thanks,
Jordan Ly
re how it works).
- Jordan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62626/#review186488
---
On Sept. 27, 2017, 8:25 p.m.,
proper shutdown occurs in Vagrant.
Scale tested up to 2000 TASK_LOST events with the registered endpoint waiting
5-10 minutes to response -- does not seem to block scheduling.
Thanks,
Jordan Ly
his is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62700/#review186975
-------
On Oct. 3, 2017, 5:01 p.m., Jordan Ly wrote:
>
> ---
> T
`
Ran `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` successfully.
I will verify this patch on a live cluster as well before submitting.
Thanks,
Jordan Ly
submitting.
Thanks,
Jordan Ly
5697d2e2eb001042511924442ff2dbe358451642
Diff: https://reviews.apache.org/r/61918/diff/1/
Testing
---
Unit tests pass.
Currently running end to end test and testing on a live cluster.
Thanks,
Jordan Ly
eviews.apache.org/r/61918/#review184005
---
On Aug. 25, 2017, 8:31 p.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61918/
> -
/sh/org/apache/aurora/e2e/test_end_to_end.sh` successfully.
I will verify this patch on a live cluster as well before submitting.
Thanks,
Jordan Ly
and testing on a live cluster.
Thanks,
Jordan Ly
duling.
Thanks,
Jordan Ly
g/r/62700/diff/6/
Changes: https://reviews.apache.org/r/62700/diff/5-6/
Testing
---
./gradlew test
Tested proper shutdown occurs in Vagrant.
Scale tested up to 2000 TASK_LOST events with the registered endpoint waiting
5-10 minutes to response -- does not seem to block scheduling.
Thanks,
Jordan Ly
---
On Oct. 12, 2017, 11:18 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62956/
> ---
>
>
t; manually churn the cluster to free up space. Wonder how the 30 day filter
> > would behave in such a case. Having said that, we should make this
> > configurable with a resonable default (few hrs)?
>
> Jordan Ly wrote:
> I believe that the filter only works against a speci
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63099/#review188515
---
Ship it!
Ship It!
- Jordan Ly
On Oct. 18, 2017, 4:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62956/#review188588
---
Ship it!
Ship It!
- Jordan Ly
On Oct. 18, 2017, 9:25 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62652/#review188603
---
Ship it!
Ship It!
- Jordan Ly
On Oct. 8, 2017, 5:29 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62652/#review188601
---
Ship it!
Ship It!
- Jordan Ly
On Oct. 8, 2017, 5:29 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62652/#review188605
---
Ship it!
Ship It!
- Jordan Ly
On Oct. 8, 2017, 5:29 p.m
andler`.
- Jordan Ly
On Oct. 19, 2017, 8:23 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63157/
>
given agent and if so decline both.
- Jordan Ly
On Oct. 19, 2017, 8:23 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/metadata/NearestFitTest.java
e170d626e74eda07fbb026e49a5e6a78ec976bd9
Diff: https://reviews.apache.org/r/63236/diff/1/
Testing
---
`./gradlew test`
Thanks,
Jordan Ly
ed so dramatically -- I will
look into that while testing as well.
Thanks,
Jordan Ly
```
Not exactly sure why `FillClusterBenchmark` increased so dramatically -- I will
look into that while testing as well.
Thanks,
Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63973/#review191918
---
On Nov. 27, 2017, 7:41 p.m., Jordan Ly wrote:
>
>
`
Not exactly sure why `FillClusterBenchmark` increased so dramatically -- I will
look into that while testing as well.
Thanks,
Jordan Ly
src/test/java/org/apache/aurora/scheduler/stats/AsyncStatsModuleTest.java
dfcbb4ad0a91fa70b99dd13ae5ad04c7c25af44c
Diff: https://reviews.apache.org/r/64190/diff/1/
Testing
---
`./gradlew test`
Thanks,
Jordan Ly
-
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64126/
> ---
>
> (Updated Nov. 29, 2017, 1:40 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Jorda
ps://reviews.apache.org/r/64234/#comment270551>
Same with this comment referring to "log". There are a few other mentions
of log within this class we might want to get rid of.
- Jordan Ly
On Dec. 1, 2017, 12:32 a.m., Bill Farner wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63973/#review191940
---
@ReviewBot retry
- Jordan Ly
On Nov. 27, 2017, 7:41 p.m
1080.267 ±74.635 ops/s
SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark
thrpt 10 11604.642 ± 586.248 ops/s
```
Not exactly sure why `FillClusterBenchmark` increased so dramatically -- I will
look into that while testing as well.
Thanks,
Jordan Ly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63973/#review191984
---
@ReviewBot retry
- Jordan Ly
On Nov. 27, 2017, 7:41 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64523/#review193595
---
@ReviewBot retry
- Jordan Ly
On Dec. 12, 2017, 7:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64523/#review193610
---
@ReviewBot retry
- Jordan Ly
On Dec. 12, 2017, 7:15 p.m
rowable t) {
> > +try {
> > + Thread.sleep(1000);
> > +} catch (InterruptedException e) {
> > +}
> > errorsCounter.incrementAndGet();
> > LOG.error("Error sending a Webhook event", t);
> > ```
> >
> > If i
t;
> (Updated Dec. 14, 2017, 10:05 p.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> This tool was originally intended as a migration path between Persistenc
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64629/#review193946
---
Ship it!
Ship It!
- Jordan Ly
On Dec. 14, 2017, 11:09 p.m
> On Dec. 14, 2017, 2:07 a.m., Jordan Ly wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
> > Line 88 (original), 90 (patched)
> > <https://reviews.apache.org/r/64286/diff/3/?file=1914592#file1914592line90>
> >
&g
rc/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java
Lines 100 (patched)
<https://reviews.apache.org/r/64286/#comment272393>
Do we need to map edit -> op?
- Jordan Ly
On Dec.
and the unknown cause of the actual errors. Maybe we run the
reviewbot on this repo repeatedly? Obviously not the most scientifically sound
solution.
EDIT 12/12: I tested this by putting a long sleep in `onThrowable` which causes
the issue in master and is fixed with this patch.
Thanks,
Jordan
? I believe they
are only used in DB stores.
- Jordan Ly
On Nov. 11, 2017, 4:53 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/MesosCallbackHandlerTest.java
8f8b86dfb5d53439671ca59e6c42245b31fc6136
Diff: https://reviews.apache.org/r/63763/diff/2/
Changes: https://reviews.apache.org/r/63763/diff/1-2/
Testing
---
`./gradlew test`
Thanks,
Jordan Ly
> >
> > Can we get away with `MoreExecutors.directExecutor()` instead?
>
> Jordan Ly wrote:
> I don't believe so. This test depends on a delay between `execute(...)`
> and the runnable being executed. Is there some way to control when
> `directExecutor()` executes actions (ie.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63760/#review190844
---
Ship it!
Nice fix!
- Jordan Ly
On Nov. 13, 2017, 4:32 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63743/#review190845
---
Ship it!
Ship It!
- Jordan Ly
On Nov. 11, 2017, 4:53 a.m
://reviews.apache.org/r/63763/diff/1/
Testing
---
`./gradlew test`
Thanks,
Jordan Ly
into that while testing as well.
Thanks,
Jordan Ly
ng something from the original issue.
I was looking at this patch as context: https://reviews.apache.org/r/53918/
- Jordan Ly
On Nov. 21, 2017, 3:40 a.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-
---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63536/
> -----------
>
> (Updated Nov. 21, 2017, 6:42 p.m.)
>
>
> Review request for A
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64015/#review191692
---
Ship it!
Ship It!
- Jordan Ly
On Nov. 22, 2017, 1:07 a.m
he default 0 on `PartitionPolicy` is sufficient.
- Jordan Ly
On Nov. 16, 2017, 1:54 a.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
te actions not immediately)?
- Jordan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63763/#review190886
---
On No
1 - 100 of 220 matches
Mail list logo
