it:
https://reviews.apache.org/r/16528/#review31389
---
On Jan. 13, 2014, 7:32 p.m., Suman Karumuri wrote:
>
> ---
> This is an automatically generated e-mail. To rep
https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
Thanks,
Suman Karumuri
5line26>
> >
> > Looks like leftover testing code. Please remove.
I left the mocks intentionally so I can use it in the stand alone UI. Removed
it now.
- Suman
---
This is an automatically generated e-mail. To
-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
Thanks,
Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16740/#review31785
---
Ship it!
Ship It!
- Suman Karumuri
On Jan. 13, 2014, 11:54 p.m
checks inside the scheduler may be a better way to
implement this.
PS: I may have understood this entirely wrong, if so, please feel free to
ignore this.
- Suman Karumuri
On Jan. 8, 2014, 12:45 a.m., Kevin Sweeney wrote:
>
> ---
ervlet code is removed.
- Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31685
---
On Jan. 13, 2014, 11:58 p.m., Suman Karumuri wr
/
Testing
---
gradle clean build
Tested the UI using the isolated scheduler.
File Attachments
Home page
https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
Thanks,
Suman Karumuri
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31922
---
On Jan. 15, 2014, 7:08 a.m., Suman Karumuri wrote:
>
> ---
>
hould actually be removed as well
>
> Suman Karumuri wrote:
> Looks like our style settings need to be tweaked after the org.apache
> rename. Removed.
>
> Bill Farner wrote:
> You gave a ship-it on the review [1] where i globally fixed and explained
> this :-)
>
&g
To reply, visit:
> https://reviews.apache.org/r/16995/
> ---
>
> (Updated Jan. 16, 2014, 11 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Suman Karumuri.
>
>
> Bugs: AURORA-45
> https://issues.apache.org/ji
it:
https://reviews.apache.org/r/16528/#review31967
---
On Jan. 15, 2014, 7:08 a.m., Suman Karumuri wrote:
>
> ---
> This is an automatically generated e
,
Suman Karumuri
16f22a700abb7ba51559e3cfbb04d9218bf4f98a
Diff: https://reviews.apache.org/r/17014/diff/
Testing
---
gradle clean build.
Tested with local scheduler. Scheduler shows an error message (ex: when storage
is not ready)
Thanks,
Suman Karumuri
Description
---
Added docs about git setup.
Diffs
-
docs/contributing.md d337da2be9b182a0c872574c3587d414c566331b
Diff: https://reviews.apache.org/r/17068/diff/
Testing
---
Thanks,
Suman Karumuri
,
Suman Karumuri
ment61165>
inline this variable?
src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java
<https://reviews.apache.org/r/17131/#comment61166>
Would it be better if these comments are changed to JavaDoc comments?
- Suman Karumuri
On Jan. 20, 2014, 9:01 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17133/#review32369
---
Ship it!
Looks good!
- Suman Karumuri
On Jan. 20, 2014, 10:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16995/#review32372
---
Ship it!
Ship It!
- Suman Karumuri
On Jan. 20, 2014, 10:24 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17095/#review32373
---
Ship it!
Ship It!
- Suman Karumuri
On Jan. 18, 2014, 9:01 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17068/#review32236
---
On Jan. 17, 2014, 11:40 p.m., Suman Karumuri wrote:
>
> -
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17068/#review32232
---
On Jan. 17, 2014, 11:40 p.m., Suman Karumuri wrote:
>
> ---
and Bill Farner.
Repository: aurora
Description
---
Added docs about git setup.
Diffs (updated)
-
docs/contributing.md d337da2be9b182a0c872574c3587d414c566331b
Diff: https://reviews.apache.org/r/17068/diff/
Testing
---
Thanks,
Suman Karumuri
16f22a700abb7ba51559e3cfbb04d9218bf4f98a
Diff: https://reviews.apache.org/r/17014/diff/
Testing
---
gradle clean build.
Tested with local scheduler. Scheduler shows an error message (ex: when storage
is not ready)
Thanks,
Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17014/#review32442
---
ping.
- Suman Karumuri
On Jan. 21, 2014, 9:28 p.m., Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17131/#review32516
---
Ship it!
Ship It!
- Suman Karumuri
On Jan. 20, 2014, 9:01 p.m
16f22a700abb7ba51559e3cfbb04d9218bf4f98a
Diff: https://reviews.apache.org/r/17014/diff/
Testing
---
gradle clean build.
Tested with local scheduler. Scheduler shows an error message (ex: when storage
is not ready)
Thanks,
Suman Karumuri
ssage from the
thrift end point. Showing the message now.
- Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17014/#review32444
-------
-a0c4-feb81ee260f4__Screen_Shot_2014-01-22_at_10.49.57_AM.png
Thanks,
Suman Karumuri
86220ff1ef42c892c10d4d9f174552e113a32e13
src/test/resources/org/apache/aurora/gen/api.thrift.md5
fd64486908839ede8a326aa0603f16ce677d7eb8
Diff: https://reviews.apache.org/r/17205/diff/
Testing
---
gradle clean build
gradle run to test with local UI.
Thanks,
Suman Karumuri
.
Thanks,
Suman Karumuri
t this diff since I am blocked on
these changes.
- Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17205/#review32638
---
On Jan. 22
test local UI.
Thanks,
Suman Karumuri
ct.
Agreed.
- Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17303/#review32720
---
On Jan. 24, 2014, 7:13
42fdca2759f15d007bee058485c237268c57597a
Diff: https://reviews.apache.org/r/17347/diff/
Testing
---
gradle clean build.
Thanks,
Suman Karumuri
6cefdfad469a9b69a5291ad46be1df14b443472e
Diff: https://reviews.apache.org/r/17430/diff/
Testing
---
gradle clean build
gradle run - tested in local UI.
Thanks,
Suman Karumuri
run - tested in local UI.
Thanks,
Suman Karumuri
view32947
---
On Jan. 28, 2014, 8:51 p.m., Suman Karumuri wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
test reproduce the bug? I would have expected to see
> > something like two tasks in the same job resulting in a job count of 1.
Good catch. I added the task, but it got lost among other fixes. Fixed it now.
- Suman
---
This
/resources/org/apache/aurora/gen/api.thrift.md5
42fdca2759f15d007bee058485c237268c57597a
Diff: https://reviews.apache.org/r/17430/diff/
Testing
---
gradle clean build
gradle run - tested in local UI.
Thanks,
Suman Karumuri
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17430/#review33041
-------
On Jan. 28, 2014, 10:17 p.m., Suman Karumuri wrote:
>
> --
---
gradle clean build.
gradle run.
Thanks,
Suman Karumuri
://reviews.apache.org/r/17562/diff/
Testing
---
gradle clean build.
gradle run.
Thanks,
Suman Karumuri
ra/gen/api.thrift
> 94569f9abfb56c50e67e09cc018484463f9de427
>
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
> 02b7a27e0a9ec5226d9d043de8bf4739fb151b09
> src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java
> 644d6e87f5ed44d2705ebbcc6619a727d52c03d8
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java
> 62fc8045f6a5fda234df73452685bd04e3142aaf
> src/test/resources/org/apache/aurora/gen/api.thrift.md5
> e88d29732ee8652ede6c7ee13513122086385646
>
> Diff: https://reviews.apache.org/r/17562/diff/
>
>
> Testing
> ---
>
> gradle clean build.
> gradle run.
>
>
> Thanks,
>
> Suman Karumuri
>
>
> On Jan. 31, 2014, 12:56 a.m., Kevin Sweeney wrote:
> >
>
> Suman Karumuri wrote:
> Spoke to Bill before making these changes. We decided to use getInfo API
> and deprecate getAPIVersion. The getInfo will return with the clusterName and
> APIVersion for now.
e88d29732ee8652ede6c7ee13513122086385646
Diff: https://reviews.apache.org/r/17562/diff/
Testing
---
gradle clean build.
gradle run.
Thanks,
Suman Karumuri
/17715/diff/
Testing
---
gradle clean build
gradle run
Thanks,
Suman Karumuri
ve, it would be nice to leave a TODO here.
- Suman Karumuri
On Feb. 4, 2014, 6:41 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
Cool. Thanks!
On Tue, Feb 4, 2014 at 12:37 PM, Bill Farner wrote:
>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17672/
>
> On February 4th, 2014, 7:22 p.m. UTC, *Suman Karumuri* wrote:
>
> The logic is much cleaner now.
>
0abd3e737e901f08d18c3ceb55ea2f94847cc2e1
Diff: https://reviews.apache.org/r/17730/diff/
Testing
---
gradle clean build.
gradle run with fake summary data.
Thanks,
Suman Karumuri
On Feb. 5, 2014, 1:38 a.m., Suman Karumuri wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17730/
> --
/http/ui/js/controllers.js
0abd3e737e901f08d18c3ceb55ea2f94847cc2e1
Diff: https://reviews.apache.org/r/17730/diff/
Testing
---
gradle clean build.
gradle run with fake summary data.
Thanks,
Suman Karumuri
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17730/#review33719
---
On Feb. 5, 2014, 7:14 a.m., Suman Karumuri wrote:
>
> --
0abd3e737e901f08d18c3ceb55ea2f94847cc2e1
Diff: https://reviews.apache.org/r/17730/diff/
Testing
---
gradle clean build.
gradle run with fake summary data.
Thanks,
Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17823/#review33910
---
+1
- Suman Karumuri
On Feb. 6, 2014, 11:52 p.m., Kevin Sweeney
,
Suman Karumuri
is not logged by the library. I prefer to have this since it provides
visibility into the logic mentioned in the previous comment.
- Suman Karumuri
On Feb. 12, 2014, 11:26 p.m., Suman Karumuri wrote:
>
> ---
> This is an automatica
/scheduler/http/ServletModule.java
ba37e26bba4e1ad4c546e73748182deb2d5942a7
Diff: https://reviews.apache.org/r/18036/diff/
Testing
---
gradle clean build
tested on localhost, verified behavior via log statements.
Thanks,
Suman Karumuri
> On Feb. 13, 2014, 6:29 p.m., Suman Karumuri wrote:
> > src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java, line
> > 40
> > <https://reviews.apache.org/r/18036/diff/1/?file=483735#file483735line40>
> >
> > It is not logged by the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18157/#review34897
---
Ship it!
Ship It!
- Suman Karumuri
On Feb. 18, 2014, 7:26 p.m
Diff: https://reviews.apache.org/r/18300/diff/
Testing
---
gradle clean build.
rm /tmp/testing_log_file && gradle run
Thanks,
Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18297/#review35046
---
Ship it!
Ship It!
- Suman Karumuri
On Feb. 20, 2014, 6:41 p.m
/AopModuleTest.java
d93ac53ec15863f2ee0e0ebc4737d8f4f8e4be9d
src/test/resources/org/apache/aurora/gen/api.thrift.md5
10f5cdab16230e66ac7c9fab199e2dd2564248da
Diff: https://reviews.apache.org/r/17562/diff/
Testing
---
gradle clean build.
gradle run.
Thanks,
Suman Karumuri
ut that?
Done.
- Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17562/#review33635
---
On Feb. 20, 2014, 9:53 p.m., Sum
clean build
gradle run and tested on my laptop
Thanks,
Suman Karumuri
/diff/
Testing
---
gradle clean build.
gradle run.
Thanks,
Suman Karumuri
he cluster name string is bound, annotated with @ClusterName, so you
> > can avoid the plumbing and just:
> >
> > @Inject
> > @ClusterName
> > private String clusterName;
> >
> > In the target classes.
/aurora/gen/api.thrift.md5
fafb5100443482e662db453429c5259f2ab80ae5
Diff: https://reviews.apache.org/r/17562/diff/
Testing
---
gradle clean build.
gradle run.
Thanks,
Suman Karumuri
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17303/#review33465
---
On Jan. 24, 2014, 7:13 a.m., Suman Karumuri wrote:
/aurora/gen/api.thrift
> 74010379baa2e47cefc228943f766c7b3a8b0d97
> src/test/java/org/apache/aurora/scheduler/base/JobsTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/SchedulerzRoleTest.java
> 912be189583419e7201e45650d18cd24a6a5a35b
>
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
> 6cefdfad469a9b69a5291ad46be1df14b443472e
> src/test/resources/org/apache/aurora/gen/api.thrift.md5
> 42fdca2759f15d007bee058485c237268c57597a
>
> Diff: https://reviews.apache.org/r/17303/diff/
>
>
> Testing
> ---
>
> gradle clean build
> gradle run to test local UI.
>
>
> Thanks,
>
> Suman Karumuri
>
>
/ForwardingThrift.java
1edc0d7b224cc477ea6e8873e76ee8c70c6b4d50
src/test/resources/org/apache/aurora/gen/api.thrift.md5
fafb5100443482e662db453429c5259f2ab80ae5
Diff: https://reviews.apache.org/r/17303/diff/
Testing
---
gradle clean build
gradle run to test local UI.
Thanks,
Suman Karumuri
fafb5100443482e662db453429c5259f2ab80ae5
Diff: https://reviews.apache.org/r/17303/diff/
Testing
---
gradle clean build
gradle run to test local UI.
Thanks,
Suman Karumuri
/quotas end points.
Will run end to end test tonight.
Thanks,
Suman Karumuri
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347/#review32946
---
On Jan. 25, 2014, 12:48 a.m., Suman Karumuri wrote:
>
>
with the wire format test Kevin.
Please let me know if you would like to see any other testing.
- Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18546/#review35590
---
/test_diff.py
339459e2f563083ddbf01cadd4e938970d6ea388
Diff: https://reviews.apache.org/r/18598/diff/
Testing
---
./build-support/jenkins/build.sh runs successfully
Thanks,
Suman Karumuri
urned out to be an environment issue. Also,
fixed existing bug AURORA-101, that addresses this.
- Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18546/#review35718
://reviews.apache.org/r/18546/diff/
Testing
---
Successfully ran:
gradle clean build && ./pants src/test/python/apache/aurora/client:all
On a local scheduler tested /scheduler* and /quotas end points.
Will run end to end test tonight.
Thanks,
Suman Karumuri
5>
> >
> > s/quota/ResourceAggregate
Done.
- Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18546/#review35751
-------
://reviews.apache.org/r/18546/diff/
Testing
---
Successfully ran:
gradle clean build && ./pants src/test/python/apache/aurora/client:all
On a local scheduler tested /scheduler* and /quotas end points.
Will run end to end test tonight.
Thanks,
Suman Karumuri
ift/SchedulerThriftInterfaceTest.java
dc557718269064a202c3e4eb1272ff2b9f209ad9
src/test/resources/org/apache/aurora/gen/api.thrift.md5
4e6c51d9298bf6fc1935ec9080f38726f79e7959
Diff: https://reviews.apache.org/r/17347/diff/
Testing (updated)
---
./gradlew clean build.
Thanks,
Suman Karumuri
run to test local UI.
Thanks,
Suman Karumuri
arate test case, but didn't like to break the convention of one test
case per thrift call that is set in the file just for one test case. So,
leaving it as is.
> On Feb. 28, 2014, 8:21 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java, li
tps://reviews.apache.org/r/17347/#review35871
-------
On Feb. 28, 2014, 11:32 p.m., Suman Karumuri wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17347/
> -
dc557718269064a202c3e4eb1272ff2b9f209ad9
src/test/resources/org/apache/aurora/gen/api.thrift.md5
4e6c51d9298bf6fc1935ec9080f38726f79e7959
Diff: https://reviews.apache.org/r/17347/diff/
Testing
---
./gradlew clean build.
Thanks,
Suman Karumuri
src/test/resources/org/apache/aurora/gen/api.thrift.md5
08c4c2a4717a1c827f4cef6405d78e7db5046a00
Diff: https://reviews.apache.org/r/17347/diff/
Testing
---
./gradlew clean build.
Thanks,
Suman Karumuri
src/test/python/apache/aurora/client/api/test_quota_check.py
4dff351ef031d9cdfadbcea5666f4e995a89cce2
Diff: https://reviews.apache.org/r/17347/diff/
Testing
---
./gradlew clean build.
Thanks,
Suman Karumuri
/HistoryPrunerTest.java
<https://reviews.apache.org/r/18484/#comment67332>
This function can be replaced by Tasks.SCHEDULED_TO_JOB_KEY
- Suman Karumuri
On Feb. 25, 2014, 10:25 p.m., Bill Farner wrote:
>
> ---
> This is a
-
>
> (Updated March 3, 2014, 11:35 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Suman Karumuri.
>
>
> Bugs: AURORA-221
> https://issues.apache.org/jira/browse/AURORA-221
>
>
> Repository: aurora
>
>
> Description
> ---
&
w35907
---
On March 1, 2014, 1:27 a.m., Kevin Sweeney wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18658/
> -
mail. To reply, visit:
> https://reviews.apache.org/r/18713/
> ---
>
> (Updated March 3, 2014, 11:31 p.m.)
>
>
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
&g
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17562/#review35447
---
On Feb. 25, 2014, 1:22 a.m., Suman Karumuri wrote:
&g
/org/apache/aurora/gen/api.thrift.md5
5cfa330f54c0297c84b8f41ee550a7bc6f163010
Diff: https://reviews.apache.org/r/17562/diff/
Testing
---
gradle clean build.
gradle run.
Thanks,
Suman Karumuri
faceTest.java,
> > line 1004
> > <https://reviews.apache.org/r/17303/diff/3/?file=507571#file507571line1004>
> >
> > It would be really nice to see all of these assertEquals looking more
> > like:
> >
> > assertEquals(expected, actual);
>
build
gradle run to test local UI.
Thanks,
Suman Karumuri
diff/4/?file=514596#file514596line57>
> >
> > Always default to immutable.
> >
> > ImmutableList.of()
> >
> >
Changed.
- Suman
---
This is an automatically generat
build
gradle run to test local UI.
Thanks,
Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18935/#review36817
---
Ship it!
Ship It!
- Suman Karumuri
On March 11, 2014, 12:09 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18713/#review36890
---
Ship it!
Ship It!
- Suman Karumuri
On March 12, 2014, 1:26 a.m
job stats
https://reviews.apache.org/media/uploaded/files/2014/03/17/65da4a77-4c82-46f8-93d1-34fd319ef60e__Screen_Shot_2014-03-17_at_3.13.36_PM.png
Thanks,
Suman Karumuri
1 - 100 of 273 matches
Mail list logo
