jiajunwang closed issue #402: Implement the WAGED rebalancer
URL: https://github.com/apache/helix/issues/402
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jiajunwang closed issue #508: The WAGED rebalancer should fail the cluster
model creating if resource usage config is invalid
URL: https://github.com/apache/helix/issues/508
This is an automated message from the Apache Git
jiajunwang opened a new pull request #520: Refactoring soft constraints to
simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520
### Issues
- [ ] My PR addresses the following Helix issues and references them in the
PR description:
#518
jiajunwang commented on issue #514: The WAGED rebalancer returns the previously
calculated assignment on calculation failure
URL: https://github.com/apache/helix/pull/514#issuecomment-545176981
This PR is ready to be merged, approved by @pkuwm
pkuwm opened a new issue #524: Add waged rebalancer metrics
URL: https://github.com/apache/helix/issues/524
Implement monitoring mbeans for the WAGES rebalancer.
To implement:
GlobalBaselineCalcCounter: Counter of the global rebalance.
PartialRebalanceCounter: Counter of the
pkuwm opened a new pull request #525: Add waged rebalancer monitoring mbean
metrics
URL: https://github.com/apache/helix/pull/525
### Issues
- [x] My PR addresses the following Helix issues and references them in the
PR title:
#524 Implementation.
### Description
jiajunwang merged pull request #514: The WAGED rebalancer returns the
previously calculated assignment on calculation failure
URL: https://github.com/apache/helix/pull/514
This is an automated message from the Apache Git
narendly opened a new pull request #523: Add a null check for StateModel in
Participant reset logic
URL: https://github.com/apache/helix/pull/523
### Issues
- [ ] My PR addresses the following Helix issues and references them in the
PR description:
Fixes #522
###
narendly commented on a change in pull request #514: The WAGED rebalancer
returns the previously calculated assignment on calculation failure
URL: https://github.com/apache/helix/pull/514#discussion_r337647686
##
File path:
narendly commented on a change in pull request #514: The WAGED rebalancer
returns the previously calculated assignment on calculation failure
URL: https://github.com/apache/helix/pull/514#discussion_r337648476
##
File path:
narendly commented on a change in pull request #514: The WAGED rebalancer
returns the previously calculated assignment on calculation failure
URL: https://github.com/apache/helix/pull/514#discussion_r337648672
##
File path:
narendly opened a new issue #522: Fix NPE in Participant's reset()
URL: https://github.com/apache/helix/issues/522
We noticed that an NPE is possible in the reset logic. Need to fix this.
This is an automated message from the
jiajunwang commented on a change in pull request #523: Add a null check for
StateModel in Participant reset logic
URL: https://github.com/apache/helix/pull/523#discussion_r337681279
##
File path:
helix-core/src/main/java/org/apache/helix/participant/HelixStateMachineEngine.java
jiajunwang commented on a change in pull request #514: The WAGED rebalancer
returns the previously calculated assignment on calculation failure
URL: https://github.com/apache/helix/pull/514#discussion_r337712534
##
File path:
jiajunwang commented on a change in pull request #514: The WAGED rebalancer
returns the previously calculated assignment on calculation failure
URL: https://github.com/apache/helix/pull/514#discussion_r337713013
##
File path:
pkuwm opened a new issue #521: Upgrade testng to fix unit test bugs
URL: https://github.com/apache/helix/issues/521
Found a bug for assertEquals(map1, map2). When map1 is empty and map2 is
not, assertEquals(map1, map2) could pass, which is supposed to fail.
Current testng version
narendly merged pull request #523: Add a null check for StateModel in
Participant reset logic
URL: https://github.com/apache/helix/pull/523
This is an automated message from the Apache Git Service.
To respond to the
narendly commented on issue #523: Add a null check for StateModel in
Participant reset logic
URL: https://github.com/apache/helix/pull/523#issuecomment-545093828
This PR is ready to be merged, approved by @dasahcc
This is
jiajunwang commented on a change in pull request #514: The WAGED rebalancer
returns the previously calculated assignment on calculation failure
URL: https://github.com/apache/helix/pull/514#discussion_r337717535
##
File path:
narendly commented on a change in pull request #517: Add typoed name
DataPropagationLatencyGuage as deprecated
URL: https://github.com/apache/helix/pull/517#discussion_r337793669
##
File path:
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ZkClientPathMonitor.java
narendly commented on a change in pull request #517: Add typoed name
DataPropagationLatencyGuage as deprecated
URL: https://github.com/apache/helix/pull/517#discussion_r337793818
##
File path:
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ZkClientPathMonitor.java
jiajunwang commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337794200
##
File path:
helix-core/src/main/java/org/apache/helix/monitoring/metrics/model/RatioMetric.java
##
jiajunwang commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337791937
##
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
jiajunwang commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337790772
##
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
jiajunwang commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337791411
##
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
jiajunwang commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337792566
##
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
narendly commented on a change in pull request #519: Refine the rebalance scope
calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r337798905
##
File path:
narendly commented on a change in pull request #519: Refine the rebalance scope
calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r337799390
##
File path:
narendly commented on a change in pull request #514: The WAGED rebalancer
returns the previously calculated assignment on calculation failure
URL: https://github.com/apache/helix/pull/514#discussion_r337778444
##
File path:
jiajunwang commented on a change in pull request #514: The WAGED rebalancer
returns the previously calculated assignment on calculation failure
URL: https://github.com/apache/helix/pull/514#discussion_r337782455
##
File path:
i3wangyi closed pull request #501: Fix the type reference issue
URL: https://github.com/apache/helix/pull/501
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
narendly commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337804645
##
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
narendly commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337804770
##
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
narendly commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337806648
##
File path:
narendly commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337806098
##
File path:
helix-core/src/main/java/org/apache/helix/monitoring/metrics/model/RatioMetric.java
##
@@
narendly commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337805217
##
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
narendly commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337806154
##
File path:
pkuwm commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337808702
##
File path:
helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/TestWagedRebalancerMetrics.java
pkuwm commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337807970
##
File path:
pkuwm commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337808633
##
File path:
helix-core/src/main/java/org/apache/helix/monitoring/metrics/model/RatioMetric.java
##
@@
narendly commented on a change in pull request #516: Implement the
propertyStore read endpoint
URL: https://github.com/apache/helix/pull/516#discussion_r337794497
##
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java
narendly commented on a change in pull request #516: Implement the
propertyStore read endpoint
URL: https://github.com/apache/helix/pull/516#discussion_r337795388
##
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java
narendly commented on a change in pull request #516: Implement the
propertyStore read endpoint
URL: https://github.com/apache/helix/pull/516#discussion_r337796780
##
File path:
helix-rest/src/test/java/org/apache/helix/rest/server/TestPropertyStoreAccessor.java
##
@@
narendly commented on a change in pull request #516: Implement the
propertyStore read endpoint
URL: https://github.com/apache/helix/pull/516#discussion_r337795061
##
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java
narendly commented on a change in pull request #519: Refine the rebalance scope
calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r337804026
##
File path:
narendly commented on a change in pull request #519: Refine the rebalance scope
calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r337800360
##
File path:
narendly commented on a change in pull request #519: Refine the rebalance scope
calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r337799033
##
File path:
narendly commented on a change in pull request #519: Refine the rebalance scope
calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r337799928
##
File path:
narendly commented on a change in pull request #519: Refine the rebalance scope
calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r337798058
##
File path:
pkuwm commented on issue #517: Add typoed name DataPropagationLatencyGuage as
deprecated
URL: https://github.com/apache/helix/pull/517#issuecomment-545210575
This PR is ready to be merged, approved by @narendly
Final commit comment:
If we remove the typoed name
narendly commented on a change in pull request #516: Implement the
propertyStore read endpoint
URL: https://github.com/apache/helix/pull/516#discussion_r337829469
##
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java
jiajunwang commented on a change in pull request #519: Refine the rebalance
scope calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r337856978
##
File path:
jiajunwang opened a new issue #527: NIT:
`CHANGE_TYPES_REQUIRING_GLOBAL_REBALANCE` would be correct technically.
URL: https://github.com/apache/helix/issues/527
NIT: `CHANGE_TYPES_REQUIRING_GLOBAL_REBALANCE` would be correct technically.
_Originally posted by @narendly in
jiajunwang commented on a change in pull request #519: Refine the rebalance
scope calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r337856760
##
File path:
pkuwm commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337856707
##
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##
jiajunwang commented on a change in pull request #519: Refine the rebalance
scope calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r337859567
##
File path:
jiajunwang commented on a change in pull request #519: Refine the rebalance
scope calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r337857586
##
File path:
jiajunwang commented on a change in pull request #519: Refine the rebalance
scope calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r337859496
##
File path:
jiajunwang commented on a change in pull request #519: Refine the rebalance
scope calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r337857422
##
File path:
jiajunwang commented on a change in pull request #519: Refine the rebalance
scope calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r337859937
##
File path:
jiajunwang commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337860395
##
File path:
narendly commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337823992
##
File path:
narendly commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337824554
##
File path:
narendly commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337824224
##
File path:
narendly commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337820908
##
File path:
narendly commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337825066
##
File path:
narendly commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337825645
##
File path:
narendly commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337824491
##
File path:
narendly commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337827587
##
File path:
narendly commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337825572
##
File path:
narendly commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337825469
##
File path:
narendly commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337820819
##
File path:
narendly commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337824637
##
File path:
narendly commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337825413
##
File path:
narendly commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337826099
##
File path:
jiajunwang commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337860562
##
File path:
jiajunwang commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337860874
##
File path:
jiajunwang commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337860703
##
File path:
narendly commented on issue #520: Refactoring soft constraints to simply the
algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#issuecomment-545239413
@jiajunwang Also from now on, please try to keep PRs separate. Structural
changes could go in one PR, and
narendly commented on a change in pull request #516: Implement the
propertyStore read endpoint
URL: https://github.com/apache/helix/pull/516#discussion_r337829469
##
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java
narendly merged pull request #517: Add typoed name DataPropagationLatencyGuage
as deprecated
URL: https://github.com/apache/helix/pull/517
This is an automated message from the Apache Git Service.
To respond to the message,
pkuwm closed issue #512: Name DataPropagationLatencyGauge has a typo
URL: https://github.com/apache/helix/issues/512
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jiajunwang opened a new issue #526: Need a better way to verify (wait) if the
partition assignment converged or not.
URL: https://github.com/apache/helix/issues/526
Currently, we use the verifier to check if the partitions in a cluster have
been allocated to the ideal placement. The
jiajunwang commented on a change in pull request #520: Refactoring soft
constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#discussion_r337861175
##
File path:
84 matches
Mail list logo