[Impala-ASF-CR] IMPALA-6906: disable test that depends on memory estimates on S3

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10207 ) Change subject: IMPALA-6906: disable test that depends on memory estimates on S3 .. IMPALA-6906: disable test that

[Impala-ASF-CR] IMPALA-6906: disable test that depends on memory estimates on S3

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10207 ) Change subject: IMPALA-6906: disable test that depends on memory estimates on S3 .. Patch Set 3: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6927: Remove invalid DCHECK from coordinator backend state

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10192 ) Change subject: IMPALA-6927: Remove invalid DCHECK from coordinator backend state .. IMPALA-6927: Remove invalid

[Impala-ASF-CR] IMPALA-6927: Remove invalid DCHECK from coordinator backend state

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10192 ) Change subject: IMPALA-6927: Remove invalid DCHECK from coordinator backend state .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6913: Simple parser for Impala profile logs.

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9265 ) Change subject: IMPALA-6913: Simple parser for Impala profile logs. .. IMPALA-6913: Simple parser for Impala profile

[Impala-ASF-CR] IMPALA-6913: Simple parser for Impala profile logs.

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9265 ) Change subject: IMPALA-6913: Simple parser for Impala profile logs. .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6892: CheckHashAndDecrypt() includes file and host

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10204 ) Change subject: IMPALA-6892: CheckHashAndDecrypt() includes file and host .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6892: CheckHashAndDecrypt() includes file and host

2018-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10204 ) Change subject: IMPALA-6892: CheckHashAndDecrypt() includes file and host .. Patch Set 3: Flaky Hbase planner test -- To view,

[Impala-ASF-CR] IMPALA-6892: CheckHashAndDecrypt() includes file and host

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10204 ) Change subject: IMPALA-6892: CheckHashAndDecrypt() includes file and host .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6802 (part 1): Clean up authorization tests

2018-04-25 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10135 ) Change subject: IMPALA-6802 (part 1): Clean up authorization tests .. Patch Set 6: (8 comments)

[Impala-ASF-CR] IMPALA-6802 (part 1): Clean up authorization tests

2018-04-25 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/10135 ) Change subject: IMPALA-6802 (part 1): Clean up authorization tests .. IMPALA-6802 (part 1): Clean up authorization tests The first patch

[Impala-ASF-CR] IMPALA-6892: CheckHashAndDecrypt() includes file and host

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10204 ) Change subject: IMPALA-6892: CheckHashAndDecrypt() includes file and host .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6902: Tighten udf test to look for crashes

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10180 ) Change subject: IMPALA-6902: Tighten udf test to look for crashes .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6902: Tighten udf test to look for crashes

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10180 ) Change subject: IMPALA-6902: Tighten udf test to look for crashes .. IMPALA-6902: Tighten udf test to look for crashes

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-04-25 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#13). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-04-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 13: (5 comments) Thanks, Csaba! Yes, we have tests

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-04-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 30: (3 comments)

[Impala-ASF-CR](asf-site) Update download and signature links for 2.12.0 release.

2018-04-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10183 ) Change subject: Update download and signature links for 2.12.0 release. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-04-25 Thread Zoltan Borok-Nagy (Code Review)
Hello Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9005 to look at the new patch set (#30). Change subject: IMPALA-6314: Add run time scalar subquery check

[Impala-ASF-CR](asf-site) Added changelog for 2.12.0

2018-04-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10184 ) Change subject: Added changelog for 2.12.0 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] add impala-flake8

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10182 ) Change subject: add impala-flake8 .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2359/

[Impala-ASF-CR] IMPALA-6889: Fix race around terminating processes

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10156 ) Change subject: IMPALA-6889: Fix race around terminating processes .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5392: Added all stack frames to ThreadInfo summary.

2018-04-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 ) Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. .. Patch Set 4: (10 comments)

[Impala-ASF-CR] add impala-flake8

2018-04-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10182 ) Change subject: add impala-flake8 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10182 To

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-04-25 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 13: (6 comments)

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-04-25 Thread Pranay Singh (Code Review)
Hello anujphadke, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8936 to look at the new patch set (#14). Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

[native-toolchain-CR] thrift-0.9.3-p4: forward compatibility of TLS protocols

2018-04-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10129 ) Change subject: thrift-0.9.3-p4: forward compatibility of TLS protocols .. thrift-0.9.3-p4: forward compatibility of TLS

[native-toolchain-CR] thrift-0.9.3-p4: forward compatibility of TLS protocols

2018-04-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10129 ) Change subject: thrift-0.9.3-p4: forward compatibility of TLS protocols .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6927: Remove invalid DCHECK from coordinator backend state

2018-04-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10192 ) Change subject: IMPALA-6927: Remove invalid DCHECK from coordinator backend state .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6927: Remove invalid DCHECK from coordinator backend state

2018-04-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10192 ) Change subject: IMPALA-6927: Remove invalid DCHECK from coordinator backend state .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] add impala-flake8

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10182 ) Change subject: add impala-flake8 .. add impala-flake8 Add flake8 and dependencies to impala-python. The versions are

[Impala-ASF-CR] IMPALA-6906: disable test that depends on memory estimates on S3

2018-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10207 Change subject: IMPALA-6906: disable test that depends on memory estimates on S3 .. IMPALA-6906: disable test that depends on memory

[Impala-ASF-CR] [Preview]IMPALA-5216: Make admission control queuing async

2018-04-25 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10060 to look at the new patch set (#4). Change subject: [Preview]IMPALA-5216: Make admission control queuing async

[Impala-ASF-CR] IMPALA-6927: Remove invalid DCHECK from coordinator backend state

2018-04-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10192 ) Change subject: IMPALA-6927: Remove invalid DCHECK from coordinator backend state .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6905: support regexes with more verifiers

2018-04-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10155 ) Change subject: IMPALA-6905: support regexes with more verifiers .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6905: support regexes with more verifiers

2018-04-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10155 ) Change subject: IMPALA-6905: support regexes with more verifiers .. Patch Set 1: Code-Review+1 ...for my end. Alex, did you care to

[Impala-ASF-CR] IMPALA-6913: Simple parser for Impala profile logs.

2018-04-25 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, David Knupp, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9265 to look at the new patch set (#5). Change subject: IMPALA-6913: Simple parser for Impala profile logs.

[Impala-ASF-CR] IMPALA-6913: Simple parser for Impala profile logs.

2018-04-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9265 ) Change subject: IMPALA-6913: Simple parser for Impala profile logs. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6927: Remove invalid DCHECK from coordinator backend state

2018-04-25 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10192 Change subject: IMPALA-6927: Remove invalid DCHECK from coordinator backend state .. IMPALA-6927: Remove invalid DCHECK from coordinator

[Impala-ASF-CR] IMPALA-6892: CheckHashAndDecrypt() includes file and host

2018-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10204 ) Change subject: IMPALA-6892: CheckHashAndDecrypt() includes file and host .. IMPALA-6892: CheckHashAndDecrypt() includes file and host

[Impala-ASF-CR] add impala-flake8

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10182 ) Change subject: add impala-flake8 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10182 To

[Impala-ASF-CR] IMPALA-6821: Push down limits into Kudu

2018-04-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10119 ) Change subject: IMPALA-6821: Push down limits into Kudu .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6892: CheckHashAndDecrypt() includes file and host

2018-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10204 Change subject: IMPALA-6892: CheckHashAndDecrypt() includes file and host .. IMPALA-6892: CheckHashAndDecrypt() includes file and host

[Impala-ASF-CR](2.x) IMPALA-6643: Add REFRESH fine-grained privilege

2018-04-25 Thread Alex Behm (Code Review)
Alex Behm has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10179 ) Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. IMPALA-6643: Add REFRESH fine-grained privilege Before this

[Impala-ASF-CR] IMPALA-6927: Remove invalid DCHECK from coordinator backend state

2018-04-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10192 ) Change subject: IMPALA-6927: Remove invalid DCHECK from coordinator backend state .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6679,IMPALA-6678: reduce scan reservation

2018-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9757 ) Change subject: IMPALA-6679,IMPALA-6678: reduce scan reservation .. Patch Set 10: Code-Review+2 (4 comments) It'd be good to get Bikram's

[Impala-ASF-CR] IMPALA-6679,IMPALA-6678: reduce scan reservation

2018-04-25 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9757 to look at the new patch set (#10). Change subject: IMPALA-6679,IMPALA-6678: reduce scan reservation ..

[Impala-ASF-CR] IMPALA-6905: support regexes with more verifiers

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10155 ) Change subject: IMPALA-6905: support regexes with more verifiers .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6905: support regexes with more verifiers

2018-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10155 ) Change subject: IMPALA-6905: support regexes with more verifiers .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6927: Remove invalid DCHECK from coordinator backend state

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10192 ) Change subject: IMPALA-6927: Remove invalid DCHECK from coordinator backend state .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6889: Fix race around terminating processes

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10156 ) Change subject: IMPALA-6889: Fix race around terminating processes .. IMPALA-6889: Fix race around terminating

[Impala-ASF-CR] IMPALA-6889: Fix race around terminating processes

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10156 ) Change subject: IMPALA-6889: Fix race around terminating processes .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6866: Rework timeouts for test exchange delays.py

2018-04-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10208 Change subject: IMPALA-6866: Rework timeouts for test_exchange_delays.py .. IMPALA-6866: Rework timeouts for test_exchange_delays.py

[Impala-ASF-CR] IMPALA-6913: Simple parser for Impala profile logs.

2018-04-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9265 ) Change subject: IMPALA-6913: Simple parser for Impala profile logs. .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6906: disable test that depends on memory estimates on S3

2018-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10207 ) Change subject: IMPALA-6906: disable test that depends on memory estimates on S3 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6906: disable test that depends on memory estimates on S3

2018-04-25 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10207 to look at the new patch set (#2). Change subject: IMPALA-6906: disable test that depends on memory estimates on S3

[Impala-ASF-CR] IMPALA-6906: disable test that depends on memory estimates on S3

2018-04-25 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10207 to look at the new patch set (#3). Change subject: IMPALA-6906: disable test that depends on memory estimates on S3

[Impala-ASF-CR] IMPALA-6892: CheckHashAndDecrypt() includes file and host

2018-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10204 ) Change subject: IMPALA-6892: CheckHashAndDecrypt() includes file and host .. Patch Set 2: Code-Review+2 Maybe later we should have the

[Impala-ASF-CR] IMPALA-6679,IMPALA-6678: reduce scan reservation

2018-04-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9757 ) Change subject: IMPALA-6679,IMPALA-6678: reduce scan reservation .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-04-25 Thread Pranay Singh (Code Review)
Hello anujphadke, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8936 to look at the new patch set (#15). Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

[Impala-ASF-CR] WIP: IMPALA-6518,IMPALA-6340: Check that decimal types are compatible in FE

2018-04-25 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/9930 ) Change subject: WIP: IMPALA-6518,IMPALA-6340: Check that decimal types are compatible in FE .. WIP: IMPALA-6518,IMPALA-6340: Check

[Impala-ASF-CR] IMPALA-6927: Remove invalid DCHECK from coordinator backend state

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10192 ) Change subject: IMPALA-6927: Remove invalid DCHECK from coordinator backend state .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6920: fix inconsistencies with scanner thread tokens

2018-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10186 ) Change subject: IMPALA-6920: fix inconsistencies with scanner thread tokens .. IMPALA-6920: fix inconsistencies with scanner thread

[Impala-ASF-CR] IMPALA-6892: CheckHashAndDecrypt() includes file and host

2018-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10204 ) Change subject: IMPALA-6892: CheckHashAndDecrypt() includes file and host .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6906: disable test that depends on memory estimates on S3

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10207 ) Change subject: IMPALA-6906: disable test that depends on memory estimates on S3 .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6679,IMPALA-6678: reduce scan reservation

2018-04-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9757 ) Change subject: IMPALA-6679,IMPALA-6678: reduce scan reservation .. Patch Set 10: Code-Review+2 (9 comments) Just a few nits.

[Impala-ASF-CR] IMPALA-6866: Rework timeouts for test exchange delays.py

2018-04-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10208 ) Change subject: IMPALA-6866: Rework timeouts for test_exchange_delays.py .. Patch Set 1: Running tests on Isilon and S3. -- To

[Impala-ASF-CR] IMPALA-6529: [DOCS] Output type of round function matches the input type

2018-04-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10214 Change subject: IMPALA-6529: [DOCS] Output type of round function matches the input type .. IMPALA-6529: [DOCS] Output type of round

[Impala-ASF-CR] IMPALA-6927: Remove invalid DCHECK from coordinator backend state

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10192 ) Change subject: IMPALA-6927: Remove invalid DCHECK from coordinator backend state .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6913: Simple parser for Impala profile logs.

2018-04-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9265 ) Change subject: IMPALA-6913: Simple parser for Impala profile logs. .. Patch Set 5: Code-Review+1 I'm inclined to +2 this

[Impala-ASF-CR] IMPALA-6906: disable test that depends on memory estimates on S3

2018-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10207 ) Change subject: IMPALA-6906: disable test that depends on memory estimates on S3 .. Patch Set 3: Code-Review+2 Later we could disable on

[Impala-ASF-CR] IMPALA-6913: Simple parser for Impala profile logs.

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9265 ) Change subject: IMPALA-6913: Simple parser for Impala profile logs. .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6529: [DOCS] Output type of round function matches the input type

2018-04-25 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10214 ) Change subject: IMPALA-6529: [DOCS] Output type of round function matches the input type .. Patch Set 1: Could I have quick reviews

[Impala-ASF-CR] IMPALA-6529: [DOCS] Output type of round function matches the input type

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10214 ) Change subject: IMPALA-6529: [DOCS] Output type of round function matches the input type .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6529: [DOCS] Output type of round function matches the input type

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10214 ) Change subject: IMPALA-6529: [DOCS] Output type of round function matches the input type .. IMPALA-6529: [DOCS]

[Impala-ASF-CR] IMPALA-6885: handle empty s3 dirs in recover partitions test

2018-04-25 Thread Vuk Ercegovac (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10210 to look at the new patch set (#2). Change subject: IMPALA-6885: handle empty s3 dirs in recover_partitions test ..

[Impala-ASF-CR] IMPALA-6885: handle empty s3 dirs in recover partitions test

2018-04-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10210 ) Change subject: IMPALA-6885: handle empty s3 dirs in recover_partitions test .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6913: Simple parser for Impala profile logs.

2018-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9265 ) Change subject: IMPALA-6913: Simple parser for Impala profile logs. .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR](asf-site) Update download and signature links for 2.12.0 release.

2018-04-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10183 ) Change subject: Update download and signature links for 2.12.0 release. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6892: CheckHashAndDecrypt() includes file and host

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10204 ) Change subject: IMPALA-6892: CheckHashAndDecrypt() includes file and host .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6892: CheckHashAndDecrypt() includes file and host

2018-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10204 ) Change subject: IMPALA-6892: CheckHashAndDecrypt() includes file and host .. Patch Set 2: Yeah that seems like a good idea to do at

[Impala-ASF-CR] IMPALA-6802 (part 1): Clean up authorization tests

2018-04-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10135 ) Change subject: IMPALA-6802 (part 1): Clean up authorization tests .. Patch Set 5: (8 comments) Overall the new mechanism seems fine to

[Impala-ASF-CR] IMPALA-6905: support regexes with more verifiers

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10155 ) Change subject: IMPALA-6905: support regexes with more verifiers .. IMPALA-6905: support regexes with more verifiers

[Impala-ASF-CR] IMPALA-6905: support regexes with more verifiers

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10155 ) Change subject: IMPALA-6905: support regexes with more verifiers .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6885: handle empty s3 dirs in recover partitions test

2018-04-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10210 ) Change subject: IMPALA-6885: handle empty s3 dirs in recover_partitions test .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-04-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 30: (1 comment) Change looks

[Impala-ASF-CR] IMPALA-6885: handle empty s3 dirs in recover partitions test

2018-04-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10210 Change subject: IMPALA-6885: handle empty s3 dirs in recover_partitions test .. IMPALA-6885: handle empty s3 dirs in recover_partitions

[Impala-ASF-CR] IMPALA-6906: disable test that depends on memory estimates on S3

2018-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10207 ) Change subject: IMPALA-6906: disable test that depends on memory estimates on S3 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 13: (15 comments) I spent a bit of time trying to break

[Impala-ASF-CR] IMPALA-6529: [DOCS] Output type of round function matches the input type

2018-04-25 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/10214 ) Change subject: IMPALA-6529: [DOCS] Output type of round function matches the input type .. Patch Set 1: Code-Review+2 LGTM -- To

[Impala-ASF-CR] IMPALA-6529: [DOCS] Output type of round function matches the input type

2018-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10214 ) Change subject: IMPALA-6529: [DOCS] Output type of round function matches the input type .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6679,IMPALA-6678: reduce scan reservation

2018-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9757 ) Change subject: IMPALA-6679,IMPALA-6678: reduce scan reservation .. Patch Set 10: (9 comments)

[Impala-ASF-CR] IMPALA-6679,IMPALA-6678: reduce scan reservation

2018-04-25 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9757 to look at the new patch set (#11). Change subject: IMPALA-6679,IMPALA-6678: reduce scan reservation

[Impala-ASF-CR] IMPALA-6679,IMPALA-6678: reduce scan reservation

2018-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9757 ) Change subject: IMPALA-6679,IMPALA-6678: reduce scan reservation .. Patch Set 10: Code-Review+2 Carry +2 -- To view, visit