[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-11-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 10: Code-Review+1 Thanks for the explanations, Zoli!

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-27 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Laszlo Gaal, Zoltan Borok-Nagy, Philip Zeyliger, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8447 to look at the new patch set (#22). Change subject: IMPALA-2181: Add query

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 22: (2 comments) Thanks Dan for taking a look!

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-11-22 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Lars Volker, Tim Armstrong, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8612 to look at the new patch set (#2). Change subject: IMPALA-4132: Use -fno-omit-frame-pointer

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-11-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-11-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 9: (7 comments)

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-22 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Laszlo Gaal, Zoltan Borok-Nagy, Philip Zeyliger, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8447 to look at the new patch set (#21). Change subject: IMPALA-2181: Add query

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 21: (8 comments)

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8549 ) Change subject: IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C .. Patch Set 7: (1 comment) Apparently,

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-27 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Laszlo Gaal, Michael Brown, Zoltan Borok-Nagy, Philip Zeyliger, David Knupp, Attila Jeges, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8549 to look at the new patch set (#7). Change subject:

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-27 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Laszlo Gaal, Michael Brown, Zoltan Borok-Nagy, Philip Zeyliger, David Knupp, Attila Jeges, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8549 to look at the new patch set (#8). Change subject:

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-11-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 19: (4 comments)

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-22 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Laszlo Gaal, Zoltan Borok-Nagy, Philip Zeyliger, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8447 to look at the new patch set (#20). Change subject: IMPALA-2181: Add query

[Impala-ASF-CR] IMPALA-6265 Query cancellation test enhancements

2017-12-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8713 ) Change subject: IMPALA-6265 Query cancellation test enhancements .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-6265 Query cancellation test enhancements

2017-12-05 Thread Gabor Kaszab (Code Review)
Hello Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8713 to look at the new patch set (#3). Change subject: IMPALA-6265 Query cancellation test enhancements

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 14: Code-Review+1 Thanks for sharing your view,

[Impala-ASF-CR] IMPALA-6318: Adjustment for hanging query cancellation test

2017-12-15 Thread Gabor Kaszab (Code Review)
Hello Laszlo Gaal, Zoltan Borok-Nagy, David Knupp, Attila Jeges, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8852 to look at the new patch set (#3). Change subject: IMPALA-6318: Adjustment for hanging query cancellation

[Impala-ASF-CR] IMPALA-6318: Adjustment for hanging query cancellation test

2017-12-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8852 ) Change subject: IMPALA-6318: Adjustment for hanging query cancellation test .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-6318: Adjustment for hanging query cancellation test

2017-12-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8852 Change subject: IMPALA-6318: Adjustment for hanging query cancellation test .. IMPALA-6318: Adjustment for hanging query cancellation

[Impala-ASF-CR] IMPALA-6318: Adjustment for hanging query cancellation test

2017-12-15 Thread Gabor Kaszab (Code Review)
Hello Laszlo Gaal, Zoltan Borok-Nagy, David Knupp, Attila Jeges, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8852 to look at the new patch set (#2). Change subject: IMPALA-6318: Adjustment for hanging query cancellation

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2017-12-13 Thread Gabor Kaszab (Code Review)
Hello Laszlo Gaal, Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8820 to look at the new patch set (#4). Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2017-12-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2017-12-20 Thread Gabor Kaszab (Code Review)
Hello Laszlo Gaal, Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8820 to look at the new patch set (#5). Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2017-12-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-6318: Adjustment for hanging query cancellation test

2017-12-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8852 ) Change subject: IMPALA-6318: Adjustment for hanging query cancellation test .. Patch Set 4: Indeed, nice catch! Thanks, Tim! And sorry

[Impala-ASF-CR] IMPALA-6318: Adjustment for hanging query cancellation test

2017-12-17 Thread Gabor Kaszab (Code Review)
Hello Laszlo Gaal, Zoltan Borok-Nagy, David Knupp, Attila Jeges, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8852 to look at the new patch set (#5). Change subject: IMPALA-6318: Adjustment for hanging query cancellation

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 14: FYI, both the core and the exhaustive tests passed

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-20 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Laszlo Gaal, Michael Brown, Zoltan Borok-Nagy, Philip Zeyliger, David Knupp, Attila Jeges, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8549 to look at the new patch set (#6). Change subject:

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8549 ) Change subject: IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C .. Patch Set 6: (10 comments)

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-11-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8612 Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. IMPALA-4132: Use -fno-omit-frame-pointer Using -fno-omit-frame-pointer would

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-21 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8549 ) Change subject: IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-21 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 17: (17 comments)

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-21 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Laszlo Gaal, Zoltan Borok-Nagy, Philip Zeyliger, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8447 to look at the new patch set (#18). Change subject: IMPALA-2181: Add query

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-17 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Laszlo Gaal, Michael Brown, Zoltan Borok-Nagy, Philip Zeyliger, David Knupp, Attila Jeges, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8549 to look at the new patch set (#4). Change subject:

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-17 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Laszlo Gaal, Michael Brown, Zoltan Borok-Nagy, Philip Zeyliger, David Knupp, Attila Jeges, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8549 to look at the new patch set (#5). Change subject:

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-17 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8549 ) Change subject: IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C .. Patch Set 5: (4 comments) We

[Impala-ASF-CR] IMPALA-6265 Query cancellation test enhancements

2017-12-04 Thread Gabor Kaszab (Code Review)
Hello Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8713 to look at the new patch set (#2). Change subject: IMPALA-6265 Query cancellation test enhancements

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 6: (7 comments) Thanks, for

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 6: (5 comments) Thanks for the explanation!

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-12-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 13: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2017-12-12 Thread Gabor Kaszab (Code Review)
Hello Laszlo Gaal, Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8820 to look at the new patch set (#3). Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2017-12-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8820 Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. IMPALA-5654: Disallow setting Kudu table name in CREATE

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 6: AFAIK with Impala we try to keep one code

[Impala-ASF-CR] IMPALA-3942: Fix unexpected conversion of string literal in front-end

2017-12-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix unexpected conversion of string literal in front-end .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6265 Increase timeout in test cancellation tests

2017-12-01 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8713 Change subject: IMPALA-6265 Increase timeout in test cancellation tests .. IMPALA-6265 Increase timeout in test cancellation tests

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output

2017-12-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 ) Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 5: (19 comments) Thanks for dealing with my previous

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 9: Patch set 9: Rebased with master -- To view, visit

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-15 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#8). Change subject: IMPALA-5706: Spilling sort optimisations ..

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 8: (16 comments)

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-15 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#9). Change subject: IMPALA-5706: Spilling sort optimisations ..

[Impala-ASF-CR] IMPALA-6995: avoid DCHECK in TimestampParse::Parse()

2018-05-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10349 ) Change subject: IMPALA-6995: avoid DCHECK in TimestampParse::Parse() .. Patch Set 3: Code-Review+1 Thank for responding to my

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-18 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#13). Change subject: IMPALA-5706: Spilling sort optimisations ..

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-17 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 10: FYI, ran an exhaustive suite on this change and some

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-17 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 12: (2 comments)

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-17 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#11). Change subject: IMPALA-5706: Spilling sort optimisations ..

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-17 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#12). Change subject: IMPALA-5706: Spilling sort optimisations ..

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 7: Code-Review+1 (4 comments) Thanks Attila for addressing

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-16 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#10). Change subject: IMPALA-5706: Spilling sort optimisations ..

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 10: (6 comments)

[Impala-ASF-CR] IMPALA-6995: avoid DCHECK in TimestampParse::Parse()

2018-05-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10349 ) Change subject: IMPALA-6995: avoid DCHECK in TimestampParse::Parse() .. Patch Set 2: (4 comments) Hey Tim, I'm fine with the change

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-21 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#14). Change subject: IMPALA-5706: Spilling sort optimisations

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-21 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-25 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#15). Change subject: IMPALA-5706: Spilling sort optimisations

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#8). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#7). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 8: (1 comment) Thanks for your

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-08 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-08 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10654 Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. IMPALA-7121: Clean up partitionIds_ from HdfsTable The purpose of

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-08 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#10). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 9: Patchset 9 is a rebase -- To

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#9). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 9: Verified-1 FYI, apparently

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. Patch Set 2: (1 comment) Thanks for taking a look Todd and Tim!

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 11: (2 comments)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-14 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#11). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. Patch Set 3: Code-Review+1 Patch set 3 is a rebase. (Carry +1)

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-14 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, Todd Lipcon, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10654 to look at the new patch set (#3). Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 10: Hey, could you please take a

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. Patch Set 2: Hey, could you please take a look at this review or

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 12: Patch set 12 is adjusting

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-15 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#12). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-7141 (part 1): clean up handling of default/dummy partition

2018-06-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10711 ) Change subject: IMPALA-7141 (part 1): clean up handling of default/dummy partition .. Patch Set 2: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. Patch Set 3: -Code-Review Todd, I see you have a +2 on

[Impala-ASF-CR] IMPALA-7141 (part 1): clean up handling of default/dummy partition

2018-06-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10711 ) Change subject: IMPALA-7141 (part 1): clean up handling of default/dummy partition .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-19 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#14). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-19 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#13). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-19 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#15). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. IMPALA-7121: Clean up partitionIds_ from HdfsTable The purpose of

[Impala-ASF-CR] IMPALA-7121: Clean up partitionIds from HdfsTable

2018-06-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 ) Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable .. Patch Set 2: (1 comment) FYI, ran a core test suite and all

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-05-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10543 Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. IMPALA-6119: Fix issue with multiple

  1   2   3   >