[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 17: Again failed on a flaky test (but on a di

[Impala-ASF-CR] IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8972 ) Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test" .. IMPALA-6318: Revert "Adjustment for hanging query

[Impala-ASF-CR] IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8972 ) Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test" .. Patch Set 2: Instead of dropping the test, just

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2018-01-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 2: Checked the binary sizes for release builds: Binary size of im

[Impala-ASF-CR] IMPALA-6311: Skip row groups with predicates on NULL columns

2018-01-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9140 Change subject: IMPALA-6311: Skip row groups with predicates on NULL columns .. IMPALA-6311: Skip row groups with predicates on NULL colum

[Impala-ASF-CR] IMPALA-6311: Skip row groups with predicates on NULL columns

2018-01-26 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9140 to look at the new patch set (#2). Change subject: IMPALA-6311: Skip row groups with predicates on NULL columns

[Impala-ASF-CR] IMPALA-6311: Skip row groups with predicates on NULL columns

2018-01-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6311: Skip row groups with predicates on NULL columns .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-01-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 7: (5 comments) Thanks for getting back to this r

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-01-26 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9140 to look at the new patch set (#3). Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-01-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 3: (4 comments) Thanks for taking a look, Zol

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-01 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9140 to look at the new patch set (#4). Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-01 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-02 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9140 to look at the new patch set (#6). Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-02-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 8: Code-Review+1 Thanks for taking care of this. F

[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()

2018-02-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9352 Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled() .. IMPALA-6423: HDFS scanner doesn't check RuntimeSt

[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()

2018-02-18 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9352 to look at the new patch set (#2). Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled() .

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/9063/

[Impala-ASF-CR] IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN

2018-02-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9358 ) Change subject: IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN .. Patch Set 2: (2 comments) Seems fine in gene

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/9063/

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN

2018-02-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9358 ) Change subject: IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN .. Patch Set 2: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-02-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 2: (2 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-02-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 2: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-02-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 3: (1 comment) Thanks for the expl

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-02-23 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9420 Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. IMPALA-3866 Improve error reporting for scratch write erro

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-02-23 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. IMPALA-3866 Improve error reporting for scratch write error

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-03-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 2: (10 comments) http://gerrit

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 2: (5 comments) Thx Attila for taking a look!

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-06 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#3). Change subject: IMPALA-3866 Improve error reporting for scratch write errors ..

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 3: Rebased with master + resolved conflicts.

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-06 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#4). Change subject: IMPALA-3866 Improve error reporting for scratch write errors ..

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 4: (31 comments) Thanks for taking a look, At

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 3: Code-Review+1 (1 comment) h

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2018-03-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9391 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 2: Hey, Let me put myself in context and get

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-07 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#5). Change subject: IMPALA-3866 Improve error reporting for scratch write errors ..

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 5: (11 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2018-03-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9391 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 2: (8 comments) Thanks for taking care of t

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-07 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#6). Change subject: IMPALA-3866 Improve error reporting for scratch write errors ..

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-08 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-08 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#7). Change subject: IMPALA-3866 Improve error reporting for scratch write errors ..

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-12 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#8). Change subject: IMPALA-3866: Improve error reporting for scratch write errors .

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 8: (16 comments) Thanks for taking a look, T

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-13 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#9). Change subject: IMPALA-3866: Improve error reporting for scratch write errors .

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 9: (6 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-13 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#11). Change subject: IMPALA-3866: Improve error reporting for scratch write errors

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-14 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#12). Change subject: IMPALA-3866: Improve error reporting for scratch write errors

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-15 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#13). Change subject: IMPALA-3866: Improve error reporting for scratch write errors .

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 13: (5 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-16 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#14). Change subject: IMPALA-3866: Improve error reporting for scratch write errors .

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-16 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#15). Change subject: IMPALA-3866: Improve error reporting for scratch write errors .

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6699: Fix Australian DST ending time

2018-03-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9724 Change subject: IMPALA-6699: Fix Australian DST ending time .. IMPALA-6699: Fix Australian DST ending time Australian Daylight Saving Tim

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-21 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 15: Hey Tim, Dan, I think I addressed all you

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-22 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9724 to look at the new patch set (#2). Change subject: IMPALA-6699: Fix DST end time for Australian time zones ...

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9724 ) Change subject: IMPALA-6699: Fix DST end time for Australian time zones .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-23 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9724 to look at the new patch set (#3). Change subject: IMPALA-6699: Fix DST end time for Australian time zones ...

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-23 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9724 ) Change subject: IMPALA-6699: Fix DST end time for Australian time zones .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6713: Fix request for unneeded memory in partial sort

2018-04-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10031 ) Change subject: IMPALA-6713: Fix request for unneeded memory in partial sort .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6713: Fix request for unneeded memory in partial sort

2018-04-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10031 ) Change subject: IMPALA-6713: Fix request for unneeded memory in partial sort .. Patch Set 2: Code-Review+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-04-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 1: (7 comments) Spent only a limited amount of time on this

[Impala-ASF-CR] IMPALA-5706: Parallelise read I/O in sorter

2018-04-17 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#3). Change subject: IMPALA-5706: Parallelise read I/O in sorter .. IMPALA-5706: Para

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-04-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 2: (29 comments) Dumping another batch of comments :) http

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-04-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/9986/2/

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-04-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/9986/2/

[Impala-ASF-CR] IMPALA-5706: Parallelise read I/O in sorter

2018-04-21 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#5). Change subject: IMPALA-5706: Parallelise read I/O in sorter ..

[Impala-ASF-CR] IMPALA-5706: Parallelise read I/O in sorter

2018-04-21 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Parallelise read I/O in sorter .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/9943/3//CO

[Impala-ASF-CR] IMPALA-5706: Parallelise read I/O in sorter

2018-04-24 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#6). Change subject: IMPALA-5706: Parallelise read I/O in sorter ..

[Impala-ASF-CR] IMPALA-5706: Parallelise read I/O in sorter

2018-04-24 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Parallelise read I/O in sorter .. Patch Set 6: (2 comments) Thanks Csaba for taking a look at this review!

[Impala-ASF-CR] IMPALA-5706: Parallelise read I/O in sorter

2018-04-24 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Parallelise read I/O in sorter .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR](asf-site) Update download and signature links for 2.12.0 release.

2018-04-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10183 ) Change subject: Update download and signature links for 2.12.0 release. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR](asf-site) Added changelog for 2.12.0

2018-04-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10184 ) Change subject: Added changelog for 2.12.0 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10184/1/docs/changelog-2.12

[Impala-ASF-CR] IMPALA-5706: Parallelise read I/O in sorter

2018-04-26 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#7). Change subject: IMPALA-5706: Parallelise read I/O in sorter ..

[Impala-ASF-CR](asf-site) Update download and signature links for 2.12.0 release.

2018-04-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10183 ) Change subject: Update download and signature links for 2.12.0 release. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.

[Impala-ASF-CR](asf-site) Added changelog for 2.12.0

2018-04-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10184 ) Change subject: Added changelog for 2.12.0 .. Patch Set 2: Code-Review+1 Thx for the heads up! -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-01-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12267 Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. IMPALA-4018 Part1: Add FORMAT clause in CAST() This enhancement introd

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-01-31 Thread Gabor Kaszab (Code Review)
Hello Paul Rogers, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12267 to look at the new patch set (#3). Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() ..

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-01-31 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 3: (13 comments) Hey Paul, Thanks for taking a look! The f

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-01 Thread Gabor Kaszab (Code Review)
Hello Greg Rahn, Paul Rogers, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12267 to look at the new patch set (#4). Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-01 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 4: (11 comments) Thanks everyone for taking a look and lea

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-08 Thread Gabor Kaszab (Code Review)
Hello Greg Rahn, Paul Rogers, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12267 to look at the new patch set (#5). Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-08 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 5: (2 comments) Hey, I managed to cover all the comments.

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-13 Thread Gabor Kaszab (Code Review)
Hello Greg Rahn, Paul Rogers, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12267 to look at the new patch set (#6). Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 6: (4 comments) Sorry, the last patch set came together wi

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 7: (8 comments) http://gerrit.cloudera.org:8080/#/c/12267/

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-18 Thread Gabor Kaszab (Code Review)
Hello Greg Rahn, Paul Rogers, Philip Zeyliger, Attila Jeges, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12267 to look at the new patch set (#7). Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST()

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 7: There was an ongoing discussion on the Jira during this

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has abandoned this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Abandoned Will deliver a feature in one patch instead of splitting it to 2 par

[Impala-ASF-CR] IMPALA-8303: [DOCS] Impala 3.2 release notes

2019-03-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12752 ) Change subject: IMPALA-8303: [DOCS] Impala 3.2 release notes .. Patch Set 1: Hey Alex, I'm not sure how this usually is handled: Should

[Impala-ASF-CR] IMPALA-8303: [DOCS] Impala 3.2 release notes

2019-03-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12752 ) Change subject: IMPALA-8303: [DOCS] Impala 3.2 release notes .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-8303: [DOCS] Impala 3.2 release notes

2019-03-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12752 ) Change subject: IMPALA-8303: [DOCS] Impala 3.2 release notes .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12752/2/d

[Impala-ASF-CR] IMPALA-8303: [DOCS] Take 2 Fixed the rev and id for 3.2

2019-03-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12780 ) Change subject: IMPALA-8303: [DOCS] Take 2 Fixed the rev and id for 3.2 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR](asf-site) Download 3.2.0

2019-03-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12808 Change subject: Download 3.2.0 .. Download 3.2.0 Updated download links for release 3.2.0 Change-Id: I6b1451baf85a96099116da1a10af8c00a

[Impala-ASF-CR](asf-site) Add 3.2.0 change log

2019-03-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12809 Change subject: Add 3.2.0 change log .. Add 3.2.0 change log Change-Id: I0592234d9f67677bae0313d65889233e6b9c6210 --- A docs/changelog-3

[Impala-ASF-CR] IMPALA-8308: [DOCS] Impala 3.2 Release

2019-03-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12838 ) Change subject: IMPALA-8308: [DOCS] Impala 3.2 Release .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12838/3/docs/to

[Impala-ASF-CR] IMPALA-8308: [DOCS] Impala 3.2 Release

2019-03-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12838 ) Change subject: IMPALA-8308: [DOCS] Impala 3.2 Release .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR](asf-site) [DOCS] Impala 3.2 docs to be published

2019-03-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12860 ) Change subject: [DOCS] Impala 3.2 docs to be published .. Patch Set 1: Code-Review+2 I think this should wait until changelog makes it

  1   2   3   4   5   6   7   8   9   10   >