[Impala-ASF-CR] IMPALA-6441: update explain string for stress test

2018-01-25 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9141 Change subject: IMPALA-6441: update explain string for stress test .. IMPALA-6441: update explain string for stress test - Update the ex

[Impala-ASF-CR] IMPALA-6441: update explain string for stress test

2018-01-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9141 ) Change subject: IMPALA-6441: update explain string for stress test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/914

[Impala-ASF-CR] IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

2018-01-26 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9146 Change subject: IMPALA-6441 addendum: fix reading rows from HS2 via Impyla .. IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

[Impala-ASF-CR] IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

2018-01-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9146 ) Change subject: IMPALA-6441 addendum: fix reading rows from HS2 via Impyla .. Patch Set 2: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-6447: remove Python 2.7 dictionary comprehensions

2018-01-29 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9150 Change subject: IMPALA-6447: remove Python 2.7 dictionary comprehensions .. IMPALA-6447: remove Python 2.7 dictionary comprehensions In

[Impala-ASF-CR] IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

2018-01-29 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9146 ) Change subject: IMPALA-6441 addendum: fix reading rows from HS2 via Impyla .. Patch Set 3: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

2018-01-30 Thread Michael Brown (Code Review)
Michael Brown has removed a vote on this change. Change subject: IMPALA-6441 addendum: fix reading rows from HS2 via Impyla .. Removed Verified-1 by Impala Public Jenkins (255) -- To view, visit http://gerrit.cloudera.org:8080/9

[Impala-ASF-CR] IMPALA-6303: [DOCS]Fix incorrect mention of DataNodes in documentation

2018-01-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9160 ) Change subject: IMPALA-6303: [DOCS]Fix incorrect mention of DataNodes in documentation .. Patch Set 2: (1 comment) Thanks! Just a min

[Impala-ASF-CR] IMPALA-6303: [DOCS] Fix incorrect mention of DataNodes

2018-01-31 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9160 ) Change subject: IMPALA-6303: [DOCS] Fix incorrect mention of DataNodes .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

2018-02-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9146 ) Change subject: IMPALA-6441 addendum: fix reading rows from HS2 via Impyla .. Patch Set 4: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-6475: Enable running TPCH on Kudu

2018-02-02 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9206 ) Change subject: IMPALA-6475: Enable running TPCH on Kudu .. Patch Set 1: Code-Review+2 Yeah, this is basically the solution path I had

[Impala-ASF-CR] IMPALA-6475: Enable running TPCH on Kudu

2018-02-03 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9206 ) Change subject: IMPALA-6475: Enable running TPCH on Kudu .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] Remove Yarn from minicluster.

2018-02-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9264 ) Change subject: Remove Yarn from minicluster. .. Patch Set 1: > > Patch Set 1: > > > > Did you also test data load and snapshot creat

[Impala-ASF-CR] Remove Yarn from minicluster.

2018-02-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9264 ) Change subject: Remove Yarn from minicluster. .. Patch Set 1: > Does that work on miniclusters? I ran it and it's having trouble > con

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9273 ) Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. Patch Set 1: I think this is a good start,

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 5: (3 comments) I was trying to think about how this could be done withou

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 5: (2 comments) > This means we will have automated test runs with both k

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9273 ) Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. Patch Set 5: (4 comments) > Line 38: I hav

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 9: Code-Review+1 (1 comment) Feel free to carry forward my +1 after fixin

[Impala-ASF-CR] [docs] Removed the obsolete Llama options files

2018-02-16 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [docs] Removed the obsolete Llama options files .. Patch Set 2: > (1 comment) > > Now the question is, how do we make

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9273 ) Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. Patch Set 7: Code-Review+2 https://jenkins.

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9273 ) Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. Patch Set 7: > Build failed: https://jenkin

[Impala-ASF-CR] IMPALA-4430: Update build scripts to die hard when IMPALA HOME has spaces

2018-03-05 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9385 ) Change subject: IMPALA-4430: Update build scripts to die hard when IMPALA_HOME has spaces .. Patch Set 5: (2 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

2018-03-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9494 ) Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit_code 5 .. Patch Set 4: (10 comments) http://gerrit.cloud

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

2018-03-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 ) Change subject: Fix test dimensions in test_errorlog.py .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] Consistently use Java 1.7 compiler.

2018-03-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9600 ) Change subject: Consistently use Java 1.7 compiler. .. Patch Set 1: Code-Review+1 (1 comment) I git grep'd myself and didn't see any o

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 2: (14 comments) First pass, will

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 3: (4 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 4: soft +1. I'd like to test it my

[Impala-ASF-CR] IMPALA-6415: [DOCS] fix invalid

2018-03-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9731 ) Change subject: IMPALA-6415: [DOCS] fix invalid .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9731/1//COMMIT_MSG Co

[Impala-ASF-CR] IMPALA-6415: [DOCS] fix invalid

2018-03-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9731 ) Change subject: IMPALA-6415: [DOCS] fix invalid .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9731

[Impala-ASF-CR] IMPALA-6716: Store LDAP options as shell member variables

2018-03-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9744 ) Change subject: IMPALA-6716: Store LDAP options as shell member variables .. Patch Set 1: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-6715: fix stress TPC workload selection

2018-03-22 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9758 Change subject: IMPALA-6715: fix stress TPC workload selection .. IMPALA-6715: fix stress TPC workload selection A recent commit caused

[Impala-ASF-CR] IMPALA-6715: fix stress TPC workload selection

2018-03-23 Thread Michael Brown (Code Review)
Hello Nithya Janarthanan, David Knupp, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9758 to look at the new patch set (#2). Change subject: IMPALA-6715: fix stress TPC workload selection .

[Impala-ASF-CR] IMPALA-6715: fix stress TPC workload selection

2018-03-23 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 ) Change subject: IMPALA-6715: fix stress TPC workload selection .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9758/1

[Impala-ASF-CR] IMPALA-6715: fix stress TPC workload selection

2018-03-23 Thread Michael Brown (Code Review)
Hello Nithya Janarthanan, David Knupp, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9758 to look at the new patch set (#3). Change subject: IMPALA-6715: fix stress TPC workload selection .

[Impala-ASF-CR] IMPALA-6715: fix stress TPC workload selection

2018-03-23 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 ) Change subject: IMPALA-6715: fix stress TPC workload selection .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9758/1

[Impala-ASF-CR] Use "mvn -B" in builds to avoid dowloading progress bars in logs.

2018-03-24 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9792 ) Change subject: Use "mvn -B" in builds to avoid dowloading progress bars in logs. .. Patch Set 1: Code-Review+2 -- To view, visit htt

[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection

2018-03-24 Thread Michael Brown (Code Review)
Hello Nithya Janarthanan, David Knupp, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9758 to look at the new patch set (#4). Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection .

[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection

2018-03-24 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 ) Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection .. Patch Set 4: PS4 fixes another bug which would be a block

[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search

2018-03-26 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9770 Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search .. IMPALA-5721,IMPALA-6717,IMPALA-6738: improve s

[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection

2018-03-26 Thread Michael Brown (Code Review)
Hello Nithya Janarthanan, David Knupp, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9758 to look at the new patch set (#5). Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection .

[Impala-ASF-CR] IMPALA-6715,IMPALA-6736: fix stress TPC workload selection

2018-03-26 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 ) Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search

2018-03-27 Thread Michael Brown (Code Review)
Hello Nithya Janarthanan, David Knupp, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9770 to look at the new patch set (#8). Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search

[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search

2018-03-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9770 ) Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search .. Patch Set 7: (7 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. Patch Set 8: I was surprised this commit is missing th

[Impala-ASF-CR](2.x) Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.

2018-03-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9833 ) Change subject: Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list. .. Patch Set 1: Code-Review+2 -- To view, v

[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh

2018-03-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 ) Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh

2018-03-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 ) Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh .. Patch Set 3: Code-Review+1 This makes sense as I understand

[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search

2018-03-28 Thread Michael Brown (Code Review)
Hello Nithya Janarthanan, David Knupp, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9770 to look at the new patch set (#9). Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search

[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search

2018-03-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9770 ) Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search .. Patch Set 7: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-6759: align stress test memory estimation parse pattern

2018-03-28 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9844 Change subject: IMPALA-6759: align stress test memory estimation parse pattern .. IMPALA-6759: align stress test memory estimation parse

[Impala-ASF-CR] IMPALA-6759: align stress test memory estimation parse pattern

2018-03-28 Thread Michael Brown (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9844 to look at the new patch set (#2). Change subject: IMPALA-6759: align stress test memory estimation parse pattern .. I

[Impala-ASF-CR] IMPALA-6759: align stress test memory estimation parse pattern

2018-03-28 Thread Michael Brown (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9844 to look at the new patch set (#3). Change subject: IMPALA-6759: align stress test memory estimation parse pattern .. I

[Impala-ASF-CR] IMPALA-6759: align stress test memory estimation parse pattern

2018-03-28 Thread Michael Brown (Code Review)
Michael Brown has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9844 ) Change subject: IMPALA-6759: align stress test memory estimation parse pattern .. IMPALA-6759: align stress test memory estimati

[Impala-ASF-CR] IMPALA-6759: align stress test memory estimation parse pattern

2018-03-28 Thread Michael Brown (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9844 to look at the new patch set (#4). Change subject: IMPALA-6759: align stress test memory estimation parse pattern .. I

[Impala-ASF-CR] IMPALA-6759: align stress test memory estimation parse pattern

2018-03-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9844 ) Change subject: IMPALA-6759: align stress test memory estimation parse pattern .. Patch Set 4: This was a screwup. It was an honest-mis

[Impala-ASF-CR] IMPALA-6759: align stress test memory estimation parse pattern

2018-03-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9844 ) Change subject: IMPALA-6759: align stress test memory estimation parse pattern .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR](2.x) Ignore "IMPALA-6759: align stress test memory estimation parse pattern"

2018-03-28 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9845 Change subject: Ignore "IMPALA-6759: align stress test memory estimation parse pattern" .. Ignore "IMPALA-6759: align stress test memory

[Impala-ASF-CR] IMPALA-6759: align stress test memory estimation parse pattern

2018-03-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9844 ) Change subject: IMPALA-6759: align stress test memory estimation parse pattern .. Patch Set 4: See https://gerrit.cloudera.org/#/c/9846

[Impala-ASF-CR] IMPALA-6759: align stress test memory estimation parse pattern

2018-03-28 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9846 Change subject: IMPALA-6759: align stress test memory estimation parse pattern .. IMPALA-6759: align stress test memory estimation parse

[Impala-ASF-CR] IMPALA-6759: align stress test memory estimation parse pattern

2018-03-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9846 ) Change subject: IMPALA-6759: align stress test memory estimation parse pattern .. Patch Set 1: (1 comment) History: https://gerrit.clo

[Impala-ASF-CR](2.x) Ignore "IMPALA-6759: align stress test memory estimation parse pattern"

2018-03-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9845 ) Change subject: Ignore "IMPALA-6759: align stress test memory estimation parse pattern" .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR](2.x) Ignore "IMPALA-6759: align stress test memory estimation parse pattern"

2018-03-28 Thread Michael Brown (Code Review)
Michael Brown has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9845 ) Change subject: Ignore "IMPALA-6759: align stress test memory estimation parse pattern" .. Ignore "IMPALA-6759: align stress te

[Impala-ASF-CR](asf-site) Board request: Please add ApacheCon event promotion

2018-04-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9952 ) Change subject: Board request: Please add ApacheCon event promotion .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-6805: Show current database in Impala shell prompt

2018-04-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9927 ) Change subject: IMPALA-6805: Show current database in Impala shell prompt .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] Remove Yarn from minicluster by default.

2018-04-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9264 ) Change subject: Remove Yarn from minicluster by default. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9264/2//COMMI

[Impala-ASF-CR] Remove Yarn from minicluster by default. (2nd try)

2018-04-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9970 ) Change subject: Remove Yarn from minicluster by default. (2nd try) .. Patch Set 1: Code-Review+2 Thanks! -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-6805: Show current database in Impala shell prompt

2018-04-10 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9927 ) Change subject: IMPALA-6805: Show current database in Impala shell prompt .. Patch Set 8: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9995 ) Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-11 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 7: (5 comments) I'm kind of in the same mode as

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 8: Code-Review+1 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE

2018-04-12 Thread Michael Brown (Code Review)
Michael Brown has abandoned this change. ( http://gerrit.cloudera.org:8080/8372 ) Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE .. Abandoned -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-6845: TestHdfsQueries causes some tests to be run twice

2018-04-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10053 ) Change subject: IMPALA-6845: TestHdfsQueries causes some tests to be run twice .. Patch Set 2: (1 comment) great catch http://gerrit

[Impala-ASF-CR] IMPALA-6845: TestHdfsQueries causes some tests to be run twice

2018-04-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10053 ) Change subject: IMPALA-6845: TestHdfsQueries causes some tests to be run twice .. Patch Set 3: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 9: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-6819: Add new queries to targeted-perf workload

2018-04-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9979 ) Change subject: IMPALA-6819: Add new queries to targeted-perf workload .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-6889: Fix race around terminating processes

2018-04-23 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10156 ) Change subject: IMPALA-6889: Fix race around terminating processes .. Patch Set 1: (1 comment) Thanks again for looking! http://gerr

[Impala-ASF-CR] IMPALA-6904: stress test threshold parameters

2018-04-23 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9769 ) Change subject: IMPALA-6904: stress test threshold parameters .. Patch Set 2: (6 comments) Everything functional looks fine. There are

[Impala-ASF-CR] IMPALA-6904: stress test threshold parameters

2018-04-23 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9769 ) Change subject: IMPALA-6904: stress test threshold parameters .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] Revert "IMPALA-6869: [DOCS] Update Known Issues doc for 2.12"

2018-04-23 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10164 Change subject: Revert "IMPALA-6869: [DOCS] Update Known Issues doc for 2.12" .. Revert "IMPALA-6869: [DOCS] Update Known Issues doc for

[Impala-ASF-CR] IMPALA-6889: Fix race around terminating processes

2018-04-24 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10156 ) Change subject: IMPALA-6889: Fix race around terminating processes .. Patch Set 2: Code-Review+2 Thanks again for investigating this.

[Impala-ASF-CR] add impala-flake8

2018-04-24 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10182 Change subject: add impala-flake8 .. add impala-flake8 Add flake8 and dependencies to impala-python. The versions are compatible with P

[Impala-ASF-CR] add impala-flake8

2018-04-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10182 ) Change subject: add impala-flake8 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10182 To unsubscrib

[Impala-ASF-CR] IMPALA-6905: support regexes with more verifiers

2018-04-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10155 ) Change subject: IMPALA-6905: support regexes with more verifiers .. Patch Set 1: Code-Review+1 ...for my end. Alex, did you care to re

[Impala-ASF-CR](asf-site) Added changelog for 2.12.0

2018-04-26 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10184 ) Change subject: Added changelog for 2.12.0 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10184 To u

[Impala-ASF-CR] IMPALA-6866: Rework timeouts for test exchange delays.py

2018-04-26 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10208 ) Change subject: IMPALA-6866: Rework timeouts for test_exchange_delays.py .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR](2.x) IMPALA-6892: CheckHashAndDecrypt() includes file and host

2018-04-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10232 ) Change subject: IMPALA-6892: CheckHashAndDecrypt() includes file and host .. Patch Set 1: Thanks Tim. It did look trivial but I wanted

[Impala-ASF-CR] Speed up Python dependencies.

2018-04-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10234 ) Change subject: Speed up Python dependencies. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10234/1/infra/python/de

[Impala-ASF-CR] IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility"

2018-04-30 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10238 Change subject: IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility" .. IMPALA-6951: Revert "Warn about Hadoop / Java

[Impala-ASF-CR] IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility"

2018-04-30 Thread Michael Brown (Code Review)
Michael Brown has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10238 ) Change subject: IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility" .. IMPALA-6951: Revert "Warn about Hado

[Impala-ASF-CR] IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility"

2018-04-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10238 ) Change subject: IMPALA-6951: Revert "Warn about Hadoop / Java version incompatibility" .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6070: Further improvements to test-with-docker.

2018-04-30 Thread Michael Brown (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10248 to review the following change. Change subject: IMPALA-6070: Further improvements to test-with-docker. ..

[Impala-ASF-CR](2.x) IMPALA-6070: Further improvements to test-with-docker.

2018-04-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10248 ) Change subject: IMPALA-6070: Further improvements to test-with-docker. .. Patch Set 1: (1 comment) Not a clean cherry-pick. See below

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10244 ) Change subject: Warn about Hadoop / Java version incompatibility .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/1024

[Impala-ASF-CR](2.x) ignore Hadoop 3-related commits in 2.x

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10260 Change subject: ignore Hadoop 3-related commits in 2.x .. ignore Hadoop 3-related commits in 2.x These commits are about Hadoop 3 and s

[Impala-ASF-CR](asf-site) [DOCS] Add Impala docs from branch 2.x

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10258 ) Change subject: [DOCS] Add Impala docs from branch 2.x .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10258/1/docs/b

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10244 ) Change subject: Warn about Hadoop / Java version incompatibility .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR](2.x) ignore Hadoop 3-related commits in 2.x

2018-05-01 Thread Michael Brown (Code Review)
Michael Brown has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10260 ) Change subject: ignore Hadoop 3-related commits in 2.x .. ignore Hadoop 3-related commits in 2.x These commits are about Hadoo

  1   2   3   >