[Impala-ASF-CR] IMPALA-3504: function for current timestamp in UTC, i.e. utc timestamp()

2016-09-21 Thread Youwei Wang (Code Review)
Youwei Wang has posted comments on this change. Change subject: IMPALA-3504: function for current timestamp in UTC, i.e. utc_timestamp() .. Patch Set 1: > As I mentioned in your previous review and/or the JIRA, this needs >

[Impala-ASF-CR] IMPALA-3504: function for current timestamp in UTC, i.e. utc timestamp()

2016-09-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3504: function for current timestamp in UTC, i.e. utc_timestamp() .. Patch Set 1: > > As I mentioned in your previous review and/or the JIRA, this >

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. Patch Set 9: (10 comments) Publishing these comments

[Impala-ASF-CR] IMPALA-4160: Remove some leftover Llama references

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4493 Change subject: IMPALA-4160: Remove some leftover Llama references .. IMPALA-4160: Remove some leftover Llama references Change-Id:

[Impala-ASF-CR] IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible.

2016-09-21 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4309 to look at the new patch set (#8). Change subject: IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible.

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible.

2016-09-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible. .. Patch Set 8: Code-Review+2 Turns out there was a test for this error

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 1: (9 comments) ... a few more things

[Impala-ASF-CR] IMPALA-4160: Remove some leftover Llama references

2016-09-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4160: Remove some leftover Llama references .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4493 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 3: (3 comments) Thanks for adding a test!

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 1: (3 comments) sorry, more comments I keep finding new things as I'm adding some

[Impala-ASF-CR](asf-site) IMPALA-4068: Follow-up with Roman Shaposhnik on branding rules.

2016-09-21 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4496 Change subject: IMPALA-4068: Follow-up with Roman Shaposhnik on branding rules. .. IMPALA-4068: Follow-up with Roman Shaposhnik on branding

[Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation

2016-09-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation .. Patch Set 6: Henry, which parts did you want someone else to +2? I think all of the stuff

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

2016-09-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4497 Change subject: IMPALA-3671: Add query option to limit scratch space usage .. IMPALA-3671: Add query option to limit scratch space usage

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: before we go too far down that path, i think it would be a good idea that

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: Marcel, the current accumulation of row batches is wrong, so don't think it

[Impala-ASF-CR](asf-site) IMPALA-4068: Follow-up with Roman Shaposhnik on branding rules.

2016-09-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4068: Follow-up with Roman Shaposhnik on branding rules. .. Patch Set 1: Code-Review+2 Wfm, but it's pretty silly imo -- To view, visit

[Impala-ASF-CR](asf-site) IMPALA-4068: Follow-up with Roman Shaposhnik on branding rules.

2016-09-21 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: IMPALA-4068: Follow-up with Roman Shaposhnik on branding rules. .. IMPALA-4068: Follow-up with Roman Shaposhnik on branding rules. He notes: "It really

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

2016-09-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3671: Add query option to limit scratch space usage .. Patch Set 1: Code-Review+1 Continue from https://gerrit.cloudera.org/#/c/3938/ so that I'm listed

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

2016-09-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. Change subject: IMPALA-3671: Add query option to limit scratch space usage .. Abandoned Moved to https://gerrit.cloudera.org/#/c/4497 -- To view, visit

[Impala-ASF-CR] IMPALA-4050: Support starting webserver specified by hostname

2016-09-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4050: Support starting webserver specified by hostname .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4314/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR](asf-site) IMPALA-4068: Follow-up with Roman Shaposhnik on branding rules.

2016-09-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4068: Follow-up with Roman Shaposhnik on branding rules. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4496 To unsubscribe,

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: I took a look at NLJ-builder. It seems to do much the same thing as this

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-21 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 4: (6 comments) @Michael, comments addressed.

[Impala-ASF-CR] IMPALA-4117: Factor simple scheduler test code into own files

2016-09-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4117: Factor simple scheduler test code into own files .. Patch Set 1: (2 comments) Thanks for the review, please see PS2.

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-21 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has uploaded a new patch set (#4). Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. IMPALA-4101: qgen: Hive join predicates should only contains equality

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 18: (18 comments)

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 5: Code-Review+1 A committer needs to look at this for +2 -- To

[Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation

2016-09-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation .. Patch Set 9: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-21 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-21 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 17: (3 comments)

[Impala-ASF-CR] IMPALA-3504: function for current timestamp in UTC, i.e. utc timestamp()

2016-09-21 Thread Youwei Wang (Code Review)
Youwei Wang has posted comments on this change. Change subject: IMPALA-3504: function for current timestamp in UTC, i.e. utc_timestamp() .. Patch Set 2: > > > As I mentioned in your previous review and/or the JIRA, this > >

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation

2016-09-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation

2016-09-21 Thread Tim Armstrong (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4163 to look at the new patch set (#7). Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation

[Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation

2016-09-21 Thread Tim Armstrong (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4163 to look at the new patch set (#8). Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation

[Impala-ASF-CR] IMPALA-4160: Remove some leftover Llama references

2016-09-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4160: Remove some leftover Llama references .. IMPALA-4160: Remove some leftover Llama references Change-Id:

[Impala-ASF-CR] IMPALA-4160: Remove some leftover Llama references

2016-09-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4160: Remove some leftover Llama references .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4493 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-21 Thread Amos Bird (Code Review)
Hello Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3942 to look at the new patch set (#18). Change subject: IMPALA-1654: General partition exprs in DDL operations.

[Impala-ASF-CR] IMPALA-3504: function for current timestamp in UTC, i.e. utc timestamp()

2016-09-21 Thread Youwei Wang (Code Review)
Youwei Wang has uploaded a new patch set (#2). Change subject: IMPALA-3504: function for current timestamp in UTC, i.e. utc_timestamp() .. IMPALA-3504: function for current timestamp in UTC, i.e. utc_timestamp() Implement a

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. IMPALA-4011: Remove / reword messages when statestore messages are late Change-Id:

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-09-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 1: (2 comments) Changes make a lot of sense to me.

[Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation

2016-09-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation .. Patch Set 9: Code-Review+1 Missed removing a function declaration in PS7 (didn't save my vim

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 6: (8 comments) Do we have any counters where we track running sum and number of samples and

[Impala-ASF-CR] IMPALA-4118: extract encryption utils from BufferedBlockMgr

2016-09-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr .. Patch Set 6: (11 comments) http://gerrit.cloudera.org:8080/#/c/4389/6/be/src/common/init.cc File

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4500 Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. IMPALA-4011: Remove / reword messages when

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-21 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-21 Thread Tim Armstrong (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3873 to look at the new patch set (#19). Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder ..

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 19: Code-Review+1 carry +1 -- To view, visit http://gerrit.cloudera.org:8080/3873 To

[Impala-ASF-CR] IMPALA-4171: Remove JAR from repo.

2016-09-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4171: Remove JAR from repo. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4499 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4117: Factor simple scheduler test code into own files

2016-09-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4117: Factor simple scheduler test code into own files .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4486 To unsubscribe,

[Impala-ASF-CR] IMPALA-4118: extract encryption utils from BufferedBlockMgr

2016-09-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4389/6/be/src/util/openssl-util.cc

[Impala-ASF-CR] IMPALA-4050: Support starting webserver specified by hostname

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4050: Support starting webserver specified by hostname .. Patch Set 1: I think you've submitted this patch without squashing it - so you've got two

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-21 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-4171: Remove JAR from repo.

2016-09-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4171: Remove JAR from repo. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4499/2/testdata/bin/copy-udfs-udas.sh File

[Impala-ASF-CR] IMPALA-4171: Remove JAR from repo.

2016-09-21 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4171: Remove JAR from repo. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4499/2/testdata/bin/copy-udfs-udas.sh File

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4171: Remove JAR from repo.

2016-09-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4171: Remove JAR from repo. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4499 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4171: Remove JAR from repo.

2016-09-21 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#3). Change subject: IMPALA-4171: Remove JAR from repo. .. IMPALA-4171: Remove JAR from repo. By ASF rules, we can't have JARs in releases. The releases are just tarballs of the repo.

[Impala-ASF-CR] IMPALA-4160: Remove some leftover Llama references

2016-09-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4160: Remove some leftover Llama references .. Patch Set 1: Code-Review+2 This passed a private build, running GVO now. -- To view, visit

[Impala-ASF-CR] IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible.

2016-09-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible. .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible.

2016-09-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible. .. IMPALA-4028: Improve message for improper Sentry config to