Youwei Wang has posted comments on this change.
Change subject: IMPALA-3504: function for current timestamp in UTC, i.e.
utc_timestamp()
..
Patch Set 1:
> As I mentioned in your previous review and/or the JIRA, this needs
> t
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3504: function for current timestamp in UTC, i.e.
utc_timestamp()
..
Patch Set 1:
> > As I mentioned in your previous review and/or the JIRA, this
> ne
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3902: Scheduler improvements for running multiple
fragment instances on a single backend
..
Patch Set 9:
(10 comments)
Publishing these comments becaus
Hello Lars Volker, Internal Jenkins, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4309
to look at the new patch set (#8).
Change subject: IMPALA-4028: Improve message for improper Sentry config to make
extra spaces visible.
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4028: Improve message for improper Sentry config to make
extra spaces visible.
..
Patch Set 8: Code-Review+2
Turns out there was a test for this error me
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4493
Change subject: IMPALA-4160: Remove some leftover Llama references
..
IMPALA-4160: Remove some leftover Llama references
Change-Id: I62
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables
..
Patch Set 1:
(9 comments)
... a few more things
http://gerrit.cloudera.org:8080/#/c/4414/1/f
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4160: Remove some leftover Llama references
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4493
To unsubscribe, visit h
Michael Brown has posted comments on this change.
Change subject: IMPALA-4101: qgen: Hive join predicates should only contains
equality functions
..
Patch Set 3:
(3 comments)
Thanks for adding a test!
http://gerrit.cloudera.
Alex Behm has posted comments on this change.
Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all
others
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pull-sin
Michael Brown has posted comments on this change.
Change subject: IMPALA-4101: qgen: Hive join predicates should only contains
equality functions
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4419/3//COMMIT
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all
others
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pul
Alex Behm has posted comments on this change.
Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all
others
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pull-sin
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables
..
Patch Set 1:
(3 comments)
sorry, more comments
I keep finding new things as I'm adding some
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4496
Change subject: IMPALA-4068: Follow-up with Roman Shaposhnik on branding rules.
..
IMPALA-4068: Follow-up with Roman Shaposhnik on branding r
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation
..
Patch Set 6:
Henry, which parts did you want someone else to +2? I think all of the stuff
unde
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4497
Change subject: IMPALA-3671: Add query option to limit scratch space usage
..
IMPALA-3671: Add query option to limit scratch space usage
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3671: Add query option to limit scratch space usage
..
Patch Set 1: Code-Review+1
Continue from https://gerrit.cloudera.org/#/c/3938/ so that I'm listed a
Tim Armstrong has abandoned this change.
Change subject: IMPALA-3671: Add query option to limit scratch space usage
..
Abandoned
Moved to https://gerrit.cloudera.org/#/c/4497
--
To view, visit http://gerrit.cloudera.org:8080/
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all
others
..
Patch Set 6:
before we go too far down that path, i think it would be a good idea that
Alex Behm has posted comments on this change.
Change subject: IMPALA-4050: Support starting webserver specified by hostname
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4314/1//COMMIT_MSG
Commit Message:
L
Alex Behm has posted comments on this change.
Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all
others
..
Patch Set 6:
Marcel, the current accumulation of row batches is wrong, so don't think it
make
Alex Behm has posted comments on this change.
Change subject: IMPALA-4068: Follow-up with Roman Shaposhnik on branding rules.
..
Patch Set 1: Code-Review+2
Wfm, but it's pretty silly imo
--
To view, visit http://gerrit.cloude
Jim Apple has posted comments on this change.
Change subject: IMPALA-4068: Follow-up with Roman Shaposhnik on branding rules.
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4496
To unsubscribe, vi
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all
others
..
Patch Set 6:
I took a look at NLJ-builder. It seems to do much the same thing as this pat
Jim Apple has submitted this change and it was merged.
Change subject: IMPALA-4068: Follow-up with Roman Shaposhnik on branding rules.
..
IMPALA-4068: Follow-up with Roman Shaposhnik on branding rules.
He notes:
"It really wou
Lars Volker has uploaded a new patch set (#2).
Change subject: IMPALA-4117: Factor simple scheduler test code into own files
..
IMPALA-4117: Factor simple scheduler test code into own files
This change merely splits the helper c
Lars Volker has posted comments on this change.
Change subject: IMPALA-4117: Factor simple scheduler test code into own files
..
Patch Set 1:
(2 comments)
Thanks for the review, please see PS2.
http://gerrit.cloudera.org:8080
stak...@cloudera.com has uploaded a new patch set (#4).
Change subject: IMPALA-4101: qgen: Hive join predicates should only contains
equality functions
..
IMPALA-4101: qgen: Hive join predicates should only contains equality fun
stak...@cloudera.com has posted comments on this change.
Change subject: IMPALA-4101: qgen: Hive join predicates should only contains
equality functions
..
Patch Set 4:
(6 comments)
@Michael, comments addressed.
http://gerri
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all
others
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pull
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all
others
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pull
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4499
Change subject: IMPALA-4171: Remove JAR from repo.
..
IMPALA-4171: Remove JAR from repo.
By ASF rules, we can't have JARs in releases. The r
Jim Apple has uploaded a new patch set (#2).
Change subject: IMPALA-4171: Remove JAR from repo.
..
IMPALA-4171: Remove JAR from repo.
By ASF rules, we can't have JARs in releases. The releases are just
tarballs of the repo.
Thi
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4117: Factor simple scheduler test code into own files
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4486
To unsubscri
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3873/14/be/src/exec/partitioned-hash-join-b
Michael Brown has posted comments on this change.
Change subject: IMPALA-4101: qgen: Hive join predicates should only contains
equality functions
..
Patch Set 4:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4419/4/tests/c
Alex Behm has posted comments on this change.
Change subject: IMPALA-4171: Remove JAR from repo.
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4499/2/testdata/bin/copy-udfs-udas.sh
File testdata/bin/copy-udfs
Jim Apple has uploaded a new patch set (#3).
Change subject: IMPALA-4171: Remove JAR from repo.
..
IMPALA-4171: Remove JAR from repo.
By ASF rules, we can't have JARs in releases. The releases are just
tarballs of the repo.
Thi
Jim Apple has posted comments on this change.
Change subject: IMPALA-4171: Remove JAR from repo.
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4499/2/testdata/bin/copy-udfs-udas.sh
File testdata/bin/copy-udfs
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all
others
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pul
Alex Behm has posted comments on this change.
Change subject: IMPALA-4171: Remove JAR from repo.
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4499
To unsubscribe, visit http://gerrit.cloudera
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4160: Remove some leftover Llama references
..
Patch Set 1: Code-Review+2
This passed a private build, running GVO now.
--
To view, visit http://gerrit
Alex Behm has posted comments on this change.
Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all
others
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pull-sin
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4028: Improve message for improper Sentry config to make
extra spaces visible.
..
IMPALA-4028: Improve message for improper Sentry config to m
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4028: Improve message for improper Sentry config to make
extra spaces visible.
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.cloudera.or
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder
..
Patch Set 18:
(18 comments)
http://gerrit.cloudera.org:8080/#/c/3873/18/be/src/exec/partitioned-hash-join
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4117: Factor simple scheduler test code into own files
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4486
To unsubscribe, v
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4389/6/be/src/util/openssl-util.cc
F
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation
..
Patch Set 6:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4163/6/be/src/runtime/coordinator.h
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-1654: General partition exprs in DDL operations.
..
Patch Set 17: Code-Review+1
(5 comments)
http://gerrit.cloudera.org:8080/#/c/3942/17/fe/src/ma
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4500
Change subject: IMPALA-4011: Remove / reword messages when statestore messages
are late
..
IMPALA-4011: Remove / reword messages when s
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3823: Add timer to measure Parquet footer reads
..
Patch Set 6:
(8 comments)
Do we have any counters where we track running sum and number of samples and
co
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4011: Remove / reword messages when statestore messages
are late
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4500/1/be/src/statest
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3823: Add timer to measure Parquet footer reads
..
Patch Set 6:
> Do we have any counters where we track running sum and number of samples and
> compute
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation
..
Patch Set 6:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4163/6/be/src/runtime/coordinato
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4163
to look at the new patch set (#7).
Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation
..
Patch Set 8: Code-Review+1
Rebase
--
To view, visit http://gerrit.cloudera.org:8080/4163
To u
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4163
to look at the new patch set (#8).
Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4163
to look at the new patch set (#9).
Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation
..
Patch Set 9: Code-Review+1
Missed removing a function declaration in PS7 (didn't save my vim bu
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4011: Remove / reword messages when statestore messages
are late
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4500/1/be/src/statest
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-4011: Remove / reword messages when statestore messages
are late
..
IMPALA-4011: Remove / reword messages when statestore messages are late
Change-Id: I09
Alex Behm has posted comments on this change.
Change subject: IMPALA-4023: don't attach buffered tuple streams to batches
..
Patch Set 1:
(2 comments)
Changes make a lot of sense to me.
http://gerrit.cloudera.org:8080/#/c/444
stak...@cloudera.com has uploaded a new patch set (#5).
Change subject: IMPALA-4101: qgen: Hive join predicates should only contains
equality functions
..
IMPALA-4101: qgen: Hive join predicates should only contains equality fun
stak...@cloudera.com has posted comments on this change.
Change subject: IMPALA-4101: qgen: Hive join predicates should only contains
equality functions
..
Patch Set 5:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4419/4/
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4011: Remove / reword messages when statestore messages
are late
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4500/1/b
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder
..
Patch Set 18:
(18 comments)
http://gerrit.cloudera.org:8080/#/c/3873/18/be/src/exec/partitioned-hash-
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3873
to look at the new patch set (#19).
Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder
..
IMPALA-
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder
..
Patch Set 19: Code-Review+1
carry +1
--
To view, visit http://gerrit.cloudera.org:8080/3873
To unsub
Michael Brown has posted comments on this change.
Change subject: IMPALA-4101: qgen: Hive join predicates should only contains
equality functions
..
Patch Set 5: Code-Review+1
A committer needs to look at this for +2
--
To v
Alex Behm has posted comments on this change.
Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr
..
Patch Set 6:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/4389/6/be/src/common/init.cc
File be/s
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation
..
Patch Set 9: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4163/6/be/src/service/
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder
..
Patch Set 19: Code-Review+2
This looks fine to me for the first step but please check with Michael if he
Amos Bird has posted comments on this change.
Change subject: IMPALA-1654: General partition exprs in DDL operations.
..
Patch Set 17:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3942/17/fe/src/main/java/com/cloudera/impa
Hello Bharath Vissapragada, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3942
to look at the new patch set (#18).
Change subject: IMPALA-1654: General partition exprs in DDL operations.
.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4171: Remove JAR from repo.
..
IMPALA-4171: Remove JAR from repo.
By ASF rules, we can't have JARs in releases. The releases are just
tarballs
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4171: Remove JAR from repo.
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4499
To unsubscribe, visit http://gerrit.clou
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4160: Remove some leftover Llama references
..
IMPALA-4160: Remove some leftover Llama references
Change-Id: I62e12363ab3ecca42bf7a82be3c2df01
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4160: Remove some leftover Llama references
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4493
To unsubscribe, visit ht
Youwei Wang has uploaded a new patch set (#2).
Change subject: IMPALA-3504: function for current timestamp in UTC, i.e.
utc_timestamp()
..
IMPALA-3504: function for current timestamp in UTC, i.e. utc_timestamp()
Implement a UDF
Youwei Wang has posted comments on this change.
Change subject: IMPALA-3504: function for current timestamp in UTC, i.e.
utc_timestamp()
..
Patch Set 2:
> > > As I mentioned in your previous review and/or the JIRA, this
> > n
Juan Yu has posted comments on this change.
Change subject: IMPALA-4011: Remove / reword messages when statestore messages
are late
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4500/2/be/src/statestore/stat
Alex Behm has posted comments on this change.
Change subject: IMPALA-1654: General partition exprs in DDL operations.
..
Patch Set 18: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/3942
To unsubscribe, visit
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4011: Remove / reword messages when statestore messages
are late
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4500
To
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4117: Factor simple scheduler test code into own files
..
IMPALA-4117: Factor simple scheduler test code into own files
This change merely spl
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4117: Factor simple scheduler test code into own files
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4486
To unsubscrib
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4011: Remove / reword messages when statestore messages
are late
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4500/2/be/src/statesto
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4050: Support starting webserver specified by hostname
..
Patch Set 1:
I think you've submitted this patch without squashing it - so you've got two
IMPA
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation
..
Patch Set 9:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4163/6/be/src/service/child-quer
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation
..
Patch Set 11: Code-Review+2
Rebase, carry +2
--
To view, visit http://gerrit.cloudera.org:808
Hello Henry Robinson, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4163
to look at the new patch set (#10).
Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation
Tim Armstrong has uploaded a new patch set (#7).
Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr
..
IMPALA-4118: extract encryption utils from BufferedBlockMgr
As groundwork for IMPALA-4118, extract e
93 matches
Mail list logo
