[kudu-CR] Fix TSAN race in log throttler

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix TSAN race in log throttler .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3254/ -- To view, visit http://gerrit.cloudera.org:8080/4324

[kudu-CR] Fix TSAN race in log throttler

2016-09-07 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4324 to review the following change. Change subject: Fix TSAN race in log throttler .. Fix TSAN race in log throttler

[kudu-CR] KUDU-1065: [java client] Flexible Partition Pruning

2016-09-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1065: [java client] Flexible Partition Pruning .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time .. Patch Set 4: Build Started

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/4164/7//COMMIT_MSG Commit Message: PS7, Line 25: 1M

[kudu-CR] KUDU-1065: [java client] Flexible Partition Pruning

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1065: [java client] Flexible Partition Pruning .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3258/ -- To view, visit

[kudu-CR] KUDU-1065: [java client] Flexible Partition Pruning

2016-09-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1065: [java client] Flexible Partition Pruning .. Patch Set 1: (32 comments)

[kudu-CR] KUDU-1065: [java client] Flexible Partition Pruning

2016-09-07 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4299 to look at the new patch set (#2). Change subject: KUDU-1065: [java client] Flexible Partition Pruning ..

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time .. Patch Set 2: (2 comments)

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4133 to look at the new patch set (#7). Change subject: Cleanup/refactor tracking of consensus watermarks

[kudu-CR] docs: fix list of support encodings

2016-09-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: docs: fix list of support encodings .. docs: fix list of support encodings Change-Id: I47d7b29c802b0c8fee178b59d2e26ab00bbfbc72 Reviewed-on:

[kudu-CR] docs: fix list of support encodings

2016-09-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: fix list of support encodings .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4322 To unsubscribe, visit

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4133/7/src/kudu/consensus/consensus_queue.cc

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/4133/6/src/kudu/consensus/consensus_queue.cc

[kudu-CR] WIP: tie log retention to consensus watermarks

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: tie log retention to consensus watermarks .. Patch Set 1: (3 comments) just responding to comments. will work on the TODOs in the patch and add tests.

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time .. Patch Set 3: Build Started

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-07 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4315 to look at the new patch set (#3). Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time .. Patch Set 3: (1 comment)

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/3257/ -- To view, visit

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 7: (2 comments)

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time .. Patch Set 3: (1 comment)

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] WIP: tie log retention to consensus watermarks

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: tie log retention to consensus watermarks .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3262/ -- To view, visit

[kudu-CR] WIP: tie log retention to consensus watermarks

2016-09-07 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4177 to look at the new patch set (#2). Change subject: WIP: tie log retention to consensus watermarks .. WIP: tie log

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time .. Patch Set 5: Build Started

[kudu-CR] WIP: tie log retention to consensus watermarks

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: tie log retention to consensus watermarks .. Patch Set 1: ok, new patch is largely cleaned up, though still planning on adding a test or two. Worth

[kudu-CR] Tie log retention to consensus watermarks

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Tie log retention to consensus watermarks .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3265/ -- To view, visit

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time .. Patch Set 4: (4 comments)

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-07 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4315 to look at the new patch set (#6). Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time .. Patch Set 6: (4 comments)

[kudu-CR] Tie log retention to consensus watermarks

2016-09-07 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4177 to look at the new patch set (#5). Change subject: Tie log retention to consensus watermarks .. Tie log retention

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 7: Code-Review+1 (1 comment) lgtm, just a syntax nit

[kudu-CR] Predicate evaluation pushdown

2016-09-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 12: (18 comments) http://gerrit.cloudera.org:8080/#/c/3990/12/src/kudu/cfile/binary_dict_block.cc File

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/3266/ -- To view, visit

[kudu-CR] KUDU-1304 - [python] Enable listing of tablet servers

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1304 - [python] Enable listing of tablet servers .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3269/ -- To view, visit

[kudu-CR] KUDU-1304 - [python] Enable listing of tablet servers

2016-09-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/4328 Change subject: KUDU-1304 - [python] Enable listing of tablet servers .. KUDU-1304 - [python] Enable listing of tablet servers Kudu's

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time .. Patch Set 6: Build Started

[kudu-CR] WIP: tie log retention to consensus watermarks

2016-09-07 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4177 to look at the new patch set (#3). Change subject: WIP: tie log retention to consensus watermarks .. WIP: tie log

[kudu-CR] WIP: tie log retention to consensus watermarks

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: tie log retention to consensus watermarks .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3263/ -- To view, visit

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4133 to look at the new patch set (#8). Change subject: Cleanup/refactor tracking of consensus watermarks

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4133 To unsubscribe, visit

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 8: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/3267/ -- To view, visit

[kudu-CR] Tie log retention to consensus watermarks

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Tie log retention to consensus watermarks .. Patch Set 5: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/3268/ -- To view, visit

[kudu-CR] KUDU-1304 - [python] Enable listing of tablet servers

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1304 - [python] Enable listing of tablet servers .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4328/1/python/kudu/client.pyx File

[kudu-CR] dist test: set death signal on forked processes

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: dist_test: set death signal on forked processes .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3271/ -- To view, visit

[kudu-CR] tablet server-stress-test: limit runtime of this test

2016-09-07 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4329 to review the following change. Change subject: tablet_server-stress-test: limit runtime of this test ..

[kudu-CR] tablet server-stress-test: limit runtime of this test

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tablet_server-stress-test: limit runtime of this test .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3270/ -- To view, visit

[kudu-CR] dist test: set death signal on forked processes

2016-09-07 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4330 to review the following change. Change subject: dist_test: set death signal on forked processes .. dist_test: set

[kudu-CR] Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9 .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3272/ -- To view,

[kudu-CR] Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4331 Change subject: Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9 .. Fix compilation error after

[kudu-CR] Predicate evaluation pushdown

2016-09-07 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#13). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-07 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4164 to look at the new patch set (#8). Change subject: Inlined dispatch for predicate evaluation .. Inlined dispatch

[kudu-CR] Predicate evaluation pushdown

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 13: Build Started http://104.196.14.100/job/kudu-gerrit/3273/ -- To view, visit http://gerrit.cloudera.org:8080/3990

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/3274/ -- To view, visit

[kudu-CR] Predicate evaluation pushdown

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3990 To unsubscribe, visit

[kudu-CR] Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9 .. Patch Set 1: Verified+1 Build got past compilation, so checking this in to fix master --

[kudu-CR] Predicate evaluation pushdown

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3990 To unsubscribe, visit

[kudu-CR] tablet server-stress-test: limit runtime of this test

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tablet_server-stress-test: limit runtime of this test .. tablet_server-stress-test: limit runtime of this test This stress test is typically the long

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time .. KUDU-1593 - [python] Allow to set the number of replicas

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4164/8/src/kudu/common/column_predicate.cc File

[kudu-CR] KUDU-1420. client: remove unimplemented ApplyAsync() method

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1420. client: remove unimplemented ApplyAsync() method .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3277/ -- To view, visit

[kudu-CR] KUDU-1420. client: remove unimplemented ApplyAsync() method

2016-09-07 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4332 to review the following change. Change subject: KUDU-1420. client: remove unimplemented ApplyAsync() method

[kudu-CR] [server] clean-up: stringstream --> ostringstream

2016-09-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [server] clean-up: stringstream --> ostringstream .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4303 To unsubscribe, visit

[kudu-CR] Add release notes for tablet history GC

2016-09-07 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Add release notes for tablet history GC .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3988 To unsubscribe, visit

[kudu-CR] KUDU-1135 (part 1): avoid flushing cmeta to disk twice when voting

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1135 (part 1): avoid flushing cmeta to disk twice when voting .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3278/ -- To view, visit

[kudu-CR] tablet server-stress-test: limit runtime of this test

2016-09-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tablet_server-stress-test: limit runtime of this test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4329 To unsubscribe, visit

[kudu-CR] Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9

2016-09-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix compilation error after ce0fcd4dd65a23aebf2601570e335c1b6ce2a0c9 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4331 To

[kudu-CR] KUDU-1420. client: remove unimplemented ApplyAsync() method

2016-09-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1420. client: remove unimplemented ApplyAsync() method .. Patch Set 1: Code-Review+2 Alexey may or may not have started working on this. We talked about it a

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 19: (22 comments) http://gerrit.cloudera.org:8080/#/c/3076/19/src/kudu/tablet/compaction-test.cc File

[kudu-CR] Fix TSAN race in log throttler

2016-09-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Fix TSAN race in log throttler .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4324 To unsubscribe, visit

[kudu-CR] Fix TSAN race in log throttler

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix TSAN race in log throttler .. Fix TSAN race in log throttler After adding new log throttling code, some tests became flaky in TSAN. This should fix

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/4164/7//COMMIT_MSG Commit Message: PS7, Line 25: 1M

[kudu-CR] docs: fix list of support encodings

2016-09-07 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4322 to look at the new patch set (#2). Change subject: docs: fix list of support encodings .. docs: fix

[kudu-CR] docs: fix list of support encodings

2016-09-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: docs: fix list of support encodings .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3255/ -- To view, visit

[kudu-CR] compaction policy: avoid O(n^2) calls to EstimateOnDiskSize

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: compaction_policy: avoid O(n^2) calls to EstimateOnDiskSize .. compaction_policy: avoid O(n^2) calls to EstimateOnDiskSize In a cluster workload with a

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time .. Patch Set 2: (2 comments) looks mostly good, just a couple

[kudu-CR] Predicate evaluation pushdown

2016-09-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 12: (18 comments) mostly just some remaining nits, though I think I spotted one real bug too.

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-07 Thread Ara Ebrahimi (Code Review)
Ara Ebrahimi has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 1: (1 comment)

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 6: (3 comments)