[kudu-CR] [docs] - Impala doc - partitioning required

Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/4595 Change subject: [docs] - Impala doc - partitioning required .. [docs] - Impala doc - partitioning required It seems a blurb in the

[kudu-CR] dist-test: allow collecting the tmp dir of failed tests

Mike Percy has posted comments on this change. Change subject: dist-test: allow collecting the tmp dir of failed tests .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2336 To unsubscribe,

[kudu-CR] [docs] - Impala doc - partitioning required

Jordan Birdsell has uploaded a new patch set (#2). Change subject: [docs] - Impala doc - partitioning required .. [docs] - Impala doc - partitioning required It seems a blurb in the impala page got missed when partitioning

[kudu-CR] Replace some TSAN suppressions with annotations

Mike Percy has posted comments on this change. Change subject: Replace some TSAN suppressions with annotations .. Patch Set 1: Code-Review+2 seems to work. great -- To view, visit http://gerrit.cloudera.org:8080/4593 To

[kudu-CR] [java client] Temporarily ignore row count regressions in ITClient

Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/4597 Change subject: [java client] Temporarily ignore row count regressions in ITClient .. [java client] Temporarily ignore row count

[kudu-CR] [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader

Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader .. Patch Set 1: (7 comments)

[kudu-CR] [util] shorten names for key/mapped types

Alexey Serbin has posted comments on this change. Change subject: [util] shorten names for key/mapped types .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4584/1/src/kudu/gutil/map-util.h File

[kudu-CR] KUDU-1669. Java ITClient test can orphan processes

Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/4598 Change subject: KUDU-1669. Java ITClient test can orphan processes .. KUDU-1669. Java ITClient test can orphan processes

[kudu-CR] [tools] Implement a manual leader step down for a tablet

Alexey Serbin has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 9: (5 comments) There is one extra instance of "master_addresses" string literal and

[kudu-CR] [client-test] added basic test for RWYW behavior

Alexey Serbin has posted comments on this change. Change subject: [client-test] added basic test for RWYW behavior .. Patch Set 1: > Btw, a more interesting test, perhaps, would be one that _always_ > failed, i.e. that made

[kudu-CR] Replace some TSAN suppressions with annotations

Todd Lipcon has submitted this change and it was merged. Change subject: Replace some TSAN suppressions with annotations .. Replace some TSAN suppressions with annotations In the case that there is a known race, we can either

[kudu-CR] [client-test] added basic test for RWYW behavior

Alexey Serbin has posted comments on this change. Change subject: [client-test] added basic test for RWYW behavior .. Patch Set 1: > I have an ambivalent opinion regarding this test. > > Read Your Writes means that a client

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning .. Patch Set 4: (2 comments)

[kudu-CR] Clean up switch statements in column predicate.cc

Adar Dembo has posted comments on this change. Change subject: Clean up switch statements in column_predicate.cc .. Patch Set 1: Code-Review+2 OK, though I think Dinesh had added default switch statements to remove some

[kudu-CR](branch-1.0.x) [java client] make DateFormat safe to use

Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/4603 Change subject: [java client] make DateFormat safe to use .. [java client] make DateFormat safe to use Todd's error-prone patch

[kudu-CR](branch-1.0.x) KUDU-1623. Properly handle UPSERTS that only include PK column

Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/4604 Change subject: KUDU-1623. Properly handle UPSERTS that only include PK column .. KUDU-1623. Properly handle UPSERTS that only include PK

[kudu-CR](branch-1.0.x) cache: fix behavior on single-CPU systems

Todd Lipcon has posted comments on this change. Change subject: cache: fix behavior on single-CPU systems .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4608 To unsubscribe, visit

[kudu-CR](branch-1.0.x) KUDU-1652: Partition pruning fails with IS NOT NULL predicate on PK column

Todd Lipcon has posted comments on this change. Change subject: KUDU-1652: Partition pruning fails with IS NOT NULL predicate on PK column .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4607

[kudu-CR](branch-1.0.x) KUDU-1651: Check empty dict before decoder eval

Todd Lipcon has posted comments on this change. Change subject: KUDU-1651: Check empty dict before decoder eval .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4606 To unsubscribe, visit

[kudu-CR] [c++ client] added few deprecation notes

David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] added few deprecation notes .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4569/3//COMMIT_MSG Commit Message: Line 18:

[kudu-CR] Clean up switch statements in column predicate.cc

Hello Dinesh Bhat, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4599 to review the following change. Change subject: Clean up switch statements in column_predicate.cc ..

[kudu-CR] Clean up switch statements in column predicate.cc

Todd Lipcon has posted comments on this change. Change subject: Clean up switch statements in column_predicate.cc .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4599 To unsubscribe, visit

[kudu-CR] [c++ client] added few deprecation notes

Alexey Serbin has posted comments on this change. Change subject: [c++ client] added few deprecation notes .. Patch Set 3: (3 comments) Thank you for review! Will post updated version soon.

[kudu-CR](branch-1.0.x) KUDU-1652: Partition pruning fails with IS NOT NULL predicate on PK column

Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/4607 Change subject: KUDU-1652: Partition pruning fails with IS NOT NULL predicate on PK column .. KUDU-1652: Partition pruning fails with IS

[kudu-CR](branch-1.0.x) cache: fix behavior on single-CPU systems

Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/4608 Change subject: cache: fix behavior on single-CPU systems .. cache: fix behavior on single-CPU systems On a system with only a single

[kudu-CR] [client-test] added basic test for RWYW behavior

Alexey Serbin has posted comments on this change. Change subject: [client-test] added basic test for RWYW behavior .. Patch Set 1: > |The test loops when it sees timeout from a tablet replica > catching-up, not just to get

[kudu-CR] Clean up switch statements in column predicate.cc

Dan Burkert has submitted this change and it was merged. Change subject: Clean up switch statements in column_predicate.cc .. Clean up switch statements in column_predicate.cc Where possible, remove default branches in favor

[kudu-CR] KUDU-1640 - [python] Add IN-list predicate support

Dan Burkert has posted comments on this change. Change subject: KUDU-1640 - [python] Add IN-list predicate support .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4548/5/python/kudu/client.pyx File

[kudu-CR] [java client] Temporarily ignore row count regressions in ITClient

Adar Dembo has posted comments on this change. Change subject: [java client] Temporarily ignore row count regressions in ITClient .. Patch Set 1: (1 comment)

[kudu-CR] Clean up switch statements in column predicate.cc

Dinesh Bhat has posted comments on this change. Change subject: Clean up switch statements in column_predicate.cc .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR](branch-1.0.x) KUDU-1651: Check empty dict before decoder eval

Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/4606 Change subject: KUDU-1651: Check empty dict before decoder eval .. KUDU-1651: Check empty dict before decoder eval A completely null

[kudu-CR](branch-1.0.x) [java client] Fix an NPE in KuduException

Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/4605 Change subject: [java client] Fix an NPE in KuduException .. [java client] Fix an NPE in KuduException Saw this in a Jenkins run and also

[kudu-CR](branch-1.0.x) consensus: properly truncate all state when aborting operations

Todd Lipcon has posted comments on this change. Change subject: consensus: properly truncate all state when aborting operations .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4602 To

[kudu-CR](branch-1.0.x) KUDU-1623. Properly handle UPSERTS that only include PK column

Todd Lipcon has posted comments on this change. Change subject: KUDU-1623. Properly handle UPSERTS that only include PK column .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4604 To

[kudu-CR] KUDU-1654 - [python] Python 3 Client Test Failure: test table column

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1654 - [python] Python 3 Client Test Failure: test_table_column .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1669. Java ITClient test can orphan processes

Adar Dembo has posted comments on this change. Change subject: KUDU-1669. Java ITClient test can orphan processes .. Patch Set 1: BTW, the test failure appears to be exactly the one I filed KUDU-1669 about. Could you look

[kudu-CR] [c++ client] added few deprecation notes

David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] added few deprecation notes .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4569/3//COMMIT_MSG Commit Message: Line 18:

[kudu-CR](branch-1.0.x) consensus: properly truncate all state when aborting operations

Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/4602 Change subject: consensus: properly truncate all state when aborting operations .. consensus: properly truncate all state when aborting

[kudu-CR](branch-1.0.x) KUDU-1090: relax MemTracker uniqueness constraint

Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/4601 Change subject: KUDU-1090: relax MemTracker uniqueness constraint .. KUDU-1090: relax MemTracker uniqueness constraint This patch relaxes

[kudu-CR] java: fix kudu-client builds with TSAN-only thirdparty

Jean-Daniel Cryans has posted comments on this change. Change subject: java: fix kudu-client builds with TSAN-only thirdparty .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4577 To

[kudu-CR](branch-1.0.x) [java client] make DateFormat safe to use

Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] make DateFormat safe to use .. Patch Set 1: Code-Review+2 Verified+1 Unrelated C++ test failure. -- To view, visit

[kudu-CR](branch-1.0.x) KUDU-1652: Partition pruning fails with IS NOT NULL predicate on PK column

Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1652: Partition pruning fails with IS NOT NULL predicate on PK column .. KUDU-1652: Partition pruning fails with IS NOT NULL predicate on PK column

[kudu-CR](branch-1.0.x) KUDU-1651: Check empty dict before decoder eval

Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1651: Check empty dict before decoder eval .. KUDU-1651: Check empty dict before decoder eval A completely null dictionary-encoded column will yield

[kudu-CR](branch-1.0.x) KUDU-1623. Properly handle UPSERTS that only include PK column

Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1623. Properly handle UPSERTS that only include PK column .. KUDU-1623. Properly handle UPSERTS that only include PK column This fixes a bug

[kudu-CR](branch-1.0.x) KUDU-1090: relax MemTracker uniqueness constraint

Adar Dembo has posted comments on this change. Change subject: KUDU-1090: relax MemTracker uniqueness constraint .. Patch Set 1: Code-Review+2 Verified+1 The failure was a known flake in client-test. -- To view, visit

[kudu-CR](branch-1.0.x) KUDU-1090: relax MemTracker uniqueness constraint

Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1090: relax MemTracker uniqueness constraint .. KUDU-1090: relax MemTracker uniqueness constraint This patch relaxes the MemTracker uniqueness

[kudu-CR](branch-1.0.x) consensus: properly truncate all state when aborting operations

Dan Burkert has posted comments on this change. Change subject: consensus: properly truncate all state when aborting operations .. Patch Set 1: Verified+1 Pretty sure this failed due to a flake. -- To view, visit

[kudu-CR](branch-1.0.x) [java client] make DateFormat safe to use

Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] make DateFormat safe to use .. [java client] make DateFormat safe to use Todd's error-prone patch discovered this problem in

[kudu-CR](branch-1.0.x) consensus: properly truncate all state when aborting operations

Dan Burkert has submitted this change and it was merged. Change subject: consensus: properly truncate all state when aborting operations .. consensus: properly truncate all state when aborting operations This fixes a consensus

[kudu-CR](branch-1.0.x) [java client] Fix an NPE in KuduException

Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Fix an NPE in KuduException .. [java client] Fix an NPE in KuduException Saw this in a Jenkins run and also running ITClient on my

[kudu-CR](branch-1.0.x) [java client] Fix an NPE in KuduException

Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Fix an NPE in KuduException .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4605 To unsubscribe, visit

[kudu-CR](branch-1.0.x) cache: fix behavior on single-CPU systems

Dan Burkert has submitted this change and it was merged. Change subject: cache: fix behavior on single-CPU systems .. cache: fix behavior on single-CPU systems On a system with only a single CPU, shard_bits_ would be set to 0.

[kudu-CR] Remove newlines from raft consensus.cc state logging

Todd Lipcon has submitted this change and it was merged. Change subject: Remove newlines from raft_consensus.cc state logging .. Remove newlines from raft_consensus.cc state logging Removes an explicit newline from

[kudu-CR] Python - Clean up distutils classifiers and package information

Todd Lipcon has submitted this change and it was merged. Change subject: Python - Clean up distutils classifiers and package information .. Python - Clean up distutils classifiers and package information Updated development

[kudu-CR] [util] Fix a minor bug in AssertEventually()

Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4566 to look at the new patch set (#3). Change subject: [util] Fix a minor bug in AssertEventually()

[kudu-CR] [util] Fix a minor bug in AssertEventually()

Dinesh Bhat has posted comments on this change. Change subject: [util] Fix a minor bug in AssertEventually() .. Patch Set 3: > Please split out the column_predicate change to a separate patch, > since it's unrelated and I

[kudu-CR] Replace some TSAN suppressions with annotations

Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4593 to review the following change. Change subject: Replace some TSAN suppressions with annotations .. Replace

[kudu-CR] Bump up min negotiation threads in disk reservation-itest

Todd Lipcon has posted comments on this change. Change subject: Bump up min negotiation threads in disk_reservation-itest .. Patch Set 1: I think http://gerrit.cloudera.org:8080/4593 may be a better approach here. I'm

[kudu-CR] Replace some TSAN suppressions with annotations

Adar Dembo has posted comments on this change. Change subject: Replace some TSAN suppressions with annotations .. Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/4593/1//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

Adar Dembo has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. Patch Set 1: (4 comments) Good find.

[kudu-CR] [util] Fix a minor bug in AssertEventually()

Adar Dembo has posted comments on this change. Change subject: [util] Fix a minor bug in AssertEventually() .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4566 To unsubscribe, visit

[kudu-CR] [util] Fix a minor bug in AssertEventually()

Todd Lipcon has posted comments on this change. Change subject: [util] Fix a minor bug in AssertEventually() .. Patch Set 2: Verified-1 Please split out the column_predicate change to a separate patch, since it's unrelated

[kudu-CR] Bump up min negotiation threads in disk reservation-itest

Todd Lipcon has posted comments on this change. Change subject: Bump up min negotiation threads in disk_reservation-itest .. Patch Set 1: Fixing KUDU-1580 would also probably be a good way to address the root cause instead of

[kudu-CR] [util] Fix a minor bug in AssertEventually()

Todd Lipcon has posted comments on this change. Change subject: [util] Fix a minor bug in AssertEventually() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4566/2/src/kudu/common/column_predicate.cc File

[kudu-CR] rpc: Add min / max negotiation threads

Todd Lipcon has posted comments on this change. Change subject: rpc: Add min / max negotiation threads .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4574/1/src/kudu/rpc/messenger.h File

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4594 to review the following change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

[kudu-CR] [util] Fix a minor bug in AssertEventually()

Mike Percy has posted comments on this change. Change subject: [util] Fix a minor bug in AssertEventually() .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4566 To unsubscribe, visit

[kudu-CR] [util] Fix a minor bug in AssertEventually()

Mike Percy has submitted this change and it was merged. Change subject: [util] Fix a minor bug in AssertEventually() .. [util] Fix a minor bug in AssertEventually() We want to be sleeping with a monotonically increasing

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4491 to look at the new patch set (#8). Change subject: KUDU-1563. Add support for INSERT IGNORE .. KUDU-1563. Add

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4523 to look at the new patch set (#8). Change subject: [java] KUDU-1563. Add support for INSERT IGNORE .. [java]

[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4522 to look at the new patch set (#6). Change subject: [python] KUDU-1563. Add support for INSERT IGNORE .. [python]

[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE

Brock Noland has posted comments on this change. Change subject: [python] KUDU-1563. Add support for INSERT IGNORE .. Patch Set 5: (2 comments) Thank you!

[kudu-CR] KUDU-1640 - [python] Add IN-list predicate support

Jordan Birdsell has posted comments on this change. Change subject: KUDU-1640 - [python] Add IN-list predicate support .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/4548/5/python/kudu/client.pyx File

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4594 to look at the new patch set (#2). Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

[kudu-CR] [tools] Implement a manual leader step down for a tablet

Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4533 to look at the new patch set (#10). Change subject: [tools] Implement a manual leader_step_down for a tablet

[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

Brock Noland has posted comments on this change. Change subject: [java] KUDU-1563. Add support for INSERT IGNORE .. Patch Set 7: (6 comments)

[kudu-CR] [tools] Implement a manual leader step down for a tablet

Dinesh Bhat has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 9: (5 comments) > (5 comments) > > There is one extra instance of "master_addresses"