[kudu-CR] [thirdparty] Fix failing openssl check on MacOS

2018-05-09 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10355 to review the following change. Change subject: [thirdparty] Fix failing openssl check on MacOS

[kudu-CR] [thirdparty] Fix failing openssl check on MacOS

2018-05-09 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10355 to look at the new patch set (#3). Change subject: [thirdparty] Fix failing openssl check on MacOS

[kudu-CR] [flags] run validators after processing help flags

2018-05-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10342 ) Change subject: [flags] run validators after processing help flags .. Patch Set 5: (1 comment)

[kudu-CR] [thirdparty] Fix failing openssl check on MacOS

2018-05-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10355 ) Change subject: [thirdparty] Fix failing openssl check on MacOS .. Patch Set 2: (1 comment)

[kudu-CR] [thirdparty] Fix failing openssl check on MacOS

2018-05-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10355 ) Change subject: [thirdparty] Fix failing openssl check on MacOS .. Patch Set 3: Code-Review+1 Looks good though it'd be nice for another

[kudu-CR] [thirdparty] Fix failing openssl check on MacOS

2018-05-09 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10355 ) Change subject: [thirdparty] Fix failing openssl check on MacOS .. Patch Set 3: (1 comment) > Patch Set 2: > > (1 comment)

[kudu-CR] [docs] Update macOS build docs

2018-05-09 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10356 to look at the new patch set (#2). Change subject: [docs] Update macOS build docs ..

[kudu-CR] [docs] Update macOS build docs

2018-05-09 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10356 to review the following change. Change subject: [docs] Update macOS build docs .. [docs] Update macOS

[kudu-CR] [thirdparty] Fix failing openssl check on MacOS

2018-05-09 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10355 to look at the new patch set (#2). Change subject: [thirdparty] Fix failing openssl check on MacOS

[kudu-CR] [docs] Update macOS build docs

2018-05-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 ) Change subject: [docs] Update macOS build docs .. Patch Set 2: Is this relevant after 60c8e305bef9ace8688aabbf18e2f500e8d9135c ? --

[kudu-CR] [flags] run validators after processing help flags

2018-05-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10342 ) Change subject: [flags] run validators after processing help flags .. Patch Set 5: > (1 comment) Do I understand correctly that the

[kudu-CR] [docs] Update macOS build docs

2018-05-09 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 ) Change subject: [docs] Update macOS build docs .. Patch Set 2: > Patch Set 2: > > Is this relevant after

[kudu-CR] Add a table renaming tool

2018-05-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10337 ) Change subject: Add a table renaming tool .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10337 To

[kudu-CR] thirdparty: tweak clang compiler flags

2018-05-09 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10352 to look at the new patch set (#2). Change subject: thirdparty: tweak clang compiler flags ..

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

2018-05-09 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10293 ) Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck .. Patch Set 2: (1 comment) > Patch Set 2: > > (1 comment)

[kudu-CR] thirdparty: tweak clang compiler flags

2018-05-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10352 ) Change subject: thirdparty: tweak clang compiler flags .. Patch Set 2: (1 comment) I had to tweak this to get the tsan build to pass,

[kudu-CR] [flags] run validators after processing help flags

2018-05-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10342 ) Change subject: [flags] run validators after processing help flags .. Patch Set 5: > Do I understand correctly that the part of the

[kudu-CR] thirdparty: tweak clang compiler flags

2018-05-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10352 ) Change subject: thirdparty: tweak clang compiler flags .. Patch Set 2: (1 comment)

[kudu-CR] Add a table renaming tool

2018-05-09 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10337 ) Change subject: Add a table renaming tool .. Add a table renaming tool This commit introduces a tool to rename a table. When HMS

[kudu-CR] A new Jepsen checker for READ YOUR WRITES scan mode

2018-05-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9526 ) Change subject: A new Jepsen checker for READ_YOUR_WRITES scan mode .. Patch Set 12: (10 comments)

[kudu-CR] [thirdparty] Fix thirdparty build on Python 2.6

2018-05-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10359 ) Change subject: [thirdparty] Fix thirdparty build on Python 2.6 .. Patch Set 1: Code-Review+2 Tested to work on python 2.6 -- To view,

[kudu-CR] [thirdparty] Fix thirdparty build on Python 2.6

2018-05-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10359 ) Change subject: [thirdparty] Fix thirdparty build on Python 2.6 .. Patch Set 1: Verified+1 Overriding Jenkins due to an isolate issue

[kudu-CR] [thirdparty] Fix thirdparty build on Python 2.6

2018-05-09 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10359 ) Change subject: [thirdparty] Fix thirdparty build on Python 2.6 .. [thirdparty] Fix thirdparty build on Python 2.6 60c8e305b

[kudu-CR] [thirdparty] Fix thirdparty build on Python 2.6

2018-05-09 Thread Mike Percy (Code Review)
Mike Percy has removed a vote on this change. Change subject: [thirdparty] Fix thirdparty build on Python 2.6 .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10359 To unsubscribe,

[kudu-CR] [thirdparty] Fix thirdparty build on Python 2.6

2018-05-09 Thread Attila Bukor (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10359 to review the following change. Change subject: [thirdparty] Fix thirdparty build on Python 2.6

[kudu-CR] thirdparty: tweak clang compiler flags

2018-05-09 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10352 to look at the new patch set (#3). Change subject: thirdparty: tweak clang compiler flags ..

[kudu-CR] thirdparty: tweak clang compiler flags

2018-05-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10352 ) Change subject: thirdparty: tweak clang compiler flags .. Patch Set 3: (1 comment)

[kudu-CR] A new Jepsen checker for READ YOUR WRITES scan mode

2018-05-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9526 ) Change subject: A new Jepsen checker for READ_YOUR_WRITES scan mode .. Patch Set 13: (8 comments)

[kudu-CR] A new Jepsen checker for READ YOUR WRITES scan mode

2018-05-09 Thread Hao Hao (Code Review)
Hello Alexey Serbin, David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9526 to look at the new patch set (#13). Change subject: A new Jepsen checker for READ_YOUR_WRITES scan mode

[kudu-CR] A new Jepsen checker for READ YOUR WRITES scan mode

2018-05-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9526 ) Change subject: A new Jepsen checker for READ_YOUR_WRITES scan mode .. Patch Set 13: Verified+1 Unrelated flaky test. -- To view, visit

[kudu-CR] A new Jepsen checker for READ YOUR WRITES scan mode

2018-05-09 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: A new Jepsen checker for READ_YOUR_WRITES scan mode .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9526 To unsubscribe,

[kudu-CR] thirdparty: tweak clang compiler flags

2018-05-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10352 ) Change subject: thirdparty: tweak clang compiler flags .. Patch Set 3: (1 comment)

[kudu-CR] Add a way to pin clean time advancement

2018-05-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9641 ) Change subject: Add a way to pin clean time advancement .. Patch Set 4: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2426 Fix WRONG SERVER UUID case in ksck

2018-05-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10293 ) Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck .. Patch Set 2: (1 comment)

[kudu-CR] WIP [rebalancing] high-level rebalancing algorithm

2018-05-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 ) Change subject: WIP [rebalancing] high-level rebalancing algorithm .. Patch Set 3: (55 comments) Thank you for the thorough review!

[kudu-CR] WIP [rebalancing] high-level rebalancing algorithm

2018-05-09 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10336 to look at the new patch set (#4). Change subject: WIP [rebalancing] high-level rebalancing algorithm

[kudu-CR] [flags] run validators after processing help flags

2018-05-09 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Jean-Daniel Cryans, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10342 to look at the new patch set (#6). Change subject: [flags] run validators after processing help flags

[kudu-CR] [flags] run validators after processing help flags

2018-05-09 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10342 to look at the new patch set (#7). Change subject: [flags] run validators after processing help flags

[kudu-CR] [thirdparty] Fix failing openssl check on MacOS

2018-05-09 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10355 ) Change subject: [thirdparty] Fix failing openssl check on MacOS .. [thirdparty] Fix failing openssl check on MacOS Since

[kudu-CR] [thirdparty] Fix failing openssl check on MacOS

2018-05-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10355 ) Change subject: [thirdparty] Fix failing openssl check on MacOS .. Patch Set 3: Code-Review+2 Works on my Homebrew machine. -- To