[kudu-CR] Fix RAT warnings

2018-10-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11632 ) Change subject: Fix RAT warnings .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11632 To

[kudu-CR] Improve logging for mini HMS and Sentry services

2018-10-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11635 ) Change subject: Improve logging for mini HMS and Sentry services .. Patch Set 1: (3 comments)

[kudu-CR] Improve logging for mini HMS and Sentry services

2018-10-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11635 ) Change subject: Improve logging for mini HMS and Sentry services .. Patch Set 2: (3 comments)

[kudu-CR] Improve logging for mini HMS and Sentry services

2018-10-09 Thread Dan Burkert (Code Review)
Hello Andrew Wong, Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11635 to look at the new patch set (#2). Change subject: Improve logging for mini HMS and Sentry services

[kudu-CR] Improve logging for mini HMS and Sentry services

2018-10-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11635 ) Change subject: Improve logging for mini HMS and Sentry services .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] dist test: collect the correct tmpdir

2018-10-09 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11642 Change subject: dist_test: collect the correct tmpdir .. dist_test: collect the correct tmpdir Over the course of many refactors, we've

[kudu-CR] [test] use LocationInfo in ts itest base

2018-10-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11643 Change subject: [test] use LocationInfo in ts_itest_base .. [test] use LocationInfo in ts_itest_base Added LocationInfo parameter into

[kudu-CR] dist test: collect the correct tmpdir

2018-10-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11642 ) Change subject: dist_test: collect the correct tmpdir .. Patch Set 1: I'm pretty sure about the explanation of Java tests, based on

[kudu-CR] Improve logging for mini HMS and Sentry services

2018-10-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11635 ) Change subject: Improve logging for mini HMS and Sentry services .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [compaction] KUDU-2056: Expose a metric for how much a tablet needs to be compacted

2018-10-09 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11639 Change subject: [compaction] KUDU-2056: Expose a metric for how much a tablet needs to be compacted .. [compaction] KUDU-2056: Expose

[kudu-CR] Cleanup in rowset SVG layout dumping

2018-10-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11612 ) Change subject: Cleanup in rowset SVG layout dumping .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2324 Add gflags to disable individual maintenance ops

2018-10-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11609 ) Change subject: KUDU-2324 Add gflags to disable individual maintenance ops .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2324 Add gflags to disable individual maintenance ops

2018-10-09 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11609 ) Change subject: KUDU-2324 Add gflags to disable individual maintenance ops .. Patch Set 5: (1 comment)

[kudu-CR] [compaction] Small improvements to compaction policy tests

2018-10-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11605 ) Change subject: [compaction] Small improvements to compaction policy tests .. Patch Set 2: (4 comments)

[kudu-CR] [docs] Add brief instructions on decommissioning tablet servers

2018-10-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11618 ) Change subject: [docs] Add brief instructions on decommissioning tablet servers .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Cleanup in rowset SVG layout dumping

2018-10-09 Thread Attila Bukor (Code Review)
Attila Bukor has removed a vote on this change. Change subject: Cleanup in rowset SVG layout dumping .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11612 To unsubscribe, visit

[kudu-CR] Cleanup in rowset SVG layout dumping

2018-10-09 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11612 ) Change subject: Cleanup in rowset SVG layout dumping .. Patch Set 4: Verified+1 -- To view, visit

[kudu-CR] [docs] Add brief instructions on decommissioning tablet servers

2018-10-09 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11618 ) Change subject: [docs] Add brief instructions on decommissioning tablet servers .. [docs] Add brief instructions on

[kudu-CR] KUDU-2324 Add gflags to disable individual maintenance ops

2018-10-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11609 ) Change subject: KUDU-2324 Add gflags to disable individual maintenance ops .. Patch Set 4: (1 comment)

[kudu-CR] [compaction] Small improvements to compaction policy tests

2018-10-09 Thread Will Berkeley (Code Review)
Hello Mike Percy, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11605 to look at the new patch set (#3). Change subject: [compaction] Small improvements to compaction policy tests

[kudu-CR] [compaction] Small improvements to compaction policy tests

2018-10-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11605 ) Change subject: [compaction] Small improvements to compaction policy tests .. Patch Set 2: (5 comments)

[kudu-CR] KUDU-2324 Add gflags to disable individual maintenance ops

2018-10-09 Thread Will Berkeley (Code Review)
Hello Fengling Wang, Mike Percy, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11609 to look at the new patch set (#6). Change subject: KUDU-2324 Add gflags to disable

[kudu-CR] Cleanup in rowset SVG layout dumping

2018-10-09 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11612 ) Change subject: Cleanup in rowset SVG layout dumping .. Cleanup in rowset SVG layout dumping I tested this by manually

[kudu-CR] [compaction] Small improvements to compaction policy tests

2018-10-09 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11605 ) Change subject: [compaction] Small improvements to compaction policy tests .. Patch Set 2: (1 comment)

[kudu-CR] [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements

2018-10-09 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11613 to look at the new patch set (#5). Change subject: [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements

[kudu-CR] [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements

2018-10-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11613 ) Change subject: [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements .. Patch Set 5: Code-Review+2 (1 comment)

[kudu-CR] [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements

2018-10-09 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11613 ) Change subject: [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements .. [webui] KUDU-844 and other

[kudu-CR] [tests] location assignment for ExternaMiniCluster

2018-10-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11606 ) Change subject: [tests] location assignment for ExternaMiniCluster .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator

2018-10-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/11395 ) Change subject: KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator .. Patch Set 9: +2ing but might make sense to add

[kudu-CR] KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator

2018-10-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/11395 ) Change subject: KUDU-686 (part 2/2): use DeltaPreparer in DeltaFileIterator .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2324 Add gflags to disable individual maintenance ops

2018-10-09 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11609 ) Change subject: KUDU-2324 Add gflags to disable individual maintenance ops .. KUDU-2324 Add gflags to disable individual

[kudu-CR] [compaction] Small improvements to compaction policy tests

2018-10-09 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11605 ) Change subject: [compaction] Small improvements to compaction policy tests .. [compaction] Small improvements to compaction

[kudu-CR] [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements

2018-10-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11613 ) Change subject: [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements .. Patch Set 5: Code-Review+1 (1 comment)

[kudu-CR] [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements

2018-10-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11613 ) Change subject: [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2324 Add gflags to disable individual maintenance ops

2018-10-09 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11609 ) Change subject: KUDU-2324 Add gflags to disable individual maintenance ops .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] [compaction] Small improvements to compaction policy tests

2018-10-09 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11605 ) Change subject: [compaction] Small improvements to compaction policy tests .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements

2018-10-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11613 ) Change subject: [webui] KUDU-844 and other /tablet-rowsetlayout-svg improvements .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer

2018-10-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/11394 ) Change subject: KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer .. Patch Set 8: Code-Review+2 -- To

[kudu-CR] Fix RAT warnings

2018-10-09 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11632 ) Change subject: Fix RAT warnings .. Fix RAT warnings Change-Id: If18dc7321ba0294d9d640064f25e5b3d3bca1914 Reviewed-on:

[kudu-CR] Improve logging for mini HMS and Sentry services

2018-10-09 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11635 ) Change subject: Improve logging for mini HMS and Sentry services .. Improve logging for mini HMS and Sentry services This

[kudu-CR](branch-1.8.x) Fix RAT warnings

2018-10-09 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: Fix RAT warnings .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11631 To unsubscribe, visit

[kudu-CR](branch-1.8.x) Fix RAT warnings

2018-10-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11631 ) Change subject: Fix RAT warnings .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11631 To

[kudu-CR](branch-1.8.x) Fix RAT warnings

2018-10-09 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11631 ) Change subject: Fix RAT warnings .. Fix RAT warnings Change-Id: If18dc7321ba0294d9d640064f25e5b3d3bca1914 Reviewed-on:

[kudu-CR] Fix RAT warnings

2018-10-09 Thread Attila Bukor (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11632 to look at the new patch set (#2). Change subject: Fix RAT warnings .. Fix RAT warnings Change-Id:

[kudu-CR] [tools] separated rebalancer tests from kudu-admin-test

2018-10-09 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11640 to look at the new patch set (#2). Change subject: [tools] separated rebalancer tests from kudu-admin-test

[kudu-CR] Fix RAT warnings

2018-10-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11632 ) Change subject: Fix RAT warnings .. Patch Set 1: (1 comment)

[kudu-CR] Improve logging for mini HMS and Sentry services

2018-10-09 Thread Dan Burkert (Code Review)
Hello Andrew Wong, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11635 to review the following change. Change subject: Improve logging for mini HMS and Sentry services .. Improve

[kudu-CR](branch-1.8.x) Fix RAT warnings

2018-10-09 Thread Attila Bukor (Code Review)
Attila Bukor has restored this change. ( http://gerrit.cloudera.org:8080/11631 ) Change subject: Fix RAT warnings .. Restored -- To view, visit http://gerrit.cloudera.org:8080/11631 To unsubscribe, visit

[kudu-CR](branch-1.8.x) Fix RAT warnings

2018-10-09 Thread Attila Bukor (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11631 to look at the new patch set (#3). Change subject: Fix RAT warnings .. Fix RAT warnings Change-Id:

[kudu-CR] [tools] separated rebalancer tests from kudu-admin-test

2018-10-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11640 Change subject: [tools] separated rebalancer tests from kudu-admin-test .. [tools] separated rebalancer tests from kudu-admin-test

[kudu-CR] [location awareness] Add location info in ksck report

2018-10-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 8: (1 comment)

[kudu-CR] [docs] Fix placement of decommission docs in rebalancing section

2018-10-09 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11627 ) Change subject: [docs] Fix placement of decommission docs in rebalancing section .. [docs] Fix placement of decommission docs

[kudu-CR] [tests] location assignment for ExternaMiniCluster

2018-10-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11606 ) Change subject: [tests] location assignment for ExternaMiniCluster .. [tests] location assignment for ExternaMiniCluster

[kudu-CR] [docs] Fix placement of decommission docs in rebalancing section

2018-10-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11627 ) Change subject: [docs] Fix placement of decommission docs in rebalancing section .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [docs] Fix placement of decommission docs in rebalancing section

2018-10-09 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11627 ) Change subject: [docs] Fix placement of decommission docs in rebalancing section .. Patch Set 1: Verified+1 Docs-only change -- To

[kudu-CR] [docs] Fix placement of decommission docs in rebalancing section

2018-10-09 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11627 Change subject: [docs] Fix placement of decommission docs in rebalancing section .. [docs] Fix placement of decommission docs in

[kudu-CR] [docs] Fix placement of decommission docs in rebalancing section

2018-10-09 Thread Will Berkeley (Code Review)
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11627 ) Change subject: [docs] Fix placement of decommission docs in rebalancing section .. Removed reviewer Kudu Jenkins. -- To view,

[kudu-CR] Update version to 1.9.0-SNAPSHOT

2018-10-09 Thread Attila Bukor (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11628 to review the following change. Change subject: Update version to 1.9.0-SNAPSHOT .. Update version to 1.9.0-SNAPSHOT

[kudu-CR](branch-1.8.x) Bump version to 1.8.0 (non-SNAPSHOT)

2018-10-09 Thread Attila Bukor (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11629 to review the following change. Change subject: Bump version to 1.8.0 (non-SNAPSHOT) .. Bump version to 1.8.0

[kudu-CR](branch-1.8.x) Bump version to 1.8.0 (non-SNAPSHOT)

2018-10-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11629 ) Change subject: Bump version to 1.8.0 (non-SNAPSHOT) .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR] Update version to 1.9.0-SNAPSHOT

2018-10-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11628 ) Change subject: Update version to 1.9.0-SNAPSHOT .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR] Update version to 1.9.0-SNAPSHOT

2018-10-09 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11628 ) Change subject: Update version to 1.9.0-SNAPSHOT .. Update version to 1.9.0-SNAPSHOT Change-Id:

[kudu-CR](branch-1.8.x) Bump version to 1.8.0 (non-SNAPSHOT)

2018-10-09 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11629 ) Change subject: Bump version to 1.8.0 (non-SNAPSHOT) .. Bump version to 1.8.0 (non-SNAPSHOT) Change-Id:

[kudu-CR](branch-1.8.x) Fix RAT warnings

2018-10-09 Thread Attila Bukor (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11631 to review the following change. Change subject: Fix RAT warnings .. Fix RAT warnings Change-Id:

[kudu-CR](branch-1.8.x) Fix RAT warnings

2018-10-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11631 ) Change subject: Fix RAT warnings .. Patch Set 1: (1 comment)

[kudu-CR](branch-1.8.x) Fix RAT warnings

2018-10-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11631 ) Change subject: Fix RAT warnings .. Patch Set 1: These should probably go to master and then be cherry-picked back to the 1.8 branch.

[kudu-CR](branch-1.8.x) Fix RAT warnings

2018-10-09 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11631 ) Change subject: Fix RAT warnings .. Patch Set 1: (1 comment) > Patch Set 1: > > These should probably go to master and then be

[kudu-CR](branch-1.8.x) Fix RAT warnings

2018-10-09 Thread Attila Bukor (Code Review)
Attila Bukor has abandoned this change. ( http://gerrit.cloudera.org:8080/11631 ) Change subject: Fix RAT warnings .. Abandoned pushing to master instead -- To view, visit http://gerrit.cloudera.org:8080/11631 To unsubscribe,

[kudu-CR] Fix RAT warnings

2018-10-09 Thread Attila Bukor (Code Review)
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11632 to review the following change. Change subject: Fix RAT warnings .. Fix RAT warnings Change-Id: