[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11869 ) Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs .. Patch Set 3: The alter

[kudu-CR] [tools] reference comparison mode for rebalancing algo tests

2018-11-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11870 Change subject: [tools] reference comparison mode for rebalancing algo tests .. [tools] reference comparison mode for rebalancing algo

[kudu-CR] KUDU-1918 Prevent hijacking of scanner IDs

2018-11-02 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/6348 ) Change subject: KUDU-1918 Prevent hijacking of scanner IDs .. Patch Set 6: (7 comments)

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11869 ) Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs .. Patch Set 3: The tablet

[kudu-CR] KUDU-1918 Prevent hijacking of scanner IDs

2018-11-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6348 ) Change subject: KUDU-1918 Prevent hijacking of scanner IDs .. Patch Set 7: (7 comments)

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11869 ) Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs .. Patch Set 3: > I need to

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11869 ) Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs .. Patch Set 3: I'm not sure

[kudu-CR] KUDU-1918 Prevent hijacking of scanner IDs

2018-11-02 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#7) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/6348 ) Change subject: KUDU-1918 Prevent hijacking of scanner IDs .. KUDU-1918 Prevent hijacking

[kudu-CR] [rebalancer] location-aware rebalancer (part 9/n)

2018-11-02 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11862 to look at the new patch set (#3). Change subject: [rebalancer] location-aware rebalancer (part 9/n)

[kudu-CR] [rebalancer] location-aware rebalancer (part 9/n)

2018-11-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11862 ) Change subject: [rebalancer] location-aware rebalancer (part 9/n) .. Patch Set 3: (6 comments)

[kudu-CR] [test] optional table creation in TabletServerIntegrationTestBase

2018-11-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11861 Change subject: [test] optional table creation in TabletServerIntegrationTestBase .. [test] optional table creation in

[kudu-CR] [rebalancer] location-aware rebalancer (part 9/n)

2018-11-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11862 Change subject: [rebalancer] location-aware rebalancer (part 9/n) .. [rebalancer] location-aware rebalancer (part 9/n) Updated

[kudu-CR] [sentry] add AuthzProvider

2018-11-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 10: (1 comment)

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11827 ) Change subject: [compaction] Cleanup of compaction policy code .. [compaction] Cleanup of compaction policy code I'm reading

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-11-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11827 ) Change subject: [compaction] Cleanup of compaction policy code .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] (02/05) delta store: convert DeltaIterator::PrepareBatch flags into bitfield

2018-11-02 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11857 ) Change subject: (02/05) delta_store: convert DeltaIterator::PrepareBatch flags into bitfield .. Removed reviewer Kudu Jenkins

[kudu-CR] (02/05) delta store: convert DeltaIterator::PrepareBatch flags into bitfield

2018-11-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11857 ) Change subject: (02/05) delta_store: convert DeltaIterator::PrepareBatch flags into bitfield .. Patch Set 2: Verified+1 Overriding

[kudu-CR] [examples] Add basic Spark example (scala)

2018-11-02 Thread Mitch Barnett (Code Review)
Mitch Barnett has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example (scala) .. Patch Set 11: (5 comments)

[kudu-CR] [examples] Add basic Spark example (scala)

2018-11-02 Thread Mitch Barnett (Code Review)
Hello Will Berkeley, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11788 to look at the new patch set (#12). Change subject: [examples] Add basic Spark example (scala)

[kudu-CR] [examples] Add basic Spark example (scala)

2018-11-02 Thread Mitch Barnett (Code Review)
Mitch Barnett has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example (scala) .. Patch Set 11: (1 comment)

[kudu-CR] move HashAlgorithm from common.proto to hash.proto

2018-11-02 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11865 to look at the new patch set (#2). Change subject: move HashAlgorithm from common.proto to hash.proto

[kudu-CR] [examples] Add basic Spark example (scala)

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example (scala) .. Patch Set 12: Code-Review+1 LGTM -- To view, visit

[kudu-CR] move HashAlgorithm from common.proto to hash.proto

2018-11-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11865 ) Change subject: move HashAlgorithm from common.proto to hash.proto .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] move HashAlgorithm from common.proto to hash.proto

2018-11-02 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11865 ) Change subject: move HashAlgorithm from common.proto to hash.proto .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [sentry] add AuthzProvider

2018-11-02 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11659 to look at the new patch set (#13). Change subject: [sentry] add AuthzProvider

[kudu-CR] [sentry] add AuthzProvider

2018-11-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 13: Code-Review+2 LGTM as long as Alexey's content -- To view, visit

[kudu-CR] (05/05) delta applier: support for diff scan style iteration

2018-11-02 Thread Adar Dembo (Code Review)
Hello Mike Percy, David Ribeiro Alves, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11860 to look at the new patch set (#3). Change subject: (05/05) delta_applier: support for diff scan style iteration

[kudu-CR] (04/05) delta store: support iteration with is deleted virtual column

2018-11-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11859 ) Change subject: (04/05) delta_store: support iteration with is_deleted virtual column .. Patch Set 2: Verified+1 RELEASE build hung in

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-11-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11827 ) Change subject: [compaction] Cleanup of compaction policy code .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] [test] optional table creation in TabletServerIntegrationTestBase

2018-11-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11861 ) Change subject: [test] optional table creation in TabletServerIntegrationTestBase .. Patch Set 1: (1 comment)

[kudu-CR] python: make test scantoken more robust to exceptions

2018-11-02 Thread Adar Dembo (Code Review)
Hello Jordan Birdsell, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11863 to review the following change. Change subject: python: make test_scantoken more robust to exceptions

[kudu-CR] (04/05) delta store: support iteration with is deleted virtual column

2018-11-02 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11859 ) Change subject: (04/05) delta_store: support iteration with is_deleted virtual column .. Removed reviewer Kudu Jenkins with the

[kudu-CR] [sentry] add AuthzProvider

2018-11-02 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11659 to look at the new patch set (#12). Change subject: [sentry] add AuthzProvider

[kudu-CR] [sentry] add AuthzProvider

2018-11-02 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 12: (3 comments)

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-11-02 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11827 to look at the new patch set (#6). Change subject: [compaction] Cleanup of compaction policy code

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11827 ) Change subject: [compaction] Cleanup of compaction policy code .. Patch Set 3: (1 comment)

[kudu-CR] move HashAlgorithm from common.proto to hash.proto

2018-11-02 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11865 ) Change subject: move HashAlgorithm from common.proto to hash.proto .. Patch Set 1: -Code-Review The release build failed with a related

[kudu-CR] move HashAlgorithm from common.proto to hash.proto

2018-11-02 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11865 ) Change subject: move HashAlgorithm from common.proto to hash.proto .. Patch Set 1: (1 comment)

[kudu-CR] move HashAlgorithm from common.proto to hash.proto

2018-11-02 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11865 ) Change subject: move HashAlgorithm from common.proto to hash.proto .. move HashAlgorithm from common.proto to hash.proto Commit

[kudu-CR] move HashAlgorithm from common.proto to hash.proto

2018-11-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11865 ) Change subject: move HashAlgorithm from common.proto to hash.proto .. Patch Set 2: Verified+1 Overriding Jenkins, dist-test failure

[kudu-CR] move HashAlgorithm from common.proto to hash.proto

2018-11-02 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: move HashAlgorithm from common.proto to hash.proto .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11865 To

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11869 Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs .. [compaction] KUDU-1400:

[kudu-CR] [test] optional table creation in TabletServerIntegrationTestBase

2018-11-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11861 ) Change subject: [test] optional table creation in TabletServerIntegrationTestBase .. [test] optional table creation in

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-02 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11869 to look at the new patch set (#2). Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11869 ) Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs .. Patch Set 3: (1 comment)

[kudu-CR] [compaction] KUDU-1400: Improve rowset compaction policy to consider merging small DRSs

2018-11-02 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11869 to look at the new patch set (#3). Change subject: [compaction] KUDU-1400: Improve rowset compaction policy to

[kudu-CR] [rebalancer] location-aware rebalancer (part 9/n)

2018-11-02 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11862 to look at the new patch set (#2). Change subject: [rebalancer] location-aware rebalancer (part 9/n)

[kudu-CR] move HashAlgorithm from common.proto to hash.proto

2018-11-02 Thread Adar Dembo (Code Review)
Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11865 to review the following change. Change subject: move HashAlgorithm from common.proto to hash.proto ..

[kudu-CR] move HashAlgorithm from common.proto to hash.proto

2018-11-02 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11865 ) Change subject: move HashAlgorithm from common.proto to hash.proto .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] move HashAlgorithm from common.proto to hash.proto

2018-11-02 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11865 ) Change subject: move HashAlgorithm from common.proto to hash.proto .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] [test] optional table creation in TabletServerIntegrationTestBase

2018-11-02 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11861 to look at the new patch set (#2). Change subject: [test] optional table creation in TabletServerIntegrationTestBase

[kudu-CR] [test] optional table creation in TabletServerIntegrationTestBase

2018-11-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11861 ) Change subject: [test] optional table creation in TabletServerIntegrationTestBase .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [rebalancer] location-aware rebalancer (part 9/n)

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11862 ) Change subject: [rebalancer] location-aware rebalancer (part 9/n) .. Patch Set 2: (6 comments)

[kudu-CR] [sentry] add AuthzProvider

2018-11-02 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 12: (1 comment)

[kudu-CR] [examples] Add basic Spark example (scala)

2018-11-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example (scala) .. Patch Set 11: (9 comments)