[kudu-CR] Disable rowset compaction in TestUndoDeltaBlockGc

2018-11-06 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11884 ) Change subject: Disable rowset compaction in TestUndoDeltaBlockGc .. Disable rowset compaction in TestUndoDeltaBlockGc In a

[kudu-CR] (01/05) delta store: avoid copying deleted row data in ApplyUpdates

2018-11-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11856 ) Change subject: (01/05) delta_store: avoid copying deleted row data in ApplyUpdates .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-1918 Prevent hijacking of scanner IDs

2018-11-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6348 ) Change subject: KUDU-1918 Prevent hijacking of scanner IDs .. Patch Set 8: (5 comments)

[kudu-CR] run-test: don't report leaks that don't fail test

2018-11-06 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11886 Change subject: run-test: don't report leaks that don't fail test .. run-test: don't report leaks that don't fail test The presence of

[kudu-CR] run-test: don't report leaks that don't fail test

2018-11-06 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11886 to look at the new patch set (#2). Change subject: run-test: don't report leaks that don't fail test

[kudu-CR] KUDU-1918 Prevent hijacking of scanner IDs

2018-11-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/6348 ) Change subject: KUDU-1918 Prevent hijacking of scanner IDs .. Patch Set 8: Code-Review+2 (2 comments)

[kudu-CR] KUDU-1918 Prevent hijacking of scanner IDs

2018-11-06 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#8) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/6348 ) Change subject: KUDU-1918 Prevent hijacking of scanner IDs .. KUDU-1918 Prevent hijacking

[kudu-CR] Limit number of rowsets in compaction selection to 32 in TSAN mode

2018-11-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11885 ) Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode .. Patch Set 2: > > Where did that 256KB figure

[kudu-CR] Add "network plane" as part of ConnectionId

2018-11-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11681 ) Change subject: Add "network_plane" as part of ConnectionId .. Patch Set 4: (8 comments) Could you also update this comment in

[kudu-CR] run-test: don't report leaks that don't fail test

2018-11-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11886 ) Change subject: run-test: don't report leaks that don't fail test .. Patch Set 2: (2 comments)

[kudu-CR] WIP [rebalancer] location-aware rebalancer (part 10/n)

2018-11-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11892 Change subject: WIP [rebalancer] location-aware rebalancer (part 10/n) .. WIP [rebalancer] location-aware rebalancer (part 10/n) Added

[kudu-CR] KUDU-2584: Prevent flaky off-by-one errors in backup tests

2018-11-06 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11815 ) Change subject: KUDU-2584: Prevent flaky off-by-one errors in backup tests .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2584: Prevent flaky off-by-one errors in backup tests

2018-11-06 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11815 ) Change subject: KUDU-2584: Prevent flaky off-by-one errors in backup tests .. KUDU-2584: Prevent flaky off-by-one errors in

[kudu-CR] docs: Use a non-SSH method of installing Gerrit commit hook

2018-11-06 Thread Mike Percy (Code Review)
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11896 Change subject: docs: Use a non-SSH method of installing Gerrit commit hook .. docs: Use a non-SSH method of installing Gerrit commit hook

[kudu-CR] Add "network plane" as part of ConnectionId

2018-11-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11681 ) Change subject: Add "network_plane" as part of ConnectionId .. Patch Set 4: (1 comment)

[kudu-CR] WIP [rebalancer] location-aware rebalancer (part 10/n)

2018-11-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11892 ) Change subject: WIP [rebalancer] location-aware rebalancer (part 10/n) .. Patch Set 1: (1 comment)

[kudu-CR] docs: Use a non-SSH method of installing Gerrit commit hook

2018-11-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11896 ) Change subject: docs: Use a non-SSH method of installing Gerrit commit hook .. Patch Set 1: (2 comments)

[kudu-CR] docs: Use a non-SSH method of installing Gerrit commit hook

2018-11-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11896 ) Change subject: docs: Use a non-SSH method of installing Gerrit commit hook .. Patch Set 1: (2 comments)

[kudu-CR] De-flake sentry client-test and sentry authz provider-test

2018-11-06 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: De-flake sentry_client-test and sentry_authz_provider-test .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11898 To

[kudu-CR] De-flake sentry client-test and sentry authz provider-test

2018-11-06 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11898 ) Change subject: De-flake sentry_client-test and sentry_authz_provider-test .. Patch Set 1: Verified+1 Unrelated flaky DefaultSourceTest.

[kudu-CR] docs: Use a non-SSH method of installing Gerrit commit hook

2018-11-06 Thread Mike Percy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11896 to look at the new patch set (#2). Change subject: docs: Use a non-SSH method of installing Gerrit commit hook

[kudu-CR] docs: Use a non-SSH method of installing Gerrit commit hook

2018-11-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11896 ) Change subject: docs: Use a non-SSH method of installing Gerrit commit hook .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] python: make test scantoken more robust to exceptions

2018-11-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11863 ) Change subject: python: make test_scantoken more robust to exceptions .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] De-flake sentry client-test and sentry authz provider-test

2018-11-06 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11898 Change subject: De-flake sentry_client-test and sentry_authz_provider-test .. De-flake sentry_client-test and sentry_authz_provider-test

[kudu-CR] [rebalancer] location-aware rebalancer (part 9/n)

2018-11-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11862 ) Change subject: [rebalancer] location-aware rebalancer (part 9/n) .. [rebalancer] location-aware rebalancer (part 9/n)

[kudu-CR] Limit number of rowsets in compaction selection to 32 in TSAN mode

2018-11-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11885 ) Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode .. Patch Set 2: > Where did that 256KB figure

[kudu-CR] Limit number of rowsets in compaction selection to 32 in TSAN mode

2018-11-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11885 ) Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2584: Prevent flaky off-by-one errors in backup tests

2018-11-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11815 ) Change subject: KUDU-2584: Prevent flaky off-by-one errors in backup tests .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] [tools] reference comparison mode for rebalancing algo tests

2018-11-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11870 ) Change subject: [tools] reference comparison mode for rebalancing algo tests .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [rebalancer] location-aware rebalancer (part 9/n)

2018-11-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11862 ) Change subject: [rebalancer] location-aware rebalancer (part 9/n) .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] run-test: don't report leaks that don't fail test

2018-11-06 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: run-test: don't report leaks that don't fail test .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11886 To

[kudu-CR] run-test: don't report leaks that don't fail test

2018-11-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11886 ) Change subject: run-test: don't report leaks that don't fail test .. Patch Set 2: Verified+1 The test failure seems unrelated:

[kudu-CR] KUDU-1918 Prevent hijacking of scanner IDs

2018-11-06 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/6348 ) Change subject: KUDU-1918 Prevent hijacking of scanner IDs .. KUDU-1918 Prevent hijacking of scanner IDs This makes the scanner

[kudu-CR] Limit number of rowsets in compaction selection to 32 in TSAN mode

2018-11-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11885 ) Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode .. Patch Set 2: Code-Review+2 > Patch Set 2: > I'm

[kudu-CR] [tools] reference comparison mode for rebalancing algo tests

2018-11-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11870 ) Change subject: [tools] reference comparison mode for rebalancing algo tests .. [tools] reference comparison mode for

[kudu-CR] KUDU-2584: Prevent flaky off-by-one errors in backup tests

2018-11-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11815 ) Change subject: KUDU-2584: Prevent flaky off-by-one errors in backup tests .. Patch Set 2: (5 comments)

[kudu-CR] KUDU-2584: Prevent flaky off-by-one errors in backup tests

2018-11-06 Thread Grant Henke (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11815 to look at the new patch set (#3). Change subject: KUDU-2584: Prevent flaky off-by-one errors in backup tests

[kudu-CR] KUDU-2584: Prevent flaky off-by-one errors in backup tests

2018-11-06 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11815 ) Change subject: KUDU-2584: Prevent flaky off-by-one errors in backup tests .. Patch Set 3: Verified+1 -- To view, visit

[kudu-CR] KUDU-2584: Prevent flaky off-by-one errors in backup tests

2018-11-06 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: KUDU-2584: Prevent flaky off-by-one errors in backup tests .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11815 To

[kudu-CR] Limit number of rowsets in compaction selection to 32 in TSAN mode

2018-11-06 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11885 to look at the new patch set (#2). Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode

[kudu-CR] Limit number of rowsets in compaction selection to 32 in TSAN mode

2018-11-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11885 ) Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode .. Patch Set 1: (1 comment)

[kudu-CR] Limit number of rowsets in compaction selection to 32 in TSAN mode

2018-11-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11885 ) Change subject: Limit number of rowsets in compaction selection to 32 in TSAN mode .. Patch Set 2: Todd mentioned offline that it