[kudu-CR] Predicate evaluation pushdown

2016-08-04 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3841 Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown This patch is a work in progress. The premise of this

[kudu-CR] Predicate evaluation pushdown

2016-08-16 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#2). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] [KUDU-1880] Prevent eager ignoring of NULLs

2017-02-15 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6029 Change subject: [KUDU-1880] Prevent eager ignoring of NULLs .. [KUDU-1880] Prevent eager ignoring of NULLs While scanning nullable

[kudu-CR] [KUDU-1880] Prevent eager ignoring of NULLs

2017-02-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [KUDU-1880] Prevent eager ignoring of NULLs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6029/1//COMMIT_MSG Commit Message: PS1, Line 7:

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-15 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#2). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent

[kudu-CR] KUDU-1493: Implement SchemaRelationProvider

2017-02-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1493: Implement SchemaRelationProvider .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6029/4/src/kudu/tablet/tablet-scan-correctness-test.cc

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#4). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/6029/3/src/kudu/tablet/tablet-scan-correctness-test.cc

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#3). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-02-23 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6129 Change subject: KUDU-1893 Ensure evaluation of added columns .. KUDU-1893 Ensure evaluation of added columns During a normal scan, a

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-02-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 1: Just want to point out that this potentially breaks the abstraction of only evaluate when

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-02-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 1: One alternative to this would be to have the DefaultColumnValueIterator switch decoder-level

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-02-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6129 to look at the new patch set (#2). Change subject: KUDU-1893 Ensure evaluation of added columns .. KUDU-1893

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6029/4/src/kudu/tablet/tablet-scan-correctness-test.cc

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-02-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c/6129/2/src/kudu/cfile/cfile_reader.cc File

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6029/4/src/kudu/tablet/tablet-scan-correctness-test.cc

[kudu-CR] Predicate evaluation pushdown

2016-08-15 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3990 Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown The premise of this patch is to avoid the excessive use of

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-27 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#5). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-27 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#6). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6184 Change subject: KUDU-1904 Don't seek on empty RLE blocks .. KUDU-1904 Don't seek on empty RLE blocks Seeking in RLE blocks enforces that

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-03-01 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6129 to look at the new patch set (#8). Change subject: KUDU-1893 Ensure evaluation of added columns .. KUDU-1893

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-03-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/6129/8//COMMIT_MSG Commit Message: PS8, Line 20:

[kudu-CR] KUDU-1893 Ensure evaluation of added columns

2017-03-01 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6129 to look at the new patch set (#7). Change subject: KUDU-1893 Ensure evaluation of added columns .. KUDU-1893

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#7). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#11). Change subject: KUDU-1880 Prevent eager ignoring of NULLs

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#10). Change subject: KUDU-1880 Prevent eager ignoring of NULLs

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#9). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. Patch Set 9: (9 comments)

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1904 Don't seek on empty RLE blocks .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6184/2/src/kudu/cfile/rle_block.h File

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6184 to look at the new patch set (#3). Change subject: KUDU-1904 Don't seek on empty RLE blocks .. KUDU-1904 Don't

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6184 to look at the new patch set (#4). Change subject: KUDU-1904 Don't seek on empty RLE blocks .. KUDU-1904 Don't

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

2017-02-28 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#2). Change subject: KUDU-1904 Don't seek on empty RLE blocks .. KUDU-1904 Don't seek on empty RLE blocks Seeking in RLE blocks enforces that the seek position is less than the number

[kudu-CR] KUDU-1880 Prevent eager ignoring of NULLs

2017-02-28 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6029 to look at the new patch set (#8). Change subject: KUDU-1880 Prevent eager ignoring of NULLs .. KUDU-1880 Prevent

[kudu-CR] KUDU-1834 Don't redact KuduRowResult::ToString()

2017-03-01 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6222 Change subject: KUDU-1834 Don't redact KuduRowResult::ToString() .. KUDU-1834 Don't redact KuduRowResult::ToString() A user on the client

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-02 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4164 to look at the new patch set (#3). Change subject: Inlined dispatch for predicate evaluation .. Inlined dispatch

[kudu-CR] Predicate evaluation pushdown

2016-09-02 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#8). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Predicate evaluation pushdown

2016-09-03 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#9). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-03 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4164 to look at the new patch set (#4). Change subject: Inlined dispatch for predicate evaluation .. Inlined dispatch

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 10: (8 comments) http://gerrit.cloudera.org:8080/#/c/3990/10/src/kudu/cfile/cfile-test-base.h File

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/4164/4/src/kudu/common/column_predicate.cc File

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-06 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4164 to look at the new patch set (#5). Change subject: Inlined dispatch for predicate evaluation .. Inlined dispatch

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-06 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4164 to look at the new patch set (#7). Change subject: Inlined dispatch for predicate evaluation .. Inlined dispatch

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#12). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-06 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4164 to look at the new patch set (#6). Change subject: Inlined dispatch for predicate evaluation .. Inlined dispatch

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#11). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Predicate evaluation pushdown

2016-09-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3990/3/src/kudu/cfile/binary_plain_block.h File

[kudu-CR] Predicate evaluation pushdown

2016-09-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 7: (11 comments) http://gerrit.cloudera.org:8080/#/c/3990/7/src/kudu/cfile/binary_prefix_block.h File

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4164/2//COMMIT_MSG Commit Message: > Does it make

[kudu-CR] Predicate evaluation pushdown

2016-09-08 Thread Andrew Wong (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#16). Change subject: Predicate evaluation pushdown .. Predicate

[kudu-CR] Inlined dispatch for predicate evaluation

2016-08-29 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4164 Change subject: Inlined dispatch for predicate evaluation .. Inlined dispatch for predicate evaluation In order to evaluate a predicate,

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/4164/7//COMMIT_MSG Commit Message: PS7, Line 25: 1M

[kudu-CR] Predicate evaluation pushdown

2016-09-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 12: (18 comments) http://gerrit.cloudera.org:8080/#/c/3990/12/src/kudu/cfile/binary_dict_block.cc File

[kudu-CR] Predicate evaluation pushdown

2016-09-07 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#13). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-07 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4164 to look at the new patch set (#8). Change subject: Inlined dispatch for predicate evaluation .. Inlined dispatch

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4164/8/src/kudu/common/column_predicate.cc File

[kudu-CR] Inlined dispatch for predicate evaluation

2016-08-29 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4164 to look at the new patch set (#2). Change subject: Inlined dispatch for predicate evaluation .. Inlined dispatch

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-08 Thread Andrew Wong (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4164 to look at the new patch set (#10). Change subject: Inlined dispatch for predicate evaluation ..

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Blogpost describing predicate evaluation pushdown .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4384/2/_posts/predicate-pushdown.md File

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#4). Change subject: Blogpost describing predicate evaluation pushdown .. Blogpost describing predicate evaluation pushdown Version with images can be found here:

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#3). Change subject: Blogpost describing predicate evaluation pushdown .. Blogpost describing predicate evaluation pushdown Version with images can be found here:

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Blogpost describing predicate evaluation pushdown .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4384/2/_posts/predicate-pushdown.md File

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Blogpost describing predicate evaluation pushdown .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4384/3/_posts/predicate-pushdown.md File

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4384 Change subject: Blogpost describing predicate evaluation pushdown .. Blogpost describing predicate evaluation pushdown Version with

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Blogpost describing predicate evaluation pushdown .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/4384/2/_posts/predicate-pushdown.md File

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Blogpost describing predicate evaluation pushdown .. Patch Set 4: (14 comments) http://gerrit.cloudera.org:8080/#/c/4384/3/_posts/predicate-pushdown.md File

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#7). Change subject: Blogpost describing predicate evaluation pushdown .. Blogpost describing predicate evaluation pushdown Version with images can be found here:

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Blogpost describing predicate evaluation pushdown .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4384/1/_posts/predicate-pushdown.md File

[kudu-CR] KUDU-1651: Check empty dict before decoder eval

2016-09-26 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4537 Change subject: KUDU-1651: Check empty dict before decoder eval .. KUDU-1651: Check empty dict before decoder eval A completely null

[kudu-CR] Predicate evaluation pushdown

2016-08-22 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#4). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Predicate evaluation pushdown

2016-08-22 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#3). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Predicate evaluation pushdown

2016-08-25 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#6). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6451 to look at the new patch set (#8). Change subject: [consensus] Add consensus op-level lag metrics .. [consensus]

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6451/8/src/kudu/consensus/consensus_queue.cc File

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/6451/7/src/kudu/consensus/consensus.proto File

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6451 to look at the new patch set (#9). Change subject: [consensus] Add consensus op-level lag metrics .. [consensus]

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6451 to look at the new patch set (#10). Change subject: [consensus] Add consensus op-level lag metrics .. [consensus]

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 10: (10 comments) http://gerrit.cloudera.org:8080/#/c/6451/10/src/kudu/consensus/consensus.proto File

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-24 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6451 to look at the new patch set (#11). Change subject: [consensus] Add consensus op-level lag metrics

[kudu-CR] Spark ITBLL

2017-03-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Spark ITBLL .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/6419/2/build-support/jenkins/build-and-test.sh File

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/6451/12/src/kudu/consensus/consensus_queue.cc

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-24 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6451 to look at the new patch set (#13). Change subject: [consensus] Add consensus op-level lag metrics

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-24 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6451 to look at the new patch set (#12). Change subject: [consensus] Add consensus op-level lag metrics

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-24 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/6451/11/src/kudu/consensus/consensus_queue.cc

[kudu-CR] WIP: KUDU-1506 Add consensus lag metrics

2017-03-22 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: WIP: KUDU-1506 Add consensus lag metrics .. Patch Set 6: > Is there any way we can get this metric to be time-based instead of > op-based? op-based has the

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 6: (3 comments) As you guys in the above comments, since this doesn't address time, I've changed the

[kudu-CR] [consensus] Add consensus op-level lag metrics

2017-03-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6451 to look at the new patch set (#7). Change subject: [consensus] Add consensus op-level lag metrics .. [consensus]

[kudu-CR] cfile-test: add a 100M-string file with low cardinality

2017-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: cfile-test: add a 100M-string file with low cardinality .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6432/1/src/kudu/cfile/cfile-test-base.h

[kudu-CR] compaction: fix rowblock size in compaction output

2017-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: compaction: fix rowblock size in compaction output .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6430 To unsubscribe, visit

[kudu-CR] cfile-test: add a 100M-string file with low cardinality

2017-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: cfile-test: add a 100M-string file with low cardinality .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6432/1/src/kudu/cfile/cfile-test-base.h

[kudu-CR] key encoder: avoid unordered map for looking up encoders

2017-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: key_encoder: avoid unordered_map for looking up encoders .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6431/2/src/kudu/common/key_encoder.cc

[kudu-CR] cfile writer: inline written size() method

2017-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: cfile_writer: inline written_size() method .. Patch Set 2: Curious whether or not you saw any improvement after making this change (even if not, the change makes

[kudu-CR] Optimize BinaryDictBlock to use dense hash map, smaller hot path

2017-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Optimize BinaryDictBlock to use dense_hash_map, smaller hot path .. Patch Set 2: (1 comment)

[kudu-CR] compaction-test: use default bloom sizing

2017-03-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: compaction-test: use default bloom sizing .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6429/2/src/kudu/tablet/compaction-test.cc File

[kudu-CR] KUDU-1506 Add consensus lag metrics

2017-03-21 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6451 to look at the new patch set (#3). Change subject: KUDU-1506 Add consensus lag metrics .. KUDU-1506 Add consensus

[kudu-CR] WIP: KUDU-1506 Add consensus lag metrics

2017-03-21 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6451 to look at the new patch set (#6). Change subject: WIP: KUDU-1506 Add consensus lag metrics .. WIP: KUDU-1506 Add

[kudu-CR] cfile writer: inline written size() method

2017-03-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: cfile_writer: inline written_size() method .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6434 To unsubscribe, visit

[kudu-CR] compaction: fix rowblock size in compaction output

2017-03-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: compaction: fix rowblock size in compaction output .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6430 To unsubscribe, visit

[kudu-CR] key encoder: avoid unordered map for looking up encoders

2017-03-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: key_encoder: avoid unordered_map for looking up encoders .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6431 To unsubscribe,

[kudu-CR] KUDU-1506 Add consensus lag metrics

2017-03-21 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6451 Change subject: KUDU-1506 Add consensus lag metrics .. KUDU-1506 Add consensus lag metrics It may be useful to see how far behind certain

  1   2   3   4   5   6   7   8   9   10   >