Mike Percy has submitted this change and it was merged.
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad support to Kudu
Breakpad creates minidumps upon crash, which are small files that
include
David Ribeiro Alves has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 37: Code-Review+2
haven't actually tested this last rev on mac, assuming there weren't any new
breakages
Adar Dembo has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 37: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5620
To unsubscribe, visit
Mike Percy has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 37:
I tested this latest rev on macOS El Capitan and Ubuntu xenial and both builds
pass.
--
To view, visit
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#37).
Change subject: Add Google Breakpad support to Kudu
..
Add Google
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#36).
Change subject: Add Google Breakpad support to Kudu
..
Add Google
Mike Percy has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 34:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5620/34/src/kudu/util/minidump.h
File
Adar Dembo has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 34:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5620/34/src/kudu/util/minidump.h
File
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#35).
Change subject: Add Google Breakpad support to Kudu
..
Add Google
Hello Mike Percy, Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#34).
Change subject: Add Google Breakpad support to Kudu
..
Adar Dembo has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 32: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5620
To unsubscribe, visit
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#32).
Change subject: Add Google Breakpad support to Kudu
..
Add Google
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#31).
Change subject: Add Google Breakpad support to Kudu
..
Add Google
Adar Dembo has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 30: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5620
To unsubscribe, visit
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#30).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Mike Percy has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 27:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5620/27/src/kudu/client/symbols.map
File
Mike Percy has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 28: Verified+1
Overriding Jenkins failure due to a flaky java test.
--
To view, visit
Adar Dembo has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 27:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5620/27/src/kudu/client/symbols.map
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#27).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#25).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Mike Percy has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 21:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5620/21/src/kudu/util/minidump-test.cc
File
Adar Dembo has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 24:
> I don't see any reason why the client would link these symbols.
Maybe it's because of the static variable
Adar Dembo has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 24: Code-Review+2
Looks good.
The test failure in client_symbol-test.sh is likely because we need to hide the
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#24).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#22).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Adar Dembo has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 21:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/5620/20/build-support/jenkins/build-and-test.sh
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#21).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#19).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#18).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#17).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#16).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#15).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#14).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#13).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#12).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#11).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#10).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Mike Percy has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#9).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Mike Percy has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 6:
(21 comments)
http://gerrit.cloudera.org:8080/#/c/5620/6//COMMIT_MSG
Commit Message:
PS6, Line 29: default
>
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#8).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#7).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Adar Dembo has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 6:
(22 comments)
> The right way to do it would probably be to have a signal-handling thread.
Another option is
Lars Volker has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#6).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Mike Percy has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc
File
Adar Dembo has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#5).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#4).
Change subject: Add Google Breakpad support to Kudu
..
Add Google
Mike Percy has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 3:
(46 comments)
http://gerrit.cloudera.org:8080/#/c/5620/3//COMMIT_MSG
Commit Message:
Line 7: Add Google
Dinesh Bhat has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc
File
Todd Lipcon has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc
File
Dinesh Bhat has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 3:
(4 comments)
I forgot to press send on this friday.
Thinking out loud, I am trying to see what's the real
Alexey Serbin has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 3:
(10 comments)
Does it work on OS X? Consider adding corresponding ifdefs at least at the
first pass to
Lars Volker has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 3:
(3 comments)
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5620
to look at the new patch set (#3).
Change subject: Add Google Breakpad support to Kudu
..
Add Google Breakpad
Mike Percy has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5620/1//COMMIT_MSG
Commit Message:
Line 28: because
Mike Percy has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5620/1//COMMIT_MSG
Commit Message:
Line 28: because
Todd Lipcon has posted comments on this change.
Change subject: Add Google Breakpad support to Kudu
..
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5620/1//COMMIT_MSG
Commit Message:
Line 28: because
Hello Dinesh Bhat, Lars Volker, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5620
to review the following change.
Change subject: Add Google Breakpad support to Kudu
..
Add
60 matches
Mail list logo
