[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5045 To unsubscribe,

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. KUDU-921. tablet copy: Make the StartTabletCopy() RPC async This patch changes tablet copy

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-07 Thread Mike Percy (Code Review)
Hello Dinesh Bhat, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5045 to look at the new patch set (#13). Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 12: (5 comments) http://gerrit.cloudera.org:8080/#/c/5045/12/src/kudu/integration-tests/ta

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 12: (5 comments) http://gerrit.cloudera.org:8080/#/c/5045/12/src/kudu/integration-tests/t

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 12: Verified+1 Apparently log-rolling-itest is flaky. -- To view, visit http://gerrit.clo

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/5045/6/src/kudu/tserver/ts_tablet_mana

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-06 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 6: (3 comments) LGTM, couple of nits. http://gerrit.cloudera.org:8080/#/c/5045/6/src/kud

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-06 Thread Mike Percy (Code Review)
Hello Dinesh Bhat, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5045 to look at the new patch set (#11). Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async ..

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-06 Thread Mike Percy (Code Review)
Hello Dinesh Bhat, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5045 to look at the new patch set (#10). Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async ..

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-05 Thread Mike Percy (Code Review)
Hello Dinesh Bhat, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5045 to look at the new patch set (#9). Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async ...

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-05 Thread Mike Percy (Code Review)
Hello Dinesh Bhat, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5045 to look at the new patch set (#8). Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async ...

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 7: > I don't have a strong opinion as long as: > 1) There's some way to wait for the table

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 7: > 1) There's some way to wait for the tablet copy to finish, at least > for tests, even

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 7: > > I'm going to take your advice and do this. I think it will also > > solve the test

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 7: Code-Review-1 I posted this for a test run / sanity check but I need to work on better

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Hello Dinesh Bhat, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5045 to look at the new patch set (#7). Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async ...

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/5045/6/src/kudu/integration-tests/tabl

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 6: > > On second look I see what you mean; the moment we invoke the > > callback, we respo

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 6: > On second look I see what you mean; the moment we invoke the > callback, we respond t

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 6: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/5045/6/src/kudu/integra

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 6: > > If I'm understanding this correctly, the semantics of the > > StartTabletCopy RPC r

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5045 to look at the new patch set (#6). Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/5045/2/src/kudu/tserver/ts_tablet_mana

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5045 to look at the new patch set (#5). Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 4: (4 comments) > If I'm understanding this correctly, the semantics of the > StartTabletC

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-11-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5045/4/src/kudu/tserver/ts_tablet_mana

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-11-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 4: Verified-1 i'm trying this out on a cluster that's experiencing the issue, and it crash

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-11-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 4: (3 comments) Just passing through and took an interest. If I'm understanding this corr

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-11-30 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5045 to look at the new patch set (#4). Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async