Re: Review Request 36295: Updated CHANGELOG for 0.23.0-rc2

2015-07-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36295/#review90874 --- Ship it! Ship It! - Timothy Chen On July 8, 2015, 7:27 a.m.,

Review Request 36299: Updated release guide with PyPi instructions; Reformatted, clarified.

2015-07-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36299/ --- Review request for mesos, Benjamin Hindman, Thomas Rampelberg, and Vinod Kone.

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

2015-07-08 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/#review90883 --- Ship it! Great, looks good to me now. How about other files like

Re: Review Request 36294: Updated configuration.md with new flags for 0.23.0.

2015-07-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36294/ --- (Updated July 8, 2015, 1:18 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36295: Updated CHANGELOG for 0.23.0-rc2

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36295/#review90876 --- Patch looks great! Reviews applied: [36295] All tests passed. -

Re: Review Request 36299: Updated release guide with PyPi instructions; Reformatted, clarified.

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36299/#review90878 --- Bad patch! Reviews applied: [36299] Failed command:

Review Request 36314: Added test for passing total slave's resources in ResourceUsage.

2015-07-08 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36314/ --- Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod

Re: Review Request 36294: Updated configuration.md with new flags for 0.23.0.

2015-07-08 Thread Adam B
On July 8, 2015, 10:24 a.m., Jie Yu wrote: docs/configuration.md, lines 1295-1301 https://reviews.apache.org/r/36294/diff/1/?file=1001995#file1001995line1295 This one is being deprecated. Maybe you want to call it out? Shouldn't we also call that out in the Flags help in

Re: Review Request 34140: AppC image store

2015-07-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/#review90954 --- src/slave/flags.cpp (line 74)

Re: Review Request 34139: AppC image discovery.

2015-07-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34139/#review90955 --- src/slave/flags.cpp (line 69)

Re: Review Request 36294: Updated configuration.md with new flags for 0.23.0.

2015-07-08 Thread Jie Yu
On July 8, 2015, 5:24 p.m., Jie Yu wrote: docs/configuration.md, lines 1295-1301 https://reviews.apache.org/r/36294/diff/1/?file=1001995#file1001995line1295 This one is being deprecated. Maybe you want to call it out? Adam B wrote: Shouldn't we also call that out in the

Re: Review Request 36294: Updated configuration.md with new flags for 0.23.0.

2015-07-08 Thread Adam B
On July 8, 2015, 9:35 a.m., Marco Massenzio wrote: Thanks for doing this! It seems to me that this is just a 'prettified' form of the `--help` output? perhaps we could automate its generation, removing the need of manually double-checking. Just a thought. +1000, created

Re: Review Request 36294: Updated configuration.md with new flags for 0.23.0.

2015-07-08 Thread Marco Massenzio
On July 8, 2015, 4:35 p.m., Marco Massenzio wrote: Thanks for doing this! It seems to me that this is just a 'prettified' form of the `--help` output? perhaps we could automate its generation, removing the need of manually double-checking. Just a thought. Adam B wrote:

Re: Review Request 23783: Missing Apache headers for libprocess

2015-07-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23783/ --- (Updated July 8, 2015, 6:47 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-07-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/ --- (Updated July 8, 2015, 5:04 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-08 Thread Paul Brett
On July 8, 2015, 3:18 a.m., Adam B wrote: docs/network-monitoring.md, line 17 https://reviews.apache.org/r/36281/diff/3/?file=1001910#file1001910line17 Mesos will automatically check for those kernel functionalities and will abort if they are not supported Is this still

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-08 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/ --- (Updated July 8, 2015, 5:23 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 36299: Updated release guide with PyPi instructions; Reformatted, clarified.

2015-07-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36299/#review90922 --- Ship it! docs/release-guide.md (line 69)

Re: Review Request 36314: Added test for passing total slave's resources in ResourceUsage.

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36314/#review90923 --- Patch looks great! Reviews applied: [36204, 36314] All tests

Re: Review Request 36294: Updated configuration.md with new flags for 0.23.0.

2015-07-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36294/#review90927 --- Ship it! Thanks Adam! I agree with Marco that this probably should

Re: Review Request 36294: Updated configuration.md with new flags for 0.23.0.

2015-07-08 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36294/#review90913 --- Ship it! Thanks for doing this! It seems to me that this is just

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-07-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/ --- (Updated July 8, 2015, 5:04 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-07-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/ --- (Updated July 8, 2015, 5:04 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-07-08 Thread haosdent huang
On July 7, 2015, 12:05 a.m., Timothy Chen wrote: Thanks for adding the hook! There is one more code path that a docker container can be launched, which is in launchExecutorProcess. Can you add the hook call in that path as well? Hi, @tnachen I update the patch. Could you review again,

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-07-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/ --- (Updated July 8, 2015, 5:06 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/#review90934 --- Patch looks great! Reviews applied: [36185] All tests passed. -

Re: Review Request 35947: Added a new API call 'updateAvailable' to the allocator.

2015-07-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35947/#review90930 --- A high-level concern I would like to share with you guys, though it

Re: Review Request 35947: Added a new API call 'updateAvailable' to the allocator.

2015-07-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35947/#review90936 --- include/mesos/master/allocator.hpp (lines 133 - 135)

Re: Review Request 36294: Updated configuration.md with new flags for 0.23.0.

2015-07-08 Thread Adam B
On July 8, 2015, 9:35 a.m., Marco Massenzio wrote: docs/configuration.md, line 1031 https://reviews.apache.org/r/36294/diff/1/?file=1001995#file1001995line1031 it would be awesome if we could have an exhaustive list of allowed time units: eg, is msecs or usecs allowed? what about

Re: Review Request 35947: Added a new API call 'updateAvailable' to the allocator.

2015-07-08 Thread Alexander Rukletsov
On July 8, 2015, 5:37 p.m., Alexander Rukletsov wrote: A high-level concern I would like to share with you guys, though it isn't directly related to this particular patch. I have a feeling that we don't really care about keeping the Allocator interface neat, brief, and concise, but

Review Request 36328: Change Request accepts to acceptsEncoding

2015-07-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36328/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and

Re: Review Request 23784: Missing Apache headers for stout

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23784/#review90985 --- Bad patch! Reviews applied: [23784] Failed command:

Re: Review Request 36326: containerizer: added cgroups based statistics.

2015-07-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 8, 2015, 8:39 p.m.) Review request for mesos and Timothy Chen.

Review Request 36326: containerizer: added cgroups based statistics.

2015-07-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

2015-07-08 Thread Marco Massenzio
On July 7, 2015, 9:32 p.m., Marco Massenzio wrote: support/post-reviews.py, line 173 https://reviews.apache.org/r/35777/diff/2/?file=1001308#file1001308line173 note that here you will be printing the whole commit message, which in this case is not appropriate. I

Re: Review Request 36326: containerizer: added cgroups based statistics.

2015-07-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 8, 2015, 9:40 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 23749: Missing Apache headers for mesos

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23749/#review91001 --- Patch looks great! Reviews applied: [23749] All tests passed. -

Re: Review Request 34136: Add ContainerImage protobuf.

2015-07-08 Thread Vinod Kone
On June 26, 2015, 9:57 p.m., Jiang Yan Xu wrote: include/mesos/mesos.proto, lines 1212-1214 https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1212 Is it the intention that Image type is **defined** outside MesosInfo because DockerInfo can later reference it?

Re: Review Request 34136: Add ContainerImage protobuf.

2015-07-08 Thread Timothy Chen
On June 25, 2015, 10:32 p.m., Paul Brett wrote: include/mesos/mesos.proto, line 1221 https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1221 Mesos info is optional, but if present can optionally contain an image? So what does a mesos present with a MesosInfo

Re: Review Request 35961: Include protobuf classes in generated Javadoc.

2015-07-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35961/#review90969 --- Any plan to get this onto the website? - Ben Mahler On June 29,

Re: Review Request 35961: Include protobuf classes in generated Javadoc.

2015-07-08 Thread Adam B
On July 8, 2015, 12:38 p.m., Ben Mahler wrote: Any plan to get this onto the website? Unfortunately, our website build/deploy Rakefile doesn't use the standard maven way to generate javadoc, and just runs the javadoc command manually. See https://issues.apache.org/jira/browse/MESOS-2959

Re: Review Request 23784: Missing Apache headers for stout

2015-07-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23784/ --- (Updated July 8, 2015, 8:51 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 35947: Added a new API call 'updateAvailable' to the allocator.

2015-07-08 Thread Jie Yu
On July 8, 2015, 5:59 p.m., Alexander Rukletsov wrote: include/mesos/master/allocator.hpp, lines 133-135 https://reviews.apache.org/r/35947/diff/1/?file=993649#file993649line133 And we introduce a libprocess dependency into `Allocator` interface. I think it's a prominent step,

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

2015-07-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 8, 2015, 8:23 p.m.) Review request for mesos and Benjamin

Re: Review Request 36326: containerizer: added cgroups based statistics.

2015-07-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 8, 2015, 9:02 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

2015-07-08 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35777/ --- (Updated July 8, 2015, 9:18 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/#review90983 --- Bad patch! Reviews applied: [23784] Failed command:

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

2015-07-08 Thread Michael Park
On July 7, 2015, 9:32 p.m., Marco Massenzio wrote: support/post-reviews.py, line 173 https://reviews.apache.org/r/35777/diff/2/?file=1001308#file1001308line173 note that here you will be printing the whole commit message, which in this case is not appropriate. I

Re: Review Request 36326: containerizer: added cgroups based statistics.

2015-07-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91005 --- src/slave/containerizer/docker.hpp (line 230)

Re: Review Request 34136: Add ContainerImage protobuf.

2015-07-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/#review91002 --- Ship it! LGTM. include/mesos/mesos.proto (line 1220)

Re: Review Request 34136: Add ContainerImage protobuf.

2015-07-08 Thread Vinod Kone
On June 25, 2015, 10:32 p.m., Paul Brett wrote: include/mesos/mesos.proto, line 1221 https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1221 Mesos info is optional, but if present can optionally contain an image? So what does a mesos present with a MesosInfo

Review Request 36294: Updated configuration.md with new flags for 0.23.0.

2015-07-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36294/ --- Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Joris Van

Review Request 36295: Updated CHANGELOG for 0.23.0-rc2

2015-07-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36295/ --- Review request for mesos, Joris Van Remoortere, Marco Massenzio, and Timothy

Re: Review Request 23783: Missing Apache headers for libprocess

2015-07-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23783/ --- (Updated July 8, 2015, 7:47 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36326: containerizer: added cgroups based statistics.

2015-07-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/ --- (Updated July 8, 2015, 8:53 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36336: Expose major, minor and patch components from stout Version

2015-07-08 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36336/#review91047 --- 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp (line

Re: Review Request 36336: Expose major, minor and patch components from stout Version

2015-07-08 Thread Paul Brett
On July 8, 2015, 11:44 p.m., Vinod Kone wrote: Are you sure we cannot use major, minor and patch? How come we havent encountered an issue so far? They are private member variables with no accessors. Previously, we just used the comparison operations built into the Version class but

Re: Review Request 36337: Adding a missing newline to Framework Development Guide.

2015-07-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36337/#review91029 --- Ship it! Ship It! - Timothy Chen On July 8, 2015, 10:54 p.m.,

Re: Review Request 23784: Missing Apache headers for stout

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23784/#review91036 --- Patch looks great! Reviews applied: [23784] All tests passed. -

Re: Review Request 35777: Made post-reviews.py handle bad (or not) ReviewBoard URLs.

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35777/#review91048 --- Patch looks great! Reviews applied: [35777] All tests passed. -

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-07-08 Thread haosdent huang
On July 8, 2015, 9:07 p.m., Timothy Chen wrote: src/tests/docker_containerizer_tests.cpp, line 3011 https://reviews.apache.org/r/36185/diff/3/?file=1002346#file1002346line3011 nit: I think we should name this to reflect the test like org_apache_mesos_TestSlavePreLaunchDockerHook

Re: Review Request 36326: containerizer: added cgroups based statistics.

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36326/#review91051 --- Patch looks great! Reviews applied: [36106, 36326] All tests

Re: Review Request 36336: Expose major, minor and patch components from stout Version

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36336/#review91058 --- Patch looks great! Reviews applied: [36336] All tests passed. -

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

2015-07-08 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36024/ --- (Updated July 8, 2015, 9:48 p.m.) Review request for mesos and Joris Van

Review Request 36336: Expose major, minor and patch components from stout Version

2015-07-08 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36336/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu,

Review Request 36337: Adding a missing newline to Framework Development Guide.

2015-07-08 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36337/ --- Review request for mesos, Adam B and Benjamin Hindman. Repository: mesos

Re: Review Request 23783: Missing Apache headers for libprocess

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23783/#review91013 --- Patch looks great! Reviews applied: [23783] All tests passed. -

Re: Review Request 34137: Add support for container image provisioners.

2015-07-08 Thread Vinod Kone
On June 29, 2015, 7:41 p.m., Jiang Yan Xu wrote: src/slave/containerizer/provisioner.cpp, lines 46-47 https://reviews.apache.org/r/34137/diff/2/?file=989758#file989758line46 Seems like this belongs to a later patch. AppcProvisioner is not introduced yet. +1 - Vinod

Re: Review Request 36328: Change Request accepts to acceptsEncoding

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36328/#review91026 --- Patch looks great! Reviews applied: [36328] All tests passed. -

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/#review91022 --- Patch looks great! Reviews applied: [36226] All tests passed. -

Re: Review Request 36218: Doxygen styleguide revisions based on conversation from https://reviews.apache.org/r/36193/.

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36218/#review91033 --- Patch looks great! Reviews applied: [36218] All tests passed. -

Re: Review Request 36336: Expose major, minor and patch components from stout Version

2015-07-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36336/#review91023 --- Are you sure we cannot use major, minor and patch? How come we

Re: Review Request 36218: Doxygen styleguide revisions based on conversation from https://reviews.apache.org/r/36193/.

2015-07-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36218/ --- (Updated July 8, 2015, 1:45 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-07-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/#review90992 --- src/tests/docker_containerizer_tests.cpp (line 3011)

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

2015-07-08 Thread Artem Harutyunyan
On July 8, 2015, 7:54 p.m., Joris Van Remoortere wrote: src/tests/fetcher_tests.cpp, line 281 https://reviews.apache.org/r/36024/diff/4/?file=1000470#file1000470line281 I think you mean `const vectorstring testEndpoints` ? Indeed! - Artem

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

2015-07-08 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36024/ --- (Updated July 8, 2015, 10:44 p.m.) Review request for Joris Van Remoortere.

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

2015-07-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 8, 2015, 6:50 p.m.) Review request for mesos and Benjamin

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

2015-07-08 Thread Isabel Jimenez
On July 8, 2015, 12:13 p.m., Till Toenshoff wrote: Great, looks good to me now. How about other files like e.g. 3rdparty/libprocess/configure.ac? Just added to review 23783, thanks! - Isabel --- This is an automatically generated

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

2015-07-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 8, 2015, 6:51 p.m.) Review request for mesos and Benjamin

Re: Review Request 23783: Missing Apache headers for libprocess

2015-07-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23783/ --- (Updated July 8, 2015, 6:51 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 23784: Missing Apache headers for stout

2015-07-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23784/ --- (Updated July 8, 2015, 6:55 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

2015-07-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 8, 2015, 6:56 p.m.) Review request for mesos and Benjamin

Re: Review Request 23749: Missing Apache headers for mesos

2015-07-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23749/ --- (Updated July 8, 2015, 6:57 p.m.) Review request for mesos and Benjamin

Re: Review Request 23749: Missing Apache headers for mesos

2015-07-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23749/#review90964 --- Bad patch! Reviews applied: [23784] Failed command:

Re: Review Request 23749: Missing Apache headers for mesos

2015-07-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23749/ --- (Updated July 8, 2015, 7:17 p.m.) Review request for mesos and Benjamin