Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-01 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Sept. 1, 2015, 10:42 a.m.) Review request for mesos, Benjamin

Review Request 38011: Maintenance Primitives: Use the parse<RepeatedPtrField> helper instead of a plural MachineID protobuf.

2015-09-01 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38011/ --- Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Artem

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

2015-09-01 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/#review97320 --- Some notes before you rebase. src/linux/perf.cpp (line 490)

Re: Review Request 37958: Add an option to only perform batch allocations.

2015-09-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37958/#review97309 --- Patch looks great! Reviews applied: [37958] All tests passed. -

Re: Review Request 37958: Add an option to only perform batch allocations.

2015-09-01 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37958/#review97311 --- Ship it! Just some minor updates and we can get this committed.

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

2015-09-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/ --- (Updated Sept. 1, 2015, 7:49 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review97317 --- Patch looks great! Reviews applied: [37585] All tests passed. -

Re: Review Request 37462: Add support for version detection and parsing.

2015-09-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/ --- (Updated Sept. 1, 2015, 7:47 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38011: Maintenance Primitives: Use the parse<RepeatedPtrField> helper instead of a plural MachineID protobuf.

2015-09-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38011/#review97328 --- Patch looks great! Reviews applied: [37826, 37827, 37830, 38011]

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-01 Thread Guangya Liu
> On 八月 20, 2015, 7:39 p.m., Marco Massenzio wrote: > > include/mesos/scheduler/scheduler.proto, lines 314-315 > > > > > > This comments does not read well: what is the timeout? also, it would > > be good to have a

Re: Review Request 37958: Add an option to only perform batch allocations.

2015-09-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37958/#review97370 --- Ship it! Ship It! - Guangya Liu On 九月 1, 2015, 11:10 p.m.,

Re: Review Request 37913: Improve allocator filtering by keeping per-slave filter sets.

2015-09-01 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37913/#review97346 --- Ship it! Looks great, thanks! I'll will get this commmitted for

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-01 Thread Guangya Liu
> On 八月 20, 2015, 7:39 p.m., Marco Massenzio wrote: > > include/mesos/scheduler/scheduler.proto, lines 314-315 > > > > > > This comments does not read well: what is the timeout? also, it would > > be good to have a

Re: Review Request 37958: Add an option to only perform batch allocations.

2015-09-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37958/#review97375 --- Patch looks great! Reviews applied: [37958] All tests passed. -

Re: Review Request 37024: Exposes mesos version information in components.

2015-09-01 Thread Ben Mahler
> On Aug. 31, 2015, 10:47 p.m., Ben Mahler wrote: > > Couple of comments: > > > > Let's not call the actor VersionInfo, since that sounds like a protobuf > > message. How about 'VersionProcess' and we avoid the wrapper type entirely > > since Version is taken in stout? > > > > Also, can we

Re: Review Request 37958: Add an option to only perform batch allocations.

2015-09-01 Thread James Peach
> On Sept. 1, 2015, 6 p.m., Ben Mahler wrote: > > include/mesos/master/allocator.hpp, lines 43-56 > > > > > > How about a 'struct' with no default constructor? Putting in these > > default values is a bit odd, since

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/ --- (Updated Sept. 1, 2015, 10:05 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38023: Rename for agent in user doc

2015-09-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38023/#review97356 --- Ship it! Ship It! - Vinod Kone On Sept. 1, 2015, 10:40 p.m.,

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-09-01 Thread Jojy Varghese
> On Sept. 1, 2015, 9:13 p.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioners/docker/token_manager.cpp, line 61 > > > > > > Its effectively the same. const reference as method argument is just a > >

Re: Review Request 37958: Add an option to only perform batch allocations.

2015-09-01 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37958/ --- (Updated Sept. 1, 2015, 11:10 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37958: Add an option to only perform batch allocations.

2015-09-01 Thread James Peach
> On Sept. 1, 2015, 6 p.m., Ben Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 284 > > > > > > Can you move this back up to below 'initialized' for now? Fixed. > On Sept. 1, 2015, 6 p.m., Ben

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-01 Thread Marco Massenzio
> On Aug. 20, 2015, 7:39 p.m., Marco Massenzio wrote: > > include/mesos/scheduler/scheduler.proto, lines 314-315 > > > > > > This comments does not read well: what is the timeout? also, it would > > be good to have

Re: Review Request 37462: Add support for version detection and parsing.

2015-09-01 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/#review97360 --- Looks good! Should be shippable after another round.

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-01 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review97366 --- Thanks for testing this! src/tests/containerizer/perf_tests.cpp

Re: Review Request 37921: Add Copy backend for provisioners.

2015-09-01 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37921/#review97376 --- src/slave/containerizer/provisioners/backends/copy.cpp (lines 105

Re: Review Request 37773: Docker: Adding registry client.

2015-09-01 Thread Jojy Varghese
> On Sept. 1, 2015, 9:35 p.m., Timothy Chen wrote: > > src/tests/provisioners/docker_provisioner_tests.cpp, line 232 > > > > > > Why is this needed? So that we cleanup temporaries created in the SSLTest setup. -

Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-09-01 Thread Guangya Liu
> On 九月 1, 2015, 4:56 p.m., Alexander Rukletsov wrote: > > include/mesos/master/allocator.hpp, line 90 > > > > > > I think "register" is misleading. Allocator is notified that a new > > framework joins the cluster

Re: Review Request 37989: Replace hard-coded reap interval with a constant

2015-09-01 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37989/#review97372 --- Hey Guangya, the point of MESOS-1935 was to use these constant

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-01 Thread Marco Massenzio
> On Aug. 20, 2015, 7:39 p.m., Marco Massenzio wrote: > > include/mesos/scheduler/scheduler.proto, lines 314-315 > > > > > > This comments does not read well: what is the timeout? also, it would > > be good to have

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-09-01 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review97336 --- src/slave/containerizer/provisioners/docker/token_manager.cpp

Re: Review Request 37773: Docker: Adding registry client.

2015-09-01 Thread Jojy Varghese
> On Sept. 1, 2015, 9:35 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 186 > > > > > > What's the benefits for this inline lambda vs just putting this code in >

Re: Review Request 37908: Silence oversubscription logging

2015-09-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37908/#review97351 --- Ship it! Ship It! - Vinod Kone On Aug. 31, 2015, 6:28 p.m.,

Re: Review Request 37462: Add support for version detection and parsing.

2015-09-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/ --- (Updated Sept. 1, 2015, 8:45 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-09-01 Thread Anand Mazumdar
> On Sept. 1, 2015, 9:13 p.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioners/docker/token_manager.cpp, line 61 > > > > > > Its effectively the same. const reference as method argument is just a > >

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review97348 --- Bad patch! Reviews applied: [37416, 37442] Failed command:

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

2015-09-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/ --- (Updated Sept. 1, 2015, 8:42 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37773: Docker: Adding registry client.

2015-09-01 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review97347 --- src/slave/containerizer/provisioners/docker/registry_client.cpp

Re: Review Request 37785: Fix Flaky SlaveTest.HTTPSchedulerSlaveRestart test

2015-09-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37785/#review97353 --- Ship it! Ship It! - Vinod Kone On Aug. 26, 2015, 3:07 a.m.,

Review Request 38023: Rename for agent in user doc

2015-09-01 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38023/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 38023: Rename for agent in user doc

2015-09-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38023/#review97358 --- Ship it! Ship It! - Guangya Liu On 九月 1, 2015, 10:40 p.m.,

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

2015-09-01 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/#review97359 --- Ship it! Will get this committed shortly. src/linux/perf.cpp

Re: Review Request 37853: Overlay filesystem provisioning backend

2015-09-01 Thread Mei Wan
> On Aug. 27, 2015, 10:42 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/backends/overlay.cpp, lines 101-103 > > > > > > Hum, I'd like to understand why overlay backend cannot support 1 layer. > > Any

Re: Review Request 37197: Docker image store.

2015-09-01 Thread Lily Chen
> On Aug. 31, 2015, 8:09 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker/store.cpp, line 131 > > > > > > For local store I don't think this comment is valid. > > Should just comment

Re: Review Request 37773: Docker: Adding registry client.

2015-09-01 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review97331 --- src/slave/containerizer/provisioners/docker/registry_client.hpp

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

2015-09-01 Thread Paul Brett
> On Sept. 1, 2015, 7:09 p.m., Ben Mahler wrote: > > src/linux/perf.cpp, line 490 > > > > > > Why not make this an Option and when it's this > > the value is None? Possible values are uint64_t, double, "" and "".

Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-09-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review97394 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 37921: Add Copy backend for provisioners.

2015-09-01 Thread Timothy Chen
> On Sept. 2, 2015, 3:07 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/provisioners/backends/copy.cpp, lines 108-116 > > > > > > Wow, I guess I hadn't realized what you meant by "making sure the > >

Review Request 38040: Refactor docker provisioner store to act as read-through cache.

2015-09-01 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38040/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Repository: mesos

Re: Review Request 37024: Exposes mesos version information in components.

2015-09-01 Thread haosdent huang
> On Aug. 31, 2015, 10:47 p.m., Ben Mahler wrote: > > Couple of comments: > > > > Let's not call the actor VersionInfo, since that sounds like a protobuf > > message. How about 'VersionProcess' and we avoid the wrapper type entirely > > since Version is taken in stout? > > > > Also, can we

Re: Review Request 37773: Docker: Adding registry client.

2015-09-01 Thread Jojy Varghese
> On Sept. 1, 2015, 9:35 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 410 > > > > > > I think ideally we can introduce something in libprocess so we can > >

Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-09-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review97297 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 37958: Add an option to only perform batch allocations.

2015-09-01 Thread James Peach
> On Sept. 1, 2015, 12:18 a.m., Qian Zhang wrote: > > include/mesos/master/allocator.hpp, line 48 > > > > > > I think we do not want "{}" in the newline. Fixed. > On Sept. 1, 2015, 12:18 a.m., Qian Zhang wrote: >

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

2015-09-01 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37826/#review97302 --- Ship it!

Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-09-01 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review97294 --- include/mesos/master/allocator.hpp (lines 62 - 64)

Re: Review Request 36620: Added Non-Freezeer Task Killer.

2015-09-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review97288 --- Patch looks great! Reviews applied: [36612, 36620] All tests

Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-09-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 九月 1, 2015, 2:59 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

2015-09-01 Thread haosdent huang
> On Aug. 27, 2015, 2:22 a.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h, line 38 > > > > > > Need adjust order here? > > Alexander Rukletsov wrote: > Not sure I

Re: Review Request 38003: MESOS-3351

2015-09-01 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/ --- (Updated Sept. 1, 2015, 2:44 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37830: Added a test for converting JSON arrays to Resources.

2015-09-01 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37830/ --- (Updated Sept. 1, 2015, 2:27 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

2015-09-01 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37826/ --- (Updated Sept. 1, 2015, 2:20 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

2015-09-01 Thread Alexander Rukletsov
> On Aug. 27, 2015, 5:51 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp, lines 179-181 > > > > > > From the method name, I think it's not completely obvious what the type > >

Re: Review Request 38003: MESOS-3351

2015-09-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38003/#review97281 --- Patch looks great! Reviews applied: [38003] All tests passed. -

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

2015-09-01 Thread Alexander Rukletsov
> On Aug. 31, 2015, 6:20 p.m., Michael Park wrote: > > What do you think of the following API? > > > > ``` > > JSON::Value value = ...; > > auto message = protobuf::parse(value); // message has type Try. > > auto repeated = > > protobuf::parse(value); //

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

2015-09-01 Thread Alexander Rukletsov
> On Aug. 27, 2015, 2:22 a.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h, line 38 > > > > > > Need adjust order here? > > Alexander Rukletsov wrote: > Not sure I

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

2015-09-01 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37827/ --- (Updated Sept. 1, 2015, 2:25 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 37958: Add an option to only perform batch allocations.

2015-09-01 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37958/#review97290 --- Ship it! LGTM. I would love us to avoid creating a master flag for

Re: Review Request 37830: Added a test for converting JSON arrays to Resources.

2015-09-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37830/#review97292 --- Patch looks great! Reviews applied: [37826, 37827, 37830] All