Review Request 41078: Fixed tests to call socket accept before sending response.

2015-12-07 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41078/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

2015-12-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40998/#review109284 --- Patch looks great! Reviews applied: [40998] Passed command:

Review Request 41077: Fixed the license header in src/linux/ns.hpp.

2015-12-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41077/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 41078: Fixed tests to call socket accept before sending response.

2015-12-07 Thread Jojy Varghese
> On Dec. 8, 2015, 7:08 a.m., Timothy Chen wrote: > > Can you elaborate more without this fix what happened and why? This fix moves "Accept" call before sending a response back to the client so that when the client sends the next request, the server is ready to accept it. Before this fix,

Re: Review Request 41075: Added support for implicit roles.

2015-12-07 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review109287 --- include/mesos/master/allocator.hpp (line 99)

Re: Review Request 41078: Fixed tests to call socket accept before sending response.

2015-12-07 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41078/#review109288 --- Can you elaborate more without this fix what happened and why? -

Re: Review Request 41075: Added support for implicit roles.

2015-12-07 Thread Neil Conway
> On Dec. 8, 2015, 7:02 a.m., Yong Qiao Wang wrote: > > include/mesos/master/allocator.hpp, line 101 > > > > > > When allocator initialize, their should be no active frameworks in > > mesos, can we consider to

Re: Review Request 41026: libevent ssl: Added check for buffer length before swapping request.

2015-12-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41026/#review109294 --- Patch looks great! Reviews applied: [41026] Passed command:

Re: Review Request 41078: Fixed tests to call socket accept before sending response.

2015-12-07 Thread Timothy Chen
> On Dec. 8, 2015, 7:08 a.m., Timothy Chen wrote: > > Can you elaborate more without this fix what happened and why? > > Jojy Varghese wrote: > This fix moves "Accept" call before sending a response back to the client > so that when the client sends the next request, the server is ready to

Re: Review Request 41075: Added support for implicit roles.

2015-12-07 Thread Yong Qiao Wang
> On Dec. 8, 2015, 7:02 a.m., Yong Qiao Wang wrote: > > I have talked with our shepherd Adam B yesterday, and we all agree to improve /roles endpoint to update/remove/list active roles, and Implicit Roles will focus on removing the static role list(specified by --roles flag) and let

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-12-07 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Dec. 7, 2015, 3:18 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-12-07 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Dec. 7, 2015, 3:22 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review104381 --- 3rdparty/libprocess/include/process/authenticator.hpp (line 20)

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

2015-12-07 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/ --- (Updated Dec. 7, 2015, 3:14 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-12-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review109145 --- 3rdparty/libprocess/include/process/authenticator.hpp (line 26)

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

2015-12-07 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Dec. 7, 2015, 3:21 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-07 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Dec. 7, 2015, 3:05 p.m.) Review request for mesos and Niklas Nielsen.

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

2015-12-07 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Dec. 7, 2015, 2:33 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-12-07 Thread Jan Schlicht
> On Dec. 2, 2015, 4:47 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, lines 236-240 > > > > > > Can we re-write it using a lambda? This way you do not need to inject > > `authorized` into the

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-07 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Dec. 7, 2015, 3:02 p.m.) Review request for mesos and Niklas Nielsen.

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-12-07 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Dec. 7, 2015, 4:02 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-12-07 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Dec. 7, 2015, 4:11 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review109154 --- Ship it! Ship It! - Till Toenshoff On Dec. 7, 2015, 3:11 p.m.,

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-12-07 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/ --- (Updated Dec. 7, 2015, 3:34 p.m.) Review request for mesos, Alexander

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-12-07 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Dec. 7, 2015, 2:33 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-12-07 Thread Alexander Rojas
> On Dec. 7, 2015, 3:22 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/authenticator.cpp, lines 25-26 > > > > > > I think `std::*`s go first. Not according to all the examples I checked, see

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-07 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Dec. 7, 2015, 3:27 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-12-07 Thread Alexander Rojas
> On Dec. 7, 2015, 3:22 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/authenticator.cpp, lines 25-26 > > > > > > I think `std::*`s go first. > > Alexander Rojas wrote: > Not according to all the

Re: Review Request 41042: Added description of the LoadQoSController in the oversubscription.md

2015-12-07 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41042/#review109167 --- Ship it! docs/oversubscription.md (line 201)

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-12-07 Thread Alexander Rukletsov
> On Dec. 7, 2015, 2:22 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/authenticator.cpp, lines 25-26 > > > > > > I think `std::*`s go first. > > Alexander Rojas wrote: > Not according to all the

Re: Review Request 40056: Make hook execution order deterministic.

2015-12-07 Thread Niklas Nielsen
> On Dec. 4, 2015, 1:15 p.m., Niklas Nielsen wrote: > > Hi Haosdent! > > > > I apologize the tardy reply. The patch looks good but needs rebasing. > > Also, have you thought of a way to test this? > > > > With a test (maybe by just ensuring the existing ordering of the test > > modules are

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

2015-12-07 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39781/ --- (Updated Dec. 7, 2015, 5:17 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 37540: Add perf event API

2015-12-07 Thread Niklas Nielsen
> On Dec. 2, 2015, 10:13 a.m., Niklas Nielsen wrote: > > Ping - Cong, is there anything you need to close the last issues? :) > > Cong Wang wrote: > I was blocked at the second to the last issue above and switched to > something else, now I can think more about it. Thanks! Sweet! Let us

Re: Review Request 41042: Added description of the LoadQoSController in the oversubscription.md

2015-12-07 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41042/ --- (Updated Dec. 7, 2015, 9:18 a.m.) Review request for mesos, Niklas Nielsen and

Review Request 41042: Added description of the LoadQoSController in the oversubscritpion.md

2015-12-07 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41042/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-4076

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-12-07 Thread Alexander Rukletsov
> On Dec. 7, 2015, 2:22 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/authenticator.cpp, lines 39-40 > > > > > > I see you use the same error message in case something is wrong. Is it > > done on

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

2015-12-07 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Dec. 7, 2015, 4:40 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

2015-12-07 Thread Niklas Nielsen
> On Nov. 30, 2015, 12:51 a.m., Benjamin Bannier wrote: > > James - are you blocked by anything? Can we help? It looks like we need one more review iteration. - Niklas --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-12-07 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Dec. 7, 2015, 8:41 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-12-07 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Dec. 7, 2015, 10:12 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-07 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/ --- (Updated Dec. 7, 2015, 10:12 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

2015-12-07 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/ --- (Updated Dec. 7, 2015, 11:32 a.m.) Review request for mesos, Alexander

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-12-07 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/ --- (Updated Dec. 7, 2015, 2:03 p.m.) Review request for mesos, Alexander

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-12-07 Thread Jan Schlicht
> On Dec. 2, 2015, 4:47 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, lines 236-240 > > > > > > Can we re-write it using a lambda? This way you do not need to inject > > `authorized` into the

Review Request 41070: Made v1 API in mesos.proto equivalent to non-v1.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41070/ --- Review request for mesos, Bernd Mathiske, Joris Van Remoortere, and Michael

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1 for 0.26.0.

2015-12-07 Thread Till Toenshoff
> On Dec. 8, 2015, 1 a.m., Michael Park wrote: > > include/mesos/v1/mesos.proto, lines 1507-1508 > > > > > > It looks like we're also missing this from `include/mesos/mesos.proto`? > > ``` > > 1510 //

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1 for 0.26.0.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41060/ --- (Updated Dec. 8, 2015, 2:23 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 41042: Added description of the LoadQoSController in the oversubscription.md

2015-12-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41042/#review109256 --- Bad patch! Reviews applied: [40617] Failed command:

Re: Review Request 36610: Add explicit syscall header file to linux fs

2015-12-07 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36610/#review109255 --- Ship it! Ship It! - Zhiwei Chen On July 20, 2015, 12:21 p.m.,

Re: Review Request 41026: libevent ssl: Added check for buffer length before swapping request.

2015-12-07 Thread Jojy Varghese
> On Dec. 8, 2015, 1:43 a.m., Joseph Wu wrote: > > Would it be plausible to write a repro/test (in the libprocess level) for > > this? > > > > Presumably, we should be able to write a process that does a "long running > > streaming download" (which causes the bug, according to your

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1 for 0.26.0.

2015-12-07 Thread Till Toenshoff
> On Dec. 8, 2015, 1 a.m., Michael Park wrote: > > include/mesos/v1/mesos.proto, lines 1507-1508 > > > > > > It looks like we're also missing this from `include/mesos/mesos.proto`? > > ``` > > 1510 //

Re: Review Request 40888: Add volume driver plugin to mesos v1 proto.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40888/#review109259 --- Ship it! Ship It! - Till Toenshoff On Dec. 2, 2015, 11:48

Re: Review Request 41066: Add containerId to ResourceUsage in v1 API

2015-12-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41066/#review109260 --- Just FYI, https://reviews.apache.org/r/41046/ is syncing up all V1

Re: Review Request 41066: Add containerId to ResourceUsage in v1 API

2015-12-07 Thread Till Toenshoff
> On Dec. 8, 2015, 3:03 a.m., Guangya Liu wrote: > > Just FYI, https://reviews.apache.org/r/41046/ is syncing up all V1 APIs In fact, that is done by https://reviews.apache.org/r/41060/ now, sorry for the confusion caused, had to update that RR but am not the original owner. - Till

Review Request 41050: Added a paragraph to the release guide that handles API updates.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41050/ --- Review request for mesos, Bernd Mathiske, Ben Mahler, and Joris Van Remoortere.

Re: Review Request 41050: Added a paragraph to the release guide that handles API updates.

2015-12-07 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41050/#review109188 --- Ship it! Ship It! - Bernd Mathiske On Dec. 7, 2015, 1:06 p.m.,

Re: Review Request 32505: Added SHUTDOWN scheduler call.

2015-12-07 Thread Vinod Kone
> On Nov. 20, 2015, 6:36 p.m., Zhitao Li wrote: > > src/master/master.cpp, line 3498 > > > > > > Hi [~vinodkone], can you please explain what it takes to "repliabily > > forward" this message? Do you mean we should

Re: Review Request 41046: Made v1 API in mesos.proto equivalent to non-v1.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41046/#review109190 --- include/mesos/v1/mesos.proto (line 1506)

Re: Review Request 39923: Cleaned up configuration.md.

2015-12-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39923/#review109192 --- What is the status of this patch -- can someone (Till) commit it?

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-12-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/#review109194 --- Ship it! Ship It! - Alexander Rukletsov On Dec. 7, 2015, 2:34

Re: Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38367/#review109199 --- include/mesos/mesos.proto (line 1466)

Re: Review Request 41046: Made v1 API in mesos.proto equivalent to non-v1.

2015-12-07 Thread Till Toenshoff
> On Dec. 7, 2015, 9:32 p.m., Till Toenshoff wrote: > > include/mesos/v1/mesos.proto, line 1506 > > > > > > I must be missing something, but where did index 6 go? Appears to be a bug in Mesos master, filed

Re: Review Request 35668: Report "unevictable" memory in container statistics.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35668/#review109204 --- include/mesos/mesos.proto (line 605)

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/#review109207 --- include/mesos/mesos.proto (line 821)

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

2015-12-07 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109206 --- Ship it! src/CMakeLists.txt (line 222)

Re: Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38367/#review109208 --- include/mesos/mesos.proto (line 1165)

Re: Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.

2015-12-07 Thread Till Toenshoff
> On Dec. 7, 2015, 10:07 p.m., Till Toenshoff wrote: > > include/mesos/mesos.proto, line 1466 > > > > > > Why are we missing index 6 here? Also missing in the V1 API. - Till

Re: Review Request 38000: Introduced support for user interaction with HTTP AuthenticationRouter.

2015-12-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38000/#review109203 --- 3rdparty/libprocess/include/process/process.hpp (lines 261 - 263)

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

2015-12-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review109213 --- 3rdparty/libprocess/src/tests/http_tests.cpp (line 1408)

Re: Review Request 40732: Enabling ResourcesTest.Precision

2015-12-07 Thread Avinash sridharan
> On Nov. 26, 2015, 3:35 p.m., Neil Conway wrote: > > src/tests/resources_tests.cpp, line 1526 > > > > > > If we're going to enable this test, the comment should be removed. Based on Klaus Ma's comments will

Re: Review Request 40732: Enabling ResourcesTest.Precision

2015-12-07 Thread Avinash sridharan
> On Nov. 26, 2015, 3:48 p.m., Klaus Ma wrote: > > src/tests/resources_tests.cpp, line 1534 > > > > > > We can not change this to `EXPECT_DOUBLE_EQ` because it's used to check > > `operator==` in `Resources`. I

Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

2015-12-07 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40998/ --- (Updated Dec. 7, 2015, 11:19 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 41026: libevent ssl: Added check for buffer length before swapping request.

2015-12-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41026/#review109226 --- Patch looks great! Reviews applied: [41026] Passed command:

Re: Review Request 41046: Made v1 API in mesos.proto equivalent to non-v1.

2015-12-07 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41046/ --- (Updated Dec. 7, 2015, 10:24 a.m.) Review request for mesos, Ben Mahler, Joris

Re: Review Request 40995: Added test cases for role behavior.

2015-12-07 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/#review109217 --- Ship it! LGTM! One question: Is the positive case (correct role

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41060/ --- (Updated Dec. 8, 2015, 12:24 a.m.) Review request for mesos, Bernd Mathiske,

Review Request 41046: Made v1 API in mesos.proto equivalent to non-v1.

2015-12-07 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41046/ --- Review request for mesos, Ben Mahler, Joris Van Remoortere, and Till Toenshoff.

Re: Review Request 41046: Made v1 API in mesos.proto equivalent to non-v1.

2015-12-07 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41046/ --- (Updated Dec. 7, 2015, 10:28 a.m.) Review request for mesos, Ben Mahler, Joris

Review Request 41073: Fixed a typo in a comment in ReservationTest.ACLMultipleOperations.

2015-12-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41073/ --- Review request for mesos, Greg Mann and Michael Park. Repository: mesos

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1 for 0.26.0.

2015-12-07 Thread Michael Park
> On Dec. 8, 2015, 1 a.m., Michael Park wrote: > > include/mesos/v1/mesos.proto, lines 1507-1508 > > > > > > It looks like we're also missing this from `include/mesos/mesos.proto`? > > ``` > > 1510 //

Re: Review Request 40995: Added test cases for role behavior.

2015-12-07 Thread Guangya Liu
> On 十二月 8, 2015, 12:51 a.m., Guangya Liu wrote: > > src/tests/role_tests.cpp, lines 24-27 > > > > > > I think that we should always use std first? > > > > using std::vector; > > > > using

Re: Review Request 40759: [WIP] Command executor can overcommit the slave

2015-12-07 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40759/ --- (Updated Dec. 8, 2015, 12:03 p.m.) Review request for Ben Mahler, Ian Downes

Re: Review Request 40995: Added test cases for role behavior.

2015-12-07 Thread Guangya Liu
> On 十二月 8, 2015, 12:51 a.m., Guangya Liu wrote: > > src/tests/role_tests.cpp, lines 24-27 > > > > > > I think that we should always use std first? > > > > using std::vector; > > > > using

Re: Review Request 41073: Fixed a typo in a comment in ReservationTest.ACLMultipleOperations.

2015-12-07 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41073/#review109264 --- Ship it! Ship It! - Greg Mann On Dec. 8, 2015, 3:38 a.m., Neil

Re: Review Request 40995: Added test cases for role behavior.

2015-12-07 Thread Neil Conway
> On Dec. 8, 2015, 12:51 a.m., Guangya Liu wrote: > > src/tests/role_tests.cpp, lines 24-27 > > > > > > I think that we should always use std first? > > > > using std::vector; > > > > using

Re: Review Request 41073: Fixed a typo in a comment in ReservationTest.ACLMultipleOperations.

2015-12-07 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41073/#review109266 --- Ship it! Ship It! - Michael Park On Dec. 8, 2015, 3:38 a.m.,

Re: Review Request 41050: Added a paragraph to the release guide that handles API updates.

2015-12-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41050/#review109272 --- Patch looks great! Reviews applied: [41050] Passed command:

Re: Review Request 40995: Added test cases for role behavior.

2015-12-07 Thread Neil Conway
> On Dec. 8, 2015, 12:17 a.m., Joseph Wu wrote: > > LGTM! > > > > One question: Is the positive case (correct role -> successful operation) > > not interesting or just tested in other files? There are tests for successful cases in other files. Maybe not exhaustive though... - Neil

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41060/ --- (Updated Dec. 8, 2015, 12:47 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40995: Added test cases for role behavior.

2015-12-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/#review109234 --- src/tests/role_tests.cpp (lines 24 - 27)

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/#review109238 --- Bad patch! Reviews applied: [40431] Failed command:

Re: Review Request 40873: RegistryClientTests: Created separate server to serve blobs.

2015-12-07 Thread Timothy Chen
> On Dec. 3, 2015, 6:21 p.m., Mesos ReviewBot wrote: > > Patch looks great! > > > > Reviews applied: [40872, 40873] > > > > Passed command: export OS=ubuntu:14.04;export > > CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh What does simulates the real world more

Re: Review Request 41026: libevent ssl: Added check for buffer length before swapping request.

2015-12-07 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41026/ --- (Updated Dec. 8, 2015, 1:22 a.m.) Review request for mesos and Joris Van

Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container

2015-12-07 Thread Klaus Ma
> On Dec. 8, 2015, 6:34 a.m., Till Toenshoff wrote: > > include/mesos/mesos.proto, line 821 > > > > > > We missed to update the V1 API with this change, it seems. Posted a new RR#41066 to address. - Klaus

Review Request 41066: Add containerId to ResourceUsage in v1 API

2015-12-07 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41066/ --- Review request for mesos, Niklas Nielsen and Till Toenshoff. Repository: mesos

Re: Review Request 41026: libevent ssl: Added check for buffer length before swapping request.

2015-12-07 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41026/#review109246 --- Would it be plausible to write a repro/test (in the libprocess

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

2015-12-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review109249 --- Bad patch! Reviews applied: [40539, 37999, 38000, 38094, 38950]

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1.

2015-12-07 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41060/#review109229 --- Ship it! Looks good to me overall! The non-issues are just me

Re: Review Request 40995: Added test cases for role behavior.

2015-12-07 Thread Neil Conway
> On Dec. 8, 2015, 12:51 a.m., Guangya Liu wrote: > > src/tests/role_tests.cpp, lines 24-27 > > > > > > I think that we should always use std first? > > > > using std::vector; > > > > using

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1.

2015-12-07 Thread Till Toenshoff
> On Dec. 8, 2015, 1 a.m., Michael Park wrote: > > include/mesos/v1/mesos.proto, lines 1507-1508 > > > > > > It looks like we're also missing this from `include/mesos/mesos.proto`? > > ``` > > 1510 //

  1   2   >