Re: Review Request 43855: Added Appc fetcher support to store.

2016-02-26 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43855/ --- (Updated Feb. 26, 2016, 8:36 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-02-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review120848 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 43905: Windows: Removed `user` launcher flag, preventing `su`.

2016-02-26 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43905/#review120957 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:17

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-02-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/ --- (Updated Feb. 26, 2016, 10:21 p.m.) Review request for mesos, Michael Park,

Review Request 44101: Added links to the operator endpoint doc pages.

2016-02-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44101/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

2016-02-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43635/#review120961 --- src/common/values.cpp (line 55)

Re: Review Request 43904: Windows: Removed `rootfs` launcher flag, preventing `chroot`.

2016-02-26 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43904/#review120958 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:17

Re: Review Request 38074: Calculate schedule latency with trace events

2016-02-26 Thread Cong Wang
> On Nov. 18, 2015, 12:51 a.m., Ian Downes wrote: > > src/slave/containerizer/isolators/cgroups/perf_event.hpp, line 97 > > > > > > linux/cgroups has an internal {{Result cgroup(pid_t pid, const > > string&

Re: Review Request 43960: Added an end-to-end test for docker registry puller.

2016-02-26 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43960/#review120948 --- Ship it! Ship It! - Gilbert Song On Feb. 26, 2016, 9:29

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-02-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/#review120971 --- Fix it, then Ship it! src/common/resources.cpp (line 68)

Re: Review Request 43796: Added documentation for `cgroups/net_cls` isolator.

2016-02-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43796/#review120976 --- Ship it! Ship It! - Jie Yu On Feb. 22, 2016, 6:26 p.m.,

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

2016-02-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43635/#review120982 --- Fix it, then Ship it! src/common/values.cpp (lines 60 - 62)

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

2016-02-26 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43416/ --- (Updated Feb. 26, 2016, 9:23 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

2016-02-26 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43552/#review120977 --- Ship it! Ship It! - Kevin Klues On Feb. 24, 2016, 7:23

Re: Review Request 43662: Added support for pipelining calls to the scheduler library.

2016-02-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43662/#review120947 --- src/scheduler/scheduler.cpp (lines 203 - 206)

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

2016-02-26 Thread Alex Clemmer
> On Feb. 25, 2016, 12:22 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp, line 52 > > > > > > Why is the cast to `size_t` needed here? > > Alex Clemmer wrote: > It is

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-26 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/ --- (Updated Feb. 26, 2016, 10:29 p.m.) Review request for mesos, Joris Van

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

2016-02-26 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43907/#review120964 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:41

Re: Review Request 43939: Required jsonifying of generic protobuf to be explicit opt-in [mesos].

2016-02-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43939/#review120965 --- Ship it! Ship It! - Neil Conway On Feb. 26, 2016, 8:39

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-26 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/ --- (Updated Feb. 26, 2016, 10:38 p.m.) Review request for mesos, Joris Van

Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

2016-02-26 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43906/#review120968 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:17

Re: Review Request 43796: Added documentation for `cgroups/net_cls` isolator.

2016-02-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43796/#review120950 --- Ship it! Ship It! - Neil Conway On Feb. 22, 2016, 6:26

Re: Review Request 43903: Stout: Add `WindowsError` constructor to `Result`.

2016-02-26 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43903/#review120956 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:13

Re: Review Request 43938: Required jsonifying of generic protobuf to be explicit opt-in [stout].

2016-02-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43938/#review120963 --- Fix it, then Ship it!

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

2016-02-26 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/#review120966 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:40

Re: Review Request 43999: Use relative path to create libraries symbolic link.

2016-02-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43999/#review120856 --- Patch looks great! Reviews applied: [43999] Passed command:

Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

2016-02-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44058/#review120860 --- Ship it! Ship It! - haosdent huang On Feb. 26, 2016, 7:19

Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

2016-02-26 Thread fan du
> On 二月 26, 2016, 9:34 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [44058] > > > > Failed command: ./support/apply-review.sh -n -r 44058 > > > > Error: > > 2016-02-26 09:34:14 URL:https://reviews.apache.org/r/44058/diff/raw/ > > [4122/4122] -> "44058.patch" [1] > >

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-02-26 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review120685 --- src/tests/cluster.hpp (line 111)

Re: Review Request 44063: Waited for status update to happen before proceeding in test.

2016-02-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44063/#review120859 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

2016-02-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44058/#review120849 --- Bad patch! Reviews applied: [44058] Failed command:

Review Request 44063: Waited for status update to happen before proceeding in test.

2016-02-26 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44063/ --- Review request for mesos. Bugs: MESOS-4784

Review Request 44071: Allowed disabling metrics endpoint rate limiting via the environment.

2016-02-26 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44071/ --- Review request for mesos. Bugs: MESOS-4776

Re: Review Request 44044: CMake: src CMakeLists-Added source to build master.

2016-02-26 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44044/ --- (Updated Feb. 26, 2016, 3:10 p.m.) Review request for mesos, Artem

Re: Review Request 43995: CMake: CompilationConfigure-Creating MACROS to get time and date.

2016-02-26 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43995/ --- (Updated Feb. 26, 2016, 3:16 p.m.) Review request for mesos, Artem

Review Request 44070: Allowed disabling metrics endpoint rate limiting via the environment.

2016-02-26 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44070/ --- Review request for mesos. Bugs: MESOS-4776

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/#review120998 --- Ship it! Ship It! - Joris Van Remoortere On Feb. 26, 2016,

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

2016-02-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/#review120997 --- Ship it! Ship It! - Michael Park On Feb. 26, 2016, 10:21

Re: Review Request 43969: Added test for Appc image fetcher.

2016-02-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43969/#review121010 --- src/tests/containerizer/provisioner_appc_tests.cpp (line 240)

Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

2016-02-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44110/#review121017 --- docs/configuration.md (line 86)

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-26 Thread Ian Downes
> On Feb. 8, 2016, 2:52 p.m., Ian Downes wrote: > > src/linux/perf.cpp, lines 423-426 > > > > > > Hmmm, I'm not satisfied with this. I thought the new output format was > > introduced at a specific kernel version

Re: Review Request 43855: Added Appc fetcher support to store.

2016-02-26 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43855/ --- (Updated Feb. 26, 2016, 10:42 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

2016-02-26 Thread Neil Conway
> On Feb. 17, 2016, 12:30 a.m., Klaus Ma wrote: > > src/common/values.cpp, line 67 > > > > > > Let's add check on overflow; it will be helpful if scalar value was > > big. Scalar is a general type, there maybe used

Review Request 44113: Cleaned up assertions in test cases.

2016-02-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44113/ --- Review request for mesos, Joris Van Remoortere and Michael Park. Repository:

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/#review121002 --- This breaks the IO based tests in Libprocess. - Joris Van

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

2016-02-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43635/#review121007 --- Fix it, then Ship it! src/common/values.cpp (line 62)

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

2016-02-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43635/ --- (Updated Feb. 27, 2016, 12:10 a.m.) Review request for mesos, Joris Van

Re: Review Request 43999: Use relative path to create libraries symbolic link.

2016-02-26 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43999/ --- (Updated Feb. 27, 2016, 9:55 a.m.) Review request for mesos, James Peach and

Re: Review Request 43999: Use relative path to create libraries symbolic link.

2016-02-26 Thread Zhiwei Chen
> On Feb. 27, 2016, 1:36 a.m., Kapil Arya wrote: > > src/Makefile.am, lines 2010-2011 > > > > > > Minor nit. Can we fix the alignment to four spaces to be consistent > > with the rest of the block? Also align the

Re: Review Request 43662: Added support for pipelining calls to the scheduler library.

2016-02-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43662/#review121046 --- Fix it, then Ship it! src/scheduler/scheduler.cpp (line 276)

Re: Review Request 43667: Modified existing scheduler tests as an aftermath of pipelining change.

2016-02-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43667/#review121049 --- Ship it! Ship It! - Vinod Kone On Feb. 17, 2016, 10:46

Re: Review Request 43664: Modified SchedulerTest.Subscribe to not test for failover.

2016-02-26 Thread Vinod Kone
> On Feb. 27, 2016, 2:08 a.m., Vinod Kone wrote: > > src/tests/scheduler_tests.cpp, line 136 > > > > > > why will there be future invocations? I see the reasoning in the next review. Maybe move this particular

Re: Review Request 39372: Introduced a callback interface for testing the scheduler library.

2016-02-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39372/#review121053 --- Ship it! Ship It! - Vinod Kone On Feb. 22, 2016, 8:19 p.m.,

Re: Review Request 43847: Added master/scheduler failover tests for scheduler library.

2016-02-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43847/#review121055 --- Fix it, then Ship it! src/tests/scheduler_tests.cpp (line

Re: Review Request 43999: Use relative path to create libraries symbolic link.

2016-02-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43999/#review121056 --- Patch looks great! Reviews applied: [43999] Passed command:

Re: Review Request 43969: Added test for Appc image fetcher.

2016-02-26 Thread Jojy Varghese
> On Feb. 27, 2016, 12:21 a.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, line 539 > > > > > > We might want to serve multiple images. Can you make it more general so > > that we can

Re: Review Request 43636: Cleaned up various code in a test file.

2016-02-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43636/ --- (Updated Feb. 27, 2016, 1:58 a.m.) Review request for mesos, Joris Van

Re: Review Request 44111: Updated UI controller to use master/state endpoint.

2016-02-26 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44111/ --- (Updated Feb. 27, 2016, 2:19 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 44129: Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.

2016-02-26 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44129/ --- (Updated Feb. 26, 2016, 11:10 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

2016-02-26 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44058/#review121061 --- The document monitoring.md and some test cases are also needed.

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

2016-02-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43635/#review121043 --- Fix it, then Ship it! src/common/values.cpp (lines 96 - 100)

Review Request 44126: Fixed a few style issues in the docs.

2016-02-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44126/ --- Review request for mesos, Joris Van Remoortere and Michael Park. Repository:

Re: Review Request 44113: Cleaned up assertions in test cases.

2016-02-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44113/ --- (Updated Feb. 27, 2016, 1:56 a.m.) Review request for mesos, Joris Van

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

2016-02-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43635/ --- (Updated Feb. 27, 2016, 1:57 a.m.) Review request for mesos, Joris Van

Re: Review Request 44111: Updated UI controller to use master/state endpoint.

2016-02-26 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44111/ --- (Updated Feb. 27, 2016, 2:17 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 44112: Updated tests to use /state endpoint.

2016-02-26 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44112/ --- (Updated Feb. 27, 2016, 2:18 a.m.) Review request for mesos, Alexander Rojas

Re: Review Request 43846: Added support for specifying detector to the callback interface.

2016-02-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43846/#review121054 --- include/mesos/v1/scheduler.hpp (line 77)

Re: Review Request 43883: Added allocator metrics for number of offer filters per framework.

2016-02-26 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/#review121058 --- src/tests/hierarchical_allocator_tests.cpp (line 2614)

Review Request 44129: Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.

2016-02-26 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44129/ --- Review request for mesos, haosdent huang, Joris Van Remoortere, Kevin Devroede,

Re: Review Request 44129: Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.

2016-02-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44129/#review121060 --- Ship it! Ship It! - Joris Van Remoortere On Feb. 27, 2016,

Re: Review Request 43969: Added test for Appc image fetcher.

2016-02-26 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43969/ --- (Updated Feb. 27, 2016, 4:05 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 44001: CMake: Add MasterConfigure for master executable build.

2016-02-26 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44001/#review121009 --- src/master/cmake/MasterConfigure.cmake (line 49)

Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

2016-02-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44110/#review121025 --- Ship it! Ship It! - Neil Conway On Feb. 27, 2016, 12:55

Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

2016-02-26 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44110/ --- (Updated Feb. 27, 2016, 12:55 a.m.) Review request for mesos, Alexander Rojas

Re: Review Request 44108: Added 'Updating the wiki' step to the release guide.

2016-02-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44108/#review121032 --- Ship it! Ship It! - Vinod Kone On Feb. 26, 2016, 11:34

Re: Review Request 44026: Moved future tests into future_tests.cpp.

2016-02-26 Thread Cong Wang
> On Feb. 26, 2016, 1:45 a.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp, lines 1764-1776 > > > > > > Should this be moved to `future_tests.cpp` too? Yes, it should, because this is

Re: Review Request 43882: Added allocation metrics for allocation time.

2016-02-26 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/#review121029 --- src/master/allocator/mesos/hierarchical.hpp (line 360)

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

2016-02-26 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review121001 --- As with the previous one, I don't know whether this metric will

Re: Review Request 44029: Fetcher::basename should ignore query strings and fragments.

2016-02-26 Thread Jiang Yan Xu
> On Feb. 26, 2016, 5:40 a.m., Bernd Mathiske wrote: > > There is a more elaborate solution to this problem > > (https://reviews.apache.org/r/40054), but it requires a lot of code to > > implement URL parsing. Until we finalize that, I think the patch at hand > > gets the most urgent job

Re: Review Request 44108: Added 'Updating the wiki' step to the release guide.

2016-02-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44108/#review121036 --- Patch looks great! Reviews applied: [44108] Passed command:

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

2016-02-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43416/#review120999 --- Ship it! Ship It! - Michael Park On Feb. 26, 2016, 9:23

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

2016-02-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43635/ --- (Updated Feb. 26, 2016, 11:52 p.m.) Review request for mesos, Joris Van

Re: Review Request 43635: Changed scalar resources to use fixed-point internally.

2016-02-26 Thread Neil Conway
> On Feb. 26, 2016, 9:40 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, line 61 > > > > > > let's pull out into a constant as discussed offline. Per discussion, we aren't going to do this for now

Re: Review Request 44003: CMake: Add CMakeLists for master executable build.

2016-02-26 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44003/#review120960 --- src/master/CMakeLists.txt (line 17)

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

2016-02-26 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/#review121005 --- src/slave/CMakeLists.txt (line 27)

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-26 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/ --- (Updated Feb. 27, 2016, 1:24 a.m.) Review request for mesos, Joris Van

Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

2016-02-26 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44110/#review121016 --- Ship it! Ship It! - Alexander Rojas On Feb. 27, 2016, 1:33

Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

2016-02-26 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44110/ --- (Updated Feb. 27, 2016, 12:33 a.m.) Review request for mesos, Alexander Rojas

Re: Review Request 43999: Use relative path to create libraries symbolic link.

2016-02-26 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43999/#review121033 --- Ship it! ran a patched version through our pipeline and our

Re: Review Request 43662: Added support for pipelining calls to the scheduler library.

2016-02-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43662/ --- (Updated Feb. 27, 2016, 1:22 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43662: Added support for pipelining calls to the scheduler library.

2016-02-26 Thread Anand Mazumdar
> On Feb. 26, 2016, 8:29 p.m., Vinod Kone wrote: > > src/scheduler/scheduler.cpp, line 394 > > > > > > what if we are in CONNECTING state? Good catch. I had missed that. Added a explicit check for CONNECTING too.

Re: Review Request 43667: Modified existing scheduler tests as an aftermath of pipelining change.

2016-02-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43667/ --- (Updated Feb. 27, 2016, 4:45 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43846: Added support for specifying detector to the callback interface.

2016-02-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43846/ --- (Updated Feb. 27, 2016, 4:48 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43846: Added support for specifying detector to the callback interface.

2016-02-26 Thread Anand Mazumdar
> On Feb. 27, 2016, 2:43 a.m., Vinod Kone wrote: > > src/scheduler/scheduler.cpp, lines 637-638 > > > > > > Yikes. Why are you doing it like this, instead of passing detector as > > an optional argument to the

Re: Review Request 43847: Added master/scheduler failover tests for scheduler library.

2016-02-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43847/ --- (Updated Feb. 27, 2016, 4:48 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44113: Cleaned up assertions in test cases.

2016-02-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44113/#review121063 --- Patch looks great! Reviews applied: [43635, 44126, 43636, 44113]

Re: Review Request 43664: Modified SchedulerTest.Subscribe to not test for failover.

2016-02-26 Thread Anand Mazumdar
> On Feb. 27, 2016, 2:08 a.m., Vinod Kone wrote: > > src/tests/scheduler_tests.cpp, line 136 > > > > > > why will there be future invocations? > > Vinod Kone wrote: > I see the reasoning in the next review.

Re: Review Request 43662: Added support for pipelining calls to the scheduler library.

2016-02-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43662/ --- (Updated Feb. 27, 2016, 4:43 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 41854: Added module initialization to Master main().

2016-02-26 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/#review121071 --- Ship it! Ship It! - Kapil Arya On Feb. 13, 2016, 12:32

Re: Review Request 44112: Updated tests to use /state endpoint.

2016-02-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44112/#review121069 --- Patch looks great! Reviews applied: [44110, 44111, 44112]

  1   2   >