Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

2016-03-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/#review123206 --- src/master/contenders/contender.cpp (line 100)

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/#review123205 --- src/master/contenders/zookeeper.cpp (lines 27 - 33)

Re: Review Request 42036: Windows: Added `slave/flags.cpp` to Windows build.

2016-03-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42036/ --- (Updated March 11, 2016, 9:51 p.m.) Review request for mesos, Alex Naparu,

Review Request 44730: Refactored `model` for TaskInfo to common/.

2016-03-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44730/ --- Review request for mesos. Repository: mesos Description --- Also added

Re: Review Request 44722: Libprocess: Add `SOL_TCP` flag for Windows.

2016-03-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44722/#review123213 --- Patch looks great! Reviews applied: [44078, 44722] Passed

Re: Review Request 44579: Minor fix to output state during a `CHECK` failure.

2016-03-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44579/#review123220 --- Ship it! Ship It! - Vinod Kone On March 9, 2016, 6:03 p.m.,

Re: Review Request 44578: Pass `received` argument by const ref in the executor library.

2016-03-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44578/#review123219 --- Ship it! Ship It! - Vinod Kone On March 9, 2016, 6:03 p.m.,

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-11 Thread Jie Yu
> On March 11, 2016, 8:02 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct

Re: Review Request 44319: Removed initialize method from the authorizer interface.

2016-03-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44319/#review123210 --- Ship it! Ship It! - Vinod Kone On March 11, 2016, 1:45

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

2016-03-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review123214 --- Ship it! Ship It! - Vinod Kone On March 11, 2016, 3:57

Re: Review Request 44580: Made changes to the executor library around managing connections.

2016-03-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44580/ --- (Updated March 11, 2016, 11:39 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43823: Updated `/tasks` master endpoint to use jsonify.

2016-03-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43823/ --- (Updated March 11, 2016, 10:10 p.m.) Review request for mesos and Michael

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-11 Thread Avinash sridharan
> On March 11, 2016, 8:02 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct

Re: Review Request 44580: Made changes to the executor library around managing connections.

2016-03-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44580/#review123223 --- Fix it, then Ship it! src/executor/executor.cpp (line 424)

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-03-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/#review123207 --- src/master/main.cpp (line 238)

Re: Review Request 43910: Enhanced a test case for the `/state` agent endpoint.

2016-03-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43910/ --- (Updated March 11, 2016, 10:11 p.m.) Review request for mesos and Michael

Review Request 44731: Modified `FaultToleranceTest.SchedulerExit` to wait for shutdown.

2016-03-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44731/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4629

Review Request 44728: Replaced `.get()` `Option` calls with `->` operator.

2016-03-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44728/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 44580: Made changes to the executor library around managing connections.

2016-03-11 Thread Anand Mazumdar
> On March 11, 2016, 10:44 p.m., Vinod Kone wrote: > > src/executor/executor.cpp, line 462 > > > > > > This if statement sounds like all combinations of "checkpoint", > > "connecting" and "recoveryTimeout" are

Re: Review Request 43911: Updated `/state` agent endpoint to use jsonify.

2016-03-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43911/ --- (Updated March 11, 2016, 10:33 p.m.) Review request for mesos and Michael

Review Request 44734: Marked a few internal functions `static`.

2016-03-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44734/ --- Review request for mesos. Repository: mesos Description --- Marked a

Re: Review Request 44733: Added fault tolerance tests for the V1 API.

2016-03-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44733/#review123234 --- Patch looks great! Reviews applied: [44578, 44579, 44580, 44727,

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-11 Thread Anurag Singh
> On March 11, 2016, 9:40 p.m., Joseph Wu wrote: > > I think you should send an email to the user and dev mailing lists to ask > > for high-level feedback on this interface. We want to make sure the > > interface is broad enough to support different implementations. (And I'm > > no expert

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 11, 2016, 9:52 a.m.) Review request for mesos, Adam B,

Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

2016-03-11 Thread Joerg Schad
> On March 10, 2016, 8:47 p.m., Joris Van Remoortere wrote: > > src/slave/containerizer/mesos/linux_launcher.cpp, line 301 > > > > > > We now rely on the hook logic to do this right? > > Let's document this.

Review Request 44702: Added missing blank line in reservation_test.

2016-03-11 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44702/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description

Re: Review Request 44694: Enabled multiple calls to ModuleManager::load().

2016-03-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44694/#review123119 --- Patch looks great! Reviews applied: [44694] Passed command:

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

2016-03-11 Thread Greg Mann
> On March 11, 2016, 5:23 a.m., Alexander Rojas wrote: > > src/authentication/http/basic_authenticator_factory.cpp, lines 58-60 > > > > > > This is exactly the reason why I didn't do it this way, since now we > >

Re: Review Request 43708: Windows:[2/3] Added zlib compilation steps for Windows.

2016-03-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43708/ --- (Updated March 11, 2016, 9:24 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43708: Windows:[2/3] Added zlib compilation steps for Windows.

2016-03-11 Thread Alex Clemmer
> On March 11, 2016, 4 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake, lines 70-71 > > > > > > What does setting it twice do? It appends `${ZLIB_ROOT}-build` to a list

Re: Review Request 44076: Windows: [2/3] Used `os::execlp` in launch.cpp.

2016-03-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44076/ --- (Updated March 11, 2016, 9:24 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

2016-03-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43709/ --- (Updated March 11, 2016, 9:24 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44319: Removed initialize method from the authorizer interface.

2016-03-11 Thread Alexander Rojas
> On March 10, 2016, 8:32 p.m., Vinod Kone wrote: > > src/master/main.cpp, line 372 > > > > > > So, we create non-default authorizer if --authorizers specifies a > > non-default name but create the default

Re: Review Request 41334: Added helper functions to filter allocation slack resources.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41334/ --- (Updated 三月 11, 2016, 9:06 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40529: Added helper function to get stateless resources.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40529/ --- (Updated 三月 11, 2016, 9:07 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42547: Added helper function to get non usage slack resources.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42547/ --- (Updated 三月 11, 2016, 9:07 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

2016-03-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- (Updated March 11, 2016, 9:39 a.m.) Review request for mesos, Adam B,

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 三月 11, 2016, 9:10 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42491: Updated allocatable() to distinguish different resources.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42491/ --- (Updated 三月 11, 2016, 9:12 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41848: Do not enable task and executor run on different resources.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41848/ --- (Updated 三月 11, 2016, 9:12 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42194: Added test cases for updateAvailable.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42194/ --- (Updated 三月 11, 2016, 9:12 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42113: Added test cases for updateAllocation.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42113/ --- (Updated 三月 11, 2016, 9:11 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41791: Updated allocation slack when dynamic reserve called.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 三月 11, 2016, 9:11 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.

2016-03-11 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44087/ --- (Updated March 11, 2016, 8:39 a.m.) Review request for mesos and Joris Van

Re: Review Request 42590: Removed reserved() API.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/ --- (Updated 三月 11, 2016, 9:08 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41772: Added helper function to flatten resources.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 三月 11, 2016, 9:10 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/ --- (Updated 三月 11, 2016, 9:10 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 三月 11, 2016, 9:10 a.m.) Review request for mesos, Ben Mahler, Artem

Review Request 44749: Separate XFS utilities.

2016-03-11 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44749/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-4828

Re: Review Request 42590: Renamed reserved() to reservations().

2016-03-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review123266 --- I left a comment but I'll take care of that for you before

Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.

2016-03-11 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/#review123268 --- Ship it! Ship It! - Daniel Pravat On March 12, 2016, 1:28

Re: Review Request 44749: Separate XFS utilities.

2016-03-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44749/#review123269 --- Patch looks great! Reviews applied: [44342, 44749] Passed

Review Request 44753: Fixed runtime isolator tests out of disk issue.

2016-03-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44753/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 44734: Marked a few internal functions `static`.

2016-03-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44734/#review123242 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 44743: Improved grammar in `--help` output for master and agent.

2016-03-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44743/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Review Request 44742: Improved documentation for multiple disks.

2016-03-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44742/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Review Request 44747: Stout: Added implementation of `write` that works on Windows.

2016-03-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44747/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 44748: Stout: Added implementation of `read` that works on Windows.

2016-03-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 44747: Stout: Added implementation of `write` that works on Windows.

2016-03-11 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44747/#review123252 --- Ship it! Ship It! - Yi Sun On March 12, 2016, 1:28 a.m.,

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

2016-03-11 Thread Greg Mann
On March 12, 2016, 2:11 a.m., fan du wrote: > > In a separate patch, could you add documentation for these metrics to > > docs/monitoring.md? Whoops, sorry! I see that you already have the documentation :-) - Greg --- This is an

Re: Review Request 42590: Renamed reserved() to reservations().

2016-03-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review123265 --- Ship it! Ship It! - Ben Mahler On March 12, 2016, 2:47

Re: Review Request 44342: XFS disk resource isolator.

2016-03-11 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44342/ --- (Updated March 12, 2016, 1:30 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44717: Marked a few Duration constants `constexpr`.

2016-03-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44717/#review123254 --- Ship it! Ship It! - Ben Mahler On March 11, 2016, 6:32

Re: Review Request 44743: Improved grammar in `--help` output for master and agent.

2016-03-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44743/#review123263 --- Patch looks great! Reviews applied: [44742, 44743] Passed

Re: Review Request 44090: Windows: Added a cast for `get/setsockopt` parameters.

2016-03-11 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44090/ --- (Updated March 12, 2016, 2:54 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 42590: Renamed reserved() to reservations().

2016-03-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review123270 --- Bad patch! Reviews applied: [42590] Failed command:

Re: Review Request 44742: Improved documentation for multiple disks.

2016-03-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44742/ --- (Updated March 12, 2016, 1:24 a.m.) Review request for mesos and Joris Van

Re: Review Request 44470: Implemented runtime isoaltor default entrypoint test.

2016-03-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44470/#review123249 --- Patch looks great! Reviews applied: [43956, 44467, 44469, 44470]

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-11 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 12, 2016, 2:02 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44190: Made `Bytes` usable in `constexpr` expressions [stout].

2016-03-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44190/#review123253 --- Ship it! Ship It! - Ben Mahler On March 11, 2016, 6:30

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

2016-03-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review123247 --- Thanks for the edits! A few comments below.

Re: Review Request 44456: Added Appc provisioner integration test.

2016-03-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44456/#review123246 --- Fix it, then Ship it!

Re: Review Request 44720: Replaced `const string` slave constants with `constexpr char[]`.

2016-03-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44720/#review123261 --- Ship it! Ship It! - Ben Mahler On March 11, 2016, 6:32

Re: Review Request 44719: Avoided external linkage for slave constants.

2016-03-11 Thread Ben Mahler
> On March 12, 2016, 2:28 a.m., Ben Mahler wrote: > > I'll make sure the commit description provides the similar motivation as was provided in https://reviews.apache.org/r/44191/ (although referring to the latest project style guidelines rather than performance). - Ben

Re: Review Request 42590: Renamed reserved() to reservations().

2016-03-11 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review123267 --- include/mesos/resources.hpp (line 228)

Re: Review Request 44469: Implemented runtime isolator default cmd test.

2016-03-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44469/ --- (Updated March 11, 2016, 4:16 p.m.) Review request for mesos, Artem

Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.

2016-03-11 Thread Yi Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/#review123251 --- Ship it! Ship It! - Yi Sun On March 12, 2016, 1:28 a.m.,

Re: Review Request 44719: Avoided external linkage for slave constants.

2016-03-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44719/#review123258 --- Ship it! src/slave/constants.hpp (lines 110 - 112)

Re: Review Request 44721: Avoided external linkage for sched constants.

2016-03-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44721/#review123262 --- Ship it! Ship It! - Ben Mahler On March 11, 2016, 6:32

Re: Review Request 43956: Created base docker image for test suite.

2016-03-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43956/ --- (Updated March 11, 2016, 4:15 p.m.) Review request for mesos, Artem

Re: Review Request 44467: Implemented local puller shell command test.

2016-03-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44467/ --- (Updated March 11, 2016, 4:15 p.m.) Review request for mesos, Artem

Re: Review Request 44470: Implemented runtime isoaltor default entrypoint test.

2016-03-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44470/ --- (Updated March 11, 2016, 4:16 p.m.) Review request for mesos, Artem

Re: Review Request 44191: Avoided external linkage for master constants.

2016-03-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44191/#review123255 --- Fix it, then Ship it! We may want to update the description to

Re: Review Request 44718: Replaced `const string` master constants with `constexpr char[]`.

2016-03-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44718/#review123257 --- Ship it! Ship It! - Ben Mahler On March 11, 2016, 6:32

Re: Review Request 41772: Added helper function to flatten resources.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 三月 12, 2016, 2:46 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42590: Renamed reserved() to reservations().

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/ --- (Updated 三月 12, 2016, 2:47 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 44421: Added support for "overlay" keyword.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/ --- (Updated 三月 11, 2016, 11:58 a.m.) Review request for mesos, haosdent huang,

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-11 Thread Alexander Rojas
> On March 10, 2016, 10:06 p.m., Vinod Kone wrote: > > src/Makefile.am, line 158 > > > > > > any reason why this should be exposed in the include directory? > > Alexander Rojas wrote: > Main reason is because

Re: Review Request 44319: Removed initialize method from the authorizer interface.

2016-03-11 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44319/ --- (Updated March 11, 2016, 2:45 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44620: Documented how to make executors work with SSL.

2016-03-11 Thread Jan Schlicht
> On March 10, 2016, 10:32 p.m., Joseph Wu wrote: > > docs/ssl.md, line 102 > > > > > > Not sure exactly how much detail we want to add here about specific > > configurations (especially considering the upcoming

Re: Review Request 44421: Added support for "overlay" keyword.

2016-03-11 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review123133 --- Ship it! Ship It! - haosdent huang On March 11, 2016, 11:58

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

2016-03-11 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 11, 2016, 2:54 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44620: Documented how to make executors work with SSL.

2016-03-11 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44620/ --- (Updated March 11, 2016, 12:26 p.m.) Review request for mesos, Adam B and

Re: Review Request 44431: Do not check overlayfs when create overlay backend.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44431/ --- (Updated 三月 11, 2016, 12:02 p.m.) Review request for mesos, Jie Yu and Shuai

Re: Review Request 44431: Do not check overlayfs when create overlay backend.

2016-03-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44431/#review123135 --- Patch looks great! Reviews applied: [44421, 44431] Passed

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-11 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/ --- (Updated March 11, 2016, 2:47 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

2016-03-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44753/#review123274 --- Patch looks great! Reviews applied: [44753] Passed command:

Re: Review Request 44620: Documented how to make executors work with SSL.

2016-03-11 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44620/#review123136 --- docs/ssl.md (line 101)

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

2016-03-11 Thread Joerg Schad
> On March 11, 2016, 2:29 p.m., Joerg Schad wrote: > > src/tests/slave_tests.cpp, line 1435 > > > > > > Should we add a comment that authn is required by default? required -> enabled by default in testcases. -

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

2016-03-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review123143 --- Patch looks great! Reviews applied: [44318, 44319, 44320, 44322]

  1   2   3   >