Re: Review Request 47702: Added framework role & principal to the Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/#review134297 --- Patch looks great! Reviews applied: [47702] Passed command:

Re: Review Request 44154: Added appc_simple_discovery_uri_prefix to configuration.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44154/ --- (Updated May 23, 2016, 3:45 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 47515: Enforced a constraint on `DiskInfo.Persistence.principal`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47515/ --- (Updated May 23, 2016, 4:37 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 47702: Added framework role & principal to the Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/#review134296 --- Do you forget to update * `framework.html`

Re: Review Request 47708: Rearranged `expectedOffers` in the SlavesEndpointFullResources Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47708/#review134299 --- Patch looks great! Reviews applied: [47706, 47707, 47708]

Re: Review Request 47558: Added allower interface to authorizer.

> On May 22, 2016, 10:58 p.m., Michael Park wrote: > > include/mesos/authorizer/authorizer.hpp, line 54 > > > > > > If we go with `ObjectAuthorizer`, we should call this `authorized`, but > > at the least we should

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated May 23, 2016, 5:03 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 47558: Added allower interface to authorizer.

> On May 22, 2016, 10:58 p.m., Michael Park wrote: > > include/mesos/authorizer/authorizer.hpp, line 51 > > > > > > I'm leaning towards calling this `ObjectAuthorizer`. We would > > effectively have

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated May 23, 2016, 5:03 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On May 17, 2016, 9:27 p.m., haosdent huang wrote: > > src/Makefile.am, line 2048 > > > > > > I think you forgot to update the CMake build files. I see all the tests are not included in `src/CMakeLists.txt`, so

Re: Review Request 46613: Introduced filtering relevant actions and acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/#review134291 --- include/mesos/authorizer/authorizer.proto (lines 69 - 70)

Re: Review Request 47558: Added allower interface to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/ --- (Updated May 22, 2016, 9:25 p.m.) Review request for mesos, Michael Park and

Re: Review Request 47558: Added allower interface to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/#review134295 --- include/mesos/authorizer/authorizer.hpp (line 35)

Re: Review Request 47702: Added framework role & principal to the Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/ --- (Updated May 23, 2016, 12:33 a.m.) Review request for mesos, haosdent huang

Review Request 47708: Rearranged `expectedOffers` in the SlavesEndpointFullResources Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47708/ --- Review request for mesos, Benjamin Mahler and Neil Conway. Bugs: MESOS-5256

Review Request 47706: Provided defaults for all virtual functions in `mesos::slave::Isolator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47706/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Bugs: MESOS-5435

Review Request 47707: Refactored resource enumeration for containerizers and isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47707/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Bugs: MESOS-5256

Re: Review Request 47702: Added framework role & principal to the Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/#review134285 --- src/webui/master/static/frameworks.html (line 16)

Re: Review Request 47702: Added framework role & principal to the Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/#review134286 --- Patch looks great! Reviews applied: [47702] Passed command:

Re: Review Request 45668: Enable CMake build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review134287 --- Bad patch! Reviews applied: [45668] Failed command:

Re: Review Request 47699: Fixed incomplete bootstrap 3.3.6 upgrade.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47699/#review134288 --- Ship it! looks good to me! - Michael Lunøe On May 22, 2016,

Re: Review Request 45668: Enable CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/ --- (Updated Mayo 22, 2016, 8:15 p.m.) Review request for mesos, Alex Clemmer,

Re: Review Request 45668: Enable CMake build

> On Mayo 22, 2016, 5:26 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 134 > > > > > > Shouldn't this be "--" instead of "__" ? > > > > # Replace "--" with "-D". > >

Re: Review Request 45668: Enable CMake build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/ --- (Updated Mayo 22, 2016, 6:38 p.m.) Review request for mesos, Alex Clemmer,

Re: Review Request 45668: Enable CMake build.

> On Mayo 22, 2016, 5:26 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 134 > > > > > > Shouldn't this be "--" instead of "__" ? > > > > # Replace "--" with "-D". > >

Review Request 47702: Added framework role & principal to the Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/ --- Review request for mesos, haosdent huang and Vinod Kone. Bugs: MESOS-4788

Re: Review Request 45668: Enable CMake build

> On May 22, 2016, 5:26 p.m., Vinod Kone wrote: > > Also you need a "." in the summary of the review to make reviewbot happy. > On May 22, 2016, 5:26 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 134 > >

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47646/#review134270 --- Patch looks great! Reviews applied: [47646] Passed command:

Re: Review Request 47700: Added a benchmark for reconciling tasks using the library/driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47700/#review134276 --- src/tests/scheduler_tests.cpp (line 1595)

Re: Review Request 47698: Included .proto javadoc during website generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47698/#review134272 --- Patch looks great! Reviews applied: [47698] Passed command:

Re: Review Request 45668: Enable CMake build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review134273 --- Bad patch! Reviews applied: [45668] Failed command:

Re: Review Request 47699: Fixed incomplete bootstrap 3.3.6 upgrade.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47699/#review134275 --- Patch looks great! Reviews applied: [47699] Passed command:

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47646/#review134278 --- Ship it! Ship It! - Vinod Kone On May 22, 2016, 12:52 p.m.,

Re: Review Request 47695: Updated the website generation and development workflows with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134279 --- site/README.md (line 15)

Re: Review Request 47699: Fixed incomplete bootstrap 3.3.6 upgrade.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47699/#review134281 --- Ship it! Ship It! - Vinod Kone On May 22, 2016, 2:22 p.m.,

Review Request 47699: Fixed incomplete bootstrap 3.3.6 upgrade.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47699/ --- Review request for mesos, Bernd Mathiske, Michael Lunøe, and Thomas Rampelberg.

Review Request 47700: Added a benchmark for reconciling tasks using the library/driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47700/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5222

Re: Review Request 45668: Enable CMake build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review134277 --- support/docker_build.sh (line 126)

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47646/ --- (Updated May 22, 2016, 12:52 p.m.) Review request for mesos, Tomasz

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

> On May 20, 2016, 6:45 p.m., Kevin Klues wrote: > > docs/release-guide.md, line 180 > > > > > > This isn't really a step in "updating the website". As such, I'd > > probably move this to the last step and reword

Re: Review Request 47698: Included .proto javadoc during website generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47698/#review134280 --- Ship it! Ship It! - Vinod Kone On May 22, 2016, 1:11 p.m.,

Re: Review Request 47695: Updated the website generation and development workflows with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134265 --- Patch looks great! Reviews applied: [47695] Passed command:

Re: Review Request 45668: Enable CMake build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/ --- (Updated Mayo 22, 2016, 2:10 p.m.) Review request for mesos, Alex Clemmer,

Review Request 47698: Included .proto javadoc during website generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47698/ --- Review request for mesos, Adam B, Ben Whitehead, and Connor Doyle. Bugs:

Re: Review Request 47693: Added more error info for mesos ps.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47693/#review134282 --- Ship it! Ship It! - Vinod Kone On May 22, 2016, 1:40 a.m.,

Re: Review Request 47700: Added a benchmark for reconciling tasks using the library/driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47700/#review134283 --- Patch looks great! Reviews applied: [47700] Passed command:

Review Request 47711: Added more verbose message when mesos command encouter error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47711/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5438

Review Request 47695: Updated the website generation and development workflows with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/ --- Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and

Re: Review Request 47695: Updated the website generation and development workflows with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/ --- (Updated May 22, 2016, 10:45 a.m.) Review request for mesos, Tomasz

Re: Review Request 47671: Windows: Allowed `dynamic_cast` on an object being constructed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47671/ --- (Updated May 22, 2016, 6:59 a.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

> On April 9, 2016, 7:08 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 757 > > > > > > What about `ShareableInfo`? This is also consistent with > > `RevocableInfo`. > > Anindya Sinha wrote: > I

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shared.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45958/ --- (Updated May 22, 2016, 7:05 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

> On May 16, 2016, 6:01 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 190 > > > > > > This is supposed to be hidden in private right? Done as a part of the refactor. Few of the comments below have

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/ --- (Updated May 22, 2016, 7:08 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On May 11, 2016, 3:49 p.m., Jiang Yan Xu wrote: > > Looks like the SHARE and UNSHARE operations are not in this patch? Yes that is correct. > On May 11, 2016, 3:49 p.m., Jiang Yan Xu wrote: > > src/common/resources.cpp, line 1328 > >

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated May 22, 2016, 7:11 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated May 22, 2016, 7:12 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45960/ --- (Updated May 22, 2016, 7:09 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

> On May 16, 2016, 6:24 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 346 > > > > > > s/nonShareable/nonshared/. Renamed nonShareable() to nonShared(). - Anindya

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated May 22, 2016, 7:21 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45964: Add unit tests for sharing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/ --- (Updated May 22, 2016, 7:21 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45966: Offer shareable resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/ --- (Updated May 22, 2016, 7:24 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 47671: Windows: Allowed `dynamic_cast` on an object being constructed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47671/#review134260 --- Patch looks great! Reviews applied: [47473, 47492, 47486, 47474,

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated May 22, 2016, 7:24 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/#review134261 --- Bad patch! Reviews applied: [45967, 45966, 45964, 45963, 45962,