Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

2016-07-19 Thread Abhishek Dasgupta
> On July 19, 2016, 12:49 a.m., Vinod Kone wrote: > > src/tests/mesos.hpp, lines 610-615 > > > > > > I think a generic `createFrameworkInfo()` that returns > > DEFAULT_FRAMEWORK_INFO with "role1" is unintuitive for

Re: Review Request 50181: [WIP] Fixed the flaky test case `MasterAPITest.GetTasks`.

2016-07-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50181/ --- (Updated July 19, 2016, 7:01 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50177: Add systemd watchdog support.

2016-07-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50177/#review142695 --- Bad patch! Reviews applied: [50177] Failed command:

Re: Review Request 50072: Set allocation interval in 'Master Flags' for operator API reservation tests.

2016-07-19 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50072/ --- (Updated July 19, 2016, 7:24 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50172: Made `ports` resource configurable in sorter benchmark test.

2016-07-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50172/#review142702 --- Patch looks great! Reviews applied: [50172] Passed command:

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

2016-07-19 Thread Abhishek Dasgupta
> On July 19, 2016, 12:57 a.m., Vinod Kone wrote: > > This change looks ok to me and indepdendent of the previous 2 reviews in > > the chain. If yes, I'm happy to commit this if you remove the dependency. > > You might be able to discard the first 2 reviews even. I discarded the first one,

Re: Review Request 50179: Added mesos-logrotate-logger utility executable.

2016-07-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50179/#review142709 --- Bad patch! Reviews applied: [50179] Failed command:

Re: Review Request 50072: Set allocation interval in 'Master Flags' for operator API reservation tests.

2016-07-19 Thread Abhishek Dasgupta
> On July 19, 2016, 12:51 a.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, lines 946-1041 > > > > > > Why this change? The context is not clear from the description or the > > ticket. My bad. MasterFlags

Re: Review Request 50072: Speed up reservation test by setting allocation interval in master flags.

2016-07-19 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50072/ --- (Updated July 19, 2016, 8:47 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50072: Speed up reservation test by setting allocation interval in master flags.

2016-07-19 Thread Abhishek Dasgupta
> On July 19, 2016, 12:51 a.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, lines 946-1041 > > > > > > Why this change? The context is not clear from the description or the > > ticket. > > Abhishek Dasgupta

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

2016-07-19 Thread Abhishek Dasgupta
> On July 19, 2016, 12:49 a.m., Vinod Kone wrote: > > src/tests/mesos.hpp, lines 610-615 > > > > > > I think a generic `createFrameworkInfo()` that returns > > DEFAULT_FRAMEWORK_INFO with "role1" is unintuitive for

Review Request 50181: [WIP] Fixed the flaky test case `MasterAPITest.GetTasks`.

2016-07-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50181/ --- Review request for mesos, Anand Mazumdar, Jay Guo, and Vinod Kone. Bugs:

Re: Review Request 50186: Avoid a GMock warning in a reservation test case.

2016-07-19 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50186/ --- (Updated July 19, 2016, 9:55 a.m.) Review request for mesos and Alexander

Re: Review Request 50186: Avoid a GMock warning in a reservation test case.

2016-07-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50186/#review142746 --- Patch looks great! Reviews applied: [50186] Passed command:

Review Request 50187: Removed the `os::sleep` from `Clock::settle`.

2016-07-19 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50187/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-3760

Re: Review Request 50181: [WIP] Fixed the flaky test case `MasterAPITest.GetTasks`.

2016-07-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50181/#review142716 --- Bad patch! Reviews applied: [50181] Failed command:

Re: Review Request 50184: Fixed length argument bug when reading file.

2016-07-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50184/#review142726 --- Patch looks great! Reviews applied: [50184] Passed command:

Re: Review Request 50187: Removed the `os::sleep` from `Clock::settle`.

2016-07-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50187/#review142755 --- Patch looks great! Reviews applied: [50187] Passed command:

Re: Review Request 50172: Made `ports` resource configurable in sorter benchmark test.

2016-07-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50172/ --- (Updated 七月 19, 2016, 3:59 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 49617: Add benchmark for failover of many frameworks.

2016-07-19 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49617/#review142075 --- src/tests/hierarchical_allocator_tests.cpp (line 3690)

Re: Review Request 49617: Add benchmark for failover of many frameworks.

2016-07-19 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49617/#review142764 --- src/tests/hierarchical_allocator_tests.cpp (line 3724)

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

2016-07-19 Thread Jiang Yan Xu
> On July 19, 2016, 10:03 a.m., Jiang Yan Xu wrote: > > It would be helpful to add a test just for contains. i.e., to test how > > `contains` works with nonshared resources and how it works with simple > > shared resources (could be constructed from createDiskResources with no > > arithmetic

Re: Review Request 50172: Made `ports` resource configurable in sorter benchmark test.

2016-07-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50172/#review142773 --- Patch looks great! Reviews applied: [50172] Passed command:

Re: Review Request 50187: Removed the `os::sleep` from `Clock::settle`.

2016-07-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50187/#review142778 --- Ship it! Thanks! - Benjamin Mahler On July 19, 2016, 10:08

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

2016-07-19 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/#review142652 --- It would be helpful to add a test just for contains. i.e., to

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

2016-07-19 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/#review142765 --- src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

2016-07-19 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/ --- (Updated July 19, 2016, 12:15 p.m.) Review request for Joseph Wu. Bugs:

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

2016-07-19 Thread Artem Harutyunyan
> On July 18, 2016, 2:28 p.m., Joseph Wu wrote: > > src/Makefile.am, line 1898 > > > > > > Can you also add this to `examples_tests.cpp`? Will do in a followup review. - Artem

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

2016-07-19 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- (Updated July 19, 2016, 6:30 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

2016-07-19 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/ --- (Updated July 19, 2016, 6:31 p.m.) Review request for mesos. Bugs:

Re: Review Request 50181: [WIP] Fixed the flaky test case `MasterAPITest.GetTasks`.

2016-07-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50181/#review142879 --- Ship it! Ship It! - Vinod Kone On July 19, 2016, 7:01 a.m.,

Re: Review Request 50213: Made build* fields optional in VersionInfo protobuf.

2016-07-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50213/#review142883 --- Ship it! Ship It! - Anand Mazumdar On July 20, 2016, 12:49

Re: Review Request 50212: Removed GET_STATE_SUMMARY from v1 operator API.

2016-07-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50212/#review142881 --- Ship it! Ship It! - Anand Mazumdar On July 20, 2016, 12:48

Re: Review Request 50208: Fixed a file descriptor leak bug while reading file.

2016-07-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50208/#review142895 --- Ship it! Ship It! - haosdent huang On July 20, 2016, 1:45

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

2016-07-19 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/#review142892 --- include/mesos/resources.hpp (line 84)

Re: Review Request 50017: Do not validate resource when add/subtract `Resources` object.

2016-07-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50017/ --- (Updated 七月 20, 2016, 3:22 a.m.) Review request for mesos, Benjamin Mahler and

Review Request 50213: Made build* fields optional in VersionInfo protobuf.

2016-07-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50213/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-5479 and MESOS-5480

Re: Review Request 50211: Renamed GET_LEADING_MASTER to GET_MASTER in v1 operator API.

2016-07-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50211/#review142880 --- Ship it! Ship It! - Anand Mazumdar On July 20, 2016, 12:47

Re: Review Request 50184: Fixed length argument bug when reading file.

2016-07-19 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50184/ --- (Updated July 20, 2016, 1:45 a.m.) Review request for mesos and Anand

Review Request 50208: Fixed a file descriptor leak bug while reading file.

2016-07-19 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50208/ --- Review request for mesos and Anand Mazumdar. Bugs: mesos-5867

Re: Review Request 50208: Fixed a file descriptor leak bug while reading file.

2016-07-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50208/#review142887 --- Ship it! Ship It! - Anand Mazumdar On July 20, 2016, 1:45

Re: Review Request 50184: Fixed length argument bug when reading file.

2016-07-19 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50184/#review142886 --- Ship it! Ship It! - Anand Mazumdar On July 20, 2016, 1:45

Re: Review Request 50199: Refactored fetcher cache directory creation.

2016-07-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50199/ --- (Updated July 19, 2016, 8:07 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49571: Added a benchmark test for allocations.

2016-07-19 Thread Anindya Sinha
> On July 19, 2016, 9:45 p.m., Jiang Yan Xu wrote: > > Commented on the resources benchmarks. Also let's pull it out then we can > > hopefully commit the arithmetic operations for shared resources patch first. > > > > On the separate review could you post the numbers from cout instead of the

Re: Review Request 50184: Fixed length argument bug when reading file.

2016-07-19 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50184/ --- (Updated July 20, 2016, 2:23 a.m.) Review request for mesos and Anand

Re: Review Request 50200: Made the agent fetch files as the task user.

2016-07-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50200/#review142894 --- Patch looks great! Reviews applied: [50199, 50200] Passed

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

2016-07-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142791 --- Fix it, then Ship it! src/local/flags.hpp (lines 33 - 34)

Re: Review Request 50002: Allow all flags load methods to specify a prefix.

2016-07-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50002/#review142901 --- Ship it! Ship It! - Greg Mann On July 15, 2016, 4:45 p.m.,

Review Request 50212: Removed GET_STATE_SUMMARY from v1 operator API.

2016-07-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50212/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-5490

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

2016-07-19 Thread Ammar Askar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/ --- (Updated July 20, 2016, 5:10 a.m.) Review request for mesos, Greg Mann and

Review Request 50211: Renamed GET_LEADING_MASTER to GET_MASTER in v1 operator API.

2016-07-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50211/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-5497

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

2016-07-19 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/ --- (Updated July 19, 2016, 6:23 p.m.) Review request for Joseph Wu. Bugs:

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

2016-07-19 Thread Srinivas Brahmaroutu
> On July 7, 2016, 6:38 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/appc/runtime.cpp, line 265 > > > > > > Seems you are losing the logic to handle logic in row 2 when there are > >

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

2016-07-19 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/ --- (Updated July 19, 2016, 9:12 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

2016-07-19 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated July 19, 2016, 9:36 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

2016-07-19 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/ --- (Updated July 19, 2016, 10:51 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

2016-07-19 Thread Anindya Sinha
> On July 19, 2016, 5:03 p.m., Jiang Yan Xu wrote: > > It would be helpful to add a test just for contains. i.e., to test how > > `contains` works with nonshared resources and how it works with simple > > shared resources (could be constructed from createDiskResources with no > > arithmetic

Review Request 50205: Enhanced benchmark test for resources to include shared resources.

2016-07-19 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50205/ --- Review request for mesos, Klaus Ma and Jiang Yan Xu. Bugs: MESOS-4892

Review Request 50199: Refactored fetcher cache directory creation.

2016-07-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50199/ --- Review request for mesos, Gilbert Song, Jie Yu, and Joerg Schad. Bugs:

Review Request 50200: Made the agent fetch files as the task user.

2016-07-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50200/ --- Review request for mesos, Gilbert Song, Jie Yu, and Joerg Schad. Bugs:

Re: Review Request 50200: Made the agent fetch files as the task user.

2016-07-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50200/ --- (Updated July 19, 2016, 8:07 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49617: Add benchmark for failover of many frameworks.

2016-07-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49617/#review142842 --- Patch looks great! Reviews applied: [49617] Passed command:

Re: Review Request 50200: Made the agent fetch files as the task user.

2016-07-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50200/ --- (Updated July 19, 2016, 8:53 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50199: Refactored fetcher cache directory creation.

2016-07-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50199/ --- (Updated July 19, 2016, 8:54 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49688: Added cmake build variables for mesos tests.

2016-07-19 Thread Srinivas Brahmaroutu
> On July 12, 2016, 4:16 a.m., Alex Clemmer wrote: > > cmake/MesosConfigure.cmake, lines 96-97 > > > > > > Hmm, this seems like it should break the build. We're defining these > > scripts in `MesosConfigure.cmake`

Re: Review Request 49688: Added cmake build variables for mesos tests.

2016-07-19 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated July 19, 2016, 9:35 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49870: Added test executables required to run tests.

2016-07-19 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49870/ --- (Updated July 19, 2016, 9:43 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

2016-07-19 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45960/ --- (Updated July 19, 2016, 10:58 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 50072: Speed up reservation test by setting allocation interval in master flags.

2016-07-19 Thread Vinod Kone
> On July 19, 2016, 10:46 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, lines 95-97 > > > > > > I'll clean up the coment while committing. > > Anand Mazumdar wrote: > Why do we want to change this for

Re: Review Request 50200: Made the agent fetch files as the task user.

2016-07-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50200/ --- (Updated July 19, 2016, 11:10 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 50199: Refactored fetcher cache directory creation.

2016-07-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50199/ --- (Updated July 19, 2016, 11:10 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 50199: Refactored fetcher cache directory creation.

2016-07-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50199/#review142829 --- src/launcher/fetcher.cpp (line 381)

Re: Review Request 49571: Added a benchmark test for allocations and shared resources.

2016-07-19 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review142771 --- Commented on the resources benchmarks. Also let's pull it out

Re: Review Request 49955: Disabled the `--registry_strict` master flag.

2016-07-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49955/#review142863 --- LGTM, module benm's comments. src/master/flags.cpp (line 86)

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

2016-07-19 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45960/ --- (Updated July 19, 2016, 10:57 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 50200: Made the agent fetch files as the task user.

2016-07-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50200/ --- (Updated July 19, 2016, 8:53 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50199: Refactored fetcher cache directory creation.

2016-07-19 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50199/#review142837 --- src/launcher/fetcher.cpp (line 433)

Re: Review Request 50072: Speed up reservation test by setting allocation interval in master flags.

2016-07-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50072/#review142859 --- Ship it! src/tests/api_tests.cpp (lines 95 - 97)

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

2016-07-19 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45960/ --- (Updated July 19, 2016, 10:52 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 48616: Add v1 changes for shared resources.

2016-07-19 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48616/ --- (Updated July 19, 2016, 10:52 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

2016-07-19 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated July 19, 2016, 10:52 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

2016-07-19 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated July 19, 2016, 10:53 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45964: Add unit tests for sharing of resources.

2016-07-19 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/ --- (Updated July 19, 2016, 10:53 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

2016-07-19 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated July 19, 2016, 10:53 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49571: Added a benchmark test for allocations.

2016-07-19 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated July 19, 2016, 10:53 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45966: Offer shared resources to frameworks only if opted in.

2016-07-19 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/ --- (Updated July 19, 2016, 10:53 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45967: Added documentation for shareable resources.

2016-07-19 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated July 19, 2016, 10:53 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 50199: Refactored fetcher cache directory creation.

2016-07-19 Thread Greg Mann
> On July 19, 2016, 8:51 p.m., Joerg Schad wrote: > > src/launcher/fetcher.cpp, line 381 > > > > > > Does it make sense to add a check here to document and check that > > precondition? Yep! :) > On July 19,

Re: Review Request 50200: Made the agent fetch files as the task user.

2016-07-19 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50200/#review142833 --- src/launcher/fetcher.cpp (lines 519 - 525)

Re: Review Request 49892: Removed unnecessary await from test.

2016-07-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49892/#review142857 --- Ship it! Ship It! - Vinod Kone On July 19, 2016, 7:48 p.m.,

Re: Review Request 50072: Speed up reservation test by setting allocation interval in master flags.

2016-07-19 Thread Anand Mazumdar
> On July 19, 2016, 10:46 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, lines 95-97 > > > > > > I'll clean up the coment while committing. Why do we want to change this for all the tests? As pointed out by

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

2016-07-19 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/ --- (Updated July 19, 2016, 9:11 p.m.) Review request for mesos. Bugs:

Re: Review Request 49892: Removed unnecessary await from test.

2016-07-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49892/ --- (Updated July 19, 2016, 7:48 p.m.) Review request for mesos and Vinod Kone.