Review Request 51421: Added provisioner appc unit test for recovering nested container.

2016-08-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51421/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and

Review Request 51420: Added provisioner appc unit test for provisioning nested container.

2016-08-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51420/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and

Re: Review Request 51417: Removed a NOTE in MesosContainerizer that no longer applies.

2016-08-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51417/#review146763 --- Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 10:21

Re: Review Request 51418: Updated a few comments in MesosContainerizer.

2016-08-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51418/#review146764 --- Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 10:21

Re: Review Request 49571: Added a benchmark test for allocations.

2016-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review146756 --- Patch looks great! Reviews applied: [51412, 45960, 45961, 45962,

Re: Review Request 51401: Removed 'status' in the destroy chain in MesosContainerizer.

2016-08-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51401/#review146758 --- Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 10:22

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

2016-08-25 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Aug. 25, 2016, 8:12 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51419: Add offeredResources to Allocator::updateAllocation() API.

2016-08-25 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51419/ --- (Updated Aug. 25, 2016, 8:11 a.m.) Review request for mesos. Repository:

Review Request 51419: Add offeredResources to Allocator::updateAllocation() API.

2016-08-25 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51419/ --- Review request for mesos. Repository: mesos Description --- This is

Re: Review Request 51409: Printed all the isolator cleanup errors during destory.

2016-08-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51409/#review146760 --- Fix it, then Ship it!

Re: Review Request 51400: Stopped passing messages in MesosContainerizer destroy methods.

2016-08-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51400/#review146757 --- Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 10:22

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

2016-08-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50705/ --- (Updated Aug. 25, 2016, 8:23 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51415: A few consistency fix on indentation.

2016-08-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51415/#review146762 --- Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 10:20

Re: Review Request 51414: Fixed the using statements in MesosContainerizer.

2016-08-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51414/#review146761 --- Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 10:20

Re: Review Request 51379: Entered the appropriate namespaces of the task during health check.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/ --- (Updated Aug. 25, 2016, 9:33 a.m.) Review request for mesos, Alexander

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

2016-08-25 Thread Yubo Li
> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.hpp, lines 20-25 > > > > > > What does adding all of these headers have to do with this patch? They > > may be needed, but I don't

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 25, 2016, 10:22 a.m.) Review request for mesos, Alexander

Re: Review Request 51418: Updated a few comments in MesosContainerizer.

2016-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51418/#review146767 --- Patch looks great! Reviews applied: [51388, 51389, 51390, 51391,

Re: Review Request 51411: Added provisioner tests to provision using meta discovery.

2016-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51411/#review146770 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 25, 2016, 10:26 a.m.) Review request for mesos, Alexander

Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

2016-08-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50702/ --- (Updated Aug. 25, 2016, 9:09 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

2016-08-25 Thread Neil Conway
> On Aug. 22, 2016, 7:43 p.m., Vinod Kone wrote: > > src/master/metrics.hpp, lines 183-184 > > > > > > can you add this to the CHANGELOG for 1.1 under "Deprecations" section? Done. Note that I haven't yet attempted

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

2016-08-25 Thread Yubo Li
> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.hpp, lines 20-25 > > > > > > What does adding all of these headers have to do with this patch? They > > may be needed, but I don't

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 25, 2016, 10:12 a.m.) Review request for mesos, Alexander

Review Request 51425: Added missed headers.

2016-08-25 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51425/ --- Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

2016-08-25 Thread Yubo Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 八月 25, 2016, 9:38 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 25, 2016, 10:19 a.m.) Review request for mesos, Alexander

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 25, 2016, 10:28 a.m.) Review request for mesos, Alexander

Re: Review Request 49360: Supported TCP in health check.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 25, 2016, 12:34 p.m.) Review request for mesos, Alexander

Re: Review Request 51378: Exposed `process::internal::defaultClone` to `process` namespace.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51378/ --- (Updated Aug. 25, 2016, 12:35 p.m.) Review request for mesos, Alexander

Re: Review Request 49556: Removed the binary way of HealthCheck in src.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49556/ --- (Updated Aug. 25, 2016, 12:34 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 25, 2016, 12:34 p.m.) Review request for mesos, Alexander

Re: Review Request 51085: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51085/ --- (Updated Aug. 25, 2016, 12:35 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 25, 2016, 1:24 p.m.) Review request for mesos, Alexander

Re: Review Request 51069: Refactored `_commandHealthCheck` in health check.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51069/ --- (Updated Aug. 25, 2016, 1:24 p.m.) Review request for mesos, Alexander

Re: Review Request 49556: Removed the binary way of HealthCheck in src.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49556/ --- (Updated Aug. 25, 2016, 1:24 p.m.) Review request for mesos, Alexander

Re: Review Request 49555: Updated mesos-docker-executor to use health check via library way.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49555/ --- (Updated Aug. 25, 2016, 1:24 p.m.) Review request for mesos, Alexander

Re: Review Request 50657: Removed the binary way of health check in libprocess.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50657/ --- (Updated Aug. 25, 2016, 1:24 p.m.) Review request for mesos, Alexander

Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

2016-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51421/#review146774 --- Patch looks great! Reviews applied: [51323, 51343, 51358, 51359,

Re: Review Request 51379: Entered the appropriate namespaces of the task during health check.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/ --- (Updated Aug. 25, 2016, 12:35 p.m.) Review request for mesos, Alexander

Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51086/ --- (Updated Aug. 25, 2016, 12:35 p.m.) Review request for mesos, Alexander

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 25, 2016, 1:24 p.m.) Review request for mesos, Alexander

Re: Review Request 49360: Supported TCP in health check.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 25, 2016, 1:25 p.m.) Review request for mesos, Alexander

Re: Review Request 51378: Exposed `process::internal::defaultClone` to `process` namespace.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51378/ --- (Updated Aug. 25, 2016, 1:25 p.m.) Review request for mesos, Alexander

Re: Review Request 51085: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51085/ --- (Updated Aug. 25, 2016, 1:26 p.m.) Review request for mesos, Alexander

Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51086/ --- (Updated Aug. 25, 2016, 1:26 p.m.) Review request for mesos, Alexander

Re: Review Request 50657: Removed the binary way of health check in libprocess.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50657/ --- (Updated Aug. 25, 2016, 12:33 p.m.) Review request for mesos, Alexander

Re: Review Request 49555: Updated mesos-docker-executor to use health check via library way.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49555/ --- (Updated Aug. 25, 2016, 12:33 p.m.) Review request for mesos, Alexander

Re: Review Request 51069: Refactored `_commandHealthCheck` in health check.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51069/ --- (Updated Aug. 25, 2016, 12:34 p.m.) Review request for mesos, Alexander

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 25, 2016, 12:33 p.m.) Review request for mesos, Alexander

Re: Review Request 49360: Supported TCP in health check.

2016-08-25 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/#review146777 --- src/health-check/health_checker.cpp (line 452)

Re: Review Request 51379: Entered the appropriate namespaces of the task during health check.

2016-08-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/#review146776 --- src/health-check/health_checker.hpp (line 52)

Re: Review Request 51379: Entered the appropriate namespaces of the task during health check.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/ --- (Updated Aug. 25, 2016, 1:26 p.m.) Review request for mesos, Alexander

Review Request 51021: Added GC of unreachable agent metadata from the registry.

2016-08-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51021/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5965

Re: Review Request 51257: Add external process container logger.

2016-08-25 Thread Will Rouesnel
> On Aug. 22, 2016, 6:03 p.m., Joseph Wu wrote: > > src/CMakeLists.txt, line 171 > > > > > > Can you un-remove all these un-related `cpuacct` changes? Weird, my local branch history doesn't show these in it. I

Re: Review Request 50707: Added test for agent removal behavior.

2016-08-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50707/ --- (Updated Aug. 25, 2016, 2:30 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

2016-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51086/#review146781 --- Patch looks great! Reviews applied: [51266, 49555, 50657, 49556,

Re: Review Request 51374: Modified registry update protocol on removal / reregistration.

2016-08-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51374/ --- (Updated Aug. 25, 2016, 2:12 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51379: Entered the appropriate namespaces of the task during health check.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/ --- (Updated Aug. 25, 2016, 2:16 p.m.) Review request for mesos, Alexander

Re: Review Request 51096: Added the `mesos-port-mapper` binary.

2016-08-25 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51096/#review146780 ---

Re: Review Request 49360: Supported TCP in health check.

2016-08-25 Thread haosdent huang
> On Aug. 25, 2016, 12:49 p.m., Tomasz Janiszewski wrote: > > src/health-check/health_checker.cpp, line 452 > > > > > > Will it work on all supported systems? Windows also have bash now but require external

Review Request 51434: Use `continue` when breaking out of LAUNCH_GROUP case due to errors.

2016-08-25 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51434/ --- Review request for mesos, Benjamin Mahler and Vinod Kone. Repository: mesos

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-08-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review146821 --- qian, sorry for the delay on getting back on this one. are you

Review Request 51431: Added health check support to mesos-execute.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51431/ --- Review request for mesos. Repository: mesos Description --- Only used

Re: Review Request 51009: Collect throttle related cpu.stat for Docker Containerizer.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51009/#review146801 --- Ship it! Ship It! - haosdent huang On Aug. 22, 2016, 7:15

Re: Review Request 51391: Fixed a bug related to logger in MesosContainerizer.

2016-08-25 Thread Joseph Wu
> On Aug. 24, 2016, 4:49 p.m., Joseph Wu wrote: > > Looks like the same code in the docker containerizer is missing the same > > check. > > Jie Yu wrote: > Can you create a ticket to track? :) https://issues.apache.org/jira/browse/MESOS-6092 - Joseph

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

2016-08-25 Thread Kevin Klues
> On Aug. 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 1555 > > > > > > I wouldn't just blindly call this function here. It should be wrapped > > in some logic that makes

Re: Review Request 51432: Added test case for TaskGroupValidationTest.ExecutorWithoutFrameworkId.

2016-08-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51432/#review146815 --- Fix it, then Ship it! src/tests/master_validation_tests.cpp

Re: Review Request 50125: Added mesos-docker-executor support for devices control.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review146823 --- src/docker/executor.hpp (lines 80 - 83)

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review146814 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51406/#review146819 --- src/slave/containerizer/mesos/launcher.cpp (lines 91 - 114)

Re: Review Request 50599: Passed allocated GPUs to 'devices' entry of 'docker::Flags'.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review146824 --- src/slave/containerizer/docker.cpp (lines 230 - 249)

Re: Review Request 51416: Fixed a TODO in the MesosContainerizer.

2016-08-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51416/#review146826 --- src/slave/containerizer/mesos/containerizer.cpp (lines 1641 -

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-08-25 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/ --- (Updated Aug. 25, 2016, 4:13 p.m.) Review request for mesos, Xiaojian Huang,

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-08-25 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review146749 --- src/slave/containerizer/mesos/provisioner/backends/overlay.cpp

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-08-25 Thread Vinod Kone
> On April 14, 2016, 4:49 p.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, line 749 > > > > > > Looking at slave::statusUpdate() code there are several scenarios where > > the slave ignores a

Review Request 51433: Added test case MasterAuthorizationTest, UnauthorizedTaskGroup.

2016-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51433/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6087

Re: Review Request 50524: Updated docker recovery to use abstraction provided by docker inspect.

2016-08-25 Thread Rajat Phull
> On Aug. 21, 2016, 3:15 p.m., Guangya Liu wrote: > > Why not merge this with https://reviews.apache.org/r/50523 ? Agreed, this is now merged with https://reviews.apache.org/r/50523. Can be dropped from review. - Rajat --- This is an

Review Request 51432: Added test case for TaskGroupValidationTest.ExecutorWithoutFrameworkId.

2016-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51432/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6087

Re: Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

2016-08-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51406/#review146791 --- Can you split the Launcher::wait support to a separate patch?

Re: Review Request 50599: Passed allocated GPUs to 'devices' entry of 'docker::Flags'.

2016-08-25 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review146816 --- src/slave/containerizer/docker.hpp (line 509)

Re: Review Request 51409: Printed all the isolator cleanup errors during destory.

2016-08-25 Thread Jie Yu
> On Aug. 25, 2016, 8:22 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1768-1769 > > > > > > We should still keep the `ContainerID`, right? Nope, caller will (and should)

Re: Review Request 45964: Add unit tests for sharing of resources.

2016-08-25 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/#review146219 --- src/tests/hierarchical_allocator_tests.cpp (lines 1269 - 1270)

Re: Review Request 50271: Created an isolator for Linux capabilities.

2016-08-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Aug. 25, 2016, 5:18 p.m.) Review request for mesos and Jie Yu.

Review Request 51429: Added proper constructor for internal SyscallPayload class and used it.

2016-08-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51429/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 51043: Added support for reading out the bounding capability set.

2016-08-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51043/ --- (Updated Aug. 25, 2016, 5:18 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 51042: Added function to apply capabilities to process exec'd next.

2016-08-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51042/ --- (Updated Aug. 25, 2016, 5:18 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50270: Introduced linux capabilities support for mesos containerizer.

2016-08-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50270/ --- (Updated Aug. 25, 2016, 5:18 p.m.) Review request for mesos and Jie Yu.

Review Request 51428: Removed friendship between ProcessCapabilities and Capabilities.

2016-08-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51428/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 51043: Added support for reading out the bounding capability set.

2016-08-25 Thread Benjamin Bannier
> On Aug. 17, 2016, 8:20 p.m., Jie Yu wrote: > > src/linux/capabilities.cpp, lines 229-231 > > > > > > Hum, this is not very performant. If lastCap == 37, a single get() here > > will issue 37 system calls. Can you

Re: Review Request 51042: Added function to apply capabilities to process exec'd next.

2016-08-25 Thread Benjamin Bannier
> On Aug. 19, 2016, 1:36 a.m., Jie Yu wrote: > > src/linux/capabilities.cpp, lines 297-313 > > > > > > Should this just be a `set`? > > > > Also, we should just assume we have SETPCAP as agent is typically

Re: Review Request 50269: Added basic tests for capabilities API.

2016-08-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50269/ --- (Updated Aug. 25, 2016, 5:20 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50960: Added appc uri fetcher tests.

2016-08-25 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50960/ --- (Updated Aug. 25, 2016, 3:22 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.

2016-08-25 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50959/ --- (Updated Aug. 25, 2016, 3:22 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 50958: Added tests to invoke the fetcher plugins by name.

2016-08-25 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50958/ --- (Updated Aug. 25, 2016, 3:22 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 51096: Added the `mesos-port-mapper` binary.

2016-08-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51096/ --- (Updated Aug. 25, 2016, 3:21 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51410: Enabled meta discovery using appc labels.

2016-08-25 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51410/ --- (Updated Aug. 25, 2016, 3:21 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 50956: Added name to uri fetcher plugins.

2016-08-25 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50956/ --- (Updated Aug. 25, 2016, 3:22 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 50957: Added fetch method based on plugin name.

2016-08-25 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50957/ --- (Updated Aug. 25, 2016, 3:22 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-08-25 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/ --- (Updated Aug. 25, 2016, 4:22 p.m.) Review request for mesos, Xiaojian Huang,

  1   2   >