Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/#review147067 --- Patch looks great! Reviews applied: [51095, 51096, 51097]

Re: Review Request 51472: Added test case TaskGroupValidationTest.TaskUsesExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51472/#review147060 --- Ship it! Ship It! - Vinod Kone On Aug. 27, 2016, 1:02 a.m.,

Re: Review Request 51462: Excluded providing the default `PATH` on `Windows`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51462/#review147059 --- Ship it! - Joseph Wu On Aug. 26, 2016, 10:39 a.m., Daniel

Re: Review Request 51233: Added a clean `Windows` environment for `mesos-executor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51233/#review147054 --- Ship it! I can tweak the following before committing.

Re: Review Request 51234: Add `userenv` import library to `Windows` build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51234/#review147061 --- Ship it! AFAICS, there's no adverse effect from moving this

Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51470/#review147062 --- Ship it! Ship It! - Anindya Sinha On Aug. 26, 2016, 10:53

Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51470/#review147058 --- Patch looks great! Reviews applied: [51470] Passed command:

Review Request 51472: Added test case TaskGroupValidationTest.TaskUsesExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51472/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6087

Re: Review Request 49360: Supported TCP in health check.

> On Aug. 25, 2016, 12:49 p.m., Tomasz Janiszewski wrote: > > src/health-check/health_checker.cpp, line 452 > > > > > > Will it work on all supported systems? > > haosdent huang wrote: > Windows also have bash

Re: Review Request 49360: Added support for TCP health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 26, 2016, 12:54 p.m.) Review request for mesos, Alexander

Re: Review Request 51446: Fixed typo in health_checker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51446/#review146952 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 26, 2016,

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

> On Aug. 26, 2016, 1:59 a.m., Vinod Kone wrote: > > qian, sorry for the delay on getting back on this one. are you still > > interested in seeing this through? if yes, can you please rebase? Sure Vinod, I will do the rebase later. - Qian

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/#review146956 ---

Re: Review Request 50657: Removed the health check binary in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50657/ --- (Updated Aug. 26, 2016, 2:11 p.m.) Review request for mesos, Alexander

Re: Review Request 51069: Refactored `_commandHealthCheck` in health check.

> On Aug. 26, 2016, 11:24 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.cpp, line 306 > > > > > > s/sss/ss : ) > > How about: > > "Killing the command health check process " Probably

Re: Review Request 36816: Added support for HTTP/HTTPS health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 26, 2016, 2:13 p.m.) Review request for mesos, Alexander

Re: Review Request 51095: Adding protobuf to represent errors returned by CNI plugins.

> On Aug. 26, 2016, 7:24 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.cpp, line 34 > > > > > > Why do we need to make this change? And it seems this change is not > > related

Re: Review Request 51069: Refactored `_commandHealthCheck` in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51069/ --- (Updated Aug. 26, 2016, 12:52 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Added support for HTTP/HTTPS health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 26, 2016, 12:52 p.m.) Review request for mesos, Alexander

Re: Review Request 51379: Entered the appropriate task's namespaces during health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/ --- (Updated Aug. 26, 2016, 1:17 p.m.) Review request for mesos, Alexander

Re: Review Request 51097: Added a `PortMapper` class.

> On Aug. 26, 2016, 9:23 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp, > > line 97 > > > > > > I think in our context, we will always set this

Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51086/ --- (Updated Aug. 26, 2016, 2:17 p.m.) Review request for mesos, Alexander

Re: Review Request 51379: Entered the appropriate task's namespaces during health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/ --- (Updated Aug. 26, 2016, 2:16 p.m.) Review request for mesos, Alexander

Re: Review Request 51085: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51085/ --- (Updated Aug. 26, 2016, 2:16 p.m.) Review request for mesos, Alexander

Re: Review Request 49555: Updated the docker executor to use health checks via the library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49555/ --- (Updated Aug. 26, 2016, 11 a.m.) Review request for mesos, Alexander

Re: Review Request 51450: Fixed a capabilities test failure on Fedora 23.

> On Aug. 26, 2016, 2:15 p.m., Benjamin Bannier wrote: > > src/tests/containerizer/capabilities_tests.cpp, lines 139-145 > > > > > > I had some difficulty undestanding the issue with this `NOTE`. > > > >

Re: Review Request 51450: Fixed a capabilities test failure on Fedora 23.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51450/#review146942 --- Fix it, then Ship it!

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

> On Aug. 26, 2016, 12:33 p.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.cpp, line 378 > > > > > > "Killing the HTTP health check process " Also fits one line afterwards. - Alexander

Re: Review Request 49360: Supported TCP in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/#review146946 --- Fix it, then Ship it! src/health-check/health_checker.cpp

Re: Review Request 51379: Entered the appropriate task's namespaces during health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/#review146949 --- Fix it, then Ship it! src/docker/executor.cpp (lines 474 -

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 26, 2016, 2:10 p.m.) Review request for mesos, Alexander

Re: Review Request 51378: Exposed `process::internal::defaultClone` to `process` namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51378/#review146948 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 25, 2016,

Re: Review Request 51097: Added a `PortMapper` class.

> On Aug. 26, 2016, 9:23 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.hpp, > > lines 39-41 > > > > > > I am not sure why we need two classes here, I

Re: Review Request 51069: Refactored `_commandHealthCheck` in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51069/ --- (Updated Aug. 26, 2016, 2:12 p.m.) Review request for mesos, Alexander

Re: Review Request 51379: Entered the appropriate task's namespaces during health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/ --- (Updated Aug. 26, 2016, 2:15 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review146941 --- Fix it, then Ship it! src/health-check/health_checker.cpp

Re: Review Request 49556: Removed the health check binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49556/ --- (Updated Aug. 26, 2016, 2:12 p.m.) Review request for mesos, Alexander

Re: Review Request 51097: Added a `PortMapper` class.

> On Aug. 26, 2016, 9:23 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp, > > line 44 > > > > > > A newline before this line, and a space after

Re: Review Request 49360: Added support for TCP health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 26, 2016, 2:14 p.m.) Review request for mesos, Alexander

Re: Review Request 51378: Exposed `process::internal::defaultClone` to `process` namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51378/ --- (Updated Aug. 26, 2016, 2:15 p.m.) Review request for mesos, Alexander

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.hpp, lines 505-507 > > > > > > I would just call this variable `gpus` > > Also the comment should read: > > ``` > > //

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 八月 26, 2016, 11:02 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51425: Added missed headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51425/#review146930 --- Fix it, then Ship it! Ship It!

Review Request 51455: Fixed typo for the comments of UnauthorizedTaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51455/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/#review146933 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 25, 2016,

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 26, 2016, 10:56 a.m.) Review request for mesos, Alexander

Re: Review Request 51069: Refactored `_commandHealthCheck` in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51069/#review146938 --- Fix it, then Ship it! src/health-check/health_checker.cpp

Re: Review Request 50657: Removed the health check binary in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50657/ --- (Updated Aug. 26, 2016, 11:04 a.m.) Review request for mesos, Alexander

Re: Review Request 50657: Removed the health check binary in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50657/#review146936 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 26, 2016,

Re: Review Request 49556: Removed the health check binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49556/#review146937 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 26, 2016,

Re: Review Request 50868: Using `OfferedResources` for benchmark test of `SuppressOffers`.

> On 八月 25, 2016, 10:56 p.m., Jiang Yan Xu wrote: > > I don't know. Making such distinction feels like splitting hairs to me. > > Yeah there are subtle differences between the two concepts but to me: > > > > - `offerCallback` may not be the best name what we could have come up with > > even

Re: Review Request 51451: Added test case MasterAuthorizationTest.KillPendingTaskInTaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51451/ --- (Updated 八月 26, 2016, 8:08 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/#review146782 ---

Re: Review Request 51455: Fixed typo for the comments of UnauthorizedTaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51455/#review146935 --- Patch looks great! Reviews applied: [51447, 51451, 51455]

Re: Review Request 49556: Removed the health check binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49556/ --- (Updated Aug. 26, 2016, 11:04 a.m.) Review request for mesos, Alexander

Re: Review Request 51451: Added test case MasterAuthorizationTest.KillPendingTaskInTaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51451/#review146931 --- Patch looks great! Reviews applied: [51447, 51451] Passed

Re: Review Request 51095: Adding protobuf to represent errors returned by CNI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51095/#review147001 --- Ship it! Ship It! - Jie Yu On Aug. 26, 2016, 12:26 a.m.,

Re: Review Request 51437: Added validation test for task group task using NetworkInfos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51437/ --- (Updated Aug. 26, 2016, 7:07 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 51437: Added validation test for task group task using NetworkInfos.

> On Aug. 25, 2016, 11:32 p.m., Guangya Liu wrote: > > src/master/validation.cpp, line 1003 > > > > > > How about > > > > ``` > > return Error("'NetworkInfos' must not be set on the task"); > > ```

Re: Review Request 51455: Fixed typo for the comments of UnauthorizedTaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51455/#review147008 --- Ship it! Ship It! - Vinod Kone On Aug. 26, 2016, 9:01 a.m.,

Re: Review Request 51096: Added the `mesos-port-mapper` binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51096/#review147004 --- src/Makefile.am (line 1345)

Re: Review Request 51451: Added test case MasterAuthorizationTest.KillPendingTaskInTaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51451/#review147006 --- Fix it, then Ship it! i'll fix it before committing.

Re: Review Request 51437: Added validation test for task group task using NetworkInfos.

> On Aug. 25, 2016, 11:42 p.m., Guangya Liu wrote: > > src/tests/master_validation_tests.cpp, line 1811 > > > > > > Here also needs an update if you quota `NetworkInfos`. see above. - Vinod

Re: Review Request 50657: Removed the health check binary in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50657/ --- (Updated Aug. 26, 2016, 2:46 p.m.) Review request for mesos, Alexander

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/#review146986 --- Patch looks great! Reviews applied: [51095, 51096, 51097]

Review Request 51462: Excluded providing the default `PATH` on `Windows`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51462/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Re: Review Request 51233: Added a clean `Windows` environment for `mesos-executor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51233/ --- (Updated Aug. 26, 2016, 5:38 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 51233: Build a clean `Windows` environment for `mesos-executor`.

> On Aug. 24, 2016, 9:28 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/include/process/windows/subprocess.hpp, line 68 > > > > > > I checked this: > > > >

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/ --- (Updated Aug. 26, 2016, 2:42 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 26, 2016, 2:43 p.m.) Review request for mesos, Alexander

Re: Review Request 49555: Updated the docker executor to use health checks via the library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49555/ --- (Updated Aug. 26, 2016, 2:11 p.m.) Review request for mesos, Alexander

Re: Review Request 51097: Added a `PortMapper` class.

> On Aug. 26, 2016, 9:23 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp, > > lines 191-192 > > > > > > I think we also need to make sure the

Re: Review Request 51379: Entered the appropriate task's namespaces during health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/ --- (Updated Aug. 26, 2016, 3:08 p.m.) Review request for mesos, Alexander

Re: Review Request 51378: Exposed `process::internal::defaultClone` to `process` namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51378/ --- (Updated Aug. 26, 2016, 3:08 p.m.) Review request for mesos, Alexander

Re: Review Request 51405: Updated some tests to use the CreateSlaveFlags() helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51405/#review146966 --- Fix it, then Ship it!

Re: Review Request 51085: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51085/ --- (Updated Aug. 26, 2016, 3:09 p.m.) Review request for mesos, Alexander

Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51086/ --- (Updated Aug. 26, 2016, 3:09 p.m.) Review request for mesos, Alexander

Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51086/#review146972 --- Patch looks great! Reviews applied: [51266, 49555, 50657, 49556,

Re: Review Request 51096: Added the `mesos-cni-port-mapper` binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51096/ --- (Updated Aug. 26, 2016, 7:49 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51407: Updated mesos containerizer to checkpoint the container exit status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51407/#review147023 --- Fix it, then Ship it!

Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50702/#review147027 --- Fix it, then Ship it! CHANGELOG (line 1)

Re: Review Request 51443: Updated 'launcher' to properly reap checkpointed exit status on linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51443/#review147021 --- Fix it, then Ship it!

Re: Review Request 50701: Added registrar operations for marking agents (un-)reachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50701/#review147026 --- Ship it! Ship It! - Vinod Kone On Aug. 24, 2016, 3:34 p.m.,

Re: Review Request 51443: Updated 'launcher' to properly reap checkpointed exit status on linux.

> On Aug. 26, 2016, 9:04 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/linux_launcher.cpp, lines 497-508 > > > > > > What if it is partially written? Should we return None() in that case > > as well (maybe

Re: Review Request 51443: Updated 'launcher' to properly reap checkpointed exit status on linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51443/ --- (Updated Aug. 26, 2016, 9:39 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 51443: Updated 'launcher' to properly reap checkpointed exit status on linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51443/ --- (Updated Aug. 26, 2016, 9:42 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

> On Aug. 26, 2016, 9:34 p.m., Vinod Kone wrote: > > i'll fix these while committing. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50702/#review147027

Re: Review Request 51096: Added the `mesos-cni-port-mapper` binary.

> On Aug. 26, 2016, 7:10 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp, > > lines 43-46 > > > > > > Any reason you want to initialize the error here,

Re: Review Request 51462: Excluded providing the default `PATH` on `Windows`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51462/#review147011 --- Patch looks great! Reviews applied: [51210, 51217, 51213, 51233,

Re: Review Request 51096: Added the `mesos-port-mapper` binary.

> On Aug. 26, 2016, 7:10 p.m., Jie Yu wrote: > > src/Makefile.am, line 1345 > > > > > > mesos-cni-port-mapper? > > > > Port mapper sounds too general to me. Agreed. I was also a bit doubtful about using

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/ --- (Updated Aug. 26, 2016, 8:24 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/#review147019 ---

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/#review147034 --- Patch looks great! Reviews applied: [51095, 51096, 51097]

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/ --- (Updated Aug. 26, 2016, 10:51 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51014: Removed one blank space in allocator benchmark test 'DeclineOffers'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51014/#review147041 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 26, 2016, 12:54

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/ --- (Updated Aug. 26, 2016, 11:01 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51096: Added the `mesos-cni-port-mapper` binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51096/ --- (Updated Aug. 26, 2016, 11:04 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51407: Updated mesos containerizer to checkpoint the container exit status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51407/ --- (Updated Aug. 26, 2016, 9:59 p.m.) Review request for mesos and Jie Yu.

Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51470/ --- Review request for mesos, Alexander Rukletsov, Anindya Sinha, Michael Park, and

Re: Review Request 51450: Fixed a capabilities test failure on Fedora 23.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51450/ --- (Updated Aug. 26, 2016, 6 a.m.) Review request for mesos and Benjamin Bannier.

  1   2   >