Review Request 65549: Improved some default executor log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65549/ --- Review request for mesos, Greg Mann, Qian Zhang, and Vinod Kone. Bugs:

Re: Review Request 65085: WIP: Added a unit test for fd leakage with blocking HTTP calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65085/#review197014 --- PASS: Mesos patch 65085 was successfully built and tested.

Re: Review Request 65062: Cleaned up endpoint directories after RP config agent API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65062/ --- (Updated Feb. 7, 2018, 6:18 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 65538: Added provider assignments into `disk_profile.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65538/#review197009 --- Fix it, then Ship it! Can you update the summary and

Re: Review Request 62800: Created cgroups under systemd hierarchy in LinuxLauncher.

> On Oct. 7, 2017, 12:23 a.m., James Peach wrote: > > src/slave/containerizer/mesos/linux_launcher.cpp > > Lines 402 (patched) > > > > > > Would we really exit? I'm not sure we should expect users to be able to > >

Re: Review Request 62799: Fixed an issue for the I/O switchboard process lifetime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62799/ --- (Updated Feb. 7, 2018, 8:01 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 62798: Added named cgroup hierarchy support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62798/ --- (Updated Feb. 7, 2018, 8:01 p.m.) Review request for mesos, James Peach, Joris

Review Request 65548: Added `Event::Update` and `v1::scheduler::TaskStatus` ostream operators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65548/ --- Review request for mesos, Alexander Rukletsov, Greg Mann, Qian Zhang, and Vinod

Re: Review Request 62800: Created cgroups under systemd hierarchy in LinuxLauncher.

> On Oct. 7, 2017, 12:23 a.m., James Peach wrote: > > src/slave/containerizer/mesos/linux_launcher.cpp > > Lines 189 (patched) > > > > > > This is racy, but we can fix it by ensuring that `os::mkdir` checks for > >

Re: Review Request 65538: Added provider assignments into `disk_profile.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65538/#review197016 --- FAIL: Failed to apply the dependent review: 65520. Failed

Re: Review Request 65402: Windows: Used Unicode API to duplicate sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65402/ --- (Updated Feb. 7, 2018, 11:22 a.m.) Review request for mesos, Akash Gupta, Jie

Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/ --- Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/#review197021 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65521: Improved isolation for agent RP API config tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65521/ --- (Updated Feb. 7, 2018, 6:16 p.m.) Review request for mesos, Greg Mann and Jie

Re: Review Request 65062: Cleaned up endpoint directories after RP config agent API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65062/ --- (Updated Feb. 7, 2018, 6:37 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 65538: Added provider assignments into `disk_profile.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65538/ --- (Updated Feb. 7, 2018, 6:51 p.m.) Review request for mesos, James DeFelice,

Re: Review Request 65467: Windows: Added `internal::windows::enable_inherit(WindowsFD)`.

> On Feb. 6, 2018, 1:55 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/internal/windows/inherit.hpp > > Lines 31-43 (patched) > > > > > > This is basically what the ChildHook `UNSET_CLOEXEC` > >

Re: Review Request 65060: Cleaned up endpoint directories after SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65060/ --- (Updated Feb. 7, 2018, 6:15 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 65060: Cleaned up endpoint directories after SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65060/ --- (Updated Feb. 7, 2018, 6:37 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65522/ --- (Updated Feb. 7, 2018, 6:45 p.m.) Review request for mesos, Gaston Kleiman and

Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65550/ --- Review request for mesos, Anand Mazumdar, Qian Zhang, and Vinod Kone. Bugs:

Re: Review Request 65399: Windows: Moved "kill on close" job object flag to own function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65399/ --- (Updated Feb. 7, 2018, 11:20 a.m.) Review request for mesos, Akash Gupta, Jie

Review Request 65552: Added a regression test for MESOS-8468.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65552/ --- Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.

Re: Review Request 65538: WIP: Added profile selectors in `disk_profile.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65538/#review197063 --- Ship it! Ship It! - James DeFelice On Feb. 7, 2018, 9:07

Re: Review Request 65541: WIP: Experimented with the MessageDifferencer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65541/ --- (Updated Feb. 7, 2018, 5:36 p.m.) Review request for mesos and Benjamin

Review Request 65561: WIP: Added more type util tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65561/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-2487

Re: Review Request 65496: Fixed a bug relating to lingering executors [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65496/#review197067 --- Ship it! This description doesn't seem to capture the cause of

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/#review197070 --- Looks good, just a few minor comments. src/tests/mock_slave.cpp

Re: Review Request 65316: Added test for delayed authorization during operator events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65316/ --- (Updated Feb. 8, 2018, 2:26 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 65561: WIP: Added more type util tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65561/#review197071 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65400: Windows: Tied task lifetimes to executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65400/#review197028 --- Ship it! Ship It! - Akash Gupta On Jan. 29, 2018, 8:34

Re: Review Request 65399: Windows: Moved "kill on close" job object flag to own function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65399/#review197027 --- Ship it! Ship It! - Akash Gupta On Feb. 7, 2018, 7:20 p.m.,

Re: Review Request 62800: Created cgroups under systemd hierarchy in LinuxLauncher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62800/#review197035 --- PASS: Mesos patch 62800 was successfully built and tested.

Re: Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65408/#review197043 --- Ship it! Ship It! - Akash Gupta On Feb. 2, 2018, 12:14

Re: Review Request 65060: Cleaned up endpoint directories after SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65060/#review197062 --- Ship it! Ship It! - Jie Yu On Feb. 7, 2018, 6:37 p.m.,

Re: Review Request 65062: Cleaned up endpoint directories after RP config agent API tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65062/#review197061 --- Ship it! Ship It! - Jie Yu On Feb. 7, 2018, 6:37 p.m.,

Review Request 65559: Updated disk profile tests for profile selector support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65559/ --- Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu. Bugs:

Re: Review Request 65109: Fixed a bug relating to lingering executors [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65109/#review197066 --- Ship it! src/slave/slave.cpp Lines 3361-3362 (patched)

Re: Review Request 65523: Fixed the flakiness in the SLRP metrics test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65523/ --- (Updated Feb. 8, 2018, 12:01 a.m.) Review request for mesos, Greg Mann and Jie

Re: Review Request 65499: Fixed the flakiness of the ROOT_ConvertPreExistingVolume test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65499/ --- (Updated Feb. 8, 2018, midnight) Review request for mesos, Benjamin Bannier,

Re: Review Request 65520: Reverted plugin name randomization in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65520/ --- (Updated Feb. 8, 2018, 12:01 a.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 65061: Speeded up tests for resource provider config agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65061/ --- (Updated Feb. 8, 2018, 12:02 a.m.) Review request for mesos, Greg Mann and Jie

Re: Review Request 65110: Added two additional mock methods in mock slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65110/#review197068 --- Ship it! Ship It! - Benjamin Mahler On Jan. 12, 2018, 2:34

Re: Review Request 65369: Added test to ensure v1 executor is shutdown upon initial task all-kill.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65369/#review197069 --- Ship it! Ship It! - Benjamin Mahler On Feb. 1, 2018, 9:24

Review Request 65558: Added helpers for supporting profile selectors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65558/ --- Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu. Bugs:

Re: Review Request 65559: Updated disk profile tests for profile selector support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65559/#review197065 --- PASS: Mesos patch 65559 was successfully built and tested.

Re: Review Request 65403: Windows: Disabled `O_CLOEXEC` semantic mapping on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65403/#review197032 --- Ship it! Ship It! - Akash Gupta On Feb. 1, 2018, 11:23

Re: Review Request 65363: Improved the validation of `ACKNOWLEDGE_OPERATION_STATUS` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65363/#review197053 --- Fix it, then Ship it! src/master/validation.cpp Lines 614

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65522/#review197049 --- FAIL: Failed to apply the dependent review: 65520. Failed

Re: Review Request 65402: Windows: Used Unicode API to duplicate sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65402/#review197030 --- Ship it! 3rdparty/stout/include/stout/os/windows/dup.hpp Line

Re: Review Request 65405: Implemented `net::socket()` for Windows using `WSASocket`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65405/#review197033 --- Ship it! Ship It! - Akash Gupta On Feb. 1, 2018, 11:30

Re: Review Request 65552: Added a regression test for MESOS-8468.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65552/#review197034 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 65554: Updated disk profile tests due to changes in the module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65554/ --- Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu. Bugs:

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65039/ --- (Updated Feb. 7, 2018, 11:04 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65406: Added `TYPED_TEST_TEMP_DISABLED_ON_WINDOWS` macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65406/#review197036 --- Ship it! Ship It! - Akash Gupta On Jan. 29, 2018, 8:39

Re: Review Request 65407: Windows: Enabled tests that were blocked by MESOS-7604.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65407/#review197040 --- Ship it! Ship It! - Akash Gupta On Feb. 2, 2018, 12:03

Review Request 65553: Passed `ResourceProviderInfo` to disk profile adaptor modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65553/ --- Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu. Bugs:

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65522/ --- (Updated Feb. 7, 2018, 9:49 p.m.) Review request for mesos, Gaston Kleiman and

Review Request 65556: Made the default executor treat agent disconnections more gracefully.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65556/ --- Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.

Re: Review Request 65362: Added a method to increment invalid scheduler API call counters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65362/ --- (Updated Feb. 7, 2018, 10:18 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 65362: Added a method to increment invalid scheduler API call counters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65362/#review197052 --- Ship it! Ship It! - Greg Mann On Feb. 1, 2018, 11:48 p.m.,

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65039/ --- (Updated Feb. 7, 2018, 11:04 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65401: Windows: Enabled `Flags::runtime_directory` for checkpointing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65401/#review197029 --- Ship it! Ship It! - Akash Gupta On Feb. 1, 2018, 11:22

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65522/#review197042 --- FAIL: Failed to apply the dependent review: 65520. Failed

Re: Review Request 65469: Windows: Made `IO::OWNED` file descriptors inheritable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65469/#review197045 --- 3rdparty/libprocess/src/subprocess.cpp Lines 259 (patched)

Re: Review Request 65538: WIP: Added profile selectors in `disk_profile.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65538/#review197048 --- PASS: Mesos patch 65538 was successfully built and tested.

Re: Review Request 65556: Made the default executor treat agent disconnections more gracefully.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65556/#review197056 --- PASS: Mesos patch 65556 was successfully built and tested.

Re: Review Request 65538: WIP: Added profile selectors in `disk_profile.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65538/ --- (Updated Feb. 7, 2018, 9:07 p.m.) Review request for mesos, James DeFelice,

Re: Review Request 65402: Windows: Used Unicode API to duplicate sockets.

> On Feb. 7, 2018, 12:49 p.m., Akash Gupta wrote: > > 3rdparty/stout/include/stout/os/windows/dup.hpp > > Line 30 (original), 33 (patched) > > > > > > It's not a change for this patch, but we should probably look to

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65039/#review197058 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 65522: Fixed some log messages in `slave.cpp`.

> On Feb. 6, 2018, 6:29 p.m., Gaston Kleiman wrote: > > src/slave/slave.cpp > > Line 9530 (original), 9529 (patched) > > > > > > I noticed that if a single task is passed, we surround its ID in single > > quotes,

Re: Review Request 65559: Updated tests for resource provider selector support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65559/ --- (Updated Feb. 8, 2018, 6:38 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 65559: Updated disk profile tests for resource provider selector support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65559/#review197074 --- PASS: Mesos patch 65559 was successfully built and tested.

Review Request 65566: Returned profiles based on provider selectors in UriDiskProfileAdaptor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65566/ --- Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu. Bugs:

Re: Review Request 65558: Added helpers for supporting profile selectors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65558/ --- (Updated Feb. 8, 2018, 4:37 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 65559: Updated disk profile tests for profile selector support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65559/ --- (Updated Feb. 8, 2018, 4:38 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 65538: Added resource provider selectors in `disk_profile.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65538/ --- (Updated Feb. 8, 2018, 4:36 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 65566: Returned profiles based on provider selectors in UriDiskProfileAdaptor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65566/#review197075 --- PASS: Mesos patch 65566 was successfully built and tested.

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/ --- (Updated Feb. 7, 2018, 11:57 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65045: Tested correct operation handling during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review196983 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65394: Added separate structs for health check runtime and check types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65394/#review196986 --- src/checks/checks_runtime.hpp Lines 48 (patched)

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review196988 --- PASS: Mesos patch 64211 was successfully built and tested.

Review Request 65545: Add warning in support/post-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65545/ --- Review request for mesos, Armand Grillet and Benjamin Bannier. Repository:

Re: Review Request 65545: Add warning in support/post-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65545/#review196990 --- support/post-reviews.py Lines 202 (patched)

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review196992 --- Ship it! Ship It! - Kevin Klues On Jan. 19, 2018, 8:48

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Feb. 7, 2018, 3:13 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 65545: Start from merge-base when posting reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65545/ --- (Updated Feb. 7, 2018, 3:22 p.m.) Review request for mesos, Armand Grillet and

Re: Review Request 65545: Start from merge-base when posting reviews.

> On Feb. 7, 2018, 2:35 p.m., Benno Evers wrote: > > support/post-reviews.py > > Lines 202 (patched) > > > > > > I'm tempted to make this fatal, since I cannot imagine a good reason > > why anyone would want to

Re: Review Request 65529: Added --clean flag to bootstrap script for Mesos CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65529/ --- (Updated Feb. 7, 2018, 3:24 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 65545: Start from merge-base when posting reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65545/#review196996 --- PASS: Mesos patch 65545 was successfully built and tested.

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

> On Feb. 7, 2018, 1:35 p.m., Alexander Rukletsov wrote: > > src/checks/checker.cpp > > Line 86 (original), 89 (patched) > > > > > > please no abbreviations like this, it is unclear what this function > > does. Is

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Feb. 6, 2018, 5:48 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 264 (patched) > > > > > > Say "using std::string" in the beginning of the file and save hundreds >

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Feb. 6, 2018, 5:48 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 630 (patched) > > > > > > Use `profilingTimer->timeout().remaining()` directly. There are two

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/#review196985 --- Is this related to

Re: Review Request 64609: Skipped bundled elfio in linting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64609/#review196984 --- Ship it! Ship It! - Armand Grillet On Jan. 25, 2018, 6:36

Re: Review Request 65395: Refactored health checks to cleanly separate each different check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/#review196987 --- src/checks/checker.hpp Lines 120-122 (original), 87-89 (patched)