/r/33040/#comment131945
This fixes a real bug, should be a separated patch.
- Cong Wang
On April 24, 2015, 7:28 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
d0932b04e3825abb6173efe0d1aee199aa356932
Diff: https://reviews.apache.org/r/33759/diff/
Testing
---
Manual tests on local host
Thanks,
Cong Wang
/routing/filter/basic.hpp PRE-CREATION
src/linux/routing/filter/basic.cpp PRE-CREATION
src/tests/routing_tests.cpp ce583b59bf9fb2ef855aa82ab6083ea11b138e55
Diff: https://reviews.apache.org/r/31504/diff/
Testing
---
Run the testcase.
Thanks,
Cong Wang
/
Testing
---
Manually start two mesos containers with netperf running side.
Thanks,
Cong Wang
---
On May 12, 2015, 12:14 a.m., Cong Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/
---
(Updated May 12
---
On May 12, 2015, 12:14 a.m., Cong Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505
, it reads like a handle of veth. Please rename it
to 'egressHandle'.
- Cong Wang
On May 19, 2015, 7:55 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426
with netperf running side.
Thanks,
Cong Wang
Description
---
s/fq_codel filter/fq_codel qdisc/
s/ingress filter/ingress qdisc/
s/non-existant/nonexistent/
Diffs
-
src/tests/routing_tests.cpp 96be25fc31a0024642854f65fc3410e05b4576b7
Diff: https://reviews.apache.org/r/35080/diff/
Testing
---
make check
Thanks,
Cong Wang
/35225/#comment139365
These params are for fq_codel, doesn't apply for htb.
- Cong Wang
On June 8, 2015, 9:46 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35225
/35152/#comment138935
Ditto, the fq_codel here is for traffic isolation and reducing buffer-bloat.
- Cong Wang
On June 5, 2015, 8:38 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/#comment139004
s/CLASS_ID/HTB_CLASS_ID/ ?
- Cong Wang
On June 5, 2015, 11:55 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35152
, 10:26 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs: MESOS-2332
https://issues.apache.org/jira/browse/MESOS-2332
Repository: mesos
Description
---
Report per-container metrics for network bandwidth throttling to the slave
/35225/#comment139549
s/if a queueing discipline already exists/if an htb queueing discipline
already exists/ ??
src/linux/routing/queueing/htb.hpp
https://reviews.apache.org/r/35225/#comment139548
s/Return/Returns/
- Cong Wang
On June 8, 2015, 10:58 p.m., Paul Brett wrote
---
make check
Thanks,
Cong Wang
/network/port_mapping.cpp
432b05ce5a99c8239fafc47a6b65d46a0fbac26e
src/tests/port_mapping_tests.cpp f8372df74cd71df37de4a2438069ef0ea8878512
Diff: https://reviews.apache.org/r/35331/diff/
Testing
---
make check
Thanks,
Cong Wang
/port_mapping.cpp
843e52d6f9923d0ee0a0297cd5c464b8b72f5de3
Diff: https://reviews.apache.org/r/31505/diff/
Testing
---
Manually start two mesos containers with netperf running side.
Thanks,
Cong Wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/#review84998
---
On May 26, 2015, 8:41 p.m., Cong Wang wrote
:
Ping. Did you see these two comments? Seems that the new diff hasn't
resolved these two issues.
Cong Wang wrote:
Yes. 1) I think we all agree on not adding a new flag in case of
inconsistent behavior; 2) We already have a test case, FqCodelClassifier.
Jie Yu wrote:
For 1), I think
:
Ping. Did you see these two comments? Seems that the new diff hasn't
resolved these two issues.
Cong Wang wrote:
Yes. 1) I think we all agree on not adding a new flag in case of
inconsistent behavior; 2) We already have a test case, FqCodelClassifier.
Jie Yu wrote:
For 1), I think
on.
Cong Wang wrote:
No, https://reviews.apache.org/r/31503/ this one should be the first
commit requires 3.2.26.
Chi Zhang wrote:
hmm looks like both are committed? could you submit a fix for that please?
Done: https://issues.apache.org/jira/browse/MESOS-2803 . Feel free to take
---
On June 1, 2015, 10:45 p.m., Cong Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505
On June 1, 2015, 6:44 p.m., Cong Wang wrote:
src/linux/routing/queueing/internal.hpp, line 284
https://reviews.apache.org/r/34426/diff/8/?file=975301#file975301line284
The lastest mesos code already relies on libnl 3.2.26, so not sure how
much sense it makes to keep the backward
On May 22, 2015, 5:28 a.m., Cong Wang wrote:
src/linux/routing/handle.hpp, line 118
https://reviews.apache.org/r/34321/diff/7/?file=968966#file968966line118
Same comments near the definitions in handle.cpp, duplicated?
Paul Brett wrote:
Once for the declaration, second
49e983edab598e2ac487bb488fdd12840a9e7dfc
Diff: https://reviews.apache.org/r/31505/diff/
Testing
---
Manually start two mesos containers with netperf running side.
Thanks,
Cong Wang
---
On May 26, 2015, 8:41 p.m., Cong Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/
---
(Updated May 26, 2015, 8:41 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37399/#review95220
---
Ship it!
Ship It!
- Cong Wang
On Aug. 12, 2015, 9:09 p.m., Paul
---
make check
Thanks,
Cong Wang
/#comment151460
This is not expected, right?
src/linux/perf.cpp (line 477)
https://reviews.apache.org/r/37416/#comment151461
Make it complete, Perf version is not available.
- Cong Wang
On Aug. 21, 2015, 6:46 p.m., Paul Brett wrote
On Aug. 24, 2015, 5:53 p.m., Cong Wang wrote:
src/linux/perf.cpp, line 418
https://reviews.apache.org/r/37416/diff/5/?file=1045148#file1045148line418
This is not expected, right?
Paul Brett wrote:
It would be a rare event but not completly unexpected. After all, perf
can
://reviews.apache.org/r/37466/#comment151466
I think this should still be in perf.hpp even though it is just for testing.
- Cong Wang
On Aug. 21, 2015, 4:06 a.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit
cb1a13d0b1754a50f0121bfda522056ff8c3e3c8
src/tests/containerizer/perf_tests.cpp
6b3d70f3e7ea8f59f94e6961491d4e9a730e3334
Diff: https://reviews.apache.org/r/37540/diff/
Testing
---
make check
Thanks,
Cong Wang
/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8
src/tests/containerizer/perf_tests.cpp
6b3d70f3e7ea8f59f94e6961491d4e9a730e3334
Diff: https://reviews.apache.org/r/37541/diff/
Testing
---
make check
Thanks,
Cong Wang
://reviews.apache.org/r/37101/diff/
Testing
---
make
Thanks,
Cong Wang
$DURATION`.
Please state it in description
- Cong Wang
On Aug. 5, 2015, 11:25 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37147
889)
https://reviews.apache.org/r/37399/#comment149942
Could be just Failed to get htb qdisc statistics on
- Cong Wang
On Aug. 12, 2015, 4:57 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit
b77b61d7048b12cea4586bcf802cbc2ff634331b
src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78
src/tests/containerizer/perf_tests.cpp
6b3d70f3e7ea8f59f94e6961491d4e9a730e3334
Diff: https://reviews.apache.org/r/37540/diff/
Testing
---
make check
Thanks,
Cong Wang
/sched_tests.cpp
00723d01cd2cc37410d6f9fdd2de080063b7ccd8
Diff: https://reviews.apache.org/r/37101/diff/
Testing
---
make
Thanks,
Cong Wang
/linux/perf.hpp b77b61d7048b12cea4586bcf802cbc2ff634331b
src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78
src/tests/containerizer/perf_tests.cpp
6b3d70f3e7ea8f59f94e6961491d4e9a730e3334
Diff: https://reviews.apache.org/r/37541/diff/
Testing
---
make check
Thanks,
Cong
b77b61d7048b12cea4586bcf802cbc2ff634331b
src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78
src/tests/containerizer/perf_tests.cpp
6b3d70f3e7ea8f59f94e6961491d4e9a730e3334
Diff: https://reviews.apache.org/r/37541/diff/
Testing
---
make check
Thanks,
Cong Wang
b77b61d7048b12cea4586bcf802cbc2ff634331b
src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78
src/tests/containerizer/perf_tests.cpp
6b3d70f3e7ea8f59f94e6961491d4e9a730e3334
Diff: https://reviews.apache.org/r/37540/diff/
Testing
---
make check
Thanks,
Cong Wang
g/r/39494/#comment161489>
Like what you do for libevent, it would be nicer if you can add a URL to
libnl3 too, but this is not a big deal...
- Cong Wang
On Oct. 21, 2015, 4:17 p.m., Greg Mann wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103436
---
Ship it!
Ship It!
- Cong Wang
On Oct. 21, 2015, 5:28 p.m
eviews.apache.org/r/39416/#review104117
---
On Oct. 18, 2015, 12:24 a.m., Cong Wang wrote:
>
> ---
> This is an automatically generated e-mail. To re
----
On Oct. 20, 2015, 6:57 p.m., Cong Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39490/
> -
utomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39415/#review104187
---
On Oct. 18, 2015, 12:22 a.m., Cong Wang wrote:
>
> ---
> This is an automati
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39417/#review104119
---
On Oct. 18, 2015, 12:29 a.m., Cong Wang wrote:
>
>
- Cong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39417/#review104120
---
On Oct. 18, 2015, 12:29 a.m., Cong W
,
Cong Wang
Diff: https://reviews.apache.org/r/39416/diff/
Testing
---
None.
Thanks,
Cong Wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39417/#review104119
-------
On Oct. 18, 2015, 12:29 a.m., Cong Wang wrote:
>
> ---
> This
tests, with and without a pre-installed HTB qdisc and classes.
Thanks,
Cong Wang
g/r/40211/#comment165290>
to be created and managed...
docs/mesos-provisioner.md (line 21)
<https://reviews.apache.org/r/40211/#comment165289>
s/and download/download/
s/unpact/unpack/
- Cong Wang
On Nov. 15, 2015, 7:26 p.m., Timoth
/flags.hpp 3e93b52a5874f52361d5a9c685499a7032014a73
src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2
Diff: https://reviews.apache.org/r/38117/diff/
Testing (updated)
---
./src/mesos-network-helper statistics --eth0_name=X --enable_snmp_statistics
--pid=
Thanks,
Cong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/#review103157
---
You probably want to move src/tests/containerizer too?
- Cong
side the loop, its value can't be kept for the next loop, right?
We need to at least keep keys across one loop.
- Cong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38117/#review10
/39490/diff/
Testing
---
Manual tests
Thanks,
Cong Wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39002/#review101499
---
Ship it!
Ship It!
- Cong Wang
On Oct. 5, 2015, 5:48 p.m
/#comment143969
That is called flow classification and isolation. Please also mention that
flow is classified based on port ranges.
- Cong Wang
On July 7, 2015, 9:54 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail
not present so you can use numify?
> >
> > if (!strings::startsWith(tokens[0], "0x")) {
> > ...
> > }
>
> Cong Wang wrote:
> This should work too, but I don't feel it is better than my code.
>
> Ian Downes wrote:
> I reall
a signal
handler...
- Cong Wang
On Aug. 28, 2015, 4:39 p.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37894
On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote:
Why? Everyone knows kill(2) sends a signal while signal(2) installs a
signal handler...
Jie Yu wrote:
IMO, that naming is confusing, and should be 'signal' and 'install'.
Joerg Schad wrote:
This is actually answering
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37903/#review97170
---
Ship it!
Or we can simply make 'prefix' unsigned.
- Cong Wang
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37540/#review97548
---
On Sept. 2, 2015, 10:16 p.m., Cong Wang wrote:
>
> -
s.apache.org/r/37540/#review97548
---
On Sept. 2, 2015, 10:16 p.m., Cong Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
his future?
finalize().
- Cong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37540/#review97548
---
On Sept. 2,
b8335aa585376d27b71897f8cbaefaa12f4b3a5c
src/slave/flags.cpp 7539441c685828027db07173e62a4e5fc1e8b54d
Diff: https://reviews.apache.org/r/38117/diff/
Testing
---
Manual tests
Thanks,
Cong Wang
Diff: https://reviews.apache.org/r/37541/diff/
Testing
---
make check
Thanks,
Cong Wang
b36710d6d7a7250bc071a57310a2d54bfb3bc624
Diff: https://reviews.apache.org/r/38074/diff/
Testing
---
manual tests
Thanks,
Cong Wang
src/slave/containerizer/isolators/cgroups/perf_event.cpp
8c3018de8e77a2a00c90559a995eae2b3678e42f
Diff: https://reviews.apache.org/r/38073/diff/
Testing
---
make check
Thanks,
Cong Wang
,
Cong Wang
8c29ca3dc2a8f6d1fb0f430482190f87f08eb4e8
Diff: https://reviews.apache.org/r/37541/diff/
Testing
---
make check
Thanks,
Cong Wang
c5630118f4858b1a805f25a2db7a24ca0989
src/linux/perf.cpp bb8b5918e4c8f4379784d4fa18c3b4709696e1ea
src/tests/containerizer/perf_tests.cpp
8c29ca3dc2a8f6d1fb0f430482190f87f08eb4e8
Diff: https://reviews.apache.org/r/37540/diff/
Testing
---
make check
Thanks,
Cong Wang
e56738e2dfd6593ef8f093687919da287af78f77
src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624
Diff: https://reviews.apache.org/r/38074/diff/
Testing
---
manual tests
Thanks,
Cong Wang
bef475e4b573f02b69f2c4dd6d1c6a6e10f34c38
Diff: https://reviews.apache.org/r/37541/diff/
Testing
---
make check
Thanks,
Cong Wang
b8335aa585376d27b71897f8cbaefaa12f4b3a5c
src/slave/flags.cpp 7539441c685828027db07173e62a4e5fc1e8b54d
Diff: https://reviews.apache.org/r/38074/diff/
Testing
---
manual tests
Thanks,
Cong Wang
/linux/perf.hpp d10968ca670eb516bae08385fd0ddde8e8ad83b5
src/linux/perf.cpp 0011482cf9d920485728798518d32af0e9627724
src/tests/containerizer/perf_tests.cpp
bef475e4b573f02b69f2c4dd6d1c6a6e10f34c38
Diff: https://reviews.apache.org/r/37540/diff/
Testing
---
make check
Thanks,
Cong
(line 757)
<https://reviews.apache.org/r/38233/#comment154664>
Bytes(usage.xsu_total * pageSize)?
- Cong Wang
On Sept. 9, 2015, 9:32 p.m., Chi Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
-----
On Sept. 4, 2015, 11:16 p.m., Cong Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38074/
> ---
)
<https://reviews.apache.org/r/38382/#comment155717>
s/sampling will be halted// ?
- Cong Wang
On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
calls it
with non-empty cgroups. Also, you probably want to check for events.empty() too
while you are on it.
- Cong Wang
On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail.
tps://reviews.apache.org/r/38378/#comment155703>
You are changing the semantic, the original test case is to verify a list
of events which contains one invalid event, you changed to to verify just one
invalid event. They are different. The original one makes more sense to me.
- Cong Wang
On Se
only reads it when user calls read().
- Cong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37540/#review98924
---
On Sept. 4, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38233/#review98629
---
Ship it!
Ship It!
- Cong Wang
On Sept. 10, 2015, 5:57 p.m., Chi
17)
<https://reviews.apache.org/r/38172/#comment155890>
Why do you need cmath header here?
- Cong Wang
On Sept. 8, 2015, 9:52 p.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail.
the same result
when they read from the same perf event handler.
- Cong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37540/#review100656
---
)
-
src/linux/perf.hpp d10968ca670eb516bae08385fd0ddde8e8ad83b5
src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a
src/tests/containerizer/perf_tests.cpp
ed5212ee31b8aa47339b8b8fab184bbdf85be82a
Diff: https://reviews.apache.org/r/37540/diff/
Testing
---
make check
Thanks,
Cong
f76f0f6a0c7a01c7f061a225d7f6ef52be0ee7b5
src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862
Diff: https://reviews.apache.org/r/38074/diff/
Testing
---
manual tests
Thanks,
Cong Wang
ed5212ee31b8aa47339b8b8fab184bbdf85be82a
Diff: https://reviews.apache.org/r/37541/diff/
Testing
---
make check
Thanks,
Cong Wang
tps://reviews.apache.org/r/38817/#comment158133>
Here you probably want a signal string (strsignal ()) instead of a raw
value.
- Cong Wang
On Sept. 28, 2015, 7:29 p.m., Ben Mahler wrote:
>
> ---
> This is an automatically g
anything to that
file when nc receives nothing.
- Cong Wang
On Oct. 3, 2015, 4:52 p.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On Oct. 6, 2015, 12:01 a.m., Cong Wang wrote:
> > Or simply use 'tee -a' instead? Since it should not append anything to that
> > file when nc receives nothing.
>
> haosdent huang wrote:
> tee -a aslo OK, but seems use different files would more clear?
I have
-3523 to catch
this coding style issue in future?
- Cong Wang
On Oct. 6, 2015, 2:30 a.m., Jojy Varghese wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
tps://reviews.apache.org/r/36180/#comment159024>
traffic_invalid_via_loopback is not good either, because there is no
traffic from an invalid port....
- Cong Wang
On Oct. 6, 2015, 3:13 a.m., haosdent huang
> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52
> > <https://reviews.apache.org/r/38639/diff/1/?file=1081455#file1081455line52>
> >
> > s/namespaces/flags/, because SIG* can
/reviews.apache.org/r/38569/#comment156941>
This one looks unnecessary.
- Cong Wang
On Sept. 21, 2015, 9:23 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
tps://reviews.apache.org/r/38535/#comment156949>
You forgot to remove this line?
There are two more places calling clone() in a similar way:
src/tests/containerizer/launch_tests.cpp, src/tests/containerizer/ns_tests.cpp.
Not sure if you need to fix them too.
- Cong Wang
On Sept. 20, 2015
'?
- Cong Wang
On Sept. 22, 2015, 2:01 p.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
g/r/37967/#comment157179>
s/verified/error/, otherwise reads odd.
src/linux/cgroups.cpp (line 1631)
<https://reviews.apache.org/r/37967/#comment157164>
s/chain/statuses/
- Cong Wang
On Sept. 22, 2015, 7:43 p.m.,
> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52
> > <https://reviews.apache.org/r/38639/diff/1/?file=1081455#file1081455line52>
> >
> > s/namespaces/flags/, because SIG* can
1 - 100 of 237 matches
Mail list logo