Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

2015-08-24 Thread Jan Schlicht
- Jan Schlicht On Aug. 24, 2015, 3:28 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37714

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Jan Schlicht
On July 29, 2015, 3:34 p.m., Bernd Mathiske wrote: src/tests/fetcher_cache_tests.cpp, line 1474 https://reviews.apache.org/r/36773/diff/7/?file=1024458#file1024458line1474 const Path Jan Schlicht wrote: Path::basename() is not marked const (which it probably should), hence

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Jan Schlicht
17225072ba5c1c9a7209f2923bcf562fcb76201f src/slave/containerizer/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58 src/tests/fetcher_cache_tests.cpp 4e1d348c412c0cec6a73d6e43f2c7124db1f3bfe Diff: https://reviews.apache.org/r/36773/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.

2015-07-28 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36889/#review93297 --- Ship it! Ship It! - Jan Schlicht On July 28, 2015, 3:48 p.m

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-28 Thread Jan Schlicht
/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58 src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 Diff: https://reviews.apache.org/r/36773/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.

2015-07-28 Thread Jan Schlicht
/EXPECT_SOME/ASSERT_SOME src/tests/fetcher_cache_tests.cpp (line 930) https://reviews.apache.org/r/36889/#comment147668 s/EXPECT_SOME/ASSERT_SOME - Jan Schlicht On July 28, 2015, 2:52 p.m., Joerg Schad wrote

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-28 Thread Jan Schlicht
/#review93272 --- On July 28, 2015, 4:04 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773

Re: Review Request 36050: Added test authorizer module.

2015-08-04 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/#review94027 --- Ship it! Ship It! - Jan Schlicht On Aug. 3, 2015, 11:47 a.m

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-04 Thread Jan Schlicht
. 4, 2015, 4:13 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-04 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review94023 --- Ship it! Ship It! - Jan Schlicht On Aug. 3, 2015, 11:47 a.m

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-28 Thread Jan Schlicht
/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58 src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 Diff: https://reviews.apache.org/r/36773/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-28 Thread Jan Schlicht
17225072ba5c1c9a7209f2923bcf562fcb76201f src/slave/containerizer/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58 src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 Diff: https://reviews.apache.org/r/36773/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Jan Schlicht
/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58 src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 Diff: https://reviews.apache.org/r/36773/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Jan Schlicht
/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58 src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 Diff: https://reviews.apache.org/r/36773/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-05 Thread Jan Schlicht
://reviews.apache.org/r/36049/#comment148761 Wrong spacing. - Jan Schlicht On Aug. 4, 2015, 6:26 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049

Re: Review Request 36050: Added test authorizer module.

2015-08-05 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/#review94209 --- Ship it! Ship It! - Jan Schlicht On Aug. 5, 2015, 11:04 a.m

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-08-03 Thread Jan Schlicht
/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58 src/tests/fetcher_cache_tests.cpp 4e1d348c412c0cec6a73d6e43f2c7124db1f3bfe Diff: https://reviews.apache.org/r/36773/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-03 Thread Jan Schlicht
://reviews.apache.org/r/36048/#comment148352 I stumbled over this syntax. While it's valid C++11, I'd suggest using `Authorizer* local = new LocalAuthorizer` as that's easier to grok. - Jan Schlicht On Aug. 3, 2015, 11:47 a.m., Alexander Rojas wrote

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Jan Schlicht
On July 29, 2015, 3:34 p.m., Bernd Mathiske wrote: src/tests/fetcher_cache_tests.cpp, line 1474 https://reviews.apache.org/r/36773/diff/7/?file=1024458#file1024458line1474 const Path Jan Schlicht wrote: Path::basename() is not marked const (which it probably should), hence

Review Request 36914: Marked Path::basename, Path::dirname const.

2015-07-29 Thread Jan Schlicht
--- make check Thanks, Jan Schlicht

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Jan Schlicht
/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58 src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 Diff: https://reviews.apache.org/r/36773/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Jan Schlicht
://reviews.apache.org/r/36773/#comment147817 Path::basename() is not marked const (which it probably should), hence we have to iterate over Path by value. - Jan Schlicht On July 29, 2015, 3:59 p.m., Jan Schlicht wrote

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-29 Thread Jan Schlicht
Path by value. - Jan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93443 --- On July 29, 2015, 3:59 p.m., Jan Schlicht wrote

Re: Review Request 37189: Added std::hash template specializations.

2015-08-11 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review94859 --- On Aug. 11, 2015, 11:58 a.m., Jan Schlicht wrote

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

2015-08-11 Thread Jan Schlicht
/stout/include/stout/uuid.hpp e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 37188: Added std::hash template specializations.

2015-08-11 Thread Jan Schlicht
Thanks, Jan Schlicht

Re: Review Request 37189: Added std::hash template specializations.

2015-08-11 Thread Jan Schlicht
://reviews.apache.org/r/37189/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 37189: Added std::hash template specializations.

2015-08-11 Thread Jan Schlicht
, Jan Schlicht

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

2015-08-11 Thread Jan Schlicht
/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-06 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review94395 --- Ship it! Ship It! - Jan Schlicht On Aug. 6, 2015, 1:59 p.m

Re: Review Request 37188: Added std::hash template specializations.

2015-08-07 Thread Jan Schlicht
3rdparty/libprocess/include/process/pid.hpp 3bce0bc99e0ebe3ac06ba53155d558fb041cd76c 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 37189: Added std::hash template specializations.

2015-08-07 Thread Jan Schlicht
/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 Diff: https://reviews.apache.org/r/37189/diff/ Testing --- make check Thanks, Jan

Re: Review Request 37187: Changed hashmap, hashset to use std::unordered_{set, map} instead of boost::unordered_{set, map}.

2015-08-07 Thread Jan Schlicht
/tests/hashset_tests.cpp 341c5e09acb4c4f9da3cee3f35b4f2028552fca3 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 37188: Added std::hash template specializations.

2015-08-07 Thread Jan Schlicht
/libprocess/include/process/pid.hpp 3bce0bc99e0ebe3ac06ba53155d558fb041cd76c 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 37189: Added std::hash template specializations.

2015-08-07 Thread Jan Schlicht
Thanks, Jan Schlicht

Re: Review Request 37187: WIP Changed hashmap, hashset to use std::unordered_{set, map} instead of boost::unordered_{set, map}.

2015-08-07 Thread Jan Schlicht
Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 37187: Changed hashmap, hashset to use std::unordered_{set, map} instead of boost::unordered_{set, map}.

2015-08-07 Thread Jan Schlicht
e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 341c5e09acb4c4f9da3cee3f35b4f2028552fca3 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 37189: Added std::hash template specializations.

2015-08-07 Thread Jan Schlicht
, Jan Schlicht

Re: Review Request 37188: Added std::hash template specializations.

2015-08-07 Thread Jan Schlicht
--- make check Thanks, Jan Schlicht

Re: Review Request 37189: Added std::hash template specializations.

2015-08-07 Thread Jan Schlicht
--- On Aug. 7, 2015, 12:28 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189

Re: Review Request 37189: Added std::hash template specializations.

2015-08-10 Thread Jan Schlicht
/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 37187: Changed hashmap, hashset to use std::unordered_{set, map} instead of boost::unordered_{set, map}.

2015-08-10 Thread Jan Schlicht
e8ebe0b2f5e49657ee191a2535e0abdaf8e665ce 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 37188: Added std::hash template specializations.

2015-08-10 Thread Jan Schlicht
df78f8e525c40b87e734e16979d3315f89e12594 3rdparty/libprocess/include/process/pid.hpp 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan

Re: Review Request 37187: Changed hashmap, hashset to use std::unordered_{set, map} instead of boost::unordered_{set, map}.

2015-08-10 Thread Jan Schlicht
/stout/tests/hashset_tests.cpp 3802a29b82da57217dd75c6b1611fd21c91cfc03 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 37188: Added std::hash template specializations.

2015-08-10 Thread Jan Schlicht
3rdparty/libprocess/include/process/pid.hpp 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3 Diff: https://reviews.apache.org/r/37188/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 37189: Added std::hash template specializations.

2015-08-10 Thread Jan Schlicht
, Jan Schlicht

Review Request 37475: Fixed a wrong comparison.

2015-08-14 Thread Jan Schlicht
/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-27 Thread Jan Schlicht
e030deabd5e749100cbccabb256dbd4af8b2fe58 src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 Diff: https://reviews.apache.org/r/36773/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-27 Thread Jan Schlicht
, 5:38 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/ --- (Updated July 27, 2015, 5:38 p.m

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-27 Thread Jan Schlicht
/fetcher.hpp 17225072ba5c1c9a7209f2923bcf562fcb76201f src/slave/containerizer/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58 src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 Diff: https://reviews.apache.org/r/36773/diff/ Testing --- make check Thanks, Jan

Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-24 Thread Jan Schlicht
://reviews.apache.org/r/36773/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 36617: Improved task reconciliation documentation.

2015-07-22 Thread Jan Schlicht
Thanks, Jan Schlicht

Re: Review Request 36617: Improved task reconciliation documentation.

2015-07-22 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/#review92436 --- On July 22, 2015, 11:14 a.m., Jan Schlicht wrote

Re: Review Request 36617: Improved task reconciliation documentation.

2015-07-22 Thread Jan Schlicht
/tests/mesos.cpp f09ef0f99573716de8905f49dcc0c9df20e31ea9 src/tests/slave_tests.cpp e1390ad84b0003052681600deb9ca518defc0970 Diff: https://reviews.apache.org/r/36617/diff/ Testing --- https://gist.github.com/nfnt/73532d62fe39d27ff33d Thanks, Jan Schlicht

Re: Review Request 36617: Improved task reconciliation documentation.

2015-07-23 Thread Jan Schlicht
/ Testing --- https://gist.github.com/nfnt/73532d62fe39d27ff33d Thanks, Jan Schlicht

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-16 Thread Jan Schlicht
. Diffs (updated) - src/launcher/fetcher.cpp 8aee4901ec1289f43b5fa6b830c3488815ec24cd Diff: https://reviews.apache.org/r/36547/diff/ Testing --- make check external FTP server test. Thanks, Jan Schlicht

Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-16 Thread Jan Schlicht
/fetcher.cpp 8aee4901ec1289f43b5fa6b830c3488815ec24cd Diff: https://reviews.apache.org/r/36547/diff/ Testing --- make check external FTP server test. Thanks, Jan Schlicht

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-16 Thread Jan Schlicht
. Diffs (updated) - src/launcher/fetcher.cpp 8aee4901ec1289f43b5fa6b830c3488815ec24cd Diff: https://reviews.apache.org/r/36547/diff/ Testing --- make check external FTP server test. Thanks, Jan Schlicht

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review91913 --- On July 16, 2015, 6:55 p.m., Jan Schlicht wrote

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Jan Schlicht
. Diffs (updated) - src/launcher/fetcher.cpp 8aee4901ec1289f43b5fa6b830c3488815ec24cd Diff: https://reviews.apache.org/r/36547/diff/ Testing --- make check external FTP server test. Thanks, Jan Schlicht

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Jan Schlicht
generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review92015 --- On July 16, 2015, 6:55 p.m., Jan Schlicht wrote: --- This is an automatically generated e-mail

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Jan Schlicht
for a response code of 226 for FTP URIs. Diffs (updated) - src/launcher/fetcher.cpp 8aee4901ec1289f43b5fa6b830c3488815ec24cd Diff: https://reviews.apache.org/r/36547/diff/ Testing --- make check external FTP server test. Thanks, Jan Schlicht

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Jan Schlicht
. Diffs (updated) - src/launcher/fetcher.cpp 8aee4901ec1289f43b5fa6b830c3488815ec24cd Diff: https://reviews.apache.org/r/36547/diff/ Testing --- make check external FTP server test. Thanks, Jan Schlicht

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Jan Schlicht
. Diffs (updated) - src/launcher/fetcher.cpp 8aee4901ec1289f43b5fa6b830c3488815ec24cd Diff: https://reviews.apache.org/r/36547/diff/ Testing --- make check external FTP server test. Thanks, Jan Schlicht

Re: Review Request 36617: Improved task reconciliation documentation.

2015-07-20 Thread Jan Schlicht
Thanks, Jan Schlicht

Re: Review Request 36617: Improved task reconciliation documentation.

2015-07-21 Thread Jan Schlicht
Thanks, Jan Schlicht

Re: Review Request 37187: Use std::unordered_{set, map} instead of boost::unordered_{set, map}.

2015-08-25 Thread Jan Schlicht
3802a29b82da57217dd75c6b1611fd21c91cfc03 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37187/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

2015-10-22 Thread Jan Schlicht
800) <https://reviews.apache.org/r/38335/#comment161712> Not yours, but please s/push_back/emplace_back src/tests/reservation_endpoints_tests.cpp (line 830) <https://reviews.apache.org/r/38335/#comment161711> This is longer than 80 chars. - Jan Schlicht On Oct. 20, 20

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Jan Schlicht
er/fetcher.cpp (line 935) <https://reviews.apache.org/r/39595/#comment164569> Indent with 4 spaces. - Jan Schlicht On Nov. 10, 2015, 2:45 p.m., Benjamin Bannier wrote: > > --- > This is an automatically gen

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/#review105898 --- Ship it! Ship It! - Jan Schlicht On Nov. 10, 2015, 6:14 p.m

Re: Review Request 39288: Quota: Added authentication of quota requests.

2015-11-11 Thread Jan Schlicht
ead8520b7108a0f2c3a0bb11ae7b543897d111a2 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39288/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 39289: Quota: Added authorization of quota requests.

2015-11-11 Thread Jan Schlicht
src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed Diff: https://reviews.apache.org/r/39289/diff/ Testing --- make check Thanks, Jan Schlicht

Review Request 40187: Fixed and formatted JSON examples.

2015-11-11 Thread Jan Schlicht
4bc68429679a4605056aeb120e9deee51af2dde6 Diff: https://reviews.apache.org/r/40187/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 40087: Added a list of protocols supported by the Mesos fetcher as requested in MESOS-2783

2015-11-10 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40087/#review105819 --- Ship it! Ship It! - Jan Schlicht On Nov. 10, 2015, 11 a.m

Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-11-10 Thread Jan Schlicht
isit: > https://reviews.apache.org/r/39594/ > --- > > (Updated Nov. 6, 2015, 8:52 p.m.) > > > Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff. > > > Bugs: MESOS-3785 > https://issues.apache.org/jira/browse/MESOS-3785 > >

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-11-16 Thread Jan Schlicht
------- On Nov. 16, 2015, 2:53 p.m., Jan Schlicht wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40347/ >

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

2015-11-16 Thread Jan Schlicht
: https://reviews.apache.org/r/40346/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 40345: [1/4] Quota Authorization: Added "RequestQuota" message to ACL protobuf.

2015-11-16 Thread Jan Schlicht
authorizer/authorizer.proto 86bbb45f9d91b4098a262e3e50a793f3bb39497e Diff: https://reviews.apache.org/r/40345/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-11-16 Thread Jan Schlicht
4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/40347/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-11-16 Thread Jan Schlicht
d fix it independently from this RR. - Jan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/#review106662 ------- On

Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.

2015-11-16 Thread Jan Schlicht
tQuota" message to ACL protobuf. Diffs - include/mesos/authorizer/authorizer.proto 86bbb45f9d91b4098a262e3e50a793f3bb39497e Diff: https://reviews.apache.org/r/40345/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-11-16 Thread Jan Schlicht
> opinion the realm should be `Mesos`. If it turns out that this is intended, > > feel free to drop... > > Jan Schlicht wrote: > Also my opinion! But I'm trying to be consistent with the other > `Unauthorized` return values, that all use `Mesos master` as realm. Let's

Re: Review Request 39289: Quota: Added authorization of quota requests.

2015-11-16 Thread Jan Schlicht
src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 src/master/quota_handler.cpp PRE-CREATION src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed Diff: https://reviews.apache.org/r/39289/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

2015-11-16 Thread Jan Schlicht
/ Testing (updated) --- make check Thanks, Jan Schlicht

Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

2015-11-16 Thread Jan Schlicht
/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed Diff: https://reviews.apache.org/r/40346/diff/ Testing --- Thanks, Jan

Review Request 40345: [1/4] Quota Authorization: Added "RequestQuota" message to ACL protobuf.

2015-11-16 Thread Jan Schlicht
iff: https://reviews.apache.org/r/40345/diff/ Testing --- make check Thanks, Jan Schlicht

Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-11-16 Thread Jan Schlicht
ead8520b7108a0f2c3a0bb11ae7b543897d111a2 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/40347/diff/ Testing --- make check Thanks, Jan Schlicht

Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

2015-11-16 Thread Jan Schlicht
806e2da6ad37a6acf76818d4c6b3c462175fd09d Diff: https://reviews.apache.org/r/40348/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 39288: Quota: Added authentication of quota requests.

2015-11-10 Thread Jan Schlicht
/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39288/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 39289: Quota: Added authorization of quota requests.

2015-11-10 Thread Jan Schlicht
3e58b454c75a2ab9f8b4a29785fa823afefd0c8a Diff: https://reviews.apache.org/r/39289/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 40187: Fixed and formatted JSON examples.

2015-11-17 Thread Jan Schlicht
72847e5efe7008fdec8287cce100857f9e7c0fe0 src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d src/slave/flags.cpp 26f554e1a73f1f7f3d7baec7bfc1a7f456c5677c Diff: https://reviews.apache.org/r/40187/diff/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 40187: Fixed and formatted JSON examples.

2015-11-17 Thread Jan Schlicht
. - Jan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40187/#review106797 --- On Nov. 11, 2015, 3:16 p.m., Jan Schli

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

2015-11-17 Thread Jan Schlicht
Thanks, Jan Schlicht

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Jan Schlicht
lt;https://reviews.apache.org/r/39595/#comment164497> Function can be made const. - Jan Schlicht On Nov. 6, 2015, 8:52 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

2015-11-10 Thread Jan Schlicht
/net.hpp (line 132) <https://reviews.apache.org/r/39594/#comment164543> Please add a newline after `=` as you did in l125. - Jan Schlicht On Nov. 10, 2015, 2:45 p.m., Benjamin Bannier wrote: > > --- > This is an automatica

Review Request 39405: [WIP] Quota: Added authentication of quota requests.

2015-11-05 Thread Jan Schlicht
: Added authentication of quota requests. Diffs - Diff: https://reviews.apache.org/r/39405/diff/ Testing --- Thanks, Jan Schlicht

Re: Review Request 39289: [WIP] Quota: Added authorization of quota requests.

2015-10-14 Thread Jan Schlicht
3e58b454c75a2ab9f8b4a29785fa823afefd0c8a Diff: https://reviews.apache.org/r/39289/diff/ Testing --- Thanks, Jan Schlicht

Re: Review Request 39288: [WIP] Quota: Added authentication of quota requests.

2015-10-14 Thread Jan Schlicht
/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39288/diff/ Testing --- Thanks, Jan Schlicht

Re: Review Request 39088: Made shell test locale-independent.

2015-10-08 Thread Jan Schlicht
LC_ALL to make sure that it really is overwritten. - Jan Schlicht On Oct. 7, 2015, 5:24 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39087: Added support for non-ascii chars to apply-review.sh.

2015-10-08 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39087/#review101901 --- Ship it! Ship It! - Jan Schlicht On Oct. 7, 2015, 4:54 p.m

  1   2   3   4   5   6   7   8   9   >