Review Request 35024: Fixed _resources_used() to include only *regular* resources.

2015-06-03 Thread Jiang Yan Xu
710b8149c9d855d0f47cb2952366be10bc78c74d Diff: https://reviews.apache.org/r/35024/diff/ Testing --- make check Thanks, Jiang Yan Xu

Re: Review Request 35118: Made updateSlave() update its 'totalResources'.

2015-06-07 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35118/#review86850 --- On June 5, 2015, 2:09 p.m., Jiang Yan Xu wrote

Re: Review Request 35119: Introduced metrics for revocable resources.

2015-06-07 Thread Jiang Yan Xu
://reviews.apache.org/r/35119/diff/ Testing --- make check. - Modified a test to test the `total` resources metrics. - We don't have unit tests that use the revocable resources yet, when we add that we should check `used` resources metrics too. Thanks, Jiang Yan Xu

Review Request 35239: Update the JSON model for Resources to display their revocablility attribute.

2015-06-08 Thread Jiang Yan Xu
: 0, disk: 0, mem: 0 } } ], ``` Note that `resources` only looks at the resources from SlaveInfo while `total_resources` reads Master::Slave::totalResources. Thanks, Jiang Yan Xu

Review Request 35119: Introduced metrics for revocable resources.

2015-06-05 Thread Jiang Yan Xu
the `total` resources metrics. - We don't have unit tests that use the revocable resources yet, when we add that we should check `used` resources metrics too. Thanks, Jiang Yan Xu

Review Request 35118: Made updateSlave() update its 'totalResources'.

2015-06-05 Thread Jiang Yan Xu
/r/35118/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Re: Review Request 35119: Introduced metrics for revocable resources.

2015-06-09 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35119/#review87238 --- On June 8, 2015, 12:55 p.m., Jiang Yan Xu wrote

Re: Review Request 35239: Update the JSON model for Resources to display their revocablility attribute.

2015-06-09 Thread Jiang Yan Xu
--- On June 8, 2015, 5:38 p.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35239

Re: Review Request 35239: Update the JSON model for Resources to display their revocablility attribute.

2015-06-09 Thread Jiang Yan Xu
that without breaking people's code that exactly matches cpus ? Jiang Yan Xu wrote: It would be easy to do so if this were for the `total_resources/revocable_resources/resources` alone but the fact is that all Resources models are affected by this. Additionally the following

Re: Review Request 35118: Made updateSlave() update its 'totalResources'.

2015-06-10 Thread Jiang Yan Xu
will work? Jiang Yan Xu wrote: Can you suggest something here? FWIW I also updated the comment on `totalResources`: ``` // The current total resources of the slave. Note that this is // different from 'info.resources()' because this also considers

Re: Review Request 34136: Add ContainerImage protobuf.

2015-06-26 Thread Jiang Yan Xu
://reviews.apache.org/r/34136/#comment142204 Is it the intention that Image type is **defined** outside MesosInfo because DockerInfo can later reference it? Otherwise it feels more natual to define Image within MesosInfo. - Jiang Yan Xu On June 22, 2015, 9:42 a.m., Ian Downes wrote

Re: Review Request 34135: Add filesystem/ isolators for persistent volumes.

2015-06-16 Thread Jiang Yan Xu
On June 2, 2015, 2:45 p.m., Timothy Chen wrote: src/slave/containerizer/isolators/filesystem/linux.cpp, line 95 https://reviews.apache.org/r/34135/diff/1/?file=957256#file957256line95 actually I'm wrong, I was reading the old style guide. The newest style guide we do put a space,

Re: Review Request 35327: Fixed a bug that allows different resources of the same name to have different types.

2015-06-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35327/#review87482 --- On June 10, 2015, 3:34 p.m., Jiang Yan Xu wrote: --- This is an automatically generated e

Review Request 35333: Small fix in updateSlave() to make resource math clearer.

2015-06-10 Thread Jiang Yan Xu
--- A follow-up on BenM's suggestion in /r/35118/. Diffs - src/master/master.cpp 95ca2e5f6c903dea7528e559f86639e78ec92b9b Diff: https://reviews.apache.org/r/35333/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Re: Review Request 35327: Fixed a bug that allows different resources of the same name to have different types.

2015-06-10 Thread Jiang Yan Xu
b1e4483695eda998129db2c89a9dce044607c8b0 Diff: https://reviews.apache.org/r/35327/diff/ Testing --- make check. Updated test `ResourcesTest.ParseError` to cover this case. Thanks, Jiang Yan Xu

Re: Review Request 35309: Added Resources::get() and Resources::names().

2015-06-10 Thread Jiang Yan Xu
soon. - Jiang Yan Xu On June 10, 2015, 12:08 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35309

Re: Review Request 35367: Changed Resourcs JSON model() to combine non-revocable resources and ignore revocable resources.

2015-06-11 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35367/#review87649 --- On June 11, 2015, 5:32 p.m., Jiang Yan Xu wrote

Re: Review Request 35367: Changed Resourcs JSON model() to combine non-revocable resources and ignore revocable resources.

2015-06-11 Thread Jiang Yan Xu
f087b2313a13c3199b70b3d7feb728e1449a52e7 src/tests/resources_tests.cpp ad12648a08ebc90da6bc9b9aa196fcef5ebe9f11 Diff: https://reviews.apache.org/r/35367/diff/ Testing (updated) --- make check. Added a test `HTTP.ModelResources` and `ResourcesTest.Types` for this. Thanks, Jiang Yan Xu

Review Request 36005: Removed obsolete ec2 scripts.

2015-06-29 Thread Jiang Yan Xu
from the website. Thanks, Jiang Yan Xu

Re: Review Request 36005: Removed obsolete ec2 scripts.

2015-06-29 Thread Jiang Yan Xu
, Jiang Yan Xu

Re: Review Request 33090: Removed unmaintained frameworks code.

2015-06-29 Thread Jiang Yan Xu
a40c7eafd71a11c8f974aa49a612fa81d0016102 Diff: https://reviews.apache.org/r/33090/diff/ Testing --- make check Thanks, Jiang Yan Xu

Re: Review Request 36005: Removed obsolete ec2 scripts.

2015-06-29 Thread Jiang Yan Xu
--- On June 29, 2015, 11:04 a.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36005/ --- (Updated June 29

Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

2015-07-07 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36269/#review90756 --- On July 7, 2015, 10:59 a.m., Jiang Yan Xu wrote

Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

2015-07-07 Thread Jiang Yan Xu
--- Per Vinod's comment on /r/36005 The `**Cleanup` section makes sense? Diffs - CHANGELOG 433924a0e614f061c448a8e85d0a2825567150dc Diff: https://reviews.apache.org/r/36269/diff/ Testing --- Thanks, Jiang Yan Xu

Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

2015-07-07 Thread Jiang Yan Xu
--- On July 7, 2015, 10:59 a.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36269

Re: Review Request 37422: Added a persistent volume test for linux filesystem isolator to test case where the container does not specify a root filesystem.

2015-08-12 Thread Jiang Yan Xu
is clean after the container terminates? - Jiang Yan Xu On Aug. 12, 2015, 4:34 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37422

Re: Review Request 37334: Added a persistent volume test for linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37334/#review95200 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 10, 2015, 6:58 p.m

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
://reviews.apache.org/r/37330/#comment150016 s/all/All/ - Jiang Yan Xu On Aug. 10, 2015, 6:57 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37330

Re: Review Request 37236: Added the linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
/37236/#comment150046 There is another reference to Absoluate path here which should be updated. - Jiang Yan Xu On Aug. 12, 2015, 11:54 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 37236: Added the linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/#review95198 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 12, 2015, 11:54 a.m

Re: Review Request 37236: Added the linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
On Aug. 12, 2015, 3:59 p.m., Jiang Yan Xu wrote: include/mesos/mesos.proto, line 1255 https://reviews.apache.org/r/37236/diff/3/?file=1038690#file1038690line1255 There is another reference to Absoluate path here which should be updated. Jie Yu wrote: It says ... or a path

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37330/#review95208 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 12, 2015, 4:21 p.m

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-19 Thread Jiang Yan Xu
-CREATION src/slave/containerizer/provisioners/backend.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37382/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Re: Review Request 37722: Added definitions of container rootfs directories.

2015-08-24 Thread Jiang Yan Xu
dbb1f68d8a789303b595d9e455e2f6f1f0de5c5b src/slave/paths.cpp 0741616b656e947cb460dd6ee6a9a4852be001c2 Diff: https://reviews.apache.org/r/37722/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Review Request 37722: Added definitions of container rootfs directories.

2015-08-24 Thread Jiang Yan Xu
0741616b656e947cb460dd6ee6a9a4852be001c2 Diff: https://reviews.apache.org/r/37722/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-19 Thread Jiang Yan Xu
. Thoughts? Jiang Yan Xu wrote: This is intended for the image in volumes case but I was trying to not be too explicit because it's not implemented yet (we should track it with a separate ticket). My comment about 'nested' was incorrect, let me clarify here

Review Request 36023: Improved the documentation of Containerizer::launch() to clarify the failure cases.

2015-06-29 Thread Jiang Yan Xu
--- Improved the documentation of Containerizer::launch() to clarify the failure cases. Diffs - src/slave/containerizer/containerizer.hpp 0ee17e6bc52d1e3acefad6bda3a1b7ba64a8a54b Diff: https://reviews.apache.org/r/36023/diff/ Testing --- N/A Thanks, Jiang Yan Xu

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-06-29 Thread Jiang Yan Xu
? This is not enforced is it? - Jiang Yan Xu On June 22, 2015, 9:38 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444

Re: Review Request 34137: Add support for container image provisioners.

2015-06-29 Thread Jiang Yan Xu
. src/tests/containerizer_tests.cpp (line 344) https://reviews.apache.org/r/34137/#comment142215 Kill empty line. - Jiang Yan Xu On June 22, 2015, 9:44 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 34136: Add ContainerImage protobuf.

2015-07-29 Thread Jiang Yan Xu
/34136/#comment147861 Hmm... I don't think this should be required. It's too inflexible and tasks likely will use name and labels. - Jiang Yan Xu On July 11, 2015, 9:47 p.m., Ian Downes wrote: --- This is an automatically

Re: Review Request 36929: Fixed a few issues in test launcher header.

2015-07-30 Thread Jiang Yan Xu
On July 30, 2015, 9:45 a.m., Vinod Kone wrote: src/tests/containerizer/launcher.hpp, lines 19-37 https://reviews.apache.org/r/36929/diff/1/?file=1024924#file1024924line19 why did you remove these headers? i think we decided to explicitly include all the headers that are

Re: Review Request 36954: Performed a self bind mount of rootfs itself in fs::chroot::enter().

2015-07-31 Thread Jiang Yan Xu
as the process' current root`. - Jiang Yan Xu On July 30, 2015, 3:09 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36954

Re: Review Request 34427: AppC provisioner backend using bind mounts.

2015-08-03 Thread Jiang Yan Xu
On May 21, 2015, 12:29 p.m., Timothy Chen wrote: src/slave/containerizer/provisioners/appc/bind_backend.hpp, line 70 https://reviews.apache.org/r/34427/diff/1/?file=964174#file964174line70 Should we make rootfs a constant somewhere? Yeah, I think there should be a paths.hpp utility

Re: Review Request 37198: Add Docker image provisioner and copy backend.

2015-08-07 Thread Jiang Yan Xu
: https://issues.apache.org/jira/browse/MESOS-2968?focusedCommentId=14652859page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14652859 Does it make sense? Thanks! - Jiang Yan Xu On Aug. 6, 2015, 1:37 p.m., Lily Chen wrote

Re: Review Request 34142: AppC provisioner.

2015-08-11 Thread Jiang Yan Xu
) https://reviews.apache.org/r/34142/#comment149709 Will move this into the bind mount backend. - Jiang Yan Xu On July 7, 2015, 12:43 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 37105: Removed the code of checkpointing container root filesystem path.

2015-08-06 Thread Jiang Yan Xu
/containerizer.cpp (lines 674 - 675) https://reviews.apache.org/r/37105/#comment149060 This doesn't get implicitly converted to Option? - Jiang Yan Xu On Aug. 5, 2015, 2:16 p.m., Jie Yu wrote: --- This is an automatically generated e-mail

Re: Review Request 36956: Created a test abstraction for preparing test rootfs.

2015-08-04 Thread Jiang Yan Xu
out of os.hpp so we only include os.hpp when we intentionally want to include everything. - Jiang Yan Xu On Aug. 3, 2015, 10:18 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 37311: Implemented a 'read-only' Appc image store.

2015-08-13 Thread Jiang Yan Xu
/containerizer/appc_provisioner_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37311/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Re: Review Request 37311: Implemented a 'read-only' Appc image store.

2015-08-13 Thread Jiang Yan Xu
/tests/containerizer/appc_provisioner_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37311/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Re: Review Request 37310: Added Appc spec validation utility.

2015-08-13 Thread Jiang Yan Xu
/containerizer/provisioners/appc/spec.cpp PRE-CREATION src/tests/containerizer/appc_provisioner_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37310/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Re: Review Request 37310: Added Appc spec validation utility.

2015-08-13 Thread Jiang Yan Xu
-mail. To reply, visit: https://reviews.apache.org/r/37310/#review95333 --- On Aug. 13, 2015, 2:33 p.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 37308: Added AppcImageManifest protobuf.

2015-08-13 Thread Jiang Yan Xu
://reviews.apache.org/r/37308/diff/ Testing --- Tested along with /r/37310/. Thanks, Jiang Yan Xu

Re: Review Request 37310: Added Appc spec validation utility.

2015-08-13 Thread Jiang Yan Xu
/containerizer/provisioners/appc/spec.cpp PRE-CREATION src/tests/containerizer/appc_provisioner_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37310/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Review Request 37309: Add app::paths which handles Appc related path manipulation.

2015-08-10 Thread Jiang Yan Xu
-CREATION src/slave/containerizer/provisioners/appc/paths.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37309/diff/ Testing --- Tested along with /r/37310/. Thanks, Jiang Yan Xu

Review Request 37310: Added Appc spec validation utility.

2015-08-10 Thread Jiang Yan Xu
://reviews.apache.org/r/37310/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Review Request 37311: Implemented a 'read-only' Appc image store.

2015-08-10 Thread Jiang Yan Xu
, Jiang Yan Xu

Review Request 37307: Changed Image::AppC::id from required to optional.

2015-08-10 Thread Jiang Yan Xu
/A. Thanks, Jiang Yan Xu

Re: Review Request 37310: Added Appc spec validation utility.

2015-08-10 Thread Jiang Yan Xu
PRE-CREATION src/tests/containerizer/appc_provisioner_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37310/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Review Request 37308: Added AppcImageManifest protobuf.

2015-08-10 Thread Jiang Yan Xu
, Jiang Yan Xu

Re: Review Request 37310: Added Appc spec validation utility.

2015-08-10 Thread Jiang Yan Xu
-CREATION src/tests/containerizer/appc_provisioner_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37310/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Re: Review Request 37311: Implemented a 'read-only' Appc image store.

2015-08-10 Thread Jiang Yan Xu
/containerizer/appc_provisioner_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37311/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Re: Review Request 37311: Implemented a 'read-only' Appc image store.

2015-08-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37311/#review94814 --- On Aug. 10, 2015, 12:19 p.m., Jiang Yan Xu wrote: --- This is an automatically generated e

Re: Review Request 37307: Changed Image::AppC::id from required to optional.

2015-08-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37307/#review94792 --- On Aug. 10, 2015, 11:31 a.m., Jiang Yan Xu wrote

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-14 Thread Jiang Yan Xu
-CREATION src/slave/containerizer/provisioners/backend.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37382/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-14 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95069 --- On Aug. 14, 2015, 10:51 a.m., Jiang Yan Xu wrote

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-14 Thread Jiang Yan Xu
--- On Aug. 14, 2015, 10:51 a.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-14 Thread Jiang Yan Xu
. Thoughts? Jiang Yan Xu wrote: This is intended for the image in volumes case but I was trying to not be too explicit because it's not implemented yet (we should track it with a separate ticket). My comment about 'nested' was incorrect, let me clarify here

Review Request 37382: Introduced provisioner Backend interface.

2015-08-11 Thread Jiang Yan Xu
: https://reviews.apache.org/r/37382/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Re: Review Request 37236: Added the linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
:13 p.m.) Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, Vinod Kone, and Jiang Yan Xu. Bugs: MESOS-2794 https://issues.apache.org/jira/browse/MESOS-2794 Repository: mesos Description --- Added the linux filesystem isolator. Note

Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
Does this not cause the issue mpark [mentioned](http://mail-archives.apache.org/mod_mbox/mesos-dev/201507.mbox/%3ccal3vcqqrcwbblf3u2fdhu1myohqgqjub9ul3zjn+oqxx0on...@mail.gmail.com%3E)? May have to put them in tests themselves. - Jiang Yan Xu On Aug. 7, 2015, 5:32 p.m., Jie Yu

Re: Review Request 37055: Added Image to Volume as one of the sources.

2015-08-07 Thread Jiang Yan Xu
On Aug. 5, 2015, 4:43 p.m., Timothy Chen wrote: include/mesos/mesos.proto, line 1254 https://reviews.apache.org/r/37055/diff/1/?file=1028034#file1028034line1254 Should we add some commets around the Image? Perhaps something like: // Image that will be used to

Re: Review Request 37142: Removed the unneeded ExecutorInfo from Container struct in MesosContainerizer.

2015-08-07 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37142/#review94594 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 5, 2015, 2:22 p.m

Re: Review Request 37105: Removed the code of checkpointing container root filesystem path.

2015-08-07 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37105/#review94598 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 5, 2015, 2:16 p.m

Re: Review Request 34136: Add ContainerImage protobuf.

2015-07-14 Thread Jiang Yan Xu
- perfix. What do you think? - Jiang Yan Xu On July 11, 2015, 9:47 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136

Re: Review Request 34136: Add ContainerImage protobuf.

2015-07-14 Thread Jiang Yan Xu
On June 26, 2015, 2:57 p.m., Jiang Yan Xu wrote: include/mesos/mesos.proto, lines 1212-1214 https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1212 Is it the intention that Image type is **defined** outside MesosInfo because DockerInfo can later reference

Re: Review Request 34136: Add ContainerImage protobuf.

2015-07-16 Thread Jiang Yan Xu
On July 14, 2015, 2:03 p.m., Jiang Yan Xu wrote: include/mesos/mesos.proto, lines 1211-1213 https://reviews.apache.org/r/34136/diff/3/?file=1009139#file1009139line1211 So I found the use of the field `id` inconsistent in the code. Sometimes `id` has the `sha512-` prefix

Re: Review Request 34142: AppC provisioner.

2015-07-17 Thread Jiang Yan Xu
identical images if done in parallel right? Also we need to maintain the image provisioning order. src/slave/containerizer/provisioners/appc.cpp (line 446) https://reviews.apache.org/r/34142/#comment145775 Be more explicit with `Optionstring::none()`? - Jiang Yan Xu On July 7, 2015, 12

Re: Review Request 34140: AppC image store

2015-07-17 Thread Jiang Yan Xu
there are additional files outside of rootfs, etc. - Jiang Yan Xu On July 7, 2015, 12:43 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140

Re: Review Request 34142: AppC provisioner.

2015-07-17 Thread Jiang Yan Xu
On July 2, 2015, 1:48 a.m., Timothy Chen wrote: include/mesos/mesos.proto, line 1300 https://reviews.apache.org/r/34142/diff/2/?file=989783#file989783line1300 I believe we discussed this, but different acVersion will most likely have different schema. Unless we

Re: Review Request 34137: Add support for container image provisioners.

2015-07-17 Thread Jiang Yan Xu
On July 16, 2015, 6:36 p.m., Jie Yu wrote: src/slave/containerizer/mesos/containerizer.cpp, line 630 https://reviews.apache.org/r/34137/diff/3/?file=1009143#file1009143line630 Hum, looks like a bug since, for example, slaveId is a reference and will be invalid when the lambda is

Re: Review Request 34141: AppC provsioning backend.

2015-07-17 Thread Jiang Yan Xu
` is copied to `directory` rather than `directory/rootfs`. I assume this is what we want given the bind mount backend implemetation: A simple illustration of directory layout (in `paths.hpp`) is hugely helpful. - Jiang Yan Xu On July 7, 2015, 12:43 p.m., Ian Downes wrote

Re: Review Request 34142: AppC provisioner.

2015-07-17 Thread Jiang Yan Xu
On July 1, 2015, 5:40 p.m., Lily Chen wrote: src/slave/containerizer/provisioners/appc.cpp, lines 143-151 https://reviews.apache.org/r/34142/diff/2/?file=989787#file989787line143 What if the candidate is over-specified (has more labels)? Should this still be a match? According

Re: Review Request 34140: AppC image store

2015-07-17 Thread Jiang Yan Xu
On May 27, 2015, 4:10 p.m., Paul Brett wrote: src/slave/containerizer/provisioners/appc/store.cpp, line 267 https://reviews.apache.org/r/34140/diff/1/?file=957277#file957277line267 Why not do the decompress, hash untar as a pipeline to reduce disk usage? Ian Downes wrote:

Re: Review Request 29437: Bug fix: Start the executor registration timer, only when the container has launched successfully

2015-07-14 Thread Jiang Yan Xu
On July 14, 2015, 10:21 a.m., Timothy Chen wrote: Nishant are you still around to help rebase this? Sorry I think we dropped this review somehow. He responded on https://issues.apache.org/jira/browse/MESOS-999. I did some work on it but ended up not pushing it. Would you like to comment

Review Request 37747: Introduced bind-mount based provisioner Backend.

2015-08-25 Thread Jiang Yan Xu
src/tests/containerizer/provisioner_backend_tests.cpp PRE-CREATION src/tests/utils.hpp f2eed2e6fbc2cc8772c642bba976b25b426784e8 Diff: https://reviews.apache.org/r/37747/diff/ Testing --- sudo make check. Added one test. Thanks, Jiang Yan Xu

Re: Review Request 38747: Adding digest utilities

2015-10-12 Thread Jiang Yan Xu
a comment? Also, we don't need to special case this right? It will terminate at the next iteration right? 3rdparty/libprocess/include/process/digest.hpp (line 299) <https://reviews.apache.org/r/38747/#comment158853> Would it be safer to just have the caller select from t

Re: Review Request 38747: Adding digest utilities

2015-10-12 Thread Jiang Yan Xu
> On Oct. 1, 2015, 11:23 a.m., Jiang Yan Xu wrote: > > Sorry I haven't chimed in earlier. I made one comment earlier with a > > reference to a pending review <https://reviews.apache.org/r/34138/> but > > didn't look at the review closely. I also have a ticket &g

Re: Review Request 38747: Adding digest utilities

2015-10-12 Thread Jiang Yan Xu
> On Oct. 1, 2015, 11:23 a.m., Jiang Yan Xu wrote: > > Sorry I haven't chimed in earlier. I made one comment earlier with a > > reference to a pending review <https://reviews.apache.org/r/34138/> but > > didn't look at the review closely. I also have a ticket &g

Re: Review Request 38747: Adding digest utilities

2015-10-12 Thread Jiang Yan Xu
a moot point is we don't use template as I was suggesting above. - Jiang Yan Xu On Oct. 12, 2015, 2:14 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 34138: AppC hash computation.

2015-07-07 Thread Jiang Yan Xu
dgst -sha512 somefile.txt SHA512(somefile.txt)= 5a73e55fd845981be5d5b87039c678b87404405d5d054c579cf684a18893d181085b9afde535c034221f858d2bcc2b14978b4d5f4d6facfaa1f81e727a010f3c ``` I think we only need shasum and sha512sum to cover both Linux and OSX. - Jiang Yan Xu On July 7

Re: Review Request 34139: AppC image discovery.

2015-07-07 Thread Jiang Yan Xu
that this is only for local discovery? The sentences already mentions 'local images' but I think --appc_discovery=local is more explict in telling what the operator should do. - Jiang Yan Xu On July 7, 2015, 12:42 p.m., Ian Downes wrote

Re: Review Request 34138: AppC hash computation.

2015-07-07 Thread Jiang Yan Xu
On July 7, 2015, 3:56 p.m., Jiang Yan Xu wrote: 1. Agree that this is useful as a utility in libprocess. Not much overhead to move it over right? 2. It feels like something that could be exposed as a function rather than class, maybe a TODO. OK I realized that doing

Re: Review Request 37738: Added a filesystem isolator test to test image in volume while the container root filesystem is also specified.

2015-08-26 Thread Jiang Yan Xu
/#comment152116 Same as my comment about in the last review about literals test_image_rootfs and test_image_volume needing to match the ones used to create the containerizer. Local variables are more explicit. - Jiang Yan Xu On Aug. 24, 2015, 4:22 p.m., Jie Yu wrote

Re: Review Request 37735: Refactored filesystem isolator tests to allow multiple rootfses.

2015-08-26 Thread Jiang Yan Xu
. Of course the reader is expected to know this, but the more explicit the better, right? - Jiang Yan Xu On Aug. 24, 2015, 4 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37735

Re: Review Request 37881: Implemented AppcProvisioner.

2015-08-29 Thread Jiang Yan Xu
them. And right now, only Appc is supported. Jiang Yan Xu wrote: Fine with me. I have changed the semantics to Provisioner::create to this: ``` // Create all supported provisioners. Return error if provisioners // explicitly specified in '--provisioners' have failed to be created

Re: Review Request 37881: Implemented AppcProvisioner.

2015-08-29 Thread Jiang Yan Xu
. Thanks, Jiang Yan Xu

Re: Review Request 37880: Changed the Appc provisioner directory to identify a rootfs by a rootfs_id (UUID).

2015-08-29 Thread Jiang Yan Xu
--- make check. Thanks, Jiang Yan Xu

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-08-29 Thread Jiang Yan Xu
fbd1c535d398a4d37c30ba23f5408095c7d35b65 src/tests/containerizer/appc_provisioner_tests.cpp 47b66b9c30cefe8f9a8e2c1c1341776c2d235020 Diff: https://reviews.apache.org/r/37929/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-08-29 Thread Jiang Yan Xu
/containerizer/appc_provisioner_tests.cpp 47b66b9c30cefe8f9a8e2c1c1341776c2d235020 Diff: https://reviews.apache.org/r/37929/diff/ Testing --- make check. Thanks, Jiang Yan Xu

Re: Review Request 37881: Implemented AppcProvisioner.

2015-08-30 Thread Jiang Yan Xu
src/tests/containerizer/appc_provisioner_tests.cpp 47b66b9c30cefe8f9a8e2c1c1341776c2d235020 Diff: https://reviews.apache.org/r/37881/diff/ Testing --- sudo make check. More test cases coming. Thanks, Jiang Yan Xu

  1   2   3   4   5   6   7   8   9   10   >