Re: Review Request 41360: Aligned the code blocks in Getting Started better.

2015-12-16 Thread Kevin Klues
> On Dec. 16, 2015, 11:36 p.m., Neil Conway wrote: > > Looks good! While we're at it, can we update the example version in the > > first `wget` command to be 0.26? > > Kevin Klues wrote: > I'll do that, but as a separate commit. https://reviews.apach

Review Request 41476: Updated getting started for 0.26 release.

2015-12-16 Thread Kevin Klues
--- Thanks, Kevin Klues

Re: Review Request 41360: Aligned the code blocks in Getting Started better.

2015-12-16 Thread Kevin Klues
mmit. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41360/#review110793 --- On Dec. 16, 2015, 11:09 p.m., Kevin Klues wrote: > > --- >

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-16 Thread Kevin Klues
ed e-mail. To reply, visit: https://reviews.apache.org/r/41372/#review110805 --- On Dec. 16, 2015, 11:07 p.m., Kevin Klues wrote: > > --- > This is an automatically

Re: Review Request 41362: Added note in docs for installing wget, tar, git.

2015-12-16 Thread Kevin Klues
0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41362/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41411: Added flags to update summary / desc for reviews.

2015-12-16 Thread Kevin Klues
----- On Dec. 15, 2015, 10:38 p.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41411/ > -

Re: Review Request 41371: Fixed getting started instructions for centos 7.1.

2015-12-16 Thread Kevin Klues
0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41371/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41363: Reworded NOTE in Examples for Getting Started doc.

2015-12-16 Thread Kevin Klues
(updated) - docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41363/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41371: Fixed getting started instructions for centos 7.1.

2015-12-16 Thread Kevin Klues
> On Dec. 16, 2015, 11:59 p.m., Jojy Varghese wrote: > > docs/getting-started.md, line 127 > > <https://reviews.apache.org/r/41371/diff/2/?file=1165243#file1165243line127> > > > > I would enclose libserf-1 i backticks. > > Kevin Klues wrote: >

Re: Review Request 41364: Added NOTE to Examples in Getting Started on prod.

2015-12-16 Thread Kevin Klues
/41364/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41371: Fixed getting started instructions for centos 7.1.

2015-12-16 Thread Kevin Klues
.apache.org/r/41371/#review110801 --- On Dec. 16, 2015, 11:06 p.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41371/ > ---

Re: Review Request 41480: [site] Added blog-post for 0.26.0.

2015-12-16 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41480/#review110869 --- Ship it! Ship It! - Kevin Klues On Dec. 17, 2015, 1:30 a.m

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-16 Thread Kevin Klues
/ Testing --- Thanks, Kevin Klues

Re: Review Request 41361: Wrote cmd to create WANdiscoSVN file for centos.

2015-12-16 Thread Kevin Klues
org/jira/browse/MESOS-4185 - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41361/#review110787 --- On Dec. 16,

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

2015-12-16 Thread Kevin Klues
/download/1.0.0/centos-6.6-x86_64.box Also tested on docker image centos:7 Thanks, Kevin Klues

Re: Review Request 41244: Using 'git rev-parse --git-dir' in post-reviews.py.

2015-12-16 Thread Kevin Klues
all of my reviews with this script since first creating this commit. Tested both in an environment with and without mesos embedded as a submodule inside another git repository. Thanks, Kevin Klues

Re: Review Request 41364: Added NOTE to Examples in Getting Started on prod.

2015-12-16 Thread Kevin Klues
://reviews.apache.org/r/41364/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41485: [site] Updated downloads-page for 0.26.0.

2015-12-16 Thread Kevin Klues
tps://reviews.apache.org/r/41485/#comment170892> Is this link supposed to trigger a download? It just seems to take me to a mirrors site. - Kevin Klues On Dec. 17, 2015, 1:31 a.m., Till Toenshoff wrote: > > --- > This is an automatically g

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-17 Thread Kevin Klues
ikely be treated as "Invite-only" since no public groups are accessible. - Kevin Klues On Dec. 17, 2015, 3:31 a.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Kevin Klues
> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. > > Kevin Klues wrote: > Even if it goes over the 70

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

2015-12-14 Thread Kevin Klues
' instead of simply assuming that the local .git is the proper directory. Diffs - bootstrap 89d986fd95dc16bbb79623ef92e3b14a2e7009f9 Diff: https://reviews.apache.org/r/41243/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41244: Using 'git rev-parse --git-dir' in post-reviews.py.

2015-12-14 Thread Kevin Klues
: https://reviews.apache.org/r/41244/diff/ Testing --- Thanks, Kevin Klues

Review Request 41372: Add update for systemd in centos Getting Started

2015-12-14 Thread Kevin Klues
requirements. Diffs - docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41372/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41364: Added NOTE to Examples in Getting Started on prod.

2015-12-14 Thread Kevin Klues
://reviews.apache.org/r/41364/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Kevin Klues
) and not understanding why they can't access the mesos web page. This note adds a comment to try and hinder such confusion. Diffs (updated) - docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41364/diff/ Testing --- Thanks, Kevin Klues

Review Request 41371: Fix getting started instructions for centos 7.1

2015-12-14 Thread Kevin Klues
jre installed for other purposes. Best to just update to the newwest default version of the java development tools. Diffs - docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41371/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41371: Fixed getting started instructions for centos 7.1.

2015-12-14 Thread Kevin Klues
0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41371/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41278: Added note to site-docker doc about tunneling.

2015-12-14 Thread Kevin Klues
to localhost to view the site locally. This commit adds a note about how to do so. Diffs - support/site-docker/README.md 80d34f33a5089214522b9c936710ccd29038a91a Diff: https://reviews.apache.org/r/41278/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-14 Thread Kevin Klues
, Kevin Klues

Review Request 41383: Added ubuntu dependence for libsasl2-modules.

2015-12-14 Thread Kevin Klues
://reviews.apache.org/r/41383/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41363: Reworded NOTE in Examples for Getting Started doc.

2015-12-14 Thread Kevin Klues
such a change. Diffs - docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41363/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41362: Added note in docs for installing wget, tar, git.

2015-12-14 Thread Kevin Klues
0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41362/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41361: Wrote cmd to create WANdiscoSVN file for centos.

2015-12-14 Thread Kevin Klues
and fill the contents automatically. Diffs - docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41361/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41360: Aligned the code blocks in Getting Started better.

2015-12-14 Thread Kevin Klues
0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41360/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41359: Forced horizontal scroll in docs code blocks.

2015-12-14 Thread Kevin Klues
://reviews.apache.org/r/41359/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41286: Updated Getting Started for Mac OS X El Capitan.

2015-12-14 Thread Kevin Klues
Yosemite to El Capitan, you need to rerun 'xcode-select --install'. This commit adds a note of this. Diffs - docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41286/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Kevin Klues
gt; > docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb > > Diff: https://reviews.apache.org/r/41364/diff/ > > > Testing > --- > > > Thanks, > > Kevin Klues > >

Re: Review Request 41286: Update Getting Started for Mac OS X El Capitan

2015-12-14 Thread Kevin Klues
of this. Diffs - docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41286/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41286: Update Getting Started for Mac OS X El Capitan

2015-12-14 Thread Kevin Klues
of this. Diffs (updated) - docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41286/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41286: Update Getting Started for Mac OS X El Capitan

2015-12-14 Thread Kevin Klues
' though, that's just bad english. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41286/#review110184 ------- O

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-15 Thread Kevin Klues
instructions to explicity update systemd as part of the system requirements. Diffs (updated) - docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41372/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41411: Added flags to update summary / desc for reviews.

2015-12-15 Thread Kevin Klues
, Kevin Klues

Review Request 41411: Added flags to post_reviews.py to update summary.

2015-12-15 Thread Kevin Klues
- support/post-reviews.py 170be83aa6dca6e8175292169d78e8f7915f7e6e Diff: https://reviews.apache.org/r/41411/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41371: Fixed getting started instructions for centos 7.1.

2015-12-15 Thread Kevin Klues
/ Testing --- Thanks, Kevin Klues

Review Request 41243: Update how we find the .git directory in bootstrap

2015-12-10 Thread Kevin Klues
://reviews.apache.org/r/41243/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41278: Add note to site-docker doc about tunneling

2015-12-14 Thread Kevin Klues
(updated) - support/site-docker/README.md 80d34f33a5089214522b9c936710ccd29038a91a Diff: https://reviews.apache.org/r/41278/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41278: Add note to site-docker doc about tunneling

2015-12-14 Thread Kevin Klues
an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41278/#review110191 --- On Dec. 14, 2015, 6:39 p.m., Kevin Klues wrote: > > --- > This is an autom

Review Request 41362: Add note in docs for installing wget, tar, git

2015-12-14 Thread Kevin Klues
Requirements' section. The two CentOS sections already had instructions for 'wget' and 'tar', but now 'git' has been added to the list. Diffs - docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41362/diff/ Testing --- Thanks, Kevin Klues

Review Request 41360: Align the code blocks in Getting Started better

2015-12-14 Thread Kevin Klues
. printing multi-line strings to a file) so they can easily be copy and pasted without having to modify the lines. Diffs - docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41360/diff/ Testing --- Thanks, Kevin Klues

Review Request 41359: Force horizontal scroll in docs code blocks

2015-12-14 Thread Kevin Klues
on in the code. It also makes it easier to copy and paste whole blocks of code. Diffs - site/source/assets/css/main.css f5622cf743dfc0a1dd1ffce88dfd90ec33e6427c Diff: https://reviews.apache.org/r/41359/diff/ Testing --- Thanks, Kevin Klues

Review Request 41363: Reword NOTE in Examples for Getting Started doc

2015-12-14 Thread Kevin Klues
/r/41363/diff/ Testing --- Thanks, Kevin Klues

Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Kevin Klues
to the mesos web page. This note adds a comment to try and hinder such confusion. Diffs - docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41364/diff/ Testing --- Thanks, Kevin Klues

Review Request 41361: Write cmd to create WANdiscoSVN file for centos

2015-12-14 Thread Kevin Klues
: https://reviews.apache.org/r/41361/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 41244: Use 'git rev-parse --git-dir' in post-reviews.py

2015-12-11 Thread Kevin Klues
dkone` to this review? Added - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41244/#review109988 --- On Dec.

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

2015-12-15 Thread Kevin Klues
it: https://reviews.apache.org/r/41243/#review110468 --- On Dec. 15, 2015, 3:10 p.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

2015-12-15 Thread Kevin Klues
) - bootstrap 89d986fd95dc16bbb79623ef92e3b14a2e7009f9 Diff: https://reviews.apache.org/r/41243/diff/ Testing --- Thanks, Kevin Klues

Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-07 Thread Kevin Klues
by the /tasks endpoint. Thanks, Kevin Klues

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-08 Thread Kevin Klues
with max_completed_frameworks=0..2 and max_completed_tasks_per_framework=0..5 and verified visually that the proper number of tasks/frameworks were being returned by the /tasks endpoint. Thanks, Kevin Klues

Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-13 Thread Kevin Klues
est for this as reviewed here: https://reviews.apache.org/r/42053/ Thanks, Kevin Klues

Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-13 Thread Kevin Klues
with max_completed_frameworks=0..2 and max_completed_tasks_per_framework=0..5 and verified visually that the proper number of tasks/frameworks were being returned by the /tasks endpoint. There is alos now a unit test for this as reviewed here: https://reviews.apache.org/r/42053/ Thanks, Kevin Klues

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

2016-01-13 Thread Kevin Klues
--- Tested on native Mac OS X El Capitan Tested on vagrant boxes for bento/centos-7.1, ubuntu/trusty64, and https://github.com/tommy-muehle/puppet-vagrant-boxes/releases/download/1.0.0/centos-6.6-x86_64.box Also tested on docker image centos:7 Thanks, Kevin Klues

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

2016-01-13 Thread Kevin Klues
comments on the matter can be seen above. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review114168 --- On Jan. 11, 2016, 8:12 p.m., Kevin Klues wrote: > > -

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-13 Thread Kevin Klues
ing --- This is a unit test. I ran it on my mac and on ubuntu 14.04. GTEST_FILTER="MasterTest.FrameworksTasksCompletedFlags" make check -j 7 Thanks, Kevin Klues

Re: Review Request 42209: Updated getting started page to install Java on OSX.

2016-01-13 Thread Kevin Klues
> On Jan. 12, 2016, 10:04 p.m., Kevin Klues wrote: > > Can you veirfy that this doesn't break things for Yosemite? > > Vinod Kone wrote: > I don't have yosemite handy to test it :) but from looking online it > looks like cask and caskroom have existed for a while, pre-

Re: Review Request 42209: Updated getting started page to install Java on OSX.

2016-01-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42209/#review114183 --- Ship it! Ship It! - Kevin Klues On Jan. 12, 2016, 9:38 p.m

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
visually that the proper number of tasks/frameworks were being returned by the /tasks endpoint. Thanks, Kevin Klues

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
of other configurations with max_completed_frameworks=0..2 and max_completed_tasks_per_framework=0..5 and verified visually that the proper number of tasks/frameworks were being returned by the /tasks endpoint. Thanks, Kevin Klues

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
ming. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/#review113896 --- On Jan. 12, 2016, 6:37 p.m., Ke

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
and verified visually that the proper number of tasks/frameworks were being returned by the /tasks endpoint. Thanks, Kevin Klues

Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
configurations with max_completed_frameworks=0..2 and max_completed_tasks_per_framework=0..5 and verified visually that the proper number of tasks/frameworks were being returned by the /tasks endpoint. Thanks, Kevin Klues

Review Request 42212: Added unit test for framework/task history flags.

2016-01-12 Thread Kevin Klues
I ran it on my mac and on ubuntu 14.04. Thanks, Kevin Klues

Re: Review Request 42209: Updated getting started page to install Java on OSX.

2016-01-12 Thread Kevin Klues
? - Kevin Klues On Jan. 12, 2016, 9:38 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42209/ > --

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-12 Thread Kevin Klues
iff/ Testing (updated) --- This is a unit test. I ran it on my mac and on ubuntu 14.04. GTEST_FILTER="MasterTest.FrameworksTasksCompletedFlags" make check -j 7 Thanks, Kevin Klues

Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
and verified visually that the proper number of tasks/frameworks were being returned by the /tasks endpoint. There is alos now a unit test for this as reviewed here: https://reviews.apache.org/r/42053/ Thanks, Kevin Klues

Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
bsite changes while under review can be viewed here: http://c99.millennium.berkeley.edu:4567/documentation/latest/configuration/ - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apac

Re: Review Request 42053: Added flags to set size of completed task/framework history.

2016-01-12 Thread Kevin Klues
://reviews.apache.org/r/42053/ Thanks, Kevin Klues

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-11 Thread Kevin Klues
is is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/#review113428 ------- On Jan. 11, 2016, 9:39 p.m., Kevin Klues wrote: > > --- > Thi

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-11 Thread Kevin Klues
=0..5 and verified visually that the proper number of tasks/frameworks were being returned by the /tasks endpoint. Thanks, Kevin Klues

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-11 Thread Kevin Klues
- Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/#review113428 --- On Jan. 11, 2016, 9:39 p.m., Kevin Klues wrote

Review Request 42154: Moved push_back to end of removeFramework.

2016-01-11 Thread Kevin Klues
adverse effects. Review: https://reviews.apache.org/r/42154 Diffs - src/master/master.cpp 2d9b7f9540574aa3ef9e5af3b2b8922dffeebac8 Diff: https://reviews.apache.org/r/42154/diff/ Testing --- Thanks, Kevin Klues

Re: Review Request 42053: Add flags to set size of completed task/framework history.

2016-01-11 Thread Kevin Klues
- Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/#review113428 --- On Jan. 11, 2016, 9:39 p.m., Kevin Klues wrote

Re: Review Request 48478: Created a `cgroups/devices` isolator.

2016-06-09 Thread Kevin Klues
b1e64b2fc5518463cd14e119f89e3cd298286052 Diff: https://reviews.apache.org/r/48478/diff/ Testing (updated) --- make -j check GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues

Review Request 48478: Created a `cgroups/devices` isolator.

2016-06-09 Thread Kevin Klues
, Kevin Klues

Review Request 48477: Added ability to express dependencies between isolators.

2016-06-09 Thread Kevin Klues
://reviews.apache.org/r/48477/diff/ Testing --- make -j check Thanks, Kevin Klues

Re: Review Request 48365: Bundled NVML headers for Nvidia GPU support.

2016-06-07 Thread Kevin Klues
/ Testing --- GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues

Review Request 48371: Added `NvidiaGpuAllocator` component.

2016-06-07 Thread Kevin Klues
/48371/diff/ Testing --- GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues

Review Request 48370: Fixed method of populating device entries for `/dev/nvidia-uvm`, etc.

2016-06-07 Thread Kevin Klues
" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues

Review Request 48369: Fixed comment in Nvidia GPU device isolator.

2016-06-07 Thread Kevin Klues
--- Fixed comment in Nvidia GPU device isolator. Diffs - src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp 7849e518af448d9557ca4d6de4ccaba8bc572992 Diff: https://reviews.apache.org/r/48369/diff/ Testing --- Thanks, Kevin Klues

Review Request 48368: Changed major/minor device types for Nvidia GPUs to `unsigned int`.

2016-06-07 Thread Kevin Klues
7849e518af448d9557ca4d6de4ccaba8bc572992 Diff: https://reviews.apache.org/r/48368/diff/ Testing --- GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues

Review Request 48366: Added auto-discovery of GPUs for Nvidia GPU support.

2016-06-07 Thread Kevin Klues
uot;*NVIDIA*" src/mesos-tests Thanks, Kevin Klues

Review Request 48367: Added test to verify that GPU auto-discovery works.

2016-06-07 Thread Kevin Klues
/ Testing --- GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues

Review Request 48374: Added class to share Nvidia-specific components between containerizers.

2016-06-07 Thread Kevin Klues
/48374/diff/ Testing --- GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues

Review Request 48375: Rearranged Nvidia GPU files to cleanup semantics for header inclusion.

2016-06-07 Thread Kevin Klues
iff: https://reviews.apache.org/r/48375/diff/ Testing --- GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues

Review Request 48376: Changed semantics for granting access to /dev/nvidiactl, etc.

2016-06-07 Thread Kevin Klues
/isolators/gpu/isolator.cpp 7849e518af448d9557ca4d6de4ccaba8bc572992 Diff: https://reviews.apache.org/r/48376/diff/ Testing --- GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues

Review Request 48363: Moved 'isolators/cgroups/devices/gpus' to 'isolators/gpu'.

2016-06-07 Thread Kevin Klues
b1e64b2fc5518463cd14e119f89e3cd298286052 Diff: https://reviews.apache.org/r/48363/diff/ Testing --- GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues

Review Request 48365: Bundled NVML headers for Nvidia GPU support.

2016-06-07 Thread Kevin Klues
-gdk.sh fcb075f75ef5dade6a05cfafcfb6b3d516764ae6 Diff: https://reviews.apache.org/r/48365/diff/ Testing --- GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues

Review Request 48364: Removed hard dependence on `libnvidia-ml.so` for Nvidia GPU support.

2016-06-07 Thread Kevin Klues
--- GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues

Review Request 48372: Updated `Containerizer::resources()` to use the `NvidiaGpuAllocator`.

2016-06-07 Thread Kevin Klues
/ Testing --- GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues

Review Request 48373: Integrated the `NvidiaGpuAllocator` into the `NvidiaGpuIsolator`.

2016-06-07 Thread Kevin Klues
f290e3c1d1114698039a505e972793dc325c7100 src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp 7849e518af448d9557ca4d6de4ccaba8bc572992 Diff: https://reviews.apache.org/r/48373/diff/ Testing --- GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests Thanks, Kevin Klues

Re: Review Request 48369: Fixed comment in Nvidia GPU device isolator.

2016-06-10 Thread Kevin Klues
://reviews.apache.org/r/48369/diff/ Testing --- Thanks, Kevin Klues

  1   2   3   4   5   6   7   8   9   10   >